Re: Plasma Browser Integration is in kdereview

[Albert Astals Cid]

El divendres, 9 de juny de 2017, a les 13:59:20 CEST, David Edmundson va 
escriure:
> >StaticMessages.sh
> 
> Didn't know about that, thanks.
> I've implemented it, but can only test so much. Can you send me scripty
> logs if it fails.

Seems to be working-ish?

Do you know if you can me it be a bit more quiet and only output errors on 
failure?

At the moment it says things like

kdereview_plasma-browser-integration /home/scripty/prod/trunk/l10n-kf5/
templates/messages/kdereview
.
start converting
--> reading file from: ./extension/_locales/en/messages.json
<-- writing file to: /home/scripty/prod/git-unstable-kf5/kdereview_plasma-
browser-integration/po/plasma-browser-extension.pot
file written
.
start converting
--> reading file from: /tmp/tmp.Nyi0t2h1Gt/pt.po
<-- writing file to: ./extension/_locales/pt/messages.json
file written
start converting
--> reading file from: /tmp/tmp.Nyi0t2h1Gt/sk.po
<-- writing file to: ./extension/_locales/sk/messages.json
file written


Which is a pain since what we do to detect scripty errors is diff the new run 
with the previous run to see what text changed and this is going to be a huge 
cause of diffs :/

Cheers,
  Albert

> 
> David

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

[Chris Holland]

Zren updated this revision to Diff 15400.
Zren added a comment.


  Semicolons... (I should install a linter)

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6188?vs=15398=15400

REVISION DETAIL
  https://phabricator.kde.org/D6188

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/package/contents/ui/main.qml

To: Zren, hein
Cc: anthonyfieroni, broulik, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

[Chris Holland]

Zren updated this revision to Diff 15398.
Zren added a comment.


  We don't really need to wait for folderViewLayer.ready before setting the 
bottom/right anchors anymore.
  Don't add extra spacing if we're not a containment (the desktop).
  Remove comment that's no longer applicable.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6188?vs=15393=15398

REVISION DETAIL
  https://phabricator.kde.org/D6188

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/package/contents/ui/main.qml

To: Zren, hein
Cc: anthonyfieroni, broulik, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

[Eike Hein]

hein added a comment.


  The widget should keep using the old behavior, grid-fitting is pretty awkward 
there (and I can already hear "my icons don't line up across widgets" 
complaints). This is really a desktop-specific special case motivated by people 
trying to put icons into opposing screen corners (or on edges), and being 
surprised to find no grid column on both ends. The widget doesn't support free 
icon placement, so it's not needed there.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6188

To: Zren, hein
Cc: anthonyfieroni, broulik, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6186: Implement software cursor in OpenGL backend

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6186

To: Kanedias, graesslin, davidedmundson
Cc: plasma-devel, kwin, #kwin, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, 
hein, lukas

D6186: Implement software cursor in OpenGL backend

[Oleg Chernovskiy]

Kanedias marked an inline comment as done.
Kanedias added a comment.


  I'm still unsure about cursor damage region (digging through cursor-related 
signals now)
  
  Cursor itself works fine, tested on kms Mesa 17.1.2 amdgpu (and in KRfb 
session)

INLINE COMMENTS

> davidedmundson wrote in scene_opengl.cpp:705
> i don't think you need these 3 lines, you're  not doing anything with this 
> vbo.
> 
> You do need vertex info from somewhere, but GLTexture has its own vbo.

Thanks, ripped it off

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6186

To: Kanedias, graesslin, davidedmundson
Cc: plasma-devel, kwin, #kwin, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, 
hein, lukas

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

[Eike Hein]

hein added a comment.


  The comment is mostly about the fact that this means you can no longer drop 
icons there then. Keep in mind that when the view is in columnar mode, 
horizontal overflow is (currently) the expected and correct behavior - if the 
folder is fuller than the screen can fill, the view has to start scrolling 
horizontally then.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6188

To: Zren, hein
Cc: anthonyfieroni, broulik, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6186: Implement software cursor in OpenGL backend

[Oleg Chernovskiy]

Kanedias updated this revision to Diff 15397.
Kanedias added a comment.


  Whoops... :)

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6186?vs=15396=15397

REVISION DETAIL
  https://phabricator.kde.org/D6186

AFFECTED FILES
  scene_opengl.cpp
  scene_opengl.h

To: Kanedias, graesslin, davidedmundson
Cc: plasma-devel, kwin, #kwin, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, 
hein, lukas

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

[Chris Holland]

Zren added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in FolderView.qml:538
> Why it used (6 * units.smallSpacing) it makes more space at bottom? It should 
> be same as iconwidth calculation, about me. I see you not change it, but it 
> should.

Fairly certain was `smallSpacing * 2` + `iconSize` + `smallSpacing * 2` + 
`defaultFont.height * lines` + `smallSpacing * 2`

Right now:

- `frame` has `y: root.useListViewMode ? 0 : units.smallSpacing`
- `frame` has `height: (icon.height + (2 * units.smallSpacing) + 
(label.lineCount * theme.mSize(theme.defaultFont).height) + (3 * 
units.smallSpacing));`
- `icon` has `topMargin: (2 * units.smallSpacing)`
- `label` has `anchors.topMargin: units.smallSpacing`

So it's actually:

  smallSpacing | frame | smallSpacing*2 | icon | smallSpacing | text | 
smallSpacing*2

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6188

To: Zren, hein
Cc: anthonyfieroni, broulik, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

[Chris Holland]

Zren added a comment.


  In https://phabricator.kde.org/D6188#115982, @hein wrote:
  
  > You didn't change the comment above the code you modified. Did you test 
that this is no longer an issue? If not, the comment needs adjusting.
  
  
  Ah, yeah, I should remove that comment. Beforehand, you were much more likely 
to create a horizontal scrollbar than the panel overlapping the icon by 1-2px.
  Someone who's panel was just barely overlapping the icons before this patch 
will lose a row of icons though. It's unfortunate, but they already had their 
icons shift around in Plasma 5.10.0

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6188

To: Zren, hein
Cc: anthonyfieroni, broulik, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6186: Implement software cursor in OpenGL backend

[Oleg Chernovskiy]

Kanedias updated this revision to Diff 15396.
Kanedias added a comment.


  - Made cursor texture local var with lazy-init
  - Made changes to support cursor shape update
  - Added cursor hotspot handling
  - Removed redundant vbo calls

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6186?vs=15364=15396

REVISION DETAIL
  https://phabricator.kde.org/D6186

AFFECTED FILES
  plugins/platforms/drm/drm_backend.h
  plugins/platforms/drm/drm_buffer_gbm.cpp
  plugins/platforms/drm/egl_gbm_backend.cpp
  scene_opengl.cpp
  scene_opengl.h

To: Kanedias, graesslin, davidedmundson
Cc: plasma-devel, kwin, #kwin, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, 
hein, lukas

D6201: [Desktop] Avoid binding loop on label.width by anchoring left/right to the frame

[Eike Hein]

hein requested changes to this revision.
hein added a comment.
This revision now requires changes to proceed.


  This most likely breaks the text position in the rename editor matching the 
label position.
  
  The rectangle selection code also tests for intersection with the icon and 
label rects to avoid irritation when accidentally selecting icons. The label 
rect being larger than the bounding box of the visible text breaks this 
optimization. It could maybe be reintroduced in the selection test code.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6201

To: Zren, hein
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6201: [Desktop] Avoid binding loop on label.width by anchoring left/right to the frame

[Chris Holland]

Zren created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Is there a reason we need to have the label to be implicitWidth?
  Right now, we get a binding loop on `width: Math.min(label.implicitWidth + 
units.smallSpacing, parent.width - units.smallSpacing * 4)`.
  

file:///home/chris/.local/share/plasma/plasmoids/org.kde.desktopcontainment/contents/ui/FolderItemDelegate.qml:288:17:
 QML Text: Binding loop detected for property "width"
  
  Also, the icon uses `units.smallSpacing` for the `leftMargin`, while the 
label currently uses  `2 * units.smallSpacing` for the `leftMargin`. I've 
changed it so they're both the same width since width is more important for the 
label.
  
  Before: F3782091: 2017-06-12___15-58-51.png 

  After: F3782089: 2017-06-12___15-54-42.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6201

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: Zren, hein
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

[Eike Hein]

hein added a comment.


  In https://phabricator.kde.org/D6188#115977, @Zren wrote:
  
  > Remove check for if we're already overflowing, using rtl layout, or if it's 
"arrange in columns/rows", since the ScrollView shouldn't be covered by panels.
  
  
  You didn't change the comment above the code you modified. Did you test that 
this is no longer an issue? If not, the comment needs adjusting.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6188

To: Zren, hein
Cc: anthonyfieroni, broulik, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

[Chris Holland]

Zren marked 2 inline comments as done.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6188

To: Zren, hein
Cc: anthonyfieroni, broulik, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

[Chris Holland]

Zren updated this revision to Diff 15393.
Zren added a comment.


  +readonly. +semicolons.
  Remove check for if we're already overflowing, using rtl layout, or if it's 
"arrange in columns/rows", since the ScrollView shouldn't be covered by panels.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6188?vs=15368=15393

REVISION DETAIL
  https://phabricator.kde.org/D6188

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/package/contents/ui/main.qml

To: Zren, hein
Cc: anthonyfieroni, broulik, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

[Chris Holland]

Zren added a comment.


  Oh now I remember why I used `scrollView.viewport`. We don't want to count 
the scrollbars as "extra" space. Notice in this screenshot it would perfectly 
fit another row, but the scrollbar made the area shorter.
  
  F3782025: 2017-06-12___13-17-47.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6188

To: Zren, hein
Cc: anthonyfieroni, broulik, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

[Chris Holland]

Zren added a comment.


  So removing the following two conditionals fixes it. I'm not sure why they 
are there. Right now it only stops at the panels if we're already overflowing.
  in `rightMargin`: `(folderViewLayer.view.overflowing || 
folderViewLayer.view.flow == GridView.FlowLeftToRight || 
folderViewLayer.view.layoutDirection == Qt.RightToLeft)`
  in `bottomMargin`: `(folderViewLayer.view.overflowing || 
folderViewLayer.view.flow == GridView.FlowTopToBottom)`
  
  F3782017: 2017-06-12___13-06-03.png 
  
  F3782019: 2017-06-12___13-06-41.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6188

To: Zren, hein
Cc: anthonyfieroni, broulik, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

[Chris Holland]

Zren added a comment.


  In https://phabricator.kde.org/D6188#115778, @broulik wrote:
  
  > About panels covering the contents, perhaps you want to take into account 
`plasmoid.availableScreenRect` but `root` already has a `margin` based on this, 
so maybe just use the `ScrollView`'s size instead of `viewport`.
  
  
  I think my faulty logic for using viewport was because ScrollView goes under 
the panel. See below where the the purple outline goes under the panel. I 
mistakenly thought `scrollView.width` was the **container's** width for some 
reason (it's not).
  
  F3781983: 2017-06-12___12-02-53.png 
  
  It seems there's an `anchor.fill: parent` chain from GridView => FolderView 
=> FolderViewLayer => all the way to the root object in `main.qml` which is a 
`FolderViewDropArea` with
  
FolderViewDropArea {

// preferredWidth(...) and preferredHeight(...) return -1 when 
(isContainment || !folderViewLayer.ready),
// so I've just expanded them as -1 for us. Basically they fill it will 
expand as far as it can.
width: -1
Layout.minimumWidth: -1
Layout.preferredWidth: 0
Plasmoid.switchWidth: -1

height: -1
Layout.minimumHeight: -1
Layout.preferredHeight: 0
Plasmoid.switchHeight: -1

anchors {
leftMargin: (isContainment && plasmoid.availableScreenRect) ? 
plasmoid.availableScreenRect.x : 0
topMargin: (isContainment && plasmoid.availableScreenRect) ? 
plasmoid.availableScreenRect.y : 0

// Don't apply the right margin if the folderView is in column mode 
and not overflowing.
// In this way, the last column remains droppable even if a small 
part of the icon is behind a panel.
rightMargin: folderViewLayer.ready && 
(folderViewLayer.view.overflowing || folderViewLayer.view.flow == 
GridView.FlowLeftToRight
|| folderViewLayer.view.layoutDirection == Qt.RightToLeft)
&& (isContainment && plasmoid.availableScreenRect) && parent
? parent.width - (plasmoid.availableScreenRect.x + 
plasmoid.availableScreenRect.width) : 0

// Same mechanism as the right margin but applied here to the 
bottom when the folderView is in row mode.
bottomMargin: folderViewLayer.ready && 
(folderViewLayer.view.overflowing || folderViewLayer.view.flow == 
GridView.FlowTopToBottom)
&& (isContainment && plasmoid.availableScreenRect) && parent
? parent.height - (plasmoid.availableScreenRect.y + 
plasmoid.availableScreenRect.height) : 0
}
}
  
  The final state for "arranged in rows" with a 30px bottom panel is:
  
qml: rightMargin folderViewLayer.ready true
qml: rightMargin folderViewLayer.view.overflowing false
qml: rightMargin flow == GridView.FlowLeftToRight true
qml: rightMargin layoutDirection == Qt.RightToLeft false
qml: rightMargin isContainment true
qml: rightMargin plasmoid.availableScreenRect QRect(0, 0, 1920, 1050)
qml: rightMargin parent ContainmentInterface(0x1d82390)
qml: rightMargin parent.width 1920
qml: rightMargin plasmoid.availableScreenRect.x 0
qml: rightMargin plasmoid.availableScreenRect.width 1920
qml: rightMargin return 0
  
  
  
qml: bottomMargin folderViewLayer.ready true
qml: bottomMargin folderViewLayer.view.overflowing false
qml: bottomMargin flow == GridView.FlowTopToBottom false
qml: bottomMargin return 0
  
  So it seems that it's hiccuping on `(folderViewLayer.view.overflowing || 
folderViewLayer.view.flow == GridView.FlowTopToBottom)`.
  
  For "arrange in columns" with a panel on the right (and bottom since I don't 
want to delete my main panel)
  
qml: bottomMargin folderViewLayer.ready true
qml: bottomMargin folderViewLayer.view.overflowing false
qml: bottomMargin flow == GridView.FlowTopToBottom true
qml: bottomMargin isContainment true
qml: bottomMargin plasmoid.availableScreenRect QRect(0, 0, 1838, 1050)
qml: bottomMargin parent ContainmentInterface(0x1d82390)
qml: bottomMargin parent.height 1080
qml: bottomMargin plasmoid.availableScreenRect.y 0
qml: bottomMargin plasmoid.availableScreenRect.height 1050
qml: bottomMargin return 30
  
  
  
qml: rightMargin folderViewLayer.ready true
qml: rightMargin folderViewLayer.view.overflowing false
qml: rightMargin flow == GridView.FlowLeftToRight false
qml: rightMargin layoutDirection == Qt.RightToLeft false
qml: rightMargin return 0
  
  So it's definitely the flow check. Gonna test without that condition in a bit.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6188

To: Zren, hein
Cc: anthonyfieroni, broulik, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6191: Simplify KNSBackend fetch logic

[Aleix Pol Gonzalez]

apol added a comment.


  Can you maybe extend the knsbackendtest to make sure we won't regress this?
  
  Thanks a lot!!!

INLINE COMMENTS

> KNSBackend.cpp:109
>  m_engine->init(m_name);
> +/// FIXME Set knscore's engine page size to 100 when we can depend on a 
> new enough frameworks
> +// m_engine->setPageSize(100);

Add an `#if KNEWSTUFF_VERSION_MAJOR==5 && KNEWSTUFF_VERSION_MINOR==36`

We always end up forgetting these fixme

> KNSBackend.cpp:130
> +// from the model, as they will be added again...
> +foreach(AbstractResource* res, m_resourcesByName.values()) {
> +resourceRemoved(res);

Good, maybe we should also delete them?
Can you see if the StandardUpdater is listening to resourceRemoved?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D6191

To: leinir, apol, #discover_software_store
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6183: [Digital Clock] Allow copying current date and time to clipboard

[Bernhard Schiffner]

bschiffner added a comment.


  Thanks for the feedback.
  It was integrated to my  best understanding and works for me.
  
  Why "^[0-9:]"? Sometimes it is just fun using the biggest sledgehammer. But 
in all respect: it is even gender neutral to be smashed this way!
  (I tried something to do it more politely but think of rigt to left 
languages, unknown literals etc. So I did this bet.)
  
  The QML / once a minute update problem (seconds all time 0) I didn't notice 
until now (4 PC/Notebook).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6183

To: bschiffner, #plasma, broulik
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6183: [Digital Clock] Allow copying current date and time to clipboard

[Bernhard Schiffner]

bschiffner updated this revision to Diff 15381.
bschiffner added a comment.


  Upating https://phabricator.kde.org/D6183: [Digital Clock] Allow copying 
current date and time to clipboard

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6183?vs=15348=15381

REVISION DETAIL
  https://phabricator.kde.org/D6183

AFFECTED FILES
  applets/digital-clock/package/contents/ui/DigitalClock.qml
  applets/digital-clock/package/contents/ui/main.qml
  applets/digital-clock/plugin/CMakeLists.txt
  applets/digital-clock/plugin/clipboardmenu.cpp
  applets/digital-clock/plugin/clipboardmenu.h
  applets/digital-clock/plugin/digitalclockplugin.cpp

To: bschiffner, #plasma, broulik
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D3209: [Notification Applet] Position dialog before showing it

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> notificationshelper.cpp:154
> +
> +popup->show();
> +});

at this point it still thinks the size is 0,0

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3209

To: broulik, #plasma, mck182, mart
Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D6192: Set Containments to have focus within the view

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:b0e8ea29fab4: Set Containments to have focus within the 
view (authored by davidedmundson).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6192?vs=15378=15379

REVISION DETAIL
  https://phabricator.kde.org/D6192

AFFECTED FILES
  src/plasmaquick/containmentview.cpp

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6192: Set Containments to have focus within the view

[Kai Uwe Broulik]

broulik added a comment.


  BUG: 381124

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6192

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6192: Set Containments to have focus within the view

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6192

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in FolderView.qml:538
> Why it used (6 * units.smallSpacing) it makes more space at bottom? It should 
> be same as iconwidth calculation, about me. I see you not change it, but it 
> should.

You can use padding (or right/top/bottom/left padding), we depend to Qt 5.6 now,

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6188

To: Zren, hein
Cc: anthonyfieroni, broulik, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> FolderView.qml:538
>  
> +property int iconHeight: (iconSize + 
> (theme.mSize(theme.defaultFont).height * plasmoid.configuration.textLines) + 
> (6 * units.smallSpacing))
> +property real extraHeight: calcExtraSpacing(iconHeight, 
> scrollArea.viewportHeight)

Why it used (6 * units.smallSpacing) it makes more space at bottom? It should 
be same as iconwidth calculation, about me. I see you not change it, but it 
should.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6188

To: Zren, hein
Cc: anthonyfieroni, broulik, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6192: Set Containments to have focus within the view

[David Edmundson]

davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Now that applets are their own focus scope (which makes sense) we've
  also made containments their own focus scope.
  
  We therefore need to also say the containment FocusScope has the focus
  within the view.

TEST PLAN
  Renamed something in folderview
  Used cursor nav

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6192

AFFECTED FILES
  src/plasmaquick/containmentview.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6191: Simplify KNSBackend fetch logic

[Dan Leinir Turthra Jensen]

leinir created this revision.
leinir added a project: Discover Software Store.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This code removes the custom pagination in KNSBackend in favour of using the 
internal pagination in KNSCore::Engine. It further removes the explicit call to 
request data, as this is already done by setting the search term, which caused 
duplicated results to be returned. Further, remove results already returned 
when KNS requests the view to be cleared, further reducing duplicate view 
entries.
  
  nb: The fact setting the search term starts a new search is undocumented, 
which will need fixing (some thorough documentation work is ongoing in kns as 
part of a gsoc project)

TEST PLAN
  Start Discover without patch, notice duplicates for most KNS sources
  Start discover with patch, notice no duplicate entries for KNS sources

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D6191

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSBackend.cpp
  libdiscover/backends/KNSBackend/KNSBackend.h

To: leinir, apol, #discover_software_store
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

[Eike Hein]

hein requested changes to this revision.
hein added a comment.
This revision now requires changes to proceed.


  Looks pretty good to me. It needs some polish as marked, but we should test 
it in master soon.

INLINE COMMENTS

> FolderView.qml:526
> +}
> +return extraSpacing
> +}

Coding style: missing termination semicolae (also elsewhere)

> FolderView.qml:539
> +property int iconHeight: (iconSize + 
> (theme.mSize(theme.defaultFont).height * plasmoid.configuration.textLines) + 
> (6 * units.smallSpacing))
> +property real extraHeight: calcExtraSpacing(iconHeight, 
> scrollArea.viewportHeight)
>  cellHeight: {

readonly (also elsewhere)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6188

To: Zren, hein
Cc: broulik, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6189: Add support for fortisslvpn

[Jan Grulich]

jgrulich created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This adds support for Fortigate SSL VPN which has been added recently to NM 
[1]. There is also a
  bug 355079 opened for missing support.
  
  [1] - 
https://blogs.gnome.org/lkundrak/2015/09/24/fortigate-ssl-vpn-support-added-to-networkmanager/

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  fortisslvpn

REVISION DETAIL
  https://phabricator.kde.org/D6189

AFFECTED FILES
  vpn/CMakeLists.txt
  vpn/fortisslvpn/CMakeLists.txt
  vpn/fortisslvpn/Messages.sh
  vpn/fortisslvpn/fortisslvpn.cpp
  vpn/fortisslvpn/fortisslvpn.h
  vpn/fortisslvpn/fortisslvpn.ui
  vpn/fortisslvpn/fortisslvpnadvanced.ui
  vpn/fortisslvpn/fortisslvpnauth.cpp
  vpn/fortisslvpn/fortisslvpnauth.h
  vpn/fortisslvpn/fortisslvpnauth.ui
  vpn/fortisslvpn/fortisslvpnwidget.cpp
  vpn/fortisslvpn/fortisslvpnwidget.h
  vpn/fortisslvpn/nm-fortisslvpn-service.h
  vpn/fortisslvpn/plasmanetworkmanagement_fortisslvpnui.desktop

To: jgrulich, lvsouza
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

Minutes Monday Plasma Meeting

[Sebastian Kügler]

The minutes of today's meeting!
-- 
sebas

http://www.kde.org | http://vizZzion.orgPresent: notmart, Sho, d_ed, romangg, kbroulik, bshah, sebas

notmart:
* some triaging
* breeze shadows work on wayland [pushed]
* kirigami gallery release on google play
* fix in extra-cmake-modules for deployment on android 
https://phabricator.kde.org/D6103
  Diff 6103 "scan the whole install folder for qml dependencies" [Closed] 
https://phabricator.kde.org/D6103
* fix wrong color on plasma toolbutton text on mouse over
* [wayland] make shadows work for windows 100%width or height (david's approach 
probably better tough)
* fix for an old sneaky plasma crash with a lot of duplicates 
https://bugs.kde.org/show_bug.cgi?id=378508
  KDE bug 378508 in plasmashell (Notifications) "when remove panel applet 
plasma crashed" [crash,FIXED] https://bugs.kde.org/show_bug.cgi?id=378508

Sho:
* [Simple Menu] Make sure initial arrow key press always selects first item
* [Simple Menu] Polished search experience to select (and keep selected) first 
search result while searching and allow activating by Enter/Return, no more 
arrow-down necessary
* [Simple Menu] Fixed auto-hide panels hosting Simple Menu not staying open 
while Simple Menu is open
* [Simple Menu] Synced Simple Menu's panel representation to Kicker's
** Fixes panel icon mouseover highlight; adds support for panel icon size hint
* [Simple Menu] Released v1.0.2
* [Kicker] Fixed not reacting to changes in the panel icon size hint in realtime
* [FV] Still hacking on new drop code (drop at position), probably reviewing 
this week
* [Frameworks] Changed panel icon default size in KIconTheme to 48, now 
matching the Breeze and Oxygen themes and the KCM code again
* [Other] Spent some time fixing QML warnings around plasma-workspace & 
plasma-desktop

d_ed:
So on the wayland front: I'm /still/ working on XDGV6
popups are a bit harder with everything
I've written the client and server in kwayland, and they work great against 
each other
The Qt QPA and kwin do not
and I don't know why, it just sits there waiting for kwin to do something
but I'm not really sure what, so I have a day of staring at logs to do :)
but other than it not working, it's moving forwards :)

romangg:
* I reapplied some lost patches yesterday from the hard reset to KWin's master 
branch by Eike and Rohan. Hope it's fine this way.

kbroulik:
* Did a couple of improvements to notifications/jobs, now exposes desktop file 
name, better grouping of jobs etc (VDG is also doing some design mockups and 
work, I'm assisting them when they have questions "can we do this" etc
* Will improve the Icon widget for websites, so that when you drop a http url 
in the panel, you get a nice launcher with favicon (D6163), perhaps also 
extract  and other metadata from it.
  Diff 6163 "[Icon Applet] Get favicon for website shortcuts" [Needs Review] 
https://phabricator.kde.org/D6163
* Plasma browser integration can now also control HTML5 audio. Works on some 
streaming websites I tested but not with all of them.
* Also added workaround for Chrome 59 which doesn't gracefully quit the host 
when you close the browser causing it to get stuck in a loop reading garbage 
from the socket (my xsession-errors file became 38 GiB because of that.. ;)
* I want to look into a "add to panel" or "add as launcher" thing for browser 
integration that will create a .desktop file for a website (Chrome can already 
do that "Add to desktop" in Extras menu, there's even a JS API to trigger that 
programmatically) and then add it to your panel/TM. Need to figure out a way 
for the user to choose where to place it (maybe even some fancy kwin thing 
where it minimizes all windows and then lets you pick like the color picker
 effect on wayland we have now?)
* I'm also on Qt 5.9 now on neon and noticed that kickoff's tabs don't properly 
animate anymore. Also KRunner seems to be morphed around by kwin now (dunno if 
this is a kwin issue or a Qt 5.9 bug). Other than that looking good!

bshah:
- [Halium] Got test_camera working : http://i.imgur.com/8Td2YVH.jpg
- [PlasmaMobile] halium based images can do calls and recieve calls : 
http://i.imgur.com/RaUKMy9.jpg (we are proper phone now! :p)
- [Halium] Writing documentation and etc for initial release 0.1
- [PlasmaMobile] Once halium have its initial release, we can publish initial 
halium based images

Riddell:
* Qt 5.9 is in KDE neon in the hidden testing repo, I'd appreciate people 
trying it and reporting issues and any opinions on whether I can put it into 
neon normal repos
* proposed release schedule until end of 2018 is up, let me know what you think 
https://community.kde.org/Schedules/Plasma_5


sebas:
- kscreen and other bug triaging
- sydney's data arena patch sent, got tested, works partly, needs another round 
or two and some thinking
- restarted work on refactoring the kscreen OSD, dialog positioning is screwed 
on X11, this will be fun :/
- discussed and rebooted the effort on Plasma's vision with 

Re: pager widget on kde 4.3.5

[Eike Hein]

Hi,

is there any reason why you guys need to use 4.3.5? It's over
seven years old ...


Cheers,
Eike

On 06/11/2017 08:25 PM, Shitrit, Shahaf wrote:
> Hey,
> I’m using the very useful pager widget on kde 4.3.5 .
> Unlike in previos kde version, there is a problem to see in which
> desktop I am at.
>  
> Please take a look:
> Previos version – can clearly see in which desktop I am:
>  
> New version – impossible to see the current desktop:
>  
>  
> Is there any way to configure the pager so it will be clear what is the
> current desktop?
>  
> It will be great, not only for me but also for my colleagues.
>  
> Thanks,
> Shahaf.
>  
> 
> -
> Intel Israel (74) Limited
> 
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
> 

D6141: make shadows work for windows 100%width or height

[Marco Martin]

mart added a comment.


  I like the approach david has taken in https://phabricator.kde.org/D6164

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6141

To: mart, #plasma, #kwin, graesslin
Cc: luebking, mvourlakos, davidedmundson, plasma-devel, kwin, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, 
lukas

D6164: Make shadows work for windows 100% width or height

[Marco Martin]

mart added a comment.


  +1

INLINE COMMENTS

> scene_opengl.cpp:2358
>  
> -const int width = qMax(topLeft.width(), bottomLeft.width()) +
> +const int width = qMax3(topLeft.width(), left.width(), 
> bottomLeft.width()) +
>qMax(top.width(), bottom.width()) +

oh, i get it now, i like that logic

> utils.h:205
> +template 
> +T qMax3(const T , const T , const T )
> +{

not sure about calling a local function qMax3, it would suggest it comes from 
qt.

maybe utilsMax3 or something without q

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6164

To: davidedmundson, #plasma
Cc: mart, plasma-devel, kwin, #kwin, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, lukas

pager widget on kde 4.3.5

[Shitrit, Shahaf]

Hey,
I'm using the very useful pager widget on kde 4.3.5 .
Unlike in previos kde version, there is a problem to see in which desktop I am 
at.

Please take a look:
Previos version - can clearly see in which desktop I am:


New version - impossible to see the current desktop:



Is there any way to configure the pager so it will be clear what is the current 
desktop?

It will be great, not only for me but also for my colleagues.

Thanks,
Shahaf.

-
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

D1350: [Digital Clock] Allow copying current date to clipboard

[Kai Uwe Broulik]

broulik abandoned this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1350

To: broulik, #plasma:_design, #plasma, davidedmundson
Cc: bschiffner, colomar, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

[Kai Uwe Broulik]

broulik added a comment.


  About panels covering the contents, perhaps you want to take into account 
`plasmoid.availableScreenRect` but `root` already has a `margin` based on this, 
so maybe just use the `ScrollView`'s size instead of `viewport`.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6188

To: Zren, hein
Cc: broulik, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6183: [Digital Clock] Allow copying current date and time to clipboard

[David Edmundson]

davidedmundson added a comment.


  It's a bit of a shame that we're mixing two data sources in the same applet, 
but I guess we're limited by whatever works.

INLINE COMMENTS

> clipboardmenu.cpp:83
> +s = time.toString(Qt::SystemLocaleLongDate);
> +s.replace(rx, "");
> +a = menu->addAction(s);

you're removing everything that isn't ':' or a number ? Why?

Does every locale use : as a separator?

> clipboardmenu.cpp:116
> +
> +QMenu *menu_cal = new QMenu;
> +menu_cal->clear();

lets not put POC in code that we want to merge.

Also, by your own comment later, this leaks.

> clipboardmenu.cpp:143
> +// QMenu cannot have QAction as parent and setMenu doesn't take ownership
> +connect(action, ::destroyed, this, [menu] {
> +menu->deleteLater();

We want "menu" not  "this" as the second context.

Otherwise if you delete the clipboardmenu class first, this leaks
If you delete the menu first, this crashes.

Neither should happen, but better to be safer.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6183

To: bschiffner, #plasma, broulik
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6183: [Digital Clock] Allow copying current date and time to clipboard

[Kai Uwe Broulik]

broulik added a comment.


  Thanks a lot for picking this up!
  
  I have some minor nitpicks below, otherwise looking very good. You don't need 
to mention "Fixes https://bugs.kde.org/show_bug.cgi?id=355190; in the commit 
message, the "BUG: 355190" already does this, also causes Bugzilla to 
auto-close the bug once committed, etc.
  
  The reason I did not finish/submit my original patch is that the time 
dataengine is updated only once every minute (unless you have seconds enabled) 
so when you open the menu the seconds will not be accurate but reflect the last 
time it was updated (usually being 0).
  
  I will try to figure out a way to force an update explicitly from QML, so we 
can finally have this in.

INLINE COMMENTS

> clipboardmenu.cpp:83
> +s = time.toString(Qt::SystemLocaleLongDate);
> +s.replace(rx, "");
> +a = menu->addAction(s);

Prefer `QString()` over an empty literal `""`

> clipboardmenu.cpp:116
> +
> +QMenu *menu_cal = new QMenu;
> +menu_cal->clear();

You don't need to create this menu here, `QMenu::addMenu(QString)` that you're 
using below already creates a new menu for you (basically just remove this and 
the next line).

Also, we typically use camel-case instead of underscores, eg. 
`otherCalendarsMenu`

> clipboardmenu.cpp:120
> +
> +/* Add ICU Calendars if QLocale is ready for
> +Chinese

That optimism ;)

> clipboardmenu.cpp:132
> +s = QString::number(m_currentDate.toMSecsSinceEpoch() / 1000);
> +a = menu_cal->addAction(s + ws + "(" + i18n("UNIX Time") + ")");
> +a->setData(s);

I would prefer having proper `i18n` with placeholders here (I think the word 
puzzles above are fine given the text itself cannot really be influenced by us, 
but here and below it should be:

  i18nc("placeholder is unix timestamp", "%1 (UNIX Time)", s);

(the `c` means "context", so the first string gives translators a bit of an 
explanation what this is about)

> clipboardmenu.cpp:140
> +
> +connect(menu, ::triggered, menu, l);
> +

You could just do the lambda inline here, I don't see `l` being used elsewhere

> clipboardmenu.cpp:143
> +// QMenu cannot have QAction as parent and setMenu doesn't take ownership
> +connect(action, ::destroyed, this, [menu] {
> +menu->deleteLater();

I know this is from the original code but I think you could optimize it to

  connect(action, ::destroyed, menu, ::deleteLater);

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6183

To: bschiffner, #plasma, broulik
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6145: Massively simplify the class DesktopPortal

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R838:45843db8d63a: Massively simplify the class DesktopPortal 
(authored by davidedmundson).

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6145?vs=15305=15369

REVISION DETAIL
  https://phabricator.kde.org/D6145

AFFECTED FILES
  src/access.cpp
  src/access.h
  src/appchooser.cpp
  src/appchooser.h
  src/desktopportal.cpp
  src/desktopportal.h
  src/email.cpp
  src/email.h
  src/filechooser.cpp
  src/filechooser.h
  src/inhibit.cpp
  src/inhibit.h
  src/notification.cpp
  src/notification.h
  src/print.cpp
  src/print.h
  src/xdg-desktop-portal-kde.cpp

To: davidedmundson, #plasma, jgrulich
Cc: apol, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart, lukas

D6186: Implement software cursor in OpenGL backend

[David Edmundson]

davidedmundson added a comment.


  > Is this the correct way of doing such stuff?
  
  Pretty much. 
  Seems a sensible patch, screen recording aside we could be using a GL on a 
different backend that can't do planes.
  
  The obvious optimisation is that we don't need to make the new cursor texture 
every time, but it can be a member var reset on cursorChanged()
  
  > Should cursor update be included in damage regions?
  
  I would have thought so. Though I can't see where scene_qpainter does it. 
(could be a bug there?)
  
  > How can I write an autotest for it?
  
  A lot of the GL stuff isn't autotested.  and even if you did write a test, 
our current CI infrastructure couldn't actually run it.

INLINE COMMENTS

> scene_opengl.cpp:705
> +
> +GLVertexBuffer* vbo = GLVertexBuffer::streamingBuffer();
> +vbo->reset();

i don't think you need these 3 lines, you're  not doing anything with this vbo.

You do need vertex info from somewhere, but GLTexture has its own vbo.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6186

To: Kanedias, graesslin, davidedmundson
Cc: plasma-devel, kwin, #kwin, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, 
hein, lukas

D6145: Massively simplify the class DesktopPortal

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Awesome!! I've tested all portals and they do work. Thanks a lot.
  
  Btw. next time if you would like to test portals you can use my test 
application https://github.com/grulja/flatpak-portal-test-kde. You just need to 
go to flatpak-build directory and run build.sh. Then import the repo to flatpak 
and run the app.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6145

To: davidedmundson, #plasma, jgrulich
Cc: apol, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart, lukas