D6495: Don't list KF5::WindowSystem in public libraries
This revision was automatically updated to reflect the committed changes. Closed by commit R242:f8de13c67421: Don't list KF5::WindowSystem in public libraries (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6495?vs=16153&id=16162 REVISION DETAIL https://phabricator.kde.org/D6495 AFFECTED FILES autotests/CMakeLists.txt src/plasmaquick/CMakeLists.txt To: davidedmundson, #plasma Cc: asturmlechner, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D3805: Per-activity favorites (Final, again?)
hein added a comment. Another crash, this time a while after running with migrated favourites: Thread 1 (Thread 0x7f8ef082cdc0 (LWP 8048)): [KCrash Handler] #6 0x7f8e44c0dcf8 in KAStatsFavoritesModel::Private::removeOldCachedEntries() const (this=0x40fc41c800) at /home/eike/devel/src/kde/workspace/plasma-desktop/applets/kicker/plugin/kastatsfavoritesmodel.cpp:122 #7 0x7f8e44c0c3e5 in KAStatsFavoritesModel::isFavorite(QString const&) const (this=this@entry=0x4f255b0, id=...) at /home/eike/devel/src/kde/workspace/plasma-desktop/applets/kicker/plugin/kastatsfavoritesmodel.cpp:310 #8 0x7f8e44c27299 in InvalidAppsFilterProxy::filterAcceptsRow(int, QModelIndex const&) const (this=0x7f5de90, source_row=, source_parent=...) at /home/eike/devel/src/kde/workspace/plasma-desktop/applets/kicker/plugin/recentusagemodel.cpp:94 #9 0x7f8efc2dab10 in QSortFilterProxyModelPrivate::create_mapping(QModelIndex const&) const (this=this@entry=0xb661410, source_parent=...) at /home/eike/devel/src/qt5/qtbase/src/corelib/itemmodels/qsortfilterproxymodel.cpp:343 #10 0x7f8efc2dc4b3 in QSortFilterProxyModel::rowCount(QModelIndex const&) const (this=, parent=...) at /home/eike/devel/src/qt5/qtbase/src/corelib/itemmodels/qsortfilterproxymodel.cpp:1878 #11 0x7f8efc2daad5 in QSortFilterProxyModelPrivate::create_mapping(QModelIndex const&) const (this=this@entry=0x6f620f0, source_parent=...) at /home/eike/devel/src/qt5/qtbase/src/corelib/itemmodels/qsortfilterproxymodel.cpp:340 #12 0x7f8efc2db9ea in QSortFilterProxyModelPrivate::update_source_sort_column() (this=this@entry=0x6f620f0) at /home/eike/devel/src/qt5/qtbase/src/corelib/itemmodels/qsortfilterproxymodel.cpp:470 #13 0x7f8efc2dc130 in QSortFilterProxyModelPrivate::_q_sourceLayoutChanged(QList const&, QAbstractItemModel::LayoutChangeHint) (this=0x6f620f0, sourceParents=..., hint=) at /home/eike/devel/src/qt5/qtbase/src/corelib/itemmodels/qsortfilterproxymodel.cpp:1374 #14 0x7f8efc2e03f3 in QSortFilterProxyModel::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (_o=, _c=, _id=, _a=) at .moc/moc_qsortfilterproxymodel.cpp:209 #15 0x7f8efc3422ba in QMetaObject::activate(QObject*, int, int, void**) (sender=0x7f5de90, signalOffset=, local_signal_index=local_signal_index@entry=3, argv=argv@entry=0x7ffd378f9b20) at /home/eike/devel/src/qt5/qtbase/src/corelib/kernel/qobject.cpp:3766 #16 0x7f8efc3429c7 in QMetaObject::activate(QObject*, QMetaObject const*, int, void**) (sender=, m=m@entry=0x7f8efc5d25e0 , local_signal_index=local_signal_index@entry=3, argv=argv@entry=0x7ffd378f9b20) at /home/eike/devel/src/qt5/qtbase/src/corelib/kernel/qobject.cpp:3628 #17 0x7f8efc2b4436 in QAbstractItemModel::layoutChanged(QList const&, QAbstractItemModel::LayoutChangeHint) (this=, _t1=..., _t2=) at .moc/moc_qabstractitemmodel.cpp:582 #18 0x7f8efc2dbfae in QSortFilterProxyModel::invalidate() () at /home/eike/devel/src/qt5/qtbase/src/corelib/itemmodels/qsortfilterproxymodel.cpp:2518 #19 0x7f8e44c262ec in InvalidAppsFilterProxy::connectNewFavoritesModel() (this=0x7f5de90) at /home/eike/devel/src/kde/workspace/plasma-desktop/applets/kicker/plugin/recentusagemodel.cpp:80 #20 0x7f8efc3423bc in QtPrivate::QSlotObjectBase::call(QObject*, void**) (a=0x7ffd378f9c50, r=0x7f5de90, this=0xb730b00) at ../../include/QtCore/../../../../qt5/qtbase/src/corelib/kernel/qobject_impl.h:101 #21 0x7f8efc3423bc in QMetaObject::activate(QObject*, int, int, void**) (sender=0xb722b10, signalOffset=, local_signal_index=, argv=) at /home/eike/devel/src/qt5/qtbase/src/corelib/kernel/qobject.cpp:3749 #22 0x7f8e44c3189e in AbstractModel::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (_o=, _c=, _id=, _a=0x7ffd378f9d60) at /home/eike/devel/build/kde/workspace/plasma-desktop/applets/kicker/kickerplugin_autogen/7RBZBFH7CH/moc_abstractmodel.cpp:224 #23 0x7f8eff690f1d in QQmlPropertyData::writeProperty(QObject*, void*, QFlags) const (flags=..., value=, target=, this=) at /home/eike/devel/src/qt5-build/qtbase/include/QtQml/5.9.1/QtQml/private/../../../../../../../qt5/qtdeclarative/src/qml/qml/qqmlpropertycache_p.h:320 #24 0x7f8eff690f1d in QObjectPointerBinding::write(QV4::Value const&, bool, QFlags) (this=0x5e357d0, result=..., isUndefined=, flags=...) at /home/eike/devel/src/qt5/qtdeclarative/src/qml/qml/qqmlbinding.cpp:585 #25 0x7f8eff692016 in QQmlNonbindingBinding::doUpdate(QQmlJavaScriptExpression::DeleteWatcher const&, QFlags, QV4::Scope&) (this=0x5e357d0, watcher=..., flags=..., scope=...) at /home/eike/devel/src/qt5/qtdeclarative/src/qml/qml/qqmlbinding.cpp:210 #26 0x7f8eff68ef73 in QQmlBinding::update(QFlags) (this=0x5e357d0, flags=...) at /home/eike/devel/src/qt5/qtdeclarative/src/qml/qml/qqmlbinding.cpp:167 #27 0x7f8eff69a7ab in QQmlObjectCreator::finalize(QQmlInstantiationInterrupt&) (this=0x5ab5490, int
D6472: Fix plasmashell.desktop hidden=true
davidedmundson abandoned this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6472 To: davidedmundson, #plasma Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6498: Don't list plasmashell in menus
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Actually read autostart code this time. It's unaffected. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D6498 AFFECTED FILES shell/org.kde.plasmashell.desktop To: davidedmundson, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6487: Applet: Rename MediaPlayer to MediaPlayerItem
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R97 Bluedevil BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D6487 To: drosca, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6488: Fix setting natural/inverted scroll mode for touchpad with libinput
This revision was automatically updated to reflect the committed changes. Closed by commit R119:8132e02bb8e8: Fix setting natural/inverted scroll mode for touchpad with libinput (authored by gladhorn). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6488?vs=16142&id=16156 REVISION DETAIL https://phabricator.kde.org/D6488 AFFECTED FILES kcms/touchpad/src/kcm/libinput/main.qml To: gladhorn, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6495: Don't list KF5::WindowSystem in public libraries
asturmlechner added a comment. Thanks, works for me! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6495 To: davidedmundson, #plasma Cc: asturmlechner, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6494: Drop unused dependencies KF5WindowSystem and KF5XmlGui
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R118 Plasma SDK BRANCH master REVISION DETAIL https://phabricator.kde.org/D6494 To: asturmlechner, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6495: Don't list KF5::WindowSystem in public libraries
davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY We don't use it in public API REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6495 AFFECTED FILES autotests/CMakeLists.txt src/plasmaquick/CMakeLists.txt To: davidedmundson, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6494: Drop unused dependencies KF5WindowSystem and KF5XmlGui
asturmlechner created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Depends on https://phabricator.kde.org/D6493 TEST PLAN Builds fine. REPOSITORY R118 Plasma SDK BRANCH master REVISION DETAIL https://phabricator.kde.org/D6494 AFFECTED FILES CMakeLists.txt engineexplorer/CMakeLists.txt engineexplorer/ktreeviewsearchline.cpp plasmoidviewer/CMakeLists.txt To: asturmlechner, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6469: Terminology fixes in KCMs: KDE-as-the-desktop -> Plasma
ltoscano updated this revision to Diff 16149. ltoscano added a comment. Remove a Plasma reference (generic session) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6469?vs=16097&id=16149 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6469 AFFECTED FILES kcms/autostart/advanceddialog.cpp kcms/autostart/autostart.cpp kcms/autostart/autostart.desktop kcms/componentchooser/emailclientconfig_ui.ui kcms/desktoppaths/globalpaths.cpp kcms/fonts/fonts.cpp kcms/keyboard/kcm_keyboard.ui kcms/keyboard/kcmmisc.cpp kcms/knotify/knotify.cpp To: ltoscano Cc: sebas, lukas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
D6488: Fix setting natural/inverted scroll mode for touchpad with libinput
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D6488 To: gladhorn, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6488: Fix setting natural/inverted scroll mode for touchpad with libinput
gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Copy and paste meant that the check box didn't work, thus under wayland no natural scroll direction was possible. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D6488 AFFECTED FILES kcms/touchpad/src/kcm/libinput/main.qml To: gladhorn, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6487: Applet: Rename MediaPlayer to MediaPlayerItem
drosca created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Recent change in QML broke the code where there was an item and model role both named MediaPlayer, which made it to show media player component for all devices. This fixes the issue and media player component is again visible only when media player is actually connected. TEST PLAN media player component now pops up only when it should REPOSITORY R97 Bluedevil BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D6487 AFFECTED FILES src/applet/package/contents/ui/DeviceItem.qml src/applet/package/contents/ui/MediaPlayer.qml src/applet/package/contents/ui/MediaPlayerItem.qml To: drosca, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
KWin 5.10.3.1 update
KWin has received an update to the 5.10.3 release. 5.10.3.1 contains a fix for https://bugs.kde.org/show_bug.cgi?id=381870 Freeze in KWin::checkGLError on startup which affects machines with an NVidia card. The change is https://commits.kde.org/kwin/aefb5f4dd9d41aa7377d56ece203089c73aefe07 https://www.kde.org/info/plasma-5.10.3.php kwin-5.10.3.1 4.4MB 199e3a2593e9e66bbd6521ee8a25a012003d15f6b4bf2f102c70b798c9abd03a
D6429: Remove deprecated plasmashell options
This revision was automatically updated to reflect the committed changes. Closed by commit R120:cb2eaef77eef: Remove deprecated plasmashell options (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6429?vs=15988&id=16138 REVISION DETAIL https://phabricator.kde.org/D6429 AFFECTED FILES shell/main.cpp To: davidedmundson, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
Re: [plasma-devel] Requesting an emergency Plasma 5.10.3.1 release
Am 2017-07-02 17:12, schrieb Jonathan Riddell: On Sat, Jul 01, 2017 at 07:15:42PM +0200, Martin Flöser wrote: This is a severe issue and thus I request an emergency release as soon as I have the patch ready. Yes can do, let me know when it should be done I just pushed: https://commits.kde.org/kwin/aefb5f4dd9d41aa7377d56ece203089c73aefe07 Please use this commit for KWin 5.10.3.1 - it is possible that the change does not fully fix the problem. We might end up in a compositor restart loop. Cheers Martin
D6464: Prevent endless loop in checkGLError due to GL_CONTEXT_LOST
This revision was automatically updated to reflect the committed changes. Closed by commit R108:aefb5f4dd9d4: Prevent endless loop in checkGLError due to GL_CONTEXT_LOST (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6464?vs=16088&id=16137 REVISION DETAIL https://phabricator.kde.org/D6464 AFFECTED FILES libkwineffects/kwinglutils.cpp To: graesslin, #kwin, #plasma, davidedmundson Cc: rikmills, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
D6484: emit runningActivityListChanged on activity creation
This revision was automatically updated to reflect the committed changes. Closed by commit R6:dce2a89774c6: emit runningActivityListChanged on activity creation (authored by mart). REPOSITORY R6 KActivities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6484?vs=16130&id=16134 REVISION DETAIL https://phabricator.kde.org/D6484 AFFECTED FILES src/lib/activitiescache_p.cpp To: mart, #plasma, ivan, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6459: Fix the National Geographic PoTD dataengine
garg added a comment. You can checkout the XML on http://www.nationalgeographic.com/photography/photo-of-the-day/ by just viewing the source :) I'm not aware of a crash in bugzilla, got a bug number? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D6459 To: garg, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6459: Fix the National Geographic PoTD dataengine
davidedmundson added a comment. Obviously this isn't the best fix, if they shuffle the XML about it won't work .. but if it makes things better so be it. Do you still have a copy of this broken XML? Is this related to the crash in XML parsing we see over bugzilla? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D6459 To: garg, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6484: emit runningActivityListChanged on activity creation
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Good work. REPOSITORY R6 KActivities BRANCH master REVISION DETAIL https://phabricator.kde.org/D6484 To: mart, #plasma, ivan, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6484: emit runningActivityListChanged on activity creation
mart added a reviewer: ivan. REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D6484 To: mart, #plasma, ivan Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6484: emit runningActivityListChanged on activity creation
mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY if an activity gets created and started immediately, runningActivityListChanged wasn't emitted, a symptom was the activitypager applet not updating the number of activities on activity creation, now emit this on setActivityInfo both when there wasn't such activity yet or the running status changes TEST PLAN activity pager immediately reacts to activity creation, other kactivities users still work REPOSITORY R6 KActivities BRANCH master REVISION DETAIL https://phabricator.kde.org/D6484 AFFECTED FILES src/lib/activitiescache_p.cpp To: mart, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6469: Terminology fixes in KCMs: KDE-as-the-desktop -> Plasma
sebas added a comment. Needs to smallish changes, then good to go in. INLINE COMMENTS > ltoscano wrote in emailclientconfig_ui.ui:12 > Do you mean keep KDE somehow? But "KDE desktop" is exactly what should go > away :) Yeah, exactly. The KDE should go away here. > lukas wrote in globalpaths.cpp:127 > Again, this should be desktop agnostic "whenever the session starts" is fine here. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6469 To: ltoscano Cc: sebas, lukas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
D6480: Fix tab bar layout key handling in RTL
This revision was automatically updated to reflect the committed changes. Closed by commit R242:06410e779b4f: Fix tab bar layout key handling in RTL (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6480?vs=16120&id=16121 REVISION DETAIL https://phabricator.kde.org/D6480 AFFECTED FILES src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml To: davidedmundson, #plasma, broulik Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6480: Fix tab bar layout key handling in RTL
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D6480 To: davidedmundson, #plasma, broulik Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6469: Terminology fixes in KCMs: KDE-as-the-desktop -> Plasma
ltoscano added inline comments. INLINE COMMENTS > lukas wrote in emailclientconfig_ui.ui:12 > I'd keep the old one as well, just for a better discoverability Do you mean keep KDE somehow? But "KDE desktop" is exactly what should go away :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6469 To: ltoscano Cc: lukas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D6480: Fix tab bar layout key handling in RTL
davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Current code will, when mirrored, treat all keys like they're the left key. BUG: 379894 TEST PLAN Ran plasma in RTL REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D6480 AFFECTED FILES src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml To: davidedmundson, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6469: Terminology fixes in KCMs: KDE-as-the-desktop -> Plasma
lukas added inline comments. INLINE COMMENTS > ltoscano wrote in autostart.cpp:75 > Should this be "Session" or "Plasma Session"? Aren't the settings changed > here valid for all desktops which follow the XDG spec? Yes, it should be valid for all DEs (I'd vote for "Session" only then) > emailclientconfig_ui.ui:12 > > - Kmail is the standard Mail program for the KDE > desktop. > + Kmail is the standard Mail program for the Plasma > desktop. > I'd keep the old one as well, just for a better discoverability > ltoscano wrote in globalpaths.cpp:127 > I explicitly wrote "Plasma" because this setting seems to be Plasma-specific. > Did I understand it correctly? Again, this should be desktop agnostic REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6469 To: ltoscano Cc: lukas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D3805: Per-activity favorites (Final, again?)
hein added a comment. Adding new favorites works. However, starting with the blank favorites I did the following: 1. Add a favorite on all activities 2. Add a favorite specific to the current activity 3. Add another favorite on all activities I've noticed that for both #2 and #3, the new favorite was inserted at the start of the favorites list. The unpatched behavior is to append rather than prepend new favorites. REVISION DETAIL https://phabricator.kde.org/D3805 To: ivan, mart, hein Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D3805: Per-activity favorites (Final, again?)
hein added a comment. Here's what I tried to do today: 1. Set up Kicker and Appdash with different favorites 2. Patch, install 3. Log out, log in Then I got the crash above. 4. Switch back to master, log out and back in, still have the two widgets with different faves 5. Log out 6. Build patch again 7. Delete kactivitymanager-statcrc and run the delete from ResourceLink SQL thingie 8. Log back in No crash this time. But: Neither Kicker nor Appdash have any favorites, nothing was migrated. REVISION DETAIL https://phabricator.kde.org/D3805 To: ivan, mart, hein Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D3805: Per-activity favorites (Final, again?)
hein added inline comments.
INLINE COMMENTS
> main.xml:48
> +
> + Are the favorites ported to use KActivitiesStats to allow
> per-activity favorites
> + false
Pedantic: Broken grammar
> SideBarItem.qml:59
> onActionClicked: {
> +console.log(actionId + "<-- this is the id");
> actionTriggered(actionId, actionArgument);
Not a fan of debug stuff that's not really understandable without context ...
lets take the console.log() calls out when finalizing the patch.
REVISION DETAIL
https://phabricator.kde.org/D3805
To: ivan, mart, hein
Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
D6443: [CurrentContainmentActionsModel] Add configurationChanged signal
davidedmundson added a comment. Can you please upload patches with arc otherwise we don't get to expand the context. Plugins have the lifespan of containment. (but could change as user toggles things) ConfigDlg lasts till it's quit This model is owned by the ContainmentConfigView. So you're right to question that, it's a good catch. But it's easily fixable, pass this a parent to configdlg - or just use two connect statements. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6443 To: broulik, #plasma Cc: davidedmundson, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D3805: Per-activity favorites (Final, again?)
hein added a comment. Reproducable crash: #0 0x7fff28407f06 in KAStatsFavoritesModel::Private::removeOldCachedEntries() const (this=0x3266e40) at /home/eike/devel/src/kde/workspace/plasma-desktop/applets/kicker/plugin/kastatsfavoritesmodel.cpp:130 #1 0x7fff284063e5 in KAStatsFavoritesModel::isFavorite(QString const&) const (this=this@entry=0x317fe70, id=...) at /home/eike/devel/src/kde/workspace/plasma-desktop/applets/kicker/plugin/kastatsfavoritesmodel.cpp:310 #2 0x7fff28421299 in InvalidAppsFilterProxy::filterAcceptsRow(int, QModelIndex const&) const (this=0x33c10b0, source_row=, source_parent=...) at /home/eike/devel/src/kde/workspace/plasma-desktop/applets/kicker/plugin/recentusagemodel.cpp:94 #3 0x718b5b10 in QSortFilterProxyModelPrivate::create_mapping(QModelIndex const&) const (this=this@entry=0x33c60a0, source_parent=...) at /home/eike/devel/src/qt5/qtbase/src/corelib/itemmodels/qsortfilterproxymodel.cpp:343 #4 0x718b74b3 in QSortFilterProxyModel::rowCount(QModelIndex const&) const (this=this@entry=0x33c10b0, parent=...) at /home/eike/devel/src/qt5/qtbase/src/corelib/itemmodels/qsortfilterproxymodel.cpp:1878 #5 0x7fff28409b4b in ForwardingModel::rowCount(QModelIndex const&) const (this=this@entry=0x33c54b0, parent=...) at /home/eike/devel/src/kde/workspace/plasma-desktop/applets/kicker/plugin/forwardingmodel.cpp:116 #6 0x7fff28409b4b in ForwardingModel::rowCount(QModelIndex const&) const (this=, parent=...) at /home/eike/devel/src/kde/workspace/plasma-desktop/applets/kicker/plugin/forwardingmodel.cpp:116 #7 0x74ca6948 in QQmlAdaptorModel::count() const (this=0x34c7068) at /home/eike/devel/src/qt5-build/qtbase/include/QtQml/5.9.1/QtQml/private/../../../../../../../qt5/qtdeclarative/src/qml/util/qqmladaptormodel_p.h:122 #8 0x74ca6948 in QQmlDelegateModel::componentComplete() (this=0x34c6290) at /home/eike/devel/src/qt5/qtdeclarative/src/qml/types/qqmldelegatemodel.cpp:338 #9 0x75816472 in QQuickItemView::componentComplete() (this=0x34c57a0) at /home/eike/devel/src/qt5/qtdeclarative/src/quick/items/qquickitemview.cpp:1509 #10 0x74c758bd in QQmlObjectCreator::finalize(QQmlInstantiationInterrupt&) (this=0x33f21c0, interrupt=...) at /home/eike/devel/src/qt5/qtdeclarative/src/qml/qml/qqmlobjectcreator.cpp:1236 #11 0x74bf7d44 in QQmlComponentPrivate::complete(QQmlEnginePrivate*, QQmlComponentPrivate::ConstructionState*) (enginePriv=0x843890, state=0x33f2170) at /home/eike/devel/src/qt5/qtdeclarative/src/qml/qml/qqmlcomponent.cpp:900 #12 0x74bf7e07 in QQmlComponentPrivate::completeCreate() (this=0x33f20d0) at /home/eike/devel/src/qt5/qtdeclarative/src/qml/qml/qqmlcomponent.cpp:936 #13 0x74c925a1 in QV4::QtObject::method_createQmlObject(QV4::BuiltinFunction const*, QV4::Scope&, QV4::CallData*) (scope=..., callData=) at /home/eike/devel/src/qt5/qtdeclarative/src/qml/qml/v8/qqmlbuiltinfunctions.cpp:1167 #14 0x74bd5fda in QV4::Object::call(QV4::Scope&, QV4::CallData*) const (d=0x7fffcf0006f0, scope=..., this=) at /home/eike/devel/src/qt5/qtdeclarative/src/qml/jsruntime/qv4object_p.h:372 #15 0x74bd5fda in QV4::Runtime::method_callProperty(QV4::ExecutionEngine*, int, QV4::CallData*) (engine=0x843da0, nameIndex=, callData=0x7fffcf0006f0) at /home/eike/devel/src/qt5/qtdeclarative/src/qml/jsruntime/qv4runtime.cpp:1102 Do I need to clean up anything? REVISION DETAIL https://phabricator.kde.org/D3805 To: ivan, mart, hein Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6403: get rid of manual window flags setting on controller
This revision was automatically updated to reflect the committed changes. Closed by commit R120:13aa418c2772: get rid of manual window flags setting on controller (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6403?vs=15905&id=16112 REVISION DETAIL https://phabricator.kde.org/D6403 AFFECTED FILES shell/panelconfigview.cpp To: mart, #plasma, davidedmundson Cc: mvourlakos, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6419: ping before close and focus gain
mart abandoned this revision. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6419 To: mart, #plasma, #kwin, davidedmundson, graesslin Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6472: Fix plasmashell.desktop hidden=true
davidedmundson added a comment. oh...that seems simpler! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6472 To: davidedmundson, #plasma Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D3805: Per-activity favorites (Final, again?)
ivan edited the test plan for this revision. REVISION DETAIL https://phabricator.kde.org/D3805 To: ivan, mart, hein Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D3805: Per-activity favorites (Final, again?)
ivan added a comment. True, I haven't updated the branch - had more than a few sub-branches since the last update. The diff here is the proposed solution for all my problems ;) The last comment was just that I've added the test to the review itself (the "Test Plan" part). REVISION DETAIL https://phabricator.kde.org/D3805 To: ivan, mart, hein Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D3805: Per-activity favorites (Final, again?)
hein added a comment. I'm a little confused by the last comment - the branch in the repo hasn't been updated in four months, so the new testing location seems to be the diff again, yet there's a "I added a test" comment with no diff change ... :) Anyways, I'll review the diff here. REVISION DETAIL https://phabricator.kde.org/D3805 To: ivan, mart, hein Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
