D6459: Fix the National Geographic PoTD dataengine
garg added a comment. Can this also go into the next 5.10 release? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D6459 To: garg, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6498: Don't list plasmashell in menus
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D6498 To: davidedmundson, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6487: Applet: Rename MediaPlayer to MediaPlayerItem
This revision was automatically updated to reflect the committed changes. Closed by commit R97:94ff9f296b6e: Applet: Rename MediaPlayer to MediaPlayerItem (authored by drosca). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6487?vs=16141&id=16165#toc REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6487?vs=16141&id=16165 REVISION DETAIL https://phabricator.kde.org/D6487 AFFECTED FILES src/applet/package/contents/ui/DeviceItem.qml src/applet/package/contents/ui/MediaPlayer.qml src/applet/package/contents/ui/MediaPlayerItem.qml To: drosca, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
Minutes Monday Plasma Hangout
Here we go!
--
sebas
http://www.kde.org | http://vizZzion.orgPlasma Team meeting, 20-30-2017
Present: kbroulik, Sho, notmart, d_ed, bshah, sebas
kbroulik:
* Implemented a couple of wishlist entries in plasmashell ("Open containing
folder" button for image selector in wallpaper; "show apps by name" option also
for the right-click launcher action in plasma)
* Fixed KRDB saving wrong font for pure Qt4 apps due to it being
non-desktopSettingsAware
* Made JS injected by plasma browser integration more self-contained reducing
likelihood of it interfering with "special" websites
Nothing in particular planned for this weeks, probably generic bug
triaging/fixing
Sho:
* [FV] After much code reading and pain found a one-line fix for the KIO issues
causing icon position loss on rename and other problems
* [FV] Added missing standard keyboard shortcut for refresh
* [TM] Close to fix for often-reported grouping proxy crash
* [Launchers] Testing latest revision of Ivan's KAStats-based favorites:
Migration still a fail for me currently, otherwise it's shaping up very nicely,
feels like we're getting close
* [Other] Helped Whonix with systray scripting stuff
* [Other] Working on Akademy talk, decided to write the presentation in QML and
embed the demos (including some of the stuff I just linked before meeting) into
slides ...
* [Other] Upgraded to F26, had to rebuild everything after, Qt build had issues
as usual
* [Personal] Got a raging throat ache today, clearly coming down with something
d_ed:
* I diagnosed the QQmlBindign::getPropertyData crash with a potential patch
submitted
* whislt trying to unit test krunner, I found none of it works how it's meant to
* I hope to update that DBus krunner patch with a unit test and more changes
this week
notmart:
* triaging
* some refinements in kirigami pull down to refresh lists
* get rid of manual window flags setting on panel controller, as causes a weird
regression on Qt 5.9 (broken click to dismiss)
* some testing of david's xdgv6 branches
* wire up xdgv6's ping to kwin: D6418 and D6419 have been pushed into david's
xdgv6 branches in kwayland and kwin
Diff 6418 "[XDGV6] manage every ping sent" [Closed]
https://phabricator.kde.org/D6418
Diff 6419 "ping before close and focus gain" [Abandoned]
https://phabricator.kde.org/D6419
* usual gscoc management for koko, shaping up nicely
* solve panel stuttering when repositioning with the controller on wayland:
D6455 "position the shellsurface immediately" it still seems quite slow with a
mouse but very fast on touchscreen for some reasons
Diff 6455 "position the shellsurface immediately" [Needs Review]
https://phabricator.kde.org/D6455
* kirigami is now in frameworks: will be in next release, will probably skip
this month's one, in for august
* https://codereview.qt-project.org/#/c/195704/ continues its agony in the qt
review process limbo, getting frustrating
bshah:
- Working on halium-7.1
- halium-7.1 opens up interesting opportunities like we can target higher end
devices like Oneplus 3T and Oneplus 5.
- Last week worked on getting android container and plasma mobile working
- android container working : http://i.imgur.com/O7yr1rN.jpg
- plasma mobile working : http://i.imgur.com/snbFDzZ.jpg
- Working on getting flashable images for it, hopefully finished in next hour.
- Working on announcement of halium 7.1 and documentation
sebas:
* Work on kscreen OSD branch https://phabricator.kde.org/D3598
* then continue on kscreen's new UI
* Move Plasma Vision discussion forward
D3805: Per-activity favorites (Final, again?)
hein added a comment. After the crash, the re-added Appdash seems to have the same favorites as the old Appdash instance had, which is still not the superset of the pre-migration favorites or anything, nor the same favorites as the Kickoff. REVISION DETAIL https://phabricator.kde.org/D3805 To: ivan, mart, hein Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D3805: Per-activity favorites (Final, again?)
hein added a comment. I get the crash also when removing and re-adding Appdash: Thread 1 (Thread 0x7f6573ed8dc0 (LWP 3060)): [KCrash Handler] #6 0x034d3d70 in () #7 0x7f64c813bb0c in KAStatsFavoritesModel::Private::data(QModelIndex const&, int) const (role=266, index=..., this=0x2e1a8c0) at /home/eike/devel/src/kde/workspace/plasma-desktop/applets/kicker/plugin/kastatsfavoritesmodel.cpp:159 #8 0x7f64c813bb0c in KAStatsFavoritesModel::Private::removeOldCachedEntries() const (this=0x2e1a8c0) at /home/eike/devel/src/kde/workspace/plasma-desktop/applets/kicker/plugin/kastatsfavoritesmodel.cpp:123 #9 0x7f64c81393e5 in KAStatsFavoritesModel::isFavorite(QString const&) const (this=this@entry=0x444d0d0, id=...) at /home/eike/devel/src/kde/workspace/plasma-desktop/applets/kicker/plugin/kastatsfavoritesmodel.cpp:310 #10 0x7f64c8154299 in InvalidAppsFilterProxy::filterAcceptsRow(int, QModelIndex const&) const (this=0x46237c0, source_row=, source_parent=...) at /home/eike/devel/src/kde/workspace/plasma-desktop/applets/kicker/plugin/recentusagemodel.cpp:94 #11 0x7f657f986b10 in QSortFilterProxyModelPrivate::create_mapping(QModelIndex const&) const (this=this@entry=0x4838690, source_parent=...) at /home/eike/devel/src/qt5/qtbase/src/corelib/itemmodels/qsortfilterproxymodel.cpp:343 #12 0x7f657f9884b3 in QSortFilterProxyModel::rowCount(QModelIndex const&) const (this=this@entry=0x46237c0, parent=...) at /home/eike/devel/src/qt5/qtbase/src/corelib/itemmodels/qsortfilterproxymodel.cpp:1878 #13 0x7f64c813cb4b in ForwardingModel::rowCount(QModelIndex const&) const (this=this@entry=0x44d8db0, parent=...) at /home/eike/devel/src/kde/workspace/plasma-desktop/applets/kicker/plugin/forwardingmodel.cpp:116 #14 0x7f64c813cb4b in ForwardingModel::rowCount(QModelIndex const&) const (this=, parent=...) at /home/eike/devel/src/kde/workspace/plasma-desktop/applets/kicker/plugin/forwardingmodel.cpp:116 #15 0x7f6582d77948 in QQmlAdaptorModel::count() const (this=0x35c4338) at /home/eike/devel/src/qt5-build/qtbase/include/QtQml/5.9.1/QtQml/private/../../../../../../../qt5/qtdeclarative/src/qml/util/qqmladaptormodel_p.h:122 #16 0x7f6582d77948 in QQmlDelegateModel::componentComplete() (this=0x34b7b70) at /home/eike/devel/src/qt5/qtdeclarative/src/qml/types/qqmldelegatemodel.cpp:338 #17 0x7f65838e7472 in QQuickItemView::componentComplete() (this=0x34b78c0) at /home/eike/devel/src/qt5/qtdeclarative/src/quick/items/qquickitemview.cpp:1509 REVISION DETAIL https://phabricator.kde.org/D3805 To: ivan, mart, hein Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D3805: Per-activity favorites (Final, again?)
hein added a comment. Another full test write up. Ivan informed in an email that for a clean slate test, in addition to the SQL deletion and deleting kactivitymanager-statsrc, also favoritesPortedToKAstats=true needs to be removed from all places in appletsrc, so I did another test run. Test setup: 1. Two activities are set up 2. build git master 3. log out 4. from a tty, make a clean slate (SQL, delete appletsrc, delete statsrc) 5. log in, add an Appdash widget in addition to the default Kickoff 6. in both Kickoff and Appdash, add two more favorites in addition to the default set, making sure it's different extra favorites in each 7. in Kickoff, drag the first default favorite (Firefox for me) inbetween the two manually added faves 8. in Appdash, do the same with the second default favorite (System Settings) 9. log out 10. build the patch, log in What I expected: - All widgets having somehow the superset of the favorites of all widgets pre-migration so no favorites are los - All activities being initialized to the same migration result - Favorite order kinda-sorta somehow reflecting the pre-migration state of things What I actually got: - Kickoff had the same favorites as pre-migration, none of the Appdash ones, and in the pre-migration order - Appdash had thesame favorites as pre-migration, but the manually repositioned System Settings favorite somehow moved one position up in front of the two manually added extra faves - In the second activity, Appdash has no favorites at all - Kickoff in the second activity seems to have the same ones as in the first activity, i.e. also missing any Appdash ones (but I forgot to check this in the first login, I think I logged out/in again since ... but I did no more changes, so I'm guessing no reason it would have changed with more logout/login cycles) Additionally, if I now add new favorite to all activities in Appdash in the first activity, it's inserted in the middle of the list before System Settings and the two previously pre-migration manually-added extra favorites. In Kickoff, it seems to append as expected. To conclude, the migration results seem broken and random, with different results by widget and activity, and adding favorites is similarly weird. REVISION DETAIL https://phabricator.kde.org/D3805 To: ivan, mart, hein Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
