[Powerdevil] [Bug 382105] Power devil crash dès la sortie de veille

2017-07-07 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=382105

Christoph Feck  changed:

   What|Removed |Added

   Severity|normal  |crash

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 382105] Power devil crash dès la sortie de veille

2017-07-07 Thread kristof
https://bugs.kde.org/show_bug.cgi?id=382105

--- Comment #1 from kristof  ---
Application: org_kde_powerdevil ()

Qt Version: 5.6.1
Frameworks Version: 5.35.0
Operating System: Linux 4.8.0-58-generic x86_64
Distribution: Linux Mint 18.2 Sonya

-- Information about the crash:


The crash can be reproduced sometimes.

-- Backtrace:
Application: org_kde_powerdevil (org_kde_powerdevil), signal: Segmentation
fault
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[Current thread is 1 (Thread 0x7f35b46fd940 (LWP 2636))]

Thread 5 (Thread 0x7f359cac0700 (LWP 2726)):
#0  0x7f35b2d2670d in poll () at ../sysdeps/unix/syscall-template.S:84
#1  0x7f35ad8f038c in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x7f35ad8f0712 in g_main_loop_run () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x7f359d5aa9d6 in ?? () from /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
#4  0x7f35ad916bb5 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#5  0x7f35aea6a6ba in start_thread (arg=0x7f359cac0700) at
pthread_create.c:333
#6  0x7f35b2d323dd in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 4 (Thread 0x7f359d2c1700 (LWP 2725)):
#0  0x7f35ad8f03f0 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#1  0x7f35ad8f049c in g_main_context_iteration () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x7f35ad8f04d9 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x7f35ad916bb5 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#4  0x7f35aea6a6ba in start_thread (arg=0x7f359d2c1700) at
pthread_create.c:333
#5  0x7f35b2d323dd in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 3 (Thread 0x7f359e8ef700 (LWP 2723)):
#0  __libc_enable_asynccancel () at
../sysdeps/unix/sysv/linux/x86_64/cancellation.S:65
#1  0x7f35b2d26702 in poll () at ../sysdeps/unix/syscall-template.S:84
#2  0x7f35ad8f038c in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x7f35ad8f049c in g_main_context_iteration () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#4  0x7f35b364e37b in
QEventDispatcherGlib::processEvents(QFlags) ()
from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#5  0x7f35b35f6ffa in
QEventLoop::exec(QFlags) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#6  0x7f35b341f9e4 in QThread::exec() () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#7  0x7f35b4811515 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5DBus.so.5
#8  0x7f35b3424808 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#9  0x7f35aea6a6ba in start_thread (arg=0x7f359e8ef700) at
pthread_create.c:333
#10 0x7f35b2d323dd in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 2 (Thread 0x7f359f96e700 (LWP 2712)):
#0  0x7f35b2d2670d in poll () at ../sysdeps/unix/syscall-template.S:84
#1  0x7f35b0b4cc62 in poll (__timeout=-1, __nfds=1, __fds=0x7f359f96db80)
at /usr/include/x86_64-linux-gnu/bits/poll2.h:46
#2  _xcb_conn_wait (c=c@entry=0x1a7bdf0, cond=cond@entry=0x1a7be30,
vector=vector@entry=0x0, count=count@entry=0x0) at ../../src/xcb_conn.c:459
#3  0x7f35b0b4e8d7 in xcb_wait_for_event (c=0x1a7bdf0) at
../../src/xcb_in.c:693
#4  0x7f35a1ecfd29 in ?? () from
/usr/lib/x86_64-linux-gnu/libQt5XcbQpa.so.5
#5  0x7f35b3424808 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#6  0x7f35aea6a6ba in start_thread (arg=0x7f359f96e700) at
pthread_create.c:333
#7  0x7f35b2d323dd in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 1 (Thread 0x7f35b46fd940 (LWP 2636)):
[KCrash Handler]
#6  0x7f35b4262563 in ?? () from
/usr/lib/x86_64-linux-gnu/libpowerdevilcore.so.2
#7  0x7f35b425a104 in PowerDevil::Core::onResumingFromIdle() () from
/usr/lib/x86_64-linux-gnu/libpowerdevilcore.so.2
#8  0x7f35b425cb26 in PowerDevil::Core::loadProfile(bool) () from
/usr/lib/x86_64-linux-gnu/libpowerdevilcore.so.2
#9  0x7f35b425f9f8 in
PowerDevil::Core::onAcAdapterStateChanged(PowerDevil::BackendInterface::AcAdapterState)
() from /usr/lib/x86_64-linux-gnu/libpowerdevilcore.so.2
#10 0x7f35b427e98b in ?? () from
/usr/lib/x86_64-linux-gnu/libpowerdevilcore.so.2
#11 0x7f35b3625b71 in QMetaObject::activate(QObject*, int, int, void**) ()
from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#12 0x7f35b427d7be in
PowerDevil::BackendInterface::acAdapterStateChanged(PowerDevil::BackendInterface::AcAdapterState)
() from /usr/lib/x86_64-linux-gnu/libpowerdevilcore.so.2
#13 0x7f359decdab2 in PowerDevilUPowerBackend::slotPropertyChanged() ()
from
/usr/lib/x86_64-linux-gnu/qt5/plugins/kf5/powerdevil/powerdevilupowerbackend.so
#14 0x7f359dede194 in ?? () from
/usr/lib/x86_64-linux-gnu/qt5/plugins/kf5/powerdevil/powerdevilupowerbackend.so
#15 0x7f359dede6a5 in
PowerDevilUPowerBackend::qt_metacall(QMetaObject::Call, int, void**) () from
/usr/lib/x86_64-linux-gnu/qt5/plugins/kf5/powerdevil/powerdevilupowerbackend.so
#16 0x7f35b481d013 in ?? () from 

[Powerdevil] [Bug 382105] New: Power devil crash dès la sortie de veille

2017-07-07 Thread kristof
https://bugs.kde.org/show_bug.cgi?id=382105

Bug ID: 382105
   Summary: Power devil crash dès la sortie de veille
   Product: Powerdevil
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: kris...@agiliadev.fr
  Target Milestone: ---

Application: org_kde_powerdevil ()

Qt Version: 5.6.1
Frameworks Version: 5.35.0
Operating System: Linux 4.8.0-58-generic x86_64
Distribution: Linux Mint 18.2 Sonya

-- Information about the crash:


The crash can be reproduced sometimes.

-- Backtrace:
Application: org_kde_powerdevil (org_kde_powerdevil), signal: Segmentation
fault
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[Current thread is 1 (Thread 0x7f35b46fd940 (LWP 2636))]

Thread 5 (Thread 0x7f359cac0700 (LWP 2726)):
#0  0x7f35b2d2670d in poll () at ../sysdeps/unix/syscall-template.S:84
#1  0x7f35ad8f038c in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x7f35ad8f0712 in g_main_loop_run () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x7f359d5aa9d6 in ?? () from /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
#4  0x7f35ad916bb5 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#5  0x7f35aea6a6ba in start_thread (arg=0x7f359cac0700) at
pthread_create.c:333
#6  0x7f35b2d323dd in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 4 (Thread 0x7f359d2c1700 (LWP 2725)):
#0  0x7f35ad8f03f0 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#1  0x7f35ad8f049c in g_main_context_iteration () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x7f35ad8f04d9 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x7f35ad916bb5 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#4  0x7f35aea6a6ba in start_thread (arg=0x7f359d2c1700) at
pthread_create.c:333
#5  0x7f35b2d323dd in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 3 (Thread 0x7f359e8ef700 (LWP 2723)):
#0  __libc_enable_asynccancel () at
../sysdeps/unix/sysv/linux/x86_64/cancellation.S:65
#1  0x7f35b2d26702 in poll () at ../sysdeps/unix/syscall-template.S:84
#2  0x7f35ad8f038c in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x7f35ad8f049c in g_main_context_iteration () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#4  0x7f35b364e37b in
QEventDispatcherGlib::processEvents(QFlags) ()
from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#5  0x7f35b35f6ffa in
QEventLoop::exec(QFlags) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#6  0x7f35b341f9e4 in QThread::exec() () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#7  0x7f35b4811515 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5DBus.so.5
#8  0x7f35b3424808 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#9  0x7f35aea6a6ba in start_thread (arg=0x7f359e8ef700) at
pthread_create.c:333
#10 0x7f35b2d323dd in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 2 (Thread 0x7f359f96e700 (LWP 2712)):
#0  0x7f35b2d2670d in poll () at ../sysdeps/unix/syscall-template.S:84
#1  0x7f35b0b4cc62 in poll (__timeout=-1, __nfds=1, __fds=0x7f359f96db80)
at /usr/include/x86_64-linux-gnu/bits/poll2.h:46
#2  _xcb_conn_wait (c=c@entry=0x1a7bdf0, cond=cond@entry=0x1a7be30,
vector=vector@entry=0x0, count=count@entry=0x0) at ../../src/xcb_conn.c:459
#3  0x7f35b0b4e8d7 in xcb_wait_for_event (c=0x1a7bdf0) at
../../src/xcb_in.c:693
#4  0x7f35a1ecfd29 in ?? () from
/usr/lib/x86_64-linux-gnu/libQt5XcbQpa.so.5
#5  0x7f35b3424808 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#6  0x7f35aea6a6ba in start_thread (arg=0x7f359f96e700) at
pthread_create.c:333
#7  0x7f35b2d323dd in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 1 (Thread 0x7f35b46fd940 (LWP 2636)):
[KCrash Handler]
#6  0x7f35b4262563 in ?? () from
/usr/lib/x86_64-linux-gnu/libpowerdevilcore.so.2
#7  0x7f35b425a104 in PowerDevil::Core::onResumingFromIdle() () from
/usr/lib/x86_64-linux-gnu/libpowerdevilcore.so.2
#8  0x7f35b425cb26 in PowerDevil::Core::loadProfile(bool) () from
/usr/lib/x86_64-linux-gnu/libpowerdevilcore.so.2
#9  0x7f35b425f9f8 in
PowerDevil::Core::onAcAdapterStateChanged(PowerDevil::BackendInterface::AcAdapterState)
() from /usr/lib/x86_64-linux-gnu/libpowerdevilcore.so.2
#10 0x7f35b427e98b in ?? () from
/usr/lib/x86_64-linux-gnu/libpowerdevilcore.so.2
#11 0x7f35b3625b71 in QMetaObject::activate(QObject*, int, int, void**) ()
from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#12 0x7f35b427d7be in
PowerDevil::BackendInterface::acAdapterStateChanged(PowerDevil::BackendInterface::AcAdapterState)
() from /usr/lib/x86_64-linux-gnu/libpowerdevilcore.so.2
#13 0x7f359decdab2 in PowerDevilUPowerBackend::slotPropertyChanged() ()
from

D1231: Add Remote Access interface to KWayland

2017-07-07 Thread Oleg Chernovskiy
Kanedias added a comment.


  I'll get rid of the fakeinput-related changes and test it with KRfb tomorrow.
  
  @davidedmundson , can you test this with multiple outputs?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1231

To: Kanedias, graesslin, davidedmundson
Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas


D1231: Add Remote Access interface to KWayland

2017-07-07 Thread Oleg Chernovskiy
Kanedias updated this revision to Diff 16318.
Kanedias added a comment.


  Added wl_output reference for buffers as requested by @davidedmundson and 
@graesslin

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1231?vs=15553=16318

REVISION DETAIL
  https://phabricator.kde.org/D1231

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_remote_access.cpp
  src/client/CMakeLists.txt
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/protocols/remote-access.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/remote_access.cpp
  src/client/remote_access.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h
  src/server/remote_access_interface.cpp
  src/server/remote_access_interface.h
  src/server/remote_access_interface_p.h
  src/tools/mapping.txt
  src/tools/testserver/testserver.cpp

To: Kanedias, graesslin, davidedmundson
Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas


[Breeze] [Bug 381407] SDDM's Breeze theme should have a prettier background than just a flat blue color

2017-07-07 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=381407

--- Comment #3 from Nate Graham  ---
Ah, you;re right. I still think it's weird to have just an ugly plain blue
background for both, but I guess my lone opinion doesn't carry much weight, and
it *is* customizable.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D6554: [Plasma Dialog] Fix flag condition

2017-07-07 Thread David Edmundson
davidedmundson added a comment.


  Your description doesn't match the code
  
  > This didn't work when other flags,, such as WindowStaysOnTopHint were 
present.
  
  & Flag is the same as TestFlag()
  
  From what I can tell, you've changed:
  
  if (!tooltipFlag && !notification)
  into if(!   (tooltipFlag && !notification)
  
  which is quite possibly correct and valid, but it doesn't match what you said.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6554

To: broulik, #plasma, mart
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas


D6554: [Plasma Dialog] Fix flag condition

2017-07-07 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6554

To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D6555: [Applet Alternatives] Set applet status to RequiresAttentionStatus while open

2017-07-07 Thread Kai Uwe Broulik
broulik edited the test plan for this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6555

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas


D6555: [Applet Alternatives] Set applet status to RequiresAttentionStatus while open

2017-07-07 Thread Kai Uwe Broulik
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This ensures the panel stays visible while applet alternatives dialog is open.
  It also works around a quirk in Plasma Dialog which won't show if 
visualParent is in a auto-hidden panel.
  
  BUG: 347855
  BUG: 352459

TEST PLAN
  Opened applet alternatives for TM in auto hidden panel, alternatives showed 
up and kept panel open. Panel auto-hid again once closed. Before the 
alternative dialog wouldn't even show up.
  
  You get a brief flicker of the panel starting to hide while the QML is being 
processed but it's an improvement over the status quo in any way.
  
  I tried to figure out why Dialog behaves weird (if I didn't set visualParent 
to `alternativesHelper.applet` which is in an auto-hidden panel it worked) but 
I got lost in there. I know that the dialog's position was properly determined 
but then somewhere it got confused.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6555

AFFECTED FILES
  shell/alternativeshelper.cpp
  shell/alternativeshelper.h

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas


D6554: [Plasma Dialog] Fix flag condition

2017-07-07 Thread Kai Uwe Broulik
broulik edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6554

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D6554: [Plasma Dialog] Fix flag condition

2017-07-07 Thread Kai Uwe Broulik
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  The code wants to check whether we're not a tooltip. This didn't work.

TEST PLAN
  My Alternatives popup now slides in from the panel. Verified that it follows 
the panel location (top/bottom)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6554

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


Re: KWin 5.10.3.1 update

2017-07-07 Thread Maximiliano Curia

¡Hola Jonathan!

El 2017-07-03 a las 17:26 +0100, Jonathan Riddell escribió:
KWin has received an update to the 5.10.3 release. 5.10.3.1 contains a fix for 
https://bugs.kde.org/show_bug.cgi?id=381870 
Freeze in KWin::checkGLError on startup 
which affects machines with an NVidia card.



The change is 
https://commits.kde.org/kwin/aefb5f4dd9d41aa7377d56ece203089c73aefe07



https://www.kde.org/info/plasma-5.10.3.php


kwin-5.10.3.1 4.4MB 
199e3a2593e9e66bbd6521ee8a25a012003d15f6b4bf2f102c70b798c9abd03a


Is this fix backportable to the 5.8 branch?

Happy hacking,
--
"Las computadoras son inútiles, solo pueden darte respuestas."
-- Pablo Picasso
Saludos /\/\ /\ >< `/


signature.asc
Description: PGP signature


D6552: RFC: [Folder View] Reply mouse click so left button containment actions work

2017-07-07 Thread Kai Uwe Broulik
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When we don't initiate a rubber band selection, replay the mouse event so 
containment actions assigned to the left mouse button work.
  
  BUG: 357367

TEST PLAN
  Assigned application launcher containment action to left mouse button, 
clicked folder view, menu showed up. Same with Ctrl+left click.
  
  Not sure if it's a good idea to just send a mouse *press* event.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6552

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/plugins/folder/CMakeLists.txt
  containments/desktop/plugins/folder/folderplugin.cpp
  containments/desktop/plugins/folder/mouseeventfaker.cpp
  containments/desktop/plugins/folder/mouseeventfaker.h

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas


[Powerdevil] [Bug 378498] Power settings missing scrollbar

2017-07-07 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=378498

Christoph Feck  changed:

   What|Removed |Added

 CC||domenico.iezzi@gmail.co
   ||m

--- Comment #4 from Christoph Feck  ---
*** Bug 382097 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 382097] Powerdevil config window too big and unresizable

2017-07-07 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=382097

Christoph Feck  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Christoph Feck  ---


*** This bug has been marked as a duplicate of bug 378498 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 382097] New: Powerdevil config window too big and unresizable

2017-07-07 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=382097

Bug ID: 382097
   Summary: Powerdevil config window too big and unresizable
   Product: Powerdevil
   Version: 5.10.3
  Platform: Archlinux Packages
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: domenico.iezzi@gmail.com
  Target Milestone: ---

Created attachment 106491
  --> https://bugs.kde.org/attachment.cgi?id=106491=edit
Screenshot of the powerdevil settings

Powerdevil settings windows is too big for 1366x768 screens, the buttons fall
under the bottom bar. The window is unresizable, so the only way to apply
changes in settings it to switch tab (for example from Energy Saving to
Activity Settings).
I added a screenshot as attachment to show the problem.

* OS: Arch Linux
* linux: 4.11.9
* plasma-desktop: 5.10.3
* powerdevil: 5.10.3

-- 
You are receiving this mail because:
You are the assignee for the bug.

D6544: Don't draw focus line on selected list item

2017-07-07 Thread Kai Uwe Broulik
broulik added a comment.


  Updated, thanks. 
https://cgit.kde.org/breeze.git/commit/?id=6906919371ff92ff0dc7f6ae4e4e14310c5e1e53

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D6544

To: broulik, #plasma, hpereiradacosta, fvogt
Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D6551: [Task Manager] Also respect visible property of configure action

2017-07-07 Thread Kai Uwe Broulik
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When Plasma is locked down, configure actions are hidden.
  In Task Manager this was not taken into account and the action was only 
disabled but still listed.

TEST PLAN
  Put the following in kdeglobals
  
[KDE Action Restrictions]
plasma/allow_configure_when_locked=false
plasma/plasmashell/unlockedDesktop=false
  
  Task Manager settings was no longer listed in Task context menus.
  Without the entries, it behaves as normal.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6551

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas


D6544: Don't draw focus line on selected list item

2017-07-07 Thread Christoph Feck
cfeck added inline comments.

INLINE COMMENTS

> cfeck wrote in breezestyle.cpp:3082
> Of course inherits(QString) is slower than qobject_cast<>.
> 
> The only reason to use inherits() is when you do not link to the library that 
> the class defines.

Also order to make the fastest test come first.

if ((state & State_Selected) && qobject_cast(widget))

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D6544

To: broulik, #plasma, hpereiradacosta, fvogt
Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D6544: Don't draw focus line on selected list item

2017-07-07 Thread Christoph Feck
cfeck added inline comments.

INLINE COMMENTS

> broulik wrote in breezestyle.cpp:3082
> From what I can tell the difference is negligible. `qobject_cast` goes 
> through `QMetaObject::cast` which then calls `inherits` internally, so I'd 
> say `inherits` is the better choice.
> 
> I didn't benchmark, though. I just followed what the rest of the code around 
> it was doing (`inherits`)

Of course inherits(QString) is slower than qobject_cast<>.

The only reason to use inherits() is when you do not link to the library that 
the class defines.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D6544

To: broulik, #plasma, hpereiradacosta, fvogt
Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D6550: [Task Manager] Set status to RequiresAttentionStatus while context menu is open

2017-07-07 Thread Kai Uwe Broulik
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This ensures the panel does not auto-hide then.
  There can only be one context menu at a time, so I moved the property to the 
root item so it's easily accessible from there.

TEST PLAN
  Configured my panel to auto-hide
  
  - Right-clicked task, panel stayed visible until the menu closed
  - Right-clicked tooltip, panel stayed visible until menu closed, and with 
this change it also highlights the task item while the menu is open
  - Verified that panel stayed visible when there was a task demanding attention

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6550

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/ToolTipWindowMouseArea.qml
  applets/taskmanager/package/contents/ui/main.qml

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas


D6527: [Containment Interface] Keep containment in RequiresAttentionStatus while context menu is open

2017-07-07 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:f3dcff28b8fb: [Containment Interface] Keep containment in 
RequiresAttentionStatus while… (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6527?vs=16238=16298

REVISION DETAIL
  https://phabricator.kde.org/D6527

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: broulik, #plasma, mart
Cc: mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas


D6544: Don't draw focus line on selected list item

2017-07-07 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.
Closed by commit R31:89b916039387: Don't draw focus line on selected list item 
(authored by broulik).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6544?vs=16287=16297

REVISION DETAIL
  https://phabricator.kde.org/D6544

AFFECTED FILES
  kstyle/breezestyle.cpp

To: broulik, #plasma, hpereiradacosta, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas


D6549: Look for QtGraphicalEffects, so packagers don't forget it

2017-07-07 Thread Aleix Pol Gonzalez
apol added a comment.


  In https://phabricator.kde.org/D6549#122629, @sitter wrote:
  
  > Probably should go to ECM instead of being copy pasted.
  
  
  Yes, right... xD

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D6549

To: apol, #kirigami, sitter, mart
Cc: plasma-devel, apol, mart


D6549: Look for QtGraphicalEffects, so packagers don't forget it

2017-07-07 Thread Harald Sitter
sitter added a comment.


  Probably should go to ECM instead of being copy pasted.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D6549

To: apol, #kirigami, sitter, mart
Cc: plasma-devel, apol, mart


D6549: Look for QtGraphicalEffects, so packagers don't forget it

2017-07-07 Thread Aleix Pol Gonzalez
apol created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6549

AFFECTED FILES
  CMakeLists.txt
  cmake/FindQMLModule.cmake.in
  cmake/QMLModules.cmake

To: apol, #kirigami, sitter, mart
Cc: plasma-devel, apol, mart


D6544: Don't draw focus line on selected list item

2017-07-07 Thread Hugo Pereira Da Costa
hpereiradacosta accepted this revision.
hpereiradacosta added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> broulik wrote in breezestyle.cpp:3082
> From what I can tell the difference is negligible. `qobject_cast` goes 
> through `QMetaObject::cast` which then calls `inherits` internally, so I'd 
> say `inherits` is the better choice.
> 
> I didn't benchmark, though. I just followed what the rest of the code around 
> it was doing (`inherits`)

Code uses both actually (usually qobject_cast for "public" classes, from Qt, 
and inherits for "private" classes, or kde).
In any case, I trust your investigation :)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D6544

To: broulik, #plasma, hpereiradacosta, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas


D6544: Don't draw focus line on selected list item

2017-07-07 Thread Kai Uwe Broulik
broulik added inline comments.

INLINE COMMENTS

> hpereiradacosta wrote in breezestyle.cpp:3082
> Not sure which one is the most efficient:
> Widget->inherits or qobject_cast ?
> (My guess  would need the second, but ...)
> Can you double check ?

>From what I can tell the difference is negligible. `qobject_cast` goes through 
>`QMetaObject::cast` which then calls `inherits` internally, so I'd say 
>`inherits` is the better choice.

I didn't benchmark, though. I just followed what the rest of the code around it 
was doing (`inherits`)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D6544

To: broulik, #plasma, hpereiradacosta, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas


D6544: Don't draw focus line on selected list item

2017-07-07 Thread Hugo Pereira Da Costa
hpereiradacosta added inline comments.

INLINE COMMENTS

> breezestyle.cpp:3082
> +// no focus indicator on selected list items
> +if (widget && widget->inherits("QAbstractItemView") && (state & 
> State_Selected))
> +{ return true; }

Not sure which one is the most efficient:
Widget->inherits or qobject_cast ?
(My guess  would need the second, but ...)
Can you double check ?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D6544

To: broulik, #plasma, hpereiradacosta, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas


[Breeze] [Bug 381407] SDDM's Breeze theme should have a prettier background than just a flat blue color

2017-07-07 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=381407

David Edmundson  changed:

   What|Removed |Added

 CC||k...@davidedmundson.co.uk
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #2 from David Edmundson  ---
>I have heard that this was a deliberate choice by the VDG,

Yes.

> so the fact that one shows a picture and the other shows a plain blue 
> background seems weird and inconsistent.


It doesn't. They both default to blue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D6544: Don't draw focus line on selected list item

2017-07-07 Thread Kai Uwe Broulik
broulik edited the test plan for this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D6544

To: broulik, #plasma, hpereiradacosta, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas


D6544: Don't draw focus line on selected list item

2017-07-07 Thread Kai Uwe Broulik
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  A fix I did for the focus line being drawn outside item boundaries resulted 
in the item selection rectangle being "cut off" by the focus line. The 
selection rectangle is enough of an indication anyway.

TEST PLAN
  Before
  F3805982: Screenshot_20170707_100856.png 

  After
  F3805984: Screenshot_20170707_110608.png 

  
  Especially noticeable in KInfoCenter where there's a tree list and only the 
label is underlined but not the icon, resulting in an uneven "cut".

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D6544

AFFECTED FILES
  kstyle/breezestyle.cpp

To: broulik, #plasma, hpereiradacosta, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas


[Powerdevil] [Bug 382088] New: power on battery: Does not consider mutiple batteries

2017-07-07 Thread Pascal d'Hermilly
https://bugs.kde.org/show_bug.cgi?id=382088

Bug ID: 382088
   Summary: power on battery: Does not consider mutiple batteries
   Product: Powerdevil
   Version: 5.10.3
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: pas...@dhermilly.dk
  Target Milestone: ---

The time left on battery seem to only consider one of the batteries.
Powertop estimate the double time left on battery.
I have 2 batteries in my Thinkpad - a removable and an internal.

Actually - I see now that kinfocenter shows a consumption rate of 17 W versus
powertop saying 8 W.
It could also be this that is influencing the estimates...

-- 
You are receiving this mail because:
You are the assignee for the bug.