D6693: Install the PlasmaComponents.3/private folder

[David Edmundson]

davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  It's used by ToolButton et al.
  We install it in the theme folder, but not in the plasma components dir.

TEST PLAN
  Used a toolbutton without error

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6693

AFFECTED FILES
  src/declarativeimports/CMakeLists.txt

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6634: Require C++14

[Fabian Vogt]

fvogt added a comment.


  In https://phabricator.kde.org/D6634#125102, @graesslin wrote:
  
  > In https://phabricator.kde.org/D6634#124880, @lbeltrame wrote:
  >
  > > openSUSE Leap 42.3 uses GCC 4.8 as default, although 5 and 6 are 
available as well.
  >
  >
  > @lbeltrame does it mean it would create problems for openSUSE or would it 
be fine?
  
  
  It would be fine.
  
  GCC 4.8 is the system compiler, which means it's used by default and used to 
compile the vast majority of packages
  (it's the only compiler available in the base SLE, so packages coming from 
there, like Qt, are always built with it).
  Leap 42.1 has additionally GCC 5, 42.2 got GCC 6 in plus and 42.3 will get 
GCC 7 as well.
  It's just a matter of setting the CC/CXX variables correctly as they're 
configured to be ABI compatible (`--with-default-libstdcxx-abi=gcc4-compatible` 
-> std::string with CoW...).

REPOSITORY
  R108 KWin

BRANCH
  cxx-14

REVISION DETAIL
  https://phabricator.kde.org/D6634

To: graesslin, #plasma, lbeltrame, ivan
Cc: fvogt, ivan, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D6688: Adjusted Scrollbars

[Artem Grinev]

LordTermor added a comment.


  No, I don't have commit access (at least I don't think so since it's my first 
commit).
  
  Real name: Artem Grinev 
  Email: agrine...@gmail.com
  
  There are also few bugs which affect gtk theme mimickers. I couldn't fix them 
myself.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D6688

To: LordTermor, mart
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6688: Adjusted Scrollbars

[David Edmundson]

davidedmundson added a comment.


  Do you have commit access.
  
  If not can we have your real name and email address please.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D6688

To: LordTermor, mart
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6688: Adjusted Scrollbars

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D6688

To: LordTermor, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6634: Require C++14

[Martin Flöser]

graesslin added a comment.


  In https://phabricator.kde.org/D6634#124880, @lbeltrame wrote:
  
  > openSUSE Leap 42.3 uses GCC 4.8 as default, although 5 and 6 are available 
as well.
  
  
  @lbeltrame does it mean it would create problems for openSUSE or would it be 
fine?

REPOSITORY
  R108 KWin

BRANCH
  cxx-14

REVISION DETAIL
  https://phabricator.kde.org/D6634

To: graesslin, #plasma, lbeltrame, ivan
Cc: ivan, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D6688: Adjusted Scrollbars

[Artem Grinev]

LordTermor created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Adjusted Scrollbars so now they fit the Qt theme

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D6688

AFFECTED FILES
  Breeze-gtk/assets/scrollbar-slider-horizontal-active.png
  Breeze-gtk/assets/scrollbar-slider-horizontal-act...@2.png
  Breeze-gtk/assets/scrollbar-slider-horizontal-hover.png
  Breeze-gtk/assets/scrollbar-slider-horizontal-ho...@2.png
  Breeze-gtk/assets/scrollbar-slider-horizontal.png
  Breeze-gtk/assets/scrollbar-slider-horizon...@2.png
  Breeze-gtk/assets/scrollbar-slider-vertical-active.png
  Breeze-gtk/assets/scrollbar-slider-vertical-act...@2.png
  Breeze-gtk/assets/scrollbar-slider-vertical-hover.png
  Breeze-gtk/assets/scrollbar-slider-vertical-ho...@2.png
  Breeze-gtk/assets/scrollbar-slider-vertical.png
  Breeze-gtk/assets/scrollbar-slider-verti...@2.png
  Breeze-gtk/assets/scrollbar-trough-horizontal.png
  Breeze-gtk/assets/scrollbar-trough-horizon...@2.png
  Breeze-gtk/assets/scrollbar-trough-vertical.png
  Breeze-gtk/assets/scrollbar-trough-verti...@2.png
  Breeze-gtk/gtk-2.0/widgets/default
  Breeze-gtk/gtk-2.0/widgets/scrollbar
  Breeze-gtk/gtk-3.20/gtk.css

To: LordTermor
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6683: [server] Send keyboard leave when client destroys the focused surface

[Martin Flöser]

graesslin created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This is a change inspired by https://bugreports.qt.io/browse/QTBUG-61930.
  When Qt closes a window due to a key press event it starts to repeat the
  event as KWayland does not send a keyboard leave event. Weston on the
  other hand does send out the keyboard leave. In my opinion it doesn't
  make much sense to send out the keyboard leave in this situation and in
  my opinion that is a client bug, but if it makes clients happy we can
  send them the keyboard leave. Similar this should be done for pointer,
  touch, etc.
  
  BUG: 382280

TEST PLAN
  Run the example added to the Qt bug and it worked fine

REPOSITORY
  R127 KWayland

BRANCH
  keyboard-leave-surface-destroy

REVISION DETAIL
  https://phabricator.kde.org/D6683

AFFECTED FILES
  autotests/client/test_wayland_seat.cpp
  src/server/keyboard_interface.cpp
  src/server/resource.cpp
  src/server/resource.h

To: graesslin, #frameworks, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, eliasp, sebas, apol, mart, hein, lukas

D6569: [client] Track all created ConnectionThreads and add API to access them

[Martin Flöser]

graesslin updated this revision to Diff 16660.
graesslin added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.


  Make this compile. Looks like kdevelop fooled me and compiled KWin instead of 
KWayland (that happens all the time to me)

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6569?vs=16406=16660

BRANCH
  all-connection-threads

REVISION DETAIL
  https://phabricator.kde.org/D6569

AFFECTED FILES
  autotests/client/test_wayland_connection_thread.cpp
  src/client/connection_thread.cpp
  src/client/connection_thread.h

To: graesslin, #frameworks, #plasma, #kwin, davidedmundson
Cc: davidedmundson, dfaure, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D6657: [krunner] First set panel behavior than as panel

[Martin Flöser]

graesslin added a comment.


  In https://phabricator.kde.org/D6657#124801, @mart wrote:
  
  > does this overridex/fixes https://phabricator.kde.org/D6654?
  
  
  kind of orthogonal. https://phabricator.kde.org/D6654 would be nicer if it 
worked. But as long as https://phabricator.kde.org/D6654 does not work, this 
one here at least makes it working.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6657

To: graesslin, #plasma
Cc: mart, apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, lukas

D6628: Fix and normalize license in .desktop files

[Harald Sitter]

sitter added a comment.


  Yeah, legacy reasons. I am looking into ways to change this moving forward 
though. Not sure if the cost-benefit will be reasonable, but it's on my radar 
and at a glance should be doable in some form or fashion.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6628

To: sebas, #plasma, sitter, mart, broulik
Cc: mak, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D6677: Automatically install/remove/update related refs

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:a9a018589de5: Automatically install/remove/update related 
refs (authored by jgrulich).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D6677?vs=16647=16650#toc

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6677?vs=16647=16650

REVISION DETAIL
  https://phabricator.kde.org/D6677

AFFECTED FILES
  libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp
  libdiscover/backends/FlatpakBackend/FlatpakTransaction.cpp
  libdiscover/backends/FlatpakBackend/FlatpakTransaction.h
  libdiscover/backends/FlatpakBackend/FlatpakTransactionJob.cpp
  libdiscover/backends/FlatpakBackend/FlatpakTransactionJob.h

To: jgrulich, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6677: Automatically install/remove/update related refs

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R134 Discover Software Store

BRANCH
  related-refs

REVISION DETAIL
  https://phabricator.kde.org/D6677

To: jgrulich, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6677: Automatically install/remove/update related refs

[Aleix Pol Gonzalez]

apol added a comment.


  Looks good to me

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D6677

To: jgrulich, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6679: Treat Button/ToolButton labels as plaintext

[Fabian Vogt]

fvogt marked an inline comment as done.
fvogt added inline comments.

INLINE COMMENTS

> broulik wrote in ToolButtonStyle.qml:100
> `Text.StyledText`

I think the priority queue in my brain is somehow backwards

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6679

To: fvogt, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6679: Treat Button/ToolButton labels as plaintext

[Fabian Vogt]

fvogt updated this revision to Diff 16649.
fvogt added a comment.


  Fix typo in ToolButtonStyle

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6679?vs=16648=16649

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6679

AFFECTED FILES
  src/declarativeimports/plasmastyle/ButtonStyle.qml
  src/declarativeimports/plasmastyle/ToolButtonStyle.qml
  src/declarativeimports/plasmastyle/private/Util.js

To: fvogt, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6679: Treat Button/ToolButton labels as plaintext

[Kai Uwe Broulik]

broulik added a comment.


  +1
  
  (for others reading this: Explicitly turning it into `StyledText` prevents 
Qt's `AutoText` from deciding to use `PlainText` in some cases which will then 
again look broken. Note that `StyledText` uses a basic string parser so it's 
nowhere near as heavy as `RichText` and should be fine)

INLINE COMMENTS

> ToolButtonStyle.qml:100
> +text: 
> Util.stylizeEscapedMnemonics(Util.toHtmlEscaped(control.text))
> +textFormat: Text.styledText
>  font: control.font || theme.defaultFont

`Text.StyledText`

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6679

To: fvogt, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6679: Treat Button/ToolButton labels as plaintext

[Fabian Vogt]

fvogt created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  The label text gets treated as RichText/StyledText, which is required
  to display mnemonics underlined. Therefore it is necessary to manually
  HTML escape the label text, which unfortunately breaks mnemonics as
  escaped HTML contains ampersands.
  This commit fixes that by introducing a custom function to stylize
  mnemonics in HTML escaped text.

TEST PLAN
  Ran a modified knotificationdbustest with "&" and
  "actio" as actions. Result: http://i.imgur.com/xHifDBu.png

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6679

AFFECTED FILES
  src/declarativeimports/plasmastyle/ButtonStyle.qml
  src/declarativeimports/plasmastyle/ToolButtonStyle.qml
  src/declarativeimports/plasmastyle/private/Util.js

To: fvogt, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6628: Fix and normalize license in .desktop files

[Kai Uwe Broulik]

broulik added a comment.


  > Is there any reason not to use the SPDX license IDs here?
  
  The values are the ones in `KAboutLicense` from what I can tell.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6628

To: sebas, #plasma, sitter, mart, broulik
Cc: mak, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D6677: Automatically install/remove/update related refs

[Jan Grulich]

jgrulich updated this revision to Diff 16647.
jgrulich added a comment.


  Cleanup commented code

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6677?vs=16645=16647

BRANCH
  related-refs

REVISION DETAIL
  https://phabricator.kde.org/D6677

AFFECTED FILES
  libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp
  libdiscover/backends/FlatpakBackend/FlatpakTransaction.cpp
  libdiscover/backends/FlatpakBackend/FlatpakTransaction.h
  libdiscover/backends/FlatpakBackend/FlatpakTransactionJob.cpp
  libdiscover/backends/FlatpakBackend/FlatpakTransactionJob.h

To: jgrulich, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6628: Fix and normalize license in .desktop files

[Matthias Klumpp]

mak added a comment.


  Is there any reason not to use the SPDX license IDs here? => 
https://spdx.org/licenses/ (e.g. `GPL-2.0+` in this case).
  In any case, this patch makes things way better, so +1 from me :-)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6628

To: sebas, #plasma, sitter, mart, broulik
Cc: mak, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D6677: Automatically install/remove/update related refs

[Jan Grulich]

jgrulich created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Process related refs which should be automatically installed/remove/updated 
together with the
  app or runtime which is being processed. This is mostly localization, but in 
case of runtime it
  can automatically download styles, icons and so on.

REPOSITORY
  R134 Discover Software Store

BRANCH
  related-refs

REVISION DETAIL
  https://phabricator.kde.org/D6677

AFFECTED FILES
  libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp
  libdiscover/backends/FlatpakBackend/FlatpakTransaction.cpp
  libdiscover/backends/FlatpakBackend/FlatpakTransaction.h
  libdiscover/backends/FlatpakBackend/FlatpakTransactionJob.cpp
  libdiscover/backends/FlatpakBackend/FlatpakTransactionJob.h

To: jgrulich, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6628: Fix and normalize license in .desktop files

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.


  Thanks for doing the leg work.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6628

To: sebas, #plasma, sitter, mart, broulik
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

Re: KRunner Wayland issues on Qt 5.9

[Marco Martin]

On Thu, Jul 13, 2017 at 1:49 PM, Marco Martin  wrote:
> On Thu, Jul 13, 2017 at 11:05 AM, David Edmundson
>  wrote:
>> That works fine for XDG, but wl-shellsurface doesn't like that and remains
>> until you delete the wl_surface. wl_shell_surface_destroy literally sends
>> nothing in wayland_debug.
>>
>> I think that's why they end up deleting both. It's not a simple thing to
>> abstract when everything behaves so differently.
>
> tried the patch and i can confirm the behavior, it goes all down to
> proxy_destroy, so client side is almost like everyting was destroyed
> correctly, but at the next
> wl_shell@27.get_shell_surface, the surface is already created and goes
> to protocol error:
> wl_surface@43: error 0: ShellSurface already created

by the way, this seems the gtk implementation
https://github.com/jdapena/gtk/blob/master/gdk/wayland/gdkwindow-wayland.c

which seems to do the same thing, destroying the wl_surface at every window hide
https://github.com/GNOME/gtk/blob/master/gdk/wayland/gdkwindow-wayland.c

--
Marco Martin

D6676: Declare AppManager.js as pragma library

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:d8f1d44a493c: Declare AppManager.js as pragma library 
(authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6676?vs=16643=16644

REVISION DETAIL
  https://phabricator.kde.org/D6676

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/private/AppManager.js

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6676: Declare AppManager.js as pragma library

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  > Before, I would get at least 6 instances (from various Dialogs that were 
created for instance).
  
  I doubt it, no-one uses that. Probably TabBars.
  
  In any case, I wouldn't spend /too/ long optimising QQC2 stuff, we are moving 
from it.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6676

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6676: Declare AppManager.js as pragma library

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  It doesn't store any state but contains only functions.

TEST PLAN
  Only one instance of this script is created in plasmashell.
  Before, I would get at least 6 instances (from various Dialogs that were 
created for instance).
  
  (This file could get some cleanup, `sceneX` and `sceneY` can be achieved by 
doing `mapToItem(null)`)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6676

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/private/AppManager.js

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

Re: KRunner Wayland issues on Qt 5.9

[Marco Martin]

On Thu, Jul 13, 2017 at 11:05 AM, David Edmundson
 wrote:
> That works fine for XDG, but wl-shellsurface doesn't like that and remains
> until you delete the wl_surface. wl_shell_surface_destroy literally sends
> nothing in wayland_debug.
>
> I think that's why they end up deleting both. It's not a simple thing to
> abstract when everything behaves so differently.

tried the patch and i can confirm the behavior, it goes all down to
proxy_destroy, so client side is almost like everyting was destroyed
correctly, but at the next
wl_shell@27.get_shell_surface, the surface is already created and goes
to protocol error:
wl_surface@43: error 0: ShellSurface already created

--
Marco Martin

D6666: Allow having a header in a ListView that is in an OverlaySheet

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:868d61272b2a: Allow having a header in a ListView that is 
in an OverlaySheet (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D?vs=16615=16639

REVISION DETAIL
  https://phabricator.kde.org/D

AFFECTED FILES
  src/controls/templates/OverlaySheet.qml

To: apol, #kirigami, mart
Cc: plasma-devel, apol, mart

D6634: Require C++14

[Luca Beltrame]

lbeltrame added a comment.


  openSUSE Leap 42.3 uses GCC 4.8 as default, although 5 and 6 are available as 
well.

REPOSITORY
  R108 KWin

BRANCH
  cxx-14

REVISION DETAIL
  https://phabricator.kde.org/D6634

To: graesslin, #plasma, lbeltrame, ivan
Cc: ivan, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D6673: [Notifications] Manually remove remote images

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We allow HTML in Notifications and QtQuick Text will even load remote images 
which poses a privacy threat.
  The network access manager factory we install is ineffective as Plasma uses a 
shared engine nowadays and whenever a new QmlObject shared engine is created, 
its setupBindings will re-install the KIO access factory.

TEST PLAN
  5.8 branch on Fabian's request as this is a security issue
  
  Can no longer cause network requests by sending a notification with `http://...;>` or ``.
  
  (Btw I noticed that setupBindings is called >100 times on Plasma startup, 
setting up the very same QML engine over and over again, including creating a 
KIO NAM factory, KLocalizedContext and KIcon image provider)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6673

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/plugin/CMakeLists.txt
  applets/notifications/plugin/notificationshelperplugin.cpp
  applets/notifications/plugin/notificationshelperplugin.h
  applets/notifications/plugin/textsanitizer.cpp
  applets/notifications/plugin/textsanitizer.h

To: broulik, #plasma, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6671: [Notification Item] Enforce PlainText for summary

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ddc530ff14b6: [Notification Item] Enforce PlainText for 
summary (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6671?vs=16629=16630

REVISION DETAIL
  https://phabricator.kde.org/D6671

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml

To: broulik, #plasma, fvogt, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6671: [Notification Item] Enforce PlainText for summary

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6671

To: broulik, #plasma, fvogt, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6671: [Notification Item] Enforce PlainText for summary

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  According to specification only body text may contain HTML and this keeps 
apps from screwing up the layout or even loading remote images.

TEST PLAN
  5.8 branch
  
  No longer able to mess up the layout by sending a notification with html tags 
in title

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6671

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml

To: broulik, #plasma, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

Re: KRunner Wayland issues on Qt 5.9

[David Edmundson]

>IIRC wl_shell is not defined to be double buffered. Not sure how it's
about xdg. There is always the chance of breaking things *cough*Qt*cough*
when changing that - even if it is sane.

Xdg definitely is and for v7 this is important as mapping/unmapping is
different.

* committing a surface with empty buffer on a surface unmaps a window

* commiting again (still with an empty buffer) tells the compositor we're
going to send a configure event because we're about to remap the window

which means we need to be at least be tracking the wl_surface changes even
if we don't properly double buffer.

>From a Kwin POV, it'd be best to deal with this on the kwayland side as we
need to reset the xdg_toplevel state.

Personally I think deleting the xdgshellsurface in Qt is a lot less messy
than the new XDG.  The only thing that doesn't make sense is deleting the
wl_surface.

I wrote a patch that does that. https://paste.kde.org/pgh8jafqw

That works fine for XDG, but wl-shellsurface doesn't like that and remains
until you delete the wl_surface. wl_shell_surface_destroy literally sends
nothing in wayland_debug.

I think that's why they end up deleting both. It's not a simple thing to
abstract when everything behaves so differently.


> What could be an idea is to not do anything in KWin till we get the first
> map event. That is evaluate all the shell options only on map.
>
>
>> In practice that won't acheive anything as QWaylandWindow::initWindow
>> calls commit a few times randomly before the expose event that we're
>> currently hooking into is called. Also kwayland-integration calls
>> commit on the surface every time it attaches something, which I don't
>> think is right.
>>
>
> It is fine given the definition of the interfaces. We setup some state and
> commit it. If we don't commit we don't know when that will happen. We only
> adjusted our own relevant states and everything else is not affected.
>

That would be true if we weren't using these in hooks in the middle of Qt
adjusting things. Maybe avoiding that is the right fix though.



FWIW I'm meeting Jonas (the XDGShell and scaling guy) in two weeks at
Guadec.

D6628: Fix and normalize license in .desktop files

[Kai Uwe Broulik]

broulik accepted this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6628

To: sebas, #plasma, sitter, mart, broulik
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D6628: Fix and normalize license in .desktop files

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6628

To: sebas, #plasma, sitter, mart
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D6642: Use version of the Applications product

[Elvis Angelaccio]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:395500244021: Use version of the Applications product 
(authored by elvisangelaccio).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D6642?vs=16557=16627#toc

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6642?vs=16557=16627

REVISION DETAIL
  https://phabricator.kde.org/D6642

AFFECTED FILES
  CMakeLists.txt

To: elvisangelaccio, #plasma, anthonyfieroni, apol
Cc: anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6628: Fix and normalize license in .desktop files

[Marco Martin]

mart added a comment.


  +1 for all the ones from me

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6628

To: sebas, #plasma, sitter
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

Re: KRunner Wayland issues on Qt 5.9

[Marco Martin]

On Thursday 13 July 2017 09:56:38 you wrote:
> with a qt more recent than https://codereview.qt-project.org/#/c/195835/
> surfacecreated events may be again sent at the right moments?
> (tough reverting https://bugreports.qt.io/browse/QTBUG-58423 would still be
> a good thing)

another good thing could be looking for the implementation of gtk and see if 
they are doing the same monstrosity, which probably they don't

-- 
Marco Martin

Re: KRunner Wayland issues on Qt 5.9

[Marco Martin]

On Thursday 13 July 2017 09:56:38 you wrote:
> with a qt more recent than https://codereview.qt-project.org/#/c/195835/
> surfacecreated events may be again sent at the right moments?
> (tough reverting https://bugreports.qt.io/browse/QTBUG-58423 would still be
> a good thing)

maybe let's try a Qt patch, something that we are confident is conforming with 
xdgshell stable and try to push it?

-- 
Marco Martin

D6657: [krunner] First set panel behavior than as panel

[Marco Martin]

mart added a comment.


  does this overridex/fixes https://phabricator.kde.org/D6654?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6657

To: graesslin, #plasma
Cc: mart, apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, lukas

Re: KRunner Wayland issues on Qt 5.9

[Marco Martin]

On Wednesday 12 July 2017 20:51:16 Martin Flöser wrote:
> 
> You might be right. Given the output of KWin debug console all the calls
> didn't work.
> 
> THIS SUCKS! So show event is too early and expose event is too late. God
> damn Qt why did you have to break this??? We had working code and now we
> are back to square 1.
> 
> Martin

with a qt more recent than https://codereview.qt-project.org/#/c/195835/
surfacecreated events may be again sent at the right moments?
(tough reverting https://bugreports.qt.io/browse/QTBUG-58423 would still be a 
good thing)

-- 
Marco Martin

D6666: Allow having a header in a ListView that is in an OverlaySheet

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D

To: apol, #kirigami, mart
Cc: plasma-devel, apol, mart