D6688: Adjusted Scrollbars

2017-07-17 Thread David Edmundson
davidedmundson added a comment.


  There's something wrong with the diff.
  
  Download raw diff doesn't have the binary changes.
  
  Can you send it as an email to me. (or upload here using arc instead of the 
web interface)

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D6688

To: LordTermor, mart
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D6764: Add font size setting to the digital clock plasmoid

2017-07-17 Thread Diego Gangl
januz edited the summary of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6764

To: januz, #plasma, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas


D6764: Add font size setting to the digital clock plasmoid

2017-07-17 Thread Diego Gangl
januz created this revision.
januz added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This patch adds a new setting to the digital clock plasmoid to change the 
font size for horizontal panels and desktop. It also sets a default (14) with a 
new look.
  
  Here's what it looks like by default:
  F3813736: digital_clock_screen.png 
  
  - Vertical panels are constrained in space for this plasmoid so I've disabled 
it for them.
  - The new default tries to be aligned with the tray icons as best as possible
  - This only applies to the clock, not the date
  - This is my first patch for plasma, sorry if I messed with the wrong files 😄

TEST PLAN
  Play with the widget settings in different panels/desktop

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6764

AFFECTED FILES
  applets/digital-clock/package/contents/config/main.xml
  applets/digital-clock/package/contents/ui/DigitalClock.qml
  applets/digital-clock/package/contents/ui/configAppearance.qml

To: januz, #plasma, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas


D6763: Fix app icon button in window decos with high DPI in previews.

2017-07-17 Thread David Edmundson
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  With both Qt devicePixelRatio > 1 and Qt::AA_UseHighDpiPixmaps set
  QIcon.pixmap() will return a bigger image than the size requested, with
  the relevant devicePixelRatio set.
  
  This code is trying to center an icon within a bounding rect, (like
  QStyle::drawItemPixmap) and so positioning should use normalised pixels,
  not actual pixmap pixels.
  
  This affected Systemsettings previews but not kwin.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6763

AFFECTED FILES
  kdecoration/breezebutton.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas


D6631: Fix compilation with strict libc (such as musl)

2017-07-17 Thread Ben Cooksley
bcooksley added a comment.


  Thanks for the quick fix.
  
  Getting closer - got a different error this time...
  https://build.kde.org/job/Plasma%20ksysguard%20kf5-qt5%20FreeBSDQt5.7/7/

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D6631

To: mpyne, #plasma, mart
Cc: bcooksley, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D6631: Fix compilation with strict libc (such as musl)

2017-07-17 Thread Michael Pyne
mpyne added a comment.


  In https://phabricator.kde.org/D6631#126101, @bcooksley wrote:
  
  > Clang doesn't seem to like this: 
https://build.kde.org/job/Plasma%20ksysguard%20kf5-qt5%20FreeBSDQt5.7/4/console
  
  
  Thanks.  Looks from the build log like it's not good enough to define the 
`_POSIX_C_SOURCE` macro and let it take a default meaning, it needs to be 
defined to a specific value.  I've pushed a fix which I hope will make it 
through CI.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D6631

To: mpyne, #plasma, mart
Cc: bcooksley, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D6411: [platforms/x11] Use a GlxContextAttributeBuilder

2017-07-17 Thread Martin Flöser
graesslin updated this revision to Diff 16830.
graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
Restricted Application added a subscriber: kwin.


  Rebased to master

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6411?vs=15930&id=16830

BRANCH
  glx-context-attribute-builder

REVISION DETAIL
  https://phabricator.kde.org/D6411

AFFECTED FILES
  abstract_opengl_context_attribute_builder.h
  autotests/CMakeLists.txt
  autotests/opengl_context_attribute_builder_test.cpp
  plugins/platforms/x11/standalone/CMakeLists.txt
  plugins/platforms/x11/standalone/glx_context_attribute_builder.cpp
  plugins/platforms/x11/standalone/glx_context_attribute_builder.h
  plugins/platforms/x11/standalone/glxbackend.cpp

To: graesslin, #kwin, #plasma
Cc: kwin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D6754: [server] Send pointer leave if focused surface gets unbound

2017-07-17 Thread Sebastian Kügler
sebas accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  send-leave-pointer-surface

REVISION DETAIL
  https://phabricator.kde.org/D6754

To: graesslin, #plasma, #frameworks, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, eliasp, sebas, apol, mart, hein, lukas


D6754: [server] Send pointer leave if focused surface gets unbound

2017-07-17 Thread Martin Flöser
graesslin created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  As https://phabricator.kde.org/R127:98e5d269a110dca9cae1e4ed2bb3051f02a69bff 
just for pointer.

REPOSITORY
  R127 KWayland

BRANCH
  send-leave-pointer-surface

REVISION DETAIL
  https://phabricator.kde.org/D6754

AFFECTED FILES
  autotests/client/test_wayland_seat.cpp
  src/server/pointer_interface.cpp

To: graesslin, #plasma, #frameworks
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, eliasp, sebas, apol, mart, hein, lukas


D6734: [qpa] Use the new OpenGLContextAttributeBuilder to create Qt's OpenGL context

2017-07-17 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:73fa7b21a187: [qpa] Use the new 
OpenGLContextAttributeBuilder to create Qt's OpenGL context (authored by 
graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6734?vs=16776&id=16828

REVISION DETAIL
  https://phabricator.kde.org/D6734

AFFECTED FILES
  abstract_opengl_context_attribute_builder.cpp
  abstract_opengl_context_attribute_builder.h
  autotests/opengl_context_attribute_builder_test.cpp
  egl_context_attribute_builder.cpp
  egl_context_attribute_builder.h
  plugins/qpa/abstractplatformcontext.cpp

To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas


D6634: Require C++14

2017-07-17 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:ea5d611de1bc: Require C++14 (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6634?vs=16530&id=16827

REVISION DETAIL
  https://phabricator.kde.org/D6634

AFFECTED FILES
  CMakeLists.txt
  plugins/platforms/x11/standalone/glxbackend.cpp

To: graesslin, #plasma, lbeltrame, ivan
Cc: fvogt, ivan, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas


D6708: Properly swap the quick tile side when pressing the shortcut again

2017-07-17 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:139b4dc82a94: Properly swap the quick tile side when 
pressing the shortcut again (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6708?vs=16728&id=16826

REVISION DETAIL
  https://phabricator.kde.org/D6708

AFFECTED FILES
  autotests/integration/quick_tiling_test.cpp
  geometry.cpp

To: graesslin, #plasma, #kwin, mart
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D6719: [aurorae] Add support for shaded windows

2017-07-17 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:bf0e0f071ceb: [aurorae] Add support for shaded windows 
(authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6719?vs=16774&id=16825

REVISION DETAIL
  https://phabricator.kde.org/D6719

AFFECTED FILES
  plugins/kdecorations/aurorae/src/aurorae.cpp
  plugins/kdecorations/aurorae/src/qml/Decoration.qml

To: graesslin, #kwin, #plasma, cfeck
Cc: cfeck, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D6735: [platforms/x11] Quit the OpenGL Freeze protection thread on shutdown

2017-07-17 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:06a558e3de65: [platforms/x11] Quit the OpenGL Freeze 
protection thread on shutdown (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6735?vs=16777&id=16823

REVISION DETAIL
  https://phabricator.kde.org/D6735

AFFECTED FILES
  plugins/platforms/x11/standalone/x11_platform.cpp

To: graesslin, #kwin, #plasma, mart
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D6726: [aurorae] Mark the render QQuickWindow as frameless

2017-07-17 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:5cb91762be43: [aurorae] Mark the render QQuickWindow as 
frameless (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6726?vs=16757&id=16824

REVISION DETAIL
  https://phabricator.kde.org/D6726

AFFECTED FILES
  plugins/kdecorations/aurorae/src/aurorae.cpp

To: graesslin, #kwin, #plasma, mart
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D6751: [Task Manager] Fix icon size in launcher tooltips

2017-07-17 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d28deb6f4ab2: [Task Manager] Fix icon size in launcher 
tooltips (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6751?vs=16809&id=16820

REVISION DETAIL
  https://phabricator.kde.org/D6751

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: broulik, #plasma, hein, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D6751: [Task Manager] Fix icon size in launcher tooltips

2017-07-17 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6751

To: broulik, #plasma, hein, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D6708: Properly swap the quick tile side when pressing the shortcut again

2017-07-17 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  fix-quick-tile-swap-side-5.10

REVISION DETAIL
  https://phabricator.kde.org/D6708

To: graesslin, #plasma, #kwin, mart
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D6735: [platforms/x11] Quit the OpenGL Freeze protection thread on shutdown

2017-07-17 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  quit-opengl-freeze-protection-thread-5.10

REVISION DETAIL
  https://phabricator.kde.org/D6735

To: graesslin, #kwin, #plasma, mart
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D6726: [aurorae] Mark the render QQuickWindow as frameless

2017-07-17 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  aurorae-fix-wayland-recursion-5.10

REVISION DETAIL
  https://phabricator.kde.org/D6726

To: graesslin, #kwin, #plasma, mart
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D6751: [Task Manager] Fix icon size in launcher tooltips

2017-07-17 Thread Kai Uwe Broulik
broulik edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6751

To: broulik, #plasma, hein
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D6751: [Task Manager] Fix icon size in launcher tooltips

2017-07-17 Thread Kai Uwe Broulik
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Depending on icon theme the implicit size of the icon may be huge.
  
  BUG:
  FIXED-IN: 5.10.4

TEST PLAN
  Used Ultra-Flat-Icons, icon size for launcher tooltips is consistent with the 
others in plasma now

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6751

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: broulik, #plasma, hein
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D6746: Fix check for missing engine in comic applet

2017-07-17 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:8aa47be2abe6: Fix check for missing engine in comic 
applet (authored by davidedmundson).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6746?vs=16796&id=16807

REVISION DETAIL
  https://phabricator.kde.org/D6746

AFFECTED FILES
  applets/comic/comic.cpp

To: davidedmundson, #plasma, anthonyfieroni
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas


Minutes Monday Plasma Hangout

2017-07-17 Thread Sebastian Kügler
Next week, no meeting on IRC but in person at Akademy during the Plasma BoF!

Cheers!
-- 
sebas

http://www.kde.org | http://vizZzion.orgPlasma Monday Meeting, 17-07-2017

Present: romangg, Riddell, kbroulik, notmart, bshah d_ed, sebas


* still working on my GSoC project and my master thesis.
* Last week I fixed a bug with a KWin patch, that's all: 
https://phabricator.kde.org/D6659
Diff 6659 "[logind] Correct property name to fix logind session" [Closed] 
https://phabricator.kde.org/D6659
but GSoC project is very interesting

Riddell:
* I'm due to make 5.10.4 tomorrow, I hope there's lots of exciting bugfixes in 
it, is all from me

kbroulik:
* I found that the "NoNetworkAccessManager" in notification doesn't actually 
work (with shared engine stuff in Plasma nowadays) and an app can cause a 
network request by sending a notification containing http://some-evil-tracking-site.com";>. Made a patch to remove images from 
notification body D6673, should go into 5.8 for security, so this needs careful 
review.
Diff 6673 "[Notifications] Manually remove remote images" [Needs Review] 
https://phabricator.kde.org/D6673
* Please also have a look at D6679 which enforces PlainText in Buttons. I know 
this is a behavior change *but* Desktop style QQC never supported it and people 
shouldn't be doing that for buttons anyway. It's another area where a 
notification can cause network requests. (The third being the title label but I 
just enforced PlainText on that Label and done)
Diff 6679 "Treat Button/ToolButton labels as plaintext" [Needs Review] 
https://phabricator.kde.org/D6679
Maybe something for Akademy Plasma Bof – how can we secure/strengthen Plasma to 
avoid those issues. However, most things are just the nature of QML allowing 
"everything" and all running in Plasma. But something to consider for Plasma 6 
(wayland-compositor plasmoids, proper sandboxing, etc :P)
* Also did some cleanup in various places (removing unused JS files, pragma 
library where possible, new connect syntax in some places etc)
* Will look into some patches I got for plasma-browser-integration, planning to 
update the store-provided extension package (haven't done in a while)
* I fixed QDialogButtonBox https://codereview.qt-project.org/#/c/198123/ 
finally merged! So mnemonics in e.g. system settings work fine again

notmart:
* working on akademy presentations
* kirigami: better look for the globaldrawer on desktop (when scrollbar is 
always visible)
* kirigami: better layout when the main scrollable is a grid view
* discover: adapt to it and make the search field perfectly aligned both with 
and without scrollbar
* port okular mobile to kirigami 2
* work with the gsoc student on koko
* investigating and frustration on wayland for the usual problem of not having 
surfaces at the proper moment

bshah:
- More work on akademy presentation
- [plasma mobile] Fixing the pulseaudio to get audio working again
- [halium] Some more documentation writing
- [halium] mostly reviewing patches and helping people to move ports forward

d_ed:
* been trying (and failing) to port anything to plasma components 3, have lots 
of data for BOF discussion about what we need to fix
* making the baloo runner out of process is stalled on stupid categories. It 
uses translated strings as config values
* I fixed two things in QtWayland


sebas:
* Finishing Akademy talk preps with notmart as we speak, it's the Plasma State 
of the Union, review of the past year, cool fancy new features presented and 
outlook into future topics such as next LTS, vision and containerization
* Fixing code licenses in our metadadata.desktop files to align with actual 
licenses (most said GPL v1)
* Just sent out an email declaring our lastest Plasma vision draft final and 
hinted at next steps
* bit of kscreen triaging

Next week is Akademy and our Plasma BoF, so no IRC meeting then but face to 
face pow-wow.


Re: Plasma Vision v 2.0

2017-07-17 Thread Sebastian Kügler
On woensdag 5 juli 2017 13:27:05 CEST Jens wrote:
> Ok after much edits and fiddling this is the current one - based on input
> from a wealth of sources and people:
> 
> -- --
> 
> "Plasma is a cross-device work environment by the KDE Community where trust
> is put on the user's capacity to best define her own workflow and
> preferences.
> 
> Plasma is simple by default, a clean work area for real-world usage which
> intends to stay out of your way.
> Plasma is powerful when needed, enabling the user to create the workflow
> that makes her more effective to complete her tasks.
> 
> Plasma never dictates the user's needs, it only strives to solve them.
> Plasma never defines what the user is allowed to do, it only ensures that
> she can.
> 
> Our motivation is to enable actual work to happen, across devices, across
> different platforms, using any application needed.
> 
> We build to be durable, we create to be usable, we design to be elegant."
> 
> -- --
> 
> This is the final call for feedback and input! Calling all passengers! If
> you have feedback GIVE IT ! 

Almost two weeks have passed without further feedback, so I hereby declare 
this vision final. :-)

Thanks all for the feedback, patience and input.

Next steps involve:

- publishing this vision and making it more known
- internalizing it, and adjusting our goals and strategy
- living up to it

More concretely, we will talk about next steps during a BoF session next 
Monday at Akademy and devise plan.

What I think would be great is if our artists could create some graphical 
material, infographics or somesuch that communicates the above, or distinct 
parts of it.

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org


D6642: Use version of the Applications product

2017-07-17 Thread Jonathan Riddell
jriddell added a comment.


  You need to update network/network/CMakeLists.txt to fix the molletnetwork 
version too
  it now installs libmolletnetwork5.so.SOVERSION

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D6642

To: elvisangelaccio, #plasma, anthonyfieroni, apol
Cc: jriddell, anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas


D6749: Use CMAKE_INSTALL_FULL_LIBEXECDIR

2017-07-17 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes.
Closed by commit R838:718029526e32: Use CMAKE_INSTALL_FULL_LIBEXECDIR (authored 
by arojas).

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6749?vs=16804&id=16805

REVISION DETAIL
  https://phabricator.kde.org/D6749

AFFECTED FILES
  data/org.freedesktop.impl.portal.desktop.kde.cmake.in

To: arojas, jgrulich, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas


D6749: Use CMAKE_INSTALL_FULL_LIBEXECDIR

2017-07-17 Thread Jan Grulich
jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Tested in Fedora, looks it is working.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6749

To: arojas, jgrulich, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas


D6749: Use CMAKE_INSTALL_FULL_LIBEXECDIR

2017-07-17 Thread Antonio Rojas
arojas created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  With CMAKE_INSTALL_LIBEXECDIR the dbus service file could get a relative 
path, which would break library location at runtime.

TEST PLAN
  Compiled with CMAKE_INSTALL_LIBEXECDIR=lib, running xdg-desktop-portal 
doesn't crash anymore.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6749

AFFECTED FILES
  data/org.freedesktop.impl.portal.desktop.kde.cmake.in

To: arojas, jgrulich, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas


D5227: Add a configuration option to hide the show password button

2017-07-17 Thread Fabian Vogt
fvogt abandoned this revision.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D5227

To: fvogt, #plasma, graesslin
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas


D6631: Fix compilation with strict libc (such as musl)

2017-07-17 Thread Ben Cooksley
bcooksley added a comment.


  Clang doesn't seem to like this: 
https://build.kde.org/job/Plasma%20ksysguard%20kf5-qt5%20FreeBSDQt5.7/4/console

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D6631

To: mpyne, #plasma, mart
Cc: bcooksley, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas