Plasma and kai uwe win akademy award
Plasma has won the akademy award for best application and especially for kai uwe as one of the hardest working and the best looking developer on the team
D6853: Reset most_recently_raised when removing ShellClient
This revision was automatically updated to reflect the committed changes. Closed by commit R108:7eb05552ca0d: Reset most_recently_raised when removing ShellClient (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6853?vs=17062=17065 REVISION DETAIL https://phabricator.kde.org/D6853 AFFECTED FILES workspace.cpp To: graesslin, #plasma, #kwin, davidedmundson Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
D6853: Reset most_recently_raised when removing ShellClient
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH unset-most-recently-raised REVISION DETAIL https://phabricator.kde.org/D6853 To: graesslin, #plasma, #kwin, davidedmundson Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
D6853: Reset most_recently_raised when removing ShellClient
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY This time without a test case that could trigger a crash as the only reading usage of the variable could luckily not crash. REPOSITORY R108 KWin BRANCH unset-most-recently-raised REVISION DETAIL https://phabricator.kde.org/D6853 AFFECTED FILES workspace.cpp To: graesslin, #plasma, #kwin Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
D6852: Reset last_active_client when a ShellClient is removed
This revision was automatically updated to reflect the committed changes. Closed by commit R108:bd158a632100: Reset last_active_client when a ShellClient is removed (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6852?vs=17060=17061 REVISION DETAIL https://phabricator.kde.org/D6852 AFFECTED FILES autotests/integration/x11_client_test.cpp workspace.cpp To: graesslin, #kwin, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
D6852: Reset last_active_client when a ShellClient is removed
graesslin added a comment. In https://phabricator.kde.org/D6852#127904, @davidedmundson wrote: > there's 3 other differences between removeClient that I think should also be here: yep I know, guess what I will work on next ;-) should_get_focus is btw. currently not yet a problem as a ShellClient never gets added to that list. REPOSITORY R108 KWin BRANCH fix-last-active-client-wayland REVISION DETAIL https://phabricator.kde.org/D6852 To: graesslin, #kwin, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
D6852: Reset last_active_client when a ShellClient is removed
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. there's 3 other differences between removeClient that I think should also be here: --- should_get_focus.removeAll(c); (this looks like it could lead to a similar crash) --- if (c == most_recently_raised) most_recently_raised = 0; --- #ifdef KWIN_BUILD_TABBOX if (tabBox->isDisplayed()) tabBox->reset(true); #endif REPOSITORY R108 KWin BRANCH fix-last-active-client-wayland REVISION DETAIL https://phabricator.kde.org/D6852 To: graesslin, #kwin, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
D6852: Reset last_active_client when a ShellClient is removed
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The last_active_client is set when an AbstractClient gets activated. For the X11 case the last_active_client was getting reset to nullptr when the last_active_client gets destroyed. But for the ShellClient that did not yet happen. This could result in a crash. This change addresses the problem and adds a test case which triggered the crash. The condition of the crash are difficult to generate though - it took me about an hour to write the test for the crash. 1. Wayland client must be active 2. Explicit focus to null (no active client) 3. destroy Wayland window 4. X11 client which sets focus on itself without interaction with window manager TEST PLAN test case no longer crashes REPOSITORY R108 KWin BRANCH fix-last-active-client-wayland REVISION DETAIL https://phabricator.kde.org/D6852 AFFECTED FILES autotests/integration/x11_client_test.cpp workspace.cpp To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
D6851: Updated to newer version
Aiix created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Updated to Newer Version Ref https://phabricator.kde.org/T6570 Changelog: 1. added: New conversation model allows visual feedback for skill results 2. added: Webview integration for skill html type data 3. added: New conversation animation and logo redesign to match upstream changes inside plasmoid and within notificiation messages 4. added: Possible fix for connection error, reconnect on error detection 5. added: Inbuilt Installation feature for all skills listed in mycroft-skills directly from the plasmoid using MSM Skill Installer 6. added: Pin to desktop, Drag and Drop to conversation area for Image/File Recognition type skills 7. added: To settings ability to set custom websocket's path 8. added: To settings ability to set custom drag and drop (Image/File) recoginition command 9. changed: Redesign for better space management and dedicated animations bar 10. removed: Mycroft plasma skills from default installation, plasma specific skills should be installed from Plasmoid/MSM/Manually REPOSITORY R846 Mycroft Plasma integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D6851 AFFECTED FILES CMakeLists.txt PACKAGING.readme Readme.md image/breeze-dark/apps/16/mycroft-plasma-appicon.svg image/breeze-dark/apps/32/mycroft-plasma-appicon.svg image/breeze/apps/16/mycroft-plasma-appicon.svg image/breeze/apps/32/mycroft-plasma-appicon.svg mycroft/skills/mycroft-activities-plasma-skill/.directory mycroft/skills/mycroft-activities-plasma-skill/LICENSE mycroft/skills/mycroft-activities-plasma-skill/README.md mycroft/skills/mycroft-activities-plasma-skill/__init__.py mycroft/skills/mycroft-activities-plasma-skill/dialog/en-us/activities.create.dialog mycroft/skills/mycroft-activities-plasma-skill/dialog/en-us/activities.remove.dialog mycroft/skills/mycroft-activities-plasma-skill/dialog/en-us/activities.show.dialog mycroft/skills/mycroft-activities-plasma-skill/dialog/en-us/activities.stop.dialog mycroft/skills/mycroft-activities-plasma-skill/dialog/en-us/activities.switch.dialog mycroft/skills/mycroft-activities-plasma-skill/test/intent/sample1.intent.json mycroft/skills/mycroft-activities-plasma-skill/test/intent/sample2.intent.json mycroft/skills/mycroft-activities-plasma-skill/test/intent/sample3.intent.json mycroft/skills/mycroft-activities-plasma-skill/test/intent/sample4.intent.json mycroft/skills/mycroft-activities-plasma-skill/test/intent/sample5.intent.json mycroft/skills/mycroft-activities-plasma-skill/vocab/en-us/ActivitiesCreateKeyword.voc mycroft/skills/mycroft-activities-plasma-skill/vocab/en-us/ActivitiesRemoveKeyword.voc mycroft/skills/mycroft-activities-plasma-skill/vocab/en-us/ActivitiesShowKeyword.voc mycroft/skills/mycroft-activities-plasma-skill/vocab/en-us/ActivitiesStopKeyword.voc mycroft/skills/mycroft-activities-plasma-skill/vocab/en-us/ActivitiesSwitchKeyword.voc mycroft/skills/mycroft-amarok-player-plasma-skill/LICENSE mycroft/skills/mycroft-amarok-player-plasma-skill/README.md mycroft/skills/mycroft-amarok-player-plasma-skill/__init__.py mycroft/skills/mycroft-amarok-player-plasma-skill/dialog/en-us/amarok.next.dialog mycroft/skills/mycroft-amarok-player-plasma-skill/dialog/en-us/amarok.pause.dialog mycroft/skills/mycroft-amarok-player-plasma-skill/dialog/en-us/amarok.play.dialog mycroft/skills/mycroft-amarok-player-plasma-skill/dialog/en-us/amarok.previous.dialog mycroft/skills/mycroft-amarok-player-plasma-skill/dialog/en-us/amarok.stop.dialog mycroft/skills/mycroft-amarok-player-plasma-skill/test/intent/sample1.intent.json mycroft/skills/mycroft-amarok-player-plasma-skill/test/intent/sample2.intent.json mycroft/skills/mycroft-amarok-player-plasma-skill/test/intent/sample3.intent.json mycroft/skills/mycroft-amarok-player-plasma-skill/test/intent/sample4.intent.json mycroft/skills/mycroft-amarok-player-plasma-skill/test/intent/sample5.intent.json mycroft/skills/mycroft-amarok-player-plasma-skill/vocab/en-us/AmarokNextKeyword.voc mycroft/skills/mycroft-amarok-player-plasma-skill/vocab/en-us/AmarokPauseKeyword.voc mycroft/skills/mycroft-amarok-player-plasma-skill/vocab/en-us/AmarokPlayKeyword.voc mycroft/skills/mycroft-amarok-player-plasma-skill/vocab/en-us/AmarokPreviousKeyword.voc mycroft/skills/mycroft-amarok-player-plasma-skill/vocab/en-us/AmarokStopKeyword.voc mycroft/skills/mycroft-internals-plasma-skill/.directory mycroft/skills/mycroft-internals-plasma-skill/LICENSE mycroft/skills/mycroft-internals-plasma-skill/README.md mycroft/skills/mycroft-internals-plasma-skill/__init__.py mycroft/skills/mycroft-internals-plasma-skill/dialog/en-us/internals.lock.dialog mycroft/skills/mycroft-internals-plasma-skill/dialog/en-us/internals.logout.dialog
