D6908: Nullptr check for rootInfo when setting active client

2017-07-25 Thread Martin Flöser 
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  Preparation for X free KWin. Code is called for both X11 and Wayland
  windows. So make it not crash if we would not have an X server.

REPOSITORY
  R108 KWin

BRANCH
  rootinfo-setActiveWindow-nullptr-check

REVISION DETAIL
  https://phabricator.kde.org/D6908

AFFECTED FILES
  activation.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol, mart, lukas

Re: Wayland App Testing BOF

2017-07-25 Thread David Edmundson 
On Tue, Jul 25, 2017 at 9:50 PM, Martin Flöser  wrote:


Am 2017-07-25 14:44, schrieb David Edmundson:
>
>> Notes from the Wayland BOF:
>>
>
> thanks for having such a BOF!
>
> Anytime.
We missed you obviously.


>
> In KWin I btw. use flags. I have an X11 and a Wayland flag to indicate
> whether the problem is specific to Wayland, to X11 or both.
>

Yep, we share that flag for plasmashell too, but new bugzilla that weird
multipliciity where you have a flag per user, and then you can set wayland
to "+" or "-" which I think does make sense for kwin/plasma case, but not
elsewhere.

Given keywords (unintuitively) aren't actually free text, they end up
making better flags than flags do.

D6175: Fix build with future glibc (major/minor macros), BSD compatible

2017-07-25 Thread Andreas Sturmlechner 
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:35c278e52537: Fix build with future glibc (major/minor 
macros), BSD compatible (authored by asturmlechner).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6175?vs=17180=17186

REVISION DETAIL
  https://phabricator.kde.org/D6175

AFFECTED FILES
  logind.cpp

To: asturmlechner, #plasma, graesslin
Cc: graesslin, plasma-devel, kwin, #kwin, adridg, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

Re: Wayland App Testing BOF

2017-07-25 Thread Martin Flöser 

Am 2017-07-25 14:44, schrieb David Edmundson:

Notes from the Wayland BOF:


thanks for having such a BOF!



Went through the (draft) tablet protocol spec with a krita dev, they
confirmed it had everything they need. Now "just" a case of
implementing it in kwayland, kwin and Qt.


good! Unfortunately it's a huge task. Just implementing the libinput 
bits is quite a lot (and I'm not sure whether i truly understand these 
kind of input devices - very glad that my notebook at least has one 
included).




KMail now works in wayland - volker to look into removing the forced
qputenv

We have a bunch of bugs reported (to report) from apps ranging from a
crash in Kalzium to some bizarre behaviour in dragon player embedding
VLC - Davide Bettio to upload his reports.

Kwin wayland works in KVM (which was news to me)


To me as well!



We now have a global Bugzilla keyword "wayland" for easier searching.


In KWin I btw. use flags. I have an X11 and a Wayland flag to indicate 
whether the problem is specific to Wayland, to X11 or both.


Cheers
Martin

D5705: AppMenu: Don't call AboutToShow on LayoutUpdated

2017-07-25 Thread David Rosca 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:dba0f80288b4: AppMenu: Don't call AboutToShow on 
LayoutUpdated (authored by drosca).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D5705?vs=14124=17183#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5705?vs=14124=17183

REVISION DETAIL
  https://phabricator.kde.org/D5705

AFFECTED FILES
  appmenu/menuimporter.cpp
  appmenu/menuimporter.h

To: drosca, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6175: Fix build with future glibc (major/minor macros), BSD compatible

2017-07-25 Thread Martin Flöser 
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.


  Please reference bug 376505

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6175

To: asturmlechner, #plasma, graesslin
Cc: graesslin, plasma-devel, kwin, #kwin, adridg, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6175: Fix build with future glibc (major/minor macros), BSD compatible

2017-07-25 Thread Andreas Sturmlechner 
asturmlechner updated this revision to Diff 17180.
asturmlechner added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  Switch to master

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6175?vs=15332=17180

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6175

AFFECTED FILES
  logind.cpp

To: asturmlechner, #plasma
Cc: graesslin, plasma-devel, kwin, #kwin, adridg, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6899: support X-KDE-OnlyShowOnQtPlatforms

2017-07-25 Thread Marco Martin 
mart updated this revision to Diff 17176.
mart added a comment.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.


  readstringlist

REPOSITORY
  R297 KDED

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6899?vs=17175=17176

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6899

AFFECTED FILES
  src/kded.cpp
  src/kded.h
  src/kdedmodule.desktop

To: mart, #frameworks, #plasma
Cc: plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6899: support X-KDE-OnlyShowOnQtPlatforms

2017-07-25 Thread Marco Martin 
mart marked 2 inline comments as done.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D6899

To: mart, #frameworks, #plasma
Cc: plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6899: support X-KDE-OnlyShowOnQtPlatforms

2017-07-25 Thread Marco Martin 
mart updated this revision to Diff 17177.
mart added a comment.


  less blanks

REPOSITORY
  R297 KDED

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6899?vs=17176=17177

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6899

AFFECTED FILES
  src/kded.cpp
  src/kded.h

To: mart, #frameworks, #plasma
Cc: plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6679: Treat Button/ToolButton labels as plaintext

2017-07-25 Thread Fabian Vogt 
This revision was automatically updated to reflect the committed changes.
fvogt marked an inline comment as done.
Closed by commit R242:48a8245db4d8: Treat Button/ToolButton labels as plaintext 
(authored by fvogt).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6679?vs=16649=17174

REVISION DETAIL
  https://phabricator.kde.org/D6679

AFFECTED FILES
  src/declarativeimports/plasmastyle/ButtonStyle.qml
  src/declarativeimports/plasmastyle/ToolButtonStyle.qml
  src/declarativeimports/plasmastyle/private/Util.js

To: fvogt, #plasma, broulik, davidedmundson
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6679: Treat Button/ToolButton labels as plaintext

2017-07-25 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6679

To: fvogt, #plasma, broulik, davidedmundson
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6898: [Pager] Remove unused utils.js

2017-07-25 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:4bcbecd2e913: [Pager] Remove unused utils.js (authored by 
broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6898?vs=17171=17173

REVISION DETAIL
  https://phabricator.kde.org/D6898

AFFECTED FILES
  applets/pager/package/contents/code/utils.js
  applets/pager/package/contents/ui/main.qml

To: broulik, #plasma, hein, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6898: [Pager] Remove unused utils.js

2017-07-25 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6898

To: broulik, #plasma, hein, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

Wayland App Testing BOF

2017-07-25 Thread David Edmundson 
Notes from the Wayland BOF:

Went through the (draft) tablet protocol spec with a krita dev, they
confirmed it had everything they need. Now "just" a case of implementing it
in kwayland, kwin and Qt.

KMail now works in wayland - volker to look into removing the forced qputenv

We have a bunch of bugs reported (to report) from apps ranging from a crash
in Kalzium to some bizarre behaviour in dragon player embedding VLC -
Davide Bettio to upload his reports.

Kwin wayland works in KVM (which was news to me)

We now have a global Bugzilla keyword "wayland" for easier searching.

Most importantly we branstormed a possibly much better solution to the
problem of popups not having a parent set. Currently in Qt it just creates
a top level, now, if the window is a popup and a transient parent is not
explicitly set we set it to what Qt thinks is the active window. This
covers far more cases than the previous QMenu hack and is much more
generic. Marco implemented this as
https://codereview.qt-project.org/#/c/200788/
(another change incoming for fixing checking windowType is a popup
everywhere)

David

D6898: [Pager] Remove unused utils.js

2017-07-25 Thread Kai Uwe Broulik 
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

TEST PLAN
  Grepped for utils in applets/pager, didn't find anything. Pager still works. 
Probably from a time where most of its logic was in QML

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6898

AFFECTED FILES
  applets/pager/package/contents/code/utils.js
  applets/pager/package/contents/ui/main.qml

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6894: [Containment Interface] always emit contextualActionsAboutToShow for containment

2017-07-25 Thread Kai Uwe Broulik 
broulik added a comment.


  Yes

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6894

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6894: [Containment Interface] always emit contextualActionsAboutToShow for containment

2017-07-25 Thread David Edmundson 
davidedmundson added a comment.


  > Right clicked an applet
  
  so if (applet) would have been true?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6894

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6894: [Containment Interface] always emit contextualActionsAboutToShow for containment

2017-07-25 Thread Kai Uwe Broulik 
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  The applet context menu contains containment actions which might be outdated 
if we don't call this.

TEST PLAN
  Right clicked an applet on my desktop, the "Folder View Settings" submenu 
containing the desktop containment actions no longer showed actions like "Empty 
Trash"

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6894

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas