D6933: [Component Chooser] Update http(s) scheme handler when changing default browser
dfaure added a comment. In https://phabricator.kde.org/D6933#129446, @broulik wrote: > > I suppose updating the handler for text/html would make sense too, so that clicking on a local HTML file opens the same webbrowser. > > Well, KRun has a special case for text/html to always open them in the default browser, no matter what. So you cannot actually have Kate as your default app for HTML :D Ah, I see. (comes from https://git.reviewboard.kde.org/r/103524). I think the reasoning was "after I set Firefox as my browser app, local HTML files still open in konqueror... bug!!! I shouldn't have to configure it twice". But actually we get more flexibility if we don't mix up the two things. I.e. a user should be able to choose a browser *and* choose kate for local html files. So I vote for 1. setting the handler for text/html from here (if it's another BrowserApp) 2. removing the text/html hack in KRun This way in the simple case, both HTTP and *.html open in your preferred browser, but for more advanced users it's still possible to open HTML files in something else. PS: keditbookmarks shows up in the combo because it's been tagged WebBrowser, I guess for menu organization purposes. But it's not a webbrowser, so I'm not sure how to fix that... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6933 To: broulik, #plasma, dfaure Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6970: Bug 382834 Patch
dgreengas created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Patch created per bug report https://bugs.kde.org/show_bug.cgi?id=382834 Per the QML specification, the animation Easing.InQuad should be specified with easing.type, not easing. TEST PLAN run kscreenlocker --testing The console output should not display a warning about the animation. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6970 AFFECTED FILES lookandfeel/contents/lockscreen/LockScreenUi.qml To: dgreengas, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
Re: Review Request 130205: View Styles
> On Juli 28, 2017, 9:14 vorm., Sebastian Kügler wrote: > > Why? > > > > The mode chooser is hidden well enough that it doesn't produce visual noise > > and not a lot of extra burden on the user (since there's UI for switching > > anyway, 2 or 3 options doesn't make it a lot lighter). Moreover, the tree > > view is something users seem to actually like and use, and the code for it > > has aged well and doesn't require maintenance, so it's not a lot of > > technical debt to carry around. > > > > > > This patch doesn't remove the actual code, it just removes the entry which > > essentially leaves dead code around, so the patch is technically > > insufficient. this patch didn't remove anything it's only change in System Settings -> Configure dialog -> View Style the list to Tree View Icon View Sidebar View Instead of Classic Tree View Icon View Sidebar View - Andreas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130205/#review103488 --- On Juli 26, 2017, 9:54 nachm., Andreas Kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130205/ > --- > > (Updated Juli 26, 2017, 9:54 nachm.) > > > Review request for Plasma. > > > Repository: systemsettings > > > Description > --- > > as system settings has now 3 different views the classic should be removed > from the tree view in configure dialogue. > > > Diffs > - > > classic/settings-classic-view.desktop 57cd2a3 > > Diff: https://git.reviewboard.kde.org/r/130205/diff/ > > > Testing > --- > > none. > > > Thanks, > > Andreas Kainz > >
D6571: Delete all Wayland connections by plugins prior to own Wayland connection
graesslin added a comment. Good news: the combo worked! The crashing useractionsmenu test just passed on build.kde.org. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6571 To: graesslin, #kwin, #plasma, mart, davidedmundson Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6571: Delete all Wayland connections by plugins prior to own Wayland connection
This revision was automatically updated to reflect the committed changes. Closed by commit R108:06433997e8d9: Emit connectionDied on all Wayland connections of plugins on teardown (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6571?vs=17299=17332 REVISION DETAIL https://phabricator.kde.org/D6571 AFFECTED FILES wayland_server.cpp To: graesslin, #kwin, #plasma, mart, davidedmundson Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129691/#review103497 --- So can we commit this then? - Albert Astals Cid On Dec. 27, 2016, 5:48 p.m., Jiri Bohac wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129691/ > --- > > (Updated Dec. 27, 2016, 5:48 p.m.) > > > Review request for Plasma and Albert Astals Cid. > > > Repository: plasma-workspace > > > Description > --- > > Update the list of country names to the current names in iso-codes > (as output by isoquery -c). > > The motivation is updating the name of Czechia as a followup to > https://git.reviewboard.kde.org/r/129644/ > As suggested by Albert Astals Cid, fixing the name in i10n is not enough: > country names are hardcoded in many places and they need to be fixed > separately. > > > Diffs > - > > applets/digital-clock/plugin/timezonesi18n.cpp 10650f8 > > Diff: https://git.reviewboard.kde.org/r/129691/diff/ > > > Testing > --- > > > Thanks, > > Jiri Bohac > >
D6952: Properly render XWayland windows in SceneQPainter
graesslin added a comment. In https://phabricator.kde.org/D6952#129679, @davidedmundson wrote: > Seems ok, but I'm lost as to why Xwayland clients have a different buffer size in the first place. It is due to the reparenting of the window to support window decorations. The actual window becomes larger. You can find similar adjustments in the code building the vertices for OpenGL. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6952 To: graesslin, #kwin, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6964: Force Plasma style for QQC2 in applets
mart added a comment. In https://phabricator.kde.org/D6964#129762, @davidedmundson wrote: > > [13:51] <notmart> hmm, still random failures in loading components > > [13:58] <notmart> gaah, import of a subdirectory still breaks > > Is this fixed? no, that's the problem of having to have a "private" subfolder in both themes i mentioned in the commit message, will need to look deeper in qml parsing to figure out what's going wrong and maybe patching qt, if both the style that we replace and the new one are controlled by us, that's workable around (as they happen to have the same directory structure) fragile but works > Also we'll need to maybe look at changing how kirigami does its theme stuff so we can make that work. kirigami does it exactly as qqc2 does, so should work as well. also in that case, we should make sure that both kirigami themes which we both control have the same directory structure REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6964 To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6964: Force Plasma style for QQC2 in applets
davidedmundson added a comment. > [13:51] <notmart> hmm, still random failures in loading components > [13:58] <notmart> gaah, import of a subdirectory still breaks Is this fixed? Also we'll need to maybe look at changing how kirigami does its theme stuff so we can make that work. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6964 To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6964: Force Plasma style for QQC2 in applets
mart updated this revision to Diff 17325. mart added a comment. comment useless debug REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6964?vs=17324=17325 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6964 AFFECTED FILES src/plasmaquick/appletquickitem.cpp src/plasmaquick/packageurlinterceptor.cpp src/plasmaquick/packageurlinterceptor.h src/plasmaquick/view.cpp To: mart, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6964: Force Plasma style for QQC2 in applets
mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY using the qml url interceptor, rewrite imports in order to load always the plasma styled qqc2 controls in plasmoids and plasma views. As is per-engine, is possible to load controls with qstyle theme in configuration dialogs and plasma style in plasmoids. Note: this replaces just the style org.kde.desktop to Plasma and not every style (so with Material set as QT_QUICK_CONTROLS_STYLE environment variable plasma would load controls with material style) because we can control both org.kde.desktop and Plasma styles: they must have the same subdirectories as unlike files, their existence is checked before the rewrite (in our case, "private"), so in order to work they must exist in both styles TEST PLAN a qqc2 button in a plasmoid has the plasma style, in a config dialog has the qwidget style. rewrite works only from org.kde.desktop to Plasma and not from other styles, due to the existence of the "private" subdirectory REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6964 AFFECTED FILES src/plasmaquick/appletquickitem.cpp src/plasmaquick/packageurlinterceptor.cpp src/plasmaquick/packageurlinterceptor.h src/plasmaquick/view.cpp To: mart, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
Re: Re: DrKonqi dependencies
Please can someone review kde:scratch/davidedmundson/drkonqi David
D6952: Properly render XWayland windows in SceneQPainter
davidedmundson added a comment. Seems ok, but I'm lost as to why Xwayland clients have a different buffer size in the first place. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6952 To: graesslin, #kwin, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6571: Delete all Wayland connections by plugins prior to own Wayland connection
davidedmundson accepted this revision. REPOSITORY R108 KWin BRANCH connection-cleanup REVISION DETAIL https://phabricator.kde.org/D6571 To: graesslin, #kwin, #plasma, mart, davidedmundson Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
Re: Review Request 130206: systemsettings tooltip items non italic
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130206/#review103489 --- Ship it! Ship It! - Sebastian Kügler On July 26, 2017, 10:14 p.m., Andreas Kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130206/ > --- > > (Updated July 26, 2017, 10:14 p.m.) > > > Review request for Plasma. > > > Repository: systemsettings > > > Description > --- > > small change only to reduce visual differences. Tooltip header is bold, > everything else is default font. > > > Diffs > - > > app/ToolTips/tooltipmanager.cpp e1c6e16 > > Diff: https://git.reviewboard.kde.org/r/130206/diff/ > > > Testing > --- > > > Thanks, > > Andreas Kainz > >
Re: Review Request 130205: View Styles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130205/#review103488 --- Why? The mode chooser is hidden well enough that it doesn't produce visual noise and not a lot of extra burden on the user (since there's UI for switching anyway, 2 or 3 options doesn't make it a lot lighter). Moreover, the tree view is something users seem to actually like and use, and the code for it has aged well and doesn't require maintenance, so it's not a lot of technical debt to carry around. This patch doesn't remove the actual code, it just removes the entry which essentially leaves dead code around, so the patch is technically insufficient. - Sebastian Kügler On July 26, 2017, 9:54 p.m., Andreas Kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130205/ > --- > > (Updated July 26, 2017, 9:54 p.m.) > > > Review request for Plasma. > > > Repository: systemsettings > > > Description > --- > > as system settings has now 3 different views the classic should be removed > from the tree view in configure dialogue. > > > Diffs > - > > classic/settings-classic-view.desktop 57cd2a3 > > Diff: https://git.reviewboard.kde.org/r/130205/diff/ > > > Testing > --- > > none. > > > Thanks, > > Andreas Kainz > >
D6946: Emit connectionDied if the QPA is destroyed
This revision was automatically updated to reflect the committed changes. Closed by commit R127:7dd186258620: Emit connectionDied if the QPA is destroyed (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6946?vs=17273=17311 REVISION DETAIL https://phabricator.kde.org/D6946 AFFECTED FILES src/client/connection_thread.cpp To: davidedmundson, graesslin Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6727: Destroy all kwayland objects created by registry when it is destroyed
This revision was automatically updated to reflect the committed changes. Closed by commit R127:b669d4148a39: Destroy all kwayland objects created by registry when it is destroyed (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6727?vs=17272=17312 REVISION DETAIL https://phabricator.kde.org/D6727 AFFECTED FILES autotests/client/test_wayland_registry.cpp src/client/blur.h src/client/contrast.h src/client/datadevice.h src/client/datadevicemanager.h src/client/dataoffer.h src/client/datasource.h src/client/dpms.h src/client/event_queue.h src/client/fakeinput.h src/client/idle.h src/client/output.cpp src/client/output.h src/client/outputconfiguration.h src/client/outputdevice.cpp src/client/outputdevice.h src/client/outputmanagement.h src/client/plasmashell.h src/client/plasmawindowmanagement.h src/client/pointerconstraints.h src/client/pointergestures.h src/client/registry.cpp src/client/registry.h src/client/relativepointer.h src/client/seat.h src/client/server_decoration.h src/client/shadow.h src/client/shm_pool.h src/client/slide.h src/client/surface.h src/client/textinput.h src/client/xdgshell.h To: davidedmundson, graesslin Cc: graesslin, plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D6763: Fix app icon button in window decos with high DPI in previews.
This revision was automatically updated to reflect the committed changes. Closed by commit R31:e827fa080137: Fix app icon button in window decos with high DPI in previews. (authored by davidedmundson). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6763?vs=16851=17310 REVISION DETAIL https://phabricator.kde.org/D6763 AFFECTED FILES kdecoration/breezebutton.cpp To: davidedmundson, #plasma, mart Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D6957: Add link about additional configuration option to baloo kcm docbook
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6957 To: lueck, #documentation, #plasma, aacid Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D3484: Center systemmonitor window properly on multi-screen setup
aacid added a comment. Should we commit this then? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3484 To: valeriymalov, #plasma_workspaces, aacid, mart Cc: davidedmundson, sebas, aacid, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas
D6956: Stop unnecessarily killing IBus when applying keyboard layouts config
xapienz added a comment. I think it would also be good to remove the line `static bool preInitialize();` in kcms/keyboard/xkb_helper.h, because it will be unused. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6956 To: achauvel Cc: xapienz, plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
