date:20170907

D5250: cursors: Make build scripts more generic; build more sizes

2017-09-07 Thread Nathaniel Graham

ngraham added a reviewer: subdiff.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D5250

To: jamesl, #plasma, subdiff
Cc: kvermette, subdiff, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7716: Support filepaths with accents

2017-09-07 Thread Aleix Pol Gonzalez

apol added inline comments.

INLINE COMMENTS

> davidedmundson wrote in sddmauthhelper.cpp:228
> in my case I need to change the locale of my helper, not just subprocesses, 
> which means I need to set it before I extract args from the user.

Maybe it could still be done by `KAuth::HelperSupport::helperMain` and fix it 
for everyone everywhere?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D7716

To: davidedmundson, #plasma
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D7260: System tray icon's context menu isn't updated properly in plasma/x11

2017-09-07 Thread Christoph Feck

cfeck added a comment.


  David, can you test again?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7260

To: i.Dark_Templar, #plasma, davidedmundson
Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7648: Fix ksysguard not starting on plasmoid click

2017-09-07 Thread Mladen Milinkovic

maxrd2 added a comment.


  In https://phabricator.kde.org/D7648#142638, @davidedmundson wrote:
  
  > Thanks, but do you know why the apps datasource doesn't have that entry 
after a while?
  
  
  I've managed to get some more insight into original problem.
  It seems that after some system updates, desktop database gets updated, and 
that triggers a bunch of onSourcesChanged+onSourcesRemoved events, followed by 
a bunch onSourcesChanged+onSourceAdded events.
  Since I'm on rolling distro i get updates very frequently and this problem 
happens to me pretty frequently.
  
  After .desktop database is updated these events are fired on 'apps' 
dataengine:
  
 bunch of events for various .desktop files
Sep 08 00:44:19
  onSourcesChanged()
  onSourceDisconnected() org.kde.ksysguard.desktop
  onConnectedSourcesChanged()
  onSourceRemoved() org.kde.ksysguard.desktop
 bunch of events for various .desktop files
Sep 08 00:47:01
  onSourceAdded() org.kde.ksysguard.desktop
 bunch of events for various .desktop files
Sep 08 00:47:43
  onSourceRemoved() org.kde.ksysguard.desktop
 bunch of events for various .desktop files
Sep 08 00:49:54
  onSourceAdded() org.kde.ksysguard.desktop
 bunch of events for various .desktop files
  
  No onSourceConnected() event was fired for "org.kde.ksysguard.desktop" after 
it has been disconnected -> removed -> added -> removed -> added.
  It wasn't connected to datasource again after it was updated and re-added and 
thus apps.data["org.kde.ksysguard.desktop"] became undefined.
  
  I can look into fixing/changing apps dataengine and making it re-connect 
"lost" sources if that is desired.
  Is that supposed to happen automatically or is qml script supposed to 
re-connect "lost" sources during onSourceAdded event?

REPOSITORY
  R114 Plasma Addons

BRANCH
  launch-change

REVISION DETAIL
  https://phabricator.kde.org/D7648

To: maxrd2, #plasma, davidedmundson
Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7726: Fix ignoring of certain popup windows by the windowmapper

2017-09-07 Thread Fabian Vogt

fvogt created this revision.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  At least on vivaldi 1.11, plasma-browser-extension broke popups
  as the windowmapper page replaced the entire content and the popup
  closed itself shortly thereafter.
  Those popups have type === "normal", but the JSON-encoded extData
  field has a windowType member that contains the truth...

TEST PLAN
  Without this, google hangouts is broken. With this, google hangouts
  works again.

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  popupfix

REVISION DETAIL
  https://phabricator.kde.org/D7726

AFFECTED FILES
  extension/extension.js

To: fvogt, broulik, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D6591: XdgV6 - Kwin side

2017-09-07 Thread Martin Flöser

graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> shell_client.cpp:222
> +
> +connect(static_cast *>(m_xdgShellSurface->global()), ::pingDelayed,
> +m_xdgShellSurface, [this](qint32 serial) {

maybe instead of the three casts just store a local variable?

  auto global = (static_cast(m_xdgShellSurface->global());

> shell_client.cpp:231-239
> +connect(static_cast *>(m_xdgShellSurface->global()), ::pingTimeout,
> +m_xdgShellSurface, [this](qint32 serial) {
> +auto it = m_pingSerials.find(serial);
> +if (it != m_pingSerials.end()) {
> +qCDebug(KWIN_CORE) << "Final ping timeout, asking to 
> kill:" << caption();
> +killWindow();
> +m_pingSerials.erase(it);

You should only kill if the ping reason is close. This would also ping for 
focus, wouldn't it?

> shell_client.cpp:277-280
> +connect(m_xdgShellPopup, ::grabbed, this, 
> [this](SeatInterface *seat, quint32 serial) {
> +Q_UNUSED(serial)
> +seat->setFocusedPointerSurface(surface());
> +});

this needs to go through our PointerInputRedirection code, otherwise 
SeatInterface and PointerInputRedirection get out of sync. From my 
understanding that should be ::popupGrab?

> shell_client.cpp:608-609
>  if (m_xdgShellSurface && isCloseable()) {
> -m_xdgShellSurface->close();
> -return;
> -}
> -if (m_qtExtendedSurface && isCloseable()) {
> +const qint32 pingSerial = static_cast *>(m_xdgShellSurface->global())->ping();
> +m_pingSerials.insert(pingSerial, CloseWindow);
> +} else if (m_qtExtendedSurface && isCloseable()) {

just wondering: isn't there a close() missing? It's only pinging...

> shell_client.h:44
>  public:
> +enum PingReason {
> +CloseWindow = 0,

please use enum class for new enums.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6591

To: davidedmundson, #plasma, graesslin
Cc: graesslin, kwin, plasma-devel, #kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Breeze] [Bug 363147] Breeze cursors should have more sizes (patch included)

2017-09-07 Thread Roman Gilg

https://bugs.kde.org/show_bug.cgi?id=363147

--- Comment #18 from Roman Gilg  ---
Hi Brennan,

from my side the patch worked. It felt though like there were some performance
issues when using the many sizes (since it loops through them), but that might
be also in my imagination.

The thing is Ken had written the original script and I pinged him in the review
on Phabricator for his opinion, but he didn't yet respond to it.

If you can draw his attention to the review it has a chance to be revived and
become accepted. I'm currently without enough time on my hand to organize it
(writing on my thesis).

-- 
You are receiving this mail because:
You are the assignee for the bug.

D3805: Per-activity favorites (Final, again?)

2017-09-07 Thread Ivan Čukić

ivan updated this revision to Diff 19283.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3805?vs=19263=19283

REVISION DETAIL
  https://phabricator.kde.org/D3805

AFFECTED FILES
  CMakeLists.txt
  applets/kicker/CMakeLists.txt
  applets/kicker/package/contents/code/tools.js
  applets/kicker/package/contents/config/main.xml
  applets/kicker/package/contents/ui/ActionMenu.qml
  applets/kicker/package/contents/ui/main.qml
  applets/kicker/plugin/abstractentry.cpp
  applets/kicker/plugin/appentry.cpp
  applets/kicker/plugin/appentry.h
  applets/kicker/plugin/computermodel.cpp
  applets/kicker/plugin/computermodel.h
  applets/kicker/plugin/computermodel.h.orig
  applets/kicker/plugin/favoritesmodel.cpp
  applets/kicker/plugin/favoritesmodel.h
  applets/kicker/plugin/kastatsfavoritesmodel.cpp
  applets/kicker/plugin/kastatsfavoritesmodel.h
  applets/kicker/plugin/kickerplugin.cpp
  applets/kicker/plugin/placeholdermodel.cpp
  applets/kicker/plugin/placeholdermodel.h
  applets/kicker/plugin/recentusagemodel.cpp
  applets/kicker/plugin/rootmodel.cpp
  applets/kicker/plugin/rootmodel.h
  applets/kicker/plugin/simplefavoritesmodel.cpp
  applets/kicker/plugin/simplefavoritesmodel.h
  applets/kicker/plugin/systemmodel.cpp
  applets/kickoff/package/contents/code/tools.js
  applets/kickoff/package/contents/config/main.xml
  applets/kickoff/package/contents/ui/ActionMenu.qml
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: ivan, mart, hein
Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7669: Make AbstractEglBackend a QObject

2017-09-07 Thread Martin Flöser

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:01ddbe7d751a: Make AbstractEglBackend a QObject (authored 
by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7669?vs=19117=19282

REVISION DETAIL
  https://phabricator.kde.org/D7669

AFFECTED FILES
  abstract_egl_backend.cpp
  abstract_egl_backend.h
  composite.cpp
  plugins/platforms/drm/egl_gbm_backend.cpp
  plugins/platforms/drm/egl_gbm_backend.h
  plugins/platforms/virtual/egl_gbm_backend.cpp
  plugins/platforms/virtual/egl_gbm_backend.h
  plugins/platforms/wayland/egl_wayland_backend.cpp
  plugins/platforms/wayland/egl_wayland_backend.h

To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D7698: Pass EGL information from AbstractEglBackend to Platform instead of query

2017-09-07 Thread Martin Flöser

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:9381411b9112: Pass EGL information from 
AbstractEglBackend to Platform instead of query (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7698?vs=19236=19281

REVISION DETAIL
  https://phabricator.kde.org/D7698

AFFECTED FILES
  abstract_egl_backend.cpp
  abstract_egl_backend.h
  platform.cpp
  platform.h

To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7713: [tabbox] Properly check whether two windows belong to same application

2017-09-07 Thread Martin Flöser

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:5d9027b110be: [tabbox] Properly check whether two windows 
belong to same application (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7713?vs=19250=19280

REVISION DETAIL
  https://phabricator.kde.org/D7713

AFFECTED FILES
  tabbox/tabbox.cpp

To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D7712: Delay syncing internal window geometry to end of cycle

2017-09-07 Thread Martin Flöser

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:e0f95fd913b6: Delay syncing internal window geometry to 
end of cycle (authored by graesslin).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D7712?vs=19249=19279#toc

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7712?vs=19249=19279

REVISION DETAIL
  https://phabricator.kde.org/D7712

AFFECTED FILES
  autotests/integration/internal_window.cpp
  shell_client.cpp

To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

Re: Videoconference between KDE community and Purism regarding Librem5

2017-09-07 Thread Matthias Klumpp

Just to make sure this message gets through to all the mailinglists (I
dropped some of the CCs, because the list was rejecting this, and I
also don't know if Zlatan is subscribed to plasma-devel & co.), since
some people didn't get the next yet apparently

This is our meeting place:

2017-09-07 16:32 GMT+02:00 Zlatan Todoric :
> [...]
> I suggest Jitsi as well and I suggest just the name KDEPurismMeeting so:
> https://meet.jit.si/KDEPurismMeeting

D6764: Add font size setting to the digital clock plasmoid

2017-09-07 Thread David Edmundson

davidedmundson added a comment.


  > i don't think i like the idea of adding yet another setting on this already 
rather fragile code
  
  I think this explains why you haven't had a review, this existing code is 
already sketchy as-is :/
  But we should be trying to fix that not just all of us ignoring it. Sorry 
about that.
  
  So this clock has 4 states:
  
  1. horizontal
  2. horizontal small (date and tz appear alongside clock)
  3. vertical
  4. other ()
  
  Currently:
  1 & 2 choose the font size to fill the space vertically indefinitely
  3 chooses the font size that fits the space horizontally up to 3x normal font 
size
  4 is... frankly unreadable.
  
  With your patch:
  in states 1 and 2 you're explicitly setting the time zone label to a config 
value, and implicitly the date and TZ label to 0.7 of that.
  
I could understand logic that limits the maximiumSize to a user defined 
value, but I don't want to be in a position where the user resizes a 
panel..then has to open all the config options of each widget and adjust things.
Would keeping the fit mode but setting the maximumPixelSize to the config 
value work for you?
  
  States 3 and 4 are unchanged:
  
I don't really want to have a config option that simply does nothing. Is 
there a reason it's not changed?

REVISION DETAIL
  https://phabricator.kde.org/D6764

To: januz, #plasma, #vdg
Cc: davidedmundson, ngraham, Zren, mart, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D7723: [ListItemBase] Use section instead of disabled menu item

2017-09-07 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:31fed95b4de6: [ListItemBase] Use section instead of 
disabled menu item (authored by broulik).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7723?vs=19273=19276

REVISION DETAIL
  https://phabricator.kde.org/D7723

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: broulik, #plasma, drosca, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D6764: Add font size setting to the digital clock plasmoid

2017-09-07 Thread Diego Gangl

januz added a comment.


  //PING//
  Hey guys, the beta is starting next week. Any chance we can still land this 
or https://phabricator.kde.org/D6813 for 5.11?

REVISION DETAIL
  https://phabricator.kde.org/D6764

To: januz, #plasma, #vdg
Cc: ngraham, Zren, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D3805: Per-activity favorites (Final, again?)

2017-09-07 Thread Eike Hein

hein added a comment.


  Test failure using Kicker:
  
  1. Right-click menu entry -> Show favorite in -> All activities
  2. Verify it's shown on both activities
  3. Be in activity 1, right-click the favorite, click the checkbox item for 
activity 2, favorite disappears from activity 1 as expected
  4. Switch to activity 2 expecting to see favorite: Not there
  5. Switch back to activity 1 (favorite also not there as expected)
  6. Add another favorite to all ativities, switch back to activity 2: Missing 
favorite reappeared along with new one
  
  Addition to #4: I think another fave I had added previously had also 
disappeared and reappeared in #6.
  
  Still same broken behavior as in last test in other words. Sending output via 
email.

REVISION DETAIL
  https://phabricator.kde.org/D3805

To: ivan, mart, hein
Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7724: [ListItemBase] Open options menu on right click

2017-09-07 Thread Kai Uwe Broulik

broulik added a comment.


  We have *both* now. The visual menu button and the "non-discoverable" context 
menu accessible through right-clicking the entire area

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D7724

To: broulik, #plasma, #vdg, drosca
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7724: [ListItemBase] Open options menu on right click

2017-09-07 Thread David Rosca

drosca added a comment.


  We're back to the context menu discussion. But to me, this feels weird, the 
context menu should be opened under cursor.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D7724

To: broulik, #plasma, #vdg, drosca
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7724: [ListItemBase] Open options menu on right click

2017-09-07 Thread Kai Uwe Broulik

broulik updated this revision to Diff 19275.
broulik added a comment.


  - Also highlight menu button while context menu is open

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7724?vs=19274=19275

REVISION DETAIL
  https://phabricator.kde.org/D7724

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: broulik, #plasma, #vdg, drosca
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7724: [ListItemBase] Open options menu on right click

2017-09-07 Thread Kai Uwe Broulik

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

TEST PLAN
  The menu is still attached to the menu button regardless of where I click but 
I don't neccessarily need to aim for that tiny button anymore.
  
  Middle click to mute still works.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D7724

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: broulik, #plasma, #vdg, drosca
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7716: Support filepaths with accents

2017-09-07 Thread David Edmundson

davidedmundson added inline comments.

INLINE COMMENTS

> apol wrote in sddmauthhelper.cpp:228
> I just realized we have something similar in samba-mounter for the exact same 
> reason:
> https://cgit.kde.org/samba-mounter.git/tree/src/helper/sambahelper.cpp#n49
> 
> In this case we're forwarding the LANG from the user: in the end it's what 
> the user requested not something specific to UTF-8. Nobody is enforcing paths 
> to be utf8 AFAIK.
> 
> I wonder if we could come up with a generic solution...

in my case I need to change the locale of my helper, not just subprocesses, 
which means I need to set it before I extract args from the user.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D7716

To: davidedmundson, #plasma
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D7723: [ListItemBase] Use section instead of disabled menu item

2017-09-07 Thread David Edmundson

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D7723

To: broulik, #plasma, drosca, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7723: [ListItemBase] Use section instead of disabled menu item

2017-09-07 Thread Kai Uwe Broulik

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  It's meant to be a section so be one

TEST PLAN
  F3901868: Screenshot_20170907_165556.png 


REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D7723

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: broulik, #plasma, drosca
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7716: Support filepaths with accents

2017-09-07 Thread Aleix Pol Gonzalez

apol added inline comments.

INLINE COMMENTS

> sddmauthhelper.cpp:228
> +int main(int argc, char **argv) {
> +qputenv("LANG", "C.UTF-8");
> +return KAuth::HelperSupport::helperMain(argc, argv, 
> "org.kde.kcontrol.kcmsddm", new SddmAuthHelper());

I just realized we have something similar in samba-mounter for the exact same 
reason:
https://cgit.kde.org/samba-mounter.git/tree/src/helper/sambahelper.cpp#n49

In this case we're forwarding the LANG from the user: in the end it's what the 
user requested not something specific to UTF-8. Nobody is enforcing paths to be 
utf8 AFAIK.

I wonder if we could come up with a generic solution...

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D7716

To: davidedmundson, #plasma
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D7722: Disable DDCUtil by default

2017-09-07 Thread Jonathan Riddell

This revision was automatically updated to reflect the committed changes.
Closed by commit R122:687587ea7cbc: Disable DDCUtil by default (authored by 
jriddell).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7722?vs=19271=19272

REVISION DETAIL
  https://phabricator.kde.org/D7722

AFFECTED FILES
  CMakeLists.txt

To: jriddell, #plasma, dvogel, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Re: Plasma 5.11 repos

2017-09-07 Thread Ivan Čukić

> Is plasma-vault ready for inclusion?

Yes please


Cheers,
Ivan

Re: ddcutil .deb

2017-09-07 Thread Jonathan Riddell


I've disabled it by default for the Plasma 5.11 release

Any contributions or suggestions for how to make it stable and
releaseable very welcome.  5.12 is due at the end of January and is to
be an LTS so it would be great to have it working for then.

Jonathan



On Tue, Sep 05, 2017 at 12:07:07PM -0400, Sanford Rockowitz wrote:
> Jonathan,
> 
> Much as I'd like to see some external pressure for ddcutil's
> inclusion in distros (it's been a slow process), I think it's
> premature to be including the library version in distros. Probably
> better off for now for PowerDevil to use its own private copy.  I'm
> happy to work with you/Dorian to improve the PowerDevil code.  It
> will help identify changes that the libddcutil API needs in order to
> be more usable.  One particular are of concern I have is support for
> multi-threaded clients.  As I noted, DDC/CI operations are slow
> because of protocol mandated sleeps (typically 50 ms per operation).
> GUIs may not want to wait for operations to complete.
> 
> Regards,
> Sanford
> 
> On 09/04/2017 08:07 AM, Jonathan Riddell wrote:
> >Thanks for your comments Sanford.  The code isn't mine it's done by
> >Dorian for KDE Plasma's Powerdevil which gets a beta release next week
> >(I'm the release dude).
> >
> >Dorian please review ddcutil Sanford's comments below for changes that could 
> >be made.
> >
> >Sanford given the API/ABI stability should we be recommending distros
> >package up libddcutil and use this code or would that cause more
> >problems and we should mark it as in-development for this release?
> >
> >Jonathan
> >
> >
> >- Forwarded message from Sanford Rockowitz  -
> >
> >Date: Fri, 1 Sep 2017 10:52:29 -0400
> >From: Sanford Rockowitz 
> >To: Jonathan Riddell 
> >Subject: Re: ddcutil .deb
> >
> >Jonathan,
> >
> >I've taken a look at your powerdevil code at 
> >https://cgit.kde.org/powerdevil.git/tree/daemon/backends/upower/ddcutilbrightness.cpp.
> >It can be simplified to improve performance and reliability.
> >
> >1)  The DDCA_Display_Identifier -> DDCA_Display_Ref lookup exists to
> >allow for choosing a monitor by its characteristics, when you don't
> >already have a list of monitors to select from, e.g. on the ddcutil
> >command line.   Struct DDCA_Display_Info, returned (as an array) by
> >ddca_display_info_list(), contains field dref, which is a valid
> >DDCA_Display_Ref you can use.   See function
> >display_selection_using_ddca_get_displays() in sample file
> >demo_display_selection.c.
> >
> >The documentation could be clearer here.
> >
> >2) There's no need to look up the VCP value for the Brightness field.
> >Per the MCCS spec, it's always x10.
> >
> >3) Rather than reading and parsing the capabilities string to
> >determine if a monitor supports VCP feature code x10, it's both faster
> >and more reliable just to try reading the value of code x10.
> >
> >Reading the capabilities string is a very expensive operation,
> >entailing multiple I2C write/read exchanges, as a single read can
> >return at most 32 bytes.  Every write/read exchange contains sleeps
> >mandated by the DDC/CI protocol.  (In fact, ddcutil spends 90% of it's
> >elapsed time sleeping.)Since the I2C protocol is unreliable, a
> >write/read exchange may have to be retried, and even worse a whole
> >sequence of write/read exchanges may have be to restarted.   Most
> >monitors are relatively clean, but some, such Dell P2412h monitors
> >that I have tested, have so many I2C failures that read capabilities
> >sometimes fails even after retries.
> >
> >Moreover, the capabilities string is not necessarily accurate. See,
> >for example, the description of the HP LP2480zx monitor. on page
> >http://www.ddcutil.com/monitor_notes/.  The string does not include
> >VCP feature code x10, even though the monitor supports it.
> >
> >BTW, while monitors vary enormously in the VCP feature codes they
> >support, I've yet to see a monitor that doesn't support feature x10.
> >
> >4) You may want to control/capture messages issued from the library.
> >See functions ddca_set_fout(), ddca_set_ferr(),
> >ddca_set_output_level(), etc.
> >
> >5) In certain very exceptional situations (i.e. things that should
> >never happen, but hey, it's conceivable) the library may abort.
> >Instead of aborting, the library can return to a location in the
> >caller registered using function ddca_register_jmp_buf().  See
> >function handle_library_abort() in sample file demo_global_settings.c.
> >I have to admit that I'm not entirely comfortable with making a
> >longjmp visible to the library client, but I'm trying to avoid forcing
> >the library user to check for truly exceptional failures on each API
> >call, while still avoiding library aborts that cause the client to
> >fail.   Let me know if you find this design useful/usable.
> >
> >Regards,
> >Sanford
> >
> >

D7722: Disable DDCUtil by default

2017-09-07 Thread Kai Uwe Broulik

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7722

To: jriddell, #plasma, dvogel, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7722: Disable DDCUtil by default

2017-09-07 Thread Jonathan Riddell

jriddell added reviewers: Plasma, dvogel.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D7722

To: jriddell, #plasma, dvogel
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7722: Disable DDCUtil by default

2017-09-07 Thread Jonathan Riddell

jriddell created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Disable DDCUtil by default

TEST PLAN
  built it, checked powerdevilupowerbackend.so depends

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7722

AFFECTED FILES
  CMakeLists.txt

To: jriddell
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

[Powerdevil] [Bug 381387] display brightness is increased when come back from closed lid

2017-09-07 Thread Sebastian Kügler

https://bugs.kde.org/show_bug.cgi?id=381387

Sebastian Kügler  changed:

   What|Removed |Added

   Assignee|plasma-devel@kde.org|plasma-b...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

D6591: XdgV6 - Kwin side

2017-09-07 Thread David Edmundson

davidedmundson added a comment.


  Ping. Even if I now can't merge till 5.11 splits, it'd be nice to have this 
approved.
  
  There's still a lot of work to be done on top of this, which is currently 
blocked.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6591

To: davidedmundson, #plasma
Cc: kwin, plasma-devel, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7669: Make AbstractEglBackend a QObject

2017-09-07 Thread David Edmundson

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  abstract-egl-backend-qobject

REVISION DETAIL
  https://phabricator.kde.org/D7669

To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D7698: Pass EGL information from AbstractEglBackend to Platform instead of query

2017-09-07 Thread David Edmundson

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  egl-backend-to-platform

REVISION DETAIL
  https://phabricator.kde.org/D7698

To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D3805: Per-activity favorites (Final, again?)

2017-09-07 Thread Ivan Čukić

ivan added a comment.


  p.s. This is how I restart everything:
  
kquitapp5 plasmashell; kactivitymanagerd stop; touch 
~/.config/kactivitymanagerd-statsrc; make install -j8 && (echo "DELETE FROM 
ResourceLink;" | sqlite3 ~/.local/share/kactivitymanagerd/resources/database) 
&& rm ~/.config/kactivitymanagerd-statsrc && cp 
~/.config/plasma-org.kde.plasma.desktop-appletsrc-prekastats 
~/.config/plasma-org.kde.plasma.desktop-appletsrc && kactivitymanagerd start && 
plasmashell

REVISION DETAIL
  https://phabricator.kde.org/D3805

To: ivan, mart, hein
Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D3805: Per-activity favorites (Final, again?)

2017-09-07 Thread Ivan Čukić

ivan updated this revision to Diff 19263.
ivan added a comment.


  Another one to test:
  
  - fixed a small bug related to fav adding
  - added debugging output for easier testing (when you encounter a bug, send 
me an email with plasma output)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3805?vs=19206=19263

REVISION DETAIL
  https://phabricator.kde.org/D3805

AFFECTED FILES
  applets/kicker/CMakeLists.txt
  applets/kicker/package/contents/code/tools.js
  applets/kicker/package/contents/config/main.xml
  applets/kicker/package/contents/ui/ActionMenu.qml
  applets/kicker/package/contents/ui/main.qml
  applets/kicker/plugin/abstractentry.cpp
  applets/kicker/plugin/appentry.cpp
  applets/kicker/plugin/appentry.h
  applets/kicker/plugin/computermodel.cpp
  applets/kicker/plugin/computermodel.h
  applets/kicker/plugin/computermodel.h.orig
  applets/kicker/plugin/favoritesmodel.cpp
  applets/kicker/plugin/favoritesmodel.h
  applets/kicker/plugin/kastatsfavoritesmodel.cpp
  applets/kicker/plugin/kastatsfavoritesmodel.h
  applets/kicker/plugin/kickerplugin.cpp
  applets/kicker/plugin/placeholdermodel.cpp
  applets/kicker/plugin/placeholdermodel.h
  applets/kicker/plugin/recentusagemodel.cpp
  applets/kicker/plugin/rootmodel.cpp
  applets/kicker/plugin/rootmodel.h
  applets/kicker/plugin/simplefavoritesmodel.cpp
  applets/kicker/plugin/simplefavoritesmodel.h
  applets/kicker/plugin/systemmodel.cpp
  applets/kickoff/package/contents/code/tools.js
  applets/kickoff/package/contents/config/main.xml
  applets/kickoff/package/contents/ui/ActionMenu.qml
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: ivan, mart, hein
Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

37 matches

Mail list logo