D8659: Make config window fit all controls
ngraham edited the test plan for this revision. ngraham added reviewers: KDE Applications, davidedmundson, broulik. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8659 To: ngraham, #kde_applications, davidedmundson, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8659: Make config window fit all controls
ngraham created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 384900 TEST PLAN Tested in KDE Neon. Before: After: REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D8659 AFFECTED FILES app/configDialog.ui To: ngraham Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8658: Change "Open..." to "Add Image..." in Wallpaper chooser
This revision was automatically updated to reflect the committed changes. Closed by commit R120:1be6aecf248f: Change "Open..." to "Add Image..." in Wallpaper chooser (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8658?vs=21882&id=21887 REVISION DETAIL https://phabricator.kde.org/D8658 AFFECTED FILES wallpapers/image/imagepackage/contents/ui/config.qml To: ngraham, #plasma, broulik, davidedmundson Cc: aspotashev, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8658: Change "Open..." to "Add Image..." in Wallpaper chooser
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D8658 To: ngraham, #plasma, broulik, davidedmundson Cc: aspotashev, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8441: Wallpaper: hide color or blur filling options for full filling mode
ngraham edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8441 To: guoyunhe, ngraham Cc: broulik, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8658: Change "Open..." to "Add Image..." in Wallpaper chooser
ngraham retitled this revision from "Change "Open..." to "Add Image" in Wallpaper chooser" to "Change "Open..." to "Add Image..." in Wallpaper chooser". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8658 To: ngraham, #plasma, broulik Cc: aspotashev, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8658: Change "Open..." to "Add Image..." in Wallpaper chooser
ngraham marked an inline comment as done. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8658 To: ngraham, #plasma, broulik Cc: aspotashev, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8658: Change "Open..." to "Add Image" in Wallpaper chooser
ngraham updated this revision to Diff 21882. ngraham added a comment. Restore elipses since this opens a file chooser dialog; also add elipses to the "Add Folder" button for the slideshow style REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8658?vs=21881&id=21882 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8658 AFFECTED FILES wallpapers/image/imagepackage/contents/ui/config.qml To: ngraham, #plasma, broulik Cc: aspotashev, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8658: Change "Open..." to "Add Image" in Wallpaper chooser
ngraham edited the test plan for this revision. ngraham added reviewers: Plasma, broulik. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8658 To: ngraham, #plasma, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8658: Change "Open..." to "Add Image" in Wallpaper chooser
aspotashev added inline comments.
INLINE COMMENTS
> config.qml:392
> +iconName: "list-add"
> +text: i18nd("plasma_applet_org.kde.image","Add Image")
> onClicked: imageWallpaper.showFileDialog();
The ellipsis ("Add Image...") is mandatory because the button opens a dialog.
Read in https://community.kde.org/KDE_Visual_Design_Group/HIG/Labels :
"End the label with an ellipsis if the command requires additional information
to execute."
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8658
To: ngraham, #plasma, broulik
Cc: aspotashev, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
D8658: Change "Open..." to "Add Image" in Wallpaper chooser
ngraham created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Changes the button in the wallpaper chooser marked "Open..." to say "Add Image". This matches the text style for the button in slideshow mode, which says, "Add Folder" TEST PLAN Tested in KDE Neon. Before: After: REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D8658 AFFECTED FILES wallpapers/image/imagepackage/contents/ui/config.qml To: ngraham Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8652: Add supported transformations to OutputDevice
graesslin updated this revision to Diff 21872. graesslin added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. enum and uint REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8652?vs=21869&id=21872 BRANCH supported-transformations REVISION DETAIL https://phabricator.kde.org/D8652 AFFECTED FILES autotests/client/test_wayland_outputdevice.cpp src/client/outputdevice.cpp src/client/outputdevice.h src/client/protocols/outputdevice.xml src/client/registry.cpp src/server/outputdevice_interface.cpp src/server/outputdevice_interface.h To: graesslin, #frameworks, #kwin, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8652: Add supported transformations to OutputDevice
graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in outputdevice_interface.cpp:470 > we have the initial send which is all fine > > Then you've got this dynamically add them. > But at a protocol level we have no way to remove and replace. > That's somewhat broken. > > Personally, I'd just make it a static and document that it must be sent > before the first done() I'm not 100 % sure whether we can in KWin determine the supported rotations in all cases before the OutputDeviceInterface is fully setup. Thus I wanted to have a little bit of flexibility here. Also if we need it we can add a remove. If we go for a static approach, we cannot remove again. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8652 To: graesslin, #frameworks, #kwin, #plasma Cc: davidedmundson, plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
D8652: Add supported transformations to OutputDevice
davidedmundson added inline comments.
INLINE COMMENTS
> outputdevice.xml:225
> +
> +
> +
enum="transform"
also uint
> outputdevice_interface.cpp:470
>
> +void OutputDeviceInterface::addSupportedTransformation(Transform
> transformation)
> +{
we have the initial send which is all fine
Then you've got this dynamically add them.
But at a protocol level we have no way to remove and replace.
That's somewhat broken.
Personally, I'd just make it a static and document that it must be sent before
the first done()
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D8652
To: graesslin, #frameworks, #kwin, #plasma
Cc: davidedmundson, plasma-devel, leezu, ZrenBot, alexeymin, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
D8652: Add supported transformations to OutputDevice
graesslin created this revision. graesslin added reviewers: Frameworks, KWin, Plasma. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The server can announce all supported transformations on an OutputDevice. The rational for this change is a requirement recognized in KWin in combination with KScreen: KScreen should not offer to transform a screen in a way which KWin cannot support. This API can fill the need. REPOSITORY R127 KWayland BRANCH supported-transformations REVISION DETAIL https://phabricator.kde.org/D8652 AFFECTED FILES autotests/client/test_wayland_outputdevice.cpp src/client/outputdevice.cpp src/client/outputdevice.h src/client/protocols/outputdevice.xml src/client/registry.cpp src/server/outputdevice_interface.cpp src/server/outputdevice_interface.h To: graesslin, #frameworks, #kwin, #plasma Cc: plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
D8493: Make Folder View screen aware
amantia added inline comments. INLINE COMMENTS > anthonyfieroni wrote in foldermodel.cpp:163-164 > When QObject dies it's disconnected to all signal/slots. In this case if you > want to not notify FolderModel you can use > > m_screenMapper->disconnect(this); Yes, I know, indeed this might be more clear. > anthonyfieroni wrote in screenmapper.cpp:32-36 > When you use singleton it's better to make variable construction in one line > > static ScreenMapper *s_instance = new ScreenMapper(); > return s_instance; > > or > > static ScreenMapper s_instance; > return &s_instance; > > In this way you don't have unwanted check for creation and variable at class > scope. Ok, although I don't see this commonly used in KDE (or Qt). If you really want, I can change it of course. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8493 To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, apol, mwolff Cc: anthonyfieroni, ngraham, mwolff, davidedmundson, broulik, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D7747: Added an extra fuzzytime setting - Hobbit Time
This revision was automatically updated to reflect the committed changes. Closed by commit R114:2e7da1046e1b: Added an extra fuzzytime setting - Hobbit Time (authored by jayturner, committed by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7747?vs=21834&id=21865 REVISION DETAIL https://phabricator.kde.org/D7747 AFFECTED FILES applets/fuzzy-clock/package/contents/ui/FuzzyClock.qml applets/fuzzy-clock/package/contents/ui/configAppearance.qml To: jayturner, ngraham Cc: jensreuterberg, broulik, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, abetts, sebas, apol, mart
D7747: Added an extra fuzzytime setting - Hobbit Time
ngraham edited the summary of this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D7747 To: jayturner, ngraham Cc: jensreuterberg, broulik, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, abetts, sebas, apol, mart
D7747: Added an extra fuzzytime setting - Hobbit Time
jayturner added a comment. In https://phabricator.kde.org/D7747#164151, @ngraham wrote: > @jayturner, what email address should I use for you when I land this? jaynicholastur...@gmail.com REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D7747 To: jayturner, ngraham Cc: jensreuterberg, broulik, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, abetts, sebas, apol, mart
D8645: [platforms/drm] Determine the supported transformation on a plane
graesslin updated this revision to Diff 21858. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Changes suggested by Kai REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8645?vs=21853&id=21858 BRANCH drm-supported-transformations REVISION DETAIL https://phabricator.kde.org/D8645 AFFECTED FILES plugins/platforms/drm/drm_object.cpp plugins/platforms/drm/drm_object.h plugins/platforms/drm/drm_object_plane.cpp plugins/platforms/drm/drm_object_plane.h To: graesslin, #kwin, #plasma, subdiff Cc: broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8645: [platforms/drm] Determine the supported transformation on a plane
graesslin marked 2 inline comments as done. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8645 To: graesslin, #kwin, #plasma, subdiff Cc: broulik, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
