D8756: Forbid more syscalls which could modify the filesystem
This revision was automatically updated to reflect the committed changes. Closed by commit R133:7720e8486337: Forbid more syscalls which could modify the filesystem (authored by davidk). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8756?vs=22174=22176 REVISION DETAIL https://phabricator.kde.org/D8756 AFFECTED FILES greeter/autotests/seccomp_test.cpp greeter/seccomp_filter.cpp To: davidk, graesslin Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8754: Baloo KCM text improvements
lueck added inline comments. INLINE COMMENTS > index.docbook:18-19 > > 2017-07-28 > Plasma 5.10 > Please bump date + releaseinfo REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8754 To: ngraham, #vdg, #plasma, abetts Cc: lueck, apol, plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart
D8756: Forbid more syscalls which could modify the filesystem
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R133 KScreenLocker BRANCH seccomp REVISION DETAIL https://phabricator.kde.org/D8756 To: davidk, graesslin Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8748: [libinput] Find screen for touch screen devices and calibrate accordingly
graesslin updated this revision to Diff 22175. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Use screens()->geometry() instead of size REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8748?vs=22152=22175 BRANCH libinput-calibrate-touchscreen2 REVISION DETAIL https://phabricator.kde.org/D8748 AFFECTED FILES autotests/libinput/device_test.cpp autotests/libinput/mock_libinput.cpp autotests/libinput/mock_libinput.h input.cpp libinput/connection.cpp libinput/connection.h libinput/device.cpp libinput/device.h plugins/platforms/drm/drm_output.h plugins/platforms/drm/screens_drm.cpp plugins/platforms/drm/screens_drm.h screens.cpp screens.h To: graesslin, #kwin, #plasma Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8756: Forbid more syscalls which could modify the filesystem
davidk added a reviewer: graesslin. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D8756 To: davidk, graesslin Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8756: Forbid more syscalls which could modify the filesystem
davidk created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Forbid more syscalls. An malicious theme could create directories with the password as name, or encode the password in chmod bits. Also, prevent deleting anything, so a theme can't delete the users files. TEST PLAN - Autotests run fine - Started sceenlocker, unlocked, created a new session. Got no seccomp violations in dmesg and everything worked fine. - Didn't test it with the nvidia driver REPOSITORY R133 KScreenLocker BRANCH seccomp REVISION DETAIL https://phabricator.kde.org/D8756 AFFECTED FILES greeter/autotests/seccomp_test.cpp greeter/seccomp_filter.cpp To: davidk Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8754: Baloo KCM text improvements
ngraham added a comment. I kind of think all of those are worse than what we already have, to be honest. "Do not search in these locations" is a pretty clear and user-friendly text string IMHO. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8754 To: ngraham, #vdg, #plasma, abetts Cc: apol, plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart
D8754: Baloo KCM text improvements
abetts added a comment. I think that people these days understand that indexing your files is a component of searching. If the word indexing is not liked, maybe it could be Capture file content data Read file content data Record file content data Etc. I would also suggest that you start each checkbox with a verb. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8754 To: ngraham, #vdg, #plasma, abetts Cc: apol, plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart
D8755: User Manager KCM text changes and UI modernization
This revision was automatically updated to reflect the committed changes. Closed by commit R128:5c072eab10bd: User Manager KCM text changes and UI modernization (authored by ngraham). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8755?vs=22167=22168 REVISION DETAIL https://phabricator.kde.org/D8755 AFFECTED FILES src/account.ui To: ngraham, abetts, #vdg, #plasma, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8755: User Manager KCM text changes and UI modernization
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R128 User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D8755 To: ngraham, abetts, #vdg, #plasma, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8754: Baloo KCM text improvements
apol added a comment. Why does the user need to know about the indexing? isn't it an implementation detail? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8754 To: ngraham, #vdg, #plasma, abetts Cc: apol, plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart
D8524: Add a signal notifying a change in the names of running activities.
hein added a comment. Ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8524 To: hein, #plasma Cc: anthonyfieroni, ivan, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8755: User Manager KCM text changes and UI modernization
ngraham edited the test plan for this revision. REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D8755 To: ngraham, abetts, #vdg, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8755: User Manager KCM text changes and UI modernization
ngraham created this revision. ngraham added reviewers: abetts, VDG, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 386635 Improve some strings and use a more modern checkboxes-on-the-left-side design TEST PLAN Tested in KDE Neon: REPOSITORY R128 User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D8755 AFFECTED FILES src/account.ui To: ngraham, abetts, #vdg, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8754: Baloo KCM text improvements
ngraham created this revision. ngraham added reviewers: VDG, Plasma, abetts. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 386634 Implement @abetts' proposed text changes for the Baloo KCM TEST PLAN Tested in KDE Neon: REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D8754 AFFECTED FILES doc/kcontrol/baloo/index.docbook kcms/baloo/configwidget.ui To: ngraham, #vdg, #plasma, abetts Cc: plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
D8692: QML mouse cursor KCM and components
ngraham edited the summary of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8692 To: mart, #plasma Cc: januz, ngraham, subdiff, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8748: [libinput] Find screen for touch screen devices and calibrate accordingly
graesslin marked an inline comment as done. graesslin added inline comments. INLINE COMMENTS > graesslin wrote in connection.cpp:395 > It's failing to compile in tests/ directory. There I don't have the > mockscreens, so I didn't think of it. Will try with the mockscreens. Thanks > for the suggestion. Didn't get it to compile with the mockscreens. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8748 To: graesslin, #kwin, #plasma Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8748: [libinput] Find screen for touch screen devices and calibrate accordingly
graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in connection.cpp:395 > not that it's a problem, but why? > You have screens mocked already. It's failing to compile in tests/ directory. There I don't have the mockscreens, so I didn't think of it. Will try with the mockscreens. Thanks for the suggestion. > davidedmundson wrote in connection.cpp:488 > you're not updating in deviceAdded(), so hypothetically if one adds a touch > screen at runtime, and plugs in the HDMI cable before the USB cable it won't > have the right screen. > > You could put this method (and the screens changed connect) in Device as > you're not doing anything with Connection in this method. > You could put this method (and the screens changed connect) in Device as > you're not doing anything with Connection in this method. I didn't want to add the screens dependency to Device. I need it in Connection for the touch point translation, so I added it there. Device itself doesn't have any dependencies of KWin yet, Connection is kind of the "firewall" between them. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8748 To: graesslin, #kwin, #plasma Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8752: [platforms/drm] At safety checks for the properties
graesslin created this revision. graesslin added reviewers: KWin, Plasma, fvogt, subdiff. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The AMS code accesses elements in a vector which might not be valid. This change refactors the code to be more robust, especially the DrmPlane, which started to crash after adding transformation support. BUG: 386490 REPOSITORY R108 KWin BRANCH drm-property-safety REVISION DETAIL https://phabricator.kde.org/D8752 AFFECTED FILES plugins/platforms/drm/drm_object.cpp plugins/platforms/drm/drm_object.h plugins/platforms/drm/drm_object_plane.cpp To: graesslin, #kwin, #plasma, fvogt, subdiff Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8748: [libinput] Find screen for touch screen devices and calibrate accordingly
davidedmundson added a comment.
One minor comment (the third one), otherwise all good.
INLINE COMMENTS
> connection.cpp:395
> case LIBINPUT_EVENT_TOUCH_DOWN: {
> +#ifndef KWIN_BUILD_TESTING
> TouchEvent *te = static_cast(event.data());
not that it's a problem, but why?
You have screens mocked already.
> connection.cpp:397
> TouchEvent *te = static_cast(event.data());
> -emit touchDown(te->id(), te->absolutePos(m_size),
> te->time(), te->device());
> +const auto = screens()->size(te->device()->screenId());
> +emit touchDown(te->id(),
> screens()->geometry(te->device()->screenId()).topLeft() +
> te->absolutePos(size), te->time(), te->device());
if you fetch the geometry here you'll get both the size and topLeft in an
easier to read way.
> connection.cpp:488
>
> +void Connection::updateScreens()
> +{
you're not updating in deviceAdded(), so hypothetically if one adds a touch
screen at runtime, and plugs in the HDMI cable before the USB cable it won't
have the right screen.
You could put this method (and the screens changed connect) in Device as you're
not doing anything with Connection in this method.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8748
To: graesslin, #kwin, #plasma
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8731: [x11] Add support for automatic screen rotation through XRandR
graesslin added a comment. > Yet we're putting this sensor stuff in kwin instead, then having to come up with extra interfaces to fix the problems we're creating. The main reason is that I wanted to support the phone case (hwcomposer) where we don't have the OutputConfigurationInterface hooked up and where it doesn't make sense to hook it up. The second reason is that KWin needs to support the full story including input adjustments. KScreen cannot do that, KWin must do it. Given that I would consider it weird to do everything related to the rotation just except detecting the orientation change. Also I think that KWin should be able to handle the most basic screen functionality (and yes I count rotation to that nowadays) on Wayland without the help of other processes. This makes it easier to deploy KWin outside of Plasma. E.g. for things we discussed like having KWin running in SDDM as the greeter compositor it means that KWin can provide automatic rotation without having to start half of our session in the login process. Of course that's all debatable and you might have noticed that the OrientationSensor class I added to KWin does not include anything else from KWin. It's a standalone component which can be split out and moved to KScreen. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8731 To: graesslin, #kwin, #plasma, sebas, davidedmundson Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8731: [x11] Add support for automatic screen rotation through XRandR
graesslin updated this revision to Diff 22153. graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. Fixup arc failure REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8731?vs=22151=22153 BRANCH xrandr-automatic-tranformation REVISION DETAIL https://phabricator.kde.org/D8731 AFFECTED FILES plugins/platforms/x11/standalone/screens_xrandr.cpp plugins/platforms/x11/standalone/screens_xrandr.h To: graesslin, #kwin, #plasma, sebas, davidedmundson Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8748: [libinput] Find screen for touch screen devices and calibrate accordingly
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY This change finds the screen for a touch screen device based on: - number available screens - output name defined on the touch screen device - internal screen - and physical size The id of the screen is stored in the Device allowing to adjust the touch points accordingly. This means instead of transferring to the combined display size the touch points are transferred into the output space and the position of the output is added. Thus in a multi screen system the touch points are properly mapped to the output. Furthermore the screen orientation is passed to the Device and a calibration matrix is set accordingly. Thus a transformed screen has the touch screen transformed accordingly. Please note that this only affects libinput on Wayland and not on X11! The x11 standalone platform needs to gain similar code. REPOSITORY R108 KWin BRANCH libinput-calibrate-touchscreen2 REVISION DETAIL https://phabricator.kde.org/D8748 AFFECTED FILES autotests/libinput/device_test.cpp autotests/libinput/mock_libinput.cpp autotests/libinput/mock_libinput.h input.cpp libinput/connection.cpp libinput/connection.h libinput/device.cpp libinput/device.h plugins/platforms/drm/drm_output.h plugins/platforms/drm/screens_drm.cpp plugins/platforms/drm/screens_drm.h screens.cpp screens.h To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8731: [x11] Add support for automatic screen rotation through XRandR
graesslin updated this revision to Diff 22151. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. - [libinput] Find screen for touch screen devices and calibrate accordingly REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8731?vs=22105=22151 BRANCH libinput-calibrate-touchscreen REVISION DETAIL https://phabricator.kde.org/D8731 AFFECTED FILES autotests/libinput/device_test.cpp autotests/libinput/mock_libinput.cpp autotests/libinput/mock_libinput.h input.cpp libinput/connection.cpp libinput/connection.h libinput/device.cpp libinput/device.h plugins/platforms/drm/drm_output.h plugins/platforms/drm/screens_drm.cpp plugins/platforms/drm/screens_drm.h plugins/platforms/x11/standalone/screens_xrandr.cpp plugins/platforms/x11/standalone/screens_xrandr.h screens.cpp screens.h To: graesslin, #kwin, #plasma, sebas, davidedmundson Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8731: [x11] Add support for automatic screen rotation through XRandR
davidedmundson added a comment. > I hope this addresses your concerns and can us allow to unblock this change. It could work, so I won't block it. But I still don't understand the design rationale. We have a component that is in charge of handling all screen management. It has all the backends already, it does the config tracking, it's got the communication all hooked up already with a simple single path in DRM. Yet we're putting this sensor stuff in kwin instead, then having to come up with extra interfaces to fix the problems we're creating. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8731 To: graesslin, #kwin, #plasma, sebas, davidedmundson Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8744: Use Qt.callLater instead of creating a Timer
broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN This is new in Qt 5.8. The kicker dialogs are properly destroyed. I didn't actually see the one in FolderView being called. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8744 AFFECTED FILES applets/kicker/package/contents/ui/ItemListDialog.qml containments/desktop/package/contents/ui/FolderViewDialog.qml To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8441: Wallpaper: hide color or blur filling options for full filling mode
ngraham added a comment. A neat idea, but yeah, I think it probably wouldn't even occur to most people to try to use a transparent image! If you approve, would you mind formally accepting it? I'm willing to triage and handle any bugs that come in saying "Hey, you broke my transparent wallpaper!" REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8441 To: guoyunhe, ngraham Cc: jensreuterberg, broulik, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, abetts, sebas, apol, mart
D8743: Add dynamic QML visual results
This revision was automatically updated to reflect the committed changes. Closed by commit R846:b5e85c3e4b9f: Add dynamic QML visual results (authored by Aiix). REPOSITORY R846 Mycroft Plasma integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8743?vs=22143=22144 REVISION DETAIL https://phabricator.kde.org/D8743 AFFECTED FILES plasmoid/contents/ui/LoaderType.qml plasmoid/contents/ui/main.qml To: Aiix, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8743: Add dynamic QML visual results
Aiix created this revision. Aiix added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Ref https://phabricator.kde.org/T7433 Added LoaderType which displays dynamically generated QML template results from mycroft skills inside dynamic component REPOSITORY R846 Mycroft Plasma integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D8743 AFFECTED FILES plasmoid/contents/ui/LoaderType.qml plasmoid/contents/ui/main.qml To: Aiix, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
Re: Out-of-screen painting for QQuickView ?
bug 353983
D8692: QML mouse cursor KCM and components
mart added a comment. In https://phabricator.kde.org/D8692#165286, @subdiff wrote: > - Open the kcm with kcmshell5 kcm_cursortheme opens it in a very small view with only one column can you try it now with the last commit? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8692 To: mart, #plasma Cc: ngraham, subdiff, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8692: QML mouse cursor KCM and components
mart updated this revision to Diff 22142. mart added a comment. - ensure at least 2 columns are visible REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8692?vs=22026=22142 BRANCH kcm-redesign/cursorTheme REVISION DETAIL https://phabricator.kde.org/D8692 AFFECTED FILES CMakeLists.txt kcmcontrols/GridDelegate.qml kcmcontrols/GridViewPage.qml kcmcontrols/qmldir kcms/cursortheme/CMakeLists.txt kcms/cursortheme/Messages.sh kcms/cursortheme/cursortheme.desktop kcms/cursortheme/kcm_cursortheme.desktop kcms/cursortheme/kcmcursortheme.cpp kcms/cursortheme/kcmcursortheme.h kcms/cursortheme/package/contents/ui/Delegate.qml kcms/cursortheme/package/contents/ui/main.qml kcms/cursortheme/package/metadata.desktop kcms/cursortheme/xcursor/cursortheme.cpp kcms/cursortheme/xcursor/cursortheme.h kcms/cursortheme/xcursor/itemdelegate.cpp kcms/cursortheme/xcursor/itemdelegate.h kcms/cursortheme/xcursor/previewwidget.cpp kcms/cursortheme/xcursor/previewwidget.h kcms/cursortheme/xcursor/sortproxymodel.cpp kcms/cursortheme/xcursor/sortproxymodel.h kcms/cursortheme/xcursor/thememodel.cpp kcms/cursortheme/xcursor/thememodel.h kcms/cursortheme/xcursor/themepage.cpp kcms/cursortheme/xcursor/themepage.h kcms/cursortheme/xcursor/themepage.ui kcms/cursortheme/xcursor/xcursor.knsrc kcms/cursortheme/xcursor/xcursortheme.cpp kcms/cursortheme/xcursor/xcursortheme.h To: mart, #plasma Cc: ngraham, subdiff, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8441: Wallpaper: hide color or blur filling options for full filling mode
jensreuterberg added a comment. Heh I may be the one who used transparent images - the idea being that you could, in theory set colour of an entire wallpaper based on icon colour using the correct kind of transparent image (essentially making darker parts less transparent meaning the lighter the area the brighter the underlying colour, creating a monochromatic image). To be quite frank as an idea it demanded slightly more work than was feasible, so I support this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8441 To: guoyunhe, ngraham Cc: jensreuterberg, broulik, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, abetts, sebas, apol, mart
D8692: QML mouse cursor KCM and components
mart added a comment. In https://phabricator.kde.org/D8692#165286, @subdiff wrote: > - Open the kcm with kcmshell5 kcm_cursortheme opens it in a very small view with only one column is the case of just few pixels too little to do a second column, to fix it it would need for thumbnails to be resizable... perhaps i should make thumbnails flexible when the view is small enough and wouldn't let 2 columns > - There is no white background to the list view the white background depends from https://phabricator.kde.org/D8526 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8692 To: mart, #plasma Cc: ngraham, subdiff, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8691: add some metadata
This revision was automatically updated to reflect the committed changes. Closed by commit R296:ae8d97bb5274: add some metadata (authored by mart). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8691?vs=22022=22141 REVISION DETAIL https://phabricator.kde.org/D8691 AFFECTED FILES src/quickaddons/configmodule.cpp src/quickaddons/configmodule.h To: mart, #plasma, davidedmundson Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
