D8793: Fix using avatars from the gallery and from local files

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R128:472f9a7446da: Fix using avatars from the gallery and from 
local files (authored by ngraham).

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8793?vs=22377=22426

REVISION DETAIL
  https://phabricator.kde.org/D8793

AFFECTED FILES
  src/accountinfo.cpp

To: ngraham, apol, #plasma, mlaurent, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8833: Make it possible to pass different kind of backgrounds as such

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  No for the same reason.

INLINE COMMENTS

> themeconfig.cpp:90
> +QMimeDatabase db;
> +const auto mime = db.mimeTypeForFile(mBackgroundPath);
> +const auto mimeName = mime.name();

So if it's blank (like the current Plasma theme with the blue image) a user can 
never set one?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D8833

To: apol, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8834: Make it possible to have videos on the background of breeze

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  If someone wants to make a theme with videos they can do so.
  
  I am not ok with polluting the default theme with every possible option 
someone could want.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8834

To: apol, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8834: Make it possible to have videos on the background of breeze

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  So far people were doing it wrong, modifying files locally and there's
  no good reason for it.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  sddmvideo

REVISION DETAIL
  https://phabricator.kde.org/D8834

AFFECTED FILES
  sddm-theme/Background.qml

To: apol, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8833: Make it possible to pass different kind of backgrounds as such

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  At the moment we already allowed it, we just always marked them as "image",
  now it will depend on the mime type.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8833

AFFECTED FILES
  src/configwidgets/selectimagebutton.cpp
  src/themeconfig.cpp

To: apol, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D5109: [Kicker/App Entry] Try QIcon with path if no theme icon is found

[Kai Uwe Broulik]

broulik abandoned this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5109

To: broulik, #plasma, hein
Cc: sefaeyeoglu, rkflx, smartins, ngraham, davidedmundson, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D5109: [Kicker/App Entry] Try QIcon with path if no theme icon is found

[Nathaniel Graham]

ngraham added a comment.


  Yeah, putting workarounds everywhere isn't so appealing. My preference would 
be for a Qt fix, otherwise we'll be playing whack-a-mole here forever.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5109

To: broulik, #plasma, hein
Cc: sefaeyeoglu, rkflx, smartins, ngraham, davidedmundson, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D8776: [autotests] Add tests for DRM platform plugin

[Martin Flöser]

graesslin added inline comments.

INLINE COMMENTS

> davidedmundson wrote in mock_drm.h:1
> I assume this is just phab being stupid?

yes or git being stupid. I did not copy any files around but created a new 
empty file. Ok, I admit I copied the copyright header, but certainly one with 
my copyright - I'm lazy ;-)

BRANCH
  drm-autotests

REVISION DETAIL
  https://phabricator.kde.org/D8776

To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7543: [autotests] Support new way to run the tests without need to install

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  autotests-ecm-in-dir

REVISION DETAIL
  https://phabricator.kde.org/D7543

To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8396: Add support for zwp_idle_inhibit_manager_v1

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  I think we need some big discussion about how powerdevil inhbitions, logind 
inhibitions and this are all going to fit together in a clear coherent way.
  
  But given there are clients using this protocol already, I guess we need this 
regardless certainly at a protocol level.

INLINE COMMENTS

> idleinhibit_interface_v1.cpp:73
> +if (!s) {
> +// send error?
> +return;

I think it should

REPOSITORY
  R127 KWayland

BRANCH
  idle-inhibit-manager

REVISION DETAIL
  https://phabricator.kde.org/D8396

To: graesslin, #frameworks, #kwin, #plasma_on_wayland, davidedmundson
Cc: davidedmundson, plasma-devel, leezu, ZrenBot, alexeymin, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D8661: Allow a cross-process check for same applications

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  belong-to-same-application-5.11

REVISION DETAIL
  https://phabricator.kde.org/D8661

To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D8776: [autotests] Add tests for DRM platform plugin

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> mock_drm.h:1
>  /
>   KWin - the KDE window manager

I assume this is just phab being stupid?

BRANCH
  drm-autotests

REVISION DETAIL
  https://phabricator.kde.org/D8776

To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8641: FormLayout

[Marco Martin]

mart updated this revision to Diff 22410.
mart added a comment.


  - && means we want & and not a mnemonic

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8641?vs=22401=22410

BRANCH
  mart/formlayout

REVISION DETAIL
  https://phabricator.kde.org/D8641

AFFECTED FILES
  examples/galleryapp/resources.qrc
  examples/gallerydata/contents/ui/MainPage.qml
  examples/gallerydata/contents/ui/gallery/ButtonGallery.qml
  examples/gallerydata/contents/ui/gallery/FormLayoutGallery.qml
  examples/gallerydata/contents/ui/gallery/TextFieldGallery.qml
  kirigami.qrc
  src/CMakeLists.txt
  src/controls/FormLayout.qml
  src/controls/GlobalDrawer.qml
  src/controls/Heading.qml
  src/controls/private/PrivateActionToolButton.qml
  src/controls/templates/FormLayout.qml
  src/formlayoutattached.cpp
  src/formlayoutattached.h
  src/kirigamiplugin.cpp
  src/mnemonicattached.cpp
  src/mnemonicattached.h

To: mart, #plasma, #kirigami, hein
Cc: colomar, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, hein

D8827: experimental support for auto mnemonics

[Marco Martin]

mart updated this revision to Diff 22409.
mart added a comment.


  - && means we want & and not a mnemonic

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8827?vs=22402=22409

BRANCH
  mart/mnemonics

REVISION DETAIL
  https://phabricator.kde.org/D8827

AFFECTED FILES
  org.kde.desktop/Button.qml
  org.kde.desktop/CheckBox.qml
  org.kde.desktop/DialogButtonBox.qml
  org.kde.desktop/MenuItem.qml
  org.kde.desktop/RadioButton.qml
  org.kde.desktop/Switch.qml
  org.kde.desktop/TabButton.qml
  org.kde.desktop/ToolButton.qml
  plugin/kquickstyleitem.cpp
  plugin/kquickstyleitem_p.h

To: mart, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8827: experimental support for auto mnemonics

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> mart wrote in Button.qml:43
> eww, even worse, in Qt 5.10 the mnemonics are removed in setText so is 
> impossible to know what the original text was /o\

which, they noticed it was terrible and reverted in Qt 5.11, but 5.10 is still 
meh, so the best i can do is to do something that fully correctly works only on 
5.11 :/

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D8827

To: mart, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8827: experimental support for auto mnemonics

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> mart wrote in Button.qml:43
> hm, yeah, will be terrible :/

eww, even worse, in Qt 5.10 the mnemonics are removed in setText so is 
impossible to know what the original text was /o\

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D8827

To: mart, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8827: experimental support for auto mnemonics

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> broulik wrote in Button.qml:43
> How does it behave if text contains an `&&` ie. user explicitly wants an 
> ampersand but not a mnemonic?

hm, yeah, will be terrible :/

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D8827

To: mart, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8827: experimental support for auto mnemonics

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> ToolButton.qml:36
>  
>  hoverEnabled: true //Qt.styleHints.useHoverEffects TODO: how to make 
> this work in 5.7?
>  

Btw probably

  Qt.styleHints.hasOwnProperty("useHoverEffects") ? 
Qt.styleHints.useHoverEffects : true

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D8827

To: mart, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8827: experimental support for auto mnemonics

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> Button.qml:43
> +//in case of explicit & the button manages it by itself
> +enabled: controlRoot.text.indexOf("&") == -1
> +sequence: controlRoot.Kirigami.MnemonicData.sequence

How does it behave if text contains an `&&` ie. user explicitly wants an 
ampersand but not a mnemonic?

> kquickstyleitem.cpp:1634
> +}
> +} else {
> +if (event->type() == QEvent::KeyPress) {

Check `watched == m_window`?

> kquickstyleitem.cpp:1635
> +} else {
> +if (event->type() == QEvent::KeyPress) {
> +QKeyEvent *ke = static_cast(event);

You could just check `KeyPress || KeyRelease` since you're doing the same thing 
in both branches

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D8827

To: mart, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8828: Honour the preferred mode flag in the kwayland backend

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R110:a4aa09ef9a83: Honour the preferred mode flag in the 
kwayland backend (authored by fvogt).

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8828?vs=22403=22404

REVISION DETAIL
  https://phabricator.kde.org/D8828

AFFECTED FILES
  autotests/testkwaylandbackend.cpp
  backends/kwayland/waylandoutput.cpp

To: fvogt, #plasma, sebas, graesslin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8828: Honour the preferred mode flag in the kwayland backend

[Martin Flöser]

graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R110 KScreen Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8828

To: fvogt, #plasma, sebas, graesslin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8828: Honour the preferred mode flag in the kwayland backend

[Fabian Vogt]

fvogt created this revision.
fvogt added reviewers: Plasma, sebas.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  BUG: 386900

TEST PLAN
  Ran plasma on wayland in virtio, instead of switching to 4096x2160@60
  it stays at the right resolution of 1024x768@60 on startup and kscreen-doctor
  shows that it's indeed set as the preferred mode.

REPOSITORY
  R110 KScreen Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8828

AFFECTED FILES
  autotests/testkwaylandbackend.cpp
  backends/kwayland/waylandoutput.cpp

To: fvogt, #plasma, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8827: experimental support for auto mnemonics

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  use auto mnemonics for common widgets as buttons,
  checkboxes and tabs
  A feature similar to KXMLGui apps

TEST PLAN
  tested in kirigami gallery

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  mart/mnemonics

REVISION DETAIL
  https://phabricator.kde.org/D8827

AFFECTED FILES
  org.kde.desktop/Button.qml
  org.kde.desktop/CheckBox.qml
  org.kde.desktop/DialogButtonBox.qml
  org.kde.desktop/MenuItem.qml
  org.kde.desktop/RadioButton.qml
  org.kde.desktop/Switch.qml
  org.kde.desktop/TabButton.qml
  org.kde.desktop/ToolButton.qml
  plugin/kquickstyleitem.cpp
  plugin/kquickstyleitem_p.h

To: mart, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8641: FormLayout

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in mnemonicattached.cpp:49
> Note that the alt to show is a Breeze special feature for widgets.

i think it's fine assuming the style supports that... (and assume that the one 
which is really supported is breeze) i wouldn't know how to detect it from here?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D8641

To: mart, #plasma, #kirigami, hein
Cc: colomar, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, hein

D8821: [effects] Delay creation of EffectFrames in WindowGeometryEffect

[Martin Flöser]

graesslin added a comment.


  As I just made my kwin crash just to get the backtrace I'm adding 
nevertheless:
  
(gdb) bt
#0  0x7f8d550626b0 in KWayland::Client::Compositor::operator 
wl_compositor*() () at /workspace/build/src/client/compositor.cpp:131
#1  0x7f8d428b377d in 
KWin::QPA::NativeInterface::nativeResourceForIntegration (this=0x1e00120, 
resource=...) at 
/home/martin/src/kde/workspace/kwin/plugins/qpa/nativeinterface.cpp:57
#2  0x7f8d550623a3 in KWayland::Client::Compositor::fromApplication 
(parent=0x7f8c90f5e3a0) at /workspace/build/src/client/compositor.cpp:63
#3  0x7f8c90d55ab2 in ?? () from 
/usr/lib/x86_64-linux-gnu/qt5/plugins/kf5/org.kde.kwindowsystem.platforms/KF5WindowSystemKWaylandPlugin.so
#4  0x7f8c90d55ce1 in ?? () from 
/usr/lib/x86_64-linux-gnu/qt5/plugins/kf5/org.kde.kwindowsystem.platforms/KF5WindowSystemKWaylandPlugin.so
#5  0x7f8c90d569c5 in ?? () from 
/usr/lib/x86_64-linux-gnu/qt5/plugins/kf5/org.kde.kwindowsystem.platforms/KF5WindowSystemKWaylandPlugin.so
#6  0x7f8d578ad40c in ?? () from 
/usr/lib/x86_64-linux-gnu/libKF5Plasma.so.5
#7  0x7f8d578a3347 in Plasma::Theme::Theme(QObject*) () from 
/usr/lib/x86_64-linux-gnu/libKF5Plasma.so.5
#8  0x7f8d5ab92936 in KWin::EffectFrameImpl::EffectFrameImpl 
(this=0x2db1320, style=, staticSize=, 
position=..., alignment=...)
at /home/martin/src/kde/workspace/kwin/effects.cpp:1835
#9  0x7f8d5ab92a8b in KWin::EffectsHandlerImpl::effectFrame 
(this=, style=KWin::EffectFrameUnstyled, staticSize=, position=..., alignment=...)
at /home/martin/src/kde/workspace/kwin/effects.cpp:1449
#10 0x7f8d58007652 in KWin::WindowGeometry::WindowGeometry 
(this=0x2dafcb0) at 
/home/martin/src/kde/workspace/kwin/effects/windowgeometry/windowgeometry.cpp:53
#11 0x7f8d57fadcb6 in 
KWin::BuiltInEffects::createHelper () at 
/home/martin/src/kde/workspace/kwin/effects/effect_builtins.cpp:84
#12 0x7f8d5ab9ac80 in KWin::BuiltInEffectLoader::loadEffect 
(this=this@entry=0x2b07a10, name=..., effect=effect@entry=, 
flags=..., flags@entry=...)
at /home/martin/src/kde/workspace/kwin/effectloader.cpp:159
#13 0x7f8d5ab9b1bf in KWin::BuiltInEffectLoader::loadEffect 
(this=0x2b07a10, effect=effect@entry=, flags=flags@entry=...)
at /home/martin/src/kde/workspace/kwin/effectloader.cpp:125
#14 0x7f8d5aba0884 in KWin::EffectLoadQueue::dequeue (this=0x2b07740) at 
/home/martin/src/kde/workspace/kwin/effectloader.h:258
#15 0x7f8d58eabc59 in QObject::event (this=0x2b07740, e=) at kernel/qobject.cpp:1246
#16 0x7f8d592973fc in QApplicationPrivate::notify_helper 
(this=, receiver=0x2b07740, e=0x2daa860) at 
kernel/qapplication.cpp:3717
#17 0x7f8d5929ee07 in QApplication::notify (this=0x7ffd08fa6ae0, 
receiver=0x2b07740, e=0x2daa860) at kernel/qapplication.cpp:3476
#18 0x7f8d58e7e798 in QCoreApplication::notifyInternal2 
(receiver=0x2b07740, event=event@entry=0x2daa860) at 
kernel/qcoreapplication.cpp:1018
#19 0x7f8d58e80f7b in QCoreApplication::sendEvent (event=0x2daa860, 
receiver=) at 
../../include/QtCore/../../src/corelib/kernel/qcoreapplication.h:233
#20 QCoreApplicationPrivate::sendPostedEvents (receiver=receiver@entry=0x0, 
event_type=event_type@entry=0, data=0x1dcc710) at 
kernel/qcoreapplication.cpp:1678
#21 0x7f8d58ed07e7 in QEventDispatcherUNIX::processEvents 
(this=0x1dff980, flags=...) at kernel/qeventdispatcher_unix.cpp:466
---Type  to continue, or q  to quit---
#22 0x7f8d428ec6fd in 
QUnixEventDispatcherQPA::processEvents(QFlags) 
() from /usr/lib/x86_64-linux-gnu/qt5/plugins/platforms/KWinQpaPlugin.so
#23 0x7f8d58e7c7ca in QEventLoop::exec (this=this@entry=0x7ffd08fa67b0, 
flags=..., flags@entry=...) at kernel/qeventloop.cpp:212
#24 0x7f8d58e85704 in QCoreApplication::exec () at 
kernel/qcoreapplication.cpp:1291
#25 0x7f8d52ce32ec in QGuiApplication::exec () at 
kernel/qguiapplication.cpp:1679
#26 0x7f8d59297355 in QApplication::exec () at 
kernel/qapplication.cpp:2905
#27 0x00408c28 in main (argc=2, argv=) at 
/home/martin/src/kde/workspace/kwin/main_wayland.cpp:836
  
  As we can see it crashes because PlasmaFrame accesses the internal connection 
before it's fully setup.

REPOSITORY
  R108 KWin

BRANCH
  windowgeometry-delay-effectframe

REVISION DETAIL
  https://phabricator.kde.org/D8821

To: graesslin, #kwin, #plasma, broulik
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D8641: FormLayout

[Marco Martin]

mart updated this revision to Diff 22401.
mart added a comment.


  - mnemoinictext property, which always has the &
  - support mnemonics in the global drawer
  - different weigths for differnt control types
  - filter on the window not the app

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8641?vs=22345=22401

BRANCH
  mart/formlayout

REVISION DETAIL
  https://phabricator.kde.org/D8641

AFFECTED FILES
  examples/galleryapp/resources.qrc
  examples/gallerydata/contents/ui/MainPage.qml
  examples/gallerydata/contents/ui/gallery/ButtonGallery.qml
  examples/gallerydata/contents/ui/gallery/FormLayoutGallery.qml
  examples/gallerydata/contents/ui/gallery/TextFieldGallery.qml
  kirigami.qrc
  src/CMakeLists.txt
  src/controls/FormLayout.qml
  src/controls/GlobalDrawer.qml
  src/controls/Heading.qml
  src/controls/private/PrivateActionToolButton.qml
  src/controls/templates/FormLayout.qml
  src/formlayoutattached.cpp
  src/formlayoutattached.h
  src/kirigamiplugin.cpp
  src/mnemonicattached.cpp
  src/mnemonicattached.h

To: mart, #plasma, #kirigami, hein
Cc: colomar, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, hein

D8821: [effects] Delay creation of EffectFrames in WindowGeometryEffect

[David Edmundson]

davidedmundson added a comment.


  Got it, thanks.

REPOSITORY
  R108 KWin

BRANCH
  windowgeometry-delay-effectframe

REVISION DETAIL
  https://phabricator.kde.org/D8821

To: graesslin, #kwin, #plasma, broulik
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D8821: [effects] Delay creation of EffectFrames in WindowGeometryEffect

[Martin Flöser]

graesslin added a comment.


  In https://phabricator.kde.org/D8821#168053, @davidedmundson wrote:
  
  > > New test case added which crashes without this fix.
  >
  > I wanted to see the backtrace of what we're working round, so applied just 
the test and not the changes to the effect.
  >  It didn't crash. Any ideas?
  
  
  Two ideas: did you run the waylandonly variant or the "normal" variant? Only 
the waylandonly variant crashes and that one is timing dependent so it might be 
that you will never see it on your system. I also only got it on my notebook 
but never on my desktop. I'll add the backtrace.

REPOSITORY
  R108 KWin

BRANCH
  windowgeometry-delay-effectframe

REVISION DETAIL
  https://phabricator.kde.org/D8821

To: graesslin, #kwin, #plasma, broulik
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D1971: Disable high DPI scaling on kscreenlocker

[David Edmundson]

davidedmundson abandoned this revision.
davidedmundson added a comment.


  > Worst still it highlights a bug when using text with Qt.NativeRendering
  
  AFAIK this is fixed.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D1971

To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8794: Split init'ing the wayland output from init

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:e96f2bff11da: Split initing the wayland output from 
init (authored by davidedmundson).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8794?vs=22280=22400

REVISION DETAIL
  https://phabricator.kde.org/D8794

AFFECTED FILES
  plugins/platforms/drm/drm_output.cpp
  plugins/platforms/drm/drm_output.h

To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D8779: Avoid hypothetical crash if output->init fails

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:6325749f2117: Avoid hypothetical crash if output-init 
fails (authored by davidedmundson).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8779?vs=22247=22399

REVISION DETAIL
  https://phabricator.kde.org/D8779

AFFECTED FILES
  plugins/platforms/drm/drm_backend.cpp

To: davidedmundson, #plasma, graesslin
Cc: bshah, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D8159: Add API for setting server decoration palettes

[David Edmundson]

davidedmundson planned changes to this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D8159

To: davidedmundson, #plasma, graesslin
Cc: graesslin, broulik, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein

D3209: [Notification Applet] Position dialog before showing it

[David Edmundson]

davidedmundson added a comment.


  What's the status of this?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3209

To: broulik, #plasma, mck182, mart
Cc: davidedmundson, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D8793: Fix using avatars from the gallery and from local files

[Nathaniel Graham]

ngraham added a comment.


  Thanks for the approval. I'll land this, then the refactoring onto my to-do 
list. I agree that the current code is a bit stinky and could benefit from a 
more direct approach.

REPOSITORY
  R128 User Manager

BRANCH
  arcpatch-D8793_2

REVISION DETAIL
  https://phabricator.kde.org/D8793

To: ngraham, apol, #plasma, mlaurent, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D3754: expose toggleWidgetExplorer through dbus

[David Edmundson]

davidedmundson closed this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3754

To: mvourlakos, #plasma, davidedmundson, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8826: Support Qt scaling in wallpaper loading

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3c5df91dd1a9: Support Qt scaling in wallpaper loading 
(authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D8826?vs=22396=22398#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8826?vs=22396=22398

REVISION DETAIL
  https://phabricator.kde.org/D8826

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/main.qml

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8793: Fix using avatars from the gallery and from local files

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.


  No objections. It fixes a bug...
  
  But, if you have the time, I'm sure we could come up wtih something much more 
elegant with some refactoring.
  
  (like storing the pixmap in infToSave, and then just writing it into .face 
directly)

INLINE COMMENTS

> accountinfo.cpp:458
>  m_model->setData(m_index, QVariant(cJob->destUrl().path()), 
> AccountModel::Face);
>  m_info->face->setIcon(QIcon(m_model->data(m_index, 
> AccountModel::Face).value()));
> +// If there is a leftover temp file, remove it

I know this isn't a line you've changed, and I hate it when reviewers comment 
about something unrelated, but it's on the screen and annoying me.

model->setData( some qstring)
model->data().value()

how is that ever going to work?

REPOSITORY
  R128 User Manager

BRANCH
  arcpatch-D8793_2

REVISION DETAIL
  https://phabricator.kde.org/D8793

To: ngraham, apol, #plasma, mlaurent, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D2660: Prefer an algorithm over an explicit for loop

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R122:d492dc57eeb3: Prefer an algorithm over an explicit for 
loop (authored by jkt, committed by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2660?vs=7144=22397#toc

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2660?vs=7144=22397

REVISION DETAIL
  https://phabricator.kde.org/D2660

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: jkt, davidedmundson, broulik
Cc: davidedmundson, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D8826: Support Qt scaling in wallpaper loading

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> main.qml:38
>  property bool ready: false
> +property var sourceSize: Qt.size(root.width * Screen.devicePixelRatio, 
> root.height * Screen.devicePixelRatio)
>  

Make it a `property size`

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8826

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D1986: WIP: Save PanelView settings in terms of grid units

[David Edmundson]

davidedmundson abandoned this revision.
davidedmundson added a comment.


  Can't remember what the state of this is, and the original code probably 
changed. Closing.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1986

To: davidedmundson, #plasma
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D8821: [effects] Delay creation of EffectFrames in WindowGeometryEffect

[David Edmundson]

davidedmundson added a comment.


  > New test case added which crashes without this fix.
  
  I wanted to see the backtrace of what we're working round, so applied just 
the test and not the changes to the effect.
  It didn't crash. Any ideas?

REPOSITORY
  R108 KWin

BRANCH
  windowgeometry-delay-effectframe

REVISION DETAIL
  https://phabricator.kde.org/D8821

To: graesslin, #kwin, #plasma, broulik
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D8826: Support Qt scaling in wallpaper loading

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  On wayland we're using Qt scaling.
  This normally handles most scaling stuff itself, except because we're
  explicitly forcing a source size, we need to scale that.

TEST PLAN
  Loaded a 4k wallpaper from internet
  Looked at the tiny pixels

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8826

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/main.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> x11mousebackend.cpp:186
> +m_supportedAccelerationProfiles.clear();
> +bool adaptiveAvaiable = false;
> +bool flatAvailable = false;

adaptiveAvaiable -> adaptiveAvailable (find-and-replace should take care of 
this, since there are many other uses of the misspelled term)

> x11mousebackend.cpp:235
> +m_accelerationProfile = PROFILE_NONE;
> +if (adaptiveAvaiable) {
> +m_accelerationProfile = PROFILE_ADAPTIVE;

Is this supposed to be "if (adaptiveEnabled) {"

> x11mousebackend.cpp:237
> +m_accelerationProfile = PROFILE_ADAPTIVE;
> +} else if (flatAvailable) {
> +m_accelerationProfile = PROFILE_FLAT;

Ditto

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8798

To: xuetianweng, ngraham, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8820: Don't notify about value changes if we are still in the constructor

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:09efedec8c71: Dont notify about value changes if we 
are still in the constructor (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8820?vs=22368=22395

REVISION DETAIL
  https://phabricator.kde.org/D8820

AFFECTED FILES
  src/libkirigami/platformtheme.cpp

To: apol, #frameworks, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, apol, mart, hein

D8820: Don't notify about value changes if we are still in the constructor

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8820

To: apol, #frameworks, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, apol, mart, hein

D8820: Don't notify about value changes if we are still in the constructor

[Aleix Pol Gonzalez]

apol added a comment.


  > If you're emitting something in the constructor, how could a UI be 
connected to it?
  
  There's a timer.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D8820

To: apol, #frameworks
Cc: davidedmundson, broulik, plasma-devel, apol, mart, hein

D8820: Don't notify about value changes if we are still in the constructor

[David Edmundson]

davidedmundson added a comment.


  > it will make the UI react to it at some point
  
  If you're emitting something in the constructor, how could a UI be connected 
to it?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D8820

To: apol, #frameworks
Cc: davidedmundson, broulik, plasma-devel, apol, mart, hein

D8493: Make Folder View screen aware

[Andras Mantia]

amantia added inline comments.

INLINE COMMENTS

> mwolff wrote in screenmapper.cpp:41
> this is a pretty arbitrary timer, can you add a comment on why 100ms is 
> better than going through the eventloop once via QMetaObject::invokeMethod 
> with the delayed flag set?

Done. InvokeMethod would not help, as the idea here is to get only one 
screenMappingChanged instead of e.g 50 when FolderModel gets the entries on 
startup.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8493

To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, 
apol, mwolff
Cc: anthonyfieroni, ngraham, mwolff, davidedmundson, broulik, mart, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D8493: Make Folder View screen aware

[Andras Mantia]

amantia updated this revision to Diff 22387.
amantia marked 2 inline comments as done.
amantia added a comment.


  Fix for some of Milian's comments (rest later, need to move to different 
computer)

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8493?vs=22344=22387

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8493

AFFECTED FILES
  containments/desktop/package/contents/config/main.xml
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/package/contents/ui/FolderViewLayer.qml
  containments/desktop/plugins/folder/CMakeLists.txt
  containments/desktop/plugins/folder/autotests/CMakeLists.txt
  containments/desktop/plugins/folder/autotests/foldermodeltest.cpp
  containments/desktop/plugins/folder/autotests/foldermodeltest.h
  containments/desktop/plugins/folder/autotests/screenmappertest.cpp
  containments/desktop/plugins/folder/autotests/screenmappertest.h
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h
  containments/desktop/plugins/folder/folderplugin.cpp
  containments/desktop/plugins/folder/screenmapper.cpp
  containments/desktop/plugins/folder/screenmapper.h

To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, 
apol, mwolff
Cc: anthonyfieroni, ngraham, mwolff, davidedmundson, broulik, mart, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D8026: [Activity KCM] Disallow adding/removing activity when restricted

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0e4484b6feb1: [Activity KCM] Disallow adding/removing 
activity when restricted (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8026?vs=20027=22383

REVISION DETAIL
  https://phabricator.kde.org/D8026

AFFECTED FILES
  kcms/activities/qml/activitiesTab/ActivitiesView.qml

To: broulik, #plasma, ivan, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8744: Use Qt.callLater instead of creating a Timer

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:e8c4c3953d4e: Use Qt.callLater instead of creating a 
Timer (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8744?vs=22145=22381

REVISION DETAIL
  https://phabricator.kde.org/D8744

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemListDialog.qml
  containments/desktop/package/contents/ui/FolderViewDialog.qml

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8493: Make Folder View screen aware

[Milian Wolff]

mwolff added inline comments.

INLINE COMMENTS

> foldermodeltest.cpp:48
> +
> +void FolderModelTest::initTestCase()
> +{

remove the init and cleanup if both are empty?

> screenmappertest.cpp:36
> +
> +void ScreenMapperTest::cleanupTestCase()
> +{

remove if empty

> screenmappertest.cpp:45
> +
> +void ScreenMapperTest::cleanup()
> +{

dito

> foldermodel.cpp:163
> +if (m_screenMapper) {
> +m_screenMapper->disconnect(this);
> +m_screenMapper->removeScreen(m_screen, url());

can you add a comment why this explicit disconnect is needed? is it b/c 
removeScreen would otherwise emit a signal that we'd try to handle but don't 
want to? otherwise the QObject dtor would disconnect us

> foldermodel.h:294
>  private:
> +
>  struct DragImage {

ws only, unneeded change, can be unset

> screenmapper.cpp:41
> +this, ::screenMappingChanged);
> +m_screenMappingChangedTimer->setInterval(100);
> +m_screenMappingChangedTimer->setSingleShot(true);

this is a pretty arbitrary timer, can you add a comment on why 100ms is better 
than going through the eventloop once via QMetaObject::invokeMethod with the 
delayed flag set?

> screenmapper.cpp:52
> +if (screenUrl.scheme().isEmpty())
> +screenUrl = QUrl::fromLocalFile(path);
> +const auto screenPathWithScheme = screenUrl.url();

should this maybe be QUrl::fromUserInput with a prefer local file flag set?

> screenmapper.cpp:69
> +if (firstScreen == screenId) {
> +if (m_availableScreens.isEmpty()) {
> +m_firstScreenForPath[path] = -1;

could be rewritten/simplified:

  const auto it = std::min_element(...);
  m_firstScreenForPath[path] = it == m_availableScreens.constEnd() ? -1 : *it;

> screenmapper.cpp:82
> +*pathIt = pathIt.value() - 1;
> +} else if (path.isEmpty()) {
> +pathIt = m_screensPerPath.begin();

so if `path` is empty, this adjusts all paths? can you add a comment on when 
this happens and what it's for?

> screenmapper.cpp:98
> +
> +QUrl screenUrl(path);
> +if (screenUrl.scheme().isEmpty())

these three lines are shared with above, introduce a helper function in an anon 
namespace for it: `QUrl screenUrlForPath(const QString );`

> screenmapper.cpp:108
> +for (const auto : it.value()) {
> +const auto url = QUrl(name);
> +// add the items to the new screen, if they are on a disabled 
> screen and their

`m_itemsOnDisabledScreensMap` stores "names" from the `m_screenItemMap`, so I 
think this line here is wrong and should also use the proposed 
`screenUrlForPath` above, or `QUrl::fromUserInput`, no? Otherwise you may end 
up with relative urls for file paths?

> screenmapper.cpp:124
> +m_availableScreens.append(screenId);
> +if (!path.isEmpty()) {
> +auto it = m_screensPerPath.find(path);

again, seems like an empty path has a special meaning, can you document that 
somewhere please?

> screenmapper.cpp:140
> +
> +void ScreenMapper::addMapping(const QString , int screen, 
> MappingSignalBehavior behavior)
> +{

is `name` also a `path`?

> screenmapper.cpp:150
> +
> +void ScreenMapper::removeFromMap(const QString )
> +{

dito

> screenmapper.h:43
> +public:
> +enum MappingSignalBehavior {
> +DelayedSignal = 0,

this needs to be documented, i.e. why and when is it required to distinguish 
between these signal behaviors?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8493

To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, 
apol, mwolff
Cc: anthonyfieroni, ngraham, mwolff, davidedmundson, broulik, mart, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Powerdevil] [Bug 304696] Display is dimmed in half the time you configure to dim

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=304696

--- Comment #12 from da-kdebugs...@abelonline.de ---
This is still open. Setting "Dim screen" to "3 min" makes the display dim after
90s (instead of 180s). Unchecking "Dim screen" disables dimming, so it is
likely due to this setting.

System settings 5.11.3 on KDE neon.

Can't believe this has been open for 5+ years.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 304696] Display is dimmed in half the time you configure to dim

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=304696

da-kdebugs...@abelonline.de changed:

   What|Removed |Added

 CC||da-kdebugs...@abelonline.de

--- Comment #11 from da-kdebugs...@abelonline.de ---
Created attachment 108874
  --> https://bugs.kde.org/attachment.cgi?id=108874=edit
Screenshot of dim screen setting

-- 
You are receiving this mail because:
You are the assignee for the bug.

D8597: Cleanup: use temp variables instead of querying properties repeatedly

[Milian Wolff]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b985b7432ef9: Cleanup: use temp variables instead of 
querying properties repeatedly (authored by mwolff).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8597?vs=21716=22380

REVISION DETAIL
  https://phabricator.kde.org/D8597

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

To: mwolff, broulik
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8421: Port the dict applet to KF5 and QtQuick 2

[David Faure]

dfaure added a comment.


  In https://phabricator.kde.org/D8421#158352, @davidedmundson wrote:
  
  > Have you added it to the panel?
  
  
  What should happen when I do? Surely a webview won't fit there...

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D8421

To: dfaure, #plasma
Cc: broulik, davidedmundson, plasma-devel, #plasma, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart