D8850: Support drag and drop between shared folder view containments

[Andras Mantia]

amantia updated this revision to Diff 22797.
amantia added a comment.


  Guard m_screenMapper usage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8850?vs=22682=22797

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8850

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/positioner.cpp

To: amantia, mwolff, #plasma, hein
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8598: FolderView: position files at drop event target position

[Andras Mantia]

amantia requested changes to this revision.
amantia added a comment.
This revision now requires changes to proceed.


  Milian, please also update the commit description (the last paragraph needs 
to go away).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8598

To: mwolff, hein, amantia
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8493: Make Folder View screen aware

[Andras Mantia]

amantia added inline comments.

INLINE COMMENTS

> hein wrote in foldermodel.cpp:1688
> I know it's a very theoretical case, but you're not disconnecting from an old 
> non-null ScreenMapper here.
> 
> You're also not calling invalidateFilter even though filterAcceptsRow uses 
> the mapper. It's all a bit non-hygienic in the sense of "allow stuff to be 
> set and reset in any order". Which can be somewhat important, especially as 
> FolderModel doesn't inherit from QQmlParserStatus (hint: would be a great 
> follow-up patch) and sometimes things can fall apart in config-dependent ways 
> during initialization.
> 
> I'd appreciate a pass through this code for that concern for good Qt Quick 
> hygiene.

As it ScreenMapper is a singleton, this will never happen, but nevertheless I 
added the disconnect.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8493

To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, 
apol, mwolff
Cc: anthonyfieroni, ngraham, mwolff, davidedmundson, broulik, mart, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D8493: Make Folder View screen aware

[Andras Mantia]

amantia updated this revision to Diff 22795.
amantia marked 2 inline comments as done.
amantia added a comment.


  Handle Eike's comments

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8493?vs=22444=22795

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8493

AFFECTED FILES
  containments/desktop/package/contents/config/main.xml
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/package/contents/ui/FolderViewLayer.qml
  containments/desktop/plugins/folder/CMakeLists.txt
  containments/desktop/plugins/folder/autotests/CMakeLists.txt
  containments/desktop/plugins/folder/autotests/foldermodeltest.cpp
  containments/desktop/plugins/folder/autotests/foldermodeltest.h
  containments/desktop/plugins/folder/autotests/screenmappertest.cpp
  containments/desktop/plugins/folder/autotests/screenmappertest.h
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h
  containments/desktop/plugins/folder/folderplugin.cpp
  containments/desktop/plugins/folder/screenmapper.cpp
  containments/desktop/plugins/folder/screenmapper.h

To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, 
apol, mwolff
Cc: anthonyfieroni, ngraham, mwolff, davidedmundson, broulik, mart, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D8798: Add xf86-input-libinput support for X11 mouse backend.

[Xuetian Weng]

xuetianweng marked 3 inline comments as done.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8798

To: xuetianweng, ngraham, #plasma, jriddell
Cc: jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

[Xuetian Weng]

xuetianweng added a comment.


  In https://phabricator.kde.org/D8798#170892, @jriddell wrote:
  
  > This disables the input kcm if libinput x11 plugin is not found.  I expect 
this is fine, it is for ubuntu distros at least, but it might be worth asking 
distros if it causes them a problem.
  
  
  FYI on ubuntu the package is 
https://packages.ubuntu.com/xenial/xserver-xorg-input-libinput-dev .
  
  Actually it only contains some macro string definition, but I would still 
prefer to use the macro from header instead of duplicate them here. After all, 
we're also depending on 
https://packages.ubuntu.com/artful/xserver-xorg-input-evdev-dev . And kwin's 
wayland mode will use libinput anyway.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8798

To: xuetianweng, ngraham, #plasma, jriddell
Cc: jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D8924: Move the KDE Polkit-Agent into ksmserver

[Martin Flöser]

graesslin added a comment.


  In https://phabricator.kde.org/D8924#170463, @apol wrote:
  
  > > This creates a "slight" problem for Wayland as ksmserver is forced to 
XCB. What do you think about doing it like with kscreenlocker? On X11 
ksmserver, on Wayland KWin? Otherwise +1000 to this suggestion.
  >
  > Isn't the solution to stop forcing ksmserver to XCB?
  
  
  no. ksmserver is an X11 only tool. We have two options: get rid of ksmserver 
or leave it on X11. Porting to Wayland makes no sense. The main task of 
ksmserver is being an X11 Session Manager.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8924

To: davidedmundson, #plasma
Cc: graesslin, ngraham, apol, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

[Xuetian Weng]

xuetianweng updated this revision to Diff 22774.
xuetianweng added a comment.


  revert the accidentally changed currentIndex in ui file when save in designer.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8798?vs=22543=22774

BRANCH
  mouse

REVISION DETAIL
  https://phabricator.kde.org/D8798

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindXorgLibinput.cmake
  kcms/CMakeLists.txt
  kcms/input/backends/x11/x11mousebackend.cpp
  kcms/input/backends/x11/x11mousebackend.h
  kcms/input/kcmmouse.ui
  kcms/input/mouse.cpp
  kcms/input/mousebackend.h
  kcms/input/mousesettings.cpp
  kcms/input/mousesettings.h

To: xuetianweng, ngraham, #plasma, jriddell
Cc: jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

[Xuetian Weng]

xuetianweng added a comment.


  Whether it shows up reallys depends on your system. Especially when there's 
multiple mouse driver available and you may using evdev.
  
  For example, here's one output on my system, when you see something like 
this, you'll know it's using libinput's xf86 driver. On ubuntu the relavant 
package I found is:
  https://packages.ubuntu.com/artful/xserver-xorg-input-libinput
  
$ xinput list-props 16
Device 'Newmen1100 MOUSE':
   Device Enabled (142):   1
   Coordinate Transformation Matrix (144): 1.00, 0.00, 0.00, 
0.00, 1.00, 0.00, 0.00, 0.00, 1.00
   libinput Natural Scrolling Enabled (285):   0
   libinput Natural Scrolling Enabled Default (286):   0
   libinput Left Handed Enabled (287): 0
   libinput Left Handed Enabled Default (288): 0
   libinput Accel Speed (289): 0.00
   libinput Accel Speed Default (290): 0.00
   libinput Accel Profiles Available (435):1, 1
   libinput Accel Profile Enabled (436):   1, 0
   libinput Accel Profile Enabled Default (437):   1, 0
   libinput Scroll Methods Available (291):0, 0, 1
   libinput Scroll Method Enabled (292):   0, 0, 0
   libinput Scroll Method Enabled Default (293):   0, 0, 0
   libinput Button Scrolling Button (438): 2
   libinput Button Scrolling Button Default (439): 2
   libinput Middle Emulation Enabled (297):0
   libinput Middle Emulation Enabled Default (298):0
   libinput Send Events Modes Available (262): 1, 0
   libinput Send Events Mode Enabled (263):0, 0
   libinput Send Events Mode Enabled Default (264):0, 0
   Device Node (265):  "/dev/input/event17"
   Device Product ID (266):7119, 41
   libinput Drag Lock Buttons (301):   
   libinput Horizontal Scroll Enabled (302):   1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8798

To: xuetianweng, ngraham, #plasma, jriddell
Cc: jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D8956: Implement geometry update blocking in ShellClient

[Martin Flöser]

graesslin created this revision.
graesslin added reviewers: Plasma, KWin.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  Commit 
https://phabricator.kde.org/R108:188491d3922180f1e1bba8fa2cd3fd2aa4a527c0 
introduced a regression
  in ShellClient and broke the QuickTiling test - sorry about that.
  
  This change fixes the failing test. The main reason was a slight change
  in semantics of setGeometry. But the real problem is/was that the
  geometry update blocking is not supported in ShellClient.
  
  This change brings in the checks from Client to ShellClient, thus that
  the geometry is properly blocked and when unblocked the geometry is
  updated correctly or a request is sent. What makes it rather difficult is
  that the geometry update blocker operates on an updated geom while
  ShellClient::setGeometry needs to compare to the original geom to
  determine whether a direct update or a request is required.
  
  Thanks to supporting geometry update blocking the changeMaximize calls
  are adjusted to use setGeometry instead of requestingGeometry directly.
  
  Overall this is an important improvement and might also allow us to no
  longer require the special RequestGeometryBlocker in ShellClient.

TEST PLAN
  Tests pass

REPOSITORY
  R108 KWin

BRANCH
  geometry-update-blocker-shell-client

REVISION DETAIL
  https://phabricator.kde.org/D8956

AFFECTED FILES
  shell_client.cpp

To: graesslin, #plasma, #kwin
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

[Jonathan Riddell]

jriddell added a comment.


  Using the patch the acceleration profile box doesn't show.  I have a KDE 
Slimbook with and xinput reports this:
  
  ⎡ Virtual core pointer  id=2[master pointer  (3)]
  ⎜   ↳ Virtual core XTEST pointerid=4[slave  pointer  (2)]
  ⎜   ↳ ImExPS/2 Generic Explorer Mouse   id=14   [slave  pointer  (2)]
  ⎜   ↳ BluetoothMouse3600id=15   [slave  pointer  (2)]
  ⎜   ↳ SIGMACHIP USB Keyboardid=10   [slave  pointer  (2)]
  
  Will it not work with this hardware?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8798

To: xuetianweng, ngraham, #plasma, jriddell
Cc: jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

[Jonathan Riddell]

jriddell added a comment.


  This disables the input kcm if libinput x11 plugin is not found.  I expect 
this is fine, it is for ubuntu distros at least, but it might be worth asking 
distros if it causes them a problem.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8798

To: xuetianweng, ngraham, #plasma, jriddell
Cc: jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

[Nathaniel Graham]

ngraham added a comment.


  In https://phabricator.kde.org/D8798#170879, @jriddell wrote:
  
  > on kcm touchpad I still get "No touchpad found" (on my KDE Slimbook), this 
isn't a surprise as your patch doesn't touch the touchpad kcm.  Should it?
  
  
  That would be probably be handled by a different patch. And FYI this request 
is tracked by https://bugs.kde.org/show_bug.cgi?id=387153.
  
  But yes, I was hoping @xuetianweng would do that too. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8798

To: xuetianweng, ngraham, #plasma, jriddell
Cc: jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

[Jonathan Riddell]

jriddell added a comment.


  on kcm touchpad I still get "No touchpad found" (on my KDE Slimbook), this 
isn't a surprise as your patch doesn't touch the touchpad kcm.  Should it?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8798

To: xuetianweng, ngraham, #plasma, jriddell
Cc: jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

[Jonathan Riddell]

jriddell requested changes to this revision.
jriddell added a comment.
This revision now requires changes to proceed.


  kcms/input/kcmmouse.ui
  Don't change  as that makes the default tab 
seem wrong

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8798

To: xuetianweng, ngraham, #plasma, jriddell
Cc: jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D8916: QML port of fonts kcm

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D8916#170830, @mart wrote:
  
  > In https://phabricator.kde.org/D8916#170365, @ngraham wrote:
  >
  > > Could we possibly take the opportunity to turn font anti-aliasing on by 
default instead of leaving it with "Vendor Default" (a string that doesn't have 
any meaning to most users)?
  >
  >
  > i would really not mess with the distro settings, which usually have a 
reason. we risk to break way too many corner cases
  
  
  one thing that may make sense, is to indeed put a "show advanced controls" 
there, (thing that i usually hate ;)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8916

To: mart, #plasma, #vdg
Cc: hein, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8916: QML port of fonts kcm

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D8916#170365, @ngraham wrote:
  
  > Could we possibly take the opportunity to turn font anti-aliasing on by 
default instead of leaving it with "Vendor Default" (a string that doesn't have 
any meaning to most users)?
  
  
  i would really not mess with the distro settings, which usually have a 
reason. we risk to break way too many corner cases

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8916

To: mart, #plasma, #vdg
Cc: hein, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

[Eike Hein]

hein added a comment.


  Thanks, will implement tomorrow!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8911

To: hein, #plasma, mart, abetts
Cc: mmustac, ngraham, davidedmundson, broulik, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

[Nathaniel Graham]

ngraham added a comment.


  After a lot of design work in https://phabricator.kde.org/tag/vdg/, we all 
agreed on the following:
  
  F5502756: photo_2017-11-22_08-59-07.jpg 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8911

To: hein, #plasma, mart, abetts
Cc: mmustac, ngraham, davidedmundson, broulik, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7246: Tooltips in Breeze theme

[Nathaniel Graham]

ngraham added a comment.


  Probably redo the patch so that it can apply to any theme.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7246

To: McPain, #breeze, #plasma, graesslin
Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7246: Tooltips in Breeze theme

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7246

To: McPain, #breeze, #plasma, graesslin
Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8939: Offset the scrollbar by the header size

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Fantastic, that's perfect!

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8939

To: apol, #kirigami, mart, ngraham, abetts
Cc: colomar, plasma-devel, apol, davidedmundson, mart, hein

D7246: Tooltips in Breeze theme

[Oleg Solovyov]

McPain added a comment.


  In https://phabricator.kde.org/D7246#158488, @ngraham wrote:
  
  > @McPain, any update?
  
  
  Not now. I don't get what to do: rewrite entire patch or write it for oxygen?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D7246

To: McPain, #breeze, #plasma, graesslin
Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8598: FolderView: position files at drop event target position

[Milian Wolff]

mwolff added inline comments.

INLINE COMMENTS

> foldermodel.cpp:155
> + *
> + * TODO: push this somehow into the Positioner
> + */

here as well then

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8598

To: mwolff, hein, amantia
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8850: Support drag and drop between shared folder view containments

[Eike Hein]

hein added inline comments.

INLINE COMMENTS

> foldermodel.cpp:1122
> +if (targetUrl.toString().startsWith(url.toString())) {
> +m_screenMapper->addMapping(targetUrl.toString(), m_screen, 
> ScreenMapper::DelayedSignal);
> +} else if 
> (targetUrl.toString().startsWith(dropTargetUrl.toString())) {

The code in this patch doesn't test for m_screenMapper being set. I don't think 
FolderModel should require one to work.

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8850

To: amantia, mwolff, #plasma, hein
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8915: Update the proxy to source and source to proxy mapping correctly

[Eike Hein]

hein accepted this revision.

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8915

To: amantia, #plasma, hein, mwolff
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8598: FolderView: position files at drop event target position

[Eike Hein]

hein accepted this revision.
hein added a comment.


  Small comment change request in the comments, but code-wise good to go.

INLINE COMMENTS

> foldermodel.cpp:1068
> + *
> + * TODO: move this somehow to the Positioner
> + */

As mentioned on IRC I'd currently prefer to keep the Positioner sort of 
optional architecturally. The idea is that non-containment FolderViews 
shouldn't need or use the Positoner (though this isn't the case currently in 
the code - it will always use it, just with an empty mapping) as they don't 
support sparse positioning and can scale better. Will also be relevant for 
future uses of this code like the Plasma Mobile file manager. Therefore I think 
this TODO note should be removed.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8598

To: mwolff, hein, amantia
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8493: Make Folder View screen aware

[Eike Hein]

hein added a comment.


  Modulo above edge-casey comments it looks good to me.

INLINE COMMENTS

> foldermodel.cpp:1324
> +const QString name = item.url().toString();
> +const int screen = m_screenMapper->screenForItem(name);
> +// don't do anything if the folderview is not associated with a 
> screen

You're not testing m_screenMapper!=nullptr here.

> foldermodel.cpp:1688
> +if (m_screenMapper) {
> +connect(m_screenMapper, ::screensChanged, this, 
> ::invalidateFilter);
> +connect(m_screenMapper, ::screenMappingChanged, this, 
> ::invalidateFilter);

I know it's a very theoretical case, but you're not disconnecting from an old 
non-null ScreenMapper here.

You're also not calling invalidateFilter even though filterAcceptsRow uses the 
mapper. It's all a bit non-hygienic in the sense of "allow stuff to be set and 
reset in any order". Which can be somewhat important, especially as FolderModel 
doesn't inherit from QQmlParserStatus (hint: would be a great follow-up patch) 
and sometimes things can fall apart in config-dependent ways during 
initialization.

I'd appreciate a pass through this code for that concern for good Qt Quick 
hygiene.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8493

To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, 
apol, mwolff
Cc: anthonyfieroni, ngraham, mwolff, davidedmundson, broulik, mart, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D8939: Offset the scrollbar by the header size

[Thomas Pfeiffer]

colomar added a comment.


  Looking great!

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D8939

To: apol, #kirigami, mart, ngraham, abetts
Cc: colomar, plasma-devel, apol, davidedmundson, mart, hein

D8939: Offset the scrollbar by the header size

[Aleix Pol Gonzalez]

apol added reviewers: ngraham, abetts.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D8939

To: apol, #kirigami, mart, ngraham, abetts
Cc: plasma-devel, apol, davidedmundson, mart, hein

D8939: Offset the scrollbar by the header size

[Aleix Pol Gonzalez]

apol added a comment.


  Here's a video of what it looks like after the patch, in Discover F5502419: 
vokoscreen-2017-11-22_12-26-58.mkv .

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D8939

To: apol, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D8939: Offset the scrollbar by the header size

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  BUG: 387098

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8939

AFFECTED FILES
  src/controls/templates/private/ScrollView.qml

To: apol, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D8598: FolderView: position files at drop event target position

[Milian Wolff]

mwolff updated this revision to Diff 22715.
mwolff added a comment.


  remove unused param

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8598?vs=22458=22715

BRANCH
  wip/lim-2

REVISION DETAIL
  https://phabricator.kde.org/D8598

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h

To: mwolff, hein, amantia
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8864: RFC: [MouseEventListener] Allow accepting mouse event

[Eike Hein]

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D8864

To: broulik, #plasma, hein
Cc: apol, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D8850: Support drag and drop between shared folder view containments

[Milian Wolff]

mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.


  lgtm in general, but a unit test for the positioner would be good to have

INLINE COMMENTS

> foldermodel.cpp:1053
> +if (isDropBetweenSharedViews(mimeData->urls(), dropTargetFolderUrl)) 
> {
> +/* QMimeData operates on local URLs, but the dir lister and thus 
> screen mapper and positioner may
> + * use a fancy scheme like desktop:/ instead. Ensure we always use 
> the latter to properly map URLs,

broken indent

> positioner.cpp:403
> +// find the next blank space
> +while (!isBlank(to) &&  from != to) {
> +to++;

can we get a unit test for this?

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8850

To: amantia, mwolff, #plasma, hein
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8924: Move the KDE Polkit-Agent into ksmserver

[Aleix Pol Gonzalez]

apol added a comment.


  > This creates a "slight" problem for Wayland as ksmserver is forced to XCB. 
What do you think about doing it like with kscreenlocker? On X11 ksmserver, on 
Wayland KWin? Otherwise +1000 to this suggestion.
  
  Isn't the solution to stop forcing ksmserver to XCB?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8924

To: davidedmundson, #plasma
Cc: graesslin, ngraham, apol, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart