D9304: Get the padding into the header
apol added a comment. Ping? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D9304 To: apol, #kirigami Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein
D9483: "Repository description" -> "Repository URL:"
This revision was automatically updated to reflect the committed changes. Closed by commit R134:34231fc68b47: Repository description - Repository URL: (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9483?vs=24313=24318 REVISION DETAIL https://phabricator.kde.org/D9483 AFFECTED FILES libdiscover/backends/PackageKitBackend/PackageKitSourcesBackend.cpp To: ngraham, apol, andreaska, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9483: "Repository description" -> "Repository URL:"
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store BRANCH package-bulleted-list-387935 REVISION DETAIL https://phabricator.kde.org/D9483 To: ngraham, apol, andreaska, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9483: "Repository description" -> "Repository URL:"
ngraham created this revision. ngraham added reviewers: apol, andreaska, Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Rename "Repository description" to "Repository URL:", which is more accurate and less confusing. REPOSITORY R134 Discover Software Store BRANCH package-bulleted-list-387935 REVISION DETAIL https://phabricator.kde.org/D9483 AFFECTED FILES libdiscover/backends/PackageKitBackend/PackageKitSourcesBackend.cpp To: ngraham, apol, andreaska, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
KDE CI: Plasma kwin kf5-qt5 SUSEQt5.9 - Build # 339 - Still unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20SUSEQt5.9/339/ Project: Plasma kwin kf5-qt5 SUSEQt5.9 Date of build: Fri, 22 Dec 2017 15:48:34 + Build duration: 30 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 118 test(s), Skipped: 0 test(s), Total: 120 test(s)Failed: TestSuite.kwin-testShellClientFailed: TestSuite.kwin-testShellClient-waylandonly
KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.9 - Build # 16 - Still unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/16/ Project: Plasma kwin kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 22 Dec 2017 15:48:34 + Build duration: 28 min and counting JUnit Tests Name: (root) Failed: 10 test(s), Passed: 109 test(s), Skipped: 0 test(s), Total: 119 test(s)Failed: TestSuite.kwin-testClientMachineFailed: TestSuite.kwin-testDebugConsoleFailed: TestSuite.kwin-testDecorationInputFailed: TestSuite.kwin-testDecorationInput-waylandonlyFailed: TestSuite.kwin-testInternalWindowFailed: TestSuite.kwin-testInternalWindow-waylandonlyFailed: TestSuite.kwin-testLockScreenFailed: TestSuite.kwin-testPointerInputFailed: TestSuite.kwin-testShellClientFailed: TestSuite.kwin-testShellClient-waylandonly
KDE CI: Plasma kwin kf5-qt5 SUSEQt5.9 - Build # 338 - Failure!
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20SUSEQt5.9/338/ Project: Plasma kwin kf5-qt5 SUSEQt5.9 Date of build: Fri, 22 Dec 2017 14:39:24 + Build duration: 39 min and counting CONSOLE OUTPUT [...truncated 1.41 MB...][ 88%] Building CXX object plugins/platforms/x11/standalone/CMakeFiles/KWinX11Platform.dir/effects_x11.cpp.o[ 88%] Building CXX object plugins/platforms/x11/standalone/CMakeFiles/KWinX11Platform.dir/effects_mouse_interception_x11_filter.cpp.o[ 88%] Building CXX object plugins/platforms/x11/standalone/CMakeFiles/KWinX11Platform.dir/sync_filter.cpp.o[ 88%] Building CXX object plugins/platforms/x11/standalone/CMakeFiles/KWinX11Platform.dir/xinputintegration.cpp.o[ 88%] Building CXX object plugins/platforms/x11/standalone/CMakeFiles/KWinX11Platform.dir/glxbackend.cpp.o[ 88%] Building CXX object plugins/platforms/x11/standalone/CMakeFiles/KWinX11Platform.dir/glx_context_attribute_builder.cpp.o[ 88%] Building CXX object plugins/platforms/x11/standalone/CMakeFiles/KWinX11Platform.dir/KWinX11Platform_autogen/mocs_compilation.cpp.o[ 88%] Linking CXX shared module ../../../../bin/KWinX11Platform.so[ 88%] Built target KWinX11PlatformScanning dependencies of target KWinWaylandX11Backend[ 88%] Building CXX object plugins/platforms/x11/windowed/CMakeFiles/KWinWaylandX11Backend.dir/logging.cpp.o[ 88%] Building CXX object plugins/platforms/x11/windowed/CMakeFiles/KWinWaylandX11Backend.dir/egl_x11_backend.cpp.o[ 88%] Building CXX object plugins/platforms/x11/windowed/CMakeFiles/KWinWaylandX11Backend.dir/scene_qpainter_x11_backend.cpp.o[ 88%] Building CXX object plugins/platforms/x11/windowed/CMakeFiles/KWinWaylandX11Backend.dir/x11windowed_backend.cpp.o[ 88%] Building CXX object plugins/platforms/x11/windowed/CMakeFiles/KWinWaylandX11Backend.dir/KWinWaylandX11Backend_autogen/mocs_compilation.cpp.o[ 88%] Linking CXX shared module ../../../../bin/KWinWaylandX11Backend.so[ 88%] Built target KWinWaylandX11BackendScanning dependencies of target testSceneOpenGL_waylandonly[ 88%] Building CXX object autotests/integration/CMakeFiles/testSceneOpenGL_waylandonly.dir/scene_opengl_test.cpp.o[ 88%] Building CXX object autotests/integration/CMakeFiles/testSceneOpenGL_waylandonly.dir/generic_scene_opengl_test.cpp.o[ 88%] Building CXX object autotests/integration/CMakeFiles/testSceneOpenGL_waylandonly.dir/testSceneOpenGL_waylandonly_autogen/mocs_compilation.cpp.o[ 88%] Linking CXX executable ../../bin/testSceneOpenGL_waylandonly[ 88%] Built target testSceneOpenGL_waylandonlyScanning dependencies of target testXwaylandInput[ 89%] Building CXX object autotests/integration/CMakeFiles/testXwaylandInput.dir/xwayland_input_test.cpp.o[ 89%] Building CXX object autotests/integration/CMakeFiles/testXwaylandInput.dir/testXwaylandInput_autogen/mocs_compilation.cpp.o[ 89%] Linking CXX executable ../../bin/testXwaylandInput[ 89%] Built target testXwaylandInputScanning dependencies of target testDontCrashNoBorder[ 89%] Building CXX object autotests/integration/CMakeFiles/testDontCrashNoBorder.dir/dont_crash_no_border.cpp.o[ 89%] Building CXX object autotests/integration/CMakeFiles/testDontCrashNoBorder.dir/testDontCrashNoBorder_autogen/mocs_compilation.cpp.o[ 89%] Linking CXX executable ../../bin/testDontCrashNoBorder[ 89%] Built target testDontCrashNoBorderScanning dependencies of target testMaximized[ 89%] Building CXX object autotests/integration/CMakeFiles/testMaximized.dir/maximize_test.cpp.o[ 89%] Building CXX object autotests/integration/CMakeFiles/testMaximized.dir/testMaximized_autogen/mocs_compilation.cpp.o[ 89%] Linking CXX executable ../../bin/testMaximized[ 89%] Built target testMaximizedScanning dependencies of target testPlasmaSurface[ 89%] Building CXX object autotests/integration/CMakeFiles/testPlasmaSurface.dir/plasma_surface_test.cpp.o[ 89%] Building CXX object autotests/integration/CMakeFiles/testPlasmaSurface.dir/testPlasmaSurface_autogen/mocs_compilation.cpp.o[ 89%] Linking CXX executable ../../bin/testPlasmaSurface[ 89%] Built target testPlasmaSurfaceScanning dependencies of target testTransientPlacmenet_waylandonly[ 89%] Building CXX object autotests/integration/CMakeFiles/testTransientPlacmenet_waylandonly.dir/transient_placement.cpp.o[ 89%] Building CXX object autotests/integration/CMakeFiles/testTransientPlacmenet_waylandonly.dir/testTransientPlacmenet_waylandonly_autogen/mocs_compilation.cpp.o[ 89%] Linking CXX executable ../../bin/testTransientPlacmenet_waylandonly[ 89%] Built target testTransientPlacmenet_waylandonlyScanning dependencies of target testPlatformCursor[ 89%] Building CXX object autotests/integration/CMakeFiles/testPlatformCursor.dir/platformcursor.cpp.o[ 89%] Building CXX object autotests/integration/CMakeFiles/testPlatformCursor.dir/testPlatformCursor_autogen/mocs_compilation.cpp.o[ 89%] Linking CXX executable ../../bin/testPlatformCursor[ 89%] Built target testPlatformCursorScanning dependencies of target
KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.9 - Build # 15 - Failure!
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/15/ Project: Plasma kwin kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 22 Dec 2017 14:39:24 + Build duration: 19 min and counting CONSOLE OUTPUT [...truncated 1.38 MB...][ 89%] Building CXX object autotests/integration/CMakeFiles/testScreenChanges_waylandonly.dir/testScreenChanges_waylandonly_autogen/mocs_compilation.cpp.o[ 89%] Built target testKeyboardLayout_waylandonly[ 89%] Building CXX object autotests/integration/CMakeFiles/testXClipboardSync.dir/testXClipboardSync_autogen/mocs_compilation.cpp.o[ 89%] Built target testDontCrashUseractionsMenu[ 89%] Building CXX object autotests/integration/CMakeFiles/testTransientNoInput_waylandonly.dir/testTransientNoInput_waylandonly_autogen/mocs_compilation.cpp.oScanning dependencies of target testXwaylandInput[ 90%] Building CXX object autotests/integration/CMakeFiles/testXwaylandInput.dir/xwayland_input_test.cpp.oScanning dependencies of target testNoXdgRuntimeDir_waylandonly[ 90%] Building CXX object autotests/integration/CMakeFiles/testNoXdgRuntimeDir_waylandonly.dir/no_xdg_runtime_dir_test.cpp.oScanning dependencies of target testDontCrashNoBorder_waylandonly[ 90%] Building CXX object autotests/integration/CMakeFiles/testDontCrashNoBorder_waylandonly.dir/dont_crash_no_border.cpp.o[ 90%] Linking CXX executable ../../bin/testScreenChanges_waylandonly[ 90%] Linking CXX executable ../../bin/testTransientNoInput_waylandonly[ 90%] Building CXX object autotests/integration/CMakeFiles/testNoXdgRuntimeDir_waylandonly.dir/testNoXdgRuntimeDir_waylandonly_autogen/mocs_compilation.cpp.o[ 90%] Linking CXX executable ../../bin/testXClipboardSync[ 90%] Linking CXX executable ../../bin/testNoXdgRuntimeDir_waylandonly[ 90%] Built target testScreenChanges_waylandonly[ 90%] Building CXX object autotests/integration/CMakeFiles/testDontCrashNoBorder_waylandonly.dir/testDontCrashNoBorder_waylandonly_autogen/mocs_compilation.cpp.o[ 90%] Building CXX object autotests/integration/CMakeFiles/testXwaylandInput.dir/testXwaylandInput_autogen/mocs_compilation.cpp.oScanning dependencies of target testDontCrashNoBorder[ 90%] Building CXX object autotests/integration/CMakeFiles/testDontCrashNoBorder.dir/dont_crash_no_border.cpp.o[ 90%] Built target testXClipboardSync[ 90%] Built target testTransientNoInput_waylandonly[ 90%] Built target testNoXdgRuntimeDir_waylandonlyScanning dependencies of target testIdleInhibition_waylandonlyScanning dependencies of target testMoveResize[ 90%] Building CXX object autotests/integration/CMakeFiles/testIdleInhibition_waylandonly.dir/idle_inhibition_test.cpp.o[ 90%] Building CXX object autotests/integration/CMakeFiles/testMoveResize.dir/move_resize_window_test.cpp.o[ 90%] Linking CXX executable ../../bin/testXwaylandInputScanning dependencies of target testLockScreen[ 90%] Building CXX object autotests/integration/CMakeFiles/testLockScreen.dir/lockscreen.cpp.o[ 90%] Linking CXX executable ../../bin/testDontCrashNoBorder_waylandonly[ 90%] Built target testXwaylandInput[ 90%] Building CXX object autotests/integration/CMakeFiles/testMoveResize.dir/testMoveResize_autogen/mocs_compilation.cpp.o[ 90%] Building CXX object autotests/integration/CMakeFiles/testDontCrashNoBorder.dir/testDontCrashNoBorder_autogen/mocs_compilation.cpp.o[ 90%] Building CXX object autotests/integration/CMakeFiles/testIdleInhibition_waylandonly.dir/testIdleInhibition_waylandonly_autogen/mocs_compilation.cpp.o[ 90%] Built target testDontCrashNoBorder_waylandonly[ 90%] Building CXX object autotests/integration/CMakeFiles/testLockScreen.dir/testLockScreen_autogen/mocs_compilation.cpp.oScanning dependencies of target testWindowSelection_waylandonly[ 90%] Building CXX object autotests/integration/CMakeFiles/testWindowSelection_waylandonly.dir/window_selection_test.cpp.oScanning dependencies of target testShellClient_waylandonly[ 90%] Building CXX object autotests/integration/CMakeFiles/testShellClient_waylandonly.dir/shell_client_test.cpp.o[ 90%] Linking CXX executable ../../bin/testDontCrashNoBorder[ 90%] Linking CXX executable ../../bin/testIdleInhibition_waylandonly[ 90%] Built target testDontCrashNoBorder[ 90%] Building CXX object autotests/integration/CMakeFiles/testShellClient_waylandonly.dir/testShellClient_waylandonly_autogen/mocs_compilation.cpp.o[ 90%] Building CXX object autotests/integration/CMakeFiles/testWindowSelection_waylandonly.dir/testWindowSelection_waylandonly_autogen/mocs_compilation.cpp.o[ 90%] Linking CXX executable ../../bin/testLockScreenScanning dependencies of target testTabBox[ 90%] Building CXX object autotests/integration/CMakeFiles/testTabBox.dir/tabbox_test.cpp.o[ 90%] Linking CXX executable ../../bin/testMoveResize[ 90%] Built target testIdleInhibition_waylandonlyScanning dependencies of target testPlatformCursor[ 91%] Building CXX object autotests/integration/CMakeFiles/testPlatformCursor.dir/platformcursor.cpp.o[ 91%] Built
D9338: [comic] Fix comic updater time interval
This revision was automatically updated to reflect the committed changes. Closed by commit R114:095196ca6438: [comic] Fix update interval (authored by anthonyfieroni). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9338?vs=24295=24303 REVISION DETAIL https://phabricator.kde.org/D9338 AFFECTED FILES applets/comic/comicupdater.cpp To: anthonyfieroni, davidedmundson, broulik, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9248: Port plasma-integration to explicit wayland AppMenu protocol
This revision was automatically updated to reflect the committed changes. Closed by commit R135:0f3fd179c9e8: Port plasma-integration to explicit wayland AppMenu protocol (authored by davidedmundson). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9248?vs=23657=24300 REVISION DETAIL https://phabricator.kde.org/D9248 AFFECTED FILES src/platformtheme/kdeplatformtheme.cpp src/platformtheme/kwaylandintegration.cpp src/platformtheme/kwaylandintegration.h To: davidedmundson, #plasma, graesslin Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9479: [widgetexplorer] Fix trying to show deleted dialog
This revision was automatically updated to reflect the committed changes. Closed by commit R120:acd7034952bc: [widgetexplorer] Fix trying to show deleted dialog (authored by anthonyfieroni). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9479?vs=24297=24298 REVISION DETAIL https://phabricator.kde.org/D9479 AFFECTED FILES components/shellprivate/widgetexplorer/widgetexplorer.cpp To: anthonyfieroni, fvogt, davidedmundson, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"
anthonyfieroni added inline comments. INLINE COMMENTS > anthonyfieroni wrote in widgetexplorer.cpp:448 > Such a slot not existing at all. Even more WidgetExplorer is closed upon DownloadDialog is shown, which makes such slot useless. But now it can be opened more than one DownloadDialogs and it looks strange. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9473 To: fvogt, #plasma, davidedmundson, anthonyfieroni Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"
davidedmundson added a comment. That's nice and easy then :) thanks for confirming. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9473 To: fvogt, #plasma, davidedmundson, anthonyfieroni Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"
anthonyfieroni added inline comments. INLINE COMMENTS > davidedmundson wrote in widgetexplorer.cpp:448 > what's the situation with this line? Such a slot not existing at all. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9473 To: fvogt, #plasma, davidedmundson, anthonyfieroni Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9479: [widgetexplorer] Fix trying to show deleted dialog
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9479 To: anthonyfieroni, fvogt, davidedmundson, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"
davidedmundson added inline comments.
INLINE COMMENTS
> widgetexplorer.cpp:448
> d->newStuffDialog.data()->setWindowTitle(i18n("Download New Plasma
> Widgets"));
> +connect(d->newStuffDialog.data(), SIGNAL(accepted()),
> SLOT(newStuffFinished()));
> }
what's the situation with this line?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9473
To: fvogt, #plasma, davidedmundson, anthonyfieroni
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
D9479: [widgetexplorer] Fix trying to show deleted dialog
anthonyfieroni updated this revision to Diff 24297. anthonyfieroni added a comment. Remove entire destructor. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9479?vs=24296=24297 REVISION DETAIL https://phabricator.kde.org/D9479 AFFECTED FILES components/shellprivate/widgetexplorer/widgetexplorer.cpp To: anthonyfieroni, fvogt, davidedmundson, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"
fvogt abandoned this revision. fvogt added a comment. Superseded by https://phabricator.kde.org/D9479 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9473 To: fvogt, #plasma, davidedmundson, anthonyfieroni Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9479: [widgetexplorer] Fix trying to show deleted dialog
fvogt added a comment. IMO you can delete the empty destructor now. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9479 To: anthonyfieroni, fvogt, davidedmundson, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9479: [widgetexplorer] Fix trying to show deleted dialog
anthonyfieroni created this revision. anthonyfieroni added reviewers: fvogt, davidedmundson, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY WidgetExplorer is destroyed on close which deletes KNS dialog. TEST PLAN Manually test, verify it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9479 AFFECTED FILES components/shellprivate/widgetexplorer/widgetexplorer.cpp To: anthonyfieroni, fvogt, davidedmundson, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"
anthonyfieroni added a comment. In https://phabricator.kde.org/D9473#182455, @fvogt wrote: > In https://phabricator.kde.org/D9473#182449, @anthonyfieroni wrote: > > > Yes it is. Reverting it you will not fix anything. Please explain step-by-step what not working. > > > "Download new widgets" -> Either plasmashell crashes instantly or the dialog does not show up and plasmashell crashes on the next click. I'll investigate. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9473 To: fvogt, #plasma, davidedmundson, anthonyfieroni Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9338: [comic] Fix comic updater time interval
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D9338 To: anthonyfieroni, davidedmundson, broulik, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"
fvogt added a comment. In https://phabricator.kde.org/D9473#182454, @anthonyfieroni wrote: > Deletion is needed > https://phabricator.kde.org/source/knewstuff/browse/master/src/downloaddialog.cpp;6de0754aa9258558a7203afc366b49984f0192eb$112 > https://phabricator.kde.org/source/knewstuff/browse/master/src/downloaddialog.cpp;6de0754aa9258558a7203afc366b49984f0192eb$50 > https://phabricator.kde.org/source/knewstuff/browse/master/src/downloadwidget.cpp;6de0754aa9258558a7203afc366b49984f0192eb$69 > https://phabricator.kde.org/source/knewstuff/browse/master/src/downloadwidget.cpp;6de0754aa9258558a7203afc366b49984f0192eb$121 > https://phabricator.kde.org/source/knewstuff/browse/master/src/core/engine.cpp;6de0754aa9258558a7203afc366b49984f0192eb$107 > Save this cache to disk, otherwise not saving anything since dialog just leak. Then the dialog should be destroyed on close or KNS3 needs to save the cache more often. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9473 To: fvogt, #plasma, davidedmundson, anthonyfieroni Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"
fvogt added a comment. In https://phabricator.kde.org/D9473#182449, @anthonyfieroni wrote: > Yes it is. Reverting it you will not fix anything. Please explain step-by-step what not working. "Download new widgets" -> Either plasmashell crashes instantly or the dialog does not show up and plasmashell crashes on the next click. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9473 To: fvogt, #plasma, davidedmundson, anthonyfieroni Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"
anthonyfieroni added a comment. Deletion is needed https://phabricator.kde.org/source/knewstuff/browse/master/src/downloaddialog.cpp;6de0754aa9258558a7203afc366b49984f0192eb$112 https://phabricator.kde.org/source/knewstuff/browse/master/src/downloaddialog.cpp;6de0754aa9258558a7203afc366b49984f0192eb$50 https://phabricator.kde.org/source/knewstuff/browse/master/src/downloadwidget.cpp;6de0754aa9258558a7203afc366b49984f0192eb$69 https://phabricator.kde.org/source/knewstuff/browse/master/src/downloadwidget.cpp;6de0754aa9258558a7203afc366b49984f0192eb$121 https://phabricator.kde.org/source/knewstuff/browse/master/src/core/engine.cpp;6de0754aa9258558a7203afc366b49984f0192eb$107 Save this cache to disk, otherwise not saving anything since dialog just leak. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9473 To: fvogt, #plasma, davidedmundson, anthonyfieroni Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"
anthonyfieroni added a comment. Yes it is. Reverting it you will not fix anything. Please explain step-by-step what not working. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9473 To: fvogt, #plasma, davidedmundson, anthonyfieroni Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9338: [comic] Fix comic updater time interval
anthonyfieroni added inline comments. INLINE COMMENTS > davidedmundson wrote in comicupdater.cpp:86 > I assume this line is the important change? > > +1 to this bit. Yes. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D9338 To: anthonyfieroni, davidedmundson, broulik, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9338: [comic] Fix comic updater time interval
anthonyfieroni updated this revision to Diff 24295. anthonyfieroni marked 2 inline comments as done. anthonyfieroni edited the test plan for this revision. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9338?vs=23936=24295 REVISION DETAIL https://phabricator.kde.org/D9338 AFFECTED FILES applets/comic/comicupdater.cpp To: anthonyfieroni, davidedmundson, broulik, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9391: [effects] Add 'Fullscreen' effect
graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Restricted Application edited projects, added Plasma; removed KWin. A possibility to solve this problem with gtk would be to restrict to Wayland windows. I'm absolutely against any changed to window gravity on X11. And I'm also not happy with a new animation if we already know that it doesn't work correctly. Given that 5.12 will be an LTS this might be unpleasant. I remember that it took several iterations and bugfixes to get the maximize effect work properly. Due to that I personally would prefer if we don't add this for 5.12 or only for Wayland windows. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9391 To: zzag, #kwin, #plasma, graesslin Cc: graesslin, broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9478: Drop use of qtpaths in startkde
apol added inline comments.
INLINE COMMENTS
> apol wrote in startkde.cmake:41
> `sysConfigDirs=${XDG_CONFIG_DIRS:-/etc/xdg}`
>
> As we did for https://phabricator.kde.org/D9299
No, with this you get to remove the if altogether.
> startplasmacompositor.cmake:24
> fi
> +if [ ${XDG_CONFIG_DIRS} ]; then
> +sysConfigDirs=${XDG_CONFIG_DIRS:-/etc/xdg}
Here too.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9478
To: davidedmundson, #plasma
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, mart
D9478: Drop use of qtpaths in startkde
davidedmundson updated this revision to Diff 24293. davidedmundson added a comment. Update with Aleix's change REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9478?vs=24292=24293 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9478 AFFECTED FILES startkde/startkde.cmake startkde/startplasmacompositor.cmake To: davidedmundson, #plasma Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D9478: Drop use of qtpaths in startkde
apol added a comment.
Thanks for looking into this!
INLINE COMMENTS
> startkde.cmake:41
> fi
> +if [ ${XDG_CONFIG_DIRS} ]; then
> +sysConfigDirs=$XDG_CONFIG_DIRS
`sysConfigDirs=${XDG_CONFIG_DIRS:-/etc/xdg}`
As we did for https://phabricator.kde.org/D9299
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9478
To: davidedmundson, #plasma
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, mart
D9478: Drop use of qtpaths in startkde
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Qtpaths doesn't work on some distros (Ubuntu for example, where it's shipped with dev tools) and it's quite a slow way to effectively just read an environment variable. This is a rework of https://phabricator.kde.org/R120:d90c63ac8fe54567dcf5f634f2112c6ab2aa1027 that also correctly includes system directories. TEST PLAN Put shell script in ~/.config/plasma-workspace/env put shell script /etc/xdg/plasma-workspace/env Rebooted. Confirmed both were run Checked earlier 'if' statement works manually in bash. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D9478 AFFECTED FILES startkde/startkde.cmake startkde/startplasmacompositor.cmake To: davidedmundson, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9477: Add comments for layout-templates
This revision was automatically updated to reflect the committed changes. Closed by commit R119:ec2f58f04850: Add comments for layout-templates (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9477?vs=24285=24288 REVISION DETAIL https://phabricator.kde.org/D9477 AFFECTED FILES layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop layout-templates/org.kde.plasma.desktop.defaultPanel/metadata.desktop layout-templates/org.kde.plasma.desktop.emptyPanel/metadata.desktop To: davidedmundson, #plasma, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9477: Add comments for layout-templates
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D9477 To: davidedmundson, #plasma, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9477: Add comments for layout-templates
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Currently not visible in the plasma UI, but appstream complains about a lack of a summary, which I assume means it could be visible in discover/other package manager. TEST PLAN N/A REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D9477 AFFECTED FILES layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop layout-templates/org.kde.plasma.desktop.defaultPanel/metadata.desktop layout-templates/org.kde.plasma.desktop.emptyPanel/metadata.desktop To: davidedmundson, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9474: [Kickoff / Kicker] Move "Add to favorites" entry to the bottom of the context menu
broulik created this revision. broulik added reviewers: Plasma, hein, ivan. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise draws attention away from jump list actions and other more frequently used actions. This got changed with the introduction of per-activity favorites. TEST PLAN "Add to favorites" and "Remove from favorites" actions are now at the bottom of the list. "Show in favorites" menu is also at the bottom and works fine REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9474 AFFECTED FILES applets/kicker/package/contents/code/tools.js applets/kickoff/package/contents/code/tools.js To: broulik, #plasma, hein, ivan Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9324: [Air theme] Add task bar progress graphic
This revision was automatically updated to reflect the committed changes. Closed by commit R242:3889edd6d6e5: [Air theme] Add task bar progress graphic (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9324?vs=23895=24280#toc REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9324?vs=23895=24280 REVISION DETAIL https://phabricator.kde.org/D9324 AFFECTED FILES src/desktoptheme/air/metadata.desktop src/desktoptheme/air/widgets/tasks.svgz To: broulik, #plasma, #vdg, ngraham Cc: abetts, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
D9391: [effects] Add 'Fullscreen' effect
broulik added a comment. Restricted Application edited projects, added KWin; removed Plasma. https://phabricator.kde.org/D6799 for the record (I like your patch better, actually, just if you want to look at my implementation) REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9391 To: zzag, #kwin, #plasma Cc: graesslin, broulik, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8446: [Notifications] Allow selecting text with mouse
This revision was automatically updated to reflect the committed changes. Closed by commit R120:2fc5b90b85df: [Notifications] Allow selecting text with mouse (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8446?vs=21233=24279 REVISION DETAIL https://phabricator.kde.org/D8446 AFFECTED FILES applets/notifications/package/contents/ui/NotificationItem.qml To: broulik, #plasma, #vdg, apol Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9470: Remove unused background.png
This revision was automatically updated to reflect the committed changes. Closed by commit R120:d2d1b9d3ac9e: Remove unused background.png (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9470?vs=24258=24278 REVISION DETAIL https://phabricator.kde.org/D9470 AFFECTED FILES lookandfeel/contents/components/artwork/background.png To: broulik, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9338: [comic] Fix comic updater time interval
davidedmundson added a comment. Can you please fill in the "testing done" field on phabricator. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D9338 To: anthonyfieroni, davidedmundson, broulik, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9338: [comic] Fix comic updater time interval
davidedmundson added inline comments.
INLINE COMMENTS
> comicupdater.cpp:56
> +} else {
> +mUpdateIntervall = 3;
> }
wouldn't you still need to call checkForUpdate() if you went into this path?
Especially as checkForUpdate is the one that sets up the timer to call itself
again
> comicupdater.cpp:86
> if ( !mLastUpdate.isValid() || ( mLastUpdate.addDays( mUpdateIntervall )
> < QDateTime::currentDateTime() ) ) {
> -mGroup.writeEntry( "lastUpdate", QDateTime::currentDateTime() );
> +mLastUpdate = QDateTime::currentDateTime();
> +mGroup.writeEntry( "lastUpdate", mLastUpdate );
I assume this line is the important change?
+1 to this bit.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D9338
To: anthonyfieroni, davidedmundson, broulik, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"
fvogt created this revision. fvogt added reviewers: Plasma, davidedmundson, anthonyfieroni. Restricted Application added a project: Plasma. REVISION SUMMARY This reverts commit https://phabricator.kde.org/R120:84a29ef86380fab40236bdf934b49bc3cf090853. WidgetExplorer gets destroyed immediately the containment is closed, so the dialog is immediately deleted. The bug the patch was supposed to fix is totally unrelated to this, as according to the report a restart of plasmashell does not help. TEST PLAN Not tested, but setting a breakpoint on the dialog's destructor points to this change. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.11 REVISION DETAIL https://phabricator.kde.org/D9473 AFFECTED FILES components/shellprivate/widgetexplorer/widgetexplorer.cpp To: fvogt, #plasma, davidedmundson, anthonyfieroni Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9323: Use ScreenMapper everywhere as a singleton
amantia closed this revision. REVISION DETAIL https://phabricator.kde.org/D9323 To: amantia, #plasma, mwolff, hein Cc: mlaurent, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
