D9549: Horizontally center shadows and make them bigger
abetts added a comment. @hpereiradacosta I feel this is a good direction for the theme. I am sure we can evolve it to fit new ideas. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9549 To: ngraham, abetts, hpereiradacosta, #vdg, #breeze Cc: januz, rpelorosso, apol, mvourlakos, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D9549: Horizontally center shadows and make them bigger
januz added a comment. I knew it would look better, but not //this// much better! Please accept this change REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9549 To: ngraham, abetts, hpereiradacosta, #vdg, #breeze Cc: januz, rpelorosso, apol, mvourlakos, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D8267: Correcting symlinks between col- and row-resize and split_v and _hBug 384864
ostroffjh added a comment. Is there a problem with this, or has it simply fallen through the cracks? REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D8267 To: ostroffjh, #plasma Cc: asturmlechner, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9542: Improve display of technical app info
alexeymin added a comment. I don't spot any obvious problems in QML any more. And I like newer version more than previous... REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9542 To: ngraham, apol, #vdg, #discover_software_store Cc: januz, alexeymin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9549: Horizontally center shadows and make them bigger
rpelorosso added a comment. These new shadows look amazing! :D REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9549 To: ngraham, abetts, hpereiradacosta, #vdg, #breeze Cc: rpelorosso, apol, mvourlakos, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D9549: Horizontally center shadows and make them bigger
ngraham added a comment. No matter what, I will definitely wait for at least @hpereiradacosta to weigh in. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9549 To: ngraham, abetts, hpereiradacosta, #vdg, #breeze Cc: apol, mvourlakos, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D9549: Horizontally center shadows and make them bigger
mvourlakos added a comment. no prob then! REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9549 To: ngraham, abetts, hpereiradacosta, #vdg, #breeze Cc: apol, mvourlakos, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D9549: Horizontally center shadows and make them bigger
mvourlakos added a comment. In https://phabricator.kde.org/D9549#183814, @abetts wrote: > In https://phabricator.kde.org/D9549#183809, @apol wrote: > > > In https://phabricator.kde.org/D9549#183807, @mvourlakos wrote: > > > > > Dont merge please, this needs authorization from VDG first > > > > > > @ngraham and @abetts are the VDG, no? > > > Last I checked I was... ;) REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9549 To: ngraham, abetts, hpereiradacosta, #vdg, #breeze Cc: apol, mvourlakos, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D9542: Improve display of technical app info
ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9542 To: ngraham, apol, #vdg, #discover_software_store Cc: januz, alexeymin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9542: Improve display of technical app info
ngraham updated this revision to Diff 24470. ngraham marked 2 inline comments as done. ngraham added a comment. - Use a larger font instead of bold for the caption - Put the homepage on top, too REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9542?vs=24456=24470 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9542 AFFECTED FILES discover/qml/ApplicationPage.qml To: ngraham, apol, #vdg, #discover_software_store Cc: januz, alexeymin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9512: startplasmacompositor: If available, query org.freedesktop.locale1 for XKB defaults
This revision was automatically updated to reflect the committed changes. Closed by commit R120:361ee31606fb: startplasmacompositor: If available, query org.freedesktop.locale1 for XKB… (authored by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9512?vs=24386=24469 REVISION DETAIL https://phabricator.kde.org/D9512 AFFECTED FILES startkde/startplasmacompositor.cmake To: fvogt, #plasma, graesslin Cc: davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9512: startplasmacompositor: If available, query org.freedesktop.locale1 for XKB defaults
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH localed REVISION DETAIL https://phabricator.kde.org/D9512 To: fvogt, #plasma, graesslin Cc: davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9555: Simulate user activity on fake input events
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application edited projects, added Plasma; removed KWin. REVISION SUMMARY This ensures that using KDE Connect to control input properly inhibits idle timeouts. REPOSITORY R108 KWin BRANCH fake-input-simulate-user-activity REVISION DETAIL https://phabricator.kde.org/D9555 AFFECTED FILES input.cpp wayland_server.cpp wayland_server.h To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7246: Tooltips
graesslin added inline comments. INLINE COMMENTS > McPain wrote in decoratedclientprivate.h:79-80 > I need to avoid sover increasing, right? No, increasing the soversion of the private library is fine. It's only used by KWin and by KDecoration public library. The interface to the decoration plugins (like breeze) is still stable. As KDecoration and KWin are released together it's not a problem. But we should try to get it in before the beta release as distros might need to adjust packaging. REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9549: Horizontally center shadows and make them bigger
abetts added a comment. In https://phabricator.kde.org/D9549#183809, @apol wrote: > In https://phabricator.kde.org/D9549#183807, @mvourlakos wrote: > > > Dont merge please, this needs authorization from VDG first > > > @ngraham and @abetts are the VDG, no? Last I checked I was... ;) REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9549 To: ngraham, abetts, hpereiradacosta, #vdg, #breeze Cc: apol, mvourlakos, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D9549: Horizontally center shadows and make them bigger
apol added a comment. In https://phabricator.kde.org/D9549#183807, @mvourlakos wrote: > Dont merge please, this needs authorization from VDG first @ngraham and @abetts are the VDG, no? REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9549 To: ngraham, abetts, hpereiradacosta, #vdg, #breeze Cc: apol, mvourlakos, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D9549: Horizontally center shadows and make them bigger
mvourlakos added a comment. Dont merge please, this needs authorization from VDG first REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9549 To: ngraham, abetts, hpereiradacosta, #vdg, #breeze Cc: mvourlakos, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9510: [server] Add a method IdleInterface::simulateUserActivity
This revision was automatically updated to reflect the committed changes. Closed by commit R127:4595a2c2709e: [server] Add a method IdleInterface::simulateUserActivity (authored by graesslin). Restricted Application edited projects, added Plasma on Wayland; removed Plasma. CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9510?vs=24380=24459#toc REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9510?vs=24380=24459 REVISION DETAIL https://phabricator.kde.org/D9510 AFFECTED FILES autotests/client/test_idle.cpp src/server/idle_interface.cpp src/server/idle_interface.h To: graesslin, #frameworks, #plasma, #kwin, davidedmundson Cc: plasma-devel, leezu, ZrenBot, ngraham, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
D9549: Horizontally center shadows and make them bigger
abetts accepted this revision. abetts added a comment. This revision is now accepted and ready to land. I love it! People, please accept. Just notice how the depth perception works better this way. With the current implementation, shadows don't show a strong depth perception and they almost disappear. I like this new patch a lot! REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9549 To: ngraham, abetts, hpereiradacosta, #vdg, #breeze Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8232: Add option to center shadow
ngraham added a comment. Per recent https://phabricator.kde.org/tag/vdg/ discussions, I've put together a patch that changes the defaults to horizontally center window and menu shadows, and make them a bit larger: https://phabricator.kde.org/D9549 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8232 To: rpelorosso, #breeze, #vdg, hpereiradacosta Cc: emateli, sebas, januz, alex-l, alake, abetts, progwolff, mvourlakos, rkflx, ngraham, davidedmundson, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, apol
D9542: Improve display of technical app info
ngraham added a comment. I could do a bigger font instead of bold, sure. As for going around in circles: sorry, I wasn't around a few releases ago, so I didn't know what it looked like back then. But folks do seem to think this is nicer than the status quo... REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9542 To: ngraham, apol, #vdg, #discover_software_store Cc: januz, alexeymin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9549: Horizontally center shadows and make them bigger
ngraham edited the test plan for this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9549 To: ngraham, abetts, hpereiradacosta, #vdg, #breeze Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9542: Improve display of technical app info
apol added a comment. We used to have exactly this same layout for that section few releases ago, let's not keep doing the same changes over and over. Also I'm not a big fan of the bold. Maybe it would make sense to make the font slightly bigger? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9542 To: ngraham, apol, #vdg, #discover_software_store Cc: januz, alexeymin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9542: Improve display of technical app info
ngraham added a comment. Good idea, I'll do that too. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9542 To: ngraham, apol, #vdg, #discover_software_store Cc: januz, alexeymin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9542: Improve display of technical app info
januz added a comment. +1 Definitely an improvement. What do you think about grouping the homepage with the rest of the info at the top? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9542 To: ngraham, apol, #vdg, #discover_software_store Cc: januz, alexeymin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9542: Improve display of technical app info
ngraham marked 2 inline comments as done.
ngraham added inline comments.
INLINE COMMENTS
> alexeymin wrote in ApplicationPage.qml:153
> Why do you put a `Text` inside a label? Why not use `font.bold` property of
> Label itself?
This was actually the only way I could get it to work. Doing this:
QQC2.Label {
Layout.fillWidth: true
text: appInfo.application.comment
font.bold: true
wrapMode: Text.WordWrap
elide: Text.ElideRight
maximumLineCount: 1
bottomPadding: 20
}
...had no effect, and did not make the text bold.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D9542
To: ngraham, apol, #vdg, #discover_software_store
Cc: alexeymin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
D9542: Improve display of technical app info
ngraham updated this revision to Diff 24456. ngraham added a comment. - Merge branch 'master' of git.kde.org:discover - Address review comments REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9542?vs=2=24456 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9542 AFFECTED FILES discover/qml/ApplicationPage.qml To: ngraham, apol, #vdg, #discover_software_store Cc: alexeymin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9506: milti-screen sleep fix
McPain planned changes to this revision. McPain added a comment. UPD: As the secondary monitor switches off, windows on it doesn't move to the primary REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D9506 To: McPain, sebas, drosca Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
