D9873: Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account

[Fabian Vogt]

fvogt closed this revision.
fvogt added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Fixed up the trailing whitespace in line 165 and landed: 
https://commits.kde.org/kwin/eb69e87288d37fdb13eca32ca807ed8279f912af

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9873

To: fvogt, #plasma, graesslin
Cc: kwin, plasma-devel, #kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma kinfocenter kf5-qt5 FreeBSDQt5.9 - Build # 10 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kinfocenter%20kf5-qt5%20FreeBSDQt5.9/10/
 Project:
Plasma kinfocenter kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 07:54:12 +
 Build duration:
44 sec and counting
   CONSOLE OUTPUT
  [...truncated 196.89 KB...]#include  ^1 error generated.gmake[2]: *** [Modules/devinfo/CMakeFiles/kcm_devinfo.dir/build.make:87: Modules/devinfo/CMakeFiles/kcm_devinfo.dir/devinfo.cpp.o] Error 1gmake[1]: *** [CMakeFiles/Makefile2:580: Modules/devinfo/CMakeFiles/kcm_devinfo.dir/all] Error 2gmake[1]: *** Waiting for unfinished jobsgmake[2]: *** [Modules/memory/CMakeFiles/kcm_memory.dir/build.make:63: Modules/memory/CMakeFiles/kcm_memory.dir/memory.cpp.o] Error 1gmake[2]: *** Waiting for unfinished jobsgmake[2]: *** [Modules/usbview/CMakeFiles/kcm_usb.dir/build.make:63: Modules/usbview/CMakeFiles/kcm_usb.dir/kcmusb.cpp.o] Error 1gmake[2]: *** Waiting for unfinished jobs[ 26%] Building CXX object Modules/memory/CMakeFiles/kcm_memory.dir/chartWidget.cpp.o[ 28%] Building CXX object Modules/usbview/CMakeFiles/kcm_usb.dir/usbdevices.cpp.o[ 29%] Building CXX object Modules/info/CMakeFiles/kcm_info.dir/info.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma kinfocenter kf5-qt5 FreeBSDQt5.9/Modules/info/info.cpp:22:In file included from /usr/home/jenkins/workspace/Plasma kinfocenter kf5-qt5 FreeBSDQt5.9/Modules/info/info.h:25:In file included from /usr/local/include/qt5/QtWidgets/QWidget:1:In file included from /usr/local/include/qt5/QtWidgets/qwidget.h:43:In file included from /usr/local/include/qt5/QtWidgets/qtwidgetsglobal.h:43:In file included from /usr/local/include/qt5/QtGui/qtguiglobal.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:9:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^In file included from /usr/home/jenkins/workspace/Plasma kinfocenter kf5-qt5 FreeBSDQt5.9/Modules/usbview/usbdevices.cpp:11:In file included from /usr/home/jenkins/workspace/Plasma kinfocenter kf5-qt5 FreeBSDQt5.9/Modules/usbview/usbdevices.h:14:In file included from /usr/local/include/qt5/QtGui/QList:1:In file included from /usr/local/include/qt5/QtGui/qevent.h:43:In file included from /usr/local/include/qt5/QtGui/qtguiglobal.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:9:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^In file included from /usr/home/jenkins/workspace/Plasma kinfocenter kf5-qt5 FreeBSDQt5.9/Modules/memory/chartWidget.cpp:12:In file included from /usr/home/jenkins/workspace/Plasma kinfocenter kf5-qt5 FreeBSDQt5.9/Modules/memory/chartWidget.h:25:In file included from /usr/local/include/qt5/QtWidgets/QWidget:1:In file included from /usr/local/include/qt5/QtWidgets/qwidget.h:43:In file included from /usr/local/include/qt5/QtWidgets/qtwidgetsglobal.h:43:In file included from /usr/local/include/qt5/QtGui/qtguiglobal.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:9:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^1 error generated.gmake[2]: *** [Modules/about-distro/src/CMakeFiles/kcm_about_distro.dir/build.make:91: Modules/about-distro/src/CMakeFiles/kcm_about_distro.dir/Module.cpp.o] Error 1gmake[1]: *** [CMakeFiles/Makefile2:316: Modules/about-distro/src/CMakeFiles/kcm_about_distro.dir/all] Error 2[ 30%] Building CXX object Modules/info/CMakeFiles/kcm_info.dir/__/base/os_current.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma kinfocenter kf5-qt5 FreeBSDQt5.9/Modules/base/os_current.cpp:24:In file included from /usr/home/jenkins/workspace/Plasma kinfocenter kf5-qt5 FreeBSDQt5.9/Modules/info/../base/os_base.h:25:In file included from /usr/local/include/qt5/QtCore/QString:1:In file included from /usr/local/include/qt5/QtCore/qstring.h:48:In file included from /usr/local/include/qt5/QtCore/qchar.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:9:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^[ 30%] Built target doc-index-cache-bz2[ 32%] Building CXX object Modules/info/CMakeFiles/kcm_info.dir/__/base/info_wayland.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma kinfocenter kf5-qt5 FreeBSDQt5.9/Modules/base/info_wayland.cpp:21:In file included from /usr/home/jenkins/workspace/Plasma kinfocenter kf5-qt5 FreeBSDQt5.9/Modules/info/../base/info_wayland.h:24:In file included from 

KDE CI: Plasma kinfocenter kf5-qt5 FreeBSDQt5.9 - Build # 9 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kinfocenter%20kf5-qt5%20FreeBSDQt5.9/9/
 Project:
Plasma kinfocenter kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 07:51:42 +
 Build duration:
1 min 20 sec and counting
   CONSOLE OUTPUT
  [...truncated 166.96 KB...]In file included from /usr/local/include/qt5/QtCore/qmap.h:43:In file included from /usr/local/include/qt5/QtCore/qiterator.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:9:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^In file included from /usr/home/jenkins/workspace/Plasma kinfocenter kf5-qt5 FreeBSDQt5.9/Modules/usbview/kcmusb.cpp:10:In file included from /usr/home/jenkins/workspace/Plasma kinfocenter kf5-qt5 FreeBSDQt5.9/Modules/usbview/kcmusb.h:14:In file included from /usr/local/include/qt5/QtCore/QMap:1:In file included from /usr/local/include/qt5/QtCore/qmap.h:43:In file included from /usr/local/include/qt5/QtCore/qiterator.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:9:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^[ 20%] Built target kcm_samba_autogen[ 21%] Building CXX object Modules/usbview/CMakeFiles/kcm_usb.dir/usbdevices.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma kinfocenter kf5-qt5 FreeBSDQt5.9/Modules/usbview/usbdevices.cpp:11:In file included from /usr/home/jenkins/workspace/Plasma kinfocenter kf5-qt5 FreeBSDQt5.9/Modules/usbview/usbdevices.h:14:In file included from /usr/local/include/qt5/QtGui/QList:1:In file included from /usr/local/include/qt5/QtGui/qevent.h:43:In file included from /usr/local/include/qt5/QtGui/qtguiglobal.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:9:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^[ 21%] Built target kcm_opengl_autogen[ 22%] Building CXX object Modules/usbview/CMakeFiles/kcm_usb.dir/usbdb.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma kinfocenter kf5-qt5 FreeBSDQt5.9/Modules/usbview/usbdb.cpp:11:In file included from /usr/home/jenkins/workspace/Plasma kinfocenter kf5-qt5 FreeBSDQt5.9/Modules/usbview/usbdb.h:14:In file included from /usr/local/include/qt5/QtCore/QMap:1:In file included from /usr/local/include/qt5/QtCore/qmap.h:43:In file included from /usr/local/include/qt5/QtCore/qiterator.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:9:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^1 error generated.1 error generated.gmake[2]: *** [CMakeFiles/kinfocenter.dir/build.make:63: CMakeFiles/kinfocenter.dir/infocenter.cpp.o] Error 1gmake[1]: *** [CMakeFiles/Makefile2:68: CMakeFiles/kinfocenter.dir/all] Error 2gmake[1]: *** Waiting for unfinished jobsgmake[2]: *** [Modules/about-distro/src/CMakeFiles/kcm_about_distro.dir/build.make:67: Modules/about-distro/src/CMakeFiles/kcm_about_distro.dir/main.cpp.o] Error 1gmake[2]: *** Waiting for unfinished jobs[ 24%] Building CXX object Modules/about-distro/src/CMakeFiles/kcm_about_distro.dir/Module.cpp.o[ 25%] Building CXX object Modules/usbview/CMakeFiles/kcm_usb.dir/kcm_usb_autogen/mocs_compilation.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma kinfocenter kf5-qt5 FreeBSDQt5.9/Modules/about-distro/src/Module.cpp:21:In file included from /usr/home/jenkins/workspace/Plasma kinfocenter kf5-qt5 FreeBSDQt5.9/Modules/about-distro/src/Module.h:24:In file included from /usr/home/jenkins/install-prefix/include/KF5/KConfigWidgets/KCModule:1:In file included from /usr/home/jenkins/install-prefix/include/KF5/KConfigWidgets/kcmodule.h:28:In file included from /usr/home/jenkins/install-prefix/include/KF5/KAuth/kauthaction.h:24:In file included from /usr/local/include/qt5/QtCore/QString:1:In file included from /usr/local/include/qt5/QtCore/qstring.h:48:In file included from /usr/local/include/qt5/QtCore/qchar.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:9:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^In file included from /usr/home/jenkins/workspace/Plasma kinfocenter kf5-qt5 FreeBSDQt5.9/build/Modules/usbview/kcm_usb_autogen/mocs_compilation.cpp:2:In file included from /usr/home/jenkins/workspace/Plasma kinfocenter kf5-qt5 

KDE CI: Plasma kinfocenter kf5-qt5 FreeBSDQt5.9 - Build # 8 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kinfocenter%20kf5-qt5%20FreeBSDQt5.9/8/
 Project:
Plasma kinfocenter kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 07:21:35 +
 Build duration:
2 min 32 sec and counting
   CONSOLE OUTPUT
  [...truncated 133.09 KB...] * KF5ConfigWidgets (required version >= 5.30) * KF5CoreAddons (required version >= 5.30) * KF5Crash (required version >= 5.30) * KF5DBusAddons (required version >= 5.30) * KF5DocTools (required version >= 5.30) * Gettext * PythonInterp * KF5I18n (required version >= 5.30) * KF5IconThemes (required version >= 5.30) * KF5KCMUtils (required version >= 5.30) * KF5KIO (required version >= 5.30) * KF5Service (required version >= 5.30) * KF5WidgetsAddons (required version >= 5.30) * KF5XmlGui (required version >= 5.30) * KF5Declarative (required version >= 5.30) * ECM (required version >= 1.6.0) * Qt5Core * KF5Package (required version >= 5.30) * KF5Solid (required version >= 5.30) * KF5 (required version >= 5.30)-- The following OPTIONAL packages have not been found: * RAW1394, library for direct access to IEEE 1394 bus,View FireWire devices in kinfocenter.-- Configuring done-- Generating done-- Build files have been written to: /usr/home/jenkins/workspace/Plasma kinfocenter kf5-qt5 FreeBSDQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Plasma kinfocenter kf5-qt5 FreeBSDQt5.9] Running shell script+ python3.5 -u ci-tooling/helpers/compile-build.py --product Plasma --project kinfocenter --branchGroup kf5-qt5 --platform FreeBSDQt5.9 --usingInstall /usr/home/jenkins/install-prefix/Scanning dependencies of target kinfocenter_autogenScanning dependencies of target kcm_about_distro_autogen[  1%] Automatic MOC for target kinfocenter[  2%] Automatic MOC for target kcm_about_distro[  2%] Built target kcm_about_distro_autogenScanning dependencies of target kcm_usb_autogen[  4%] Automatic MOC for target kcm_usb[  4%] Built target kcm_usb_autogenScanning dependencies of target kcm_memory_autogen[  5%] Automatic MOC for target kcm_memory[  5%] Built target kinfocenter_autogenScanning dependencies of target kcm_devinfo_autogen[  6%] Automatic MOC for target kcm_devinfo[  6%] Built target kcm_memory_autogenScanning dependencies of target kcm_info_autogen[  8%] Automatic MOC for target kcm_info[  8%] Built target kcm_info_autogenScanning dependencies of target kcm_samba_autogen[  9%] Automatic MOC for target kcm_samba[  9%] Built target kcm_devinfo_autogenScanning dependencies of target kcm_nic_autogen[ 10%] Automatic MOC for target kcm_nic[ 10%] Built target kcm_nic_autogenScanning dependencies of target kcm_opengl_autogen[ 12%] Automatic MOC for target kcm_opengl[ 12%] Built target kcm_samba_autogenScanning dependencies of target kcm_pci_autogen[ 13%] Automatic MOC for target kcm_pci[ 13%] Built target kcm_opengl_autogenScanning dependencies of target doc-index-cache-bz2[ 14%] Generating index.cache.bz2[ 14%] Built target kcm_pci_autogenScanning dependencies of target kinfocenter[ 16%] Building CXX object CMakeFiles/kinfocenter.dir/infocenter.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma kinfocenter kf5-qt5 FreeBSDQt5.9/infocenter.cpp:24:In file included from /usr/home/jenkins/workspace/Plasma kinfocenter kf5-qt5 FreeBSDQt5.9/infocenter.h:27:In file included from /usr/home/jenkins/install-prefix/include/KF5/KXmlGui/KXmlGuiWindow:1:In file included from /usr/home/jenkins/install-prefix/include/KF5/KXmlGui/kxmlguiwindow.h:31:In file included from /usr/home/jenkins/install-prefix/include/KF5/KXmlGui/kxmlguiclient.h:24:In file included from /usr/local/include/qt5/QtCore/QMap:1:In file included from /usr/local/include/qt5/QtCore/qmap.h:43:In file included from /usr/local/include/qt5/QtCore/qiterator.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:9:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^1 error generated.gmake[2]: *** [CMakeFiles/kinfocenter.dir/build.make:63: CMakeFiles/kinfocenter.dir/infocenter.cpp.o] Error 1gmake[1]: *** [CMakeFiles/Makefile2:68: CMakeFiles/kinfocenter.dir/all] Error 2gmake[1]: *** Waiting for unfinished jobs[ 16%] Built target doc-index-cache-bz2gmake: *** [Makefile:141: all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Plasma kinfocenter kf5-qt5 FreeBSDQt5.9] Running shell script+ python3.5 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Plasma kinfocenter kf5-qt5 FreeBSDQt5.9 - Build # 7 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kinfocenter%20kf5-qt5%20FreeBSDQt5.9/7/
 Project:
Plasma kinfocenter kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 07:18:42 +
 Build duration:
2 min 43 sec and counting
   CONSOLE OUTPUT
  [...truncated 133.11 KB...] * KF5ConfigWidgets (required version >= 5.30) * KF5CoreAddons (required version >= 5.30) * KF5Crash (required version >= 5.30) * KF5DBusAddons (required version >= 5.30) * KF5DocTools (required version >= 5.30) * Gettext * PythonInterp * KF5I18n (required version >= 5.30) * KF5IconThemes (required version >= 5.30) * KF5KCMUtils (required version >= 5.30) * KF5KIO (required version >= 5.30) * KF5Service (required version >= 5.30) * KF5WidgetsAddons (required version >= 5.30) * KF5XmlGui (required version >= 5.30) * KF5Declarative (required version >= 5.30) * ECM (required version >= 1.6.0) * Qt5Core * KF5Package (required version >= 5.30) * KF5Solid (required version >= 5.30) * KF5 (required version >= 5.30)-- The following OPTIONAL packages have not been found: * RAW1394, library for direct access to IEEE 1394 bus,View FireWire devices in kinfocenter.-- Configuring done-- Generating done-- Build files have been written to: /usr/home/jenkins/workspace/Plasma kinfocenter kf5-qt5 FreeBSDQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Plasma kinfocenter kf5-qt5 FreeBSDQt5.9] Running shell script+ python3.5 -u ci-tooling/helpers/compile-build.py --product Plasma --project kinfocenter --branchGroup kf5-qt5 --platform FreeBSDQt5.9 --usingInstall /usr/home/jenkins/install-prefix/Scanning dependencies of target kinfocenter_autogenScanning dependencies of target kcm_about_distro_autogen[  1%] Automatic MOC for target kinfocenter[  2%] Automatic MOC for target kcm_about_distro[  2%] Built target kcm_about_distro_autogenScanning dependencies of target kcm_usb_autogen[  4%] Automatic MOC for target kcm_usb[  4%] Built target kcm_usb_autogenScanning dependencies of target kcm_memory_autogen[  5%] Automatic MOC for target kcm_memory[  5%] Built target kinfocenter_autogenScanning dependencies of target kcm_devinfo_autogen[  6%] Automatic MOC for target kcm_devinfo[  6%] Built target kcm_memory_autogenScanning dependencies of target kcm_info_autogen[  8%] Automatic MOC for target kcm_info[  8%] Built target kcm_info_autogenScanning dependencies of target kcm_samba_autogen[  9%] Automatic MOC for target kcm_samba[  9%] Built target kcm_devinfo_autogenScanning dependencies of target kcm_nic_autogen[ 10%] Automatic MOC for target kcm_nic[ 10%] Built target kcm_nic_autogenScanning dependencies of target kcm_opengl_autogen[ 12%] Automatic MOC for target kcm_opengl[ 12%] Built target kcm_samba_autogenScanning dependencies of target kcm_pci_autogen[ 13%] Automatic MOC for target kcm_pci[ 13%] Built target kcm_pci_autogenScanning dependencies of target doc-index-cache-bz2[ 14%] Generating index.cache.bz2[ 14%] Built target kcm_opengl_autogenScanning dependencies of target kinfocenter[ 16%] Building CXX object CMakeFiles/kinfocenter.dir/infocenter.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma kinfocenter kf5-qt5 FreeBSDQt5.9/infocenter.cpp:24:In file included from /usr/home/jenkins/workspace/Plasma kinfocenter kf5-qt5 FreeBSDQt5.9/infocenter.h:27:In file included from /usr/home/jenkins/install-prefix/include/KF5/KXmlGui/KXmlGuiWindow:1:In file included from /usr/home/jenkins/install-prefix/include/KF5/KXmlGui/kxmlguiwindow.h:31:In file included from /usr/home/jenkins/install-prefix/include/KF5/KXmlGui/kxmlguiclient.h:24:In file included from /usr/local/include/qt5/QtCore/QMap:1:In file included from /usr/local/include/qt5/QtCore/qmap.h:43:In file included from /usr/local/include/qt5/QtCore/qiterator.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:9:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^1 error generated.gmake[2]: *** [CMakeFiles/kinfocenter.dir/build.make:63: CMakeFiles/kinfocenter.dir/infocenter.cpp.o] Error 1gmake[1]: *** [CMakeFiles/Makefile2:68: CMakeFiles/kinfocenter.dir/all] Error 2gmake[1]: *** Waiting for unfinished jobs[ 16%] Built target doc-index-cache-bz2gmake: *** [Makefile:141: all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Plasma kinfocenter kf5-qt5 FreeBSDQt5.9] Running shell script+ python3.5 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Plasma kdeplasma-addons kf5-qt5 FreeBSDQt5.9 - Build # 13 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kdeplasma-addons%20kf5-qt5%20FreeBSDQt5.9/13/
 Project:
Plasma kdeplasma-addons kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 06:49:37 +
 Build duration:
2 min 42 sec and counting
   CONSOLE OUTPUT
  [...truncated 536.63 KB...]Scanning dependencies of target notesplugin[ 30%] Building CXX object applets/mediaframe/CMakeFiles/mediaframeplugin.dir/plugin/mediaframe.cpp.o[ 30%] Building CXX object applets/notes/CMakeFiles/notesplugin.dir/plugin/abstractnoteloader.cpp.o1 error generated.gmake[2]: *** [applets/fifteenPuzzle/CMakeFiles/fifteenpuzzleplugin.dir/build.make:87: applets/fifteenPuzzle/CMakeFiles/fifteenpuzzleplugin.dir/plugin/fifteenpuzzleplugin.cpp.o] Error 1gmake[1]: *** [CMakeFiles/Makefile2:1383: applets/fifteenPuzzle/CMakeFiles/fifteenpuzzleplugin.dir/all] Error 2gmake[1]: *** Waiting for unfinished jobsIn file included from /usr/home/jenkins/workspace/Plasma kdeplasma-addons kf5-qt5 FreeBSDQt5.9/applets/notes/plugin/abstractnoteloader.cpp:22:In file included from /usr/local/include/qt5/QtCore/QString:1:In file included from /usr/local/include/qt5/QtCore/qstring.h:48:In file included from /usr/local/include/qt5/QtCore/qchar.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:10:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^[ 31%] Building CXX object applets/notes/CMakeFiles/notesplugin.dir/plugin/documenthandler.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma kdeplasma-addons kf5-qt5 FreeBSDQt5.9/applets/mediaframe/plugin/mediaframe.cpp:19:In file included from /usr/home/jenkins/workspace/Plasma kdeplasma-addons kf5-qt5 FreeBSDQt5.9/applets/mediaframe/plugin/mediaframe.h:22:In file included from /usr/local/include/qt5/QtCore/QObject:1:In file included from /usr/local/include/qt5/QtCore/qobject.h:46:In file included from /usr/local/include/qt5/QtCore/qobjectdefs.h:48:In file included from /usr/local/include/qt5/QtCore/qnamespace.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:10:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^In file included from /usr/home/jenkins/workspace/Plasma kdeplasma-addons kf5-qt5 FreeBSDQt5.9/applets/notes/plugin/documenthandler.cpp:47:In file included from /usr/home/jenkins/workspace/Plasma kdeplasma-addons kf5-qt5 FreeBSDQt5.9/applets/notes/plugin/documenthandler.h:44:In file included from /usr/local/include/qt5/QtQuick/QQuickTextDocument:1:In file included from /usr/local/include/qt5/QtQuick/qquicktextdocument.h:43:In file included from /usr/local/include/qt5/QtGui/QTextDocument:1:In file included from /usr/local/include/qt5/QtGui/qtextdocument.h:43:In file included from /usr/local/include/qt5/QtGui/qtguiglobal.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:10:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^[ 31%] Built target plasma_applet_comic_autogen[ 32%] Building CXX object applets/mediaframe/CMakeFiles/mediaframeplugin.dir/plugin/mediaframeplugin.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma kdeplasma-addons kf5-qt5 FreeBSDQt5.9/applets/mediaframe/plugin/mediaframeplugin.cpp:19:In file included from /usr/home/jenkins/workspace/Plasma kdeplasma-addons kf5-qt5 FreeBSDQt5.9/applets/mediaframe/plugin/mediaframeplugin.h:22:In file included from /usr/local/include/qt5/QtQml/QQmlEngine:1:In file included from /usr/local/include/qt5/QtQml/qqmlengine.h:43:In file included from /usr/local/include/qt5/QtCore/qurl.h:44:In file included from /usr/local/include/qt5/QtCore/qbytearray.h:44:In file included from /usr/local/include/qt5/QtCore/qrefcount.h:43:In file included from /usr/local/include/qt5/QtCore/qatomic.h:41:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:10:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^1 error generated.gmake[2]: *** [applets/notes/CMakeFiles/notesplugin.dir/build.make:63: applets/notes/CMakeFiles/notesplugin.dir/plugin/abstractnoteloader.cpp.o] Error 1gmake[2]: *** Waiting for unfinished jobs[ 32%] Building CXX object applets/mediaframe/CMakeFiles/mediaframeplugin.dir/mediaframeplugin_autogen/mocs_compilation.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma kdeplasma-addons kf5-qt5 FreeBSDQt5.9/build/applets/mediaframe/mediaframeplugin_autogen/mocs_compilation.cpp:2:In file included from 

D9873: Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account

[Martin Flöser]

graesslin accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9873

To: fvogt, #plasma, graesslin
Cc: kwin, plasma-devel, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 104 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/104/
 Project:
Plasma discover kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 02:40:39 +
 Build duration:
2 min 7 sec and counting
   CONSOLE OUTPUT
  [...truncated 128.88 KB...] * KF5 * ECM (required version >= 1.6.0) * Qt5Core-- The following OPTIONAL packages have not been found: * packagekitqt5, Library that exposes PackageKit resources,Required to build the PackageKit backend * AppStreamQt (required version >= 0.11.1), Library that lists Appstream resources,Required to build the PackageKit backend-- Configuring doneCMake Warning (dev) in discover/CMakeLists.txt:  Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED files.  Run "cmake --help-policy CMP0071" for policy details.  Use the cmake_policy  command to set the policy and suppress this warning.  For compatibility, CMake is excluding the GENERATED source file(s):"/usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/discover/qrc_resources.cpp""/usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/discover/qrc_assets.cpp"  from processing by AUTOMOC.  If any of the files should be processed, set  CMP0071 to NEW.  If any of the files should not be processed, explicitly  exclude them by setting the source file property SKIP_AUTOMOC:set_property(SOURCE file.h PROPERTY SKIP_AUTOMOC ON)This warning is for project developers.  Use -Wno-dev to suppress it.-- Generating done-- Build files have been written to: /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Plasma discover kf5-qt5 FreeBSDQt5.9] Running shell script+ python3.5 -u ci-tooling/helpers/compile-build.py --product Plasma --project discover --branchGroup kf5-qt5 --platform FreeBSDQt5.9 --usingInstall /usr/home/jenkins/install-prefix/Scanning dependencies of target DiscoverNotifiers_autogenScanning dependencies of target DiscoverCommon_autogen[  1%] Automatic MOC for target DiscoverNotifiers[  2%] Automatic MOC for target DiscoverCommon[  2%] Built target DiscoverNotifiers_autogenScanning dependencies of target PaginateModelTest_autogen[  3%] Automatic MOC for target PaginateModelTest[  3%] Built target PaginateModelTest_autogenScanning dependencies of target org.kde.discovernotifier-plasmoids-metadata-json[  4%] Generating org.kde.discovernotifier-plasmoids-metadata.jsonAbout to parse service type file "/usr/home/jenkins/install-prefix/share/kservicetypes5/plasma-applet.desktop"Found property definition "X-Plasma-API" with type "QString"Found property definition "X-Plasma-RootPath" with type "QString"Found property definition "X-Plasma-MainScript" with type "QString"Found property definition "X-Plasma-ContainmentType" with type "QString"Found property definition "X-Plasma-DropMimeTypes" with type "QStringList"Found property definition "X-Plasma-DropUrlPatterns" with type "QStringList"Found property definition "X-Plasma-NotificationArea" with type "QString"Found property definition "X-Plasma-NotificationAreaCategory" with type "QString"Found property definition "X-Plasma-DBusActivationService" with type "QString"Found property definition "X-KDE-ParentApp" with type "QString"Found property definition "X-Plasma-Provides" with type "QStringList"Found property definition "X-Plasma-ConfigPlugins" with type "QStringList"Found property definition "X-Plasma-StandAloneApp" with type "bool"Found property definition "X-Plasma-RequiredExtensions" with type "QStringList"Found property definition "NoDisplay" with type "bool"Unknown property type for key "X-Plasma-Requires-FileDialog" -> falling back to stringUnknown property type for key "X-Plasma-Requires-LaunchApp" -> falling back to stringGenerated  "/usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/notifier/org.kde.discovernotifier-plasmoids-metadata.json" [  4%] Built target org.kde.discovernotifier-plasmoids-metadata-jsonScanning dependencies of target DiscoverNotifiers[  4%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/BackendNotifierModule.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/libdiscover/notifiers/BackendNotifierModule.cpp:21:In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/libdiscover/notifiers/BackendNotifierModule.h:24:In file included from /usr/local/include/qt5/QtCore/QObject:1:In file included from /usr/local/include/qt5/QtCore/qobject.h:46:In file included from /usr/local/include/qt5/QtCore/qobjectdefs.h:48:In file included from /usr/local/include/qt5/QtCore/qnamespace.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:9:10: fatal error: 

D9868: Rename Discover's "Home" page to "Featured"

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:f9515410f251: Rename Discovers Home 
page to Featured (authored by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9868?vs=25349=25362

REVISION DETAIL
  https://phabricator.kde.org/D9868

AFFECTED FILES
  discover/qml/BrowsingPage.qml

To: ngraham, apol, #discover_software_store
Cc: ankits, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 103 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/103/
 Project:
Plasma discover kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 02:18:39 +
 Build duration:
2 min 17 sec and counting
   CONSOLE OUTPUT
  [...truncated 128.98 KB...] * KF5 * ECM (required version >= 1.6.0) * Qt5Core-- The following OPTIONAL packages have not been found: * packagekitqt5, Library that exposes PackageKit resources,Required to build the PackageKit backend * AppStreamQt (required version >= 0.11.1), Library that lists Appstream resources,Required to build the PackageKit backend-- Configuring doneCMake Warning (dev) in discover/CMakeLists.txt:  Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED files.  Run "cmake --help-policy CMP0071" for policy details.  Use the cmake_policy  command to set the policy and suppress this warning.  For compatibility, CMake is excluding the GENERATED source file(s):"/usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/discover/qrc_resources.cpp""/usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/discover/qrc_assets.cpp"  from processing by AUTOMOC.  If any of the files should be processed, set  CMP0071 to NEW.  If any of the files should not be processed, explicitly  exclude them by setting the source file property SKIP_AUTOMOC:set_property(SOURCE file.h PROPERTY SKIP_AUTOMOC ON)This warning is for project developers.  Use -Wno-dev to suppress it.-- Generating done-- Build files have been written to: /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Plasma discover kf5-qt5 FreeBSDQt5.9] Running shell script+ python3.5 -u ci-tooling/helpers/compile-build.py --product Plasma --project discover --branchGroup kf5-qt5 --platform FreeBSDQt5.9 --usingInstall /usr/home/jenkins/install-prefix/Scanning dependencies of target DiscoverNotifiers_autogenScanning dependencies of target DiscoverCommon_autogen[  1%] Automatic MOC for target DiscoverNotifiers[  2%] Automatic MOC for target DiscoverCommon[  2%] Built target DiscoverNotifiers_autogenScanning dependencies of target PaginateModelTest_autogen[  3%] Automatic MOC for target PaginateModelTest[  3%] Built target PaginateModelTest_autogenScanning dependencies of target org.kde.discovernotifier-plasmoids-metadata-json[  4%] Generating org.kde.discovernotifier-plasmoids-metadata.jsonAbout to parse service type file "/usr/home/jenkins/install-prefix/share/kservicetypes5/plasma-applet.desktop"Found property definition "X-Plasma-API" with type "QString"Found property definition "X-Plasma-RootPath" with type "QString"Found property definition "X-Plasma-MainScript" with type "QString"Found property definition "X-Plasma-ContainmentType" with type "QString"Found property definition "X-Plasma-DropMimeTypes" with type "QStringList"Found property definition "X-Plasma-DropUrlPatterns" with type "QStringList"Found property definition "X-Plasma-NotificationArea" with type "QString"Found property definition "X-Plasma-NotificationAreaCategory" with type "QString"Found property definition "X-Plasma-DBusActivationService" with type "QString"Found property definition "X-KDE-ParentApp" with type "QString"Found property definition "X-Plasma-Provides" with type "QStringList"Found property definition "X-Plasma-ConfigPlugins" with type "QStringList"Found property definition "X-Plasma-StandAloneApp" with type "bool"Found property definition "X-Plasma-RequiredExtensions" with type "QStringList"Found property definition "NoDisplay" with type "bool"Unknown property type for key "X-Plasma-Requires-FileDialog" -> falling back to stringUnknown property type for key "X-Plasma-Requires-LaunchApp" -> falling back to stringGenerated  "/usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/notifier/org.kde.discovernotifier-plasmoids-metadata.json" [  4%] Built target org.kde.discovernotifier-plasmoids-metadata-jsonScanning dependencies of target DiscoverNotifiers[  4%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/BackendNotifierModule.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/libdiscover/notifiers/BackendNotifierModule.cpp:21:In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/libdiscover/notifiers/BackendNotifierModule.h:24:In file included from /usr/local/include/qt5/QtCore/QObject:1:In file included from /usr/local/include/qt5/QtCore/qobject.h:46:In file included from /usr/local/include/qt5/QtCore/qobjectdefs.h:48:In file included from /usr/local/include/qt5/QtCore/qnamespace.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:9:10: fatal error: 

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 102 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/102/
 Project:
Plasma discover kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 02:06:54 +
 Build duration:
1 min 12 sec and counting
   CONSOLE OUTPUT
  [...truncated 134.68 KB...]  For compatibility, CMake is excluding the GENERATED source file(s):"/usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/discover/qrc_resources.cpp""/usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/discover/qrc_assets.cpp"  from processing by AUTOMOC.  If any of the files should be processed, set  CMP0071 to NEW.  If any of the files should not be processed, explicitly  exclude them by setting the source file property SKIP_AUTOMOC:set_property(SOURCE file.h PROPERTY SKIP_AUTOMOC ON)This warning is for project developers.  Use -Wno-dev to suppress it.-- Generating done-- Build files have been written to: /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Plasma discover kf5-qt5 FreeBSDQt5.9] Running shell script+ python3.5 -u ci-tooling/helpers/compile-build.py --product Plasma --project discover --branchGroup kf5-qt5 --platform FreeBSDQt5.9 --usingInstall /usr/home/jenkins/install-prefix/Scanning dependencies of target DiscoverCommon_autogenScanning dependencies of target PaginateModelTest_autogenScanning dependencies of target DiscoverNotifiers_autogenScanning dependencies of target org.kde.discovernotifier-plasmoids-metadata-json[  1%] Automatic MOC for target DiscoverCommon[  2%] Automatic MOC for target PaginateModelTest[  3%] Automatic MOC for target DiscoverNotifiers[  4%] Generating org.kde.discovernotifier-plasmoids-metadata.jsonAbout to parse service type file "/usr/home/jenkins/install-prefix/share/kservicetypes5/plasma-applet.desktop"Found property definition "X-Plasma-API" with type "QString"Found property definition "X-Plasma-RootPath" with type "QString"Found property definition "X-Plasma-MainScript" with type "QString"Found property definition "X-Plasma-ContainmentType" with type "QString"Found property definition "X-Plasma-DropMimeTypes" with type "QStringList"Found property definition "X-Plasma-DropUrlPatterns" with type "QStringList"Found property definition "X-Plasma-NotificationArea" with type "QString"Found property definition "X-Plasma-NotificationAreaCategory" with type "QString"Found property definition "X-Plasma-DBusActivationService" with type "QString"Found property definition "X-KDE-ParentApp" with type "QString"Found property definition "X-Plasma-Provides" with type "QStringList"Found property definition "X-Plasma-ConfigPlugins" with type "QStringList"Found property definition "X-Plasma-StandAloneApp" with type "bool"Found property definition "X-Plasma-RequiredExtensions" with type "QStringList"Found property definition "NoDisplay" with type "bool"Unknown property type for key "X-Plasma-Requires-FileDialog" -> falling back to stringUnknown property type for key "X-Plasma-Requires-LaunchApp" -> falling back to stringGenerated  "/usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/notifier/org.kde.discovernotifier-plasmoids-metadata.json" [  4%] Built target org.kde.discovernotifier-plasmoids-metadata-json[  4%] Built target DiscoverNotifiers_autogenScanning dependencies of target DiscoverNotifiers[  4%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/BackendNotifierModule.cpp.o[  5%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/DiscoverNotifiers_autogen/mocs_compilation.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/libdiscover/notifiers/DiscoverNotifiers_autogen/mocs_compilation.cpp:2:In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/libdiscover/notifiers/DiscoverNotifiers_autogen/EWIEGA46WW/moc_BackendNotifierModule.cpp:9:In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/libdiscover/notifiers/DiscoverNotifiers_autogen/EWIEGA46WW/../../../../../libdiscover/notifiers/BackendNotifierModule.h:24:In file included from /usr/local/include/qt5/QtCore/QObject:1:In file included from /usr/local/include/qt5/QtCore/qobject.h:46:In file included from /usr/local/include/qt5/QtCore/qobjectdefs.h:48:In file included from /usr/local/include/qt5/QtCore/qnamespace.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:9:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/libdiscover/notifiers/BackendNotifierModule.cpp:21:In file included from 

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 101 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/101/
 Project:
Plasma discover kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 01:57:24 +
 Build duration:
1 min 4 sec and counting
   CONSOLE OUTPUT
  [...truncated 134.02 KB...]  For compatibility, CMake is excluding the GENERATED source file(s):"/usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/discover/qrc_resources.cpp""/usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/discover/qrc_assets.cpp"  from processing by AUTOMOC.  If any of the files should be processed, set  CMP0071 to NEW.  If any of the files should not be processed, explicitly  exclude them by setting the source file property SKIP_AUTOMOC:set_property(SOURCE file.h PROPERTY SKIP_AUTOMOC ON)This warning is for project developers.  Use -Wno-dev to suppress it.-- Generating done-- Build files have been written to: /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Plasma discover kf5-qt5 FreeBSDQt5.9] Running shell script+ python3.5 -u ci-tooling/helpers/compile-build.py --product Plasma --project discover --branchGroup kf5-qt5 --platform FreeBSDQt5.9 --usingInstall /usr/home/jenkins/install-prefix/Scanning dependencies of target org.kde.discovernotifier-plasmoids-metadata-jsonScanning dependencies of target DiscoverCommon_autogenScanning dependencies of target PaginateModelTest_autogenScanning dependencies of target DiscoverNotifiers_autogen[  2%] Generating org.kde.discovernotifier-plasmoids-metadata.json[  3%] Automatic MOC for target DiscoverCommon[  3%] Automatic MOC for target PaginateModelTest[  4%] Automatic MOC for target DiscoverNotifiersAbout to parse service type file "/usr/home/jenkins/install-prefix/share/kservicetypes5/plasma-applet.desktop"Found property definition "X-Plasma-API" with type "QString"Found property definition "X-Plasma-RootPath" with type "QString"Found property definition "X-Plasma-MainScript" with type "QString"Found property definition "X-Plasma-ContainmentType" with type "QString"Found property definition "X-Plasma-DropMimeTypes" with type "QStringList"Found property definition "X-Plasma-DropUrlPatterns" with type "QStringList"Found property definition "X-Plasma-NotificationArea" with type "QString"Found property definition "X-Plasma-NotificationAreaCategory" with type "QString"Found property definition "X-Plasma-DBusActivationService" with type "QString"Found property definition "X-KDE-ParentApp" with type "QString"Found property definition "X-Plasma-Provides" with type "QStringList"Found property definition "X-Plasma-ConfigPlugins" with type "QStringList"Found property definition "X-Plasma-StandAloneApp" with type "bool"Found property definition "X-Plasma-RequiredExtensions" with type "QStringList"Found property definition "NoDisplay" with type "bool"Unknown property type for key "X-Plasma-Requires-FileDialog" -> falling back to stringUnknown property type for key "X-Plasma-Requires-LaunchApp" -> falling back to stringGenerated  "/usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/notifier/org.kde.discovernotifier-plasmoids-metadata.json" [  4%] Built target org.kde.discovernotifier-plasmoids-metadata-json[  4%] Built target DiscoverNotifiers_autogenScanning dependencies of target DiscoverNotifiers[  5%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/DiscoverNotifiers_autogen/mocs_compilation.cpp.o[  5%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/BackendNotifierModule.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/libdiscover/notifiers/BackendNotifierModule.cpp:21:In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/libdiscover/notifiers/BackendNotifierModule.h:24:In file included from /usr/local/include/qt5/QtCore/QObject:1:In file included from /usr/local/include/qt5/QtCore/qobject.h:46:In file included from /usr/local/include/qt5/QtCore/qobjectdefs.h:48:In file included from /usr/local/include/qt5/QtCore/qnamespace.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:9:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/libdiscover/notifiers/DiscoverNotifiers_autogen/mocs_compilation.cpp:2:In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/libdiscover/notifiers/DiscoverNotifiers_autogen/EWIEGA46WW/moc_BackendNotifierModule.cpp:9:In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 100 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/100/
 Project:
Plasma discover kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 01:42:45 +
 Build duration:
1 min 4 sec and counting
   CONSOLE OUTPUT
  [...truncated 154.61 KB...]In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/libdiscover/notifiers/BackendNotifierModule.cpp:21:In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/libdiscover/notifiers/BackendNotifierModule.h:24:In file included from /usr/local/include/qt5/QtCore/QObject:1:In file included from /usr/local/include/qt5/QtCore/qobject.h:46:In file included from /usr/local/include/qt5/QtCore/qobjectdefs.h:48:In file included from /usr/local/include/qt5/QtCore/qnamespace.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:10:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/libdiscover/notifiers/DiscoverNotifiers_autogen/mocs_compilation.cpp:2:In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/libdiscover/notifiers/DiscoverNotifiers_autogen/EWIEGA46WW/moc_BackendNotifierModule.cpp:9:In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/libdiscover/notifiers/DiscoverNotifiers_autogen/EWIEGA46WW/../../../../../libdiscover/notifiers/BackendNotifierModule.h:24:In file included from /usr/local/include/qt5/QtCore/QObject:1:In file included from /usr/local/include/qt5/QtCore/qobject.h:46:In file included from /usr/local/include/qt5/QtCore/qobjectdefs.h:48:In file included from /usr/local/include/qt5/QtCore/qnamespace.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:10:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^[  5%] Built target PaginateModelTest_autogen1 error generated.gmake[2]: *** [libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/build.make:87: libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/DiscoverNotifiers_autogen/mocs_compilation.cpp.o] Error 1gmake[2]: *** Waiting for unfinished jobs1 error generated.gmake[2]: *** [libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/build.make:63: libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/BackendNotifierModule.cpp.o] Error 1gmake[1]: *** [CMakeFiles/Makefile2:774: libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/all] Error 2gmake[1]: *** Waiting for unfinished jobsScanning dependencies of target PaginateModelTest[  6%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest.cpp.o[  7%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/PaginateModel.cpp.o[  8%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/__/libdiscover/tests/modeltest.cpp.o[  9%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest_autogen/mocs_compilation.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/discover/autotests/PaginateModelTest.cpp:20:In file included from /usr/local/include/qt5/QtTest/QtTest:3:In file included from /usr/local/include/qt5/QtTest/QtTestDepends:3:In file included from /usr/local/include/qt5/QtCore/QtCore:4:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:10:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/discover/autotests/PaginateModelTest_autogen/mocs_compilation.cpp:2:In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/discover/autotests/PaginateModelTest_autogen/A2TBO422O2/moc_PaginateModel.cpp:9:In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/discover/autotests/PaginateModelTest_autogen/A2TBO422O2/../../../../../discover/PaginateModel.h:23:In file included from /usr/local/include/qt5/QtCore/QAbstractListModel:1:In file included from /usr/local/include/qt5/QtCore/qabstractitemmodel.h:43:In file included from /usr/local/include/qt5/QtCore/qvariant.h:43:In file included from /usr/local/include/qt5/QtCore/qatomic.h:41:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:10:10: fatal error: 

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 99 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/99/
 Project:
Plasma discover kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 01:41:24 +
 Build duration:
1 min 10 sec and counting
   CONSOLE OUTPUT
  [...truncated 154.74 KB...]In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/libdiscover/notifiers/BackendNotifierModule.cpp:21:In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/libdiscover/notifiers/BackendNotifierModule.h:24:In file included from /usr/local/include/qt5/QtCore/QObject:1:In file included from /usr/local/include/qt5/QtCore/qobject.h:46:In file included from /usr/local/include/qt5/QtCore/qobjectdefs.h:48:In file included from /usr/local/include/qt5/QtCore/qnamespace.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:10:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/libdiscover/notifiers/DiscoverNotifiers_autogen/mocs_compilation.cpp:2:In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/libdiscover/notifiers/DiscoverNotifiers_autogen/EWIEGA46WW/moc_BackendNotifierModule.cpp:9:In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/libdiscover/notifiers/DiscoverNotifiers_autogen/EWIEGA46WW/../../../../../libdiscover/notifiers/BackendNotifierModule.h:24:In file included from /usr/local/include/qt5/QtCore/QObject:1:In file included from /usr/local/include/qt5/QtCore/qobject.h:46:In file included from /usr/local/include/qt5/QtCore/qobjectdefs.h:48:In file included from /usr/local/include/qt5/QtCore/qnamespace.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:10:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^[  5%] Built target PaginateModelTest_autogen1 error generated.gmake[2]: *** [libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/build.make:87: libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/DiscoverNotifiers_autogen/mocs_compilation.cpp.o] Error 1gmake[2]: *** Waiting for unfinished jobs1 error generated.gmake[2]: *** [libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/build.make:63: libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/BackendNotifierModule.cpp.o] Error 1gmake[1]: *** [CMakeFiles/Makefile2:774: libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/all] Error 2gmake[1]: *** Waiting for unfinished jobsScanning dependencies of target PaginateModelTest[  6%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest.cpp.o[  8%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest_autogen/mocs_compilation.cpp.o[  8%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/PaginateModel.cpp.o[  9%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/__/libdiscover/tests/modeltest.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/libdiscover/tests/modeltest.cpp:43:In file included from /usr/local/include/qt5/QtGui/QtGui:3:In file included from /usr/local/include/qt5/QtGui/QtGuiDepends:3:In file included from /usr/local/include/qt5/QtCore/QtCore:4:In file included from In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/discover/PaginateModel.cpp:20:In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/discover/PaginateModel.h:23:In file included from /usr/local/include/qt5/QtCore/QAbstractListModel:1:In file included from /usr/local/include/qt5/QtCore/qabstractitemmodel.h:43:In file included from /usr/local/include/qt5/QtCore/qvariant.h:43/usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:In file included from In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/discover/autotests/PaginateModelTest.cpp:/usr/local/include/qt5/QtCore/qconfig-modules.h:10:10: fatal error: /usr/local/include/qt5/QtCore/qatomic.h:41:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:'QtCore/modules/qconfig-multimedia.h' file not found:/usr/local/include/qt5/QtCore/qconfig-modules.h20:In file included from /usr/local/include/qt5/QtTest/QtTest#include  ^::3:In file included from /usr/local/include/qt5/QtTest/QtTestDepends:310:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found:In file included from 

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 98 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/98/
 Project:
Plasma discover kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 15 Jan 2018 01:25:39 +
 Build duration:
1 min 19 sec and counting
   CONSOLE OUTPUT
  [...truncated 134.66 KB...]  For compatibility, CMake is excluding the GENERATED source file(s):"/usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/discover/qrc_resources.cpp""/usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/discover/qrc_assets.cpp"  from processing by AUTOMOC.  If any of the files should be processed, set  CMP0071 to NEW.  If any of the files should not be processed, explicitly  exclude them by setting the source file property SKIP_AUTOMOC:set_property(SOURCE file.h PROPERTY SKIP_AUTOMOC ON)This warning is for project developers.  Use -Wno-dev to suppress it.-- Generating done-- Build files have been written to: /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Plasma discover kf5-qt5 FreeBSDQt5.9] Running shell script+ python3.5 -u ci-tooling/helpers/compile-build.py --product Plasma --project discover --branchGroup kf5-qt5 --platform FreeBSDQt5.9 --usingInstall /usr/home/jenkins/install-prefix/Scanning dependencies of target org.kde.discovernotifier-plasmoids-metadata-jsonScanning dependencies of target PaginateModelTest_autogenScanning dependencies of target DiscoverCommon_autogenScanning dependencies of target DiscoverNotifiers_autogen[  2%] Automatic MOC for target PaginateModelTest[  2%] Generating org.kde.discovernotifier-plasmoids-metadata.json[  3%] Automatic MOC for target DiscoverCommon[  4%] Automatic MOC for target DiscoverNotifiersAbout to parse service type file "/usr/home/jenkins/install-prefix/share/kservicetypes5/plasma-applet.desktop"Found property definition "X-Plasma-API" with type "QString"Found property definition "X-Plasma-RootPath" with type "QString"Found property definition "X-Plasma-MainScript" with type "QString"Found property definition "X-Plasma-ContainmentType" with type "QString"Found property definition "X-Plasma-DropMimeTypes" with type "QStringList"Found property definition "X-Plasma-DropUrlPatterns" with type "QStringList"Found property definition "X-Plasma-NotificationArea" with type "QString"Found property definition "X-Plasma-NotificationAreaCategory" with type "QString"Found property definition "X-Plasma-DBusActivationService" with type "QString"Found property definition "X-KDE-ParentApp" with type "QString"Found property definition "X-Plasma-Provides" with type "QStringList"Found property definition "X-Plasma-ConfigPlugins" with type "QStringList"Found property definition "X-Plasma-StandAloneApp" with type "bool"Found property definition "X-Plasma-RequiredExtensions" with type "QStringList"Found property definition "NoDisplay" with type "bool"Unknown property type for key "X-Plasma-Requires-FileDialog" -> falling back to stringUnknown property type for key "X-Plasma-Requires-LaunchApp" -> falling back to stringGenerated  "/usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/notifier/org.kde.discovernotifier-plasmoids-metadata.json" [  4%] Built target org.kde.discovernotifier-plasmoids-metadata-json[  4%] Built target DiscoverNotifiers_autogenScanning dependencies of target DiscoverNotifiers[  5%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/DiscoverNotifiers_autogen/mocs_compilation.cpp.o[  5%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/BackendNotifierModule.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/libdiscover/notifiers/DiscoverNotifiers_autogen/mocs_compilation.cpp:2:In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/libdiscover/notifiers/DiscoverNotifiers_autogen/EWIEGA46WW/moc_BackendNotifierModule.cpp:9:In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/libdiscover/notifiers/DiscoverNotifiers_autogen/EWIEGA46WW/../../../../../libdiscover/notifiers/BackendNotifierModule.h:24:In file included from /usr/local/include/qt5/QtCore/QObject:1:In file included from /usr/local/include/qt5/QtCore/qobject.h:46:In file included from /usr/local/include/qt5/QtCore/qobjectdefs.h:48:In file included from /usr/local/include/qt5/QtCore/qnamespace.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:9:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/libdiscover/notifiers/BackendNotifierModule.cpp:21:In file included from 

D9868: Rename Discover's "Home" page to "Featured"

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R134 Discover Software Store

BRANCH
  arcpatch-D9868

REVISION DETAIL
  https://phabricator.kde.org/D9868

To: ngraham, apol, #discover_software_store
Cc: ankits, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: KDE and Google Summer of Code 2018

[Valorie Zimmerman]

I'm very discouraged to see so little movement on this. After skipping GCi
this past fall, are we now also considering skipping GSoC? Or downsizing
the number of students we are mentoring?

Without Ideas we will not get students. More important, we must complete
the Org application soon, and the Ideas page is the core of that
application.

This is good for your team and your project, in the long run. It brings in
new contributors and fresh ideas.

If you need some guidance, please read
https://google.github.io/gsocguides/mentor/defining-a-project-ideas-list.html

I should have linked to it for the last email.

Valorie

On Wed, Jan 10, 2018 at 3:03 PM, Valorie Zimmerman <
valorie.zimmer...@gmail.com> wrote:

>
> Hello GSoC mentors, and teams supporting mentors,
>
> TL;DR: Fill out https://community.kde.org/GSoC/2018/Ideas; read
> https://community.kde.org/GSoC. Now.
>
> Every year, we've asked for more time to get ramped up for GSoC, and so
> now is the time for organizations to apply[1]. We have begun to write our
> application, and  that means that our Ideas page needs to be filled NOW,
> because that is the prime consideration for the GSoC team once the Org
> Applications deadline has passed.
>
> The quality of our ideas and the guidance they give our students are the
> most important part of our application. Please begin filling in your ideas
> now if you have not already, and ensure that that page is comprehensive,
> accurate and attractive. Including screenshots and other images is allowed,
> if it enriches the idea for a project. *Please ensure complete information
> about how to contact the team*; this is crucial.
>
> Also, take a look at the landing page https://community.kde.org/GSoC.
> Experienced mentors agree that:
>
> 1. commits must be made before the student proposal is submitted, and
> linked on that proposal, and
>
> 2. that regular communication from the student must be initiated by the
> student at least weekly, and we expect daily or nearly daily communication
> with the team in a more informal way.
>
> Be sure to point students to that information, as this should lower the
> number of proposals, while raising the quality.
>
> 1. https://developers.google.com/open-source/gsoc/timeline
>
> PS: If your team has an Idea, ensure that you have mentors for it, and
> that those mentors are subscribe to KDE-Soc-Mentor list. Remove any ideas
> without mentors available, please. Now, before you forget!
>
> Valorie
>


-- 
http://about.me/valoriez

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Alex Nemeth]

anemeth added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  In https://phabricator.kde.org/D9848#191008, @zzag wrote:
  
  > In https://phabricator.kde.org/D9848#190964, @luebking wrote:
  >
  > > I'm not actually smiling ...
  > >
  > > Anyway, instead of using three vectors it's strongly suggest to use one 
vector (or rather array) of a struct.
  > >  a) you can access the inner values by names
  > >  b) it's far more elegant to define = { {1, 2, 3}, {4, 5, 6}, ...}
  >
  >
  > c) it's way way elegant to calculate required params(like PixiJS does for 
determining kawase kernels 
https://github.com/pixijs/pixi-filters/blob/master/filters/kawase-blur/src/KawaseBlurFilter.js#L84-L100)
  
  
  it's a nice concept but these numbers in question can not be calculated

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin
Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson, 
fredrik, ngraham, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  In https://phabricator.kde.org/D9848#190964, @luebking wrote:
  
  > I'm not actually smiling ...
  >
  > Anyway, instead of using three vectors it's strongly suggest to use one 
vector (or rather array) of a struct.
  >  a) you can access the inner values by names
  >  b) it's far more elegant to define = { {1, 2, 3}, {4, 5, 6}, ...}
  
  
  c) it's way way elegant to calculate required params(like PixiJS does for 
determining kawase kernels 
https://github.com/pixijs/pixi-filters/blob/master/filters/kawase-blur/src/KawaseBlurFilter.js#L84-L100)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin
Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson, 
fredrik, ngraham, plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, 
apol

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Thomas Lübking]

luebking added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  I'm not actually smiling ...
  
  Anyway, instead of using three vectors it's strongly suggest to use one 
vector (or rather array) of a struct.
  a) you can access the inner values by names
  b) it's far more elegant to define = { {1, 2, 3}, {4, 5, 6}, ...}

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin
Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson, 
fredrik, ngraham, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Alex Nemeth]

anemeth added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  In https://phabricator.kde.org/D9848#190676, @romangg wrote:
  
  > In https://phabricator.kde.org/D9848#190644, @anemeth wrote:
  >
  > > .arcconfig is not needed here
  >
  >
  > Your current patch would delete the .arcconfig file from the KWin repo when 
being pushed. Do as @zzag said and check it out from master to your working 
branch.
  
  
  I don't have much experience with arc. Could you please tell me how I undo 
this file deletion?  When I issued `arc diff` I got the following question 
`Ignore this untracked file and continue? [y/N] y`
  I don't think this is enough to undo the delete, or is it?
  
  In https://phabricator.kde.org/D9848#190775, @romangg wrote:
  
  > I'm trying to test this. In Konsole it does not seem to blur anything at 
all. Read something about setting xprop dbus signal to Konsole. Then it was 
blurred but a change of blur strength in the settings didn't change the blur. 
Any tips?
  
  
  Try moving a blurred window after you click Apply or OK.
  
  In https://phabricator.kde.org/D9848#190854, @romangg wrote:
  
  > There are some rendering artifacts, when intermediate rendering results 
shall be saved. To reproduce: put a window with different color to background 
halfway under the sound level indicator when changing volume.
  
  
  I tried this and I don't know what you mean. Could you post a picture or a 
video?
  There may be some 'artifacts' which are not are actually "not a bug, but a 
feature".
  There was an "extended blur" option before I uploaded this whole thing to 
phabricator but I removed it, since it ruined the taskbar completely.
  Maybe re-adding it would eliminate your problem.
  Could you please post a video of your artifact problem?
  
  In https://phabricator.kde.org/D9848#190887, @graesslin wrote:
  
  > In https://phabricator.kde.org/D9848#190882, @broulik wrote:
  >
  > > >   There are some rendering artifacts, when intermediate rendering 
results shall be saved. 
  > >
  > > That feature has shown to be flaky numerous times and is, I think, still 
broken on Wayland multi-screen, so given the supposed better performance of the 
new blur effect I would vote for just removing the render caching altogether.
  >
  >
  > I agree and it reminds me that I wanted to disable the feature on Wayland.
  
  
  Removing the cached blur would mostly affect the taskbar. There are some 
icons on the taskbar that update constantly. For example I'm on Manjaro and the 
little red octopus icon of Octopi is constantly jumping, telling me to update.
  Without caching the whole taskbar would be updated all the time, and not just 
a small portion.
  Although removing caching would make the coding easier, so I'm not that 
against it.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin
Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson, 
fredrik, ngraham, plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, 
apol

D9873: Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account

[Fabian Vogt]

fvogt updated this revision to Diff 25351.
fvogt added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Move the added functions from the class into the xkb.cpp's static scope.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9873?vs=25311=25351

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9873

AFFECTED FILES
  xkb.cpp

To: fvogt, #plasma, graesslin
Cc: kwin, plasma-devel, #kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D9873: Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account

[Fabian Vogt]

fvogt added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  In https://phabricator.kde.org/D9873#190789, @graesslin wrote:
  
  > I wasn't aware of this secure_getenv functionality.
  
  
  Me neither...
  
  > Is that also in place after the process has completely dropped all privs?
  
  Quote from `man 3 secure_getenv`:
  
  > the effective capability bit was set on the executable file
  
  so, yes.

INLINE COMMENTS

> graesslin wrote in xkb.h:121-127
> as both do not operate on anything of the Xkb class I would move them out of 
> the class and put them into an anonymous namespace.

Would just moving them outside of the class as `static` functions within 
xkb.cpp work for you as well?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9873

To: fvogt, #plasma, graesslin
Cc: kwin, plasma-devel, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Kai Uwe Broulik]

broulik added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  > (Or how can I see the previous patch in this messy review tool
  
  Under "Revision Contents" is a "History" tab.
  
  > which draws an entire core when typing...)
  
  :D

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin
Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson, 
fredrik, ngraham, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Thomas Lübking]

luebking added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Why was that a problem?
  (Or how can I see the previous patch in this messy review tool which draws an 
entire core when typing...)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin
Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson, 
fredrik, ngraham, plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, 
apol

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Alex Nemeth]

anemeth marked 6 inline comments as done.
Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin
Cc: broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson, fredrik, 
ngraham, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

KDE CI: Plasma kdeplasma-addons kf5-qt5 FreeBSDQt5.9 - Build # 12 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kdeplasma-addons%20kf5-qt5%20FreeBSDQt5.9/12/
 Project:
Plasma kdeplasma-addons kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 14 Jan 2018 20:30:48 +
 Build duration:
2 min 16 sec and counting
   CONSOLE OUTPUT
  [...truncated 516.85 KB...]In file included from /usr/local/include/qt5/QtCore/qrefcount.h:43:In file included from /usr/local/include/qt5/QtCore/qatomic.h:41:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:10:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^1 error generated.1 error generated.1 error generated.1 error generated.gmake[2]: *** [applets/colorpicker/CMakeFiles/colorpickerplugin.dir/build.make:63: applets/colorpicker/CMakeFiles/colorpickerplugin.dir/plugin/grabwidget.cpp.o] Error 1gmake[2]: *** Waiting for unfinished jobsgmake[2]: *** [applets/fifteenPuzzle/CMakeFiles/fifteenpuzzleplugin.dir/build.make:63: applets/fifteenPuzzle/CMakeFiles/fifteenpuzzleplugin.dir/plugin/fifteenimageprovider.cpp.o] Error 1gmake[2]: *** Waiting for unfinished jobsgmake[2]: *** [libs/plasmaweather/CMakeFiles/plasmaweather.dir/build.make:63: libs/plasmaweather/CMakeFiles/plasmaweather.dir/weatherpopupapplet.cpp.o] Error 1gmake[2]: *** Waiting for unfinished jobs[ 29%] Building CXX object libs/plasmaweather/CMakeFiles/plasmaweather.dir/weathervalidator.cpp.o[ 29%] Building CXX object applets/fifteenPuzzle/CMakeFiles/fifteenpuzzleplugin.dir/plugin/fifteenpuzzleplugin.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma kdeplasma-addons kf5-qt5 FreeBSDQt5.9/libs/plasmaweather/weathervalidator.cpp:20:In file included from /usr/home/jenkins/workspace/Plasma kdeplasma-addons kf5-qt5 FreeBSDQt5.9/libs/plasmaweather/weathervalidator.h:23:In file included from /usr/home/jenkins/install-prefix/include/KF5/Plasma/DataEngine:1:In file included from /usr/home/jenkins/install-prefix/include/KF5/plasma/dataengine.h:23:In file included from /usr/local/include/qt5/QtCore/QHash:1:In file included from /usr/local/include/qt5/QtCore/qhash.h:44:In file included from /usr/local/include/qt5/QtCore/qchar.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:10:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^In file included from /usr/home/jenkins/workspace/Plasma kdeplasma-addons kf5-qt5 FreeBSDQt5.9/applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.cpp:21:In file included from /usr/home/jenkins/workspace/Plasma kdeplasma-addons kf5-qt5 FreeBSDQt5.9/applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.h:25:In file included from /usr/local/include/qt5/QtQml/QQmlEngine:1:In file included from /usr/local/include/qt5/QtQml/qqmlengine.h:43:In file included from /usr/local/include/qt5/QtCore/qurl.h:44:In file included from /usr/local/include/qt5/QtCore/qbytearray.h:44:In file included from /usr/local/include/qt5/QtCore/qrefcount.h:43:In file included from /usr/local/include/qt5/QtCore/qatomic.h:41:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:10:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^Scanning dependencies of target notesplugin[ 29%] Building CXX object applets/notes/CMakeFiles/notesplugin.dir/plugin/abstractnoteloader.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma kdeplasma-addons kf5-qt5 FreeBSDQt5.9/applets/notes/plugin/abstractnoteloader.cpp:22:In file included from /usr/local/include/qt5/QtCore/QString:1:In file included from /usr/local/include/qt5/QtCore/qstring.h:48:In file included from /usr/local/include/qt5/QtCore/qchar.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:10:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^1 error generated.gmake[2]: *** [applets/notes/CMakeFiles/notesplugin.dir/build.make:63: applets/notes/CMakeFiles/notesplugin.dir/plugin/abstractnoteloader.cpp.o] Error 1gmake[1]: *** [CMakeFiles/Makefile2:1929: applets/notes/CMakeFiles/notesplugin.dir/all] Error 2gmake[1]: *** Waiting for unfinished jobsgmake[2]: *** [applets/mediaframe/CMakeFiles/mediaframeplugin.dir/build.make:63: applets/mediaframe/CMakeFiles/mediaframeplugin.dir/plugin/mediaframe.cpp.o] Error 1gmake[2]: *** Waiting for unfinished jobs[ 30%] Building CXX object applets/mediaframe/CMakeFiles/mediaframeplugin.dir/plugin/mediaframeplugin.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma kdeplasma-addons kf5-qt5 

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Alex Nemeth]

anemeth updated this revision to Diff 25350.
anemeth added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Reverted the change of putting the blur strength configuration into a vector, 
because it resulted in some complications.
  Doing it with the huge switch case might be unpleasent for the eyes but it 
does not require more unnecessary variables and
  (in my opinion) is cleaner and more maintainable this way.
  
  I strongly disagree with the intent to remove these magic numbers and let the 
user only change the offset or the iteration number.
  There aren't enough strength steps between the steps if we make one of these 
values constant.
  If we do this we remove a big part of customization and KDE is all about 
customization.
  Those 15 set of magic number numbers is the only price we have to pay for the 
customization.
  
  Said that, if the core members of Plasma or KWin decide/vote to make the 
offset constant and let the user only change
  between the 4 or 5 iteration number to make the code a bit leaner at the cost 
of customization then I will not be against the decision.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9848?vs=25305=25350

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9848

AFFECTED FILES
  .arcconfig
  effects/blur/blur.cpp
  effects/blur/blur.h
  effects/blur/blur.kcfg
  effects/blur/blur_config.ui
  effects/blur/blurshader.cpp
  effects/blur/blurshader.h

To: anemeth, #plasma, #kwin
Cc: broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson, fredrik, 
ngraham, plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol

D9868: Rename Discover's "Home" page to "Featured"

[Nathaniel Graham]

ngraham updated this revision to Diff 25349.
ngraham added a comment.


  "Featured Apps" -> "Featured"

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9868?vs=25293=25349

BRANCH
  arcpatch-D9868

REVISION DETAIL
  https://phabricator.kde.org/D9868

AFFECTED FILES
  discover/qml/BrowsingPage.qml

To: ngraham, apol, #discover_software_store
Cc: ankits, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9872: [weather] Show optionally temperature next to icon in compact mode

[Friedrich W . H . Kossebau]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:ad04c42b28d1: [weather] Show optionally temperature next 
to icon in compact mode (authored by kossebau).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9872?vs=25326=25348

REVISION DETAIL
  https://phabricator.kde.org/D9872

AFFECTED FILES
  applets/weather/package/contents/config/config.qml
  applets/weather/package/contents/ui/CompactRepresentation.qml
  applets/weather/package/contents/ui/IconAndTextItem.qml
  applets/weather/package/contents/ui/configAppearance.qml
  applets/weather/weatherapplet.cpp
  applets/weather/weatherapplet.h

To: kossebau, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9868: Rename Discover's "Home" page to "Featured"

[Nathaniel Graham]

ngraham retitled this revision from "Rename Discover's "Home" page to "Featured 
apps"" to "Rename Discover's "Home" page to "Featured"".
ngraham edited the test plan for this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D9868

To: ngraham, apol, #discover_software_store
Cc: ankits, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 97 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/97/
 Project:
Plasma discover kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 14 Jan 2018 20:25:33 +
 Build duration:
3 min 16 sec and counting
   CONSOLE OUTPUT
  [...truncated 156.12 KB...]In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/libdiscover/notifiers/BackendNotifierModule.cpp:21:In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/libdiscover/notifiers/BackendNotifierModule.h:24:In file included from /usr/local/include/qt5/QtCore/QObject:1:In file included from /usr/local/include/qt5/QtCore/qobject.h:46:In file included from /usr/local/include/qt5/QtCore/qobjectdefs.h:48:In file included from /usr/local/include/qt5/QtCore/qnamespace.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:9:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/libdiscover/notifiers/DiscoverNotifiers_autogen/mocs_compilation.cpp:2:In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/libdiscover/notifiers/DiscoverNotifiers_autogen/EWIEGA46WW/moc_BackendNotifierModule.cpp:9:In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/libdiscover/notifiers/DiscoverNotifiers_autogen/EWIEGA46WW/../../../../../libdiscover/notifiers/BackendNotifierModule.h:24:In file included from /usr/local/include/qt5/QtCore/QObject:1:In file included from /usr/local/include/qt5/QtCore/qobject.h:46:In file included from /usr/local/include/qt5/QtCore/qobjectdefs.h:48:In file included from /usr/local/include/qt5/QtCore/qnamespace.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:9:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^[  5%] Built target PaginateModelTest_autogenScanning dependencies of target PaginateModelTest[  6%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest.cpp.o[  7%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/__/libdiscover/tests/modeltest.cpp.o[  8%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/PaginateModel.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/discover/autotests/PaginateModelTest.cpp:20:In file included from /usr/local/include/qt5/QtTest/QtTest:3:In file included from /usr/local/include/qt5/QtTest/QtTestDepends:3:In file included from /usr/local/include/qt5/QtCore/QtCore:4:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:9:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/libdiscover/tests/modeltest.cpp:43:In file included from /usr/local/include/qt5/QtGui/QtGui:3:In file included from /usr/local/include/qt5/QtGui/QtGuiDepends:3:In file included from /usr/local/include/qt5/QtCore/QtCore:4:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:9:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/discover/PaginateModel.cpp:20:In file included from /usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/discover/PaginateModel.h:23:In file included from /usr/local/include/qt5/QtCore/QAbstractListModel:1:In file included from /usr/local/include/qt5/QtCore/qabstractitemmodel.h:43:In file included from /usr/local/include/qt5/QtCore/qvariant.h:43:In file included from /usr/local/include/qt5/QtCore/qatomic.h:41:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:9:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^1 error generated.gmake[2]: *** [libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/build.make:87: libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/DiscoverNotifiers_autogen/mocs_compilation.cpp.o] Error 1gmake[2]: *** Waiting for unfinished jobs1 error generated.[  9%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest_autogen/mocs_compilation.cpp.ogmake[2]: *** 

D9850: Remove redundant changeLog field

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:fad964d9a0b9: Remove redundant changeLog field (authored 
by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9850?vs=25292=25347

REVISION DETAIL
  https://phabricator.kde.org/D9850

AFFECTED FILES
  libdiscover/backends/PackageKitBackend/PackageKitResource.cpp

To: ngraham, apol, #discover_software_store
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9868: Rename Discover's "Home" page to "Featured apps"

[Aleix Pol Gonzalez]

apol added a comment.


  Okay, makes sense. Can you leave it at just "Featured"?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D9868

To: ngraham, apol, #discover_software_store
Cc: ankits, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9879: [effects/blur] Disable texture cache on Wayland

[Thomas Lübking]

luebking added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  On a general note, UI-wise: if there's no way to ever enable an item it 
should not be shown anyway.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9879

To: graesslin, #kwin, #plasma
Cc: luebking, broulik, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D9879: [effects/blur] Disable texture cache on Wayland

[Martin Flöser]

graesslin updated this revision to Diff 25345.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  Hide option instead of disable it

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9879?vs=25343=25345

BRANCH
  blur-no-cache-wayland

REVISION DETAIL
  https://phabricator.kde.org/D9879

AFFECTED FILES
  effects/blur/CMakeLists.txt
  effects/blur/blur.cpp
  effects/blur/blur_config.cpp

To: graesslin, #kwin, #plasma
Cc: broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9874: Fix executable name in README

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D9874

To: pali, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9850: Remove redundant changeLog field

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  On ArchLinux the changelog field is empty/unused.

REPOSITORY
  R134 Discover Software Store

BRANCH
  arcpatch-D9850

REVISION DETAIL
  https://phabricator.kde.org/D9850

To: ngraham, apol, #discover_software_store
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9879: [effects/blur] Disable texture cache on Wayland

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  In https://phabricator.kde.org/D9879#190916, @graesslin wrote:
  
  > Also disable the cache blur checkbox on Wayland
  
  
  ah no, that's a stupid idea. The load call enables it again. I'll hide it.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9879

To: graesslin, #kwin, #plasma
Cc: broulik, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D9879: [effects/blur] Disable texture cache on Wayland

[Martin Flöser]

graesslin updated this revision to Diff 25343.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  Also disable the cache blur checkbox on Wayland

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9879?vs=25342=25343

BRANCH
  blur-no-cache-wayland

REVISION DETAIL
  https://phabricator.kde.org/D9879

AFFECTED FILES
  effects/blur/CMakeLists.txt
  effects/blur/blur.cpp
  effects/blur/blur_config.cpp

To: graesslin, #kwin, #plasma
Cc: broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9868: Rename Discover's "Home" page to "Featured apps"

[Nathaniel Graham]

ngraham added a comment.


  Sure, we could do Applications instead of Apps.
  
  The problem with "Home" as well as "Discover" is that is conveys no 
information about what its content is. Users want to know: "What am I seeing 
here?" They're seeing a list of featured/curated apps, but they don't know that 
unless we communicate it to them. "Featured Apps/Applications" communicates 
that; "Home" or "Discover" doesn't.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D9868

To: ngraham, apol, #discover_software_store
Cc: ankits, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9868: Rename Discover's "Home" page to "Featured apps"

[Aleix Pol Gonzalez]

apol added a comment.


  Why "Apps"?
  How about we change it to "Discover" instead of "Home"?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D9868

To: ngraham, apol, #discover_software_store
Cc: ankits, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9879: [effects/blur] Disable texture cache on Wayland

[Kai Uwe Broulik]

broulik added inline comments.
Restricted Application edited projects, added KWin; removed Plasma.

INLINE COMMENTS

> blur_config.cpp:42
> +if (KWindowSystem::isPlatformWayland()) {
> +ui.kcfg_CacheTexture->setEnabled(false);
> +}

Shouldn't it hide or at least disable the check box?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9879

To: graesslin, #kwin, #plasma
Cc: broulik, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D9872: [weather] Show optionally temperature next to icon in compact mode

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Given the feature freeze tomorrow, this being a non-critical feature at the 
outer spheres of plasma, the feature itself making sense surely, and being the 
de-facto maintainer of the weather applet code, I decided to just push this 
now. I have had run most of the code for at least a week and tested the current 
code with lots of setups during the day, so rather confident its proper.
  
  Still would like some post-push review of the (QML) code, given I am still a 
newbie when it comes to QML/QtQuick.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D9872

To: kossebau, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Anthony Fieroni]

anthonyfieroni added inline comments.
Restricted Application edited projects, added KWin; removed Plasma.

INLINE COMMENTS

> blur.cpp:94
>  delete shader;
> -delete target;
> +shader = NULL;
> +

m_simpleTarget should be deleted too

> blur.cpp:96-104
> +for (int i = 0; i < renderTargets.size(); i++) {
> +delete renderTargets[i];
> +renderTargets[i] = NULL;
> +
> +renderTextures[i].discard();
> +}
> +

Make a function that clears them.

> blur.cpp:117
>  
> -void BlurEffect::updateTexture() {
> -delete target;
> -// Offscreen texture that's used as the target for the horizontal blur 
> pass
> -// and the source for the vertical pass.
> -tex = GLTexture(GL_RGBA8, effects->virtualScreenSize());
> -tex.setFilter(GL_LINEAR);
> -tex.setWrapMode(GL_CLAMP_TO_EDGE);
> +bool BlurEffect::renderTargetsValid()
> +{

Make it const.

> blur.cpp:119-129
> +if (renderTargets.isEmpty()) {
> +return false;
> +}
> +
> +for (int i = 0; i < renderTargets.size(); i++) {
> +if (!renderTargets[i]->valid()) {
> +return false;

You can minimize it

  return !renderTargets.isEmpty() 
&& std::find_if(renderTargets.cbegin(), renderTargets.cend(), [](const 
GLRenderTarget *target) {
 return !target->valid(); }) == 
renderTarget.cend();

> blur.cpp:180-188
> +for (int i = 0; i < renderTargets.size(); i++) {
> +delete renderTargets[i];
> +renderTargets[i] = NULL;
> +
> +renderTextures[i].discard();
> +}
> +

Use same function from above.

> blur.cpp:670-724
> +shader->bind(BlurShader::copySampleType);
> +
> +shader->setModelViewProjectionMatrix(screenProjection);
> +shader->setTextureSize(screen.size());
> +shader->setBlurRect(shape.boundingRect().adjusted(BORDER_SIZE, 
> BORDER_SIZE, -BORDER_SIZE, -BORDER_SIZE), screen.size());
> +
> +GLRenderTarget::pushRenderTarget(renderTargets[0]);

Make a 3 function copySampleType, downSampleType, upSampleType with needed 
parameters. Call them here and in doCachedBlur

> blur.h:83
>  QRegion blurRegion(const EffectWindow *w) const;
> -bool shouldBlur(const EffectWindow *w, int mask, const WindowPaintData 
> ) const;
> +bool shouldBlur(const EffectWindow *w, int mask, const WindowPaintData 
> );
>  void updateBlurRegion(EffectWindow *w) const;

Still can be const.

> blurshader.cpp:232-239
>  if (gles) {
>  if (core) {
> -stream << "#version 300 es\n\n";
> +streamVert << "#version 300 es\n\n";
>  }
> -stream << "precision highp float;\n";
> +
> +streamVert << "precision highp float;\n";
>  } else if (glsl_140) {

QString glHeaderString;
  if (gles) {
  if (core) {
  glHeaderString += "#version 300 es\n\n";
  }
  glHeaderString += "precision highp float;\n";
  } else if (glsl_140) {
  glHeaderString += "#version 140\n\n";
  }
  streamVert << glHeaderString;

> blurshader.cpp:256-264
> +if (gles) {
> +if (core) {
> +streamFragDown << "#version 300 es\n\n";
> +}
> +
> +streamFragDown << "precision highp float;\n";
> +} else if (glsl_140) {

streamFragDown << glHeaderString;

> blurshader.cpp:266-271
> +streamFragDown << "uniform sampler2D texUnit;\n";
> +streamFragDown << "uniform float offset;\n";
> +streamFragDown << "uniform vec2 textureSize;\n";
> +
> +if (core)
> +streamFragDown << "out vec4 fragColor;\n\n";

QString glUniformString = "uniform sampler2D texUnit;\n"
"uniform float offset;\n"
"uniform vec2 textureSize;\n";
  if (core) {
  glUniformString += "out vec4 fragColor;\n\n";
  }
  streamFragDown << glUniformString;

> blurshader.cpp:293-308
>  if (gles) {
>  if (core) {
> -stream2 << "#version 300 es\n\n";
> +streamFragUp << "#version 300 es\n\n";
>  }
> -stream2 << "precision highp float;\n";
> +
> +streamFragUp << "precision highp float;\n";
>  } else if (glsl_140) {

streamFragUp << glHeaderString << glUniformString;

> blurshader.cpp:333-348
> +if (gles) {
> +if (core) {
> +streamFragCopy << "#version 300 es\n\n";
> +}
> +
> +streamFragCopy << "precision highp float;\n";
> +} else if (glsl_140) {

streamFragCopy << glHeaderString << glUniformString;

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin
Cc: anthonyfieroni, mart, davidedmundson, fredrik, ngraham, plasma-devel, kwin, 
#kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol

D9879: [effects/blur] Disable texture cache on Wayland

[Martin Flöser]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
graesslin requested review of this revision.
Restricted Application edited projects, added Plasma; removed KWin.

REVISION SUMMARY
  It is known to create problems especially on multi-screen and is not as
  important on Wayland as it used to be on X11 thanks to things like
  buffer age and in general better rendering.

TEST PLAN
  Opened the config module and verified that the option is disabled

REPOSITORY
  R108 KWin

BRANCH
  blur-no-cache-wayland

REVISION DETAIL
  https://phabricator.kde.org/D9879

AFFECTED FILES
  effects/blur/CMakeLists.txt
  effects/blur/blur.cpp
  effects/blur/blur_config.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  In https://phabricator.kde.org/D9848#190882, @broulik wrote:
  
  > >   There are some rendering artifacts, when intermediate rendering results 
shall be saved. 
  >
  > That feature has shown to be flaky numerous times and is, I think, still 
broken on Wayland multi-screen, so given the supposed better performance of the 
new blur effect I would vote for just removing the render caching altogether.
  
  
  I agree and it reminds me that I wanted to disable the feature on Wayland.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin
Cc: broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson, fredrik, 
ngraham, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Kai Uwe Broulik]

broulik added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  >   There are some rendering artifacts, when intermediate rendering results 
shall be saved. 
  
  That feature has shown to be flaky numerous times and is, I think, still 
broken on Wayland multi-screen, so given the supposed better performance of the 
new blur effect I would vote for just removing the render caching altogether.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin
Cc: broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson, fredrik, 
ngraham, plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol

KDE CI: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 - Build # 60 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.9/60/
 Project:
Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 14 Jan 2018 18:22:48 +
 Build duration:
2 min 41 sec and counting
   CONSOLE OUTPUT
  [...truncated 810.73 KB...][ 11%] Building CXX object libkworkspace/CMakeFiles/kworkspace.dir/kworkspace.cpp.o1 error generated.gmake[2]: *** [libkworkspace/CMakeFiles/kworkspace.dir/build.make:85: libkworkspace/CMakeFiles/kworkspace.dir/kdisplaymanager.cpp.o] Error 1gmake[2]: *** Waiting for unfinished jobsgmake[2]: *** [libdbusmenuqt/test/CMakeFiles/appmenutest.dir/build.make:63: libdbusmenuqt/test/CMakeFiles/appmenutest.dir/main.cpp.o] Error 1gmake[2]: *** Waiting for unfinished jobs[ 11%] Building CXX object components/shellprivate/CMakeFiles/plasmashellprivateplugin.dir/widgetexplorer/openwidgetassistant.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/libcolorcorrect/geolocator.cpp:17:In file included from /usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/libcolorcorrect/geolocator.h:22:In file included from /usr/home/jenkins/install-prefix/include/KF5/Plasma/DataEngine:1:In file included from /usr/home/jenkins/install-prefix/include/KF5/plasma/dataengine.h:23:In file included from /usr/local/include/qt5/QtCore/QHash:1:In file included from /usr/local/include/qt5/QtCore/qhash.h:44:In file included from /usr/local/include/qt5/QtCore/qchar.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:10:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^[ 11%] Building CXX object libdbusmenuqt/test/CMakeFiles/appmenutest.dir/appmenutest_autogen/mocs_compilation.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/components/shellprivate/widgetexplorer/openwidgetassistant.cpp:20:In file included from /usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/components/shellprivate/widgetexplorer/openwidgetassistant_p.h:23:In file included from /usr/home/jenkins/install-prefix/include/KF5/KWidgetsAddons/KAssistantDialog:1:In file included from /usr/home/jenkins/install-prefix/include/KF5/KWidgetsAddons/kassistantdialog.h:22:In file included from /usr/home/jenkins/install-prefix/include/KF5/KWidgetsAddons/kpagedialog.h:28:In file included from /usr/local/include/qt5/QtWidgets/QDialog:1:In file included from /usr/local/include/qt5/QtWidgets/qdialog.h:43:In file included from /usr/local/include/qt5/QtWidgets/qtwidgetsglobal.h:43:In file included from /usr/local/include/qt5/QtGui/qtguiglobal.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:10:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^gmake[1]: *** [CMakeFiles/Makefile2:573: libdbusmenuqt/test/CMakeFiles/appmenutest.dir/all] Error 2In file included from /usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/libkworkspace/kworkspace.cpp:23:In file included from /usr/local/include/qt5/QtCore/QDataStream:1:In file included from /usr/local/include/qt5/QtCore/qdatastream.h:43:In file included from /usr/local/include/qt5/QtCore/qscopedpointer.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:10:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^[ 11%] Building CXX object components/shellprivate/CMakeFiles/plasmashellprivateplugin.dir/widgetexplorer/widgetexplorer.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/components/shellprivate/widgetexplorer/widgetexplorer.cpp:22:In file included from /usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/components/shellprivate/widgetexplorer/widgetexplorer.h:26:In file included from /usr/local/include/qt5/QtWidgets/QAction:1:In file included from /usr/local/include/qt5/QtWidgets/qaction.h:43:In file included from /usr/local/include/qt5/QtWidgets/qtwidgetsglobal.h:43:In file included from /usr/local/include/qt5/QtGui/qtguiglobal.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:10:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^1 error generated.gmake[2]: *** [libcolorcorrect/CMakeFiles/colorcorrect.dir/build.make:87: libcolorcorrect/CMakeFiles/colorcorrect.dir/geolocator.cpp.o] Error 1gmake[1]: *** 

D9878: [Notifications] Keep notification popup open when covered by fullscreen window

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein, graesslin, VDG.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Notifications do not show up on top of full screen windows to avoid them 
showing over e.g. a presentation.
  To keep you from missing anything that's been going on, keep the popup open 
until the full screen window goes away.
  There will be at most three popups shown at once, as has always been the 
case, and they would then cycle through.
  I chose to just keep the popups open rather than using the glowing 
notification icon as in the original patch for simplicity and to not introduce 
yet another "history" of notifications (persistent + the "history" + fullscreen 
missed ones).
  While at it simplify the "should notification close" handling by binding all 
conditions to a single binding

TEST PLAN
  This basically resurrects https://git.reviewboard.kde.org/r/121010/ but makes 
use of the new libtaskmanager that should also work on Wayland and reduces 
roundtrips as the task manager applet is present anyway and we're sharing the 
backend
  
  - Verified that making a window full screen stops notification timer for all 
notifications
  - Verified that minimizing that window restarts the timer
  - Verified that switching virtual desktops restarts the timer if the window 
isnt on the new desktop
  - Verified that switching activities restarts the timer if the window isnt on 
the new activity, stopping an activity that causes a window to get moved to the 
current one isn't detected but that looks like a libTM bug
  - Verified that hovering a notification still stops that particular 
notification from disappearing
  - Verified that dragging a screenshot off a notification still stops that 
particular notification from disappearing
  - Didn't actually test multi screen but it's just using the same libtm 
filtering logic per screen there

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9878

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/notifications/package/contents/ui/Notifications.qml

To: broulik, #plasma, hein, graesslin, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Roman Gilg]

romangg added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  It works on my main PC. There are some rendering artifacts, when intermediate 
rendering results shall be saved. To reproduce: put a window with different 
color to background halfway under the sound level indicator when changing 
volume.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin
Cc: romangg, zzag, anthonyfieroni, mart, davidedmundson, fredrik, ngraham, 
plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D9792: even slimmer scrollbars

[Hugo Pereira Da Costa]

hpereiradacosta added inline comments.

INLINE COMMENTS

> breezestyle.cpp:5016
> +// in case this QStyle is used by QQuickControls QStyle wrapper
> +else if( option->styleObject ) widgetMouseOver = 
> option->styleObject->property("hover").toBool();
> +

Ok. Just checked: this whole code should still work if replaced by:

  const bool widgetMouseOver( _animations->scrollBarEngine().isHovered( widget, 
QStyle::SC_ScrollBarGroove ) );

(used elsewhere also)
it relies on the fact that hover state is properly updated, which seems to be 
the case, at least with QWidget.
Can you double check with QtQuick ? If yes, that would be a nice replacement.

REPOSITORY
  R31 Breeze

BRANCH
  arcpatch-D9792

REVISION DETAIL
  https://phabricator.kde.org/D9792

To: mart, #plasma, #kirigami, #vdg, hpereiradacosta, abetts
Cc: ngraham, colomar, abetts, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, davidedmundson, mart, hein

Re: Review Request 121010: Keep track of notifications that were covered by a fullscreen window

[Kai Uwe Broulik]

> On Nov. 6, 2014, 12:12 nachm., Martin Flöser wrote:
> > applets/notifications/plugin/notificationshelper.cpp
> > Lines 169-173 (patched)
> > 
> >
> > note: this code causes roundtrips to the X server. At the same time 
> > it's information already known to the plasmashell process: tasks dataengine.
> > 
> > It might be worth to have a look at it, whether this could be used 
> > instead.
> 
> Kai Uwe Broulik wrote:
> Thanks for the suggestion! I already wondered this call might be heavy.
> 
> So, connecting to the tasks dataengine, iterating over all tasks and 
> checking whether active and fullScreen is true should work.
> 
> Eike Hein wrote:
> Only when the tasks dataengine is being used though - keep in mind the 
> Task Manager applet doesn't use it. A standard user session doesn't have the 
> data engine loaded. It might still be the right thing to avoid redundancy, 
> but not sure what the best common case tradeoff is.
> 
> Martin Flöser wrote:
> thanks Eike, that's a good point. Is there something which could be 
> shared from libtaskmanager?

With new libtaskmanager and its clean QML imports we could finally do this. 
Pager is using it just fine, so we might as well do the same in notifications. 
Bonus points: will work on Wayland.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121010/#review69935
---


On Feb. 8, 2017, 11:35 vorm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121010/
> ---
> 
> (Updated Feb. 8, 2017, 11:35 vorm.)
> 
> 
> Review request for Plasma, KDE Usability and Martin Flöser.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This patch improves fullscreen handling in notifications.
> 
> The type of the NotificationPopup is changed to Dialog.Notification because 
> that's what it's for, I think there's been a bit of a miscommunication about 
> that (I think there needs to be another layer for the OSD because that one 
> should be above all..).
> The Notification type keeps the window above (sorta fixing Bug 338946 because 
> the close button now works as expected now) everything but not a fullscreen 
> window if it's active. This patch checks when a notification arrives whether 
> the active window is fullscreen (concealing the notification) and adds it to 
> the history. To indicate that you missed notifications while you were 
> fullscreen, the icon glows blue (until you interact with a notification or 
> open the plasmoid).
> 
> 
> Diffs
> -
> 
>   applets/notifications/package/contents/ui/NotificationIcon.qml 1449c19 
>   applets/notifications/package/contents/ui/NotificationPopup.qml 212f1e6 
>   applets/notifications/package/contents/ui/Notifications.qml acdccdd 
>   applets/notifications/package/contents/ui/main.qml 3c2fa13 
>   applets/notifications/plugin/notificationshelper.h af8f6fa 
>   applets/notifications/plugin/notificationshelper.cpp 425f0d6 
> 
> 
> Diff: https://git.reviewboard.kde.org/r/121010/diff/1/
> 
> 
> Testing
> ---
> 
> Fullscreened my IDE, "sleep 2; knotificationdbustest", waited, 
> unfullscreened, icon was blue and the history a few notifications in it.
> 
> 
> File Attachments
> 
> 
> Pending notification in tray
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/11/06/3f2141b2-1452-4e5c-8b00-782c571ad34b__notificationpendingthing.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

D9803: Apply some C++11 niceties, styling consistency

[Oleg Chernovskiy]

Kanedias closed this revision.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D9803

To: Kanedias, mart
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D9872: [weather] Show optionally temperature next to icon in compact mode

[Friedrich W . H . Kossebau]

kossebau updated this revision to Diff 25326.
kossebau added a comment.


  Align label text size twisting more with the one of fuzzyclock

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9872?vs=25307=25326

BRANCH
  addWeatherAppletOptionForTemperatureInCompactMode

REVISION DETAIL
  https://phabricator.kde.org/D9872

AFFECTED FILES
  applets/weather/package/contents/config/config.qml
  applets/weather/package/contents/ui/CompactRepresentation.qml
  applets/weather/package/contents/ui/IconAndTextItem.qml
  applets/weather/package/contents/ui/configAppearance.qml
  applets/weather/weatherapplet.cpp
  applets/weather/weatherapplet.h

To: kossebau, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9803: Apply some C++11 niceties, styling consistency

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  c++11

REVISION DETAIL
  https://phabricator.kde.org/D9803

To: Kanedias, mart
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D9792: even slimmer scrollbars

[Thomas Pfeiffer]

colomar added a comment.


  Dunno why I only noticed it now, but of course then this is not the right 
place to fix it. Sorry for the noise.

REPOSITORY
  R31 Breeze

BRANCH
  arcpatch-D9792

REVISION DETAIL
  https://phabricator.kde.org/D9792

To: mart, #plasma, #kirigami, #vdg, hpereiradacosta, abetts
Cc: ngraham, colomar, abetts, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, davidedmundson, mart, hein

D9873: Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  I wasn't aware of this secure_getenv functionality. Is that also in place 
after the process has completely dropped all privs?

INLINE COMMENTS

> xkb.h:121-127
> +static bool stringIsEmptyOrNull(const char *str);
> +/**
> + * libxkbcommon uses secure_getenv to read the XKB_DEFAULT_* variables.
> + * As kwin_wayland may have the CAP_SET_NICE capability, it returns 
> nullptr
> + * so we need to do it ourselves (see xkb_context_sanitize_rule_names).
> + **/
> +static void applyEnvironmentRules(xkb_rule_names );

as both do not operate on anything of the Xkb class I would move them out of 
the class and put them into an anonymous namespace.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9873

To: fvogt, #plasma, graesslin
Cc: kwin, plasma-devel, #kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  In https://phabricator.kde.org/D9848#190775, @romangg wrote:
  
  > I'm trying to test this. In Konsole it does not seem to blur anything at 
all. Read something about setting xprop dbus signal to Konsole. Then it was 
blurred but a change of blur strength in the settings didn't change the blur. 
Any tips?
  
  
  https://www.reddit.com/r/kde/comments/6jzuwu/konsole_and_yakuake_blur/

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin
Cc: romangg, zzag, anthonyfieroni, mart, davidedmundson, fredrik, ngraham, 
plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Roman Gilg]

romangg added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  I'm trying to test this. In Konsole it does not seem to blur anything at all. 
Read something about setting xprop dbus signal to Konsole. Then it was blurred 
but a change of blur strength in the settings didn't change the blur. Any tips?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin
Cc: romangg, zzag, anthonyfieroni, mart, davidedmundson, fredrik, ngraham, 
plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D9876: Add support for apply initial shortcut window rule

[Martin Flöser]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
graesslin requested review of this revision.
Restricted Application edited projects, added Plasma; removed KWin.

REVISION SUMMARY
  Implements the shortcut window rule for ShellClient.

REPOSITORY
  R108 KWin

BRANCH
  shell-client-shortcut-rule

REVISION DETAIL
  https://phabricator.kde.org/D9876

AFFECTED FILES
  autotests/integration/shell_client_rules_test.cpp
  shell_client.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Roman Gilg]

romangg added inline comments.
Restricted Application edited projects, added KWin; removed Plasma.

INLINE COMMENTS

> blur.cpp:35
>  
> +#define BORDER_SIZE 5
> +

`static const` and in the KWin namespace please. Also camel case then.

> blur.cpp:139
> + *
> + * The texture blur amount is depends on the downsampling iterations and 
> the offset value.
> + * By changing the offset we can alter the blur amount without relying 
> on further downsampling.

The texture blur amount depends

> blur.cpp:152
> + * have good minimum and maximum blur amount, but there would be around 
> only 5 blur strength
> + * steps.
> + * This means we can't have constant offset value.

I think 5 blur strength steps to select from is fine, if that means we can get 
rid off the magic numbers. Other opinions?

> blur.cpp:180
> +m_blurConfigData.append({4, 7, 170});
> +m_blurConfigData.append({4, 8, 200});
> +}

All this data is constant, so it doesn't make sense to reinitialize it on every 
Blur instantiation and it is only a helper for reconfigure. Maybe instead as 
static const in the file?

See here how to do it for a QVector: 
https://forum.qt.io/topic/32353/solved-creating-a-const-qvector-with-values

> blur.cpp:212
> +
> +int blurStrength = BlurConfig::blurStrength();
> +m_downSampleIterations = 
> m_blurConfigData[blurStrength].downSampleIterations;

You need to guard against out of bounds values.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin
Cc: romangg, zzag, anthonyfieroni, mart, davidedmundson, fredrik, ngraham, 
plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol

D9275: fix RTL appearance for ComboBox

[Safa Alfulaij]

safaalfulaij added inline comments.

INLINE COMMENTS

> ComboBox.qml:113
>  highlightMoveDuration: 0
> +LayoutMirroring.enabled: true
> +LayoutMirroring.childrenInherit: true

So it is true even for LTR locales?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, mart, plasma-devel, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D9275: fix RTL appearance for ComboBox

[Safa Alfulaij]

safaalfulaij added a comment.


  In https://phabricator.kde.org/D9275#190606, @mvourlakos wrote:
  
  > To test it in Latte I added in the head of 
/shell/package/contents/configuration/AppearanceConfig.qml
  >
  >   import org.kde.plasma.components 3.0 as PlasmaComponents3
  >
  >
  > and I set up the ComboBox in that file to:
  >
  >   PlasmaComponents3.ComboBox
  >
  >
  >
  >
  > > But I can't understand how changing this V3 solved V2..
  >
  > V2 components are based totally at Qt Styles, V3 are reimplementing the 
behavior
  >  PlasmaComponents2.ComboBox is a ComboBoxStyle  but
  >  PlasmaComponents3.ComboBox is a real ComboBox
  
  
  Did you test this with your LTR layout with only `--reverse`?
  I can say now that the popup box (that is a `Popup`) takes its direction from 
the locale used and not from the application, since it doesn't inhert `Item`, 
and `LayoutMirroring` doesn't affect it
  
  It is similar to this  issue 
with the `Slider`.
  I'll add more info to that soon.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, mart, plasma-devel, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D9875: Extend parsing ssh prompt

[Pali Rohár]

pali created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
pali requested review of this revision.

REVISION SUMMARY
  - Add support for yes/no questions from ssh-agent and openssh client
  - Add support for more openssh client prompt lines
  - Better support for parsing git credential strings
  
  I wrote this patch 5 years ago and sent it to Armin Berres, current
  maintainer in that year. Seems it was never applied. Now I ported it for
  the last ksshaskpass version.

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D9875

AFFECTED FILES
  src/main.cpp

To: pali
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9874: Fix executable name in README

[Pali Rohár]

pali created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
pali requested review of this revision.

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D9874

AFFECTED FILES
  README

To: pali
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9873: Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account

[Fabian Vogt]

fvogt created this revision.
fvogt added reviewers: Plasma, graesslin.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin.
fvogt requested review of this revision.
Restricted Application edited projects, added Plasma; removed KWin.

REVISION SUMMARY
  As kwin_wayland can have the CAP_SYS_NICE capability, libxkbcommon does not
  read environment variables (see secure_getenv).
  So process them here, in the same way xkb_context_sanitize_rule_names would.
  
  BUG: 388249

TEST PLAN
  kwin_wayland has the capability set, keyboard layout is applied correctly.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9873

AFFECTED FILES
  xkb.cpp
  xkb.h

To: fvogt, #plasma, graesslin
Cc: kwin, plasma-devel, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9872: [weather] Show optionally temperature next to icon in compact mode

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Looks like this when enabled on the panels (tooltip shown for one on right 
panel):
  F5648962: Screenshot_20180114_124441.png 

  
  Would really, really like to get this in for 5.12 :)
  
  All the layout logic might be a little insane, but from all my experimenting 
is seemed needed to make the applet adapt to full height in horizontal mode and 
full width in vertical mode.
  Happy to learn if there is a more simple approach :)
  
  Can also proudly report: lack of binding loops, for what I tested.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D9872

To: kossebau, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9872: [weather] Show optionally temperature next to icon in compact mode

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Adds the logic for showing an alternative component for the compact
  presentation, where the temperature is shown next to the icon with the
  weather status (done in flow of layout).
  
  Adds also the matching configuration logic to allow the user to enable that
  alternative display.

REPOSITORY
  R114 Plasma Addons

BRANCH
  addWeatherAppletOptionForTemperatureInCompactMode

REVISION DETAIL
  https://phabricator.kde.org/D9872

AFFECTED FILES
  applets/weather/package/contents/config/config.qml
  applets/weather/package/contents/ui/CompactRepresentation.qml
  applets/weather/package/contents/ui/IconAndTextItem.qml
  applets/weather/package/contents/ui/configAppearance.qml
  applets/weather/weatherapplet.cpp
  applets/weather/weatherapplet.h

To: kossebau, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Roman Gilg]

romangg added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  In https://phabricator.kde.org/D9848#190644, @anemeth wrote:
  
  > .arcconfig is not needed here
  
  
  Your current patch would delete the .arcconfig file from the KWin repo when 
being pushed. Do as @zzag said and check it out from master to your working 
branch.

INLINE COMMENTS

> anemeth wrote in blur.h:29
> Why?

You only need it in the cpp and not in the header, right? Then you should also 
only include it in the cpp and not in the header.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin
Cc: romangg, zzag, anthonyfieroni, mart, davidedmundson, fredrik, ngraham, 
plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Alex Nemeth]

anemeth marked 2 inline comments as done.
anemeth added inline comments.
Restricted Application edited projects, added KWin; removed Plasma.

INLINE COMMENTS

> romangg wrote in blur.h:29
> Put this into the cpp.

Why?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin
Cc: romangg, zzag, anthonyfieroni, mart, davidedmundson, fredrik, ngraham, 
plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Alex Nemeth]

anemeth updated this revision to Diff 25305.
anemeth added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  Moved pointer initialization to the header file.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9848?vs=25300=25305

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9848

AFFECTED FILES
  .arcconfig
  effects/blur/blur.cpp
  effects/blur/blur.h
  effects/blur/blur.kcfg
  effects/blur/blur_config.ui
  effects/blur/blurshader.cpp
  effects/blur/blurshader.h

To: anemeth, #plasma, #kwin
Cc: romangg, zzag, anthonyfieroni, mart, davidedmundson, fredrik, ngraham, 
plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  > .arcconfig is not needed here and I re-added the whitespace to match the 
old version.
  
  git-checkout `.arcconfig` from parent commit.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin
Cc: romangg, zzag, anthonyfieroni, mart, davidedmundson, fredrik, ngraham, 
plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Vlad Zagorodniy]

zzag added inline comments.
Restricted Application edited projects, added Plasma; removed KWin.

INLINE COMMENTS

> blurshader.cpp:58
> +GLShader *m_shaderUpsample = nullptr;
> +GLShader *m_shaderCopysample = nullptr;
> +

No, it should be in the header file. E.g.

  ...
  private:
  GLShader *m_shaderDownsample = nullptr;
  GLShader *m_shaderUpsample = nullptr;
  GLShader *m_shaderCopysample = nullptr;
  ...

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin
Cc: romangg, zzag, anthonyfieroni, mart, davidedmundson, fredrik, ngraham, 
plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Alex Nemeth]

anemeth marked 8 inline comments as done.
anemeth added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  In https://phabricator.kde.org/D9848#190515, @romangg wrote:
  
  > In https://phabricator.kde.org/D9848#190128, @anemeth wrote:
  >
  > > Removed .arcconfig and added a whitespace
  >
  >
  > What? Why?
  
  
  .arcconfig is not needed here and I re-added the whitespace to match the old 
version.

INLINE COMMENTS

> zzag wrote in blurshader.cpp:86
> Please use `{}`

Most other if statements don't use brackets when there is only a return line 
and I don't intend to break that tradition, or I might have to correct all of 
them too.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin
Cc: romangg, zzag, anthonyfieroni, mart, davidedmundson, fredrik, ngraham, 
plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol

KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.9 - Build # 54 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/54/
 Project:
Plasma kwin kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 14 Jan 2018 10:20:27 +
 Build duration:
3 min 7 sec and counting
   CONSOLE OUTPUT
  [...truncated 463.64 KB...]1 error generated.gmake[2]: *** [kcmkwin/kwinoptions/CMakeFiles/kcm_kwinoptions.dir/build.make:118: kcmkwin/kwinoptions/CMakeFiles/kcm_kwinoptions.dir/mouse.cpp.o] Error 1gmake[1]: *** [CMakeFiles/Makefile2:881: kcmkwin/kwinoptions/CMakeFiles/kcm_kwinoptions.dir/all] Error 2Scanning dependencies of target kdecorationprivatedeclarative[  8%] Building CXX object kcmkwin/kwindecoration/declarative-plugin/CMakeFiles/kdecorationprivatedeclarative.dir/previewbutton.cpp.o[  8%] Building CXX object kcmkwin/kwindecoration/declarative-plugin/CMakeFiles/kdecorationprivatedeclarative.dir/previewclient.cpp.o[  8%] Building CXX object kcmkwin/kwindecoration/declarative-plugin/CMakeFiles/kdecorationprivatedeclarative.dir/previewsettings.cpp.o[  8%] Building CXX object kcmkwin/kwindecoration/declarative-plugin/CMakeFiles/kdecorationprivatedeclarative.dir/previewitem.cpp.o[  9%] Building CXX object kcmkwin/kwindecoration/declarative-plugin/CMakeFiles/kdecorationprivatedeclarative.dir/previewbridge.cpp.oIn file included from /usr/home/jenkins/workspace/Plasma kwin kf5-qt5 FreeBSDQt5.9/kcmkwin/kwindecoration/declarative-plugin/previewbutton.cpp:20:In file included from /usr/home/jenkins/workspace/Plasma kwin kf5-qt5 FreeBSDQt5.9/kcmkwin/kwindecoration/declarative-plugin/previewbutton.h:23:In file included from /usr/local/include/qt5/QtQuick/QQuickPaintedItem:1:In file included from /usr/local/include/qt5/QtQuick/qquickpainteditem.h:43:In file included from /usr/local/include/qt5/QtQuick/qquickitem.h:43:In file included from /usr/local/include/qt5/QtQuick/qtquickglobal.h:43:In file included from /usr/local/include/qt5/QtQml/qtqmlglobal.h:47:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:10:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^In file included from /usr/home/jenkins/workspace/Plasma kwin kf5-qt5 FreeBSDQt5.9/kcmkwin/kwindecoration/declarative-plugin/previewclient.cpp:20:In file included from /usr/home/jenkins/workspace/Plasma kwin kf5-qt5 FreeBSDQt5.9/kcmkwin/kwindecoration/declarative-plugin/previewclient.h:23:In file included from /usr/home/jenkins/workspace/Plasma kwin kf5-qt5 FreeBSDQt5.9/kcmkwin/kwindecoration/declarative-plugin/../../../decorations/decorationpalette.h:26:In file included from /usr/home/jenkins/install-prefix/include/KDecoration2/KDecoration2/DecorationSettings:1:In file included from /usr/home/jenkins/install-prefix/include/KDecoration2/kdecoration2/decorationsettings.h:24:In file included from /usr/home/jenkins/install-prefix/include/KDecoration2/kdecoration2/decorationbutton.h:26:In file included from /usr/local/include/qt5/QtCore/QObject:1:In file included from /usr/local/include/qt5/QtCore/qobject.h:46:In file included from /usr/local/include/qt5/QtCore/qobjectdefs.h:48:In file included from /usr/local/include/qt5/QtCore/qnamespace.h:43:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:10:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^In file included from /usr/home/jenkins/workspace/Plasma kwin kf5-qt5 FreeBSDQt5.9/kcmkwin/kwindecoration/declarative-plugin/previewitem.cpp:20:In file included from /usr/home/jenkins/workspace/Plasma kwin kf5-qt5 FreeBSDQt5.9/kcmkwin/kwindecoration/declarative-plugin/previewitem.h:23:In file included from /usr/local/include/qt5/QtQuick/QQuickPaintedItem:1:In file included from /usr/local/include/qt5/QtQuick/qquickpainteditem.h:43:In file included from /usr/local/include/qt5/QtQuick/qquickitem.h:43:In file included from /usr/local/include/qt5/QtQuick/qtquickglobal.h:43:In file included from /usr/local/include/qt5/QtQml/qtqmlglobal.h:47:In file included from /usr/local/include/qt5/QtCore/qglobal.h:64:In file included from /usr/local/include/qt5/QtCore/qconfig.h:1:/usr/local/include/qt5/QtCore/qconfig-modules.h:10:10: fatal error: 'QtCore/modules/qconfig-multimedia.h' file not found#include  ^In file included from /usr/home/jenkins/workspace/Plasma kwin kf5-qt5 FreeBSDQt5.9/kcmkwin/kwindecoration/declarative-plugin/previewsettings.cpp:20:In file included from /usr/home/jenkins/workspace/Plasma kwin kf5-qt5 FreeBSDQt5.9/kcmkwin/kwindecoration/declarative-plugin/previewsettings.h:23:In file included from /usr/home/jenkins/install-prefix/include/KDecoration2/KDecoration2/Private/DecorationSettingsPrivate:1:In file included from 

D9865: Do not call into NETWinInfo in AbstractClient::setSkipPager

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:85ef2831dbc1: Do not call into NETWinInfo in 
AbstractClient::setSkipPager (authored by graesslin).
Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9865?vs=25279=25301

REVISION DETAIL
  https://phabricator.kde.org/D9865

AFFECTED FILES
  abstract_client.cpp

To: graesslin, #kwin, #plasma, hein
Cc: hein, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Alex Nemeth]

anemeth updated this revision to Diff 25300.
anemeth added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  Changed all references of NULL to nullptr

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9848?vs=25290=25300

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9848

AFFECTED FILES
  .arcconfig
  effects/blur/blur.cpp
  effects/blur/blur.h
  effects/blur/blur.kcfg
  effects/blur/blur_config.ui
  effects/blur/blurshader.cpp
  effects/blur/blurshader.h

To: anemeth, #plasma, #kwin
Cc: romangg, zzag, anthonyfieroni, mart, davidedmundson, fredrik, ngraham, 
plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D9866: Add support for initial apply rules for skip (taskbar|pager|switcher)

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:42b099355c80: Add support for initial apply rules for 
skip (taskbar|pager|switcher) (authored by graesslin).
Restricted Application edited projects, added KWin; removed Plasma.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9866?vs=25280=25302

REVISION DETAIL
  https://phabricator.kde.org/D9866

AFFECTED FILES
  autotests/integration/shell_client_rules_test.cpp
  shell_client.cpp

To: graesslin, #kwin, #plasma, hein
Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D9792: even slimmer scrollbars

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In https://phabricator.kde.org/D9792#190540, @ngraham wrote:
  
  > In https://phabricator.kde.org/D9792#190538, @colomar wrote:
  >
  > > Looks great!
  > >  My only concern would be that in the mouseover state the contrast 
between the grip and groove is quite low. This could make the two difficult to 
distinguish, especially for color blind users. Could perhaps the contrast in 
terms of brightness be increased a bit?
  >
  >
  > +1; maybe we could make the groove lighter?
  
  
  But that should be a different patch. Mouse-over and scrollbar background 
have not been changed by this patch, and have been like that since day one. 
  No objection against changing them but
  
  - in a different patch
  - consistently with the rest of breeze. (the same shade of grey is used 
elsewhere, such as sliders, and progressbars, possibly also inactive tabs in 
tabs background.
  
  As for the mouse-over color, for the handle itself, I think it comes from the 
palette unmodified.
  
  Best,
  
  Hugo

REPOSITORY
  R31 Breeze

BRANCH
  arcpatch-D9792

REVISION DETAIL
  https://phabricator.kde.org/D9792

To: mart, #plasma, #kirigami, #vdg, hpereiradacosta, abetts
Cc: ngraham, colomar, abetts, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, davidedmundson, mart, hein

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Also, I would consider using smart pointers(e.g. `QScopedPointer`).

INLINE COMMENTS

> blur.cpp:92
> +delete m_simpleTarget;
> +m_simpleTarget = NULL;
> +

Please use `nullptr`.

> blur.cpp:95
>  delete m_simpleShader;
> -delete shader;
> -delete target;
> +m_simpleShader = NULL;
> +

Please use `nullptr`.

> blur.cpp:98
> +delete m_shader;
> +m_shader = NULL;
>  }

Please use `nullptr`.

> blur.cpp:125
> +delete m_renderTargets[i];
> +m_renderTargets[i] = NULL;
> +

`nullptr`

> blurshader.cpp:55
>  GLSLBlurShader::GLSLBlurShader()
> -: BlurShader(), shader(NULL)
> +: BlurShader(), m_shaderDownsample(NULL), m_shaderUpsample(NULL), 
> m_shaderCopysample(NULL)
>  {

You can simplify:

  GLShader *m_shaderDownsample = nullptr;
  GLShader *m_shaderUpsample = nullptr;
  GLShader *m_shaderCopysample = nullptr;

> blurshader.cpp:68
> +delete m_shaderDownsample;
> +m_shaderDownsample = NULL;
> +

`nullptr`

> blurshader.cpp:71
> +delete m_shaderUpsample;
> +m_shaderUpsample = NULL;
> +

`nullptr`

> blurshader.cpp:74
> +delete m_shaderCopysample;
> +m_shaderCopysample = NULL;
>  

`nullptr`

> blurshader.cpp:86
> +case copySampleType:
> +if (matrix == m_matrixCopysample)
> +return;

Please use `{}`

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin
Cc: romangg, zzag, anthonyfieroni, mart, davidedmundson, fredrik, ngraham, 
plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol

D9275: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a comment.


  In https://phabricator.kde.org/D9275#190594, @safaalfulaij wrote:
  
  > In https://phabricator.kde.org/D9275#190569, @mvourlakos wrote:
  >
  > > with your example me I cant reproduce it either...
  > >  I can only reproduce it with Latte Settings window, all other components 
are aligned correctly except the PlasmaComponent3.Combobox list items.
  > >
  > > you are right, this might be a downstream bug...
  > >
  > > Do you want to revert it 
  > >  I can do it
  >
  >
  > I checked out the source of latte-dock and it seems that it is using the 
old QQC1-based controls, which are problematic, especially with RTL :)
  >  This is a change for QQC2-based controls (version 3.0 of 
org.kde.plasma.components).
  
  
  To test it in Latte I added in the head of 
/shell/package/contents/configuration/AppearanceConfig.qml
  
import org.kde.plasma.components 3.0 as PlasmaComponents3
  
  and I set up the ComboBox in that file to:
  
PlasmaComponents3.ComboBox
  
  
  
  > But I can't understand how changing this V3 solved V2..
  
  V2 components are based totally at Qt Styles, V3 are reimplementing the 
behavior
  PlasmaComponents2.ComboBox is a ComboBoxStyle  but
  PlasmaComponents3.ComboBox is a real ComboBox

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, mart, plasma-devel, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D9275: fix RTL appearance for ComboBox

[Safa Alfulaij]

safaalfulaij added a comment.


  In https://phabricator.kde.org/D9275#190569, @mvourlakos wrote:
  
  > with your example me I cant reproduce it either...
  >  I can only reproduce it with Latte Settings window, all other components 
are aligned correctly except the PlasmaComponent3.Combobox list items.
  >
  > you are right, this might be a downstream bug...
  >
  > Do you want to revert it 
  >  I can do it
  
  
  I checked out the source of latte-dock and it seems that it is using the old 
QQC1-based controls, which are problematic, especially with RTL :)
  This is a change for QQC2-based controls (version 3.0 of 
org.kde.plasma.components).
  
  But I can't understand how changing this V3 solved V2..

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, mart, plasma-devel, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D9866: Add support for initial apply rules for skip (taskbar|pager|switcher)

[Martin Flöser]

graesslin added a dependent revision: D9870: Add support for apply initial keep 
above/below window rules.

REPOSITORY
  R108 KWin

BRANCH
  shell-client-skip-rules

REVISION DETAIL
  https://phabricator.kde.org/D9866

To: graesslin, #kwin, #plasma, hein
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9870: Add support for apply initial keep above/below window rules

[Martin Flöser]

graesslin added a dependency: D9866: Add support for initial apply rules for 
skip (taskbar|pager|switcher).
Restricted Application edited projects, added KWin; removed Plasma.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9870

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D9870: Add support for apply initial keep above/below window rules

[Martin Flöser]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
graesslin requested review of this revision.
Restricted Application edited projects, added Plasma; removed KWin.

REVISION SUMMARY
  This implements these set rules for ShellClient.

REPOSITORY
  R108 KWin

BRANCH
  shell-client-keep-above-below-rules

REVISION DETAIL
  https://phabricator.kde.org/D9870

AFFECTED FILES
  autotests/integration/shell_client_rules_test.cpp
  shell_client.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 68 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/68/
 Project:
Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 14 Jan 2018 08:25:25 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kcm-keyboard-iso_codes

D9275: fix RTL appearance for ComboBox

[Michail Vourlakos]

mvourlakos added a comment.


  In https://phabricator.kde.org/D9275#190547, @safaalfulaij wrote:
  
  > In https://phabricator.kde.org/D9275#190497, @mvourlakos wrote:
  >
  > > how did you test it?
  > >
  > > I tried in an qml app (Latte dock) by passing the parameter "--reverse"...
  > >  If your system is already using in RTL language, have you tried with 
--reverse?
  >
  >
  > I am using this with qmlsence-qt5.
  >  `plasma` folder is the ones before this, and `plasmacomponents3` is the 
one after this.
  >  Using C locale, everything aligned to left. Using --reverse will align 
everything to right.
  >  Using ar locale, everything aligned to right. Using --reverse will **not** 
reverse it to LTR layout and it makes everything aligned to left.
  >
  > Can't see the problem really.
  
  
  with your example me I cant reproduce it either...
  I can only reproduce it with Latte Settings window, all other components are 
aligned correctly except the PlasmaComponent3.Combobox list items.
  
  you are right, this might be a downstream bug...
  
  Do you want to revert it 
  I can do it

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, mart, plasma-devel, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol