KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 80 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/80/
 Project:
Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 23 Jan 2018 04:14:23 +
 Build duration:
1 hr 16 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kcm-keyboard-iso_codes

D10032: Swap play/pause icons in mediacontroller plasmoid

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Plasma, VDG.
nicolasfella added a project: Plasma.
nicolasfella requested review of this revision.

REVISION SUMMARY
  The play/pause status of the system tray icon appears inverse to the 
play/pause button in the
  plasmoid. This patch unifies the behaviour, which is common across various 
media players.

TEST PLAN
  Visual inspection

REPOSITORY
  R120 Plasma Workspace

BRANCH
  swapicons

REVISION DETAIL
  https://phabricator.kde.org/D10032

AFFECTED FILES
  applets/mediacontroller/contents/ui/main.qml

To: nicolasfella, #plasma, #vdg
Cc: plasma-devel, #vdg, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10031: Fix potential crash

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added projects: Plasma, Kirigami.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Turns out in some weird (wrong) cases, ListView sets a negative maximum()
  value. This makes the application crash in qcommonstyle.cpp.
  This prevents the crash by making sure opt->maximum is never smaller than
  opt->minimum.

TEST PLAN
  Manual test, now Discover doesn't crash

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10031

AFFECTED FILES
  plugin/kquickstyleitem.cpp

To: apol, #kirigami, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, davidedmundson, mart, hein

D10027: Removed duplicate preview screenshots

[Andres Betts]

abetts accepted this revision.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10027

To: anemeth, apol, #discover_software_store, davidedmundson, abetts
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10027: Removed duplicate preview screenshots

[Aleix Pol Gonzalez]

apol added a comment.


  Please land on the 5.12 branch.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10027

To: anemeth, apol, #discover_software_store, davidedmundson
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10027: Removed duplicate preview screenshots

[Aleix Pol Gonzalez]

apol added a comment.


  Can you push?

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10027

To: anemeth, apol, #discover_software_store, davidedmundson
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10027: Removed duplicate preview screenshots

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10027

To: anemeth, apol, #discover_software_store, davidedmundson
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10027: Removed duplicate preview screenshots

[David Edmundson]

davidedmundson accepted this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10027

To: anemeth, apol, #discover_software_store, davidedmundson
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Fredrik Höglund]

fredrik accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin, fredrik
Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson, 
fredrik, ngraham, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Alex Nemeth]

anemeth marked an inline comment as done.
Restricted Application edited projects, added KWin; removed Plasma.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin
Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson, 
fredrik, ngraham, plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, 
apol

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Alex Nemeth]

anemeth updated this revision to Diff 25782.
anemeth added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  Implemented the change suggested by @fredrik

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9848?vs=25720=25782

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9848

AFFECTED FILES
  effects/blur/blur.cpp
  effects/blur/blur.h
  effects/blur/blur.kcfg
  effects/blur/blur_config.ui
  effects/blur/blurshader.cpp
  effects/blur/blurshader.h
  libkwineffects/kwinglutils.cpp
  libkwineffects/kwinglutils.h

To: anemeth, #plasma, #kwin
Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson, 
fredrik, ngraham, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

Re: DBus statusnotifier (aka systray) daemon/bridge for GTk/XFCE environments?

[René J . V . Bertin]

David Edmundson wrote:

My previous reply to this seems to have gone missing.

> That plugin has it's own system tray handling that uses KNotification,
> instead of the platform DBus code you looked at in Qt.
> Combined with a getenv check in knotification will be the source of your
> issue.

I was right, the issue of KF5 systrays moving to the XFCE panel on Mac was due 
to Knotifications. The platform plugin just attempts to make every Qt 
application use the KNotifications wrapper around QSystemTrayIcon and is thus 
not the real culprit.
I've written a prototype fix (forcing legacy mode on platforms where that mode 
should be preferred) which I'll present in due time via the appropriate channel.

R.

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Fredrik Höglund]

fredrik added inline comments.
Restricted Application edited projects, added KWin; removed Plasma.

INLINE COMMENTS

> kwinglutils.cpp:1104
> +
> +s_renderTargets.reserve(s_renderTargets.size() + targets.size());
> +

The reserve() call should be in the else {} clause.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin
Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson, 
fredrik, ngraham, plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, 
apol

D9944: [WIP]expose if the tablet mode switch is available

[Martin Flöser]

graesslin added inline comments.
Restricted Application edited projects, added KWin; removed Plasma.

INLINE COMMENTS

> input.cpp:1897
> +#endif
> +return true;
> +}

false

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9944

To: mart, #kwin, #plasma
Cc: graesslin, ngraham, davidedmundson, plasma-devel, kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, 
sebas, apol, mart

D10027: Removed duplicate preview screenshots

[Alex Nemeth]

anemeth updated this revision to Diff 25776.
anemeth added a comment.


  Checking for duplicate now added to appendIfValid() instead

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10027?vs=25774=25776

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10027

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSResource.cpp

To: anemeth, apol, #discover_software_store
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10028: Checking for duplicate now added to appendIfValid() instead

[Alex Nemeth]

anemeth created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
anemeth requested review of this revision.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10028

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSResource.cpp

To: anemeth
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10027: Removed duplicate preview screenshots

[Alex Nemeth]

anemeth updated this revision to Diff 25774.
anemeth added a comment.


  Now I see what you mean. :)
  That makes it a lot smaller.

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10027?vs=25773=25774

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10027

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSResource.cpp

To: anemeth, apol, #discover_software_store
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10027: Removed duplicate preview screenshots

[Nathaniel Graham]

ngraham added a comment.


  In https://phabricator.kde.org/D10027#194446, @anemeth wrote:
  
  > In https://phabricator.kde.org/D10027#194443, @apol wrote:
  >
  > > Please modify appendIfValid to not add duplicates.
  >
  >
  > What do you mean?
  >  In what situation would it add duplicates?
  >  This change is to make sure it does not add duplicates.
  
  
  He's saying that you should make the change //inside// appendIfValid() 
instead of duplicating 4 times the same code that //calls// appendIfValid().
  
  Thanks for the patch, BTW!

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10027

To: anemeth, apol, #discover_software_store
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10027: Removed duplicate preview screenshots

[Alex Nemeth]

anemeth added a comment.


  In https://phabricator.kde.org/D10027#194443, @apol wrote:
  
  > Please modify appendIfValid to not add duplicates.
  
  
  What do you mean?
  In what situation would it add duplicates?
  This change is to make sure it does not add duplicates.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10027

To: anemeth, apol, #discover_software_store
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10027: Removed duplicate preview screenshots

[Aleix Pol Gonzalez]

apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.


  Please modify appendIfValid to not add duplicates.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10027

To: anemeth, apol, #discover_software_store
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10027: Removed duplicate preview screenshots

[Alex Nemeth]

anemeth edited the summary of this revision.
anemeth edited the test plan for this revision.
anemeth added reviewers: apol, Discover Software Store.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10027

To: anemeth, apol, #discover_software_store
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10027: Removed duplicate preview screenshots

[Alex Nemeth]

anemeth created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
anemeth requested review of this revision.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10027

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSResource.cpp

To: anemeth
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10024: Add supportedSchemes feature

[Aleix Pol Gonzalez]

apol added a comment.


  Makes sense I guess.
  
  Sounds like it would be useful to set this through kiosk, would that work?

INLINE COMMENTS

> kdiroperator.cpp:2650
> +{
> +d->supportedSchemes = schemes;
> +rereadDir();

only if d->supportedSchemes != schemes?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10024

To: mwolff, #plasma, dfaure
Cc: apol, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D9965: Provide a tooltip for the main action

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:3db732db861b: Provide a tooltip for the main action 
(authored by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D9965?vs=25655=25771#toc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9965?vs=25655=25771

REVISION DETAIL
  https://phabricator.kde.org/D9965

AFFECTED FILES
  src/controls/Units.qml
  src/controls/private/ActionButton.qml
  src/styles/org.kde.desktop/Units.qml

To: apol, #kirigami, mart
Cc: broulik, plasma-devel, apol, davidedmundson, mart, hein

Re: KDE and Google Summer of Code 2018

[Thomas Pfeiffer]

> On 22. Jan 2018, at 00:35, David Edmundson  wrote:
> 
> 
> 
> On Sun, Jan 21, 2018 at 7:25 PM, Albert Astals Cid  > wrote:
> El divendres, 19 de gener de 2018, a les 10:42:44 CET, Marco Martin va
> escriure:
> > On Mon, Jan 15, 2018 at 8:15 PM, Nate Graham  > > wrote:
> > > I've submitted an idea for System Settings: Improve handling for touchpads
> > > and mice with Libinput
> >
> > Speaking of systemsettings, would be a good fit porting to qml some
> > medium-to-big kcm?
> 
> What's the actual benefit of that porting?
> 
> 
> Unifying and fixing all our KCMs is the intention, there's new designs from 
> Andy.
> Use of QtQuick is a side effect, but the intended direction if we're 
> rewriting something anyway.

Let’s not forget touch-friendliness as an important benefit!

D10024: Add supportedSchemes feature

[Milian Wolff]

mwolff added a dependent revision: D10025: Use KFileWidget::setSupportedSchemes 
when available.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10024

To: mwolff, #plasma, dfaure
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10025: Use KFileWidget::setSupportedSchemes when available

[Milian Wolff]

mwolff created this revision.
mwolff added a reviewer: dfaure.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mwolff requested review of this revision.

REVISION SUMMARY
  This makes QFileDialog::setSupportedSchemes work for the KDE file
  dialogs.
  
  Depends on https://phabricator.kde.org/D10024.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10025

AFFECTED FILES
  src/platformtheme/kdeplatformfiledialoghelper.cpp

To: mwolff, dfaure
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10024: Add supportedSchemes feature

[Milian Wolff]

mwolff created this revision.
mwolff added reviewers: Plasma, dfaure.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
mwolff requested review of this revision.

REVISION SUMMARY
  This addds a whitelist of supported URL schemes to the KFileWidget
  to be used by KDEPlatformFileDialog. The whitelist is used by the
  KFilePlacesModel and KDirOperator to filter the displayed contents.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10024

AFFECTED FILES
  autotests/kdiroperatortest.cpp
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h

To: mwolff, #plasma, dfaure
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10023: Improve display of long app captions and name/caption padding

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10023

To: ngraham, apol, #discover_software_store, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10023: Improve display of long app captions and name/caption padding

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R134 Discover Software Store

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10023

To: ngraham, apol, #discover_software_store, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9944: [WIP]expose if the tablet mode switch is available

[Marco Martin]

mart updated this revision to Diff 25763.
mart added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  - wire up tabletModeAvailable

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9944?vs=25537=25763

BRANCH
  phab/tabletModeSupported

REVISION DETAIL
  https://phabricator.kde.org/D9944

AFFECTED FILES
  input.cpp
  input.h
  libinput/connection.cpp
  libinput/connection.h
  tabletmodemanager.cpp
  tabletmodemanager.h

To: mart, #kwin, #plasma
Cc: graesslin, ngraham, davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10023: Improve display of long app captions and name/caption padding

[Aleix Pol Gonzalez]

apol requested changes to this revision.
apol added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ApplicationPage.qml:157
>  text: appInfo.application.name
> +lineHeight: 1.0
>  maximumLineCount: 1

That's the default, no need to insist on it.

> ApplicationPage.qml:167
> +maximumLineCount: 2
> +lineHeight: lineCount > 1 ? 0.75 : 1.2
>  elide: Text.ElideRight

Is it really necessary? I wouldn't change the default at least to 1.2, leave 
1.0 as it's the level 4 font.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10023

To: ngraham, apol, #discover_software_store, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10023: Improve display of long app captions and name/caption padding

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10023

To: ngraham, apol, #discover_software_store, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager

[David Edmundson]

davidedmundson planned changes to this revision.
davidedmundson added a comment.


  Good point. 
  Will revisit.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10019

To: davidedmundson, #plasma
Cc: anthonyfieroni, sebas, broulik, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager

[Anthony Fieroni]

anthonyfieroni added a comment.


  Thats what doubt me:
  
https://phabricator.kde.org/source/kdeplasma-addons/browse/master/applets/minimizeall/plugin/minimizeall.cpp;65fc80441388c5f3e70832c40e1d7afea6778e83$63-68

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10019

To: davidedmundson, #plasma
Cc: anthonyfieroni, sebas, broulik, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D9965: Provide a tooltip for the main action

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9965

To: apol, #kirigami, mart
Cc: broulik, plasma-devel, apol, davidedmundson, mart, hein

D10021: Improve app icon padding on Application page

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10021

To: ngraham, apol, andreaska, #discover_software_store, #vdg, andreask
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10021: Improve app icon padding on Application page

[Andreas Kainz]

andreask accepted this revision.

REPOSITORY
  R134 Discover Software Store

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10021

To: ngraham, apol, andreaska, #discover_software_store, #vdg, andreask
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10021: Improve app icon padding on Application page

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R134 Discover Software Store

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10021

To: ngraham, apol, andreaska, #discover_software_store, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10021: Improve app icon padding on Application page

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: apol, andreaska, Discover Software Store, VDG.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Make the padding to the right of the app icon the same as its left padding.

TEST PLAN
  Tested in KDE Neon. Before:
  
  After:

REPOSITORY
  R134 Discover Software Store

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10021

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: ngraham, apol, andreaska, #discover_software_store, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Re: DBus statusnotifier (aka systray) daemon/bridge for GTk/XFCE environments?

[René J . V . Bertin]

David Edmundson wrote:

> You missed reading the code that calls this in
> src/widgets/util/qsystemtrayicon_x11.cpp which will make an X system tray
> if the platform doesn't.

I understand now why this doesn't happen in my case. Out of scope here.

> That plugin has it's own system tray handling that uses KNotification,
> instead of the platform DBus code you looked at in Qt.
> Combined with a getenv check in knotification will be the source of your
> issue.

Yes, I know the plugin modifies things in this domain. But it can only do that 
when it's actually installed and loaded and as already mentioned several times 
that doesn't matter here. I haven't yet had the time to look at what 
KNotification does. I doubt that it can see from a getenv check if a SNI host 
is 
present on the DBus. It may have to check the actual platform name in order to 
be really thorough (via QCoreApplication or KWindowSystem; last time I asked, 
Qt's official standpoint was "we support all QPA plugins that build on a given 
platform).

It could help me to know what env. variable KNotification looks for?
If you refer to KDE_FULL_SESSION or KDE_SESSION_VERSION, those aren't set in 
this particular case, and QT_QPA_PLATFORMTHEME=cocoa .

R

Re: DBus statusnotifier (aka systray) daemon/bridge for GTk/XFCE environments?

[David Edmundson]

On Mon, Jan 22, 2018 at 1:14 PM, René J. V. Bertin 
wrote:

> >>It's not plasma-specific
> >
> > It is. Hence the name...
>
> Just have a look at what it actually does;
>
nothing requires a plasma environment
> to be present (with the possible exception of the look-and-feel feature but
> that's far from crucial). Its goal is to provide theming (visual and
> behavioural) for Qt5 applications so they follow a set of guidelines.
>
> > and not surprisingly, you having issues when it
> > integrates with Plasma.
>
> Nope, that's not what is happening here. Please read again, there is no
> Plasma,
> the plugin is not implicated, and any issues I'm dealing with here exist
> whether
> or not the plugin is installed. I'm simply not looking for support with
> that
> plugin. Just forget I ever mentioned it.
>

That plugin has it's own system tray handling that uses KNotification,
instead of the platform DBus code you looked at in Qt.
Combined with a getenv check in knotification will be the source of your
issue.

David

Re: DBus statusnotifier (aka systray) daemon/bridge for GTk/XFCE environments?

[René J . V . Bertin]

>>It's not plasma-specific
> 
> It is. Hence the name...

Just have a look at what it actually does; nothing requires a plasma 
environment 
to be present (with the possible exception of the look-and-feel feature but 
that's far from crucial). Its goal is to provide theming (visual and 
behavioural) for Qt5 applications so they follow a set of guidelines.

> and not surprisingly, you having issues when it
> integrates with Plasma.

Nope, that's not what is happening here. Please read again, there is no Plasma, 
the plugin is not implicated, and any issues I'm dealing with here exist 
whether 
or not the plugin is installed. I'm simply not looking for support with that 
plugin. Just forget I ever mentioned it.

>>I'll be looking into that too today.
> 
> Please do not waste your time or my time in trying to "fix" issues in an
> already broken setup.

Excuse me? Not only did I not ask you anything, the set-up in question (Mac 
with 
the official XQuartz environment installed, plus official MacPorts versions of 
XFCE, DBus etc.) is not broken but perfectly legitimate. A similar and 
similarly 
legitimate situation can exist on MSWin with Cygwin installed.
If my analysis is correct that is not an issue for this ML.

R

D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager

[Sebastian Kügler]

sebas added a comment.


  I like, getting rid of C++ code is always welcome.
  
  Once the patch to libtaskmanager is in and kbroulik's comments addressed, +2 
from my side.
  
  Thanks!

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10019

To: davidedmundson, #plasma
Cc: sebas, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, mart

D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager

[Kai Uwe Broulik]

broulik added a comment.


  Don't you also need to remove the cpp stuff from CMakeLists and what not?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10019

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager

[Kai Uwe Broulik]

broulik added a comment.


  BUG: 377213

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10019

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager

[Kai Uwe Broulik]

broulik added a comment.


  Cool!

INLINE COMMENTS

> main.qml:57
> +tasksModel.requestToggleMinimized(idx);
> +clients.push(tasksModel.makePeristentModelndex(i));
> +}

typo

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10019

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager

[David Edmundson]

davidedmundson updated this revision to Diff 25753.
davidedmundson added a comment.


  Debug--

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10019?vs=25752=25753

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10019

AFFECTED FILES
  applets/minimizeall/package/contents/ui/main.qml
  applets/minimizeall/plugin/minimizeall.cpp
  applets/minimizeall/plugin/minimizeall.h
  applets/minimizeall/plugin/minimizeallplugin.cpp
  applets/minimizeall/plugin/minimizeallplugin.h
  applets/minimizeall/plugin/qmldir

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  This reduces the code we have and implicitly fixes it under wayland.
  
  Tracking of which windows are minimised by us is now done in JS, and
  through use of model indexes instead of X window IDs, which wouldn't
  really have worked under wayland.
  
  Potentially we may have some minor behavioural differences on X with
  regards to which windows are managed, as the old code did not skip those
  with skip_taskmanager.
  
  Requires a tiny patch in libtaskmanager to export persistentmodelindexes to
  QML.

TEST PLAN
  Under wayland:
  Had 3 windows, one minimised already
  Clicked button. All minimised.
  Clicked again, two restored

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10019

AFFECTED FILES
  applets/minimizeall/package/contents/ui/main.qml
  applets/minimizeall/plugin/minimizeall.cpp
  applets/minimizeall/plugin/minimizeall.h
  applets/minimizeall/plugin/minimizeallplugin.cpp
  applets/minimizeall/plugin/minimizeallplugin.h
  applets/minimizeall/plugin/qmldir

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9506: milti-screen sleep fix

[Sebastian Kügler]

sebas added a comment.


  Yeah, so could you abandon this phabricator review? It makes it harder to 
sift through reviews that actually are interesting...

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D9506

To: McPain, sebas, drosca
Cc: zerg, anthonyfieroni, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9414: Implement OSD to select action when unknown monitors is connected

[Sebastian Kügler]

sebas added a comment.


  In https://phabricator.kde.org/D9414#193341, @dvratil wrote:
  
  > Please disregard the noise in this patch, sebas merged master into the 
dvratil/osd branch so I can't generate a proper diff against the base revision 
without the noise from master.
  
  
  Sorry for that ... there we quite some changes in master which I wanted to 
test together with that, and I had some useful local patches added as well...

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D9414

To: dvratil, sebas, davidedmundson, #vdg
Cc: abetts, broulik, kamathraghavendra, graesslin, ngraham, plasma-devel, 
mlaurent, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, 
apol, mart

Re: DBus statusnotifier (aka systray) daemon/bridge for GTk/XFCE environments?

[David Edmundson]

>It's not plasma-specific

It is. Hence the name...and not surprisingly, you having issues when it
integrates with Plasma.

Use outside is 100% not supported.

>I'll be looking into that too today.

Please do not waste your time or my time in trying to "fix" issues in an
already broken setup.

David

Minutes Monday Plasma Hangout

[Sebastian Kügler]

Meeting minutes and log...
-- 
sebas

http://www.kde.org | http://vizZzion.orgPlasma Team Meeting, 22 january 2018

Present: Sho, notmart, d_ed, kbroulik, bshah, romangg, sebas

Sho:
* [Kicker] Fixed the search result that Enter/Return will run while still in 
the search field not being highlighted, giving no visual feedback you can just 
slam the key
* [Kicker] Fixed menu closing unexpectedly when moving mouse cursor away from 
an item that opened a subdialog (two seperate bugs, fixed in one approach)
* [Dashboard] Fixed a small regression from a recent refactoring breaking "Add 
to Favorites"
* [FV] Almost ready to add requested unit test to 
https://codereview.qt-project.org/#/c/215939/ - was painful to figure out how 
to write
* [Simple Menu] Released v1.0.8:
** Added user-requested option to only change categories on click (default: 
hover switch)
** Synced custom panel button image handling to latest Kicker
** Synced config dialog UI to latest Kicker
** Mouse-hover-vs-keyboard-nav fix a la previous Dashboard fix
** Quite nifty speed optimizations a la previous Dashboard work
* [Simple Menu] Released v1.0.9 with a follow-up fix for a bug that causes 
system action buttons to stay highlighted when the mouse pointer left the area
* [Simple Menu] Have another bugfix release planned soon ...
* [Other] Did some GIO/GVFS remote filesystem tests to evaluate their approach 
to mounting vs. ours, as users seem to prefer it

notmart:
* first rough working kernel driver for dell tablet mode (it turns out it's a 
standard-ish feature of intel acpi, so may work on more laptops than dells), in 
talk with some kernel people to make it into mainline
* big kirigami branch about static plugins has been merged, deployment story 
perhaps a bit easier
* fixes build issues on Android
* started patch to expose to kwin wether we are in tablet mode D9944 need help 
how to correctly wire things together
Diff 9944 "[WIP]expose if the tablet mode switch is available" [Needs Review] 
https://phabricator.kde.org/D9944
* plasma: tablet mode experiments: show/hide panels and show/hide plasmoids
* pushed slimmer scrollbars in breeze just on master, will be in 5.13

d_ed:
I ported the minimize all applet to libtaskmanager to work on wayland
and get rid of an import whilst we're at it

kbroulik:
* Fixed memory leak in notifications history using a Repeater and creating all 
delegates at once (now uses ListView, it's rather ugly but the least invasive 
(read: not a total rewrite) patch I could come up with that could still go into 
5.12)
* Tried to fix Kickoff user avatar not reliably updating, D9950 and D9951 but 
it still breaks in certain cases
Diff 9950 "[KUser] Check whether .face.icon is actually readable before 
returning it" [Accepted] https://phabricator.kde.org/D9950
Diff 9951 "[KUserProxy] Adjust to accounts service" [Needs Review] 
https://phabricator.kde.org/D9951
* Appmenu applet now underlines mnemonics only when Alt pressed to be in line 
with Breeze style
* Fixed deleting and creating files ("New File" menu) in Folder View taking 
forever (it didn't signal KDirNotify properly), D9912 still open. Haven't 
figured out a fix for DropJob yet
Diff 9912 "[KNewFileMenu] KDirNotify::emitFilesAdded after storedPut" [Needs 
Review] https://phabricator.kde.org/D9912
* Looked into getting rid of those stupid "Loop device" we get in places for 
e.g. snappy mounts: D9895
Diff 9895 "[UDisks] Ignore non-user mounts" [Needs Review] 
https://phabricator.kde.org/D9895
* Since we're getting quite a few crashes in libsqlite in the Bookmarksrunner 
lately, which pokes Firefox' database file to extract bookmarks (speaking of 
sqlite, could that be related to kactivities also breaking? that qsqlite has a 
regression?), I was looking into providing the bookmarks runner through 
plasma-browser-integration. It can just query the browser instead. However, 
after I did all of that for D9984 I figured that it obviously won't work if the
 browser isn't running. So I don't know how to procede. We could also have 
p-b-i extract all bookmarks, save them into a json file somewhere and the 
search there if not running but that wouldn't make it much better than what we 
currently have, except for that we don't need SQL.
Diff 9984 "WIP: Add bookmarks runner" [Needs Review] 
https://phabricator.kde.org/D9984

bshah:
- Mostly working on same stuff as last week
- Which includes testing the fixes for udev-android-networkmanager-simplelogin 
startup race
- On popular request worked on Plasma Mobile ISO based on neon : 
http://images.plasma-mobile.org/iso/
- Need help with that as plasmashell doesn't start on first start
- Will work on packaging newer libinput in neon
- will work on packaging qt 5.10 on neon

romangg:
well, currently (re)writing my Xwayland patches as I said.
d_ed and I added two KWin ideas for GSoC
https://community.kde.org/GSoC/2018/Ideas#KWin
there are still not many Plasma ideas.
Could there be a plasma workspace idea?

sebas:
* Testing 

Re: DBus statusnotifier (aka systray) daemon/bridge for GTk/XFCE environments?

[René J . V . Bertin]

David Edmundson wrote:


> You missed reading the code that calls this in
> src/widgets/util/qsystemtrayicon_x11.cpp which will make an X system tray
> if the platform doesn't.

Indeed, but that's curious. I see what you mean, but I followed the flow in a 
debugger and AFAICT the qpa_sys==NULL path was never taken (which is why I 
missed it). I'll have to take another look at that.


> Please don't tell me you're using the Plasma platform integration plugin
> under XFCE?

Why wouldn't one do that? It's not plasma-specific in the sense that it doesn't 
depend on anything that the plasma environment provides. In fact you get close 
to the same functionality when you set the proper env. variables thanks to 
qgenericunixtheme.cpp .
FWIW, I'm only using XFCE on that machine because it's so much cheaper to build 
than a full Plasma environment. For the rest I want my Qt/KF5 apps to behave 
like they would under Plasma5 - not unlike running KF5 applications under a 
Plasma4 environment in fact.

I know that the integration plugin modifies the systray behaviour but it's not 
the only one responsible for KDE apps not getting a systray under XFCE. 
KNotifications also seems to have its part of responsibility, judging from the 
following:
- I use xfwm4 and xfce4-panel under XQuartz on my Mac and installed 
dbusmenu-gtk 
and the sni-plugin there too
- I maintain a fork of the plasma integration plugin for Mac (osx-integration)
- I added the SNI notifier widget to the XFCE panel
- Qt/Cocoa applications not using KNotifications still use the native Mac 
systray
- KDE4 and KF5 applications start using the XFCE systray as soon as I activate 
it and revert to the native systray when I unload the XFCE sni plugin.
- For KF5 applications this is independent of the integration plugin, i.e. it 
happens with or without that plugin.

This would happen if KNotifications tests for presence of a SNI host on the 
DBus 
and uses native systray functionality only as a fallback. I'll be looking into 
that too today.

R.

D10016: [KFileTreeView] Manually expand tree when model tells us to

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, dfaure.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It seems just setting the current index isn't enough to expand all the way 
down.
  
  BUG: 389305

TEST PLAN
  Ran
  
kdialog --getexistingdirectory 
/home/kaiuwe/Projekte/kf5/plasma-workspace/build
  
  and it expanded all the way down to "build". Previously it would only expand 
"home"

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10016

AFFECTED FILES
  src/platformtheme/kfiletreeview.cpp

To: broulik, #plasma, dfaure
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10016: [KFileTreeView] Manually expand tree when model tells us to

[Kai Uwe Broulik]

broulik edited the summary of this revision.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10016

To: broulik, #plasma, dfaure
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 79 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/79/
 Project:
Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 22 Jan 2018 10:36:25 +
 Build duration:
7 min 57 sec and counting
   CONSOLE OUTPUT
  [...truncated 536.42 KB...]Unknown property type for key "X-KDE-Keywords[el]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[en_GB]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[es]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[et]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[eu]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[fi]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[fr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ga]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[gl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[he]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[hu]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ia]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[id]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[is]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[it]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ja]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[kk]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[km]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ko]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[lt]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[mr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[nb]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[nds]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[nl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[nn]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[pa]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[pl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[pt]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[pt_BR]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ro]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ru]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sk]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@ijekavian]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@ijekavianlatin]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@latin]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sv]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[tr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ug]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[uk]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[vi]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[x-test]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[zh_CN]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[zh_TW]" -> falling back to stringGenerated  "/usr/home/jenkins/workspace/Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9/build/kcms/desktoptheme/kcm_desktoptheme.json" [ 10%] Automatic MOC for target kcm_desktoptheme[ 10%] Built target kcm_desktoptheme_autogenScanning dependencies of target kcm_standard_actions_autogen[ 11%] Automatic MOC for target kcm_standard_actions[ 11%] Built target kcm_standard_actions_autogenScanning dependencies of target kcm_keys_autogen[ 11%] Automatic MOC for target kcm_keys[ 11%] Built target kcm_keys_autogenScanning dependencies of target kcm_smserver_autogen[ 11%] Automatic MOC for target kcm_smserver[ 11%] Built target kcm_smserver_autogenScanning dependencies of target kcm_lookandfeel-kcms-metadata-json[ 12%] Generating kcm_lookandfeel-kcms-metadata.jsonAbout to parse service type file "/usr/home/jenkins/install-prefix/share/kservicetypes5/plasma-generic.desktop"Unknown property type for key "Keywords" -> falling back to stringUnknown property type for key "X-KDE-ParentApp" -> falling back to stringUnknown property type for key "X-Plasma-API" -> falling back to stringUnknown property type for key "X-Plasma-MainScript" -> falling back to stringUnknown property type for key 

KDE CI: Plasma libksysguard kf5-qt5 FreeBSDQt5.9 - Build # 20 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20libksysguard%20kf5-qt5%20FreeBSDQt5.9/20/
 Project:
Plasma libksysguard kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 22 Jan 2018 10:20:20 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.processtest

D9962: Make sure the search result that Return will run is highlighted

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:19796bc57165: Make sure the search result that Return 
will run is highlighted (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9962?vs=25592=25744

REVISION DETAIL
  https://phabricator.kde.org/D9962

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemListView.qml
  applets/kicker/package/contents/ui/MenuRepresentation.qml
  applets/kicker/package/contents/ui/RunnerResultsList.qml

To: hein, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9945: Don't close plasmoid when closing a subdialog

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:fc155e94457d: Dont close plasmoid when closing a 
subdialog (authored by hein).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D9945?vs=25639=25743#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9945?vs=25639=25743

REVISION DETAIL
  https://phabricator.kde.org/D9945

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemListDialog.qml
  applets/kicker/package/contents/ui/ItemListView.qml
  applets/kicker/package/contents/ui/main.qml
  applets/kicker/plugin/windowsystem.cpp
  applets/kicker/plugin/windowsystem.h

To: hein, #plasma, mart
Cc: mart, ngraham, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D9962: Make sure the search result that Return will run is highlighted

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D9962

To: hein, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Re: DBus statusnotifier (aka systray) daemon/bridge for GTk/XFCE environments?

[David Edmundson]

On Sun, Jan 21, 2018 at 6:06 PM, René J. V. Bertin 
wrote:

> Hi,
>
> > I think you've only half analysed this. If nothing is really listening on
> > DBus it will fall back to legacy X which will work on XFCE.
>
> Where did I miss this in the code? The createPlatformSystemTrayIcon()
> functions
> in qtbase/src/platformsupport/themes/genericunix/qgenericunixthemes.cpp
> are
> pretty clear: they return NULL unless isDBusTrayAvailable() returns true.
>

You missed reading the code that calls this in
src/widgets/util/qsystemtrayicon_x11.cpp which will make an X system tray
if the platform doesn't.

>
> > You'll get into this situation if you have a StatusNotifierItemWatcher
> > (typically a kded module from p-w) but no StatusNotifierItem host (sys
> tray
> > support)
>
> In fact, any Qt application that tries to put up a systray icon. At least
> when
> the plasma-integration plugin is installed.
>
> I did find a solution though, ultimately:
> https://github.com/equeim/snw-plugin
>
> Which is just about exactly what I asked for :)
>
> Hope this helps others,
>
>


> R.
>
> PS: Ah, when I move the platform integration plugin aside I indeed get a
> systray
> icon. Hmmm...
>

Please don't tell me you're using the Plasma platform integration plugin
under XFCE?

David

KDE CI: Plasma libksysguard kf5-qt5 SUSEQt5.9 - Build # 32 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma%20libksysguard%20kf5-qt5%20SUSEQt5.9/32/
 Project:
Plasma libksysguard kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 22 Jan 2018 10:20:20 +
 Build duration:
2 min 39 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)66%
(29/44)66%
(29/44)40%
(2491/6151)27%
(1235/4496)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsksgrd0%
(0/5)0%
(0/5)0%
(0/518)0%
(0/220)lsofui0%
(0/1)0%
(0/1)0%
(0/50)0%
(0/14)processcore64%
(7/11)64%
(7/11)43%
(671/1547)31%
(269/863)processui62%
(8/13)62%
(8/13)24%
(653/2778)15%
(351/2293)signalplotter100%
(4/4)100%
(4/4)91%
(558/613)69%
(276/400)tests100%
(10/10)100%
(10/10)94%
(609/645)48%
(339/706)

Re: DBus statusnotifier (aka systray) daemon/bridge for GTk/XFCE environments?

[René J . V . Bertin]

René J. V. Bertin wrote:

> PS: Ah, when I move the platform integration plugin aside I indeed get a
> systray icon. Hmmm...

Hmmm indeed. Pushing the plugin aside doesn't take down an already running host 
of course. When I do that too, the error message comes back that tells me that 
no systray feature is available.

R.

D9961: [Plasma Theme] Guard against invalid KPluginInfo object

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:9870027494b5: [Plasma Theme] Guard against invalid 
KPluginInfo object (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9961?vs=25588=25742

REVISION DETAIL
  https://phabricator.kde.org/D9961

AFFECTED FILES
  src/plasma/private/theme_p.cpp

To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9961: [Plasma Theme] Guard against invalid KPluginInfo object

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9961

To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9945: Don't close plasmoid when closing a subdialog

[Marco Martin]

mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kcm_keyboard.desktop:126
>  Comment[hu]=Billentyűzetkiosztás
> -Comment[id]=Tata Letak dan Peranti Keras Keyboard
> +Comment[id]=Tata Letak dan Perangkat Keras Keyboard
>  Comment[is]=Lyklaborðsuppsetning

this shouldn't be in the final commit

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fixfocushandover

REVISION DETAIL
  https://phabricator.kde.org/D9945

To: hein, #plasma, mart
Cc: mart, ngraham, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D9974: Improve header and metadata display

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R134 Discover Software Store

BRANCH
  combobox-to-choose-source

REVISION DETAIL
  https://phabricator.kde.org/D9974

To: ngraham, apol, abetts, colomar, #discover_software_store, #vdg, andreaska
Cc: matheusm, andreaska, januz, romangg, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Fwd: KDE CI: Plasma ksshaskpass kf5-qt5 SUSEQt5.9 - Build # 11 - Still Failing!

[Ben Cooksley]

On Mon, Jan 22, 2018 at 7:30 PM, Martin Koller  wrote:
> On Sonntag, 21. Jänner 2018 22:40:31 CET Ben Cooksley wrote:
>> On Mon, Jan 22, 2018 at 10:15 AM, Martin Koller  wrote:
>> > Hi,
>>
>> Hi Martin,
>>
>> >
>> > On Sonntag, 21. Jänner 2018 20:43:42 CET Ben Cooksley wrote:
>> >> Hi Martin,
>> >>
>> >> Looks like your latest commit to ksshaskpass doesn't build.
>> >> Could you please take a look?
>> >
>> > I don't understand this.
>> >
>> > Why does my new line fail
>> > QRegularExpression re3a("^(Password|Username) for \"(.*?)\"$");
>> >
>> > and all the others don't
>> > QRegularExpression re3("^(Password|Username) for (.*?)[:] $");
>> > QRegularExpression re2("^Bad passphrase, try again for (.*?)( 
>> > \\(will confirm each use\\))?: $");
>> >
>> > etc.
>> >
>> > All of these use QString(const char*)
>> >
>> > Is the define QT_NO_CAST_FROM_ASCII used during compilation ?
>> > If so, all QRegularExpression's should fail.
>> >
>> > I can of course now wrap all strings in QLatin1String() but first I'd like 
>> > to understand
>> > why only my new line fails.
>>
>> From my understanding Laurent has recently been making changes
>> throughout various parts of KDE applications which do have the effect
>> of enabling QT_NO_CAST_FROM_ASCII.
>
> nice :-(
>
>> The CI system doesn't do anything
>> special compared to anyone else when compiling software - any defines
>> such as this one will be set by CMake so this should be showing up
>> locally for you as well.
>
> no, I don't see it, but I just compile ksshaskpass using the locally installed
> KF5 5.42 libs.

Interesting. It is possible that previously one of the Frameworks it
uses was disabling that flag as well, as the CI will have a newer KF5
(it rebuilds once a week essentially)

>
>
>> I'm not sure why only the new line is failing, it could be the
>> compiler only complaining about the first instance it hits though?
>
> Yes, that might be possible.
> Nevertheless, I have now wrapped all exising strings in QStringLiteral
> and it compiles when I explicitely set QT_NO_CAST_FROM_ASCII

Thanks, I can confirm it's building again.

Cheers,
Ben

>
>
> --
> Best regards/Schöne Grüße
>
> Martin
> A: Because it breaks the logical sequence of discussion
> Q: Why is top posting bad?
>
> ()  ascii ribbon campaign - against html e-mail
> /\- against proprietary attachments
>
> Geschenkideen, Accessoires, Seifen, Kulinarisches: www.lillehus.at
>
>

D9506: milti-screen sleep fix

[Oleg Solovyov]

McPain added a comment.


  UPD:
  I found monitor combination that makes KScreen works: AOC(hdmi)-iiyama(D-SUB)
  If I swap monitors, KSCeen doesn't work (noticed it past friday evening)

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D9506

To: McPain, sebas, drosca
Cc: zerg, anthonyfieroni, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9506: milti-screen sleep fix

[Sebastian Kügler]

sebas added a comment.


  Alright, please abandon this patch then, it's definitely wrong.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D9506

To: McPain, sebas, drosca
Cc: zerg, anthonyfieroni, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart