[Plasma] Qt patch for desktop icon papercut

[Eike Hein]

'lo dear packagers,

the Plasma team recommends applying the following patch to both Qt
5.9 and Qt 5.10 at your convenience:

https://codereview.qt-project.org/#/c/215939/

This fixes a bug causing the wrong desktop icon to look hovered
after dragging an icon on the desktop (the top-left icon instead
of the just-dropped one).

This is not a serious bug. The patch may also fix similar issues
in other UIs, though.

The patch should find its way into the next Qt 5.9.x and 5.10.x
releases.


Cheers,
Eike

Re: Plasma 5.12.0 tagging

[Jonathan Riddell]

Im back in europe but not back home with computer until this european late
afternoon. I can make tars then or someone else can start it earlier.

Jonathan

On Thursday, 1 February 2018, David Edmundson 
wrote:

> Plasma 5.12.0 is being tagged Thursday
> a.ka. (depending on your timezone and when you read this) today.
>
> If there is anything super critical that has not yet been merged please do
> so and/or ping me as soon as possible.
>
> Public release is next Tuesday.
>
> David
>

D10217: Choose source with a combobox, but only on the desktop view

[David C]

davidc added a comment.


  Are there problems with implementation? I don't understand why this concept 
would not be considered an improvement to the way source selection is handled.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10217

To: ngraham, apol, #discover_software_store, #vdg
Cc: davidc, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10217: Choose source with a combobox, but only on the desktop view

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Discussed it internally, not popular.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10217

To: ngraham, apol, #discover_software_store, #vdg
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Diego Gangl]

januz added a comment.


  +1 I wouldn't have this as a default for Breeze, but it looks really cool. 
I'm sure it'd be a popular option, specially among those trying to mimic macOS.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma
Cc: januz, abetts, colomar, andreask, zzag, ngraham, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10219: Load translations from KPackage files if bundled

[Chris Holland]

This revision was automatically updated to reflect the committed changes.
Closed by commit R118:37792755e48a: [plasmoidviewer] Load translations from 
KPackage files if bundled (authored by Zren).

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10219?vs=26295&id=26297

REVISION DETAIL
  https://phabricator.kde.org/D10219

AFFECTED FILES
  plasmoidviewer/view.cpp

To: Zren, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10219: Load translations from KPackage files if bundled

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  thanks

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D10219

To: Zren, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10219: Load translations from KPackage files if bundled

[Chris Holland]

Zren created this revision.
Zren added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  Based on https://phabricator.kde.org/D5209, which adds this feature to 
plasma-framework.
  
  -
  
  https://phabricator.kde.org/D5209

TEST PLAN
  Assuming 
`/usr/share/locale/fr/LC_MESSAGES/plasma_applet_org.kde.plasma.digitalclock.mo` 
exists.
  
  - `LANGUAGE=fr plasmoidviewer -a org.kde.plasma.digitalclock`
- `i18n()` strings are translated into french.
- Qt datetime formatting (`Qt.formatDate(tzDate,"")`) like in 
digitalclock's tooltip **uses the system locale**.
  - `LANG=fr_CA.UTF-8 LANGUAGE=fr plasmoidviewer -a org.kde.plasma.digitalclock`
- `i18n()` strings are translated into french.
- Qt datetime formatting uses the french canadian locale.
  
  Before patch:
  
  - `LANGUAGE=fr plasmoidviewer -a ./package`
- `i18n()` strings are **not translated**.
  - `plasmoidviewer -a ./bundle.plasmoid`
- Does not work. Seems it needs to be extracted first for plasmoidviewer to 
work.
  
  After patch:
  First setup a test env that doesn't have translations elsewhere.
  
cp -r /usr/share/plasma/plasmoids/org.kde.plasma.volume .
cd org.kde.plasma.volume
mkdir -p contents/locale/fr/LC_MESSAGES
rm metadata.json
kwriteconfig5 --file "$(realpath metadata.desktop)" --group "Desktop Entry" 
--key "X-KDE-PluginInfo-Name" "org.kde.plasma.volumetest"
cd contents/locale/fr/LC_MESSAGES
cp /usr/share/locale/fr/LC_MESSAGES/plasma_applet_org.kde.plasma.volume.mo .
mv plasma_applet_org.kde.plasma.volume.mo 
plasma_applet_org.kde.plasma.volumetest.mo
cd ../../../..
  
  
  
  - `LANGUAGE=fr plasmoidviewer -a .`
- `i18n()` strings are translated into french, loaded from 
`./package/contents/locale/fr/LC_MESSAGES/plasma_applet_na.me.space.mo`
  - Tested when `contents/locale` doesn't exist.
  - Tested when `metadata.desktop` and `metadata.json` doesn't exist.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D10219

AFFECTED FILES
  plasmoidviewer/view.cpp

To: Zren, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10217: Choose source with a combobox, but only on the desktop view

[Henrik Fehlauer]

rkflx added a comment.


  FWIW, I nearly commented on one of your early blog posts. I wanted to suggest 
a combobox to:
  
  - indicate the possibility to make a selection (which a link clearly fails at)
  - solve the issue of having to move the mouse to a completely different 
location (usability problem)
  
  You got the (obvious) combobox idea yourself meanwhile, but at least have my 
+1 here ;)
  
  If the the combobox sticks out too much visually, try the QML equivalent of 
`setFrame(false)` (did not test yet, though).

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10217

To: ngraham, apol, #discover_software_store, #vdg
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10181: Removed the "fastblur" path

[Nathaniel Graham]

ngraham added a reviewer: VDG.
Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10181

To: anemeth, graesslin, #kwin, #plasma, #vdg
Cc: fredrik, ngraham, plasma-devel, kwin, #kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10181: Removed the "fastblur" path

[Nathaniel Graham]

ngraham accepted this revision as: VDG.
ngraham added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  No VDG objections!

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10181

To: anemeth, graesslin, #kwin, #plasma, #vdg
Cc: fredrik, ngraham, plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, 
apol, mart

D10181: Removed the "fastblur" path

[Fredrik Höglund]

fredrik added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Code wise this LGTM.
  
  Consider it accepted if the VDG has no objections.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10181

To: anemeth, graesslin, #kwin, #plasma
Cc: fredrik, ngraham, plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, 
apol, mart

KDE CI: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 - Build # 32 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/32/
 Project:
Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 31 Jan 2018 22:56:29 +
 Build duration:
8 min 6 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Plasma plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 31 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/31/
 Project:
Plasma plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 31 Jan 2018 22:56:29 +
 Build duration:
4 min 33 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

Plasma 5.12.0 tagging

[David Edmundson]

Plasma 5.12.0 is being tagged Thursday
a.ka. (depending on your timezone and when you read this) today.

If there is anything super critical that has not yet been merged please do
so and/or ping me as soon as possible.

Public release is next Tuesday.

David

KDE CI: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 - Build # 23 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20FreeBSDQt5.9/23/
 Project:
Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 31 Jan 2018 22:21:55 +
 Build duration:
7 min 51 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kcm-keyboard-iso_codesFailed: TestSuite.lookandfeel-kcmTest

D10170: Added optional transparency/blur to menu frames

[Nathaniel Graham]

ngraham added a comment.


  OK, I have to admit that those examples look really, really good. 30% more 
than 40%.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma
Cc: abetts, colomar, andreask, zzag, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Alex Nemeth]

anemeth added a comment.


  Just to show you how it looks compared to something that is generally 
considered good design: Deepin
  I choose the same wallpaper and menu locations.
  I tested it with 30% and 40% transparency and 10/15 blur strength (that is 
likely going to be the new default).
  
  F5685908: qqq.PNG 
  
  KDE seems a little bit darker. That's because in Deepin the file manager 
background and the menu background is both white (255, 255, 255), while in KDE 
they are both gray (252, 252, 252).
  I'm not sure a contrast trickery would improve it much.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma
Cc: abetts, colomar, andreask, zzag, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10217: Choose source with a combobox, but only on the desktop view

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10217

To: ngraham, apol, #discover_software_store, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10217: Choose source with a combobox, but only on the desktop view

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: apol, Discover Software Store, VDG.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Here I am again, hawking my combobox... :)
  
  This patch uses a combobox to select the source, but only for the desktop 
view. People are always complaining that Discover's desktop view doesn't feel 
like a desktop app, and using a desktop-metaphor UI element here would help the 
situation, I believe.
  
  On mobile, the UI is unchanged, and we show the overlay, which has always 
felt more mobile-like anyway. It's more at home on that view.
  
  When there is only a single source, we show a simple label for both desktop 
and mobile.

TEST PLAN
  Tested in KDE Neon. Source switching still works for all views and apps.
  
  Desktop view, single source:
  
  Desktop view, multiple sources:
  
  Desktop view, source chooser in action:
  
  Mobile view, single source:
  
  Mobile view, multiple sources:
  
  Mobile view, source chooser in action:

REPOSITORY
  R134 Discover Software Store

BRANCH
  combobox-on-desktop

REVISION DETAIL
  https://phabricator.kde.org/D10217

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: ngraham, apol, #discover_software_store, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7155: Implement sorting of the device tree items

[Isaac True]

isaact updated this revision to Diff 26293.
isaact added a comment.


  Hi @broulik, I've rebased the diff based on the latest source revision 
(https://phabricator.kde.org/R102:d3d3ee543a17a3859bf2204c15dc7c36804eed15).
  
  Unfortunately I don't have commit access.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7155?vs=19184&id=26293

REVISION DETAIL
  https://phabricator.kde.org/D7155

AFFECTED FILES
  Modules/devinfo/devicelisting.cpp
  Modules/devinfo/soldevice.cpp
  Modules/devinfo/soldevice.h

To: isaact, #plasma, cfeck, broulik
Cc: cfeck, broulik, anthonyfieroni, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10181: Removed the "fastblur" path

[Alex Nemeth]

anemeth updated this revision to Diff 26279.
anemeth added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Undone unrelated change

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10181?vs=26181&id=26279

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10181

AFFECTED FILES
  effects/blur/blur.cpp
  effects/blur/blur.h
  effects/blur/blur.kcfg
  effects/blur/blur_config.ui
  effects/logout/data/1.10/logout-blur.frag
  effects/logout/data/1.40/logout-blur.frag
  effects/shaders.qrc

To: anemeth, graesslin, #kwin, #plasma
Cc: fredrik, ngraham, plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, 
apol, mart

D10181: Removed the "fastblur" path

[Alex Nemeth]

anemeth marked an inline comment as done.
Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10181

To: anemeth, graesslin, #kwin, #plasma
Cc: fredrik, ngraham, plasma-devel, kwin, #kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Vlad Zagorodniy]

zzag added a comment.


  In https://phabricator.kde.org/D10170#198659, @anemeth wrote:
  
  > I got enableBackgroundContrast to work. It is very very poorly documented.  
 
  >  I played around with the values but the endresult does not look better.
  >  In my opinion it looks worse if I change the contrast or intensity.
  
  
  Could you please share screenshots?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma
Cc: abetts, colomar, andreask, zzag, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Vlad Zagorodniy]

zzag added a comment.


  In https://phabricator.kde.org/D10170#198656, @ngraham wrote:
  
  > Sort of/mostly: https://community.kde.org/KDE_Visual_Design_Group/HIG
  
  
  It would nice to have a fully-fledged design language which would specify 
grid stuff, animations, etc. Something like Fluent 
design(https://fluent.microsoft.com) or Material 
design(https://material.io/guidelines/#).
  
  I think this should be a separate topic, so yeah...

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma
Cc: abetts, colomar, andreask, zzag, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10181: Removed the "fastblur" path

[Fredrik Höglund]

fredrik added inline comments.
Restricted Application edited projects, added Plasma; removed KWin.

INLINE COMMENTS

> blur.kcfg:9
>  
> -5
> -
> -
> -false
> +10
>  

This looks like an unrelated change.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10181

To: anemeth, graesslin, #kwin, #plasma
Cc: fredrik, ngraham, plasma-devel, kwin, #kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Alex Nemeth]

anemeth updated this revision to Diff 26278.
anemeth added a comment.


  .

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10170?vs=26160&id=26278

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10170

AFFECTED FILES
  kstyle/breeze.kcfg
  kstyle/breezestyle.cpp
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: anemeth, hpereiradacosta, #plasma
Cc: abetts, colomar, andreask, zzag, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Nathaniel Graham]

ngraham added a comment.


  In https://phabricator.kde.org/D10170#198655, @zzag wrote:
  
  > @ngraham: blur is OK but it should be used wisely. Blurring the hell out 
from UI is not really cool.
  >
  > IMO, changes like this, require some changes in the "design language".
  >  PS. does Plasma have a design language? (like Fluent or Material design)
  
  
  Sort of/mostly: https://community.kde.org/KDE_Visual_Design_Group/HIG

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma
Cc: abetts, colomar, andreask, zzag, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Vlad Zagorodniy]

zzag added a comment.


  @ngraham: blur is OK but it should be used wisely. Blurring the hell out from 
UI is not really cool.
  
  IMO, changes like this, require some changes in the "design language".
  PS. does Plasma have a design language? (like Fluent or Material design)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma
Cc: abetts, colomar, andreask, zzag, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Andres Betts]

abetts added a comment.


  In https://phabricator.kde.org/D10170#198634, @ngraham wrote:
  
  > Eh, maybe I'm wrong. Still... [shakes old man stick] I don't like it! These 
whippersnappers and their transparency! Back in my day things were opaque and 
we liked it that way!
  >
  > I won't die on this hill though, since it's being proposed as an optional 
feature and not a new default.
  
  
  I think that's a good way to look at it. I would be OK to make it an option.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma
Cc: abetts, colomar, andreask, zzag, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Nathaniel Graham]

ngraham added a comment.


  Eh, maybe I'm wrong. Still... [shakes old man stick] I don't like it! These 
whippersnappers and their transparency! Back in my day things were opaque and 
we liked it that way!
  
  I won't die on this hill though, since it's being proposed as an optional 
feature and not a new default.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma
Cc: abetts, colomar, andreask, zzag, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Vlad Zagorodniy]

zzag added a comment.


  In https://phabricator.kde.org/D10170#198591, @ngraham wrote:
  
  > Since then, both of those companies have mostly moved away from blur 
transparency in their operating systems, or made it optional.
  
  
  Did they?
  
  Microsoft is doing some work on Fluent design (https://fluent.microsoft.com/).
  macOS is still using blur extensively.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma
Cc: abetts, colomar, andreask, zzag, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Nathaniel Graham]

ngraham added a comment.


  FWIW, I don't think I'd ever want this enabled by default, and I'm leery of 
adding the option to Breeze. I'm not sure how much it really fits the visual 
style. Only very very subtle blur transparency would ever work here without 
becoming garish and distracting--and such a low level IMHO calls into question 
what the point even is.
  
  For years, macOS experimented with making things transparent and blurry. 
People made fun of them. Then Microsoft did it, but even worse. People made fun 
of them, too. Since then, both of those companies have mostly moved away from 
blur transparency in their operating systems, or made it optional. I really 
don't see how letting people move closer towards their historical design 
mistakes helps us here.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma
Cc: abetts, colomar, andreask, zzag, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Vlad Zagorodniy]

zzag added a comment.


  Also, please, take into account contrast issues. That's nice to have blur, 
but, please, use it wisely.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma
Cc: abetts, colomar, andreask, zzag, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Andres Betts]

abetts removed a reviewer: VDG.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma
Cc: abetts, colomar, andreask, zzag, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Andres Betts]

abetts added subscribers: andreask, colomar, abetts.
abetts added a comment.


  In https://phabricator.kde.org/D10170#198471, @hpereiradacosta wrote:
  
  > Hello, 
  >  Hi, 
  >  thanks for the patch !
  >
  > Few comments:
  >  1/ the code does not compile under kde4 (cmake -DUSE_KDE4). You would need 
to use the proper #ifdef to prevent this
  >
  > 2/ I think the "blur" option should go. Blur should be controlled centrally 
by the desktop effect. In other words: BlurBehind should always be set to true, 
and then left to kwin to handle. Having an extra option here seems like 
micro-management. Why would you need blur behind plasma widgets (as handled by 
the desktop effect) and not behind menus ? (or vice versa). Also, right now, 
selecting "blur" in the style settings, but unselecting the desktop effect 
results in no blur behind menu, and hence inconsistency with what the style 
option says.
  >
  > 3/ the slider should follow the same convention and design as for the 
translucency effect: "transparent  opaque".  0% should be 
transparent, 100% should be opaque. 
  >  Also, should have the same granularity, so ... percents. (not 10%)
  >
  > 4/ I would really like the VDG opinion on this. IMHO I am not sure if it 
fits the breeze "guidelines" or design-ideas, in the sense that I do not know 
why this is needed (what is the use case), aside from "this is pretty".
  >
  > In other words: why would one need to be able to see what is behind the 
menu you are currently navigating ? 
  >  Navigating a menu is a very focused thing one wants to do: one is looking 
for a specific action to perform on the current content of the window. To me at 
least, seeing-through the menu is more a distraction to this task than anything 
else. (and adding blur to reduce this distraction would in fact go in the 
direction of not being translucent at all).
  >
  > If the only reason is "this is pretty", then this has to be balanced with 
the extra option, code complexity, and configurations to be tested on the 
maintainer side, that this patch adds.
  
  
  Maybe I can add some extra reasons. I am not sure if having the extra menu to 
control Blur is "necessary." However, I see value in having it in our KCMs or 
as part of an effect. One thing that this patch accomplishes is to have a 
blurred effect consistent in more areas of the desktop. While now we are able 
to make windows transparent and blur them, an option to have menus follow that 
convention is not present. Imagine that maybe a window style or theme allows 
transparency but that the menus don't look well with the preset and you would 
like to change it independently, There is no option for that. My thought is 
that if is about theme/style consistency, this makes sense to have. I feel, 
however, that it fits better in a KCM or as part of the transparency effect 
options. Thoughts anyone else in the VDG? @colomar , @ngraham , @andreask

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma, #vdg
Cc: abetts, colomar, andreask, zzag, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Andres Betts]

abetts removed a reviewer: abetts.
This revision now requires review to proceed.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma, #vdg
Cc: zzag, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Dear Andy, 
  With all due respect, please stop "accepting" revisions. Revisions should be 
accepted by the code maintainer, who then endorse the responsibility that the 
code then remains in a workable state forever after. You are not the breeze 
maintainer. 
  In my understanding at least, accepting a revision allows the submitter to 
commit the code as is (as in "this revision is now accepted and ready to land").
  In the current state, this revision is _not_ accepted and ready to land.
  
  You can, of course, vote +1 or -1 to a change, and it is then up to the 
maintainer to accept/reject/request changes to the revision, taking into 
account (or not), your +1s or -1s.
  
  Thanks in advance,
  
  Hugo

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma, #vdg, abetts
Cc: zzag, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Andres Betts]

abetts accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma, #vdg, abetts
Cc: zzag, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Hello, 
  Hi, 
  thanks for the patch !
  
  Few comments:
  1/ the code does not compile under kde4 (cmake -DUSE_KDE4). You would need to 
use the proper #ifdef to prevent this
  
  2/ I think the "blur" option should go. Blur should be controlled centrally 
by the desktop effect. In other words: BlurBehind should always be set to true, 
and then left to kwin to handle. Having an extra option here seems like 
micro-management. Why would you need blur behind plasma widgets (as handled by 
the desktop effect) and not behind menus ? (or vice versa). Also, right now, 
selecting "blur" in the style settings, but unselecting the desktop effect 
results in no blur behind menu, and hence inconsistency with what the style 
option says.
  
  3/ the slider should follow the same convention and design as for the 
translucency effect: "transparent  opaque".  0% should be 
transparent, 100% should be opaque. 
  Also, should have the same granularity, so ... percents. (not 10%)
  
  4/ I would really like the VDG opinion on this. IMHO I am not sure if it fits 
the breeze "guidelines" or design-ideas, in the sense that I do not know why 
this is needed (what is the use case), aside from "this is pretty".
  
  In other words: why would one need to be able to see what is behind the menu 
you are currently navigating ? 
  Navigating a menu is a very focused thing one wants to do: one is looking for 
a specific action to perform on the current content of the window. To me at 
least, seeing-through the menu is more a distraction to this task than anything 
else. (and adding blur to reduce this distraction would in fact go in the 
direction of not being translucent at all).
  
  If the only reason is "this is pretty", then this has to be balanced with the 
extra option, code complexity, and configurations to be tested on the 
maintainer side, that this patch adds.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma, #vdg
Cc: zzag, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10193: use proper padding for list contents

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:2644e5773030: use proper padding for list contents 
(authored by mart).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10193?vs=26216&id=26259

REVISION DETAIL
  https://phabricator.kde.org/D10193

AFFECTED FILES
  discover/qml/SourcesPage.qml

To: mart, #kirigami, #discover_software_store, apol
Cc: apol, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, davidedmundson, mart, hein

D10188: Sanitise notification HTML

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5bc696b5abcd: Sanitise notification HTML (authored by 
davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10188?vs=26251&id=26252#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10188?vs=26251&id=26252

REVISION DETAIL
  https://phabricator.kde.org/D10188

AFFECTED FILES
  dataengines/notifications/CMakeLists.txt
  dataengines/notifications/notifications_test.cpp
  dataengines/notifications/notificationsanitizer.cpp
  dataengines/notifications/notificationsanitizer.h
  dataengines/notifications/notificationsengine.cpp

To: davidedmundson, #plasma, fvogt
Cc: aacid, fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10188: Sanitise notification HTML

[Fabian Vogt]

fvogt accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10188

To: davidedmundson, #plasma, fvogt
Cc: aacid, fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10188: Sanitise notification HTML

[David Edmundson]

davidedmundson updated this revision to Diff 26251.
davidedmundson added a comment.


  One extra test

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10188?vs=26248&id=26251

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10188

AFFECTED FILES
  dataengines/notifications/CMakeLists.txt
  dataengines/notifications/notifications_test.cpp
  dataengines/notifications/notificationsanitizer.cpp
  dataengines/notifications/notificationsanitizer.h
  dataengines/notifications/notificationsengine.cpp

To: davidedmundson, #plasma, fvogt
Cc: aacid, fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9835: Bump min cmake version to 3.0

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:fc53e3420188: Bump min cmake version to 3.0 (authored by 
kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D9835?vs=25197&id=26250#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9835?vs=25197&id=26250

REVISION DETAIL
  https://phabricator.kde.org/D9835

AFFECTED FILES
  CMakeLists.txt

To: kossebau, #plasma, jriddell, davidedmundson
Cc: davidedmundson, hein, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 - Build # 31 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/31/
 Project:
Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 31 Jan 2018 14:03:28 +
 Build duration:
9 min 30 sec and counting
   CONSOLE OUTPUT
  [...truncated 852.23 KB...]/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/autotests/configmodeltest.cpp:34:46: warning: 'loadPlasmoid' is deprecated [-Wdeprecated-declarations]Plasma::Applet *applet = Plasma::Applet::loadPlasmoid(QFINDTESTDATA("data/testconfigpackage")); ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/applet.h:332:38: note: 'loadPlasmoid' has been explicitly marked deprecated herePLASMA_DEPRECATED static Applet *loadPlasmoid(const QString &path, uint appletId = 0); ^Scanning dependencies of target plasma_appletscript_declarative[ 87%] Linking CXX executable ../bin/dialogstatetest101 warnings generated./usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/autotests/configmodeltest.cpp:61:46: warning: 'loadPlasmoid' is deprecated [-Wdeprecated-declarations]Plasma::Applet *applet = Plasma::Applet::loadPlasmoid(QFINDTESTDATA("data/testconfigpackage")); ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/applet.h:332:38: note: 'loadPlasmoid' has been explicitly marked deprecated herePLASMA_DEPRECATED static Applet *loadPlasmoid(const QString &path, uint appletId = 0); ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/autotests/configmodeltest.cpp:83:50: warning: 'loadPlasmoid' is deprecated [-Wdeprecated-declarations]Plasma::Applet *applet = Plasma::Applet::loadPlasmoid(pkgPath); ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/applet.h:332:38: note: 'loadPlasmoid' has been explicitly marked deprecated herePLASMA_DEPRECATED static Applet *loadPlasmoid(const QString &path, uint appletId = 0); ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/autotests/configmodeltest.cpp:103:50: warning: 'loadPlasmoid' is deprecated [-Wdeprecated-declarations]Plasma::Applet *applet = Plasma::Applet::loadPlasmoid(pkgPath); ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/applet.h:332:38: note: 'loadPlasmoid' has been explicitly marked deprecated herePLASMA_DEPRECATED static Applet *loadPlasmoid(const QString &path, uint appletId = 0); ^Scanning dependencies of target corebindingsplugin[ 87%] Building CXX object src/scriptengines/qml/CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/declarativeappletscript.cpp.o[ 88%] Building CXX object autotests/CMakeFiles/configmodeltest.dir/configmodeltest_autogen/mocs_compilation.cpp.o[ 89%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/corebindingsplugin.cpp.o[ 89%] Built target dialogstatetest[ 90%] Building CXX object src/scriptengines/qml/CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/appletinterface.cpp.o4 warnings generated.[ 90%] Building CXX object src/scriptengines/qml/CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/containmentinterface.cpp.o[ 90%] Linking CXX executable ../bin/packagestructuretest[ 90%] Linking CXX executable ../bin/configmodeltest[ 91%] Building CXX object src/scriptengines/qml/CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/wallpaperinterface.cpp.o[ 91%] Built target packagestructuretest[ 91%] Building CXX object src/scriptengines/qml/CMakeFiles/plasma_appletscript_declarative.dir/plasma_appletscript_declarative_autogen/mocs_compilation.cpp.o/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/scriptengines/qml/plasmoid/containmentinterface.cpp:556:26: warning: unused variable 'choice' [-Wunused-variable]QAction *choice = choices->exec(window() ? window()->mapToGlobal(QPoint(x, y)) : QPoint(x, y)); ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/scriptengines/qml/plasmoid/containmentinterface.cpp:572:12: warning: unused variable 'choices' [-Wunused-variable]QMenu *choices = m_dropMenus.take(job);   ^[ 91%] Built target configmodeltest[ 91%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/colorscope.cpp.o/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/scriptengines/qml/plasmoid/containmentin

KDE CI: Plasma plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 30 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/30/
 Project:
Plasma plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 31 Jan 2018 14:03:28 +
 Build duration:
8 min 41 sec and counting
   CONSOLE OUTPUT
  [...truncated 848.56 KB...]/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/autotests/configmodeltest.cpp:34:46: warning: 'loadPlasmoid' is deprecated [-Wdeprecated-declarations]Plasma::Applet *applet = Plasma::Applet::loadPlasmoid(QFINDTESTDATA("data/testconfigpackage")); ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/applet.h:332:38: note: 'loadPlasmoid' has been explicitly marked deprecated herePLASMA_DEPRECATED static Applet *loadPlasmoid(const QString &path, uint appletId = 0); ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/autotests/configmodeltest.cpp:61:46: warning: 'loadPlasmoid' is deprecated [-Wdeprecated-declarations]Plasma::Applet *applet = Plasma::Applet::loadPlasmoid(QFINDTESTDATA("data/testconfigpackage")); ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/applet.h:332:38: note: 'loadPlasmoid' has been explicitly marked deprecated herePLASMA_DEPRECATED static Applet *loadPlasmoid(const QString &path, uint appletId = 0); ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/autotests/configmodeltest.cpp:83:50: warning: 'loadPlasmoid' is deprecated [-Wdeprecated-declarations]Plasma::Applet *applet = Plasma::Applet::loadPlasmoid(pkgPath); ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/applet.h:332:38: note: 'loadPlasmoid' has been explicitly marked deprecated herePLASMA_DEPRECATED static Applet *loadPlasmoid(const QString &path, uint appletId = 0); ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/autotests/configmodeltest.cpp:103:50: warning: 'loadPlasmoid' is deprecated [-Wdeprecated-declarations]Plasma::Applet *applet = Plasma::Applet::loadPlasmoid(pkgPath); ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/applet.h:332:38: note: 'loadPlasmoid' has been explicitly marked deprecated herePLASMA_DEPRECATED static Applet *loadPlasmoid(const QString &path, uint appletId = 0); ^[ 87%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/colorscope.cpp.o[ 88%] Building CXX object autotests/CMakeFiles/dialogstatetest.dir/dialogstatetest_autogen/mocs_compilation.cpp.o[ 88%] Linking CXX executable ../bin/dialogqmltest4 warnings generated.[ 88%] Linking CXX executable ../bin/configmodeltest[ 89%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/datamodel.cpp.o[ 89%] Linking CXX executable ../bin/dialogstatetest[ 89%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/datasource.cpp.o[ 90%] Built target dialogstatetest[ 90%] Building CXX object autotests/CMakeFiles/packagestructuretest.dir/packagestructuretest_autogen/mocs_compilation.cpp.o[ 90%] Built target dialogqmltest[ 90%] Built target configmodeltest[ 90%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/fadingnode.cpp.o[ 91%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/svgitem.cpp.o[ 92%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/framesvgitem.cpp.oScanning dependencies of target plasma_appletscript_declarative[ 92%] Building CXX object src/scriptengines/qml/CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/declarativeappletscript.cpp.o[ 92%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/quicktheme.cpp.o[ 93%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/tooltipdialog.cpp.o[ 93%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/tooltip.cpp.o[ 93%] Linking CXX executable ../bin/packagestructuretest[ 94%] Building CXX object src/scriptengines/qml/CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/appletinterface.cpp.o[ 94%] Building CXX object src/scriptengines/qml/CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/containmentinterface.cpp.o[ 94%] Built target packagestructuretest[ 95%] Building CXX object src/scriptengines/qml/CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/wallpaperinterface.cpp.o/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/scr

D10173: windowthumbnail: Fix the GLXFBConfig selection code

[Fredrik Höglund]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:46121d58484c: windowthumbnail: Fix the GLXFBConfig 
selection code (authored by fredrik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10173?vs=26165&id=26249

REVISION DETAIL
  https://phabricator.kde.org/D10173

AFFECTED FILES
  src/declarativeimports/core/windowthumbnail.cpp
  src/declarativeimports/core/windowthumbnail.h

To: fredrik, #plasma
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 111 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/111/
 Project:
Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 31 Jan 2018 12:42:27 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kcm-keyboard-iso_codes

D9835: Bump min cmake version to 3.0

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Please verify our CI has 3.0 first.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  bumpcmakeversiondep

REVISION DETAIL
  https://phabricator.kde.org/D9835

To: kossebau, #plasma, jriddell, davidedmundson
Cc: davidedmundson, hein, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10200: base listitemdelegate color on selected, not checked

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> DefaultListItemBackground.qml:25
>  id: background
> -color: listItem.checked || (listItem.supportsMouseEvents && 
> listItem.pressed && !listItem.checked && !listItem.sectionDelegate) ? 
> (internal.indicateActiveFocus ? listItem.activeBackgroundColor : 
> Qt.tint(listItem.backgroundColor, Qt.rgba(listItem.activeBackgroundColor.r, 
> listItem.activeBackgroundColor.g, listItem.activeBackgroundColor.b, 0.3))) : 
> listItem.backgroundColor
> +color: listItem.selected || (listItem.supportsMouseEvents && 
> listItem.pressed && !listItem.selected && !listItem.sectionDelegate) ? 
> (internal.indicateActiveFocus ? listItem.activeBackgroundColor : 
> Qt.tint(listItem.backgroundColor, Qt.rgba(listItem.activeBackgroundColor.r, 
> listItem.activeBackgroundColor.g, listItem.activeBackgroundColor.b, 0.3))) : 
> listItem.backgroundColor
>  

the bug is actually in that Qt.tint() call which was trying to generate the 
inactive selection color, but is wrong.

the background color should still change like it did, like everything else 
(like the dolphin sidebar does for instance) if we want to disable it, we 
should disable it globally, and is a checkbox in the colors kcm

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10200

To: sebas, hein, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D10188: Sanitise notification HTML

[David Edmundson]

davidedmundson updated this revision to Diff 26248.
davidedmundson added a comment.


  Added const
  Added two new unit test rows

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10188?vs=26213&id=26248

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D10188

AFFECTED FILES
  dataengines/notifications/CMakeLists.txt
  dataengines/notifications/notifications_test.cpp
  dataengines/notifications/notificationsanitizer.cpp
  dataengines/notifications/notificationsanitizer.h
  dataengines/notifications/notificationsengine.cpp

To: davidedmundson, #plasma, fvogt
Cc: aacid, fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10197: Fix krunner's alt+f2 on wayland

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:fc5a45403025: Fix krunner's alt+f2 on wayland 
(authored by apol).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10197?vs=26233&id=26247

REVISION DETAIL
  https://phabricator.kde.org/D10197

AFFECTED FILES
  krunner/view.cpp
  krunner/view.h

To: apol, #plasma, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9984: WIP: Add bookmarks runner

[Sebastian Kügler]

sebas added a comment.


  That's what the "old" bookmarks runner was doing, it loaded the bookmarks 
from the file the browsers write out.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D9984

To: broulik, #plasma, #vdg, davidedmundson
Cc: sebas, abetts, mart, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, apol

D10200: base listitemdelegate color on selected, not checked

[Sebastian Kügler]

sebas created this revision.
sebas added reviewers: hein, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
sebas requested review of this revision.

REVISION SUMMARY
  I can't say that I'm grasping the logic here completely, but...
  
  In systemsettings, the delegates for categories change color after being
  clicked a second time. As far as I understand, this happens because
  they're checked the first time clicked, then unchecked. The seond time
  clicked should leave them selected (and thus in the same color), and the
  reverse logic is to base the color on the selected property, not the
  checked property.
  
  Am I correct, though?

TEST PLAN
  started system settings, selected a category, selected the same category, 
color stays the same

REPOSITORY
  R169 Kirigami

BRANCH
  sebas/syselistitemdelegate

REVISION DETAIL
  https://phabricator.kde.org/D10200

AFFECTED FILES
  src/controls/BasicListItem.qml
  src/controls/private/DefaultListItemBackground.qml

To: sebas, hein, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 110 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/110/
 Project:
Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 31 Jan 2018 08:11:27 +
 Build duration:
4 min 39 sec and counting
   CONSOLE OUTPUT
  [...truncated 546.37 KB...]Unknown property type for key "X-KDE-Keywords[en_GB]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[es]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[et]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[eu]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[fi]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[fr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ga]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[gl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[he]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[hu]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ia]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[id]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[is]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[it]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ja]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[kk]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[km]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ko]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[lt]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[mr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[nb]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[nds]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[nl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[nn]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[pa]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[pl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[pt]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[pt_BR]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ro]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ru]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sk]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@ijekavian]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@ijekavianlatin]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@latin]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sv]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[tr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ug]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[uk]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[vi]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[x-test]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[zh_CN]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[zh_TW]" -> falling back to stringGenerated  "/usr/home/jenkins/workspace/Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9/build/kcms/desktoptheme/kcm_desktoptheme.json" [ 10%] Automatic MOC for target kcm_desktoptheme[ 10%] Built target kcm_desktoptheme_autogenScanning dependencies of target kcm_standard_actions_autogen[ 10%] Automatic MOC for target kcm_standard_actions[ 10%] Built target kcm_standard_actions_autogenScanning dependencies of target kcm_keys_autogen[ 10%] Automatic MOC for target kcm_keys[ 10%] Built target kcm_keys_autogenScanning dependencies of target kcm_smserver_autogen[ 11%] Automatic MOC for target kcm_smserver[ 11%] Built target kcm_smserver_autogenScanning dependencies of target kcm_lookandfeel-kcms-metadata-json[ 12%] Generating kcm_lookandfeel-kcms-metadata.jsonAbout to parse service type file "/usr/home/jenkins/install-prefix/share/kservicetypes5/plasma-generic.desktop"Unknown property type for key "Keywords" -> falling back to stringUnknown property type for key "X-KDE-ParentApp" -> falling back to stringUnknown property type for key "X-Plasma-API" -> falling back to stringUnknown property type for key "X-Plasma-MainScript" -> falling back to stringUnknown property type for key "X-Plasma-RemoteLocation" -> falling back to stringGenerated  "/usr/home/jenkins/wor

D6392: [Panel Config] Scrolling over size button increments size by 2 and shows current thickness

[Chris Holland]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:586797610e08: [Panel Config] Scrolling over size button 
increments size by 2 and shows… (authored by Zren).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6392?vs=24808&id=26235

REVISION DETAIL
  https://phabricator.kde.org/D6392

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: Zren, #plasma, davidedmundson
Cc: ngraham, mmustac, davidedmundson, broulik, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart