D10512: try to preload certain applets in a smart way

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> mart wrote in appletquickitem.cpp:57-68
> > So Adaptive can a default even environment variable is not setted?
> 
> yes, adaptive is the default
> 
> > Furthermore you can make a static function to access value
> 
> it's done anyways only once as preloadPolicy is already a static?

But if PLASMA_PRELOAD_POLICY is not setted s_preloadPolicy stays Uninitialized, 
no? But since you check against >= Adaptive it's still ok :)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: anthonyfieroni, davidedmundson, broulik, apol, ngraham, plasma-devel, 
#frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

[Ivan Čukić]

ivan requested changes to this revision.
ivan added a comment.
This revision now requires changes to proceed.


  Well, in a library that 99% relies on a database, having no database is not 
something that can be gracefully handled (the returned nullptr is asserted on 
as well in the function that calls ::instance in ResultSet :) - because of 
this, I'm changing to 'Request Changes').
  
  Graceful handling instead of qFatal/Q_ASSERT could be implemented so that all 
models and queries return empty sets. Which would be useless, but as I said, I 
don't have anything against that.
  
  When we get the bug reports about empty favourites, there will be an 
additional test step "Hi, do you have this message in the plasmashell output 
'Database can not be opened...'" :)

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D10691

To: kpiwowarski, #plasma, #frameworks, hein, ivan
Cc: ivan, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

[Eike Hein]

hein added a comment.


  @ivan So you wrote a method that can return null, but the call sites aren't 
actually prepared to handle that gracefully? :) But I was waiting for your 
review for that context.

REPOSITORY
  R159 KActivities Statistics

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10691

To: kpiwowarski, #plasma, #frameworks, hein
Cc: ivan, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Plasma 5.12.2

[Jonathan Riddell]

A week's worth of bugfixes is now available for packaging

https://www.kde.org/announcements/plasma-5.12.2.php

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

[Ivan Čukić]

ivan added a comment.


  @hein
  
  This is not really as simple as 'accept without a comment'.
  
  I don't mind this patch to be merged, but keep in mind that it just turns 
users for which plasma crashes (for which we get an explicit message as to why) 
into users who do not have certain parts of Plasma working where the error 
message will get lost in the Plasma's log. Now, as a maintainer of said parts 
of Plasma, that is your call.

REPOSITORY
  R159 KActivities Statistics

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10691

To: kpiwowarski, #plasma, #frameworks, hein
Cc: ivan, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: What does LTS mean again?

[Jonathan Riddell]

On Tue, Feb 20, 2018 at 09:13:42PM +0100, Sebastian Kügler wrote:
> Hi,
> 
> I know we talked about it extensively and even put it into writing, but I 
> can't find it anymore. What does our LTS promise for 5.12 entail?

Bugfix releases happen over a longer term.

https://community.kde.org/Schedules/Plasma_5

Jonathan

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

[Andreas Krutzler]

akrutzler added a comment.


  Not yet, @ngraham did all the commits for me so far. Just in case, my email 
is andreas.krutz...@gmx.net :)

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10701

To: akrutzler, apol, ngraham, #discover_software_store
Cc: davidedmundson, acrouthamel, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

[David Edmundson]

davidedmundson added a comment.


  Do you have commit access?

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10701

To: akrutzler, apol, ngraham, #discover_software_store
Cc: davidedmundson, acrouthamel, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

[Andreas Krutzler]

akrutzler added a comment.


  The gifs were the hardest part :)

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10701

To: akrutzler, apol, ngraham, #discover_software_store
Cc: acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10681: preload the expander (the dialog) too

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> appletquickitem.cpp:295
> +qint64 time = 0;
> +if (QLoggingCategory::defaultCategory()->isInfoEnabled()) {
> +time = QDateTime::currentMSecsSinceEpoch();

You should check the PlasmaQuick category, not the default one

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10681

To: mart, #plasma, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10692: parent full representation to the proper window at start

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> Menu.qml:36
> +//which makes quite a visual difference when this plasmoid gets 
> preloaded (ensures it actually gets preloaded fully)
> +Component.onCompleted: menuListView.forceLayout()
>  ListView {

Would that also help Kickoff's initial opening?

Also see D10557  which makes a huge 
difference without that..

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10692

To: mart, #plasma
Cc: broulik, hein, davidedmundson, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10557: [Clipboard plasmoid] Split delegate into separate files

[Kai Uwe Broulik]

broulik updated this revision to Diff 27647.
broulik added a comment.


  Remove debug

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10557?vs=27298=27647

REVISION DETAIL
  https://phabricator.kde.org/D10557

AFFECTED FILES
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml
  applets/clipboard/contents/ui/DelegateToolButtons.qml
  applets/clipboard/contents/ui/ImageItemDelegate.qml
  applets/clipboard/contents/ui/TextItemDelegate.qml
  applets/clipboard/contents/ui/UrlItemDelegate.qml

To: broulik, #plasma, graesslin
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

[Andrew Crouthamel]

acrouthamel added a comment.


  Super nice, thanks!

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10701

To: akrutzler, apol, ngraham, #discover_software_store
Cc: acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10591: forcefully activate popup windows when they open

[Kai Uwe Broulik]

broulik added a comment.


  If we were to do this, we need to first make Device Notifier not freak out 
when you have a wonky USB cable.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10591

To: mart, #plasma
Cc: broulik, davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

[Nathaniel Graham]

ngraham added a reviewer: Discover Software Store.
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Beautiful! Lovely gif too. Thanks for that.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10701

To: akrutzler, apol, ngraham, #discover_software_store
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10499: [spellcheck runner] Make each suggestion copyable as separate item

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  >   and then copy the correct or suggested into the clipboard for further 
usage?
  
  Calculator runner does `setText` on `QClipboard` in `run`, so I guess this is 
the way.
  `InformationalMatch` causes the `data` to be set as query when run. Pick your 
poison.

INLINE COMMENTS

> spellcheck.cpp:225
> +match.setText(query);
> +match.setSubtext(i18n("Correct"));
> +match.setData(query);

Add some context, "Correct" could also be a verb

REPOSITORY
  R114 Plasma Addons

BRANCH
  spellrunnerMakeTermsCopyable

REVISION DETAIL
  https://phabricator.kde.org/D10499

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

[Andreas Krutzler]

akrutzler edited the summary of this revision.
akrutzler added reviewers: apol, ngraham.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10701

To: akrutzler, apol, ngraham
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10697: Make the badge text readable on dark color schemes

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Thanks! I assume you tested it with a light color scheme also. 5.12 branch pls

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10697

To: mwolff, broulik, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

[Andreas Krutzler]

akrutzler created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
akrutzler requested review of this revision.

REVISION SUMMARY
  If you're using Breeze Dark or probably any other dark theme, the screenshot 
shadow-gradient will run from white to transparent. With this patch, the shadow 
runs from the currently set background color to transparent.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10701

AFFECTED FILES
  discover/qml/Shadow.qml

To: akrutzler
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10697: Make the badge text readable on dark color schemes

[Milian Wolff]

mwolff added a comment.


  using breeze high contrast here, before:
  
  F5720670: Screenshot_20180220_211956.png 

  
  after:
  
  F5720669: Screenshot_20180220_212030.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10697

To: mwolff, broulik, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10697: Make the badge text readable on dark color schemes

[Milian Wolff]

mwolff created this revision.
mwolff added reviewers: broulik, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mwolff requested review of this revision.

REVISION SUMMARY
  The background color should not be used for the foreground text
  color, I believe. The background color is set to theme.highlightColor,
  so use theme.highlightedTextColor for the foreground. This ensures
  the text is readable on a dark color scheme.

TEST PLAN
  unreadable text before, readable now

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10697

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Badge.qml

To: mwolff, broulik, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

What does LTS mean again?

[Sebastian Kügler]

Hi,

I know we talked about it extensively and even put it into writing, but I 
can't find it anymore. What does our LTS promise for 5.12 entail?

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org

D10692: parent full representation to the proper window at start

[Eike Hein]

hein added a comment.


  It does use it btw, just not for subdialogs.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10692

To: mart, #plasma
Cc: hein, davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10692: parent full representation to the proper window at start

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in ExpandedRepresentation.qml:29
> How does this avoid a useless Dialog resize?

otherwise mainItem starts being sized 0x0, then on Dialog showevent, it 
searches for its Layout property and resizes it based on that, this makes the 
resize being a noop which seems a sensible micro optimization

> davidedmundson wrote in systemtray.cpp:346
> why did this need special code, but kicker (not kickoff) which also does its 
> own didn't?

ah, if kicker doesn't use expandedrepresentation then it's not done there, 
tough i feel that whether qwindow::create is actually useful or not really 
would need better profiling, which i'm not sure how to do

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10692

To: mart, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10695: dont initialize app menu index in every hiding

[Michail Vourlakos]

mvourlakos created this revision.
mvourlakos added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mvourlakos requested review of this revision.

REVISION SUMMARY
  - hiding a menu shouldnt initialize the currentIndex to -1
  
  at all cases. When a secondary menu is already shown then
  the currentIndex should be only the index of the new menu.
  This improves also the qml bindings because currentIndex
  doesnt change all the time with no reason.

TEST PLAN
  added debug messages in qml side to check the value of
  currentIndex

REPOSITORY
  R120 Plasma Workspace

BRANCH
  global

REVISION DETAIL
  https://phabricator.kde.org/D10695

AFFECTED FILES
  applets/appmenu/lib/appmenuapplet.cpp

To: mvourlakos, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10692: parent full representation to the proper window at start

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> ExpandedRepresentation.qml:29
>  
> +//set width/height to avoid an useless Dialog resize
> +width: Layout.minimumWidth

How does this avoid a useless Dialog resize?

> systemtray.cpp:346
>  
> +void SystemTray::createPopup(QQuickWindow *window)
> +{

why did this need special code, but kicker (not kickoff) which also does its 
own didn't?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10692

To: mart, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10692: parent full representation to the proper window at start

[Marco Martin]

mart updated this revision to Diff 27633.
mart added a comment.


  - forces delegates creation in the item view

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10692?vs=27627=27633

BRANCH
  phab/preloadsystray

REVISION DETAIL
  https://phabricator.kde.org/D10692

AFFECTED FILES
  applets/clipboard/contents/ui/Menu.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/main.qml
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h

To: mart, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10594: Disable window rule configuration for Wayland

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  In D10594#209972 , @mart wrote:
  
  > window rules is a feature which would "just" require the kcm 
reimplementation or as a principle is something which can't work on wayland?
  
  
  See D10490 

REPOSITORY
  R108 KWin

BRANCH
  disable-rules-5.12

REVISION DETAIL
  https://phabricator.kde.org/D10594

To: graesslin, #kwin, #plasma, davidedmundson
Cc: mart, plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol

D10490: Add a method to dbus interface to query information about a window

[Martin Flöser]

Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10490

To: graesslin, #kwin, #plasma
Cc: davidedmundson, broulik, plasma-devel, kwin, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, iodelay, bwowk, 
hardening

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

[Rog131]

https://bugs.kde.org/show_bug.cgi?id=369676

--- Comment #12 from Rog131  ---
(In reply to Navid Zamani from comment #11)
> (In reply to Rog131 from comment #10)
> > The Breeze text color can be set from the KDE system settings > Colors >
> > Complementary > Normal text.
> 
> That doesn’t actually work. I just changed that color from white to black,
> saved it as a new scheme, closed the dialog, selected my new scheme from the
> list, and clicked “Apply”. Then I locked the screen, and … nothing had
> changed.
> Also, the white text isn’t actually fully white by default either.
> 
> And the actual full path is K → System settings → Colors → Change scheme →
> Color selection [tab] → Color set [dropdown] (Generic colors ⇒
> Complementary) → Normal text.
> (This is translated from German, so YMMV.)
> You need to save the scheme as a new one, because the „Apply“ button inside
> the scheme editing dialog does nothing, and your changes will be lost
> otherwise.
> 
> Or do I need to restart something or log out once?
> 
> How did you make that screenshot by the way? The dialog is on top of the
> lock screen. Photoshop^WGimp, or is there a way to test the lock screen?

KDE Forums - KDE Plasma lockscreen colors and testing lock screen:
https://forum.kde.org/viewtopic.php?f=14=151172

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10594: Disable window rule configuration for Wayland

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

BRANCH
  disable-rules-5.12

REVISION DETAIL
  https://phabricator.kde.org/D10594

To: graesslin, #kwin, #plasma, davidedmundson
Cc: mart, plasma-devel, kwin, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, iodelay, bwowk, hardening

D10628: Optional barcodes in libprison

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10628

To: svuorela, graesslin, vkrause, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10692: parent full representation to the proper window at start

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  this avoids some unwanted scene changes and speeds up the
  first open a bit, also initialize the size of the dialog main item
  so there is a resize less when the Dialog is first shown

TEST PLAN
  difference in show time is already visible, tough still not perfect,
  something else needs to improve as well

REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/preloadsystray

REVISION DETAIL
  https://phabricator.kde.org/D10692

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/main.qml
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h

To: mart, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

[Eike Hein]

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R159 KActivities Statistics

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10691

To: kpiwowarski, #plasma, #frameworks, hein
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10691: Fix plasmashell crash when database is broken

[Nathaniel Graham]

ngraham added reviewers: Plasma, Frameworks.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D10691

To: kpiwowarski, #plasma, #frameworks
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

[Kamil Piwowarski]

kpiwowarski retitled this revision from "Fix plasmashell crash when database is 
broken" to "[kactivities-stats] Fix plasmashell crash when database is broken".

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D10691

To: kpiwowarski, #plasma, #frameworks
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

[Vlad Zagorodniy]

zzag added a comment.


  In D10588#210276 , @hein wrote:
  
  > No, you weren't: "What's the point of the desktop if it is not possible to 
place folder, pictures, music, etc on it?"
  
  
  That was a rhetorical question, which apparently, causes misunderstanding. 
Sorry.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10588

To: jriddell, #plasma
Cc: ngraham, broulik, hein, mart, zzag, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

[Eike Hein]

hein added a comment.


  No, you weren't: "What's the point of the desktop if it is not possible to 
place folder, pictures, music, etc on it?"

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10588

To: jriddell, #plasma
Cc: ngraham, broulik, hein, mart, zzag, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

[Vlad Zagorodniy]

zzag added a comment.


  > This isn't about disabling support for icons (we just turned that back on 
in 5.10 ...), it's about not creating the Home and Trash icons by default on 
first login.
  
  I'm talking about not creating home and trash icons by default.(not disabling 
folder view)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10588

To: jriddell, #plasma
Cc: ngraham, broulik, hein, mart, zzag, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

[Eike Hein]

hein added a comment.


  This isn't about disabling support for icons (we just turned that back on in 
5.10 ...), it's about not creating the Home and Trash icons by default on first 
login.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10588

To: jriddell, #plasma
Cc: ngraham, broulik, hein, mart, zzag, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

[Nathaniel Graham]

ngraham added a comment.


  In D10588#210246 , @zzag wrote:
  
  > > This seems like the sort of things that developers prefer for 
"cleanliness", at the expense of messy ordinary users who like putting junk all 
over their desktop.
  >
  > What's the point of the desktop if it is not possible to place folder, 
pictures, music, etc on it?
  
  
  That's not changing.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10588

To: jriddell, #plasma
Cc: ngraham, broulik, hein, mart, zzag, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

[Vlad Zagorodniy]

zzag added a comment.


  > This seems like the sort of things that developers prefer for 
"cleanliness", at the expense of messy ordinary users who like putting junk all 
over their desktop.
  
  What's the point of the desktop if it is not possible to place folder, 
pictures, music, etc on it?
  
  Also, someone could say: "It's Plasma, you can put trash icon back!"
  The Trash can widget looks different from the default trash can icon + other 
folder icons(blurry, etc).
  
  So, please, let home and trash icons stay on the desktop by default.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10588

To: jriddell, #plasma
Cc: ngraham, broulik, hein, mart, zzag, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10475: Make it possible to show the title despite having ctx actions

[Aleix Pol Gonzalez]

apol updated this revision to Diff 27623.
apol added a comment.


  Rebase on master

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10475?vs=27167=27623

BRANCH
  arcpatch-D10475

REVISION DETAIL
  https://phabricator.kde.org/D10475

AFFECTED FILES
  src/controls/ToolBarApplicationHeader.qml

To: apol, #kirigami, mart, ngraham, abetts
Cc: rkflx, mart, ngraham, plasma-devel, apol, davidedmundson, hein

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

[Nathaniel Graham]

ngraham added a comment.


  Heh, okay.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10588

To: jriddell, #plasma
Cc: ngraham, broulik, hein, mart, zzag, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

[Eike Hein]

hein added a comment.


  This is just following up on a public promise we already made. When we turned 
Folder View into the default desktop containment, we told everyone (and got a 
lot of positive feedback from the users for it) that this means the desktop 
surface now supports icons by default again, but we don't actually place any by 
default so it's not having any impact on the people who prefer an empty desktop 
by default. Then it turns out we actually forgot to change the code.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10588

To: jriddell, #plasma
Cc: ngraham, broulik, hein, mart, zzag, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

[Nathaniel Graham]

ngraham added a comment.


  Memes aside, I have to agree. This seems like the sort of things that 
developers prefer for "cleanliness", at the expense of messy ordinary users who 
putting junk all over their desktop.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10588

To: jriddell, #plasma
Cc: ngraham, broulik, hein, mart, zzag, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

Re: QtWayland decoration improvement

[Marco Martin]

On lunedì 19 febbraio 2018 16:37:55 CET Martin Bříza wrote:
> And even less complicated way would be to just do my own thing in
> QGnomePlatform and support only the decorations I wrote myself.
> 
> Which one is the best one, according to you, please? I'm open to every
> suggestion.

using kdecoration2 would feel just right


-- 
Marco Martin

D10686: [DesktopNotifier] Notify change for any link to trash:/

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  With removal of default Trash and D10684  
users can add the Trash link back themselves. The file name isn't neccessarily 
"Trash.desktop", though, so check all desktop files for that when trash state 
changes.

TEST PLAN
  Placed a second Trash on my desktop, emptied it, both had their icons change 
immediately

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10686

AFFECTED FILES
  kioslave/desktop/desktopnotifier.cpp

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

[Vlad Zagorodniy]

zzag added a comment.


  > As discussed at 5.13 Kickoff meeting
  
  I asked as an ordinary user. Could you please explain why Home and Trash 
icons should not be on the desktop by default?
  
  These icons are very useful, especially trash icon. I don't have to open 
dolphin just to empty trash can.
  
  Currently, it looks something like this, sorry
  F5720376: trash-removal.jpg 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10588

To: jriddell, #plasma
Cc: broulik, hein, mart, zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D10684: [Drop Job] Create proper trash file on linking

[Eike Hein]

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10684

To: broulik, #frameworks, #plasma, hein
Cc: plasma-devel, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

[Kai Uwe Broulik]

broulik added a comment.


  See D10684  to make it easy for users to 
bring it back

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10588

To: jriddell, #plasma
Cc: broulik, hein, mart, zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D10684: [Drop Job] Create proper trash file on linking

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Plasma wants to remove the default trash icon on the desktop.
  This change ensures dropping Trash from e.g. Dolphin will result in a fully 
functional (i.e. reflecting trash state and proper "Trash" label) trash icon 
being dropped.

TEST PLAN
  Dropped "Trash" place from Dolphin to desktop, got a "Trash" icon with proper 
icon.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10684

AFFECTED FILES
  src/core/copyjob.cpp

To: broulik, #frameworks, #plasma
Cc: plasma-devel, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10475: Make it possible to show the title despite having ctx actions

[Aleix Pol Gonzalez]

apol added a comment.


  Now that we have a menu, we definitely need to look into this.
  
  Without patch: odd
  F5720319: Screenshot_20180220_154236.png 

  
  With patch: still odd
  F5720335: Screenshot_20180220_155606.png 


REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10475

To: apol, #kirigami, mart, ngraham, abetts
Cc: rkflx, mart, ngraham, plasma-devel, apol, davidedmundson, hein

D10197: Fix krunner's alt+f2 on wayland

[Aleix Pol Gonzalez]

apol closed this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10197

To: apol, #plasma, davidedmundson
Cc: graesslin, broulik, ngraham, davidedmundson, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10604: Show the text by the page action tool buttons

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:38a9dec73179: Show the text by the page action tool 
buttons (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10604?vs=27401=27611

REVISION DETAIL
  https://phabricator.kde.org/D10604

AFFECTED FILES
  src/controls/ToolBarApplicationHeader.qml

To: apol, #kirigami, ngraham
Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

D10337: First approach to a plasmoid that can display the state of caps lock

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Quick note before I forget again: doesn't this need some Messages.sh? There 
are some i18n calls in the QML.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10337

To: apol, #plasma, jriddell
Cc: kossebau, graesslin, abetts, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D10589: Make it possible to tweak the sorting of a resources list

[Aleix Pol Gonzalez]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:cd998c2e125a: Make it possible to tweak the sorting of a 
resources list (authored by apol).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10589?vs=27609=27610

REVISION DETAIL
  https://phabricator.kde.org/D10589

AFFECTED FILES
  discover/qml/ApplicationsListPage.qml

To: apol, ngraham
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10589: Make it possible to tweak the sorting of a resources list

[Aleix Pol Gonzalez]

apol updated this revision to Diff 27609.
apol added a comment.


  Addressed Nate's comments

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10589?vs=27363=27609

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10589

AFFECTED FILES
  discover/qml/ApplicationsListPage.qml

To: apol, ngraham
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10613: Make it possible for actions to show submenus

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:dd2886259168: Make it possible for actions to show 
submenus (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10613?vs=27547=27608

REVISION DETAIL
  https://phabricator.kde.org/D10613

AFFECTED FILES
  src/controls/private/ActionsMenu.qml
  src/controls/private/PrivateActionToolButton.qml
  tests/actionsMenu.qml

To: apol, #kirigami, mart
Cc: mart, ngraham, plasma-devel, apol, davidedmundson, hein

D10613: Make it possible for actions to show submenus

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10613

To: apol, #kirigami, mart
Cc: mart, ngraham, plasma-devel, apol, davidedmundson, hein

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

[Eike Hein]

hein added a comment.


  I'll look into it, this week probably

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10588

To: jriddell, #plasma
Cc: hein, mart, zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

[Marco Martin]

mart added a comment.


  +1 from me

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10588

To: jriddell, #plasma
Cc: mart, zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D10586: [Task Manager] Limit badge label to a sane size

[Eike Hein]

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10586

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

[Navid Zamani]

https://bugs.kde.org/show_bug.cgi?id=369676

--- Comment #11 from Navid Zamani  ---
(In reply to Rog131 from comment #10)
> The Breeze text color can be set from the KDE system settings > Colors >
> Complementary > Normal text.

That doesn’t actually work. I just changed that color from white to black,
saved it as a new scheme, closed the dialog, selected my new scheme from the
list, and clicked “Apply”. Then I locked the screen, and … nothing had changed.
Also, the white text isn’t actually fully white by default either.

And the actual full path is K → System settings → Colors → Change scheme →
Color selection [tab] → Color set [dropdown] (Generic colors ⇒ Complementary) →
Normal text.
(This is translated from German, so YMMV.)
You need to save the scheme as a new one, because the „Apply“ button inside the
scheme editing dialog does nothing, and your changes will be lost otherwise.

Or do I need to restart something or log out once?

How did you make that screenshot by the way? The dialog is on top of the lock
screen. Photoshop^WGimp, or is there a way to test the lock screen?

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10681: preload the expander (the dialog) too

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:8346b3e76ab8: preload the expander (the dialog) too 
(authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10681?vs=27605=27606#toc

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10681?vs=27605=27606

REVISION DETAIL
  https://phabricator.kde.org/D10681

AFFECTED FILES
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/private/appletquickitem_p.h

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10681: preload the expander (the dialog) too

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> appletquickitem.cpp:294
> +{
> +qint64 time = QDateTime::currentMSecsSinceEpoch();
> +createFullRepresentationItem();

wrap this line in QLoggingCategory::isInfoEnabled

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/preload

REVISION DETAIL
  https://phabricator.kde.org/D10681

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

[Jonathan Riddell]

jriddell added a comment.


  https://phabricator.kde.org/T7948

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10588

To: jriddell, #plasma
Cc: zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

[Jonathan Riddell]

jriddell added a comment.


  In D10588#207890 , @zzag wrote:
  
  > Why?
  
  
  As discussed at 5.13 Kickoff meeting

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10588

To: jriddell, #plasma
Cc: zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10681: preload the expander (the dialog) too

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  when preloading, preload the expander as well, and reparent the
  full representation to it, so we have a scene schanged less.
  also do a create() of that window (may be worth to do create()
  automatically in every Dialog?)

TEST PLAN
  the first open is visibly a lot faster now

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/preload

REVISION DETAIL
  https://phabricator.kde.org/D10681

AFFECTED FILES
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/private/appletquickitem_p.h

To: mart, #plasma
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10679: Add recipes feature delegates

[Aditya Mehra]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R846:20de58c09c82: Add recipes feature delegates (authored by 
Aiix).

REPOSITORY
  R846 Mycroft Plasma integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10679?vs=27597=27598

REVISION DETAIL
  https://phabricator.kde.org/D10679

AFFECTED FILES
  plasmoid/contents/ui/RecipeDelegate.qml
  plasmoid/contents/ui/RecipeReadDelegate.qml
  plasmoid/contents/ui/RecipeType.qml
  plasmoid/contents/ui/main.qml

To: Aiix, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10679: Add recipes feature delegates

[Aditya Mehra]

Aiix created this revision.
Aiix added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Aiix requested review of this revision.

REVISION SUMMARY
  Ref T8032 Added recipe cards and delegates for Food-Wizard Mycroft Recipes 
skill

REPOSITORY
  R846 Mycroft Plasma integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10679

AFFECTED FILES
  plasmoid/contents/ui/RecipeDelegate.qml
  plasmoid/contents/ui/RecipeReadDelegate.qml
  plasmoid/contents/ui/RecipeType.qml
  plasmoid/contents/ui/main.qml

To: Aiix, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10668: Fix PowerDevil shortcuts migration

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R122:4ae36aee: Fix PowerDevil shortcuts migration 
(authored by davidedmundson).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10668?vs=27594=27596

REVISION DETAIL
  https://phabricator.kde.org/D10668

AFFECTED FILES
  CMakeLists.txt
  daemon/powerdevilapp.cpp
  daemon/powerdevilapp.h
  kconf_update/CMakeLists.txt
  kconf_update/powerdevil_move_shortcuts.upd

To: davidedmundson, #plasma, broulik
Cc: broulik, fvogt, aacid, cfeck, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10610: Fix favicons in firefox bookmarks runner

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:93f0f5ee2c27: Fix favicons in firefox bookmarks runner 
(authored by z3ntu, committed by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10610?vs=27421=27595#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10610?vs=27421=27595

REVISION DETAIL
  https://phabricator.kde.org/D10610

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp
  runners/bookmarks/browsers/firefox.h
  runners/bookmarks/faviconfromblob.cpp

To: z3ntu, #plasma, broulik, davidedmundson
Cc: ngraham, elvisangelaccio, davidedmundson, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10668: Fix PowerDevil shortcuts migration

[David Edmundson]

davidedmundson updated this revision to Diff 27594.
davidedmundson marked 2 inline comments as done.
davidedmundson added a comment.


  Changes

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10668?vs=27574=27594

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10668

AFFECTED FILES
  CMakeLists.txt
  daemon/powerdevilapp.cpp
  daemon/powerdevilapp.h
  kconf_update/CMakeLists.txt
  kconf_update/powerdevil_move_shortcuts.upd

To: davidedmundson, #plasma, broulik
Cc: broulik, fvogt, aacid, cfeck, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10610: Fix favicons in firefox bookmarks runner

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  D10610

REVISION DETAIL
  https://phabricator.kde.org/D10610

To: z3ntu, #plasma, broulik, davidedmundson
Cc: ngraham, elvisangelaccio, davidedmundson, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10668: Fix PowerDevil shortcuts migration

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  lgtm
  
  shipit once you addressed the other comments

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10668

To: davidedmundson, #plasma, broulik
Cc: broulik, fvogt, aacid, cfeck, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10652: [Run Command] Add history drop down button

[Ma Mbele]

mbele added a comment.


  Wonderful! The famous arrow has come back! It should not have been removed in 
the first place!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10652

To: broulik, #plasma, #vdg
Cc: mbele, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: Plasma 5.13 dependencies

[Tobias C. Berner]

Hi Ben


I think we could upgrade the CI to 5.10 "sans webengine" -- which is the
one part we are missing.



mfg Tobias

On 19 February 2018 at 20:17, Ben Cooksley  wrote:

> On 20/02/2018 12:23 AM, "Jonathan Riddell"  wrote:
>
> Hi Jonathan,
>
> Plasma 5.13, due out in June, will depend on Qt 5.10, KDE Frameworks
> 5.46.  The newer Qt will help us port KControl modules to QtQuick
> Controls 2 a target of this release.
> https://phabricator.kde.org/project/view/254/
>
>
> When will this dependency start coming into effect?
>
> While we fortunately already have a Qt 5.10 image for Linux on the CI
> system, I'm not sure what the status is of Qt 5.10 for FreeBSD so a
> timeline for this would be nice.
>
>
>
> Jonathan
>
>
> Cheers,
> Ben
>

D10669: Reduce plasmashell frozen time

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R278 KWindowSystem

BRANCH
  polling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10669

To: jtamate, #plasma, #frameworks, mart
Cc: plasma-devel, davidedmundson, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10594: Disable window rule configuration for Wayland

[Marco Martin]

mart added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  window rules is a feature which would "just" require the kcm reimplementation 
or as a principle is something which can't work on wayland?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10594

To: graesslin, #kwin, #plasma
Cc: mart, plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol

D10512: try to preload certain applets in a smart way

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in appletquickitem.cpp:57-68
> So Adaptive can a default even environment variable is not setted?
> Furthermore you can make a static function to access value
> 
>   AppletQuickItemPrivate::PreloadPolicy AppletQuickItemPrivate::appletPolicy()
>   {
>   static const PreloadPolicy preloadPolicy = []() -> PreloadPolicy {
>   if (qEnvironmentVariableIsSet("PLASMA_PRELOAD_POLICY")) {
>   const QString policy = 
> QString::fromUtf8(qgetenv("PLASMA_PRELOAD_POLICY")).toLower();
>   if (policy == QStringLiteral("aggressive")) {
>   return Aggressive;
>   } else if (policy == QStringLiteral("none")) {
>   return None;
>   }
>   }
>   return Adaptive;
>   }();
>   return preloadPolicy;
>   }

> So Adaptive can a default even environment variable is not setted?

yes, adaptive is the default

> Furthermore you can make a static function to access value

it's done anyways only once as preloadPolicy is already a static?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: anthonyfieroni, davidedmundson, broulik, apol, ngraham, plasma-devel, 
#frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D10668: Fix PowerDevil shortcuts migration

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> davidedmundson wrote in powerdevilapp.cpp:177
> You'd think so, but no.
> 
> setShortcut(QAction, sequence, KGlobalAccel::NoAutoloading)   
> would do exactly that
> 
> setShortcut(QAction, sequence, KGlobalAccel::Autoloading)   
> (which this defaults to)
> will make KGlobalAccel load whatever it has stored already in its config file.

Then use ::Autoloading explicitly?

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D10668

To: davidedmundson, #plasma
Cc: fvogt, aacid, cfeck, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10659: [AppletConfiguration] Let applet override Return closing the dialog

[Kai Uwe Broulik]

broulik added a comment.


  > Can this property become something more official, with real documentation
  
  Sure. If you tell me where the other features of the config dialog (e.g. the 
`saveConfig()` function ) is documented, I'd happily add it there.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10659

To: broulik, #plasma, kossebau
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart