D10762: Fix the build on armhf/aarch64

[Bhushan Shah]

bshah planned changes to this revision.
bshah added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Appearantly this doesn't fix all the issues.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10762

To: bshah, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D10762: Fix the build on armhf/aarch64

[Bhushan Shah]

bshah created this revision.
bshah added reviewers: Plasma, graesslin.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.
bshah requested review of this revision.
Restricted Application edited projects, added Plasma; removed KWin.

REVISION SUMMARY
  qopengl.h redeclares the functions defined in the epoxy/gl.h and it
  results in the build error. this is similar to other .cpp files where
  epoxy/gl.h is used.
  
  See: https://build.neon.kde.org/job/xenial_unstable_plasma_kwin_bin_armhf/157

REPOSITORY
  R108 KWin

BRANCH
  fix-arm-build

REVISION DETAIL
  https://phabricator.kde.org/D10762

AFFECTED FILES
  libkwineffects/kwinglplatform.cpp

To: bshah, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10294: Init the icon in ShellClient::init

[Bhushan Shah]

bshah accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

BRANCH
  init-icon-5.12

REVISION DETAIL
  https://phabricator.kde.org/D10294

To: graesslin, #kwin, #plasma, bshah
Cc: plasma-devel, kwin, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, iodelay, bwowk, hardening

D10755: Add a MsmApp::skillsPath method so the skills folder is not hardcoded

[Aditya Mehra]

Aiix accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R846 Mycroft Plasma integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10755

To: antlarr, Aiix
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10756: Reduce sidebar width

[Christoph Feck]

cfeck added a comment.


  Woot! :)
  
  In the long term, the drawers probably could use a qtquick splitview to allow 
the user to adjust the sizes.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10756

To: ngraham, #discover_software_store, apol
Cc: cfeck, acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10475: Make it possible to show the title despite having ctx actions

[Aleix Pol Gonzalez]

apol updated this revision to Diff 27825.
apol added a comment.


  Center the title and leave actions to the left and ctx actions to the right

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10475?vs=27623=27825

BRANCH
  arcpatch-D10475

REVISION DETAIL
  https://phabricator.kde.org/D10475

AFFECTED FILES
  src/controls/ToolBarApplicationHeader.qml

To: apol, #kirigami, mart, ngraham, abetts
Cc: rkflx, mart, ngraham, plasma-devel, apol, davidedmundson, hein

D10475: Make it possible to show the title despite having ctx actions

[Aleix Pol Gonzalez]

apol added a comment.


  In D10475#211781 , @abetts wrote:
  
  > I am in favor of placing the Titles left aligned, but only if we don't put 
more than 1 control to the left of the title. If we can't compromise on that, 
another option is to keep titles center-aligned.
  
  
  Problem with center-aligned is that it's hard to have it look centered having 
components growing on either side. I'll give it a go to having the actions on 
the left and the contextualActions on the right.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10475

To: apol, #kirigami, mart, ngraham, abetts
Cc: rkflx, mart, ngraham, plasma-devel, apol, davidedmundson, hein

D10756: Reduce sidebar width

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:bfa25177805f: Reduce sidebar width (authored by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10756?vs=27822=27824

REVISION DETAIL
  https://phabricator.kde.org/D10756

AFFECTED FILES
  discover/qml/DiscoverDrawer.qml

To: ngraham, #discover_software_store, apol
Cc: acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10756: Reduce sidebar width

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R134 Discover Software Store

BRANCH
  work-around-huge-sidebar-issue (branched from Plasma/5.12)

REVISION DETAIL
  https://phabricator.kde.org/D10756

To: ngraham, #discover_software_store, apol
Cc: acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10756: Reduce sidebar width

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10756

To: ngraham, #discover_software_store, apol
Cc: acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10756: Reduce sidebar width

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10756

To: ngraham, #discover_software_store, apol
Cc: acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10756: Reduce sidebar width

[Andrew Crouthamel]

acrouthamel added a comment.


  I like it!

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10756

To: ngraham, #discover_software_store, apol
Cc: acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10756: Reduce sidebar width

[Nathaniel Graham]

ngraham updated this revision to Diff 27822.
ngraham added a comment.


  Use the right branch

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10756?vs=27821=27822

BRANCH
  work-around-huge-sidebar-issue (branched from Plasma/5.12)

REVISION DETAIL
  https://phabricator.kde.org/D10756

AFFECTED FILES
  discover/qml/DiscoverDrawer.qml

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10756: Reduce sidebar width

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10756

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10756: Reduce sidebar width

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Discover Software Store, apol.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  BUG: 385992
  
  This is a hack to work aroudn the fact that we're using the wrong UI element 
for Discover's sidebar (see Bug 390928 

  
  Replacing the GlobalDrawer with something more appropriate is going to be a 
lot of work, so until then, let's not torture our users with the humongous 
sidebar any longer and just force it to be a smaller size.

TEST PLAN
  [images go here]

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10756

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10755: Add a MsmApp::skillsPath method so the skills folder is not hardcoded

[Antonio Larrosa Jimenez]

antlarr created this revision.
antlarr added a reviewer: Aiix.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
antlarr requested review of this revision.

REVISION SUMMARY
  The skills folder was hardcoded to /opt/mycroft/skills in MsmView.qml.
  When using the openSUSE packages I'm preparing, that's changed
  to ~/.mycroft/skills, so now we use that one if it exists and the
  system folder in other case.

REPOSITORY
  R846 Mycroft Plasma integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10755

AFFECTED FILES
  plasmoid/contents/ui/MsmView.qml
  plugin/msmapp.cpp
  plugin/msmapp.h

To: antlarr, Aiix
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10490: Add a method to dbus interface to query information about a window

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

BRANCH
  rules-detect-dbus

REVISION DETAIL
  https://phabricator.kde.org/D10490

To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, kwin, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, iodelay, bwowk, 
hardening

D10549: Don't crash if the cursor theme fails to create

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

BRANCH
  dont-crash-cursor-theme-failure

REVISION DETAIL
  https://phabricator.kde.org/D10549

To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, iodelay, bwowk, hardening

D10723: hide primary display combo when not supported

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R104 KScreen

BRANCH
  sebas/pcombo

REVISION DETAIL
  https://phabricator.kde.org/D10723

To: sebas, #plasma, dvratil, davidedmundson
Cc: kpiwowarski, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10752: Fix focus being removed from the text input widget

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R846:307fa73adecf: Fix focus being removed from the text input 
widget (authored by Antonio Larrosa antonio.larr...@gmail.com).

REPOSITORY
  R846 Mycroft Plasma integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10752?vs=27813=27817

REVISION DETAIL
  https://phabricator.kde.org/D10752

AFFECTED FILES
  plasmoid/contents/ui/main.qml

To: antlarr, Aiix
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10753: Provide the source selection as a contextual action

[Nathaniel Graham]

ngraham added a comment.


  OK, the i18n error is gone now. But do we really need that "also available in 
" text at the end of the Description, anyway? Apparently nobody reads it. 
Maybe we should focus on polishing the main source chooser UI and get rid of 
that little vestigial one.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10753

To: apol, ngraham
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10753: Provide the source selection as a contextual action

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  I see what you're going for here, but the "Sources" menu you're trying to add 
still doesn't actually work, same as the Sort menu. Is there an open Kirigami 
patch that this depends upon?
  
  Also now there's a textual bug in the Description:
  
  F5726029: Spectacle.a32064.png 

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10753

To: apol, ngraham
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10753: Provide the source selection as a contextual action

[Aleix Pol Gonzalez]

apol updated this revision to Diff 27816.
apol added a comment.


  Polish

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10753?vs=27814=27816

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10753

AFFECTED FILES
  discover/qml/ApplicationPage.qml
  libdiscover/resources/ResourcesProxyModel.cpp
  libdiscover/resources/ResourcesProxyModel.h

To: apol
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10752: Fix focus being removed from the text input widget

[Aditya Mehra]

Aiix accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R846 Mycroft Plasma integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10752

To: antlarr, Aiix
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10752: Fix focus being removed from the text input widget

[Antonio Larrosa Jimenez]

antlarr created this revision.
antlarr added a reviewer: Aiix.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
antlarr requested review of this revision.

REVISION SUMMARY
  Each time a message is received, the focus was stolen from
  the text input widget, which made it nearly impossible to write
  some command to mycroft. This way we only remove the focus from
  the widget when we really change its text.

TEST PLAN
  Write some text and notice the focus is constantly being removed
  from the widget when the animation on the top of the plasmoid is animated.
  
  After applying the patch, it allows to write text as expected.

REPOSITORY
  R846 Mycroft Plasma integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10752

AFFECTED FILES
  plasmoid/contents/ui/main.qml

To: antlarr, Aiix
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10753: Provide the source selection as a contextual action

[Aleix Pol Gonzalez]

apol created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Instead of the dreaded link button.
  
  BUG: 390464

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10753

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: apol
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10750: wayland: Add support for zwp_linux_dmabuf

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Concerning the tests: the ones requiring OpenGL work best if module vgem is 
loaded. That normally makes them pass. The tests regarding keyboard layout need 
env variable XDG_DEFAULT_LAYOUT being unset or on us.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10750

To: fredrik, #kwin, #plasma, davidedmundson, mart, graesslin
Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D10475: Make it possible to show the title despite having ctx actions

[Andres Betts]

abetts added a comment.


  I am in favor of placing the Titles right aligned, but only if we don't put 
more than 1 control to the right of the title. If we can't compromise on that, 
another option is to keep titles center-aligned.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10475

To: apol, #kirigami, mart, ngraham, abetts
Cc: rkflx, mart, ngraham, plasma-devel, apol, davidedmundson, hein

D10475: Make it possible to show the title despite having ctx actions

[Nathaniel Graham]

ngraham added a comment.


  The title is still the primary focus for this header UI, which means (for RTL 
languages at least), it needs to be left or center aligned. This means the 
actions have to be on the right, to make sure your eyes don't see them before 
the title.
  
  @abetts, what do you think?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10475

To: apol, #kirigami, mart, ngraham, abetts
Cc: rkflx, mart, ngraham, plasma-devel, apol, davidedmundson, hein

Re: KDE Neon Developer Unstable - plasmashell crashing on start

[Jörn M]

Thanks for the fast replys.
Will wait for the new packages ;-)

One further question. What is the real difference between developer stable
/ unstable?

My understanding was, that (for example) a change to qt5.10 will first be
done in unstable and when everything is in place it will be rolled out to
stable...

Am 22.02.2018 18:39 schrieb "Bhushan Shah" :

Yeah, there is ongoing migration to qt5.10

So it is known that it is broken... I hope to get this fixed sooner,
only few rebuilds remianing

On Thu, Feb 22, 2018 at 10:38 PM, Jörn M  wrote:
> Hello,
>
> today I noticed that KDE Neon developer unstable updates to Qt 5.10.
> The currently rolled out packages leave my system in an unusable state:
>
> - plasmashell crashes:
>
> ~> plasmashell
> org.kde.plasmaquick: Applet preload policy set to 1
> plasmashell: relocation error:
> /usr/lib/x86_64-linux-gnu/libKF5Declarative.so.5: symbol
> _ZN15QQmlPropertyMap15allocatePrivateEv, version Qt_5 not defined in file
> libQt5Qm
> l.so.5 with link time reference
>
> - plasmawindowed crashes:
>
> ~> plasmawindowed org.kde.plasma.networkmanagement
> org.kde.plasmaquick: Applet preload policy set to 1
> org.kde.plasma: requesting config for "Networks" without a containment!
> plasmawindowed: relocation error:
> /usr/lib/x86_64-linux-gnu/libKF5Declarative.so.5: symbol
> _ZN15QQmlPropertyMap15allocatePrivateEv, version Qt_5 not defined in file
> libQt
> 5Qml.so.5 with link time reference
>
>
> - It seems that only applications using libKF5Declarative are effected
> (plasma-discover for example works fine)
>
> Any hints how to solve this?
>
> Best Regards,
> Jörn



--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D

D10722: other preload microoptimizations

[Marco Martin]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:79fb4ebfa77f: other preload microoptimizations (authored 
by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10722?vs=27798=27806

REVISION DETAIL
  https://phabricator.kde.org/D10722

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/ScrollArea.qml

To: mart, #plasma, davidedmundson, broulik
Cc: davidedmundson, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10750: wayland: Add support for zwp_linux_dmabuf

[Fredrik Höglund]

fredrik created this revision.
fredrik added reviewers: KWin, Plasma, davidedmundson, mart, graesslin.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
fredrik requested review of this revision.
Restricted Application edited projects, added Plasma; removed KWin.

REVISION SUMMARY
  This adds support for LinuxDmabufUnstableV1Interface in kwin.

TEST PLAN
  I asked Marco to test it with a driver that supports modifiers, and he 
confirmed that it works.
  I have also checked that kwin still works with drivers that don't support 
modifiers.
  
  Test results before (6 failures):
  
  The following tests FAILED:
  
30 - kwin-testLockScreen (Failed)
39 - kwin-testPointerInput (Failed)
57 - kwin-testSceneOpenGL-waylandonly (Failed)
71 - kwin-testKeyboardLayout (Failed)
74 - kwin-testKeymapCreationFailure-waylandonly (Failed)
88 - kwin-testColorCorrectNightColor-waylandonly (Failed)
  
  Test results after (8 failures):
  
  The following tests FAILED:
  
30 - kwin-testLockScreen (Failed)
39 - kwin-testPointerInput (Failed)
59 - kwin-testSceneOpenGLES-waylandonly (Failed)
60 - kwin-testNoXdgRuntimeDir (Failed)
61 - kwin-testNoXdgRuntimeDir-waylandonly (Failed)
71 - kwin-testKeyboardLayout (Failed)
72 - kwin-testKeyboardLayout-waylandonly (Failed)
74 - kwin-testKeymapCreationFailure-waylandonly (Failed)
  
  I'm not sure what to make of this, but at least some of these failures are 
spurious.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10750

AFFECTED FILES
  platformsupport/scenes/opengl/abstract_egl_backend.cpp
  platformsupport/scenes/opengl/abstract_egl_backend.h
  platformsupport/scenes/opengl/backend.cpp
  platformsupport/scenes/opengl/backend.h
  plugins/scenes/opengl/scene_opengl.cpp
  plugins/scenes/opengl/scene_opengl.h
  scene.cpp
  scene.h
  wayland_server.cpp
  wayland_server.h

To: fredrik, #kwin, #plasma, davidedmundson, mart, graesslin
Cc: plasma-devel, kwin, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Re: KDE Neon Developer Unstable - plasmashell crashing on start

[Bhushan Shah]

Yeah, there is ongoing migration to qt5.10

So it is known that it is broken... I hope to get this fixed sooner,
only few rebuilds remianing

On Thu, Feb 22, 2018 at 10:38 PM, Jörn M  wrote:
> Hello,
>
> today I noticed that KDE Neon developer unstable updates to Qt 5.10.
> The currently rolled out packages leave my system in an unusable state:
>
> - plasmashell crashes:
>
> ~> plasmashell
> org.kde.plasmaquick: Applet preload policy set to 1
> plasmashell: relocation error:
> /usr/lib/x86_64-linux-gnu/libKF5Declarative.so.5: symbol
> _ZN15QQmlPropertyMap15allocatePrivateEv, version Qt_5 not defined in file
> libQt5Qm
> l.so.5 with link time reference
>
> - plasmawindowed crashes:
>
> ~> plasmawindowed org.kde.plasma.networkmanagement
> org.kde.plasmaquick: Applet preload policy set to 1
> org.kde.plasma: requesting config for "Networks" without a containment!
> plasmawindowed: relocation error:
> /usr/lib/x86_64-linux-gnu/libKF5Declarative.so.5: symbol
> _ZN15QQmlPropertyMap15allocatePrivateEv, version Qt_5 not defined in file
> libQt
> 5Qml.so.5 with link time reference
>
>
> - It seems that only applications using libKF5Declarative are effected
> (plasma-discover for example works fine)
>
> Any hints how to solve this?
>
> Best Regards,
> Jörn



-- 
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D

Re: KDE Neon Developer Unstable - plasmashell crashing on start

[Jörn M]

Short correction, I'm using:

KDE neon developer stable

Am 22.02.2018 18:08 schrieb "Jörn M" :

> Hello,
>
> today I noticed that KDE Neon developer unstable updates to Qt 5.10.
> The currently rolled out packages leave my system in an unusable state:
>
> - plasmashell crashes:
>
> ~> plasmashell
> org.kde.plasmaquick: Applet preload policy set to 1
> plasmashell: relocation error: 
> /usr/lib/x86_64-linux-gnu/libKF5Declarative.so.5:
> symbol _ZN15QQmlPropertyMap15allocatePrivateEv, version Qt_5 not defined
> in file libQt5Qm
> l.so.5 with link time reference
>
> - plasmawindowed crashes:
>
> ~> plasmawindowed org.kde.plasma.networkmanagement
> org.kde.plasmaquick: Applet preload policy set to 1
> org.kde.plasma: requesting config for "Networks" without a containment!
> plasmawindowed: relocation error: 
> /usr/lib/x86_64-linux-gnu/libKF5Declarative.so.5:
> symbol _ZN15QQmlPropertyMap15allocatePrivateEv, version Qt_5 not defined
> in file libQt
> 5Qml.so.5 with link time reference
>
>
> - It seems that only applications using libKF5Declarative are effected
> (plasma-discover for example works fine)
>
> Any hints how to solve this?
>
> Best Regards,
> Jörn
>

Re: KDE Neon Developer Unstable - plasmashell crashing on start

[Harald Sitter]

Bhushan is current landing Qt 5.10 which is why the dev editions are
currently in flux.

On Thu, Feb 22, 2018 at 6:08 PM, Jörn M  wrote:
> Hello,
>
> today I noticed that KDE Neon developer unstable updates to Qt 5.10.
> The currently rolled out packages leave my system in an unusable state:
>
> - plasmashell crashes:
>
> ~> plasmashell
> org.kde.plasmaquick: Applet preload policy set to 1
> plasmashell: relocation error:
> /usr/lib/x86_64-linux-gnu/libKF5Declarative.so.5: symbol
> _ZN15QQmlPropertyMap15allocatePrivateEv, version Qt_5 not defined in file
> libQt5Qm
> l.so.5 with link time reference
>
> - plasmawindowed crashes:
>
> ~> plasmawindowed org.kde.plasma.networkmanagement
> org.kde.plasmaquick: Applet preload policy set to 1
> org.kde.plasma: requesting config for "Networks" without a containment!
> plasmawindowed: relocation error:
> /usr/lib/x86_64-linux-gnu/libKF5Declarative.so.5: symbol
> _ZN15QQmlPropertyMap15allocatePrivateEv, version Qt_5 not defined in file
> libQt
> 5Qml.so.5 with link time reference
>
>
> - It seems that only applications using libKF5Declarative are effected
> (plasma-discover for example works fine)
>
> Any hints how to solve this?
>
> Best Regards,
> Jörn

D10692: parent full representation to the proper window at start

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> broulik wrote in main.qml:121
> Shouldn't this be a binding?

not really, as is just an inizialization to have the size it will have when 
properly reparented

when the popup is open, it's put in the StackView, so is them propely anchored 
and all

putting a binding here would just make things more complicated and potentially 
different things that want to resize the same thing at once

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10692

To: mart, #plasma
Cc: apol, broulik, hein, davidedmundson, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

Re: KDE Neon Developer Unstable - plasmashell crashing on start

[Nate Graham]

Can confirm; I'm seeing the same thing.

Nate


On 02/22/2018 10:08 AM, Jörn M wrote:

Hello,

today I noticed that KDE Neon developer unstable updates to Qt 5.10.
The currently rolled out packages leave my system in an unusable state:

- plasmashell crashes:

~> plasmashell
org.kde.plasmaquick: Applet preload policy set to 1
plasmashell: relocation error: 
/usr/lib/x86_64-linux-gnu/libKF5Declarative.so.5: symbol 
_ZN15QQmlPropertyMap15allocatePrivateEv, version Qt_5 not defined in 
file libQt5Qm

l.so.5 with link time reference

- plasmawindowed crashes:

~> plasmawindowedorg.kde.plasma.networkmanagement
org.kde.plasmaquick: Applet preload policy set to 1
org.kde.plasma: requesting config for "Networks" without a containment!
plasmawindowed: relocation error: 
/usr/lib/x86_64-linux-gnu/libKF5Declarative.so.5: symbol 
_ZN15QQmlPropertyMap15allocatePrivateEv, version Qt_5 not defined in 
file libQt

5Qml.so.5 with link time reference


- It seems that only applications using libKF5Declarative are effected 
(plasma-discover for example works fine)


Any hints how to solve this?

Best Regards,
Jörn

D10692: parent full representation to the proper window at start

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> main.qml:121
> +if (applet.fullRepresentationItem) {
> +applet.fullRepresentationItem.width = 
> expandedRepresentation.width
> +applet.fullRepresentationItem.width = 
> expandedRepresentation.height

Shouldn't this be a binding?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10692

To: mart, #plasma
Cc: apol, broulik, hein, davidedmundson, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D10722: other preload microoptimizations

[Kai Uwe Broulik]

broulik accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10722

To: mart, #plasma, davidedmundson, broulik
Cc: davidedmundson, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE Neon Developer Unstable - plasmashell crashing on start

[Jörn M]

Hello,

today I noticed that KDE Neon developer unstable updates to Qt 5.10.
The currently rolled out packages leave my system in an unusable state:

- plasmashell crashes:

~> plasmashell
org.kde.plasmaquick: Applet preload policy set to 1
plasmashell: relocation error:
/usr/lib/x86_64-linux-gnu/libKF5Declarative.so.5: symbol
_ZN15QQmlPropertyMap15allocatePrivateEv, version Qt_5 not defined in file
libQt5Qm
l.so.5 with link time reference

- plasmawindowed crashes:

~> plasmawindowed org.kde.plasma.networkmanagement
org.kde.plasmaquick: Applet preload policy set to 1
org.kde.plasma: requesting config for "Networks" without a containment!
plasmawindowed: relocation error:
/usr/lib/x86_64-linux-gnu/libKF5Declarative.so.5: symbol
_ZN15QQmlPropertyMap15allocatePrivateEv, version Qt_5 not defined in file
libQt
5Qml.so.5 with link time reference


- It seems that only applications using libKF5Declarative are effected
(plasma-discover for example works fine)

Any hints how to solve this?

Best Regards,
Jörn

D10722: other preload microoptimizations

[Marco Martin]

mart updated this revision to Diff 27798.
mart added a comment.


  - err forgot typeof

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10722?vs=27797=27798

BRANCH
  arcpatch-D10722

REVISION DETAIL
  https://phabricator.kde.org/D10722

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/ScrollArea.qml

To: mart, #plasma, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10722: other preload microoptimizations

[Marco Martin]

mart updated this revision to Diff 27797.
mart added a comment.


  - fix typo

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10722?vs=27796=27797

BRANCH
  arcpatch-D10722

REVISION DETAIL
  https://phabricator.kde.org/D10722

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/ScrollArea.qml

To: mart, #plasma, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10722: other preload microoptimizations

[Marco Martin]

mart updated this revision to Diff 27796.
mart added a comment.


  - check for function

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10722?vs=27795=27796

BRANCH
  arcpatch-D10722

REVISION DETAIL
  https://phabricator.kde.org/D10722

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/ScrollArea.qml

To: mart, #plasma, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10722: other preload microoptimizations

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in svgitem.cpp:50
> > when the component is complete, in many cases i guessthe properties would 
> > all be already set?
> 
> We know for definitely they will be already set.
> 
> I don't understand what problem you think this is solving.

i was probably just confused reading hotspot reports with and without...
i think all this part can be ignored, i want to leave just the part about 
preloading of lists

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10722

To: mart, #plasma, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10722: other preload microoptimizations

[Marco Martin]

mart updated this revision to Diff 27795.
mart added a comment.


  - Revert most of it
  - only leave the forcelayout part

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10722?vs=27707=27795

BRANCH
  arcpatch-D10722

REVISION DETAIL
  https://phabricator.kde.org/D10722

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/ScrollArea.qml

To: mart, #plasma, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10722: other preload microoptimizations

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> mart wrote in svgitem.cpp:50
> when the component is complete, in many cases i guessthe properties would all 
> be already set? (could add a check on that) could even be worth directly a 
> loadPixmap, like an immediate updatePolish() there

> when the component is complete, in many cases i guessthe properties would all 
> be already set?

We know for definitely they will be already set.

I don't understand what problem you think this is solving.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10722

To: mart, #plasma, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10748: drop the setting of c++0x

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:11086bb7913f: drop the setting of c++0x (authored by 
mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10748?vs=27790=27793

REVISION DETAIL
  https://phabricator.kde.org/D10748

AFFECTED FILES
  CMakeLists.txt

To: mart, #plasma, kossebau
Cc: kossebau, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10748: drop the setting of c++0x

[Friedrich W . H . Kossebau]

kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.


  Builds here as before as well.
  
  Reducing duplicated flags in the compile commands for me from
  `-std=c++0x -std=c++0x -std=c++0x -std=gnu++11`
  to
   `-std=c++0x -std=c++0x -std=gnu++11` :)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/cpp0x

REVISION DETAIL
  https://phabricator.kde.org/D10748

To: mart, #plasma, kossebau
Cc: kossebau, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10747: Implement zwp_linux_dmabuf_v1

[Fredrik Höglund]

fredrik added inline comments.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.

INLINE COMMENTS

> linuxdmabuf_v1_interface.h:39
> +
> +namespace LinuxDmabuf
> +{

Do we want these nested namespaces? We could have LinuxDmabufFlags, 
LinuxDmabufBuffer etc. instead.

> linuxdmabuf_v1_interface.h:65
> + */
> +class Buffer {
> +public:

Should the Buffer class use a d-pointer?

> linuxdmabuf_v1_interface.h:107
> + */
> +class Bridge {
> +public:

Is this the solution we want for interfacing with the compositor?

My preference would be to use std::function callbacks, with setters in 
LinuxDmabufUnstableV1Interface. Setting up the interface could then look like 
this:

  m_linuxDmabuf = m_display->createLinuxDmabufInterface(m_display);
  m_linuxDmabuf->setQuerySupportedFormats([]{ return 
Compositor::self()->scene()->supportedDrmFormats(); });
  ...
  m_linuxDmabuf->create();

This can also be extended without breaking binary compatibility. But I don't 
think we can use std::function in frameworks. There are also BIC issues when 
mixing different STL implementations, which we may or may not care about.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10747

To: fredrik, #kwin, #plasma, graesslin, davidedmundson, mart
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, schernikov, alexeymin, eliasp, hein

D10747: Implement zwp_linux_dmabuf_v1

[Marco Martin]

mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.


  +1 on my machine opengl apps seems to work well on wayland (after the first 
revision in which they were flipped upside down, now they are ok)
  would need a final ship it by someone more familiar with that area tough :)

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10747

To: fredrik, #kwin, #plasma, graesslin, davidedmundson, mart
Cc: plasma-devel, #frameworks, schernikov, michaelh, ZrenBot, alexeymin, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D10748: drop the setting of c++0x

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  this is already done by KDEFrameworkCompilerSettings so it's just duplicated 
now

TEST PLAN
  still builds and runs

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/cpp0x

REVISION DETAIL
  https://phabricator.kde.org/D10748

AFFECTED FILES
  CMakeLists.txt

To: mart, #plasma
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10747: Implement zwp_linux_dmabuf_v1

[Fredrik Höglund]

fredrik created this revision.
fredrik added reviewers: KWin, Plasma, graesslin, davidedmundson, mart.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
fredrik requested review of this revision.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.

REVISION SUMMARY
  This interface provides a way for clients to create generic dmabuf-based 
wl_buffers.

TEST PLAN
  I asked Marco to test it with a driver that supports modifiers, and he says 
that it works.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10747

AFFECTED FILES
  src/client/protocols/linux-dmabuf-unstable-v1.xml
  src/server/CMakeLists.txt
  src/server/buffer_interface.cpp
  src/server/buffer_interface.h
  src/server/display.cpp
  src/server/display.h
  src/server/drm_fourcc.h
  src/server/linuxdmabuf_v1_interface.cpp
  src/server/linuxdmabuf_v1_interface.h

To: fredrik, #kwin, #plasma, graesslin, davidedmundson, mart
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10722: other preload microoptimizations

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in svgitem.cpp:50
> I don't see how this makes any difference.
> 
> Every setSomeProperty already calls scheduleImageUpdate regardless of whether 
> we're complete or not.
> and if you don't have any properties set, then there's nothing to polish.

when the component is complete, in many cases i guessthe properties would all 
be already set? (could add a check on that) could even be worth directly a 
loadPixmap, like an immediate updatePolish() there

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10722

To: mart, #plasma
Cc: davidedmundson, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10481: Add FormLayout.qml to kirigami.qrc

[Marco Martin]

mart added a comment.


  ping?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10481

To: icota, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D10499: [spellcheck runner] Make each suggestion copyable as separate item

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:66eb115a9300: [spellcheck runner] Make each suggestion 
copyable as separate item (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10499?vs=27127=27772#toc

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10499?vs=27127=27772

REVISION DETAIL
  https://phabricator.kde.org/D10499

AFFECTED FILES
  runners/spellchecker/spellcheck.cpp
  runners/spellchecker/spellcheck.h

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10692: parent full representation to the proper window at start

[Marco Martin]

mart updated this revision to Diff 27767.
mart added a comment.


  remove leftovers

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10692?vs=27715=27767

BRANCH
  arcpatch-D10692

REVISION DETAIL
  https://phabricator.kde.org/D10692

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/main.qml

To: mart, #plasma
Cc: apol, broulik, hein, davidedmundson, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D10692: parent full representation to the proper window at start

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> apol wrote in systemtray.h:30
> Why?

eww, leftover

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10692

To: mart, #plasma
Cc: apol, broulik, hein, davidedmundson, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

Re: What does LTS mean again?

[David Edmundson]

​> - Bugfixes releases

All bug fixes, including low priority ones on a steady cycle for a year
Security and major bug fixes released on-demand for at least a year

Things might be extended, but not shortened.



Frameworks isn't something we've communicated with the frameworks ML.
Though I can't see it being a problem should the need arise.

Last time we didn't actually end up doing patch releases for the frameworks
5.whateverItWas :/ Even though we had at least one CVE in KAuth during that
time.

David

D10736: Do clamping in the model and add missing lower bound check

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10736

To: hein, #plasma, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10736: Do clamping in the model and add missing lower bound check

[Eike Hein]

hein created this revision.
hein added a reviewer: Plasma.
Restricted Application added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  Clamping the window delegate size to stay within the desktop
  rect was previously done in the QML code, but only for the
  higher bound. This moves clamping into the C++ model and adds
  a lower bound.
  
  BUG:390888

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10736

AFFECTED FILES
  applets/pager/package/contents/ui/main.qml
  applets/pager/plugin/windowmodel.cpp

To: hein, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart