KDE CI: Plasma plasma-framework stable-kf5-qt5 SUSEQt5.9 - Build # 76 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20SUSEQt5.9/76/
 Project:
Plasma plasma-framework stable-kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 25 Feb 2018 21:31:34 +
 Build duration:
9 hr 55 min and counting
   CONSOLE OUTPUT
  [...truncated 155.09 KB...]./plugin/%{APPNAMELC}plugin.cpp./plugin/CMakeLists.txt./plugin/qmldir./plugin/%{APPNAMELC}plugin.h./READMENote: Writing plasmapkg2.1[  1%] Built target qml-plasmoid-with-qml-extensionScanning dependencies of target plasmapkg2_autogenScanning dependencies of target calendarplugin_autogen[  1%] Automatic MOC for target plasmapkg2[  1%] Automatic MOC for target calendarplugin[  1%] Built target docs-plasmapkg2-plasmapkg2-1Scanning dependencies of target qml-plasmoid[  1%] Built target plasmapkg2_autogen[  1%] Generating qml-plasmoid.tar.bz2Scanning dependencies of target cpp-plasmoid[  1%] Generating cpp-plasmoid.tar.bz2../CMakeLists.txt./qml-plasmoid.png./Messages.sh./qml-plasmoid.kdevtemplate./package./package/contents./package/contents/images./package/contents/images/pairs.svgz./package/contents/ui./package/contents/ui/main.qml./package/metadata.desktop./README[  1%] Built target qml-plasmoidScanning dependencies of target plasma-wallpaper../CMakeLists.txt./cpp-plasmoid.png./src./src/CMakeLists.txt./src/%{APPNAMELC}.cpp./src/%{APPNAMELC}.h./src/package./src/package/contents./src/package/contents/images./src/package/contents/images/pairs.svgz./src/package/contents/ui./src/package/contents/ui/main.qml./src/package/metadata.desktop./Messages.sh./cpp-plasmoid.kdevtemplate./README[  1%] Generating plasma-wallpaper.tar.bz2[  1%] Built target cpp-plasmoid../CMakeLists.txt./plasma-wallpaper.kdevtemplate./Messages.sh./package./package/contents./package/contents/config./package/contents/config/main.xml./package/contents/ui./package/contents/ui/main.qml./package/contents/ui/config.qml./package/metadata.desktop./READMEScanning dependencies of target plasmapkg2[  1%] Built target plasma-wallpaper[  1%] Building CXX object src/plasmapkg/CMakeFiles/plasmapkg2.dir/main.cpp.oScanning dependencies of target platformcomponentsplugin_autogen[  2%] Building CXX object src/plasmapkg/CMakeFiles/plasmapkg2.dir/plasmapkg2_autogen/mocs_compilation.cpp.o[  3%] Automatic MOC for target platformcomponentsplugin[  3%] Built target calendarplugin_autogenScanning dependencies of target calendarplugin[  4%] Building CXX object src/declarativeimports/calendar/CMakeFiles/calendarplugin.dir/calendarplugin.cpp.o[  4%] Building CXX object src/declarativeimports/calendar/CMakeFiles/calendarplugin.dir/calendar.cpp.o[  4%] Built target platformcomponentsplugin_autogen[  4%] Linking CXX executable ../../bin/plasmapkg2/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 SUSEQt5.9/src/declarativeimports/calendar/calendar.cpp: In member function ‘void Calendar::setTypes(int)’:/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 SUSEQt5.9/src/declarativeimports/calendar/calendar.cpp:106:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (m_types == types) { ^~~~[  4%] Built target plasmapkg2[  5%] Building CXX object src/declarativeimports/calendar/CMakeFiles/calendarplugin.dir/daysmodel.cpp.o[  5%] Built target KF5Plasma_autogenmake[2]: *** Deleting file 'src/declarativeimports/calendar/CMakeFiles/calendarplugin.dir/daysmodel.cpp.o'make[2]: *** Deleting file 'src/declarativeimports/calendar/CMakeFiles/calendarplugin.dir/calendar.cpp.o'make[2]: *** Deleting file 'src/declarativeimports/calendar/CMakeFiles/calendarplugin.dir/calendarplugin.cpp.o'make[1]: *** [CMakeFiles/Makefile2:1458: src/declarativeimports/calendar/CMakeFiles/calendarplugin.dir/all] Terminatedmake: *** [Makefile:141: all] Error 2make: INTERNAL: Exiting with 5 jobserver tokens available; should be 6![Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Plasma plasma-framework stable-kf5-qt5 SUSEQt5.9] Running shell script+ python3 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext

D10835: [kicker] Never execute recent documents

[Алексей Шилин]

aleksejshilin added a comment.


  In D10835#213787 , @broulik wrote:
  
  > Can you check whether this affects Task manager also?
  
  
  Task Manager runs the corresponding application explicitly by its .desktop 
file, so it's not affected.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10835

To: aleksejshilin, #plasma
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10850: Rename wallpaper translation catalogs to follow pattern

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  The wallpaper loading code expects the catalogs to follow the pattern
  "plasma_wallpaper_" + pluginid. While in config QML the domain needs
  to be explicitly set using i18nd, as the default textdomain is set to
  that of the config container, it is not needed in the wallpaper QML.
  
  While using a catalog with plasma_applet_* prefix works if setting
  the domain explicitly, the usage goes against the design of the
  naming patterns. So to give a good example and also properly marking
  the usage of the catalog, the names are switched.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fixwallpapercatalognames

REVISION DETAIL
  https://phabricator.kde.org/D10850

AFFECTED FILES
  wallpapers/color/Messages.sh
  wallpapers/color/contents/ui/config.qml
  wallpapers/image/CMakeLists.txt
  wallpapers/image/Messages.sh
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/imagepackage/platformcontents/phone/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/platformcontents/phone/ui/config.qml

To: kossebau, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

[Breeze] [Bug 343580] All look and feel, icons, theme are not configurable and all icons are gone

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=343580

jarlgjess...@gmail.com changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED

--- Comment #6 from jarlgjess...@gmail.com ---
Thanks problem is solved now!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 343580] All look and feel, icons, theme are not configurable and all icons are gone

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=343580

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|UNCONFIRMED |NEEDSINFO
 CC||n...@kde.org

--- Comment #5 from Nate Graham  ---
Edmund, thanks for your bug triaging efforts! Feel free to mark these kinds of
bugs as NEEDSINFO WAITINGFORINFO if you're requesting more information or
confirmation from the reporter. See
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging#Ask_for_any_missing_information

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 352610] root apps use oxygen icons and widget style

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=352610

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Nate Graham  ---
Yup, this is "fixed" now. But really, you shouldn't run apps as root or use
root sessions in the first place.

Edmund, thanks for your bug triaging efforts! Feel free to mark these kinds of
bugs as RESOLVED if they're now fixed or no longer applicable.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10802: Fix the userswitcher when using the mouse for switching

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1eb9ae7e33e2: Fix the userswitcher when using the mouse 
for switching (authored by fvogt).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10802?vs=27935=28066

REVISION DETAIL
  https://phabricator.kde.org/D10802

AFFECTED FILES
  ksmserver/switchuserdialog.cpp

To: fvogt, #plasma, broulik
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9713: Add script to unlock a broken session via ConsoleKit.

[Tobias C . Berner]

tcberner added a comment.


  We could certainly do that by removing the wrapping `if ( NOT HAVE_LOGINCTL 
)`. 
  Additionally, also the order of the if-branches in `abstractlocker.cpp` would 
probably need to be reordered as to prefere login1.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D9713

To: tcberner, graesslin, #freebsd, #plasma
Cc: arfrever, broulik, PureTryOut, adridg, pprkut, graesslin, plasma-devel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9713: Add script to unlock a broken session via ConsoleKit.

[Martin Flöser]

graesslin added inline comments.

INLINE COMMENTS

> arfrever wrote in CMakeLists.txt:97
> I would suggest that this build-time detection of ConsoleKit occur always, 
> and as a result, that ck-unlock-session be always installed if ConsoleKit is 
> installed.
> For example, I have both loginctl and ConsoleKit installed, but loginctl is 
> not running and ConsoleKit is running.
> (loginctl is part of systemd whose library functionality can be used by other 
> packages even when systemd is not used as init system.)

You can disable the detection of loginctl through cmake functionality.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D9713

To: tcberner, graesslin, #freebsd, #plasma
Cc: arfrever, broulik, PureTryOut, adridg, pprkut, graesslin, plasma-devel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

[Martin Flöser]

graesslin added a comment.


  In D10816#213801 , @broulik wrote:
  
  > Also I think all of this will become obsolete with Qt 5.11 where it 
supports multiple platform plugins as a fallback chain: 
https://codereview.qt-project.org/#/c/220294/
  
  
  Yes, this is only intended to be used till Plasma depends on Qt 5.11.

INLINE COMMENTS

> broulik wrote in kworkspace.h:161
> Can you `assert` this?

I'll rephrase it, it's not a "must", it's just a "must happen before if one 
wants to use it". Given that I don't think an assert is required.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10816

To: graesslin, #plasma
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10800: Plasma browser MPRIS canPlay shouldn't depend on the actual playing status

[Matthijs Tijink]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:48a2e78b2afb: Plasma browser MPRIS canPlay shouldnt 
depend on the actual playing status (authored by mtijink).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10800?vs=27933=28064

REVISION DETAIL
  https://phabricator.kde.org/D10800

AFFECTED FILES
  host/mprisplugin.cpp

To: mtijink, #plasma, broulik
Cc: nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9713: Add script to unlock a broken session via ConsoleKit.

[Arfrever Frehtes Taifersar Arahesis]

arfrever added inline comments.

INLINE COMMENTS

> CMakeLists.txt:97
> +if ( NOT HAVE_LOGINCTL )
> +find_package(ConsoleKit)
> +set_package_properties(ConsoleKit PROPERTIES

I would suggest that this build-time detection of ConsoleKit occur always, and 
as a result, that ck-unlock-session be always installed if ConsoleKit is 
installed.
For example, I have both loginctl and ConsoleKit installed, but loginctl is not 
running and ConsoleKit is running.
(loginctl is part of systemd whose library functionality can be used by other 
packages even when systemd is not used as init system.)

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D9713

To: tcberner, graesslin, #freebsd, #plasma
Cc: arfrever, broulik, PureTryOut, adridg, pprkut, graesslin, plasma-devel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10838: [joystick kcm] Fix translation catalog name to follow patterns

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improvekcmjoystickcatalogname

REVISION DETAIL
  https://phabricator.kde.org/D10838

AFFECTED FILES
  kcms/hardware/joystick/CMakeLists.txt
  kcms/hardware/joystick/Messages.sh

To: kossebau, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D9414: Implement OSD to select action when unknown monitors is connected

[Andrew Crouthamel]

acrouthamel added a comment.


  Could this be implemented for bug 390096 
? Having the display button open 
this OSD would be an improvement over the current operation, in my opinion.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D9414

To: dvratil, sebas, davidedmundson, #vdg
Cc: acrouthamel, abetts, broulik, kamathraghavendra, graesslin, ngraham, 
plasma-devel, mlaurent, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D10837: bad textarea width for rename file if filename too short

[Painless Roaster]

painlessroaster added a comment.


  new patch with correct rtl support

REVISION DETAIL
  https://phabricator.kde.org/D10837

To: painlessroaster, #plasma
Cc: plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10837: bad textarea width for rename file if filename too short

[Painless Roaster]

painlessroaster added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION DETAIL
  https://phabricator.kde.org/D10837

To: painlessroaster, #plasma
Cc: plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

[Kai Uwe Broulik]

broulik added a comment.


  Also I think all of this will become obsolete with Qt 5.11 where it supports 
multiple platform plugins as a fallback chain: 
https://codereview.qt-project.org/#/c/220294/

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10816

To: graesslin, #plasma
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> kworkspace.h:161
> +*
> +* This function must be invoked before the QGuiApplication instance is 
> constructed.
> +* @since 5.13

Can you `assert` this?

> kworkspace.h:164
> +**/
> +   KWORKSPACE_EXPORT void platformDetection(int argc, char **argv);
> +

`detectPlatform`?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10816

To: graesslin, #plasma
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10802: Fix the userswitcher when using the mouse for switching

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10802

To: fvogt, #plasma, broulik
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10800: Plasma browser MPRIS canPlay shouldn't depend on the actual playing status

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Makes sense. Thanks!

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  fix-mpris-canplaypause

REVISION DETAIL
  https://phabricator.kde.org/D10800

To: mtijink, #plasma, broulik
Cc: nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10835: [kicker] Never execute recent documents

[Kai Uwe Broulik]

broulik added a comment.


  Can you check whether this affects Task manager also?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10835

To: aleksejshilin, #plasma
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10836: Ensure _NET_CURRENT_DESKTOP is set on startup

[Martin Flöser]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
graesslin requested review of this revision.
Restricted Application edited projects, added Plasma; removed KWin.

REVISION SUMMARY
  Seems to have regressed in Plasma 5.12 due to code reordering. Now the
  property is explicitly updated once the NETRootInfo is created.
  
  BUG: 391034
  FIXED-IN: 5.12.3

TEST PLAN
  Test case exposing the problem added. Fails without the patch,
  succeeds with the patch.

REPOSITORY
  R108 KWin

BRANCH
  set-current-desktop-on-startup

REVISION DETAIL
  https://phabricator.kde.org/D10836

AFFECTED FILES
  autotests/integration/virtual_desktop_test.cpp
  workspace.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

[Breeze] [Bug 350684] lock window when switching between users is very hard to use

[Dirk Heinrichs]

https://bugs.kde.org/show_bug.cgi?id=350684

Dirk Heinrichs  changed:

   What|Removed |Added

 CC|dirk.heinri...@altum.de |

--- Comment #3 from Dirk Heinrichs  ---
Well, if you ask 2,5 years later...

At least for me, who's eanwhile using a newer KDE version, this is not an issue
anymore. But I'm not the original author...

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10835: [kicker] Never execute recent documents

[Алексей Шилин]

aleksejshilin created this revision.
aleksejshilin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
aleksejshilin requested review of this revision.

REVISION SUMMARY
  When one tried to open a recent document which happened to be
  executable (a shell script, for example), it was run instead.
  This was unexpected and could even be disastrous.
  
  After this change, recent documents are always opened.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  always_open_recent_documents

REVISION DETAIL
  https://phabricator.kde.org/D10835

AFFECTED FILES
  applets/kicker/plugin/recentusagemodel.cpp

To: aleksejshilin, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10807: fileindexerconfig: Exclude Vaults by default

[Michael Heidelbach]

michaelh added a comment.


  In D10807#213250 , @rkflx wrote:
  
  > What about users who manually create and mount FUSE-type encrypted 
directories? Plasma Vault is just a nice interface for this workflow, after all.
  
  
  Good point.
  
  > A more general approach would be to look at the filesystem type in `mount` 
(do we have an API for that?). I'd imagine a user configurable whitelist and/or 
blacklist (in a config file, not sure that's UI material) would be most 
flexible. Perhaps there's already similar code in Baloo for handling removable 
devices or remote filesystems, or is this all based on some hardcoded path 
heuristics?
  
  Not sure, apparently baloo reads `/etc/mtab` only to disable copy-on-write on 
btrfs.
  Baloo needs a better handling of filesystems. I just started to tackle this 
(see T8054 ). When I'm done with that, it 
should be possible to white-/blacklist specific filesystems.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10807

To: michaelh, #baloo, #frameworks, ngraham, #plasma
Cc: rkflx, alexeymin, plasma-devel, ivan, nicolasfella, ashaposhnikov, 
michaelh, kmorwinski, spoorun, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

[Breeze] [Bug 352610] root apps use oxygen icons and widget style

[Edmund Kasprzak]

https://bugs.kde.org/show_bug.cgi?id=352610

Edmund Kasprzak  changed:

   What|Removed |Added

 CC||edk...@gmail.com

--- Comment #4 from Edmund Kasprzak  ---
I vote for closing this bug, as I think currently (when Plasma5 is widely
adopted) Breeze is always default including fresh (not kde4 upgrade) root
account.

Tested and confirmied with Debian 9/Plasma 5.8.
Apps opened as root use Breeze style by default (without previous configuration
of that).

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

[Roman Gilg]

romangg added a task: T8077: Do not set QT_QPA_PLATFORM to wayland at session 
startup.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10816

To: graesslin, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

[Breeze] [Bug 350684] lock window when switching between users is very hard to use

[Edmund Kasprzak]

https://bugs.kde.org/show_bug.cgi?id=350684

Edmund Kasprzak  changed:

   What|Removed |Added

 CC||edk...@gmail.com

--- Comment #2 from Edmund Kasprzak  ---
It's been some time, can you confirm the same in more recent KDE?

To be honest, I'm not sure if I understand the issue correctly.

Using Neon Git Stable, Plasma 5.12.2, KF 5.43.0, Qt 5.10.0 here and can't see a
problem here.

When being in lockscreen I can either
1. type password for current use and login
2. Click on "Switch user". If that's clicked:

2.1 - Choose a different user (if another user session is already open in
background). Then it opens a password prompt for that user. Typing the password
and click on "Switch session" switches to that user.

2.2 - Choose a "New session" and  click "Switch session" (it's like
confirmation, the same is typing password in scenario above). It goes back to
login screen to create a new session.

2.3 Click on "Back" where I can go back to my original session after typing
password.


I can't see anything wrong with that logic.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10440: Support modifier mouse/scroll action on internal decorated windows

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  In D10440#213112 , @romangg wrote:
  
  > Looks fine, but making this behavior dependent on `isDecorated` seems a bit 
hacky to me. Wouldn't be a separate property for this better? Are all internal 
windows without decoration not movable? What if we want to do it this way at 
some point in the future? We just shouldn't forget about this check here then.
  
  
  KWin internal windows are a bit special. Traditionally KWin was not able to 
manage it's own windows which means on X11 they were override redirect. Due to 
that they are not movable. The first ever internal window which is not falling 
under the constraints is the DebugConsole. But also only on Wayland. On X11 it 
has the same restrictions as on Wayland. Due to the restrictions for internal 
windows I consider it as highly unlikely that we will extend this in future. 
The main difference between a normal internal window and the DebugConsole 
internal window is that it is decorated. Other internal windows which are not 
decorated are also not going to be movable. What we currently have are things 
like the OSD, Overlay, etc. All of them not movable. "Real" windows are 
normally done through spawning a dedicated child process (examples: window 
killer, dialog for fullscreen windows, etc.). This is probably also not going 
to change.
  
  So yes the whole thing is kind of hacky, but I think it is acceptable.

REPOSITORY
  R108 KWin

BRANCH
  modifier-click-scroll-decorated-internal-window-5.12

REVISION DETAIL
  https://phabricator.kde.org/D10440

To: graesslin, #kwin, #plasma, romangg
Cc: romangg, plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D10549: Don't crash if the cursor theme fails to create

[Martin Flöser]

graesslin added inline comments.
Restricted Application edited projects, added KWin; removed Plasma.

INLINE COMMENTS

> romangg wrote in wayland_cursor_theme.cpp:69
> Can we check differently if it is the same theme? Or should we in any case 
> emit themeChanged when we are at this point already?

As it's connected to Cursor::themeChanged we can assume that we don't have to 
check here. If it would be invoked for the same theme the bug would be in the 
Cursor class. Given that I would say we can ignore it here. I just checked in 
cursor.cpp and there it is properly guarded to only emit the themeChanged 
signal if the theme truly changed.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10549

To: graesslin, #kwin, #plasma, davidedmundson, romangg
Cc: romangg, plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

[Breeze] [Bug 343580] All look and feel, icons, theme are not configurable and all icons are gone

[Edmund Kasprzak]

https://bugs.kde.org/show_bug.cgi?id=343580

Edmund Kasprzak  changed:

   What|Removed |Added

 CC||edk...@gmail.com

--- Comment #4 from Edmund Kasprzak  ---
It's been sometime, were you able to achieve this issue more times?

I didn't have anything like that testing openSUSE Tumbleweed, Leap 42.3 and
Leap 15 beta for last couple of months.

It looks like some opensuse kde specific quirk at that time.
I vote to close this ticket if no occurences have been found.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10142: [server] Properly handle the situation when the DataSource for a drag gets destroyed

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:2dfe16d774c7: [server] Properly handle the situation when 
the DataSource for a drag gets… (authored by graesslin).
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10142?vs=26054=28025

REVISION DETAIL
  https://phabricator.kde.org/D10142

AFFECTED FILES
  autotests/client/test_drag_drop.cpp
  src/server/datadevice_interface.cpp
  src/server/seat_interface.cpp
  src/server/seat_interface_p.h

To: graesslin, #frameworks, #kwin, #plasma, romangg
Cc: plasma-devel, michaelh, kmorwinski, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, schernikov, alexeymin, eliasp, hein

D10490: Add a method to dbus interface to query information about a window

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:1d71292e13fc: Add a method to dbus interface to query 
information about a window (authored by graesslin).
Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10490?vs=27318=28023

REVISION DETAIL
  https://phabricator.kde.org/D10490

AFFECTED FILES
  dbusinterface.cpp
  dbusinterface.h
  kcmkwin/kwinrules/CMakeLists.txt
  kcmkwin/kwinrules/detectwidget.cpp
  kcmkwin/kwinrules/detectwidget.h
  kcmkwin/kwinrules/ruleswidget.cpp
  kcmkwin/kwinrules/ruleswidget.h
  org.kde.KWin.xml

To: graesslin, #kwin, #plasma, davidedmundson, romangg
Cc: davidedmundson, broulik, plasma-devel, kwin, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, iodelay, bwowk, 
hardening

D10308: Send hoverLeave or hoverMotion after touch up on decoration

[Martin Flöser]

This revision was not accepted when it landed; it landed in state "Changes 
Planned".
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:911176a887be: Send hoverLeave or hoverMotion after touch 
up on decoration (authored by graesslin).
Restricted Application edited projects, added Plasma; removed KWin.

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10308?vs=26533=28022#toc

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10308?vs=26533=28022

REVISION DETAIL
  https://phabricator.kde.org/D10308

AFFECTED FILES
  autotests/integration/decoration_input_test.cpp
  autotests/integration/quick_tiling_test.cpp
  input.cpp

To: graesslin, #kwin, #plasma, ngraham, romangg
Cc: plasma-devel, kwin, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, iodelay, bwowk, hardening

D10294: Init the icon in ShellClient::init

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:5795fc8cc04a: Init the icon in ShellClient::init 
(authored by graesslin).
Restricted Application edited projects, added KWin; removed Plasma.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10294?vs=26500=28021

REVISION DETAIL
  https://phabricator.kde.org/D10294

AFFECTED FILES
  autotests/integration/internal_window.cpp
  autotests/integration/shell_client_test.cpp
  shell_client.cpp

To: graesslin, #kwin, #plasma, bshah
Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D10308: Send hoverLeave or hoverMotion after touch up on decoration

[Martin Flöser]

graesslin planned changes to this revision.
graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  I need to rework the patch, it broke with 
338c7362c9fbb37f1fb8beb9a50644b585d8135e 


REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10308

To: graesslin, #kwin, #plasma, ngraham, romangg
Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D10291: Add a recursion blocker in Pointer/TouchInputRedirection::update

[Roman Gilg]

romangg added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Note that it gave me some error, when I tried to compile this branch.
  
  `UpdateRecursionBlocker` has a generic name, but it is dependent on receiving 
as `T` one of the input classes with `input` as an instance and having a member 
function `update`. I would make it fully generic by adding a std::function type 
argument to the constructer (that in our current application encapsulates 
`input->update()`) and that gets called in the destructor just like it is now. 
The template parameter `T` would then be the template argument of the 
std::function argument and m_input would be replaced by a member variable 
`m_fct` storing the std::function
  
  The class does not directly block recursions, but delays additional calls to 
the end of the first call (and then does the call only once). Therefore I would 
name it differently. Something like `BlockAndDelayCallsToOne`?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10291

To: graesslin, #kwin, #plasma
Cc: romangg, plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D10830: Disable SplitterProxy by default since it's broken

[Albert Astals Cid]

aacid created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
aacid requested review of this revision.

REVISION SUMMARY
  BUGS: 389837

REPOSITORY
  R31 Breeze

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10830

AFFECTED FILES
  kstyle/breeze.kcfg

To: aacid
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D9713: Add script to unlock a broken session via ConsoleKit.

[Tobias C . Berner]

This revision was automatically updated to reflect the committed changes.
tcberner marked an inline comment as done.
Closed by commit R133:68fb0b7d3e1c: Add script to unlock a broken session via 
ConsoleKit. (authored by tcberner).

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9713?vs=27901=27992

REVISION DETAIL
  https://phabricator.kde.org/D9713

AFFECTED FILES
  CMakeLists.txt
  abstractlocker.cpp
  ck-unlock-session.cmake
  cmake/FindConsoleKit.cmake
  cmake/Findloginctl.cmake
  config-kscreenlocker.h.cmake

To: tcberner, graesslin, #freebsd, #plasma
Cc: broulik, PureTryOut, adridg, pprkut, graesslin, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10308: Send hoverLeave or hoverMotion after touch up on decoration

[Roman Gilg]

Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

BRANCH
  hover-leave-on-deco-after-touch-5.12

REVISION DETAIL
  https://phabricator.kde.org/D10308

To: graesslin, #kwin, #plasma, ngraham, romangg
Cc: plasma-devel, kwin, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, iodelay, bwowk, hardening

D10291: Add a recursion blocker in Pointer/TouchInputRedirection::update

[Roman Gilg]

Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10291

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, iodelay, bwowk, hardening

D10549: Don't crash if the cursor theme fails to create

[Roman Gilg]

Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10549

To: graesslin, #kwin, #plasma, davidedmundson, romangg
Cc: romangg, plasma-devel, kwin, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, iodelay, bwowk, hardening

D10235: [server] Add support for the frame semantics of Pointer version 5

[Roman Gilg]

Restricted Application edited projects, added Plasma on Wayland; removed Plasma.

REPOSITORY
  R127 KWayland

BRANCH
  server-pointer-frame-semantics

REVISION DETAIL
  https://phabricator.kde.org/D10235

To: graesslin, #kwin, #plasma, #frameworks, romangg
Cc: romangg, plasma-devel, schernikov, michaelh, kmorwinski, ZrenBot, 
alexeymin, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein

D10235: [server] Add support for the frame semantics of Pointer version 5

[Roman Gilg]

romangg edited projects, added Plasma on Wayland; removed Plasma.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.

REPOSITORY
  R127 KWayland

BRANCH
  server-pointer-frame-semantics

REVISION DETAIL
  https://phabricator.kde.org/D10235

To: graesslin, #kwin, #plasma, #frameworks, romangg
Cc: romangg, plasma-devel, michaelh, kmorwinski, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10235: [server] Add support for the frame semantics of Pointer version 5

[Roman Gilg]

romangg accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.

REPOSITORY
  R127 KWayland

BRANCH
  server-pointer-frame-semantics

REVISION DETAIL
  https://phabricator.kde.org/D10235

To: graesslin, #kwin, #plasma, #frameworks, romangg
Cc: romangg, plasma-devel, michaelh, kmorwinski, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, schernikov, alexeymin, 
eliasp, hein

D10549: Don't crash if the cursor theme fails to create

[Roman Gilg]

romangg added inline comments.
Restricted Application edited projects, added KWin; removed Plasma.

INLINE COMMENTS

> graesslin wrote in wayland_cursor_theme.cpp:69
> As it returns a pointer it is impossible that we get the same pointer back.

Can we check differently if it is the same theme? Or should we in any case emit 
themeChanged when we are at this point already?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10549

To: graesslin, #kwin, #plasma, davidedmundson, romangg
Cc: romangg, plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

[Martin Flöser]

graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
graesslin requested review of this revision.

REVISION SUMMARY
  This is a preparation step to unset QT_QPA_PLATFORM from the wayland
  startup session script. Setting QT_QPA_PLATFORM breaks 3rd-party Qt
  software which does not bundle QtWayland. Most prominent example is
  the Qt installer itself (see
  https://bugreports.qt.io/browse/QTBUG-60222).
  
  On the other hand our Plasma workspace applications need to be forced to
  Wayland on a Wayland system. So we have a conflict between we want to
  set QT_QPA_PLATFORM and we don't want to set QT_QPA_PLATFORM.
  
  This change adds new API to KWorkspace to address this problem. The new
  method adjusts the QT_QPA_PLATFORM based on the XDG_SESSION_TYPE
  enviornment variable. It is completely opt-in. Meaning applications need
  to explicitly add the call prior to creating the QGuiApplication and if
  the user specifies either QT_QPA_PLATFORM env variable or any of the
  -platform command line argument variants, the platform detection is
  skipped.
  
  The change also adjusts all plasma-workspace applications which should
  use Wayland on Wayland to use the new API. The startup script on the
  other hand still sets QT_QPA_PLATFORM. We also have applications outside
  of plasma-workspace which needs this detection. Examples are:
  
  - powerdevil
  - systemsettings
  - kinfocenter
  
  Once this change is merged those applications can be adjusted by linking
  against PW::KWorkspace and afterwards QT_QPA_PLATFORM can be unset from
  startplasmacompositor.

TEST PLAN
  See added autotest

REPOSITORY
  R120 Plasma Workspace

BRANCH
  platform-detection

REVISION DETAIL
  https://phabricator.kde.org/D10816

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/main.cpp
  ksmserver/logout-greeter/main.cpp
  ksmserver/switchuser-greeter/main.cpp
  ksplash/ksplashqml/CMakeLists.txt
  ksplash/ksplashqml/main.cpp
  kuiserver/CMakeLists.txt
  kuiserver/main.cpp
  libkworkspace/CMakeLists.txt
  libkworkspace/autotests/CMakeLists.txt
  libkworkspace/autotests/testPlatformDetection.cpp
  libkworkspace/kworkspace.cpp
  libkworkspace/kworkspace.h
  shell/CMakeLists.txt
  shell/main.cpp
  startkde/kcminit/CMakeLists.txt
  startkde/kcminit/main.cpp
  systemmonitor/CMakeLists.txt
  systemmonitor/main.cpp

To: graesslin, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10807: fileindexerconfig: Exclude Vaults by default

[Henrik Fehlauer]

rkflx added a comment.


  What about users who manually create and mount FUSE-type encrypted 
directories? Plasma Vault is just a nice interface for this workflow, after all.
  
  A more general approach would be to look at the filesystem type in `mount` 
(do we have an API for that?). I'd imagine a user configurable whitelist and/or 
blacklist (in a config file, not sure that's UI material) would be most 
flexible. Perhaps there's already similar code in Baloo for handling removable 
devices or remote filesystems, or is this all based on some hardcoded path 
heuristics?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10807

To: michaelh, #baloo, #frameworks, ngraham, #plasma
Cc: rkflx, alexeymin, plasma-devel, ivan, nicolasfella, ashaposhnikov, 
michaelh, kmorwinski, spoorun, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10549: Don't crash if the cursor theme fails to create

[Martin Flöser]

graesslin added inline comments.
Restricted Application edited projects, added Plasma; removed KWin.

INLINE COMMENTS

> romangg wrote in wayland_cursor_theme.cpp:69
> Only do if theme really changes (`theme && m_theme != theme`).

As it returns a pointer it is impossible that we get the same pointer back.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10549

To: graesslin, #kwin, #plasma, davidedmundson, romangg
Cc: romangg, plasma-devel, kwin, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, iodelay, bwowk, hardening

D10235: [server] Add support for the frame semantics of Pointer version 5

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.


  In D10235#213009 , @romangg wrote:
  
  > Shouldn't the sendFrame event sent by the compositor explicitly? The way 
it's currently send after each event compositors are not able to group these.
  
  
  Yes and no. For all the events we currently support, there is no grouping. 
For new event types, which we do not yet support, we need to add API to allow 
the compositer to send the frame.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10235

To: graesslin, #kwin, #plasma, #frameworks
Cc: romangg, plasma-devel, schernikov, michaelh, kmorwinski, ZrenBot, 
alexeymin, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein