date:20180318

D11469: [Mouse KCM] Add X11 libinput exclusive backend and UI

2018-03-18 Thread Nathaniel Graham

ngraham added inline comments.

INLINE COMMENTS

> main_deviceless.qml:62
> +
> +Column {
> +spacing: units.smallSpacing * 2

Do you really need to define each individual column like this? Seems like a 
code small to me.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11469

To: romangg, #plasma
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11469: [Mouse KCM] Add X11 libinput exclusive backend and UI

2018-03-18 Thread Andres Betts

abetts added a comment.


  In D11469#228987 , @ngraham wrote:
  
  > Some more UI comments:
  >
  > - Right now it looks pretty awkward with everything left-justified. 
Centering would seem to be more natural.
  > - Since the speed/acceleration is the most commonly-changed settings, let's 
move it up to the top.
  > - I think we could put bottom checkbox on the top, unifying all the 
"behavior"-style settings in one place.
  > - This would seem like a good candidate for using Marco's FormLayout, or at 
least copying the style. That means aligning all the controls and putting 
labels to the left of them  (except for checkboxes, which always have labels 
only on the right.
  >
  >   Here's an exceptionally crude ASCII mockup of what I'm imagining:
  >
  >   ``` Speed: ---|--- Acceleration profile: ( ) Flat (o) 
Adaptive
  >   [ ] Left-handed mode
  >   [ ] Emulate middle button
  >   [X] Invert scroll direction ```
  
  
  +1 on this!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11469

To: romangg, #plasma
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11469: [Mouse KCM] Add X11 libinput exclusive backend and UI

2018-03-18 Thread Nathaniel Graham

ngraham added a comment.


  Some more UI comments:
  
  - Right now it looks pretty awkward with everything left-justified. Centering 
would seem to be more natural.
  - Since the speed/acceleration is the most commonly-changed settings, let's 
move it up to the top.
  - I think we could put bottom checkbox on the top, unifying all the 
"behavior"-style settings in one place.
  - This would seem like a good candidate for using Marco's FormLayout, or at 
least copying the style. That means aligning all the controls and putting 
labels to the left of them  (except for checkboxes, which always have labels 
only on the right.
  
  Here's an exceptionally crude ASCII mockup of what I'm imagining:
  
   Speed: ---|---
Acceleration profile: ( ) Flat
  (o) Adaptive

  [ ] Left-handed mode
  [ ] Emulate middle button
  [x] Invert scroll direction

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11469

To: romangg, #plasma
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11469: [Mouse KCM] Add X11 libinput exclusive backend and UI

2018-03-18 Thread Nathaniel Graham

ngraham added a comment.


  Ah, people are really going to like this.
  
  Instead of "acceleration", could we make the label say "speed"? I know 
"acceleration" is technically what it's controlling, but I think "speed" gets 
the point across just as well and it's more natural language--more in tune with 
what people are going to go looking for when they decide they want their mouse 
to go faster or slower.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11469

To: romangg, #plasma
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11471: [Touchpad KCM] Sync values to UI on Defaults in Wayland session

2018-03-18 Thread Roman Gilg

romangg added a comment.


  This is supposed to land in 5.12 as well.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11471

To: romangg, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11471: [Touchpad KCM] Sync values to UI on Defaults in Wayland session

2018-03-18 Thread Roman Gilg

romangg created this revision.
romangg added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  On Defaults the updated values need to be resynced to the QML part.
  Otherwise the UI is not updated.
  
  BUG: 392029

TEST PLAN
  Manually tested in Wayland session.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fixTouchpadWaylandDefaults

REVISION DETAIL
  https://phabricator.kde.org/D11471

AFFECTED FILES
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp

To: romangg, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11468: [Mouse KCM] Add KWin Wayland backend

2018-03-18 Thread Roman Gilg

romangg created this revision.
romangg added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  The primal goal of this patch is the addition of a new backend in order to
  configure pointer devices through KWin's libinput backend in a Wayland 
session.
  
  The implementation builds upon Xuetian's backend splitting work, which again
  was based on the backend splitting in the Touchpad KCM.
  
  To integrate this backend nicely the code structure is cleaned up and Ui code
  as well as backend specific code is pushed into the respective subdirectories
  similar to the Touchpad KCM code.

TEST PLAN
  Tested the old backend on X and the new libinput backend on Wayland.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  mouseKCM

REVISION DETAIL
  https://phabricator.kde.org/D11468

AFFECTED FILES
  kcms/input/AUTHORS
  kcms/input/CMakeLists.txt
  kcms/input/ChangeLog
  kcms/input/backends/kwin_wl.cmake
  kcms/input/backends/kwin_wl/kwin_wl_backend.cpp
  kcms/input/backends/kwin_wl/kwin_wl_backend.h
  kcms/input/backends/kwin_wl/kwin_wl_device.cpp
  kcms/input/backends/kwin_wl/kwin_wl_device.h
  kcms/input/backends/x11.cmake
  kcms/input/backends/x11/evdev_settings.cpp
  kcms/input/backends/x11/evdev_settings.h
  kcms/input/backends/x11/kapplymousetheme.cpp
  kcms/input/backends/x11/x11_backend.cpp
  kcms/input/backends/x11/x11_backend.h
  kcms/input/backends/x11/x11mousebackend.cpp
  kcms/input/backends/x11/x11mousebackend.h
  kcms/input/consoleUserPerms
  kcms/input/cursor_large.bdf
  kcms/input/cursor_large_black.pcf.gz
  kcms/input/cursor_large_white.pcf.gz
  kcms/input/cursor_small_white.pcf.gz
  kcms/input/inputbackend.cpp
  kcms/input/inputbackend.h
  kcms/input/kapplymousetheme.cpp
  kcms/input/kcm/configcontainer.cpp
  kcms/input/kcm/configcontainer.h
  kcms/input/kcm/configplugin.cpp
  kcms/input/kcm/configplugin.h
  kcms/input/kcm/libinput/components/ExclGroupBox.qml
  kcms/input/kcm/libinput/components/ToolTip.qml
  kcms/input/kcm/libinput/libinput_config.cpp
  kcms/input/kcm/libinput/libinput_config.h
  kcms/input/kcm/libinput/main.qml
  kcms/input/kcm/resources.qrc
  kcms/input/kcm/xlib/kcmmouse.ui
  kcms/input/kcm/xlib/xlib_config.cpp
  kcms/input/kcm/xlib/xlib_config.h
  kcms/input/kcmmouse.ui
  kcms/input/logging.cpp
  kcms/input/logging.h
  kcms/input/main.cpp
  kcms/input/misc/CMakeLists.txt
  kcms/input/misc/consoleUserPerms
  kcms/input/misc/cursor_large.bdf
  kcms/input/misc/cursor_large_black.pcf.gz
  kcms/input/misc/cursor_large_white.pcf.gz
  kcms/input/misc/cursor_small_white.pcf.gz
  kcms/input/misc/mouse_lh.png
  kcms/input/misc/mouse_lh.svgz
  kcms/input/misc/mouse_rh.png
  kcms/input/misc/mouse_rh.svgz
  kcms/input/mouse.cpp
  kcms/input/mouse.h
  kcms/input/mousebackend.cpp
  kcms/input/mousebackend.h
  kcms/input/mousesettings.cpp
  kcms/input/mousesettings.h
  kcms/input/pics/CMakeLists.txt
  kcms/input/pics/mouse_lh.png
  kcms/input/pics/mouse_lh.svgz
  kcms/input/pics/mouse_rh.png
  kcms/input/pics/mouse_rh.svgz
  kcms/input/plugin.cpp
  kcms/input/plugin.h

To: romangg, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11198: [libbreezecommon] add box shadow helper

2018-03-18 Thread Vlad Zagorodniy

zzag updated this revision to Diff 29858.
zzag added a comment.


  don't forward declare Qt stuff

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11198?vs=29843=29858

REVISION DETAIL
  https://phabricator.kde.org/D11198

AFFECTED FILES
  CMakeLists.txt
  cmake/Modules/FindFFTW.cmake
  kstyle/CMakeLists.txt
  libbreezecommon/CMakeLists.txt
  libbreezecommon/breezeboxshadowhelper.cpp
  libbreezecommon/breezeboxshadowhelper.h
  libbreezecommon/config-breezecommon.h.cmake

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: broulik, abetts, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11198: [libbreezecommon] add box shadow helper

2018-03-18 Thread Hugo Pereira Da Costa

hpereiradacosta added inline comments.

INLINE COMMENTS

> breezeboxshadowhelper.h:30
> +class QRect;
> +
> +

I think the "rule" is to not use forward declarations for classes external to 
once project. 
Reason is that the upstream library might decide to turn a class into a struct, 
or an alias into future changes, which will then break your code.
Please include the headers here directly, and remove them from the cpp

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11198

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: broulik, abetts, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D10251: [RFC] Use mipmap filtering in window thumbnails

2018-03-18 Thread Julian Wolff

progwolff added a comment.


  Thanks!
  
  I tested it with several running applications, including windows with 
different apect ratios and combined previews for multiple instances of the same 
application. Looks great in every case.
  
  +1 from me!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10251

To: fredrik, #plasma, #vdg
Cc: progwolff, broulik, ngraham, hein, plasma-devel, #frameworks, michaelh, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-18 Thread David Edmundson

davidedmundson added a comment.


  > (btw that leak i think should be solved, @davidedmundson also has a rewrite 
of the wallpaper code which should make it take less memory, as right now the 
first few times it changes memory gooes up not for an actual leak but more for 
the management not being correct)
  
  At the risk of getting offtopic. The leak is not in Plasma code, no matter 
how amazingly I rewrote the wallpaper it won't make a difference there. Sorry :/

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D11308

To: ngraham, #plasma, #vdg, graesslin, abetts
Cc: Fuchs, broulik, davidedmundson, zzag, Pitel, progwolff, abetts, hein, mart, 
graesslin, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol

D11198: [libbreezecommon] add box shadow helper

2018-03-18 Thread Vlad Zagorodniy

zzag updated this revision to Diff 29843.
zzag edited the summary of this revision.
zzag added a comment.


  - add comments

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11198?vs=29535=29843

REVISION DETAIL
  https://phabricator.kde.org/D11198

AFFECTED FILES
  CMakeLists.txt
  cmake/Modules/FindFFTW.cmake
  kstyle/CMakeLists.txt
  libbreezecommon/CMakeLists.txt
  libbreezecommon/breezeboxshadowhelper.cpp
  libbreezecommon/breezeboxshadowhelper.h
  libbreezecommon/config-breezecommon.h.cmake

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: broulik, abetts, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11455: Update kcmstyle docbook

2018-03-18 Thread Burkhard Lück

lueck created this revision.
lueck added reviewers: Plasma, Documentation.
Restricted Application added a project: Plasma.
Restricted Application added subscribers: kde-doc-english, plasma-devel.
lueck requested review of this revision.

REVISION SUMMARY
  remove menubar style options
  add info how to use global menu now

TEST PLAN
  checkXML5 index.docbook

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11455

AFFECTED FILES
  doc/kcontrol/kcmstyle/index.docbook

To: lueck, #plasma, #documentation
Cc: plasma-devel, kde-doc-english, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10251: [RFC] Use mipmap filtering in window thumbnails

2018-03-18 Thread Fredrik Höglund

fredrik updated this revision to Diff 29832.
fredrik added a comment.


  Rebase on master.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10251?vs=26374=29832

REVISION DETAIL
  https://phabricator.kde.org/D10251

AFFECTED FILES
  src/declarativeimports/core/windowthumbnail.cpp
  src/declarativeimports/core/windowthumbnail.h

To: fredrik, #plasma, #vdg
Cc: progwolff, broulik, ngraham, hein, plasma-devel, #frameworks, michaelh, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11447: No longer export QT_QPA_PLATFORM env variable to the session

2018-03-18 Thread Martin Flöser

graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
graesslin requested review of this revision.

REVISION SUMMARY
  As discussed the env variables are no longer exported. Thus Qt
  applications follow the default qpa platform they are compiled with and
  thus still function if they are packaged with a Qt without QtWayland.
  Plasma's internal processes pick the qpa platform depending on the
  session type as well as our flatpak apps.
  
  KRunner and Plasmashell are adjusted to not leak the env variable they
  set for themselves.

TEST PLAN
  Started a wayland session, verified with KWin's debug console
  that plasmashell and krunner are wayland. Launched kwrite from both plasma
  and krunner and verified that it's xcb

REPOSITORY
  R120 Plasma Workspace

BRANCH
  unset-qt-qpa-platform

REVISION DETAIL
  https://phabricator.kde.org/D11447

AFFECTED FILES
  krunner/main.cpp
  shell/main.cpp
  startkde/startplasmacompositor.cmake

To: graesslin, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11446: Use platform detection from KWorkspace in Powerdevil

2018-03-18 Thread Martin Flöser

graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
graesslin requested review of this revision.

REVISION SUMMARY
  On a wayland session powerdevil needs to use Wayland platform.

TEST PLAN
  Only compile tested, changes are identical to the tested
  systemsettings patch.

REPOSITORY
  R122 Powerdevil

BRANCH
  platform-detection

REVISION DETAIL
  https://phabricator.kde.org/D11446

AFFECTED FILES
  CMakeLists.txt
  daemon/CMakeLists.txt
  daemon/powerdevilapp.cpp

To: graesslin, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11445: Use platform detection in SystemSettings

2018-03-18 Thread Martin Flöser

graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
graesslin requested review of this revision.

REVISION SUMMARY
  SystemSettings needs to run on Wayland in a Wayland session and on X11
  in an X11 session.

TEST PLAN
  unset QT_QPA_PLATFORM and XDG_SESSION_TYPE -> x11 window,
  reset XDG_SESSION_TYPE to wayland -> wayland window

REPOSITORY
  R124 System Settings

BRANCH
  platform-detection

REVISION DETAIL
  https://phabricator.kde.org/D11445

AFFECTED FILES
  CMakeLists.txt
  app/CMakeLists.txt
  app/main.cpp

To: graesslin, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

2018-03-18 Thread Martin Flöser

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b5c326996309: Add platform detection to KWorkspace 
library to adjust QT_QPA_PLATFORM (authored by graesslin).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10816?vs=28556=29809

REVISION DETAIL
  https://phabricator.kde.org/D10816

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/main.cpp
  ksmserver/logout-greeter/main.cpp
  ksmserver/switchuser-greeter/main.cpp
  ksplash/ksplashqml/CMakeLists.txt
  ksplash/ksplashqml/main.cpp
  kuiserver/CMakeLists.txt
  kuiserver/main.cpp
  libkworkspace/CMakeLists.txt
  libkworkspace/autotests/CMakeLists.txt
  libkworkspace/autotests/testPlatformDetection.cpp
  libkworkspace/kworkspace.cpp
  libkworkspace/kworkspace.h
  shell/CMakeLists.txt
  shell/main.cpp
  startkde/kcminit/CMakeLists.txt
  startkde/kcminit/main.cpp
  systemmonitor/CMakeLists.txt
  systemmonitor/main.cpp

To: graesslin, #plasma, romangg
Cc: davidedmundson, romangg, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11469: [Mouse KCM] Add X11 libinput exclusive backend and UI

D11469: [Mouse KCM] Add X11 libinput exclusive backend and UI

D11469: [Mouse KCM] Add X11 libinput exclusive backend and UI

D11469: [Mouse KCM] Add X11 libinput exclusive backend and UI

D11471: [Touchpad KCM] Sync values to UI on Defaults in Wayland session

D11471: [Touchpad KCM] Sync values to UI on Defaults in Wayland session

D11468: [Mouse KCM] Add KWin Wayland backend

D11198: [libbreezecommon] add box shadow helper

D11198: [libbreezecommon] add box shadow helper

D10251: [RFC] Use mipmap filtering in window thumbnails

D11308: Use the default Plasma wallpaper on the lock screen

D11198: [libbreezecommon] add box shadow helper

D11455: Update kcmstyle docbook

D10251: [RFC] Use mipmap filtering in window thumbnails

D11447: No longer export QT_QPA_PLATFORM env variable to the session

D11446: Use platform detection from KWorkspace in Powerdevil

D11445: Use platform detection in SystemSettings

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

18 matches

Site Navigation

Mail list logo

Footer information