D11567: Fix use of assert/crash when removing global shortcut

[Martin Flöser]

graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.


  Or just remove the assert.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11567

To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Re: KDE CI: Plasma plasma-framework kf5-qt5 SUSEQt5.9 - Build # 248 - Still Failing!

[David Edmundson]

​Failure is just because the p-f on Plasma doesn't have latest kpackage.

the p-f on the frameworks build does build correctly.
It's a non-issue which will get synced up soon.

The failing unit tests are another matter.

D11567: Fix use of assert/crash when removing global shortcut

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  I'm not the author, but it's pretty clear what the intention was.
  
  We expect to get one result back from proxyModel->match
  We use results.first(), so we want to check we have at least one entry.
  The assert was written backwards
  
  BUG: 387444

TEST PLAN
  Can now remove a group without a crash

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11567

AFFECTED FILES
  kcms/keys/kglobalshortcutseditor.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11558: Don't show cache memory in systemloadviewer bars

[Henrik Fehlauer]

rkflx added a comment.


  In D11558#231153 , @davidedmundson 
wrote:
  
  > > Quickly seeing the difference between "free" and "cached" can be quite 
useful.
  >
  > Useful for what?
  
  
  For a start, there's a problem with a system (and thus performance) if cache 
usage is always very low. "Unused" memory does not help in this case. Seeing 
this value staying in a "good" state helps to confirm that despite large memory 
hogs coming and going the cache is utilized optimally. If not, I might add more 
memory or change the system configuration (e.g. ban Electron apps ;) to improve 
cache utilization. If I would only see "free" memory, I would not be able to 
evaluate this.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D11558

To: davidedmundson, #plasma
Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11558: Don't show cache memory in systemloadviewer bars

[David Edmundson]

davidedmundson added a comment.


  > Quickly seeing the difference between "free" and "cached" can be quite 
useful.
  
  Useful for what?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D11558

To: davidedmundson, #plasma
Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11558: Don't show cache memory in systemloadviewer bars

[Henrik Fehlauer]

rkflx added a comment.


  > It's a completely useless value to know vs how much memory is free.
  
  FWIW, I find it's a useful information to assess the state of a system: It 
grows with time after a reboot, and it shows nicely how memory intensive 
processes eventually take a toll on the cache until they are closed and I'm 
left with lots of free memory but only little cache. Quickly seeing the 
difference between "free" and "cached" can be quite useful.
  
  IMO it would be enough to adapt the colours a bit (and possibly improve the 
tooltip).

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D11558

To: davidedmundson, #plasma
Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11563: Remove long-time deprecated Encoding=UTF-8 from desktop format files

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Based on request on irc # plasma yesterday:
  [14:34]  frinring: Feel free to remove it again - in all branches 
please
  
  If okayed, would do the same in the Plasma/5.12 branch to all other plasma 
repos I touched before in master only for this.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11563

To: kossebau, #plasma, fvogt, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11563: Remove long-time deprecated Encoding=UTF-8 from desktop format files

[Friedrich W . H . Kossebau]

kossebau updated this revision to Diff 30164.
kossebau added a comment.


  remove unrelated fields.txt file

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11563?vs=30163=30164

BRANCH
  removeencoding

REVISION DETAIL
  https://phabricator.kde.org/D11563

AFFECTED FILES
  applets/appmenu/package/metadata.desktop
  applets/batterymonitor/package/metadata.desktop
  applets/calendar/package/metadata.desktop
  applets/digital-clock/package/metadata.desktop
  applets/lock_logout/metadata.desktop
  applets/mediacontroller/metadata.desktop
  applets/notifications/package/metadata.desktop
  applets/systemmonitor/cpu/metadata.desktop
  applets/systemmonitor/diskactivity/metadata.desktop
  applets/systemmonitor/diskusage/metadata.desktop
  applets/systemmonitor/memory/metadata.desktop
  applets/systemmonitor/net/metadata.desktop
  applets/systemtray/container/package/metadata.desktop
  applets/systemtray/package/metadata.desktop
  dataengines/executable/plasma-dataengine-executable.desktop
  dataengines/favicons/plasma-dataengine-favicons.desktop
  dataengines/geolocation/plasma-dataengine-geolocation.desktop
  dataengines/network/plasma-dataengine-network.desktop
  dataengines/packagekit/plasma-dataengine-packagekit.desktop
  dataengines/rss/plasma-dataengine-rss.desktop
  dataengines/systemmonitor/plasma-dataengine-systemmonitor.desktop
  kioslave/desktop/Home.desktop
  kioslave/desktop/directory.desktop
  kioslave/desktop/directory.trash
  lookandfeel/metadata.desktop
  menu/desktop/hidden.directory
  menu/desktop/kf5-development-translation.directory
  menu/desktop/kf5-development-webdevelopment.directory
  menu/desktop/kf5-development.directory
  menu/desktop/kf5-editors.directory
  menu/desktop/kf5-edu-languages.directory
  menu/desktop/kf5-edu-mathematics.directory
  menu/desktop/kf5-edu-miscellaneous.directory
  menu/desktop/kf5-edu-science.directory
  menu/desktop/kf5-edu-tools.directory
  menu/desktop/kf5-education.directory
  menu/desktop/kf5-games-arcade.directory
  menu/desktop/kf5-games-board.directory
  menu/desktop/kf5-games-card.directory
  menu/desktop/kf5-games-kids.directory
  menu/desktop/kf5-games-logic.directory
  menu/desktop/kf5-games-roguelikes.directory
  menu/desktop/kf5-games-strategy.directory
  menu/desktop/kf5-games.directory
  menu/desktop/kf5-graphics.directory
  menu/desktop/kf5-internet-terminal.directory
  menu/desktop/kf5-internet.directory
  menu/desktop/kf5-main.directory
  menu/desktop/kf5-more.directory
  menu/desktop/kf5-multimedia.directory
  menu/desktop/kf5-office.directory
  menu/desktop/kf5-science.directory
  menu/desktop/kf5-settingsmenu.directory
  menu/desktop/kf5-system-terminal.directory
  menu/desktop/kf5-system.directory
  menu/desktop/kf5-toys.directory
  menu/desktop/kf5-unknown.directory
  menu/desktop/kf5-utilities-accessibility.directory
  menu/desktop/kf5-utilities-desktop.directory
  menu/desktop/kf5-utilities-file.directory
  menu/desktop/kf5-utilities-peripherals.directory
  menu/desktop/kf5-utilities-pim.directory
  menu/desktop/kf5-utilities-xutils.directory
  menu/desktop/kf5-utilities.directory
  plasma.desktop.cmake
  plasmawayland.desktop.cmake
  wallpapers/color/metadata.desktop
  wallpapers/image/imagepackage/metadata.desktop
  wallpapers/image/slideshowpackage/metadata.desktop

To: kossebau, #plasma, fvogt, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11563: Remove long-time deprecated Encoding=UTF-8 from desktop format files

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, fvogt, broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  The "Encoding" entry had been deprecated in 2006
  
(https://cgit.freedesktop.org/xdg/xdg-specs/commit/?id=6855384d021d88557f80674798c584c15b547f36)
  and there is no current workspace known which still requires it being set
  (incl. Plasma itself).
  Also has the usage been incomplete and sometimes not at the beginning as
  required if used (once scripty had sorted all entries in desktop files
  alphabetically and it was not restored everywhere).
  Removing them altogether creates consistency and avoids further confusion
  about and wasted resources for this unused data bit.
  
  Removing those entries also from Plasma/5.12 branch avoid conflicts on
  merging to master, given the entries are often next to translated entries,
  or generous merging which lets the entries slip back into existance.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  removeencoding

REVISION DETAIL
  https://phabricator.kde.org/D11563

AFFECTED FILES
  applets/appmenu/package/metadata.desktop
  applets/batterymonitor/package/metadata.desktop
  applets/calendar/package/metadata.desktop
  applets/digital-clock/package/metadata.desktop
  applets/lock_logout/metadata.desktop
  applets/mediacontroller/metadata.desktop
  applets/notifications/package/metadata.desktop
  applets/systemmonitor/cpu/metadata.desktop
  applets/systemmonitor/diskactivity/metadata.desktop
  applets/systemmonitor/diskusage/metadata.desktop
  applets/systemmonitor/memory/metadata.desktop
  applets/systemmonitor/net/metadata.desktop
  applets/systemtray/container/package/metadata.desktop
  applets/systemtray/package/metadata.desktop
  dataengines/executable/plasma-dataengine-executable.desktop
  dataengines/favicons/plasma-dataengine-favicons.desktop
  dataengines/geolocation/plasma-dataengine-geolocation.desktop
  dataengines/network/plasma-dataengine-network.desktop
  dataengines/packagekit/plasma-dataengine-packagekit.desktop
  dataengines/rss/plasma-dataengine-rss.desktop
  dataengines/systemmonitor/plasma-dataengine-systemmonitor.desktop
  dataengines/weather/fields.txt
  kioslave/desktop/Home.desktop
  kioslave/desktop/directory.desktop
  kioslave/desktop/directory.trash
  lookandfeel/metadata.desktop
  menu/desktop/hidden.directory
  menu/desktop/kf5-development-translation.directory
  menu/desktop/kf5-development-webdevelopment.directory
  menu/desktop/kf5-development.directory
  menu/desktop/kf5-editors.directory
  menu/desktop/kf5-edu-languages.directory
  menu/desktop/kf5-edu-mathematics.directory
  menu/desktop/kf5-edu-miscellaneous.directory
  menu/desktop/kf5-edu-science.directory
  menu/desktop/kf5-edu-tools.directory
  menu/desktop/kf5-education.directory
  menu/desktop/kf5-games-arcade.directory
  menu/desktop/kf5-games-board.directory
  menu/desktop/kf5-games-card.directory
  menu/desktop/kf5-games-kids.directory
  menu/desktop/kf5-games-logic.directory
  menu/desktop/kf5-games-roguelikes.directory
  menu/desktop/kf5-games-strategy.directory
  menu/desktop/kf5-games.directory
  menu/desktop/kf5-graphics.directory
  menu/desktop/kf5-internet-terminal.directory
  menu/desktop/kf5-internet.directory
  menu/desktop/kf5-main.directory
  menu/desktop/kf5-more.directory
  menu/desktop/kf5-multimedia.directory
  menu/desktop/kf5-office.directory
  menu/desktop/kf5-science.directory
  menu/desktop/kf5-settingsmenu.directory
  menu/desktop/kf5-system-terminal.directory
  menu/desktop/kf5-system.directory
  menu/desktop/kf5-toys.directory
  menu/desktop/kf5-unknown.directory
  menu/desktop/kf5-utilities-accessibility.directory
  menu/desktop/kf5-utilities-desktop.directory
  menu/desktop/kf5-utilities-file.directory
  menu/desktop/kf5-utilities-peripherals.directory
  menu/desktop/kf5-utilities-pim.directory
  menu/desktop/kf5-utilities-xutils.directory
  menu/desktop/kf5-utilities.directory
  plasma.desktop.cmake
  plasmawayland.desktop.cmake
  wallpapers/color/metadata.desktop
  wallpapers/image/imagepackage/metadata.desktop
  wallpapers/image/slideshowpackage/metadata.desktop

To: kossebau, #plasma, fvogt, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10297: Add new "Tools" button above System Monitor's process list

[Henrik Fehlauer]

rkflx added inline comments.

INLINE COMMENTS

> rkflx wrote in ksysguardprocesslist.cpp:412
> Could you do an exact match on the filename, i.e. only the last part of the 
> full path? There might be situations where "System Monitor" is developed or 
> installed in a directory containing this string by chance.

Recently I learned comparing with `qApp->desktopFileName()` might be even 
better than looking at the path of the executable…

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D10297

To: gregormi, #plasma, colomar, kossebau, broulik, mart, hein
Cc: apol, anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D11559: Fix default colour used by Swap monitor

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  An obvious typo. Thanks for this fix! PS: A Screenshot would have been nice, 
though :-)

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11559

To: davidedmundson, #plasma, dhaumann
Cc: dhaumann, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11561: fix typos in UI strings

[Frederik Schwarzer]

schwarzer created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
schwarzer requested review of this revision.

REPOSITORY
  R845 Plasma Vault

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11561

AFFECTED FILES
  kded/engine/vault.cpp
  kded/ui/cryfscypherchooserwidget.ui

To: schwarzer
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10670: Reduce plasmashell frozen time

[Ben Cooksley]

bcooksley added a comment.


  Phabricator considers reviews approved only when all individual and group 
reviewers have approved it.
  
  In this instance, nobody approved on behalf of #frameworks 
 and @mwolff has changes requested 
still.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10670

To: jtamate, #frameworks, #plasma, mwolff, davidedmundson
Cc: bcooksley, hein, mwolff, plasma-devel, davidedmundson, michaelh, ZrenBot, 
ngraham, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11559: Fix default colour used by Swap monitor

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  It has a typo, meaning it gives an error (in a completely unrelated
  place...because QML) and doesn't actually render anything.

TEST PLAN
  No more error

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11559

AFFECTED FILES
  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11558: Don't show cache memory in systemloadviewer bars

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  It's a completely useless value to know vs how much memory is free.
  It's problematic because the bar is inconsistent with the tooltip, and
  by default the system load viewer chooses a colour very similar to the
  application used memory.
  
  BUG: 391918

TEST PLAN
  Ran it
  (there's some unrelated bugs/warnings in this applet that need fixing)
  Bar showed a sensible value that matched tooltip, rather than 
  looking 100% full all the time

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11558

AFFECTED FILES
  applets/systemloadviewer/package/contents/config/main.xml
  applets/systemloadviewer/package/contents/ui/ColorSettings.qml
  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10670: Reduce plasmashell frozen time

[Eike Hein]

hein added a comment.


  I think it's because mwolff did "Requesting changes" and he didn't accept.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10670

To: jtamate, #frameworks, #plasma, mwolff, davidedmundson
Cc: hein, mwolff, plasma-devel, davidedmundson, michaelh, ZrenBot, ngraham, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10670: Reduce plasmashell frozen time

[Jaime Torres Amate]

jtamate added a comment.


  In D10670#230938 , @hein wrote:
  
  > > This revision was not accepted when it landed; it landed in state Needs 
Review.
  >
  > Weird, David accepted it though?
  
  
  Yes. Shouldn't this be reported as a bug to phabricator? It has happened  to 
me twice.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10670

To: jtamate, #frameworks, #plasma, mwolff, davidedmundson
Cc: hein, mwolff, plasma-devel, davidedmundson, michaelh, ZrenBot, ngraham, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 - Build # 84 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/84/
 Project:
Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 21 Mar 2018 18:27:07 +
 Build duration:
8 min 34 sec and counting
   CONSOLE OUTPUT
  [...truncated 68.38 KB...]USER  = 'jenkins'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/84/display/redirect?page=changes'PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/usr/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9"-- The C compiler identification is Clang 4.0.0-- The CXX compiler identification is Clang 4.0.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - SuccessCMake Error at CMakeLists.txt:27 (include):  include could not find load file:ECMSetupQtPluginMacroNames-- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.45.0") -- Found KF5Archive: /usr/home/jenkins/install-prefix/lib/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.45.0") -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.45.0") -- Found KF5ConfigWidgets: /usr/home/jenkins/install-prefix/lib/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.45.0") -- Found KF5CoreAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.45.0") -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.45.0") -- Found KF5Declarative: /usr/home/jenkins/install-prefix/lib/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.45.0") -- Found KF5GlobalAccel: /usr/home/jenkins/install-prefix/lib/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.45.0") -- Found KF5GuiAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.45.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/local/bin/python3.6 (found version "3.6.4") -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.45.0") -- Found KF5IconThemes: /usr/home/jenkins/install-prefix/lib/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.45.0") -- Found KF5KIO: /usr/home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.45.0") -- Found KF5Service: /usr/home/jenkins/install-prefix/lib/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.45.0") -- Found KF5WindowSystem: /usr/home/jenkins/install-prefix/lib/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.45.0") -- Found KF5XmlGui: /usr/home/jenkins/install-prefix/lib/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake (found version "5.45.0") -- Found KF5Notifications: /usr/home/jenkins/install-prefix/lib/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version "5.45.0") -- Found KF5Package: /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageConfig.cmake (found version "5.45.0") -- Found KF5Kirigami2: /usr/home/jenkins/install-prefix/lib/cmake/KF5Kirigami2/KF5Kirigami2Config.cmake (found version "5.45.0") -- Found KF5Wayland: /usr/home/jenkins/install-prefix/lib/cmake/KF5Wayland/KF5WaylandConfig.cmake (found version "5.45.0") -- Found KF5DocTools: /usr/home/jenkins/install-prefix/lib/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.45.0") -- Found KF5: success (found suitable version "5.45.0", minimum required is "5.44.0") found components:  Activities Archive Config ConfigWidgets CoreAddons DBusAddons Declarative GlobalAccel GuiAddons I18n IconThemes KIO Service WindowSystem XmlGui Notifications Package Kirigami2 Wayland DocTools -- Looking for XOpenDisplay in /usr/local/lib/libX11.so;/usr/local/lib/libXext.so-- Looking for XOpenDisplay in 

D10670: Reduce plasmashell frozen time

[Eike Hein]

hein added a comment.


  > This revision was not accepted when it landed; it landed in state Needs 
Review.
  
  Weird, David accepted it though?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10670

To: jtamate, #frameworks, #plasma, mwolff, davidedmundson
Cc: hein, mwolff, plasma-devel, davidedmundson, michaelh, ZrenBot, ngraham, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-framework stable-kf5-qt5 SUSEQt5.9 - Build # 111 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20SUSEQt5.9/111/
 Project:
Plasma plasma-framework stable-kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 21 Mar 2018 18:27:07 +
 Build duration:
1 min 47 sec and counting
   CONSOLE OUTPUT
  [...truncated 91.44 KB...]QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 SUSEQt5.9"-- The C compiler identification is GNU 7.3.1-- The CXX compiler identification is GNU 7.3.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - SuccessCMake Error at CMakeLists.txt:27 (include):  include could not find load file:ECMSetupQtPluginMacroNames-- Found KF5Activities: /home/jenkins/install-prefix/lib64/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.45.0") -- Found KF5Archive: /home/jenkins/install-prefix/lib64/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.45.0") -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.45.0") -- Found KF5ConfigWidgets: /home/jenkins/install-prefix/lib64/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.45.0") -- Found KF5CoreAddons: /home/jenkins/install-prefix/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.45.0") -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.45.0") -- Found KF5Declarative: /home/jenkins/install-prefix/lib64/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.45.0") -- Found KF5GlobalAccel: /home/jenkins/install-prefix/lib64/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.45.0") -- Found KF5GuiAddons: /home/jenkins/install-prefix/lib64/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.45.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/bin/python3.6 (found version "3.6.4") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.45.0") -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.45.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.45.0") -- Found KF5Service: /home/jenkins/install-prefix/lib64/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.45.0") -- Found KF5WindowSystem: /home/jenkins/install-prefix/lib64/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.45.0") -- Found KF5XmlGui: /home/jenkins/install-prefix/lib64/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake (found version "5.45.0") -- Found KF5Notifications: /home/jenkins/install-prefix/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version "5.45.0") -- Found KF5Package: /home/jenkins/install-prefix/lib64/cmake/KF5Package/KF5PackageConfig.cmake (found version "5.45.0") -- Found KF5Kirigami2: /home/jenkins/install-prefix/lib64/cmake/KF5Kirigami2/KF5Kirigami2Config.cmake (found version "5.45.0") -- Found KF5Wayland: /home/jenkins/install-prefix/lib64/cmake/KF5Wayland/KF5WaylandConfig.cmake (found version "5.45.0") -- Found KF5DocTools: /home/jenkins/install-prefix/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.45.0") -- Found KF5: success (found suitable version "5.45.0", minimum required is "5.44.0") found components:  Activities Archive Config ConfigWidgets CoreAddons DBusAddons Declarative GlobalAccel GuiAddons I18n IconThemes KIO Service WindowSystem XmlGui Notifications Package Kirigami2 Wayland DocTools -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so-- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so - found-- Looking for gethostbyname-- Looking 

KDE CI: Plasma plasma-framework kf5-qt5 SUSEQt5.9 - Build # 248 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20SUSEQt5.9/248/
 Project:
Plasma plasma-framework kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 21 Mar 2018 18:27:07 +
 Build duration:
1 min 28 sec and counting
   CONSOLE OUTPUT
  [...truncated 90.79 KB...]QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 SUSEQt5.9"-- The C compiler identification is GNU 7.3.1-- The CXX compiler identification is GNU 7.3.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - SuccessCMake Error at CMakeLists.txt:27 (include):  include could not find load file:ECMSetupQtPluginMacroNames-- Found KF5Activities: /home/jenkins/install-prefix/lib64/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.45.0") -- Found KF5Archive: /home/jenkins/install-prefix/lib64/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.45.0") -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.45.0") -- Found KF5ConfigWidgets: /home/jenkins/install-prefix/lib64/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.45.0") -- Found KF5CoreAddons: /home/jenkins/install-prefix/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.45.0") -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.45.0") -- Found KF5Declarative: /home/jenkins/install-prefix/lib64/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.45.0") -- Found KF5GlobalAccel: /home/jenkins/install-prefix/lib64/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.45.0") -- Found KF5GuiAddons: /home/jenkins/install-prefix/lib64/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.45.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/bin/python3.6 (found version "3.6.4") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.45.0") -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.45.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.45.0") -- Found KF5Service: /home/jenkins/install-prefix/lib64/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.45.0") -- Found KF5WindowSystem: /home/jenkins/install-prefix/lib64/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.45.0") -- Found KF5XmlGui: /home/jenkins/install-prefix/lib64/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake (found version "5.45.0") -- Found KF5Notifications: /home/jenkins/install-prefix/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version "5.45.0") -- Found KF5Package: /home/jenkins/install-prefix/lib64/cmake/KF5Package/KF5PackageConfig.cmake (found version "5.45.0") -- Found KF5Kirigami2: /home/jenkins/install-prefix/lib64/cmake/KF5Kirigami2/KF5Kirigami2Config.cmake (found version "5.45.0") -- Found KF5Wayland: /home/jenkins/install-prefix/lib64/cmake/KF5Wayland/KF5WaylandConfig.cmake (found version "5.45.0") -- Found KF5DocTools: /home/jenkins/install-prefix/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.45.0") -- Found KF5: success (found suitable version "5.45.0", minimum required is "5.44.0") found components:  Activities Archive Config ConfigWidgets CoreAddons DBusAddons Declarative GlobalAccel GuiAddons I18n IconThemes KIO Service WindowSystem XmlGui Notifications Package Kirigami2 Wayland DocTools -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so-- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so - found-- Looking for gethostbyname-- Looking for gethostbyname - 

D10670: Reduce plasmashell frozen time

[Jaime Torres Amate]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:33ddaaa23f6b: Reduce plasmashell frozen time (authored by 
jtamate).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10670?vs=27672=30138

REVISION DETAIL
  https://phabricator.kde.org/D10670

AFFECTED FILES
  src/plasma/private/effectwatcher.cpp

To: jtamate, #frameworks, #plasma, mwolff, davidedmundson
Cc: mwolff, plasma-devel, davidedmundson, michaelh, ZrenBot, ngraham, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: PulseAudio switch-on-connect and device-manager modules

[Nate Graham]

 On Wed, 21 Mar 2018 10:27:50 -0700 David 
Edmundson wrote  
 > In the current state when in "automatic mode", the device preference is 
 > still visible but you now only see one entry in the audio playback device 
 > preference column. So at least there's some indication.
 > 
 > That part is definitely not ideal, merging the phonon and PlasmaPA kcms is 
 > something I want to see happen as they have overlapping tasks at different 
 > levels in the stack. 

Agreed. Looks like this is our path forward. Merging these KCMs and making that 
UI more obvious also lines up well with both 
https://phabricator.kde.org/project/view/254/ and 
https://phabricator.kde.org/T6831

Do we have a task or a bug tracking this work?

Nate

Re: PulseAudio switch-on-connect and device-manager modules

[David Edmundson]

>If option 1 is chosen, doesn't that disable functionality in the Phonon
KCM?

Yes.

In the current state when in "automatic mode", the device preference is
still visible but you now only see one entry in the audio playback device
preference column. So at least there's some indication.

That part is definitely not ideal, merging the phonon and PlasmaPA kcms is
something I want to see happen as they have overlapping tasks at different
levels in the stack.

David

Re: PulseAudio switch-on-connect and device-manager modules

[Nate Graham]

 On Wed, 21 Mar 2018 10:13:11 -0700 David 
Edmundson wrote  

 > I'll try explaining again.
 > 
 > Default outputs can be either:
 > 
 > 1) Automatic
 > 2) Chosen by the user
 > 
 > There is one PA module for automatic behaviour, there is one PA module for 
 > user-chosen behaviour.

If option 1 is chosen, doesn't that disable functionality in the Phonon KCM? Is 
the problem here that we don't have a good UI in the Phonon KCM for 
communicating that things are disabled because audio is being automatically 
routed through the last-connected device?

Nate

Re: PulseAudio switch-on-connect and device-manager modules

[David Edmundson]

On Wed, Mar 21, 2018 at 5:01 PM, Nate Graham  wrote:

>  On Wed, 21 Mar 2018 09:47:25 -0700 David Rosca
> wrote 
>  > As already said by David Edmundson, it works correctly.
>
> When I suggested in 392103 that we enable switch-on-connect by default,
> you said we couldn't do that because it would break the Phonon KCM (your
> exact words were "the entire "Audio/Video settings" KCM (phonon) won't work
> anymore."). That doesn't sound like "it works correctly" to me. The fact
> that these modules are mutually exclusive, yet used by different KCMs seems
> like an issue, especially if it imposes technical blockers to changing a
> default setting, or even starting up that conversation.
>

I'll try explaining again.

Default outputs can be either:
1) Automatic
2) Chosen by the user

There is one PA module for automatic behaviour, there is one PA module for
user-chosen behaviour.

This switch acts as a toggle between which we do.

Re: PulseAudio switch-on-connect and device-manager modules

[Nate Graham]

 On Wed, 21 Mar 2018 09:47:25 -0700 David Rosca wrote 
 
 > As already said by David Edmundson, it works correctly. 

When I suggested in 392103 that we enable switch-on-connect by default, you 
said we couldn't do that because it would break the Phonon KCM (your exact 
words were "the entire "Audio/Video settings" KCM (phonon) won't work 
anymore."). That doesn't sound like "it works correctly" to me. The fact that 
these modules are mutually exclusive, yet used by different KCMs seems like an 
issue, especially if it imposes technical blockers to changing a default 
setting, or even starting up that conversation.


 > Ideally, we would want behavior of both modules, but that's 
 > not possible.

Is this an upstream PulseAudio bug, then?

Nate

Re: PulseAudio switch-on-connect and device-manager modules

[David Rosca]

On Wed, Mar 21, 2018 at 4:51 PM, Nate Graham  wrote:
> Howdy folks,
>
> It seems that we have KCMs that conflict with one another:
> - The Phonon Audio/Video KCM uses the module-device-manager PulseAudio Module.
> - plasma-pa's KCM has an "Automatically switch all running streams when a new 
> output becomes available" checkbox that loads the switch-on-connect 
> PulseAudio module.
>
> ...But both modules can't be loaded at once. So plasma-pa's "Automatically 
> switch all running streams when a new output becomes available" checkbox does 
> not work in many circumstances.
>
> This is all relevant to our users who would like to have audio streams 
> automatically switched over when a new device becomes available (e.g. a 
> bluetooth or USB headset) and report that checking the "Automatically switch 
> all running streams when a new output becomes available" checkbox doesn't 
> enable that behavior for them.
>
> What's our path forward here?

As already said by David Edmundson, it works correctly.

Just to make it clear, this is what those two modules are doing:

module-device-manager allows to configure which device will be used
for given stream according to its role (what type is it, specified by
applications - eg. notifications, music, video, ...), but this only
works for existing (or already seen) devices.

module-switch-on-connect basically just switches all streams to newly
connected devices

As they both change devices for streams, they can't coexist without
producing unexpected results. You can see that there is no clear
winner to which module we should load by default, device-manager
offers detailed configuration but doesn't handle new devices,
switch-on-connect offers no configuration but handles new devices as
expected. Ideally, we would want behavior of both modules, but that's
not possible. module-device-manager is loaded by default and also
existed before module-switch-on-connect, so I think we shouldn't
change that. Users can still choose to use switch-on-connect (using
checkbox in plasma-pa kcm) if they want.

David


>
> Nate
>
>
> Relevant bug reports, for background:
> - https://bugs.kde.org/show_bug.cgi?id=392103
> - https://bugs.kde.org/show_bug.cgi?id=392117
> - https://bugs.freedesktop.org/show_bug.cgi?id=95104
> - https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/1720519
>

Re: PulseAudio switch-on-connect and device-manager modules

[Nate Graham]

I'm trying to centralize the conversation here rather than in a bunch of 
disjointed bug reports, because I feel like that's made it difficult to discuss 
the issue.

If enabling source switching in plasma-pa disables the device-manager module to 
prevent module conflicts and in the process breaks functionality the Phonon 
KCM, isn't that the bug that needs solving?

Having two KCMs that use different PulseAudio modules that conflict with one 
another such that we can have either automatic source switching, or a 
fully-functional Phonon KCM--but not both--seems like a bug to me.

Nate


 On Wed, 21 Mar 2018 09:16:14 -0700 David 
Edmundson wrote  
 > You're not going to get a different answer here to the comments David and I 
 > have already left on bugzilla.
 > 
 > 
 > 
 > 
 > I don't understand what you think the problem is.
 > 
 > 
 > 
 > >...But both modules can't be loaded at once. 
 > 
 > Not technically true, but they would interfere with each other.
 > 
 > 
 > 
 > But in any case plasma-pa disables device-manager when we enable switch on 
 > connect.
 > 
 > 
 > 
 > >So plasma-pa's "Automatically switch all running streams when a new  output 
 > >becomes available" checkbox does not work in many circumstances.
 > 
 > 
 > 
 > That's not what any of your links are about, also it doesn't make sense as 
 > described because we disable device-manager when we enable 
 > switch-on-connect. See ModuleManager::setSwitchOnConnect.
 > 
 > 
 > 
 > 
 > David
 > 
 > 
 > 
 > 
 > 
 > 
 > 
 > 
 >  
 > 

Re: PulseAudio switch-on-connect and device-manager modules

[David Edmundson]

You're not going to get a different answer here to the comments David and I
have already left on bugzilla.

I don't understand what you think the problem is.

>...But both modules can't be loaded at once.
Not technically true, but they would interfere with each other.

But in any case plasma-pa disables device-manager when we enable switch on
connect.

>So plasma-pa's "Automatically switch all running streams when a new output
becomes available" checkbox does not work in many circumstances.

That's not what any of your links are about, also it doesn't make sense as
described because we disable device-manager when we enable
switch-on-connect. See ModuleManager::setSwitchOnConnect.

David

PulseAudio switch-on-connect and device-manager modules

[Nate Graham]

Howdy folks,

It seems that we have KCMs that conflict with one another: 
- The Phonon Audio/Video KCM uses the module-device-manager PulseAudio Module.
- plasma-pa's KCM has an "Automatically switch all running streams when a new 
output becomes available" checkbox that loads the switch-on-connect PulseAudio 
module.

...But both modules can't be loaded at once. So plasma-pa's "Automatically 
switch all running streams when a new output becomes available" checkbox does 
not work in many circumstances.

This is all relevant to our users who would like to have audio streams 
automatically switched over when a new device becomes available (e.g. a 
bluetooth or USB headset) and report that checking the "Automatically switch 
all running streams when a new output becomes available" checkbox doesn't 
enable that behavior for them.

What's our path forward here?

Nate


Relevant bug reports, for background:
- https://bugs.kde.org/show_bug.cgi?id=392103
- https://bugs.kde.org/show_bug.cgi?id=392117
- https://bugs.freedesktop.org/show_bug.cgi?id=95104
- https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/1720519

D11308: Use the default Plasma wallpaper on the lock screen

[Fabian Vogt]

fvogt added a comment.


  I'll write my viewpoint as downstream maintainer here: We removed the blue 
background as default as soon as it landed as it is was complained about in 
various places.
  Also, our sddm theme also uses the wallpaper as background so it looks 
similiar now.
  
  (if a user installed the -branding-upstream package they'd get the blue 
background again, but AFAICT not many did that)
  
  My personal opinion is that the blue background is incredibly hard to look 
at, too bright and not enough contrast.
  
  +1 from me.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D11308

To: ngraham, #plasma, #vdg, graesslin, abetts
Cc: fvogt, Fuchs, broulik, davidedmundson, zzag, Pitel, progwolff, abetts, 
hein, mart, graesslin, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D11551: use the new install_package form

[Marco Martin]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:28c54b9851f6: use the new install_package form (authored 
by mart).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11551?vs=30120=30124

REVISION DETAIL
  https://phabricator.kde.org/D11551

AFFECTED FILES
  applet/CMakeLists.txt

To: mart, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11292: [RFC] Ordered system tray v2

[Radek Hušek]

Pitel abandoned this revision.
Pitel added a comment.


  Replaced by D11352 .

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11292

To: Pitel, #plasma, #vdg
Cc: mart, zzag, davidedmundson, anthonyfieroni, wsdfhjxc, ngraham, 
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol

D11550: use the bundled variant of installpackage

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:2583b4232e87: use the bundled variant of installpackage 
(authored by mart).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11550?vs=30119=30121

REVISION DETAIL
  https://phabricator.kde.org/D11550

AFFECTED FILES
  applet/CMakeLists.txt

To: mart, #plasma, jgrulich
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11551: use the new install_package form

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  plasmoids can now be used also from binary resource files rcc
  which makes a bit of difference in startup times especially on
  devices with low storage
  use the new macro to generate and install the rcc

TEST PLAN
  still works

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11551

AFFECTED FILES
  applet/CMakeLists.txt

To: mart, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11550: use the bundled variant of installpackage

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  plasmoids can now be used also from binary resource files rcc
  which makes a bit of difference in startup times especially on
  devices with low storage
  use the new macro to generate and install the rcc

TEST PLAN
  still works

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11550

AFFECTED FILES
  applet/CMakeLists.txt

To: mart, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D1230: GBM remote access support for KWin

[Oleg Chernovskiy]

Kanedias added a comment.


  This makes sense. Thanks, will try with KDecoration master once I'm home

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: kossebau, jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, 
davidedmundson, plasma-devel, schernikov, iodelay, zzag, bwowk, ZrenBot, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein

D1230: GBM remote access support for KWin

[Friedrich W . H . Kossebau]

kossebau added a comment.


  In D1230#230642 , @romangg wrote:
  
  > In D1230#230613 , @Kanedias wrote:
  >
  > > They don't override anything and compile fails for me if they are 
present. GCC 7.3.1.
  >
  >
  > I believe this is an unrelated regression you just ran into because of 
D11209 . I hadn't yet updated my 
KDecoration clone, that's why it still compiled for me. In any case please 
remove the unrelated override keyword removal from the patch and let's hope the 
regression will be quickly fixed in KDecoration.
  
  
  No, D11209  should be innocent here. Not 
exporting the symbols of the pimpl classes has no effect on the virtualness of 
the methods of the normal classes.
  
  The issue is rather that those tooltip-related methods only got added 
recently to master, see D7246 . So KWin 
master also expects KDecoration master.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: kossebau, jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, 
davidedmundson, plasma-devel, schernikov, iodelay, zzag, bwowk, ZrenBot, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein

D11352: [RFC] Auto ordered systray

[Radek Hušek]

Pitel updated this revision to Diff 30111.
Pitel added a comment.


  Great, but I found one more bug (and it affected order of items). This fixes 
it.
  
  - Add tie breaking (for the unlikely case of the same category & text)
  - Add debug print
  - Fix sorting algorithm (the order was wrong if item was created with empty 
text and filled it in later)
  
  Note that I do not have write access, so I cannot land this myself.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11352?vs=29977=30111

BRANCH
  stableSystray2

REVISION DETAIL
  https://phabricator.kde.org/D11352

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: Pitel, #vdg, #plasma, mart
Cc: ngraham, wsdfhjxc, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11352: [RFC] Auto ordered systray

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  got trough some testing of the last version, for me is now good to go

REPOSITORY
  R120 Plasma Workspace

BRANCH
  stableSystray2

REVISION DETAIL
  https://phabricator.kde.org/D11352

To: Pitel, #vdg, #plasma, mart
Cc: ngraham, wsdfhjxc, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D1230: GBM remote access support for KWin

[Oleg Chernovskiy]

Kanedias added a comment.


  I don't have KDecoration checked out. The problem is much more simple. These 
functions don't override anything but there's override keyword present where it 
shouldn't be. The fix is still required for them, regardless of KDecoration 
status.
  
  Any other issues apart from this one? I'll remove these lines once I'm home.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, 
plasma-devel, schernikov, iodelay, zzag, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D1230: GBM remote access support for KWin

[Roman Gilg]

romangg added a comment.


  In D1230#230613 , @Kanedias wrote:
  
  > They don't override anything and compile fails for me if they are present. 
GCC 7.3.1.
  
  
  I believe this is an unrelated regression you just ran into because of D11209 
. I hadn't yet updated my KDecoration 
clone, that's why it still compiled for me. In any case please remove the 
unrelated override keyword removal from the patch and let's hope the regression 
will be quickly fixed in KDecoration.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, 
plasma-devel, schernikov, iodelay, zzag, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D1230: GBM remote access support for KWin

[Oleg Chernovskiy]

Kanedias marked an inline comment as done.
Kanedias added a comment.


  They don't override anything and compile fails for me if they are present. 
GCC 7.3.1.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, 
plasma-devel, schernikov, iodelay, zzag, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D1230: GBM remote access support for KWin

[Roman Gilg]

romangg added a comment.


  Why did you remove the override specifier? It compiles for me also with them. 
And they are certainly in no connection to this patch.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, 
plasma-devel, schernikov, iodelay, zzag, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D11512: Set proper application name once browser identifies to us

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:3d8e61b3901f: Set proper application name once browser 
identifies to us (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11512?vs=30099=30101

REVISION DETAIL
  https://phabricator.kde.org/D11512

AFFECTED FILES
  host/main.cpp
  host/settings.cpp
  host/settings.h

To: broulik, davidedmundson, fvogt
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11512: Set proper application name once browser identifies to us

[Kai Uwe Broulik]

broulik updated this revision to Diff 30099.
broulik added a comment.


  - Set organization domain and name also

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11512?vs=30003=30099

REVISION DETAIL
  https://phabricator.kde.org/D11512

AFFECTED FILES
  host/main.cpp
  host/settings.cpp
  host/settings.h

To: broulik, davidedmundson, fvogt
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D1230: GBM remote access support for KWin

[Oleg Chernovskiy]

Kanedias requested review of this revision.
Kanedias marked an inline comment as done.
Kanedias added inline comments.

INLINE COMMENTS

> romangg wrote in drm_output.h:135
> This gives me an compile error: invalid static_cast from type 'QObject*' to 
> type 'KWayland::Server::OutputInterface*'
> 
> I assume you can just pass m_waylandOutput as QPointer and then access data() 
> in passBuffer. This compiled for me.

Fixed. Also removed `override` in places where it didn't compile because of it.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, 
plasma-devel, schernikov, iodelay, zzag, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D1230: GBM remote access support for KWin

[Oleg Chernovskiy]

Kanedias updated this revision to Diff 30092.
Kanedias added a comment.


  - Fix clang compilation
  - Fix QPointer

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1230?vs=29434=30092

BRANCH
  fix-clang

REVISION DETAIL
  https://phabricator.kde.org/D1230

AFFECTED FILES
  decorations/decoratedclient.h
  kcmkwin/kwindecoration/declarative-plugin/previewclient.h
  plugins/platforms/drm/CMakeLists.txt
  plugins/platforms/drm/drm_buffer_gbm.h
  plugins/platforms/drm/drm_output.h
  plugins/platforms/drm/egl_gbm_backend.cpp
  plugins/platforms/drm/egl_gbm_backend.h
  plugins/platforms/drm/remoteaccess_manager.cpp
  plugins/platforms/drm/remoteaccess_manager.h

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, 
plasma-devel, schernikov, iodelay, zzag, bwowk, ZrenBot, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein