D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  FYI: I undid the wonky manual UI sizing that @broulik objected to. In 
hindsight, not the best approach.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  Okay, this patch is back to where we started, with nothing changed except 
centering the icon. Hopefully we can commit it now. I'll move the discussion 
over how to redesign the dialog itself to a separate task.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey updated this revision to Diff 32758.
sharvey added a comment.


  - Merge branch 'master' into align-lock-icon
  - Undo manual resizing of ser combo box & password error box

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12311?vs=32498=32758

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

AFFECTED FILES
  AuthDialog.cpp
  AuthDialog.ui

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12278: WIP: [Colors KCM] Port to new design

[Nathaniel Graham]

ngraham added a comment.


  In D12278#251210 , @mart wrote:
  
  > In D12278#248160 , @ngraham 
wrote:
  >
  > > It would be really cool if the delegates would show a little preview of a 
window actually using these colors, instead of the current grid of colored 
squares.
  >
  >
  > it's probably not trivial with how colors are done in qqc2 right now.. i 
plan to add more custom colors for kirigami, but non essential for now?
  
  
  Yes, definitely non-essential. A nice-to-have, not a need-to-have.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12278

To: broulik, #plasma, #vdg
Cc: mart, abetts, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D12278: WIP: [Colors KCM] Port to new design

[Nathaniel Graham]

ngraham added a comment.


  -1 for "current" here too.
  
  I also don't like "Default" either. What does that even mean to a regular 
user?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12278

To: broulik, #plasma, #vdg
Cc: mart, abetts, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D12278: WIP: [Colors KCM] Port to new design

[Marco Martin]

mart added a comment.


  In D12278#248160 , @ngraham wrote:
  
  > It would be really cool if the delegates would show a little preview of a 
window actually using these colors, instead of the current grid of colored 
squares.
  
  
  it's probably not trivial with how colors are done in qqc2 right now.. i plan 
to add more custom colors for kirigami, but non essential for now?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12278

To: broulik, #plasma, #vdg
Cc: mart, abetts, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

[Fabian Vogt]

fvogt added a comment.


  > I'm pointing out that I'm in general against any risky changes on X11. If 
users want to use this features: Wayland is there. KWin is feature frozen on 
X11 and I highly suggest to the Plasma community to decide the same at the 
sprint. We will have less maintenance issues due to it.
  
  Yes, but many can't or don't want to use Wayland.
  In fact, the machine where I tried this on last had to use the proprietary 
nvidia driver to work properly. The wayland session doesn't work, it just 
freezes (I'll try to have a look at that though).
  
  If I'm not mistaken scaling is currently broken on Wayland due to use of XCB 
as Qt's default platform.
  
  > I can promise you that this feature will create bug reports, it comes with 
a cost to add this on X11. While we have a almost finished Wayland solution 
which is hold back by among other developers still working on X11.
  
  Sure, but by setting the same scale on each screen you get the exact same 
behaviour as with the current state. I'd say that's as low risk as it can 
possibly be.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D12405

To: fvogt, #plasma
Cc: hein, ngraham, graesslin, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

[Eike Hein]

hein added a comment.


  In principle I'm inclined to side with Martin here. At this point, I no 
longer want the extra burden/distraction of working on newly-introduced 
X11-related bugs. It's frustrating to spend manhours on code you know will be 
obsolete, and that delays getting work done to make it obsolete. I still have 
many scaling problems on Wayland that I think should be higher priority.
  
  I can't give a qualified assessment of the specific risk factor here though.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D12405

To: fvogt, #plasma
Cc: hein, ngraham, graesslin, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12278: WIP: [Colors KCM] Port to new design

[Marco Martin]

mart added a comment.


  In D12278#248109 , @davidedmundson 
wrote:
  
  > > Not too fond of this "Current"
  >
  > me neither, if it was up to me, I'd just show a prompt asking for a name 
when you click "edit" on a system scheme. Would be nice and simple.
  >
  > but it was redone by Marco quite recently and still kept. So clearly for a 
reason?
  
  
  it was like that, i redid the thing after enough user complaints, and yeah, i 
don't like current either

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12278

To: broulik, #plasma, #vdg
Cc: mart, abetts, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

[Martin Flöser]

graesslin added a comment.


  I'm pointing out that I'm in general against any risky changes on X11. If 
users want to use this features: Wayland is there. KWin is feature frozen on 
X11 and I highly suggest to the Plasma community to decide the same at the 
sprint. We will have less maintenance issues due to it.
  
  I can promise you that this feature will create bug reports, it comes with a 
cost to add this on X11. While we have a almost finished Wayland solution which 
is hold back by among other developers still working on X11.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D12405

To: fvogt, #plasma
Cc: ngraham, graesslin, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12102: Port Language KCM to Qt Quick

[Marco Martin]

mart added a comment.


  In D12102#251163 , @ngraham wrote:
  
  > +1 for putting the text on the top rather than the bottom. Once we make the 
list draggable, it might be nice to incorporate that into the text too, e.g 
"drag languages into your preferred order" or something like that.
  >
  > Unfortunately, our use of the hamburger button precludes use of that 
elsewhere-fairly-universal "three bar" symbol to mean "this is draggable!" 
Maybe a very light gray rendition of this, or a variant?
  >
  > F5816712: 1600 
  >
  > Or we could finally banish the hamburger menu once and for all...
  
  
  I'm thinking about a vertical version of https://phabricator.kde.org/D10980
  
  which means we need versions for handles:
  horizontal left
  hirizontal, right
  horizontal, both
  vertical, top
  vertical bottom
  vertical, both (fot this particular thing)
  https://phabricator.kde.org/D10980

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

[Nathaniel Graham]

ngraham added a comment.


  +1 for not letting the perfect be the enemy of the good here. Multi-monitor 
support is a pain point for many of our users.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D12405

To: fvogt, #plasma
Cc: ngraham, graesslin, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

[Fabian Vogt]

fvogt added a comment.


  > So I wouldn't trust this thing in Qt to work due to the pain we have in 
KWin especially with these problems.
  
  Yes, it might not be perfect. It works well enough that not exposing this in 
the settings is a wasted opportunity though.
  I used this extensively for half a year with a 4k non-primary monitor, where 
the only other option is to meet halfway at 1.5x scale or move the screen so 
close that it's touching your nose.
  
  I doubt that users would expect this to work perfectly with any unusual 
configurations such as overlapping screens, but even then it's an improvement 
to the current situation.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D12405

To: fvogt, #plasma
Cc: graesslin, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12069: Implement a keyboard selector plasmoid

[Martin Flöser]

graesslin added a comment.


  I don't think that there's any reason to discard this. It's a start and 
improvement over the current situation and a fallback is needed anyway. So we 
start with the fallback instead of adding it later on.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12069

To: apol, #plasma
Cc: hein, graesslin, broulik, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12102: Port Language KCM to Qt Quick

[Marco Martin]

mart added a comment.


  In D12102#251163 , @ngraham wrote:
  
  > +1 for putting the text on the top rather than the 
  >  Unfortunately, our use of the hamburger button precludes use of that 
elsewhere-fairly-universal "three bar" symbol to mean "this is draggable!" 
Maybe a very light gray rendition of this, or a variant?
  >
  > F5816712: 1600 
  
  
  I like it tough it should still be consistent with the drag icons for the 
handles of swipelistitem which are now not used in desktop but still needed . 
On that review there are still some handles proposals (of which none look like 
an hamburger icon)
  
  > Or we could finally banish the hamburger menu once and for all...
  
  No :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12102: Port Language KCM to Qt Quick

[Nathaniel Graham]

ngraham added a comment.


  +1 for putting the text on the top rather than the bottom. Once we make the 
list draggable, it might be nice to incorporate that into the text too, e.g 
"drag languages into your preferred order" or something like that.
  
  Unfortunately, our use of the hamburger button precludes use of that 
elsewhere-fairly-universal "three bar" symbol to mean "this is draggable!" 
Maybe a very light gray rendition of this, or a variant?
  
  F5816712: 1600 
  
  Or we could finally banish the hamburger menu once and for all...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein added a comment.


  Adding 'Default' is pretty easy, no problem.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12373: Klipper: Remove first history item on clipboard clear

[Martin Flöser]

graesslin added a comment.


  Sorry, but I'm against this. The options keepass provides are just bullshit 
(sorry to be that direct). That cannot work and will not work. One cannot 
remove anything from the clipboard, trying to do so is insane. What would make 
most sense for things like clipboard is setting a mimetime like text/password. 
This could be used by Klipper to never add it to history. That would be a 
useful feature. But anything that just tries to support keepass's utterly 
broken workflow from an X11/Wayland and security point of view doesn't make any 
sense.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12373

To: hoffmannrobert
Cc: graesslin, broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

[Martin Flöser]

graesslin added a comment.


  I also cannot imagine this to work due to the fact how X11 works. There is 
just no mapping from window to screen. No window can know on which screen it 
is. Not even KWin knows that as the window manager (screen is not a constant 
property, but evaluated every time it is accessed, it's based on the distance 
to closest screen). Especially for overlapping windows it's very difficult to 
try to get to which screen it belongs. It gets even more complicated when 
things like panning and overlapping screens get into it. So I wouldn't trust 
this thing in Qt to work due to the pain we have in KWin especially with these 
problems.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D12405

To: fvogt, #plasma
Cc: graesslin, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12102: Port Language KCM to Qt Quick

[Henrik Fehlauer]

rkflx added a comment.


  Looking better now ;)
  
  One more note: Users read the dialog from the top. Having "Default" added to 
the topmost entry like in @abetts' mockup would be great, if possible at all, 
because most users won't really get to the text at the bottom.
  
  As for the handle, maybe something like 
http://clauderic.github.io/react-sortable-hoc/, (see "Drag Handle" and "Lock 
axis", observe cursor changing). This icon is pretty standard in both web and 
Android, unfortunately overloaded with many other meanings, too. I guess this 
needs to be a Kirigami-wide decision, or do we have an existing example?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein added a comment.


  In D12102#251048 , @ngraham wrote:
  
  > For this list, where the items themselves don't do anything on click, I 
think it's sane to allow the whole list item to be a drag area. There's more of 
a challenge to allow re-ordering items that do something when you click on 
them, but we don't have that issue here.
  
  
  We need some sort of cue so people can tell it's draggable though.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12102: Port Language KCM to Qt Quick

[Nathaniel Graham]

ngraham added a comment.


  For this list, where the items themselves don't do anything on click, I think 
it's sane to allow the whole list item to be a drag area. There's more of a 
challenge to allow re-ordering items that do something when you click on them, 
but we don't have that issue here.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein added a comment.


  https://www.youtube.com/watch?v=gdnuOa7tDco

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12102: Port Language KCM to Qt Quick

[Nathaniel Graham]

ngraham added a comment.


  Lookin' pretty sharp!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein added a comment.


  So, how are we gonna approach this drag thing? Three dots?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein added a comment.


  With the right text and disabling the default action for the first item:
  
  F5816462: Screenshot_20180421_234449.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein added a comment.


  Turns out tooltip support is there already:
  
  F5816427: Screenshot_20180421_233951.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12102: Port Language KCM to Qt Quick

[Nathaniel Graham]

ngraham added a comment.


  In D12102#251008 , @hein wrote:
  
  > Yeah, I think duplicating the button text is goofy. I'm OK with the first 
sentence.
  >
  > Otherwise, personally I would like the list to be like this:
  >
  > (a) Have a drag handle and be drag-reorderable (missing in Kirigami
  >  (b) On hover, show icon-based "Move to top" (using the `go-top` icon) and 
remove actions
  >
  > That'd address @rkflx "make changing the default super easy" thing.
  
  
  +1, that would be excellent.
  
  Also +1 for further refining the usability and presentation of the 
SwipeListItems in the way you bring up.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein added a comment.


  Another issue I have with SwipeListItem: In addition to the hover effect, 
there's always a fancy flashing effect on clicks, even though it doesn't do 
anything in my list.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

[Fabian Vogt]

fvogt added a comment.


  > Docs say QT_SCREEN_SCALE_FACTORS doesn't affect the logical DPI. which 
means you have a 1x scale on one screen 2x on another..they both have the same 
font size which will just be really wrong.
  
  Exactly that is not the case.
  
  Let me give you an example for broken font size: Screen "DP-0" has Scale 1 
and "DP-1" has scale 1. You set "Xft.dpi: 96". The result is 96 dpi font on 
DP-0 and 48 dpi font on DP-1.
  This can only happen if Qt scales the font DPI depending on the 
QT_SCREEN_SCALE_FACTORS values.
  
  Screenshot of a working setup: F5816419: image.png 


REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D12405

To: fvogt, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein added a comment.


  BTW: I think SwipeListItem actions should have support for tooltips, so those 
actions can have "Make default" and "Remove" tooltips.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein added a comment.


  Yeah, I think duplicating the button text is goofy. I'm OK with the first 
sentence.
  
  Otherwise, personally I would like the list to be like this:
  
  (a) Have a drag handle and be drag-reorderable (missing in Kirigami
  (b) On hover, show icon-based "Move to top" (using the `go-top` icon) and 
remove actions
  
  That'd address @rkflx "make changing the default super easy" thing.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12102: Port Language KCM to Qt Quick

[Nathaniel Graham]

ngraham added a comment.


  > Pick your default language by moving topmost. To add more languages, click 
on the right.
  
  How about this?
  
  > The language at the top of this list is the one you want to see and use 
most often. To add more languages, click the "Add Languages..." button.
  
  Perhaps we could even remove the second sentence entirely, since the button 
is right there...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein added a comment.


  An early attempt at implementing @abetts new mockup:
  
  F5816409: Screenshot_20180421_232025.png 

  
  F5816411: Screenshot_20180421_232046.png 

  
  I didn't do the icons because:
  
  (a) I don't think SwipeListItem allows me to show the actions permanently 
currently
  (b) The circle-with-slash icon is semantically wrong (list-remove looks like 
a minus in Breeze)
  (c) This is not about enabling and disabling, it's a prioritized list

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

[David Edmundson]

davidedmundson added a comment.


  I can't imagine this working. It didn't when I've tried the same thing.
  Docs say QT_SCREEN_SCALE_FACTORS doesn't affect the logical DPI.  which means 
you have a 1x scale on one screen 2x on another..they both have the same font 
size which will just be really wrong.
  
  Also I bet spectacle's area selection is bust on at least one of the monitor 
variants. There's a whole lot of confusion (with no real right answer) as to 
what the size of a 1x monitor is in logical co-ordinates when your window is on 
the 2x screen and vice versa.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D12405

To: fvogt, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

[Fabian Vogt]

fvogt created this revision.
fvogt added a reviewer: Plasma.
Restricted Application added a project: Plasma.
fvogt requested review of this revision.

REVISION SUMMARY
  Qt computes the scale factor relative to the primary screen. This means
  we can support per-screen DPI on X11 by setting QT_SCREEN_SCALE_FACTORS
  appropriately, while keeping Xft.dpi synced to the primary screen's DPI.
  This means applications which don't read QT_SCREEN_SCALE_FACTORS use the
  scale of the primary screen. This is a good compromise, especially for
  those who either need fractional scaling or can't use wayland for various
  reasons.
  
  WIP because this doesn't track changes of the primary screen and I'm not
  sure how to implement this the best way. The issue is that the
  QT_SCREEN_SCALE_FACTORS management is not done by the backend, but only by
  the KCM. Ideas welcome.

TEST PLAN
  VM with multihead QXL. I can now assign a per-screen scale in the KCM
  and after a relogin applications scale correctly based on the screen they're 
on.

REPOSITORY
  R104 KScreen

BRANCH
  perscreenxcb

REVISION DETAIL
  https://phabricator.kde.org/D12405

AFFECTED FILES
  kcm/src/outputconfig.cpp
  kcm/src/scalingconfig.cpp
  kcm/src/scalingconfig.h
  kcm/src/widget.cpp
  kcm/src/widget.h

To: fvogt, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein added a comment.


  I like the mockup, but yeah, still need to figure out ordering.
  
  As for the top text label, let's go with "Preferred languages" over 
"Installed languages" (also what the old KCM used).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12102: Port Language KCM to Qt Quick

[Henrik Fehlauer]

rkflx added a comment.


  In D12102#250725 , @abetts wrote:
  
  > Here are additional mockups for thought.F5815917: Screen Shot 2018-04-20 at 
10.54.07 PM.png 
  
  
  Quite nice (the helpful text label in particular, and how the default option 
is emphasized), but how will setting the fallback language work, e.g. how to 
switch English and Spanish around in your screenshot? In the previous iteration 
this was done by allowing to order the list (which IMO was fine, only needed 
some polishing).
  
  > F5815920: AddLanguageAnimation.mov 
  
  Hm, my browser is not able to play Apple's QuickTime video format (and even 
after downloading it does not want to play). Could you re-upload as a WebM 
maybe?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Andrius Štikonas]

stikonas added a comment.


  In D12311#250688 , @bruns wrote:
  
  > Gnome-disks does, and so do other programs.
  
  
  Gnome-disks uses UDisks to do everything and can't do anything on its own. So 
available features are very limited (not even resizing partitions).
  I suspect it is significantly less portable (e.g. to FreeBSD).
  That's why gnome-disks was written from scratch (with fewer features than 
gparted that it was supposedly replacing).

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: stikonas, bruns, ltoscano, broulik, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart