D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[Andres Betts]

abetts added a comment.


  What does this look like now after the changes? Screenshot? Video? :D

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

To: broulik, #plasma, #vdg, ngraham
Cc: abetts, ngraham, colomar, gregormi, mart, graesslin, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

KDE CI: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 - Build # 126 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/126/
 Project:
Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 01 May 2018 03:45:28 +
 Build duration:
3 min 34 sec and counting
   CONSOLE OUTPUT
  [...truncated 439.71 KB...]/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:225:28: note: 'addDirectoryDefinition' has been explicitly marked deprecated herePLASMA_DEPRECATED void addDirectoryDefinition(const char *key, const QString , const QString );   ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:107:14: warning: 'setMimeTypes' is deprecated [-Wdeprecated-declarations]package->setMimeTypes("images", mimetypes); ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:274:28: note: 'setMimeTypes' has been explicitly marked deprecated herePLASMA_DEPRECATED void setMimeTypes(const char *key, QStringList mimeTypes);   ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:108:14: warning: 'setMimeTypes' is deprecated [-Wdeprecated-declarations]package->setMimeTypes("theme", mimetypes); ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:274:28: note: 'setMimeTypes' has been explicitly marked deprecated herePLASMA_DEPRECATED void setMimeTypes(const char *key, QStringList mimeTypes);   ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:110:14: warning: 'addDirectoryDefinition' is deprecated [-Wdeprecated-declarations]package->addDirectoryDefinition("config", QStringLiteral("config"), i18n("Configuration Definitions")); ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:225:28: note: 'addDirectoryDefinition' has been explicitly marked deprecated herePLASMA_DEPRECATED void addDirectoryDefinition(const char *key, const QString , const QString );   ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:113:14: warning: 'setMimeTypes' is deprecated [-Wdeprecated-declarations]package->setMimeTypes("config", mimetypes); ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:274:28: note: 'setMimeTypes' has been explicitly marked deprecated herePLASMA_DEPRECATED void setMimeTypes(const char *key, QStringList mimeTypes);   ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:115:14: warning: 'addDirectoryDefinition' is deprecated [-Wdeprecated-declarations]package->addDirectoryDefinition("ui", QStringLiteral("ui"), i18n("User Interface")); ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:225:28: note: 'addDirectoryDefinition' has been explicitly marked deprecated herePLASMA_DEPRECATED void addDirectoryDefinition(const char *key, const QString , const QString );   ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:117:14: warning: 'addDirectoryDefinition' is deprecated [-Wdeprecated-declarations]package->addDirectoryDefinition("data", QStringLiteral("data"), i18n("Data Files")); ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:225:28: note: 'addDirectoryDefinition' has been explicitly marked deprecated herePLASMA_DEPRECATED void addDirectoryDefinition(const char *key, const QString , const QString );   ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:119:14: warning: 'addDirectoryDefinition' is deprecated [-Wdeprecated-declarations]package->addDirectoryDefinition("scripts", QStringLiteral("code"), i18n("Executable Scripts")); ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:225:28: note: 'addDirectoryDefinition' has been explicitly marked deprecated herePLASMA_DEPRECATED void addDirectoryDefinition(const char *key, const QString , const QString );   ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:122:14: warning: 'setMimeTypes' is deprecated 

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[Nathaniel Graham]

ngraham added a comment.


  Here's an idea shamelessly stolen from a blog commenter: how about showing 
the current keyboard layout next to the text field, instead of down in the 
corner? That way users would see upfront that they're using (or not using) the 
keyboard layout that they expect.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

To: broulik, #plasma, #vdg, ngraham
Cc: abetts, ngraham, colomar, gregormi, mart, graesslin, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

KDE CI: Plasma plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 125 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/125/
 Project:
Plasma plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Tue, 01 May 2018 03:45:28 +
 Build duration:
1 min 45 sec and counting
   CONSOLE OUTPUT
  [...truncated 441.70 KB...] ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:225:28: note: 'addDirectoryDefinition' has been explicitly marked deprecated herePLASMA_DEPRECATED void addDirectoryDefinition(const char *key, const QString , const QString );   ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:104:14: warning: 'addDirectoryDefinition' is deprecated [-Wdeprecated-declarations]package->addDirectoryDefinition("theme", QStringLiteral("theme"), i18n("Themed Images")); ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:225:28: note: 'addDirectoryDefinition' has been explicitly marked deprecated herePLASMA_DEPRECATED void addDirectoryDefinition(const char *key, const QString , const QString );   ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:107:14: warning: 'setMimeTypes' is deprecated [-Wdeprecated-declarations]package->setMimeTypes("images", mimetypes); ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:274:28: note: 'setMimeTypes' has been explicitly marked deprecated herePLASMA_DEPRECATED void setMimeTypes(const char *key, QStringList mimeTypes);   ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:108:14: warning: 'setMimeTypes' is deprecated [-Wdeprecated-declarations]package->setMimeTypes("theme", mimetypes); ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:274:28: note: 'setMimeTypes' has been explicitly marked deprecated herePLASMA_DEPRECATED void setMimeTypes(const char *key, QStringList mimeTypes);   ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:110:14: warning: 'addDirectoryDefinition' is deprecated [-Wdeprecated-declarations]package->addDirectoryDefinition("config", QStringLiteral("config"), i18n("Configuration Definitions")); ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:225:28: note: 'addDirectoryDefinition' has been explicitly marked deprecated herePLASMA_DEPRECATED void addDirectoryDefinition(const char *key, const QString , const QString );   ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:113:14: warning: 'setMimeTypes' is deprecated [-Wdeprecated-declarations]package->setMimeTypes("config", mimetypes); ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:274:28: note: 'setMimeTypes' has been explicitly marked deprecated herePLASMA_DEPRECATED void setMimeTypes(const char *key, QStringList mimeTypes);   ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:115:14: warning: 'addDirectoryDefinition' is deprecated [-Wdeprecated-declarations]package->addDirectoryDefinition("ui", QStringLiteral("ui"), i18n("User Interface")); ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:225:28: note: 'addDirectoryDefinition' has been explicitly marked deprecated herePLASMA_DEPRECATED void addDirectoryDefinition(const char *key, const QString , const QString );   ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:117:14: warning: 'addDirectoryDefinition' is deprecated [-Wdeprecated-declarations]package->addDirectoryDefinition("data", QStringLiteral("data"), i18n("Data Files")); ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:225:28: note: 'addDirectoryDefinition' has been explicitly marked deprecated herePLASMA_DEPRECATED void addDirectoryDefinition(const char *key, const QString , const QString );   ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:119:14: warning: 'addDirectoryDefinition' is deprecated [-Wdeprecated-declarations]package->addDirectoryDefinition("scripts", QStringLiteral("code"), i18n("Executable Scripts")); 

KDE CI: Plasma kwin stable-kf5-qt5 FreeBSDQt5.9 - Build # 68 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kwin%20stable-kf5-qt5%20FreeBSDQt5.9/68/
 Project:
Plasma kwin stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 30 Apr 2018 21:49:18 +
 Build duration:
7 min 9 sec and counting
   CONSOLE OUTPUT
  [...truncated 863.91 KB...][ 54%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwintouchscreen.dir/screenpreviewwidget.cpp.o[ 54%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwinscreenedges.dir/screenpreviewwidget.cpp.o[ 54%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/effectModelTest.dir/compositing.cpp.o[ 54%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwintouchscreen.dir/kwin_effects_interface.cpp.o[ 54%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/kwincompositing.dir/compositing.cpp.o[ 54%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwinscreenedges.dir/kwin_effects_interface.cpp.o[ 54%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/effectModelTest.dir/test/effectmodeltest.cpp.o[ 54%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwintouchscreen.dir/kcm_kwintouchscreen_autogen/mocs_compilation.cpp.o[ 54%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwinscreenedges.dir/kcm_kwinscreenedges_autogen/mocs_compilation.cpp.o[ 54%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/kwincompositing.dir/effectconfig.cpp.o[ 54%] Linking CXX shared module ../../bin/kcm_kwintouchscreen.so[ 54%] Linking CXX shared module ../../bin/kcm_kwinscreenedges.so[ 54%] Built target kcm_kwintouchscreen[ 54%] Generating kwin_effects_interface.cpp, kwin_effects_interface.h[ 54%] Generating ui_main.h[ 54%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/kwincompositing.dir/kwin_compositing_interface.cpp.o[ 55%] Generating kwin_effects_interface.mocScanning dependencies of target kcm_kwindesktop[ 55%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwindesktop.dir/main.cpp.o[ 55%] Built target kcm_kwinscreenedges[ 55%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwindesktop.dir/desktopnameswidget.cpp.o[ 55%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/effectModelTest.dir/test/modeltest.cpp.o[ 55%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/kwincompositing.dir/kwin_effects_interface.cpp.o[ 56%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/kwincompositing.dir/kwincompositing_autogen/mocs_compilation.cpp.o/usr/home/jenkins/workspace/Plasma kwin stable-kf5-qt5 FreeBSDQt5.9/kcmkwin/kwindesktop/main.cpp:571:21: warning: 'KPluginInfo' is deprecated [-Wdeprecated-declarations]KPluginInfo pluginInfo(services.first());^/usr/home/jenkins/install-prefix/include/KF5/KService/kplugininfo.h:115:34: note: 'KPluginInfo' has been explicitly marked deprecated hereexplicit KSERVICE_DEPRECATED KPluginInfo(const KService::Ptr service); ^1 warning generated.[ 56%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwindesktop.dir/kwin_effects_interface.cpp.o[ 56%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/effectModelTest.dir/kwin_compositing_interface.cpp.o[ 56%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/effectModelTest.dir/kwin_effects_interface.cpp.o[ 56%] Linking CXX shared module ../../bin/kwincompositing.so[ 56%] Built target kwincompositing[ 56%] Generating kwin_effects_interface.cpp, kwin_effects_interface.h[ 56%] Generating ui_main.h[ 56%] Generating kwin_effects_interface.mocScanning dependencies of target kcm_kwintabbox[ 56%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/main.cpp.o[ 56%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwindesktop.dir/kcm_kwindesktop_autogen/mocs_compilation.cpp.o[ 56%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/effectModelTest.dir/effectModelTest_autogen/mocs_compilation.cpp.oScanning dependencies of target testPluginEffectLoader[ 56%] Building CXX object autotests/CMakeFiles/testPluginEffectLoader.dir/test_plugin_effectloader.cpp.o[ 56%] Linking CXX shared module ../../bin/kcm_kwindesktop.so[ 56%] Linking CXX executable ../../bin/effectModelTest[ 56%] Built target kcm_kwindesktop[ 56%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/layoutpreview.cpp.oScanning dependencies of target testScriptedEffectLoader[ 56%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/test_scripted_effectloader.cpp.o[ 56%] Building CXX object autotests/CMakeFiles/testPluginEffectLoader.dir/mock_effectshandler.cpp.o[ 56%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/thumbnailitem.cpp.o/usr/home/jenkins/install-prefix/lib/libKF5Declarative.so.5.45.0: undefined reference to `QQmlPropertyMap::init(QMetaObject const*)@Qt_5'/usr/home/jenkins/install-prefix/lib/libKF5Declarative.so.5.45.0: undefined reference to `QQmlPropertyMap::allocatePrivate()@Qt_5'c++: error: 

KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.9 - Build # 157 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/157/
 Project:
Plasma kwin kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 30 Apr 2018 21:51:09 +
 Build duration:
3 min 8 sec and counting
   CONSOLE OUTPUT
  [...truncated 939.56 KB...]/usr/home/jenkins/workspace/Plasma kwin kf5-qt5 FreeBSDQt5.9/kcmkwin/kwincompositing/model.cpp:600:18: warning: 'setupBindings' is deprecated [-Wdeprecated-declarations]kdeclarative.setupBindings(); ^/usr/home/jenkins/install-prefix/include/KF5/KDeclarative/kdeclarative/kdeclarative.h:57:34: note: 'setupBindings' has been explicitly marked deprecated hereKDECLARATIVE_DEPRECATED void setupBindings(); ^[ 56%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwintouchscreen.dir/screenpreviewwidget.cpp.o[ 56%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwinscreenedges.dir/monitor.cpp.o[ 56%] Building CXX object autotests/CMakeFiles/testPluginEffectLoader.dir/mock_effectshandler.cpp.o1 warning generated.[ 56%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwindesktop.dir/desktopnameswidget.cpp.o[ 56%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/mock_abstract_client.cpp.o[ 56%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/layoutpreview.cpp.o1 warning generated.[ 56%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/effectModelTest.dir/effectconfig.cpp.o1 warning generated.[ 56%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/kwincompositing.dir/main.cpp.o[ 56%] Building CXX object autotests/CMakeFiles/testPluginEffectLoader.dir/__/effectloader.cpp.o[ 56%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwinscreenedges.dir/screenpreviewwidget.cpp.o[ 56%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwintouchscreen.dir/kwin_effects_interface.cpp.o[ 56%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/mock_effectshandler.cpp.o[ 56%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwindesktop.dir/kwin_effects_interface.cpp.o[ 57%] Building CXX object autotests/CMakeFiles/testBuiltInEffectLoader.dir/mock_effectshandler.cpp.o[ 57%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/effectModelTest.dir/compositing.cpp.o[ 57%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/mock_screens.cpp.o[ 57%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/thumbnailitem.cpp.o[ 57%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwinscreenedges.dir/kwin_effects_interface.cpp.o[ 57%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwintouchscreen.dir/kcm_kwintouchscreen_autogen/mocs_compilation.cpp.o[ 57%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/kwincompositing.dir/compositing.cpp.o[ 57%] Building CXX object autotests/CMakeFiles/testBuiltInEffectLoader.dir/__/effectloader.cpp.o[ 57%] Building CXX object autotests/CMakeFiles/testPluginEffectLoader.dir/testPluginEffectLoader_autogen/mocs_compilation.cpp.o[ 57%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwindesktop.dir/kcm_kwindesktop_autogen/mocs_compilation.cpp.o[ 57%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/mock_workspace.cpp.o[ 57%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/__/__/tabbox/tabboxconfig.cpp.o[ 57%] Linking CXX shared module ../../bin/kcm_kwintouchscreen.so[ 57%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwinscreenedges.dir/kcm_kwinscreenedges_autogen/mocs_compilation.cpp.o[ 57%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/kwin_effects_interface.cpp.o[ 57%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/effectModelTest.dir/test/effectmodeltest.cpp.o[ 57%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/__/effectloader.cpp.o[ 57%] Built target kcm_kwintouchscreen[ 57%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/effectModelTest.dir/test/modeltest.cpp.o[ 57%] Linking CXX shared module ../../bin/kcm_kwindesktop.so[ 57%] Linking CXX executable ../bin/testPluginEffectLoader[ 57%] Built target kcm_kwindesktop[ 57%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/kwincompositing.dir/effectconfig.cpp.o[ 57%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/__/scripting/scriptedeffect.cpp.o/usr/home/jenkins/install-prefix/lib/libKF5Declarative.so.5: undefined reference to `QQmlPropertyMap::init(QMetaObject const*)@Qt_5'/usr/home/jenkins/install-prefix/lib/libKF5Declarative.so.5: undefined reference to `QQmlPropertyMap::allocatePrivate()@Qt_5'c++: error: linker command failed with exit code 1 (use -v to see invocation)gmake[2]: *** [autotests/CMakeFiles/testPluginEffectLoader.dir/build.make:130: bin/testPluginEffectLoader] Error 1gmake[1]: *** [CMakeFiles/Makefile2:7113: 

KDE CI: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 - Build # 265 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.9/265/
 Project:
Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 30 Apr 2018 19:56:13 +
 Build duration:
2 min 7 sec and counting
   CONSOLE OUTPUT
  [...truncated 738.19 KB...]/usr/home/jenkins/install-prefix/include/KF5/KService/kplugininfo.h:115:34: note: 'KPluginInfo' has been explicitly marked deprecated hereexplicit KSERVICE_DEPRECATED KPluginInfo(const KService::Ptr service); ^[ 23%] Building CXX object plasma-windowed/CMakeFiles/plasmawindowed.dir/plasmawindowedview.cpp.o[ 23%] Building CXX object components/keyboardlayout/CMakeFiles/keyboardlayoutplugin.dir/keyboardlayoutplugin.cpp.o1 warning generated.[ 23%] Linking CXX shared library ../../bin/libplasmashellprivateplugin.so[ 23%] Building CXX object components/keyboardlayout/CMakeFiles/keyboardlayoutplugin.dir/debug.cpp.o[ 23%] Built target plasmashellprivatepluginScanning dependencies of target plasmashell_autogen[ 23%] Automatic MOC for target plasmashell[ 23%] Building CXX object components/keyboardlayout/CMakeFiles/keyboardlayoutplugin.dir/keyboardlayoutplugin_autogen/mocs_compilation.cpp.o[ 23%] Built target plasmashell_autogenScanning dependencies of target plasma_packagestructure_layoutemplate[ 23%] Building CXX object shell/packageplugins/layouttemplate/CMakeFiles/plasma_packagestructure_layoutemplate.dir/layouttemplate.cpp.o[ 23%] Building CXX object shell/packageplugins/layouttemplate/CMakeFiles/plasma_packagestructure_layoutemplate.dir/plasma_packagestructure_layoutemplate_autogen/mocs_compilation.cpp.oScanning dependencies of target plasma_packagestructure_lookandfeel[ 23%] Building CXX object plasma-windowed/CMakeFiles/plasmawindowed.dir/main.cpp.o[ 23%] Building CXX object shell/packageplugins/lookandfeel/CMakeFiles/plasma_packagestructure_lookandfeel.dir/lookandfeel.cpp.o[ 23%] Linking CXX shared library ../../bin/libkeyboardlayoutplugin.so[ 23%] Built target keyboardlayoutpluginScanning dependencies of target plasma_packagestructure_plasmashell[ 23%] Building CXX object shell/packageplugins/shell/CMakeFiles/plasma_packagestructure_plasmashell.dir/shellpackage.cpp.o[ 23%] Linking CXX shared module ../../../bin/plasma_packagestructure_layoutemplate.so[ 23%] Built target plasma_packagestructure_layoutemplate[ 23%] Building CXX object shell/packageplugins/shell/CMakeFiles/plasma_packagestructure_plasmashell.dir/plasma_packagestructure_plasmashell_autogen/mocs_compilation.cpp.oScanning dependencies of target plasma_packagestructure_wallpaper[ 23%] Building CXX object shell/packageplugins/qmlWallpaper/CMakeFiles/plasma_packagestructure_wallpaper.dir/wallpaper.cpp.o[ 23%] Building CXX object shell/packageplugins/lookandfeel/CMakeFiles/plasma_packagestructure_lookandfeel.dir/plasma_packagestructure_lookandfeel_autogen/mocs_compilation.cpp.o[ 23%] Linking CXX shared module ../../../bin/plasma_packagestructure_lookandfeel.so[ 23%] Built target plasma_packagestructure_lookandfeelScanning dependencies of target plasma_packagestructure_wallpaperimages[ 23%] Building CXX object shell/packageplugins/wallpaperimages/CMakeFiles/plasma_packagestructure_wallpaperimages.dir/wallpaperpackage.cpp.o[ 23%] Linking CXX shared module ../../../bin/plasma_packagestructure_plasmashell.so[ 23%] Building CXX object plasma-windowed/CMakeFiles/plasmawindowed.dir/plasmawindowed_autogen/mocs_compilation.cpp.o[ 23%] Built target plasma_packagestructure_plasmashellScanning dependencies of target screenpooltest[ 23%] Building CXX object shell/autotests/CMakeFiles/screenpooltest.dir/screenpooltest.cpp.o[ 23%] Building CXX object shell/packageplugins/qmlWallpaper/CMakeFiles/plasma_packagestructure_wallpaper.dir/plasma_packagestructure_wallpaper_autogen/mocs_compilation.cpp.o[ 23%] Linking CXX shared module ../../../bin/plasma_packagestructure_wallpaper.so[ 23%] Built target plasma_packagestructure_wallpaper[ 23%] Generating settings.h, settings.cpp[ 23%] Generating ui_freespacenotifier_prefs_base.h[ 23%] Building CXX object shell/packageplugins/wallpaperimages/CMakeFiles/plasma_packagestructure_wallpaperimages.dir/plasma_packagestructure_wallpaperimages_autogen/mocs_compilation.cpp.oScanning dependencies of target freespacenotifier[ 24%] Building CXX object freespacenotifier/CMakeFiles/freespacenotifier.dir/freespacenotifier.cpp.o[ 24%] Linking CXX executable ../bin/plasmawindowed[ 25%] Building CXX object shell/autotests/CMakeFiles/screenpooltest.dir/__/screenpool.cpp.o[ 25%] Linking CXX shared module ../../../bin/plasma_packagestructure_wallpaperimages.so[ 25%] Built target plasma_packagestructure_wallpaperimages[ 25%] Generating klippersettings.h, klippersettings.cpp[ 25%] Generating ui_generalconfig.h[ 25%] Generating ui_actionsconfig.h[ 25%] Generating ui_editactiondialog.h/usr/home/jenkins/install-prefix/lib/libKF5Declarative.so.5: undefined reference to 

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[Nathaniel Graham]

ngraham added a comment.


  Shall we land this, or are there any other objections?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

To: broulik, #plasma, #vdg, ngraham
Cc: abetts, ngraham, colomar, gregormi, mart, graesslin, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

KDE CI: Plasma plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 124 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/124/
 Project:
Plasma plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 30 Apr 2018 16:07:38 +
 Build duration:
2 min 23 sec and counting
   CONSOLE OUTPUT
  [...truncated 451.53 KB...] ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:274:28: note: 'setMimeTypes' has been explicitly marked deprecated herePLASMA_DEPRECATED void setMimeTypes(const char *key, QStringList mimeTypes);   ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:108:14: warning: 'setMimeTypes' is deprecated [-Wdeprecated-declarations]package->setMimeTypes("theme", mimetypes); ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:274:28: note: 'setMimeTypes' has been explicitly marked deprecated herePLASMA_DEPRECATED void setMimeTypes(const char *key, QStringList mimeTypes);   ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:110:14: warning: 'addDirectoryDefinition' is deprecated [-Wdeprecated-declarations]package->addDirectoryDefinition("config", QStringLiteral("config"), i18n("Configuration Definitions")); ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:225:28: note: 'addDirectoryDefinition' has been explicitly marked deprecated herePLASMA_DEPRECATED void addDirectoryDefinition(const char *key, const QString , const QString );   ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:113:14: warning: 'setMimeTypes' is deprecated [-Wdeprecated-declarations]package->setMimeTypes("config", mimetypes); ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:274:28: note: 'setMimeTypes' has been explicitly marked deprecated herePLASMA_DEPRECATED void setMimeTypes(const char *key, QStringList mimeTypes);   ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:115:14: warning: 'addDirectoryDefinition' is deprecated [-Wdeprecated-declarations]package->addDirectoryDefinition("ui", QStringLiteral("ui"), i18n("User Interface")); ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:225:28: note: 'addDirectoryDefinition' has been explicitly marked deprecated herePLASMA_DEPRECATED void addDirectoryDefinition(const char *key, const QString , const QString );   ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:117:14: warning: 'addDirectoryDefinition' is deprecated [-Wdeprecated-declarations]package->addDirectoryDefinition("data", QStringLiteral("data"), i18n("Data Files")); ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:225:28: note: 'addDirectoryDefinition' has been explicitly marked deprecated herePLASMA_DEPRECATED void addDirectoryDefinition(const char *key, const QString , const QString );   ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:119:14: warning: 'addDirectoryDefinition' is deprecated [-Wdeprecated-declarations]package->addDirectoryDefinition("scripts", QStringLiteral("code"), i18n("Executable Scripts")); ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:225:28: note: 'addDirectoryDefinition' has been explicitly marked deprecated herePLASMA_DEPRECATED void addDirectoryDefinition(const char *key, const QString , const QString );   ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:122:14: warning: 'setMimeTypes' is deprecated [-Wdeprecated-declarations]package->setMimeTypes("scripts", mimetypes); ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:274:28: note: 'setMimeTypes' has been explicitly marked deprecated herePLASMA_DEPRECATED void setMimeTypes(const char *key, QStringList mimeTypes);   ^/usr/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:124:14: warning: 'addDirectoryDefinition' is deprecated [-Wdeprecated-declarations]package->addDirectoryDefinition("translations", QStringLiteral("locale"), i18n("Translations")); 

KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.9 - Build # 156 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/156/
 Project:
Plasma kwin kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 30 Apr 2018 16:02:53 +
 Build duration:
7 min 5 sec and counting
   CONSOLE OUTPUT
  [...truncated 857.13 KB...][ 55%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwintouchscreen.dir/screenpreviewwidget.cpp.o[ 55%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwinscreenedges.dir/screenpreviewwidget.cpp.o[ 55%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/effectModelTest.dir/compositing.cpp.o[ 55%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwintouchscreen.dir/kwin_effects_interface.cpp.o[ 55%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/kwincompositing.dir/compositing.cpp.o[ 55%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwinscreenedges.dir/kwin_effects_interface.cpp.o[ 55%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/effectModelTest.dir/test/effectmodeltest.cpp.o[ 55%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwintouchscreen.dir/kcm_kwintouchscreen_autogen/mocs_compilation.cpp.o[ 55%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwinscreenedges.dir/kcm_kwinscreenedges_autogen/mocs_compilation.cpp.o[ 55%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/kwincompositing.dir/effectconfig.cpp.o[ 55%] Linking CXX shared module ../../bin/kcm_kwintouchscreen.so[ 55%] Linking CXX shared module ../../bin/kcm_kwinscreenedges.so[ 55%] Built target kcm_kwintouchscreen[ 55%] Generating kwin_effects_interface.cpp, kwin_effects_interface.h[ 55%] Generating ui_main.h[ 55%] Generating kwin_effects_interface.moc[ 55%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/kwincompositing.dir/kwin_compositing_interface.cpp.oScanning dependencies of target kcm_kwindesktop[ 55%] Built target kcm_kwinscreenedges[ 55%] Generating kwin_effects_interface.cpp, kwin_effects_interface.h[ 55%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwindesktop.dir/main.cpp.o[ 55%] Generating ui_main.h[ 55%] Generating kwin_effects_interface.moc[ 55%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/effectModelTest.dir/test/modeltest.cpp.oScanning dependencies of target kcm_kwintabbox[ 55%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/main.cpp.o[ 56%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/kwincompositing.dir/kwin_effects_interface.cpp.o/usr/home/jenkins/workspace/Plasma kwin kf5-qt5 FreeBSDQt5.9/kcmkwin/kwindesktop/main.cpp:571:21: warning: 'KPluginInfo' is deprecated [-Wdeprecated-declarations]KPluginInfo pluginInfo(services.first());^/usr/home/jenkins/install-prefix/include/KF5/KService/kplugininfo.h:115:34: note: 'KPluginInfo' has been explicitly marked deprecated hereexplicit KSERVICE_DEPRECATED KPluginInfo(const KService::Ptr service); ^1 warning generated.[ 56%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwindesktop.dir/desktopnameswidget.cpp.o[ 56%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/effectModelTest.dir/kwin_compositing_interface.cpp.o[ 56%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/layoutpreview.cpp.o[ 56%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/kwincompositing.dir/kwincompositing_autogen/mocs_compilation.cpp.o[ 56%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwindesktop.dir/kwin_effects_interface.cpp.o[ 56%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/effectModelTest.dir/kwin_effects_interface.cpp.o[ 56%] Linking CXX shared module ../../bin/kwincompositing.so[ 56%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/thumbnailitem.cpp.o[ 56%] Built target kwincompositing[ 56%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/__/__/tabbox/tabboxconfig.cpp.o[ 56%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwindesktop.dir/kcm_kwindesktop_autogen/mocs_compilation.cpp.oScanning dependencies of target testPluginEffectLoader[ 56%] Building CXX object autotests/CMakeFiles/testPluginEffectLoader.dir/test_plugin_effectloader.cpp.o[ 56%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/effectModelTest.dir/effectModelTest_autogen/mocs_compilation.cpp.o[ 56%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/kwin_effects_interface.cpp.o[ 56%] Linking CXX shared module ../../bin/kcm_kwindesktop.so[ 56%] Built target kcm_kwindesktopScanning dependencies of target testScriptedEffectLoader[ 56%] Linking CXX executable ../../bin/effectModelTest[ 56%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/test_scripted_effectloader.cpp.o[ 57%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/kcm_kwintabbox_autogen/mocs_compilation.cpp.o[ 57%] Building CXX object 

KDE CI: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 - Build # 125 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/125/
 Project:
Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 30 Apr 2018 16:07:38 +
 Build duration:
1 min 22 sec and counting
   CONSOLE OUTPUT
  [...truncated 450.68 KB...]/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:274:28: note: 'setMimeTypes' has been explicitly marked deprecated herePLASMA_DEPRECATED void setMimeTypes(const char *key, QStringList mimeTypes);   ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:108:14: warning: 'setMimeTypes' is deprecated [-Wdeprecated-declarations]package->setMimeTypes("theme", mimetypes); ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:274:28: note: 'setMimeTypes' has been explicitly marked deprecated herePLASMA_DEPRECATED void setMimeTypes(const char *key, QStringList mimeTypes);   ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:110:14: warning: 'addDirectoryDefinition' is deprecated [-Wdeprecated-declarations]package->addDirectoryDefinition("config", QStringLiteral("config"), i18n("Configuration Definitions")); ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:225:28: note: 'addDirectoryDefinition' has been explicitly marked deprecated herePLASMA_DEPRECATED void addDirectoryDefinition(const char *key, const QString , const QString );   ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:113:14: warning: 'setMimeTypes' is deprecated [-Wdeprecated-declarations]package->setMimeTypes("config", mimetypes); ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:274:28: note: 'setMimeTypes' has been explicitly marked deprecated herePLASMA_DEPRECATED void setMimeTypes(const char *key, QStringList mimeTypes);   ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:115:14: warning: 'addDirectoryDefinition' is deprecated [-Wdeprecated-declarations]package->addDirectoryDefinition("ui", QStringLiteral("ui"), i18n("User Interface")); ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:225:28: note: 'addDirectoryDefinition' has been explicitly marked deprecated herePLASMA_DEPRECATED void addDirectoryDefinition(const char *key, const QString , const QString );   ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:117:14: warning: 'addDirectoryDefinition' is deprecated [-Wdeprecated-declarations]package->addDirectoryDefinition("data", QStringLiteral("data"), i18n("Data Files")); ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:225:28: note: 'addDirectoryDefinition' has been explicitly marked deprecated herePLASMA_DEPRECATED void addDirectoryDefinition(const char *key, const QString , const QString );   ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:119:14: warning: 'addDirectoryDefinition' is deprecated [-Wdeprecated-declarations]package->addDirectoryDefinition("scripts", QStringLiteral("code"), i18n("Executable Scripts")); ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:225:28: note: 'addDirectoryDefinition' has been explicitly marked deprecated herePLASMA_DEPRECATED void addDirectoryDefinition(const char *key, const QString , const QString );   ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:122:14: warning: 'setMimeTypes' is deprecated [-Wdeprecated-declarations]package->setMimeTypes("scripts", mimetypes); ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasma/../plasma/package.h:274:28: note: 'setMimeTypes' has been explicitly marked deprecated herePLASMA_DEPRECATED void setMimeTypes(const char *key, QStringList mimeTypes);   ^/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9/src/plasmaquick/private/packages.cpp:124:14: warning: 'addDirectoryDefinition' is deprecated [-Wdeprecated-declarations]

D12577: Allowing KAMD to run without a database backend

[David Edmundson]

davidedmundson added a comment.


  > ivan created this revision.Sat, Apr 28, 2:06 PM
  > This revision was not accepted when it landed; it landed in state Needs 
Review.Sun, Apr 29, 2:21 PM
  
  I don't mind you merging if no-one bothers reviewing your changes, but 
expecting that in 24 hours is a bit ridiculous.
  
  Also this commit contains some very irrelevant changes to your commit message 
(removing kde4 migration, plugin loading validation) please try to keep things 
split.

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D12577

To: ivan, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12606: Use QUrl::fromUserInput to construct sound url

[Wolfgang Bauer]

wbauer added a comment.


  In D12606#255923 , @davidedmundson 
wrote:
  
  > It is not "dead" however it is now restricted to fixes for major bugs such 
as security and data loss.
  
  
  Ok, I don't think this qualifies then...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12606

To: wbauer, #plasma, davidedmundson
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12606: Use QUrl::fromUserInput to construct sound url

[David Edmundson]

davidedmundson added a comment.


  It is not "dead" however it is now restricted to fixes for major bugs such as 
security and data loss.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12606

To: wbauer, #plasma, davidedmundson
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12606: Use QUrl::fromUserInput to construct sound url

[Wolfgang Bauer]

wbauer added a comment.


  Forgot to ask: should I cherry-pick this to the 5.8 branch too?
  Or is that completely dead already anyway?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12606

To: wbauer, #plasma, davidedmundson
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12610: Avoid crashing on failed flatpak_installation_list_installed_refs_for_update

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  flatpak_installation_list_installed_refs_for_update can return null,
  clearly we expect this as we catch it above and show an waring. But on
  finished in the lambda we call refs->len, which obviously crashes.
  
  onFetchUpdatesFinished doesnt' do anything with an empty list.
  
  BUG: 393614

TEST PLAN
  None, just read backtrace and code.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12610

AFFECTED FILES
  libdiscover/backends/FlatpakBackend/FlatpakNotifier.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10747: Implement zwp_linux_dmabuf_v1

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> linuxdmabuf_v1_interface.cpp:364
> +
> +static void unbind(wl_client *client, wl_resource *resource);
> +static void createParamsCallback(wl_client *client, wl_resource 
> *resource, uint32_t id);

is this defined? I can't find it

I'd expect it be used on line 408.

> linuxdmabuf_v1_interface.h:65
> + */
> +class Buffer {
> +public:

doesn't this need exporting?

> linuxdmabuf_v1_interface.h:99
> + */
> +class KWAYLANDSERVER_EXPORT LinuxDmabufUnstableV1Interface : public Global
> +{

One of kwayland's functions is to act as an abstraction layer

Generally all exported class names aren't called with UnstableV1 or whatever.
This would be LinuxDmabufInterface and then we'd handle the V1 stuff in the 
private implementation.

(Personally, I think it's far more effort than it's worth to abstract something 
that isn't guaranteed to be compatiable, and would be ok for you argue that 
it's deliberate)

> fredrik wrote in linuxdmabuf_v1_interface.h:107
> Is this the solution we want for interfacing with the compositor?
> 
> My preference would be to use std::function callbacks, with setters in 
> LinuxDmabufUnstableV1Interface. Setting up the interface could then look like 
> this:
> 
>   m_linuxDmabuf = m_display->createLinuxDmabufInterface(m_display);
>   m_linuxDmabuf->setQuerySupportedFormats([]{ return 
> Compositor::self()->scene()->supportedDrmFormats(); });
>   ...
>   m_linuxDmabuf->create();
> 
> This can also be extended without breaking binary compatibility. But I don't 
> think we can use std::function in frameworks. There are also BIC issues when 
> mixing different STL implementations, which we may or may not care about.

I don't think I fully understand the issue.

I assume the problem we're solving is that we need to provide supportedFormats 
on client bind, and as per the spec we need to do that immediately but we don't 
have that information before the scene is created which comes after we create 
the global?

Looking at the current kwin patch we'd just return wrong values / even crash if 
we were called before the scene was created. Given that's currently the case, 
why can't we just have the compositor call  a normal setSupportedFormats(...) 
when the scene is first set up.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10747

To: fredrik, #kwin, #plasma, graesslin, davidedmundson, mart
Cc: romangg, plasma-devel, #frameworks, ragreen, Pitel, schernikov, michaelh, 
ZrenBot, bruns, alexeymin, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
eliasp, sebas, apol, mart, hein

KDE CI: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 - Build # 264 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.9/264/
 Project:
Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 30 Apr 2018 11:48:31 +
 Build duration:
2 min 4 sec and counting
   CONSOLE OUTPUT
  [...truncated 727.32 KB...][ 21%] Building CXX object libtaskmanager/CMakeFiles/taskmanager.dir/tasktools.cpp.o[ 21%] Building CXX object libtaskmanager/CMakeFiles/taskmanager.dir/virtualdesktopinfo.cpp.o/usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/components/shellprivate/widgetexplorer/widgetexplorer.cpp:141:59: warning: 'listAppletInfo' is deprecated [-Wdeprecated-declarations]const QList list = PluginLoader::self()->listAppletInfo(QString());  ^/usr/home/jenkins/install-prefix/include/KF5/plasma/pluginloader.h:178:41: note: 'listAppletInfo' has been explicitly marked deprecated herePLASMA_DEPRECATED KPluginInfo::List listAppletInfo(const QString , const QString  = QString());^[ 21%] Building CXX object components/keyboardlayout/CMakeFiles/keyboardlayoutplugin.dir/keyboardlayoutplugin.cpp.o1 warning generated.[ 21%] Building CXX object components/shellprivate/CMakeFiles/plasmashellprivateplugin.dir/shellprivateplugin.cpp.o[ 21%] Building CXX object components/shellprivate/CMakeFiles/plasmashellprivateplugin.dir/interactiveconsole/interactiveconsole.cpp.o[ 21%] Building CXX object libtaskmanager/CMakeFiles/taskmanager.dir/waylandtasksmodel.cpp.o[ 21%] Building CXX object components/keyboardlayout/CMakeFiles/keyboardlayoutplugin.dir/debug.cpp.o[ 21%] Building CXX object components/keyboardlayout/CMakeFiles/keyboardlayoutplugin.dir/keyboardlayoutplugin_autogen/mocs_compilation.cpp.o[ 22%] Building CXX object libtaskmanager/CMakeFiles/taskmanager.dir/windowtasksmodel.cpp.o/usr/home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9/components/shellprivate/interactiveconsole/interactiveconsole.cpp:387:21: warning: 'KPluginInfo' is deprecated [-Wdeprecated-declarations]KPluginInfo info(it.value());^/usr/home/jenkins/install-prefix/include/KF5/KService/kplugininfo.h:115:34: note: 'KPluginInfo' has been explicitly marked deprecated hereexplicit KSERVICE_DEPRECATED KPluginInfo(const KService::Ptr service); ^[ 22%] Linking CXX shared library ../../bin/libkeyboardlayoutplugin.so1 warning generated.[ 23%] Building CXX object components/shellprivate/CMakeFiles/plasmashellprivateplugin.dir/plasmashellprivateplugin_autogen/mocs_compilation.cpp.o[ 23%] Built target keyboardlayoutpluginScanning dependencies of target sessionsprivateplugin_autogen[ 23%] Automatic MOC for target sessionsprivateplugin[ 23%] Built target sessionsprivateplugin_autogen[ 23%] Building CXX object libtaskmanager/CMakeFiles/taskmanager.dir/xwindowsystemeventbatcher.cpp.oScanning dependencies of target plasmawindowed[ 23%] Building CXX object plasma-windowed/CMakeFiles/plasmawindowed.dir/plasmawindowedcorona.cpp.o[ 23%] Building CXX object libtaskmanager/CMakeFiles/taskmanager.dir/xwindowtasksmodel.cpp.o[ 23%] Building CXX object libtaskmanager/CMakeFiles/taskmanager.dir/taskmanager_autogen/mocs_compilation.cpp.o[ 23%] Linking CXX shared library ../../bin/libplasmashellprivateplugin.so[ 23%] Building CXX object plasma-windowed/CMakeFiles/plasmawindowed.dir/plasmawindowedview.cpp.o[ 23%] Built target plasmashellprivatepluginScanning dependencies of target plasmashell_autogen[ 23%] Automatic MOC for target plasmashell[ 23%] Building CXX object plasma-windowed/CMakeFiles/plasmawindowed.dir/main.cpp.o[ 23%] Linking CXX shared library ../bin/libtaskmanager.so[ 23%] Built target plasmashell_autogenScanning dependencies of target plasma_packagestructure_layoutemplate[ 23%] Building CXX object shell/packageplugins/layouttemplate/CMakeFiles/plasma_packagestructure_layoutemplate.dir/layouttemplate.cpp.o[ 23%] Built target taskmanagerScanning dependencies of target plasma_packagestructure_lookandfeel[ 23%] Building CXX object shell/packageplugins/lookandfeel/CMakeFiles/plasma_packagestructure_lookandfeel.dir/lookandfeel.cpp.o[ 23%] Building CXX object shell/packageplugins/layouttemplate/CMakeFiles/plasma_packagestructure_layoutemplate.dir/plasma_packagestructure_layoutemplate_autogen/mocs_compilation.cpp.o[ 23%] Linking CXX shared module ../../../bin/plasma_packagestructure_layoutemplate.so[ 23%] Building CXX object plasma-windowed/CMakeFiles/plasmawindowed.dir/plasmawindowed_autogen/mocs_compilation.cpp.o[ 23%] Built target plasma_packagestructure_layoutemplate[ 23%] Building CXX object shell/packageplugins/lookandfeel/CMakeFiles/plasma_packagestructure_lookandfeel.dir/plasma_packagestructure_lookandfeel_autogen/mocs_compilation.cpp.oScanning dependencies of target plasma_packagestructure_plasmashell[ 23%] Building CXX object 

KDE CI: Plasma plasma-workspace stable-kf5-qt5 FreeBSDQt5.9 - Build # 98 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-workspace%20stable-kf5-qt5%20FreeBSDQt5.9/98/
 Project:
Plasma plasma-workspace stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 30 Apr 2018 11:47:46 +
 Build duration:
1 min 20 sec and counting
   CONSOLE OUTPUT
  [...truncated 739.09 KB...][ 25%] Building CXX object shell/CMakeFiles/plasmashell.dir/currentcontainmentactionsmodel.cpp.o[ 25%] Linking CXX shared library libkeyboardlayoutplugin.so[ 25%] Building CXX object libdbusmenuqt/CMakeFiles/dbusmenuqt.dir/dbusmenu_interface.cpp.o[ 25%] Built target keyboardlayoutplugin[ 25%] Building CXX object components/shellprivate/CMakeFiles/plasmashellprivateplugin.dir/widgetexplorer/widgetexplorer.cpp.o[ 25%] Building CXX object libdbusmenuqt/CMakeFiles/dbusmenuqt.dir/dbusmenuqt_autogen/mocs_compilation.cpp.o[ 25%] Building CXX object shell/CMakeFiles/plasmashell.dir/desktopview.cpp.o[ 25%] Building CXX object libtaskmanager/CMakeFiles/taskmanager.dir/launchertasksmodel.cpp.o[ 25%] Building CXX object plasma-windowed/CMakeFiles/plasmawindowed.dir/plasmawindowed_autogen/mocs_compilation.cpp.o[ 25%] Building CXX object libtaskmanager/CMakeFiles/taskmanager.dir/startuptasksmodel.cpp.o[ 25%] Building CXX object libkworkspace/CMakeFiles/kworkspace.dir/kwin_interface.cpp.o[ 25%] Building CXX object libkworkspace/CMakeFiles/kworkspace.dir/kworkspace_autogen/mocs_compilation.cpp.o[ 25%] Building CXX object shell/CMakeFiles/plasmashell.dir/panelview.cpp.o[ 25%] Building CXX object libtaskmanager/CMakeFiles/taskmanager.dir/taskfilterproxymodel.cpp.o[ 26%] Building CXX object shell/CMakeFiles/plasmashell.dir/panelconfigview.cpp.o[ 27%] Linking CXX static library libdbusmenuqt.a[ 27%] Linking CXX executable plasmawindowed[ 27%] Built target dbusmenuqtScanning dependencies of target plasma_packagestructure_lookandfeel[ 27%] Building CXX object libtaskmanager/CMakeFiles/taskmanager.dir/taskgroupingproxymodel.cpp.o[ 28%] Building CXX object shell/packageplugins/lookandfeel/CMakeFiles/plasma_packagestructure_lookandfeel.dir/lookandfeel.cpp.o/usr/home/jenkins/workspace/Plasma plasma-workspace stable-kf5-qt5 FreeBSDQt5.9/components/shellprivate/widgetexplorer/widgetexplorer.cpp:141:59: warning: 'listAppletInfo' is deprecated [-Wdeprecated-declarations]const QList list = PluginLoader::self()->listAppletInfo(QString());  ^/usr/home/jenkins/install-prefix/include/KF5/plasma/pluginloader.h:178:41: note: 'listAppletInfo' has been explicitly marked deprecated herePLASMA_DEPRECATED KPluginInfo::List listAppletInfo(const QString , const QString  = QString());^[ 28%] Building CXX object shell/packageplugins/lookandfeel/CMakeFiles/plasma_packagestructure_lookandfeel.dir/plasma_packagestructure_lookandfeel_autogen/mocs_compilation.cpp.o[ 28%] Building CXX object shell/CMakeFiles/plasmashell.dir/panelshadows.cpp.o/usr/home/jenkins/install-prefix/lib/libKF5Declarative.so.5: undefined reference to `QQmlPropertyMap::init(QMetaObject const*)@Qt_5'/usr/home/jenkins/install-prefix/lib/libKF5Declarative.so.5: undefined reference to `QQmlPropertyMap::allocatePrivate()@Qt_5'c++: error: linker command failed with exit code 1 (use -v to see invocation)gmake[2]: *** [plasma-windowed/CMakeFiles/plasmawindowed.dir/build.make:129: plasma-windowed/plasmawindowed] Error 1gmake[1]: *** [CMakeFiles/Makefile2:1746: plasma-windowed/CMakeFiles/plasmawindowed.dir/all] Error 2gmake[1]: *** Waiting for unfinished jobs[ 28%] Building CXX object components/shellprivate/CMakeFiles/plasmashellprivateplugin.dir/shellprivateplugin.cpp.o[ 28%] Building CXX object libtaskmanager/CMakeFiles/taskmanager.dir/tasksmodel.cpp.o[ 29%] Linking CXX shared library libkworkspace5.so1 warning generated.[ 30%] Building CXX object components/shellprivate/CMakeFiles/plasmashellprivateplugin.dir/interactiveconsole/interactiveconsole.cpp.o[ 30%] Built target kworkspace[ 30%] Building CXX object shell/CMakeFiles/plasmashell.dir/shellcorona.cpp.o[ 30%] Linking CXX shared module plasma_packagestructure_lookandfeel.so[ 30%] Built target plasma_packagestructure_lookandfeel[ 30%] Building CXX object components/shellprivate/CMakeFiles/plasmashellprivateplugin.dir/plasmashellprivateplugin_autogen/mocs_compilation.cpp.o[ 31%] Building CXX object libtaskmanager/CMakeFiles/taskmanager.dir/tasktools.cpp.o[ 31%] Building CXX object shell/CMakeFiles/plasmashell.dir/shellmanager.cpp.o[ 31%] Building CXX object shell/CMakeFiles/plasmashell.dir/standaloneappcorona.cpp.o[ 31%] Building CXX object shell/CMakeFiles/plasmashell.dir/osd.cpp.o/usr/home/jenkins/workspace/Plasma plasma-workspace stable-kf5-qt5 FreeBSDQt5.9/components/shellprivate/interactiveconsole/interactiveconsole.cpp:387:21: warning: 'KPluginInfo' is deprecated [-Wdeprecated-declarations]KPluginInfo info(it.value());

D12606: Use QUrl::fromUserInput to construct sound url

[Wolfgang Bauer]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:608204765110: [ksmserver] Use QUrl::fromUserInput to 
construct sound url (authored by wbauer).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12606?vs=33308=33321

REVISION DETAIL
  https://phabricator.kde.org/D12606

AFFECTED FILES
  ksmserver/startup.cpp

To: wbauer, #plasma, davidedmundson
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Notes from Sprint - Plasma Browser Integration

[David Edmundson]

Plasma Browser Integration has a host part and a client (chrome/firefox
extension) part. The host must be installed by distros,

The plan of action we've agreed upon is that we (by default) won't install
the client part. We'll encourage distros to install the host part by
default.

The host part will also ship a mechanism that will show a non-invasive
popup when firefox/chrome is launched with a link to the relevant browser
store.

We also have an agreed upon git-tagging mechanism for the relevant store
uploads being out of sync with Plasma releases. See Readme in repo.

The extensions will be marked public just before the Plasma beta.

Another sprint decision was that we have a collective duty to make sure
Falkon is at feature parity in terms of Plasma integration. (probably using
PBI doesn't make sense, it'll be easier to just reimplement any features
natively).



In terms of other actions:
 - we now have an official KDE account managing the firefox store ready for
me and Kai to get simultaneously hit by a bus.
 - i18n is *hopefully* fixed with custom scripts to handle json->pot->*kde
magic*->pot->json system.
 - a lot of dead code for future features has been removed
 - both firefox and chrome stores have been updated to the current code

David

Notes from Sprint - Input stuff

[David Edmundson]

As you may know, we had the lead dev of the new Qt input stack at the
sprint, with one goal to show all the really unusual things we do with
input and trying to make sure the new stack can handle them.

The new stack really isn't there for mouse input as-is; and won't be in
5.11 either. My gut feeling from the current state is that it might be up
to us to make sure mouse (as opposed to just touch) is as complete.

Overall I like a lot. I ported some parts of plasma-desktop to the new API.
(branch qtlabs_handler). Some parts (including complex drag and drop) went
surprisingly smoothly. Eike also ported some of folderview and can post
details on that

We've got a few design changes in (taphandler hit areas being bigger than
parents, drag starts after time delay) either requested or in review
already. Overall I think we're now a bit closer to being involved in the
dev process which is a good thing. A few hours of dev now could prevent
days of complex workarounds in the future.

David

D12481: Add dptr to models

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R994:0abe8778072a: Add dptr to models (authored by 
nicolasfella).

REPOSITORY
  R994 Pulseaudio Qt Bindings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12481?vs=32924=33315

REVISION DETAIL
  https://phabricator.kde.org/D12481

AFFECTED FILES
  src/models.cpp
  src/models.h
  src/models_p.h

To: nicolasfella, drosca, apol, davidedmundson
Cc: davidedmundson, broulik, apol, drosca, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D12481: Add dptr to models

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> broulik wrote in models_p.h:26
> Do we need an explicit `Q_DECL_HIDDEN` or something?

No. That's only needed for when people do

class AbstractModel::Private

where AbstractModel is exported

REPOSITORY
  R994 Pulseaudio Qt Bindings

BRANCH
  dptr

REVISION DETAIL
  https://phabricator.kde.org/D12481

To: nicolasfella, drosca, apol, davidedmundson
Cc: davidedmundson, broulik, apol, drosca, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart