D12855: Move search field to its own row so it doesn't get compressed

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> WidgetExplorer.qml:157
>  /*
> +* This was here when I got here 5/12/18 - sharvey
>  PlasmaCore.Dialog {

? Not sure The extra comment adds anything. Instead we should just remove the 
commented-out code in a new patch IMHO.

> WidgetExplorer.qml:203
>  id: topBar
> +spacing: 10
>  anchors {

Can we use some multiple of `units.smallSpacing` or something here instead of a 
hardcoded pixel value?

> WidgetExplorer.qml:210
>  
> +
>  Item {

Unrelated whitespace change

> WidgetExplorer.qml:215
>  Layout.fillWidth: true
> -Layout.minimumHeight: Math.max(heading.height, 
> searchInput.height)
> +Layout.minimumHeight: heading.height
>  Layout.alignment: Qt.AlignVCenter

Does anything break if we just remove this line entirely?

> WidgetExplorer.qml:223
>  elide: Text.ElideRight
> -visible: !header.showingSearch
> -}
> -PlasmaComponents.TextField {
> -id: searchInput
> -width: parent.width
> -clearButtonShown: true
> -anchors.verticalCenter: parent.verticalCenter
> -placeholderText: 
> i18nd("plasma_shell_org.kde.plasma.desktop", "Search...")
> -onTextChanged: {
> -list.positionViewAtBeginning()
> -list.currentIndex = -1
> -widgetExplorer.widgetsModel.searchTerm = text
> -header.showingSearch = (text != "");
> -}
> -
> -Component.onCompleted: forceActiveFocus()
> -visible: header.showingSearch
> +visible: true
>  }

No need for this anymore, since `True` is the default value.

> WidgetExplorer.qml:263
>  
> +// move search textbox to its own row
> +RowLayout {

This comment, if necessary at all, should be phrased in terms of the current 
state, not the change that added it.

> WidgetExplorer.qml:274
> +
> +spacing: 10
> +

Ditto; let's not use a hardcoded pixel value.

> WidgetExplorer.qml:389
>  }
> -

Unrelated whitespace change

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12855

To: sharvey, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12859: [QuickShare] Respect units.iconSizeHints.panel for panel icon

[Chris Holland]

Zren created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  Reported on reddit: 
https://www.reddit.com/r/kde/comments/8j3iem/why_is_the_share_widget_icon_not_the_same_size_as/
  
  Before:
  F5846816: 2018-05-13___20-26-42.png 
  
  After:
  F5846818: 2018-05-13___20-56-37.png 

TEST PLAN
  1. Add QuickShare and ShowDesktop widgets to a wide panel.
  2. System Settings > Icons > Advanced > Panel > 22px
  3. Confirm ShowDesktop respects icon size, while QuickShare does not.
  4. Install patched version of QuickShare + restart plasmashell.
  5. Confirm both respect icon size.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D12859

AFFECTED FILES
  applets/quickshare/plasmoid/contents/ui/main.qml

To: Zren
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12837: Split replaceAccount from addAccountToCache

[Nathaniel Graham]

ngraham added a comment.


  Bulletproof steps to reproduce for me:
  
  1. System Settings > Account Details > User Manager > Create a new user
  2. Give the new user admin rights
  3. Log out
  4. Log in as that the new user
  5. Go to System Settings > Account Details > User Manager
  
  The user you were just logged in as before isn't listed!
  
  This patch fixes that bug for me. The patch looks sane, but this code seems 
fragile and really needs an autotest...

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D12837

To: valeriymalov, #plasma
Cc: ngraham, rdieter, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12855: Move search field to its own row so it doesn't get compressed

[Scott Harvey]

sharvey updated this revision to Diff 34083.
sharvey added a comment.


  Submitted from wrong local branch

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12855?vs=34078=34083

BRANCH
  new-search-row (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12855

AFFECTED FILES
  desktoppackage/contents/explorer/WidgetExplorer.qml

To: sharvey, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12857: Systemmonitor: use different label format when the applet is on a vertical panel

[Miklós Máté]

miklosm created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
miklosm requested review of this revision.

REVISION SUMMARY
  When the applet is on a vertical panel, its horizontal size is limited, and 
the speedLabel clashes with the name label. I fixed that by moving the speed 
values below the sensor name in this case.
  
  I also added some cleanups unintentionally (the first three hunks), as I 
couldn't find a way to change the diff after it's submitted. They remove an 
unneeded import, and fix some uninitialized variable warnings. Feel free to 
ignore them.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12857

AFFECTED FILES
  applets/systemmonitor/common/contents/ui/Applet.qml
  applets/systemmonitor/common/contents/ui/ConfigGeneral.qml
  applets/systemmonitor/common/contents/ui/DoublePlotter.qml
  applets/systemmonitor/common/contents/ui/SinglePlotter.qml
  applets/systemmonitor/cpu/contents/ui/cpu.qml
  applets/systemmonitor/diskactivity/contents/ui/diskactivity.qml
  applets/systemmonitor/memory/contents/ui/memory.qml
  applets/systemmonitor/net/contents/ui/net.qml

To: miklosm
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12855: Move search field to its own row so it doesn't get compressed

[Scott Harvey]

sharvey added a comment.


  Before:
  
  {F5846708}
  --
  
  After:
  F5846710: Screenshot_20180513_082104.png 
 F5846712: Screenshot_20180513_082036.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12855

To: sharvey, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12849: Improve layout of fonts kcm

[Nathaniel Graham]

ngraham added a comment.


  Alignment looks great to me! We might want to take the opportunity to also 
center-align the titles, which it better-looking for these centered formlayout 
style UIs. And maybe use a bit of extra vertical padding instead of that 
horizontalline separator?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12849

To: progwolff, mart, abetts, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12855: Move search field to its own row so it doesn't get compressed

[Scott Harvey]

sharvey created this revision.
sharvey added reviewers: ngraham, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
sharvey requested review of this revision.

REVISION SUMMARY
  Move search to its own row to prevent it from being compressed

TEST PLAN
  - Recompile `plasma-desktop`
  - Bring up Widget Explorer
  - Press Search to see Search in new row
  - Select widget type category to see Title become elided

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12855

AFFECTED FILES
  desktoppackage/contents/explorer/WidgetExplorer.qml

To: sharvey, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: Cursor sizes on wayland

[Martin Flöser]

Am 2018-05-09 12:08, schrieb Aleix Pol:
On Tue, May 8, 2018 at 8:57 PM, Martin Flöser  
wrote:



Am 8. Mai 2018 17:05:57 MESZ schrieb Aleix Pol :

Hi,
I've been looking into getting a consistent cursor look on wayland,
which is specially daunting because of scaling.

I'd like to look into fixing it for xwayland clients. Would somebody
be able to shed some light into the issue so I can understand it and
fix it?

Xwayland clients use the normal X11 API to set cursors. Xwayland just 
forwards them through the Wayland protocol. The env variable for 
cursor size is the same on Wayland and X11, so there should not be any 
difference.


I'm not sure what exactly you want to look into. Personally I had the 
feeling that apps started to act crazy concerning cursor sizes - on 
Wayland and on X11. Normally there just should not be any difference. 
There's one env variable controlling it and if all apps would just use 
it and not do crazy stuff instead it would just work.


Well, setting the cursor size isn't any useful if you have two
monitors. I have it configured at resolution-dependent at the moment
and sometimes I lose my cursor on my high dpi screen.
If I use something bigger, when I move it to my external monitor I get
a monstrosity.

David mentioned at the sprint that we maybe should be correcting its
scale on the kwin size, if it's not being scaled yet.


This might be part of the solution. This needs a more general solution 
and might require changes to Wayland protocols and each toolkit and 
KWin.


For "normal" windows we use the wl_surface::enter to inform on which 
output they are. Thus they can adjust for different dpi. Similar there 
is the scale information on a wl_surface.


For a cursor wl_surface KWin neither emits the output information nor 
uses the scale information. Both would be relative easy to implement. 
But only makes sense if toolkits support it. Last time I looked at Qt 
code, Qt did not (but that's some time ago).


So to get this properly working, I would suggest to add the output 
enter/leave information to cursor surfaces and honor scale in KWin. Then 
add the same to QtWayland if it doesn't exist already.


Cheers
Martin

D12853: Calendar widget: fix resize

[Miklós Máté]

miklosm created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
miklosm requested review of this revision.

REVISION SUMMARY
  If the fullRepresentation has a minimum size, the applet cannot be shrinked 
back to show the compactRepresentation.
  
  Alternative fix: make the switch size larger than the minimum size of the 
fullRepresentation

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12853

AFFECTED FILES
  applets/calendar/package/contents/ui/main.qml

To: miklosm
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12835: Draw borders around side panels by default

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Wow, I didn't know what a minefield I was stepping into with this topic... 
but I believe my suspicions are confirmed that this design choice represented a 
compromise that did not satisfy everyone--hence the option. I can see now that 
flipping this default won't cut it, and we need to do some more serious design 
work if any changes are to be made. I'll see if I can dig up the history behind 
this (already found https://forum.kde.org/viewtopic.php?f=285=120006) so I 
can be more informed going forward.
  
  What I see folks objecting to most in the discussion here is the frame. 
That's actually the part I think is least important and that I'll agree is most 
dated-looking. To me, what's needed is a bit more visual separation of the list 
and the content area-it doesn't need to be a frame though! What needs to be 
communicated is that they're connected, but different. Conventional tabbed 
views accomplish this very well, but I'm not sure the current design here does 
the same. The categories just feel unmoored to me, floating there in the window 
without enough containment. To me they feel jarringly like they could escape 
underneath the part of the window where the blue line doesn't extend all the 
way to the bottom. And it feels awkward that their background color is the same 
as the rest of the window. Most other UIs in our software that involve sidebars 
use a different color for the backgrounds of the sidebar and the content area 
(but often inconsistently).
  
  And yes, all of this is my subjective feeling.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D12835

To: ngraham, andreaska, hpereiradacosta
Cc: dhaumann, hpereiradacosta, abetts, rkflx, cfeck, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12852: Added the option to display date in the same line of clock

[Andrea Stevanato]

astevanato created this revision.
astevanato added a reviewer: Plasma: Workspaces.
astevanato added a project: Plasma: Workspaces.
Restricted Application edited projects, added Plasma; removed Plasma: 
Workspaces.
Restricted Application added a subscriber: plasma-devel.
astevanato requested review of this revision.

REVISION SUMMARY
  Added the possibility to display date in tha same line of clock though there 
are the space for display the date on the bottom of the clock
  F5846363: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12852

AFFECTED FILES
  applets/digital-clock/package/contents/config/main.xml
  applets/digital-clock/package/contents/ui/DigitalClock.qml
  applets/digital-clock/package/contents/ui/configAppearance.qml

To: astevanato, #plasma_workspaces
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12851: Change preview text background color to match with default combobox background color

[Julian Wolff]

progwolff created this revision.
progwolff added reviewers: mart, abetts, ngraham.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
progwolff requested review of this revision.

REVISION SUMMARY
  The default combobox background color is white (QPalette::Base / 
Kirigami.Theme.View),
  preview comboboxes were gray (QPalette::Window / Kirigami.Theme.Window)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fonts_kcm_comboboxes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12851

AFFECTED FILES
  kcms/fonts/package/contents/ui/main.qml
  kcms/fonts/previewimageprovider.cpp

To: progwolff, mart, abetts, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12849: Improve layout of fonts kcm

[Julian Wolff]

progwolff created this revision.
progwolff added reviewers: mart, abetts, ngraham.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
progwolff requested review of this revision.

REVISION SUMMARY
  Change the layout of the fonts kcm using checkable form layout items as 
suggested in
  https://phabricator.kde.org/T7927#132277

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fonts_kcm_layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12849

AFFECTED FILES
  kcms/fonts/package/contents/ui/main.qml

To: progwolff, mart, abetts, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12835: Draw borders around side panels by default

[Dominik Haumann]

dhaumann added a comment.


  I as someone being around for 15 years now also immediately thought "huh? Why 
this forth and back and forth..."?
  
  I believe you need much more investigation here and discussion with the 
visual design group, maybe a blog asking about what people like more.

REPOSITORY
  R31 Breeze

BRANCH
  borders-around-settings-window-side-panels (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12835

To: ngraham, andreaska, hpereiradacosta
Cc: dhaumann, hpereiradacosta, abetts, rkflx, cfeck, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12835: Draw borders around side panels by default

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Note: I am not saying that the current design is the best one. However it was 
designed as an improvement to the framed one. Reverting to the framed version 
is basically discarding this work. I would rather see some work done on 
improving upon what has been done rather than discarding it.

REPOSITORY
  R31 Breeze

BRANCH
  borders-around-settings-window-side-panels (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12835

To: ngraham, andreaska, hpereiradacosta
Cc: hpereiradacosta, abetts, rkflx, cfeck, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12835: Draw borders around side panels by default

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Note that there is no bug report, to my knowledge, complaining about this. 
(neither usability wise nor design wise).

REPOSITORY
  R31 Breeze

BRANCH
  borders-around-settings-window-side-panels (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12835

To: ngraham, andreaska
Cc: hpereiradacosta, abetts, rkflx, cfeck, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12835: Draw borders around side panels by default

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Maybe it is just me who has been around for too long ...

REPOSITORY
  R31 Breeze

BRANCH
  borders-around-settings-window-side-panels (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12835

To: ngraham, andreaska
Cc: hpereiradacosta, abetts, rkflx, cfeck, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12835: Draw borders around side panels by default

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  This is really interesting how things go back and forth if you wait long 
enough ...
  Removing this frame (by default) was a _big_ thing at the time breeze was 
designed, and there was countless discussion on how to do it.
  Wait five years, and the same discussion comes again, full reverse, with 
using the same arguments, reverse, in the sense that what was used to say "its 
good" before, has now become "bad" and vice versa. 
  To me, at least, who has attended both debates, the whole point seems a bit 
pointless. (and demotivating).

REPOSITORY
  R31 Breeze

BRANCH
  borders-around-settings-window-side-panels (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12835

To: ngraham, andreaska
Cc: hpereiradacosta, abetts, rkflx, cfeck, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein updated this revision to Diff 34053.
hein added a comment.


  Don't mutate source model while building list of langs to add to selection.
  
  This will likely fix Marco's problem.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12102?vs=34051=34053

BRANCH
  arcpatch-D12102_1

REVISION DETAIL
  https://phabricator.kde.org/D12102

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/translations/CMakeLists.txt
  kcms/translations/Messages.sh
  kcms/translations/kcm_translations.desktop
  kcms/translations/kcmtranslations.cpp
  kcms/translations/kcmtranslations.h
  kcms/translations/kcmtranslationswidget.ui
  kcms/translations/package/contents/ui/main.qml
  kcms/translations/package/metadata.desktop
  kcms/translations/translations.cpp
  kcms/translations/translations.desktop
  kcms/translations/translations.h
  kcms/translations/translationsmodel.cpp
  kcms/translations/translationsmodel.h

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12822: Added null check in OverlayDrawer

[Antonio Davide Trogu]

Dax added a comment.


  Yes it's the same one!

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12822

To: Dax
Cc: apol, plasma-devel, davidedmundson, mart, hein

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein updated this revision to Diff 34051.
hein added a comment.


  Remove width from delegate in sheet again.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12102?vs=33818=34051

BRANCH
  arcpatch-D12102_1

REVISION DETAIL
  https://phabricator.kde.org/D12102

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/translations/CMakeLists.txt
  kcms/translations/Messages.sh
  kcms/translations/kcm_translations.desktop
  kcms/translations/kcmtranslations.cpp
  kcms/translations/kcmtranslations.h
  kcms/translations/kcmtranslationswidget.ui
  kcms/translations/package/contents/ui/main.qml
  kcms/translations/package/metadata.desktop
  kcms/translations/translations.cpp
  kcms/translations/translations.desktop
  kcms/translations/translations.h
  kcms/translations/translationsmodel.cpp
  kcms/translations/translationsmodel.h

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12774: Fix submenus not updating when switching between categories of the same size

[Eike Hein]

hein added a comment.


  No worries, also my fault for not spotting it in review. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12774

To: hein, #plasma, mart
Cc: dfaure, rikmills, ngraham, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12835: Draw borders around side panels by default

[Henrik Fehlauer]

rkflx added a comment.


  If you revert a design decision, your summary should include a reference to 
the arguments of the original decision, a justification for changing it back 
again based on those, and you should try to get consent from the original 
authors and designers.
  
  In general it's a sensible thing to respect the choices of your fellow 
contributors working on the code before you, because working with each other is 
more effective than working against each other in the long term.
  
  In D12835#261523 , @ngraham wrote:
  
  > I wasn't around for the KDE4/oxygen days, so I wasn't aware this 
represented a reversion of anything; I just think this patch results in better 
visual design that the status quo.
  
  
  No need to go back to KDE4, you can simply try Oxygen and Fusion. IMO the 
whole point of different styles is to look different, and the minimalism of 
Breeze is just part of its DNA. If you think of the current design as a 
vertical tabbar, it makes sense (you would not apply the same patch to the 
normal tabbar, would you?).
  
  > Breeze may be a minimalistic theme, but minimalism always rides a fine 
line. If you take away too much, you can reduce clarity, or muddy the 
boundaries between things that are different and separate. The status quo here 
has never sat well with me: the side panel feels like it isn't sure what it 
wants to be. Is its content a part of the main window, or separate? It feels 
like neither. And what's with that blue line that doesn't extend all the way to 
the top or the bottom? The design feels like an unhappy compromise, not 
something that's bold and proud (apologies for all the subjective touchy-feely 
language; this is just how it feels to me). At least with this patch there's a 
clear and confident visual separation of the category list and the content 
area, and now I realize that's what I'm looking for.
  
  What you wrote here confirms my guess: It's how //you// feel about it (and in 
older screenshots of yours it's clear you changed this setting a long time ago, 
now trying to push your personal preference to everybody). My goal is not to 
question your preference, but to speak up that there are users who feel 
different and like the current design, even though those might not have 
discovered your Diff.
  
  > As an alternative, perhaps we should instead move towards making the side 
panels (and dockable panels) look more like System Settings' sidebar: a white 
background, but without a distinct frame, and  a one-pixel line separating it 
from the content area that extends the full height of the window. This would 
Breezey and modern, and much better than either IMHO. We might even be able to 
remove the setting entirely...
  
  I doubt that will work because of the buttons on the bottom left, which would 
be squished visually below your all-white background.

REPOSITORY
  R31 Breeze

BRANCH
  borders-around-settings-window-side-panels (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12835

To: ngraham, andreaska
Cc: abetts, rkflx, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart