D13101: Fix adding langs more than once within the same session.

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:150f8877ee42: Fix adding langs more than once within the 
same session. (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13101?vs=34837=34839

REVISION DETAIL
  https://phabricator.kde.org/D13101

AFFECTED FILES
  kcms/translations/package/contents/ui/main.qml

To: hein, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13101: Fix adding langs more than once within the same session.

[Eike Hein]

hein added a comment.


  There's no more risk than before. Both versions of the code add two lists 
together, the other one just ran into Qt Quick type bullshit where one list got 
serialized to a string.
  
  In terms of what the risk of dupes is: There's one base model with a data 
role for "is this selected or not" and two filter models which filter this base 
model based on this data role, in opposite ways. The list in the add dialog is 
therefore guaranteed not to contain anything that's already selected.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13101

To: hein, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13101: Fix adding langs more than once within the same session.

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> main.qml:108
>  
> addLanguagesSheet.selectedLanguages.sort().forEach(function(index) {
>  
> langs.push(availableLanguagesModel.get(index).LanguageCode);
>  });

Is there now a risk of adding duplicates in 
kcm.translationsModel.selectedLanguages?

Is this a problem?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13101

To: hein, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13101: Fix adding langs more than once within the same session.

[Eike Hein]

hein created this revision.
hein added a reviewer: davidedmundson.
Restricted Application added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  BUG:394455

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.13

REVISION DETAIL
  https://phabricator.kde.org/D13101

AFFECTED FILES
  kcms/translations/package/contents/ui/main.qml

To: hein, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13100: do not use buffered file IO

[Rolf Eike Beer]

dakon created this revision.
dakon added a reviewer: aacid.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
dakon requested review of this revision.

REVISION SUMMARY
  This is not necessary here. Additionally we can use O_CLOEXEC to make sure 
the file descriptors are not leaked by accident.

REPOSITORY
  R107 KWallet PAM Integration

REVISION DETAIL
  https://phabricator.kde.org/D13100

AFFECTED FILES
  pam_kwallet.c

To: dakon, aacid
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11262: KDE logout screen background color fix

[Richard Addison]

raddison added a comment.


  It looks like that in Kubuntu 18.04 ...
  F5866833: current.png 
  
  Seems okay to me. It's not dark, it's fairly transparent and it doesn't have 
any artifacts. Can anyone confirm it with a screenshot?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11262

To: Pitel, mart, #plasma
Cc: raddison, ragreen, fvogt, cfeck, fredrik, ngraham, abetts, broulik, 
mvourlakos, plasma-devel, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

Dependency on Solid/PowerManagement from KDELibs4Support

[Christoph Feck]

Checking what blocks porting away -workspace and -desktop from 
KDELibs4Support, I see Solid/PowerManagement. I have not checked what 
exactly is needed from this module, but could we release this module 
separately if there is no plan to integrate it back to Solid?


--
Christoph Feck

D13095: Scren brightness follow a quatratic progression

[Thomas Surrel]

thsurrel updated this revision to Diff 34825.
thsurrel added a reviewer: Plasma.
thsurrel added a comment.


  Added context

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13095?vs=34812=34825

REVISION DETAIL
  https://phabricator.kde.org/D13095

AFFECTED FILES
  daemon/actions/bundled/brightnesscontrol.cpp
  daemon/powerdevilbackendinterface.cpp
  daemon/powerdevilbackendinterface.h
  daemon/powerdevilbrightnesslogic.cpp

To: thsurrel, #plasma
Cc: romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13095: Scren brightness follow a quatratic progression

[Roman Gilg]

romangg added a comment.


  Pls add context and reviewer Plasma.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D13095

To: thsurrel
Cc: romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13071: [Klipper] Port away from KLineEdit

[Christoph Feck]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:bf5e72907510: Port away from KLineEdit (authored by 
cfeck).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13071?vs=34734=34823

REVISION DETAIL
  https://phabricator.kde.org/D13071

AFFECTED FILES
  klipper/CMakeLists.txt
  klipper/editactiondialog.cpp
  klipper/editactiondialog.ui

To: cfeck, #plasma, graesslin
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13070: [libtaskmanager] Add missing QUrlQuery includes

[Christoph Feck]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ed274a056de9: Add missing QUrlQuery includes (authored by 
cfeck).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13070?vs=34732=34822

REVISION DETAIL
  https://phabricator.kde.org/D13070

AFFECTED FILES
  libtaskmanager/launchertasksmodel.cpp
  libtaskmanager/tasktools.cpp
  libtaskmanager/xwindowtasksmodel.cpp

To: cfeck, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D6313: Support Icon Scale from Icon naming specification 0.13

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> kiconloader.h:277
> + * @p canReturnNull.
> + * @since 5.48
> + */

Next release is 5.47, but I am fine with waiting for additional feedback if 
this is controversial.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, ragreen, Pitel, michaelh, ZrenBot, bruns, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D6313: Support Icon Scale from Icon naming specification 0.13

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> kiconloader.h:527
>   * @see resetPalette
> - * @since 5.39
> + * @since 5.38
>   */

Is this missing a rebase or intended? See 
https://cgit.kde.org/kiconthemes.git/commit/?id=b506a48214a08f56d79e7847a22b0417028a46ff

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, ragreen, Pitel, michaelh, ZrenBot, bruns, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

Re: KDE CI: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Failing!

[Christoph Feck]

On 24.05.2018 12:05, Ben Cooksley wrote:

Based on the lack of response I will be deeming Plasma Vault unmaintained


Why do sysadmins enforce a strict policy to have a clean CI instead of 
"just" offering the service? We don't declare products unmaintained 
because they have bugs in bugzilla either.


--
Christoph Feck

Re: KDE CI: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Failing!

[Nate Graham]

Ivan, please respond.

Ben, Vault is maintained, so it's unfortunate that you haven't gotten a 
response yet.


Nate



On 05/24/2018 04:05 AM, Ben Cooksley wrote:
On Wed, May 23, 2018 at 9:08 PM, Ben Cooksley > wrote:


On Sat, May 19, 2018 at 4:15 PM, Ben Cooksley > wrote:

Hi all,

If someone could please check if this is correct, and whether
Plasma Vault is intended to be built outside of Linux systems?


*Ping*


Based on the lack of response I will be deeming Plasma Vault 
unmaintained and will be moving it there in 24 hours time.

Please be aware that I am not subscribed to the list.

Regards,
Ben



Regards,
Ben


On Sat, May 19, 2018 at 9:30 AM, CI System > wrote:

*BUILD FAILURE*
Build URL

https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/4/


Project:Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10
Date of build:  Fri, 18 May 2018 21:29:55 +
Build duration: 1 min 4 sec and counting


*CONSOLE OUTPUT *
[...truncated 64.88 KB...]
JAVA_HOME = '/usr/local/openjdk8-jre'
BUILD_ID = '4'
PAGER = 'more'
RUN_CHANGES_DISPLAY_URL =

'https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/4/display/redirect?page=changes

'
PKG_CONFIG_PATH =

'/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'
RUN_DISPLAY_URL =

'https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/4/display/redirect

'
BLOCKSIZE = 'K'
BUILD_URL =

'https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/4/

'
LD_LIBRARY_PATH = '/usr/home/jenkins/install-prefix/lib'
JOB_NAME = 'Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10'
TERM = 'su'
SHLVL = '1'
JOB_BASE_NAME = 'Plasma plasma-vault stable-kf5-qt5
FreeBSDQt5.10'
HOME = '/usr/home/jenkins/'
CMAKE_PREFIX_PATH =
'/usr/home/jenkins/install-prefix:/usr/:/usr/local/'
PWD = '/usr/home/jenkins/workspace/Plasma plasma-vault
stable-kf5-qt5 FreeBSDQt5.10'
JOB_DISPLAY_URL =

'https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/display/redirect

'
STAGE_NAME = 'Configuring Build'
BUILD_TAG = 'jenkins-Plasma plasma-vault stable-kf5-qt5
FreeBSDQt5.10-4'
JOB_URL =

'https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/

'
NODE_NAME = 'FreeBSD Builder 3'
HOST = 'freebsd-node3'
WORKSPACE = '/usr/home/jenkins/workspace/Plasma plasma-vault
stable-kf5-qt5 FreeBSDQt5.10'
XDG_CONFIG_DIRS =
'/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'
GROUP = 'jenkins'
BUILD_NUMBER = '4'
HUDSON_URL = 'https://build.kde.org/'
XDG_CURRENT_DESKTOP = 'KDE'
EXECUTOR_NUMBER = '0'
HOSTTYPE = 'FreeBSD'
USER = 'jenkins'
QML2_IMPORT_PATH = '/usr/home/jenkins/install-prefix/lib/qml'
VENDOR = 'amd'
MAIL = '/var/mail/jenkins'
EDITOR = 'vi'
SHELL = '/bin/tcsh'
JENKINS_URL = 'https://build.kde.org/'
XDG_DATA_DIRS =
'/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'
ASAN_OPTIONS =

'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:symbolize=1'
LOGNAME = 'jenkins'
HUDSON_HOME = '/home/production/data'
== Commencing Configuration:
cmake -DCMAKE_BUILD_TYPE=Debug
-DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON
-DCMAKE_INSTALL_PREFIX="/usr/home/jenkins//install-prefix/"

D13030: Display brightness OSD even when min and max is reached

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R122:4b8ae4d708a6: Display brightness OSD even when min and 
max is reached (authored by thsurrel, committed by ngraham).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13030?vs=34751=34819

REVISION DETAIL
  https://phabricator.kde.org/D13030

AFFECTED FILES
  daemon/powerdevilbrightnesslogic.cpp

To: thsurrel, ngraham, romangg
Cc: romangg, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13030: Display brightness OSD even when min and max is reached

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.


  Works for me (can't test minimum case since screen is dark then) and good 
usability improvement.
  
  Please in next patches import the context of the diff to Phab (either use arc 
or `git diff -U9 ...`.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D13030

To: thsurrel, ngraham, romangg
Cc: romangg, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13095: Scren brightness follow a quatratic progression

[Thomas Surrel]

thsurrel created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
thsurrel requested review of this revision.

REVISION SUMMARY
  Modern hardware allow to adjust the screen brightness very precisely,
  with more than hundreds or thousands different possible levels. When
  modifying the screen brightness through the keyboard shortcuts, we
  are not making the best use of this very fine grain possibility,
  notably when in low light conditions. As of today, the progression
  is linear, so for a maximum brightness level of 1000 we are making
  20 steps of 50. This is not great since jumping from 0 to 50 can be
  already too bright when using a laptop in the dark. And when in full
  light, going from 950 to 1000 is barely noticeable.
  
  This patch tries to improve the situation by switching from a
  linear to a quadratic progression, offering smaller steps in the
  low level brightness.
  
  The switch to the quadratic progression is done in
  powerdevilbrightnesslogic.cpp, the other modifications ensure that
  the OSD still displays equal steps when giving a visual feedback,
  otherwise the lower steps are barely distinguishible.
  
  BUG: 362830

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D13095

AFFECTED FILES
  daemon/actions/bundled/brightnesscontrol.cpp
  daemon/powerdevilbackendinterface.cpp
  daemon/powerdevilbackendinterface.h
  daemon/powerdevilbrightnesslogic.cpp

To: thsurrel
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13063: distro release upgrade checker for ubuntu distros

[Jonathan Riddell]

jriddell abandoned this revision.
jriddell added a comment.


  Moved to own app
  https://cgit.kde.org/scratch/jriddell/distro-release-notifier.git/

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D13063

To: jriddell, apol, rikmills
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13073: Weigh matching services by relating data used in query to their menuids

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:664b90afcfd8: Weigh matching services by relating data 
used in query to their menuids (authored by hein).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13073?vs=34804=34808

REVISION DETAIL
  https://phabricator.kde.org/D13073

AFFECTED FILES
  libtaskmanager/tasktools.cpp

To: hein, broulik, davidedmundson
Cc: cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13073: Weigh matching services by relating data used in query to their menuids

[Eike Hein]

hein updated this revision to Diff 34804.
hein added a comment.


  Don't both mutate _and_ return.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13073?vs=34742=34804

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D13073

AFFECTED FILES
  libtaskmanager/tasktools.cpp

To: hein, broulik, davidedmundson
Cc: cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13059: Only enable on XCB

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R100:8d88ca5a07fc: Only enable on XCB (authored by 
davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D13059?vs=34704=34800#toc

REPOSITORY
  R100 KGamma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13059?vs=34704=34800

REVISION DETAIL
  https://phabricator.kde.org/D13059

AFFECTED FILES
  kcmkgamma/kgamma.desktop

To: davidedmundson, #plasma, hein, graesslin
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13062: Don't manipulate foreign windows

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R135:6288079d936b: Dont manipulate foreign windows 
(authored by broulik).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13062?vs=34712=34797

REVISION DETAIL
  https://phabricator.kde.org/D13062

AFFECTED FILES
  src/platformtheme/x11integration.cpp

To: broulik, #plasma, davidedmundson, graesslin
Cc: graesslin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13031: [ProcessModel] Center more column headings

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R111:7a580e83e1b2: [ProcessModel] Center more column headings 
(authored by broulik).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13031?vs=34626=34796

REVISION DETAIL
  https://phabricator.kde.org/D13031

AFFECTED FILES
  processui/ProcessModel.cpp

To: broulik, #plasma, hein
Cc: ngraham, alex-l, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: KDE CI: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Failing!

[Luca Beltrame]

In data giovedì 24 maggio 2018 12:05:08 CEST, Ben Cooksley ha scritto:

> Based on the lack of response I will be deeming Plasma Vault unmaintained
> and will be moving it there in 24 hours time.

Please contact Ivan first. He may have missed this message in the ML.

-- 
Luca Beltrame - KDE Forums team
KDE Science supporter
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

Re: KDE CI: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Failing!

[Ben Cooksley]

On Wed, May 23, 2018 at 9:08 PM, Ben Cooksley  wrote:

> On Sat, May 19, 2018 at 4:15 PM, Ben Cooksley  wrote:
>
>> Hi all,
>>
>> If someone could please check if this is correct, and whether Plasma
>> Vault is intended to be built outside of Linux systems?
>>
>
> *Ping*
>

Based on the lack of response I will be deeming Plasma Vault unmaintained
and will be moving it there in 24 hours time.
Please be aware that I am not subscribed to the list.

Regards,
Ben


>
>
>>
>> Regards,
>> Ben
>>
>>
>> On Sat, May 19, 2018 at 9:30 AM, CI System  wrote:
>>
>>> *BUILD FAILURE*
>>> Build URL https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf5
>>> -qt5%20FreeBSDQt5.10/4/
>>> Project: Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10
>>> Date of build: Fri, 18 May 2018 21:29:55 +
>>> Build duration: 1 min 4 sec and counting
>>> * CONSOLE OUTPUT *
>>> [...truncated 64.88 KB...]
>>> JAVA_HOME = '/usr/local/openjdk8-jre'
>>> BUILD_ID = '4'
>>> PAGER = 'more'
>>> RUN_CHANGES_DISPLAY_URL = 'https://build.kde.org/job/Pla
>>> sma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/4/displa
>>> y/redirect?page=changes'
>>> PKG_CONFIG_PATH = '/usr/home/jenkins/install-pre
>>> fix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'
>>> RUN_DISPLAY_URL = 'https://build.kde.org/job/Pla
>>> sma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/4/display/redirect'
>>> BLOCKSIZE = 'K'
>>> BUILD_URL = 'https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf
>>> 5-qt5%20FreeBSDQt5.10/4/'
>>> LD_LIBRARY_PATH = '/usr/home/jenkins/install-prefix/lib'
>>> JOB_NAME = 'Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10'
>>> TERM = 'su'
>>> SHLVL = '1'
>>> JOB_BASE_NAME = 'Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10'
>>> HOME = '/usr/home/jenkins/'
>>> CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'
>>> PWD = '/usr/home/jenkins/workspace/Plasma plasma-vault stable-kf5-qt5
>>> FreeBSDQt5.10'
>>> JOB_DISPLAY_URL = 'https://build.kde.org/job/Pla
>>> sma%20plasma-vault%20stable-kf5-qt5%20FreeBSDQt5.10/display/redirect'
>>> STAGE_NAME = 'Configuring Build'
>>> BUILD_TAG = 'jenkins-Plasma plasma-vault stable-kf5-qt5 FreeBSDQt5.10-4'
>>> JOB_URL = 'https://build.kde.org/job/Plasma%20plasma-vault%20stable-kf
>>> 5-qt5%20FreeBSDQt5.10/'
>>> NODE_NAME = 'FreeBSD Builder 3'
>>> HOST = 'freebsd-node3'
>>> WORKSPACE = '/usr/home/jenkins/workspace/Plasma plasma-vault
>>> stable-kf5-qt5 FreeBSDQt5.10'
>>> XDG_CONFIG_DIRS = '/usr/home/jenkins/install-pre
>>> fix/etc/xdg:/usr/local/etc/xdg'
>>> GROUP = 'jenkins'
>>> BUILD_NUMBER = '4'
>>> HUDSON_URL = 'https://build.kde.org/'
>>> XDG_CURRENT_DESKTOP = 'KDE'
>>> EXECUTOR_NUMBER = '0'
>>> HOSTTYPE = 'FreeBSD'
>>> USER = 'jenkins'
>>> QML2_IMPORT_PATH = '/usr/home/jenkins/install-prefix/lib/qml'
>>> VENDOR = 'amd'
>>> MAIL = '/var/mail/jenkins'
>>> EDITOR = 'vi'
>>> SHELL = '/bin/tcsh'
>>> JENKINS_URL = 'https://build.kde.org/'
>>> XDG_DATA_DIRS = '/usr/home/jenkins/install-pre
>>> fix/share:/usr/share:/usr/local/share'
>>> ASAN_OPTIONS = 'detect_leaks=0:new_delete_typ
>>> e_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:
>>> alloc_dealloc_mismatch=0:symbolize=1'
>>> LOGNAME = 'jenkins'
>>> HUDSON_HOME = '/home/production/data'
>>> == Commencing Configuration:
>>> cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address'
>>> -DBUILD_TESTING=ON 
>>> -DCMAKE_INSTALL_PREFIX="/usr/home/jenkins//install-prefix/"
>>> "/usr/home/jenkins/workspace/Plasma plasma-vault stable-kf5-qt5
>>> FreeBSDQt5.10"
>>> -- The C compiler identification is Clang 4.0.0
>>> -- The CXX compiler identification is Clang 4.0.0
>>> -- Check for working C compiler: /usr/bin/cc
>>> -- Check for working C compiler: /usr/bin/cc -- works
>>> -- Detecting C compiler ABI info
>>> -- Detecting C compiler ABI info - done
>>> -- Detecting C compile features
>>> -- Detecting C compile features - done
>>> -- Check for working CXX compiler: /usr/bin/c++
>>> -- Check for working CXX compiler: /usr/bin/c++ -- works
>>> -- Detecting CXX compiler ABI info
>>> -- Detecting CXX compiler ABI info - done
>>> -- Detecting CXX compile features
>>> -- Detecting CXX compile features - done
>>> --
>>> -- Could not set up the appstream test. appstreamcli is missing.
>>> -- Looking for __GLIBC__
>>> -- Looking for __GLIBC__ - not found
>>> -- Performing Test _OFFT_IS_64BIT
>>> -- Performing Test _OFFT_IS_64BIT - Success
>>> -- Performing Test HAVE_DATE_TIME
>>> -- Performing Test HAVE_DATE_TIME - Success
>>> -- Found KF5Activities: /usr/home/jenkins/install-pref
>>> ix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version
>>> "5.47.0")
>>> -- Found KF5Config: /usr/home/jenkins/install-pref
>>> ix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.47.0")
>>> -- Found KF5ConfigWidgets: /usr/home/jenkins/install-pref
>>> ix/lib/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found
>>> version "5.47.0")
>>> -- Found 

D13085: [RadioButton] Rename "control" to "controlRoot"

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:9e864e8059c1: [RadioButton] Rename control to 
controlRoot (authored by broulik).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13085?vs=34785=34793

REVISION DETAIL
  https://phabricator.kde.org/D13085

AFFECTED FILES
  org.kde.desktop/RadioButton.qml

To: broulik, #plasma, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13086: Don't set explicit spacing on RadioButton/CheckBox

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:05d7f273eb94: Dont set explicit spacing on 
RadioButton/CheckBox (authored by broulik).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13086?vs=34786=34792

REVISION DETAIL
  https://phabricator.kde.org/D13086

AFFECTED FILES
  org.kde.desktop/CheckBox.qml
  org.kde.desktop/RadioButton.qml

To: broulik, #plasma, #vdg, mart, fvogt, fabianr
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13087: [FocusRect] Use manual placement instead of anchors

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:ec06b3bc2f98: [FocusRect] Use manual placement instead of 
anchors (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D13087?vs=34787=34791#toc

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13087?vs=34787=34791

REVISION DETAIL
  https://phabricator.kde.org/D13087

AFFECTED FILES
  org.kde.desktop/private/FocusRect.qml

To: broulik, #plasma, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13087: [FocusRect] Use manual placement instead of anchors

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  I thought I was smart by using `anchors` that get auto-mirroring but 
`leftPadding` of the `control` already took that into account leading to double 
mirroring undoing the effect.

TEST PLAN
  Ran in `qmlscene -reverse` and focus rect is properly aligned in Breeze and 
Windows style. Left-to-right is still correct

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D13087

AFFECTED FILES
  org.kde.desktop/private/FocusRect.qml

To: broulik, #plasma, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13086: Don't set explicit spacing on RadioButton/CheckBox

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG, mart, fvogt.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The appropriate spacing is already determined by the indicator's width

TEST PLAN
  Left and right spacing is consistent now when used in e.g. a `FormLayout`
  Also looks ok in Oxygen and Fusion
  F5866258: Screenshot_20180524_104358.png 


REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D13086

AFFECTED FILES
  org.kde.desktop/CheckBox.qml
  org.kde.desktop/RadioButton.qml

To: broulik, #plasma, #vdg, mart, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13085: [RadioButton] Rename "control" to "controlRoot"

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This makes it consistent with `CheckBox` and also fixes the focus indicator.
  Also make the rest of the code identical to `CheckBox`

TEST PLAN
  - Compared the two files, were identical now except for the indicator 
component name and the onTriggered action
  - Focus indicator on RadioButton works again
  - Text color was still correct

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D13085

AFFECTED FILES
  org.kde.desktop/RadioButton.qml

To: broulik, #plasma, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D6313: Support Icon Scale from Icon naming specification 0.13

[Kai Uwe Broulik]

broulik updated this revision to Diff 34781.
broulik added a comment.


  …

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6313?vs=34780=34781

REVISION DETAIL
  https://phabricator.kde.org/D6313

AFFECTED FILES
  src/kiconengine.cpp
  src/kiconengine.h
  src/kiconloader.cpp
  src/kiconloader.h
  src/kicontheme.cpp
  src/kicontheme.h

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, ragreen, Pitel, michaelh, ZrenBot, bruns, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D6313: Support Icon Scale from Icon naming specification 0.13

[Kai Uwe Broulik]

broulik updated this revision to Diff 34780.
broulik added a comment.


  - Remove accidental cruft

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6313?vs=34779=34780

REVISION DETAIL
  https://phabricator.kde.org/D6313

AFFECTED FILES
  src/kiconengine.cpp
  src/kiconengine.h
  src/kiconloader.cpp
  src/kiconloader.h
  src/kicontheme.cpp
  src/kicontheme.h

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, ragreen, Pitel, michaelh, ZrenBot, bruns, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D6313: Support Icon Scale from Icon naming specification 0.13

[Kai Uwe Broulik]

broulik updated this revision to Diff 34779.
broulik added a comment.


  - Rename to `loadIcon` with `scale` to `loadScaledIcon` to avoid ambiguous 
overload

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6313?vs=31197=34779

REVISION DETAIL
  https://phabricator.kde.org/D6313

AFFECTED FILES
  src/kiconengine.cpp
  src/kiconengine.h
  src/kiconloader.cpp
  src/kiconloader.h
  src/kicontheme.cpp
  src/kicontheme.h

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, ragreen, Pitel, michaelh, ZrenBot, bruns, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  One last word about the necessity of this arrow. To me the arrow is mandatory 
as soon as it refers to an action that is different than the one of the icon. 
(either long press, or extra menu beside the icon main action). Still to me, 
opening a menu when pressing the icon is a single action, so you should not 
need two controls. This is as much a single action as when pressing an icon 
opens a dialog, (like in save as), or a confirmation dialog (like "do you 
really want to discard changes to the document), and for which we have no 
visual indication either that it will be different from say, sending the email.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D13064

To: hpereiradacosta, ngraham, abetts
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13064: reimplemented drop-down menu arrow in toolbuttons in case of instant inline popup

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D13064#267463 , @ngraham wrote:
  
  > Got the chance to test this out.  Functionally, it works great, and 
resolves the issue!
  >
  > Visually, I can understand you guys's hesitation about bringing the arrows 
back, because they do seem to lack that //je-ne-sais-quoi//, somehow. I wonder 
if the arrow might look nicer if it was vertically centered, instead of 
appearing towards the bottom of the button. The downward-pointing arrow is 
centered in other Breeze contexts (comboboxes and drop-down menu buttons, for 
example).
  >
  > Perhaps we could experiment with different arrow appearances so that they 
feel more natural? I feel like these arrows can work great in other non-Breeze 
contexts. Thunderbird, for example:
  >
  > F5865940: Screenshot_20180523_212216.png 

  
  
  Vertically centered arrows we also already use, and they correspond to 
buttons for which the button itself and the arrow are two different actions. 
  See: F5866110: Screenshot_20180524_075343.png 

  (from oxygen-demo 5)
  
  The use of an off centered, slightly smaller arrow located closer to the icon 
is to convey the information that it is not a different action, but "the same". 
  Other themes (most Qt themes in fact) use the same convention.
  I do not think changing the arrow style will improve the situation much, and 
on the contrary might introduce inconsistency in the style with respect to 
other arrows. If this path is to be followed, it must be part of a more 
conscious revisiting of the breeze widget style, and not an isolated change.
  
  Finally, one should also check how this looks when enabling text beside, or 
below the icons (two options that we support). Trying so you will see that this 
is looking even worse. This is true for breeze, but also for all the other Qt 
styles around that I could check.
  
  This is what I meant in the bug report when saying that the main reason why I 
disabled the arrow was a lack of good design for it.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D13064

To: hpereiradacosta, ngraham, abetts
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13068: Filter out incognito tabs and media controls on Firefox

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:8ddc5bc6f920: Filter out incognito tabs and media 
controls on Firefox (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13068?vs=34726=34776

REVISION DETAIL
  https://phabricator.kde.org/D13068

AFFECTED FILES
  extension/extension.js

To: broulik, #plasma, fvogt, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

[kio-extras] [Bug 369520] FISH: directories are mistaken for files and vice-versa

[sebaro]

https://bugs.kde.org/show_bug.cgi?id=369520

--- Comment #3 from sebaro  ---
Yes, in "Details" view I can also expend the directory content.

I have this issue in any server I tried, VPS/DigitalOcean or dedicated/OVH,
many versions of Ubuntu and CentOS. Didn't try LAN.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D13042: Do not show activity switcher during fast switches

[Thomas Surrel]

thsurrel updated this revision to Diff 34774.
thsurrel added a comment.


  Update the timing to match what is used in KWin and Alt-Tab

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13042?vs=34655=34774

REVISION DETAIL
  https://phabricator.kde.org/D13042

AFFECTED FILES
  imports/activitymanager/switcherbackend.cpp

To: thsurrel, #plasma, ivan
Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart