[Powerdevil] [Bug 345618] Powerdevil crash from idle desktop.

2018-06-16 Thread Rainer Finke
https://bugs.kde.org/show_bug.cgi?id=345618

Rainer Finke  changed:

   What|Removed |Added

 CC||m...@rainer-finke.de

--- Comment #15 from Rainer Finke  ---
Once my system returns from stand-by on Plasma-Wayland, powerdevil does always
crash.

Application: org_kde_powerdevil (org_kde_powerdevil), signal: Segmentation
fault
Using host libthread_db library "/usr/lib/libthread_db.so.1".
[Current thread is 1 (Thread 0x7fa6b0c19840 (LWP 2099))]

Thread 6 (Thread 0x7fa69550e700 (LWP 2300)):
#0  0x7fa6add72934 in read () at /usr/lib/libc.so.6
#1  0x7fa6a8458ed1 in  () at /usr/lib/libglib-2.0.so.0
#2  0x7fa6a8412ff8 in g_main_context_check () at /usr/lib/libglib-2.0.so.0
#3  0x7fa6a84134c6 in  () at /usr/lib/libglib-2.0.so.0
#4  0x7fa6a841363e in g_main_context_iteration () at
/usr/lib/libglib-2.0.so.0
#5  0x7fa6ae692e64 in
QEventDispatcherGlib::processEvents(QFlags) ()
at /usr/lib/libQt5Core.so.5
#6  0x7fa6ae63e85c in
QEventLoop::exec(QFlags) () at
/usr/lib/libQt5Core.so.5
#7  0x7fa6ae487ac9 in QThread::exec() () at /usr/lib/libQt5Core.so.5
#8  0x7fa6ae491b95 in  () at /usr/lib/libQt5Core.so.5
#9  0x7fa6aa9de075 in start_thread () at /usr/lib/libpthread.so.0
#10 0x7fa6add8153f in clone () at /usr/lib/libc.so.6

Thread 5 (Thread 0x7fa695d0f700 (LWP 2298)):
#0  0x7fa6a8458ecb in  () at /usr/lib/libglib-2.0.so.0
#1  0x7fa6a8412ff8 in g_main_context_check () at /usr/lib/libglib-2.0.so.0
#2  0x7fa6a84134c6 in  () at /usr/lib/libglib-2.0.so.0
#3  0x7fa6a841363e in g_main_context_iteration () at
/usr/lib/libglib-2.0.so.0
#4  0x7fa6ae692e64 in
QEventDispatcherGlib::processEvents(QFlags) ()
at /usr/lib/libQt5Core.so.5
#5  0x7fa6ae63e85c in
QEventLoop::exec(QFlags) () at
/usr/lib/libQt5Core.so.5
#6  0x7fa6ae487ac9 in QThread::exec() () at /usr/lib/libQt5Core.so.5
#7  0x7fa6ae491b95 in  () at /usr/lib/libQt5Core.so.5
#8  0x7fa6aa9de075 in start_thread () at /usr/lib/libpthread.so.0
#9  0x7fa6add8153f in clone () at /usr/lib/libc.so.6

Thread 4 (Thread 0x7fa6977fe700 (LWP 2140)):
#0  0x7fa6add76ea9 in poll () at /usr/lib/libc.so.6
#1  0x7fa6a8413523 in  () at /usr/lib/libglib-2.0.so.0
#2  0x7fa6a84138e2 in g_main_loop_run () at /usr/lib/libglib-2.0.so.0
#3  0x7fa69c781348 in  () at /usr/lib/libgio-2.0.so.0
#4  0x7fa6a843ba2a in  () at /usr/lib/libglib-2.0.so.0
#5  0x7fa6aa9de075 in start_thread () at /usr/lib/libpthread.so.0
#6  0x7fa6add8153f in clone () at /usr/lib/libc.so.6

Thread 3 (Thread 0x7fa697fff700 (LWP 2138)):
#0  0x7fa6add76ea9 in poll () at /usr/lib/libc.so.6
#1  0x7fa6a8413523 in  () at /usr/lib/libglib-2.0.so.0
#2  0x7fa6a841363e in g_main_context_iteration () at
/usr/lib/libglib-2.0.so.0
#3  0x7fa6a8413692 in  () at /usr/lib/libglib-2.0.so.0
#4  0x7fa6a843ba2a in  () at /usr/lib/libglib-2.0.so.0
#5  0x7fa6aa9de075 in start_thread () at /usr/lib/libpthread.so.0
#6  0x7fa6add8153f in clone () at /usr/lib/libc.so.6

Thread 2 (Thread 0x7fa69dae5700 (LWP 2133)):
#0  0x7fa6a845a2d9 in g_mutex_lock () at /usr/lib/libglib-2.0.so.0
#1  0x7fa6a8412a55 in g_main_context_prepare () at
/usr/lib/libglib-2.0.so.0
#2  0x7fa6a841344e in  () at /usr/lib/libglib-2.0.so.0
#3  0x7fa6a841363e in g_main_context_iteration () at
/usr/lib/libglib-2.0.so.0
#4  0x7fa6ae692e64 in
QEventDispatcherGlib::processEvents(QFlags) ()
at /usr/lib/libQt5Core.so.5
#5  0x7fa6ae63e85c in
QEventLoop::exec(QFlags) () at
/usr/lib/libQt5Core.so.5
#6  0x7fa6ae487ac9 in QThread::exec() () at /usr/lib/libQt5Core.so.5
#7  0x7fa6aeae2976 in  () at /usr/lib/libQt5DBus.so.5
#8  0x7fa6ae491b95 in  () at /usr/lib/libQt5Core.so.5
#9  0x7fa6aa9de075 in start_thread () at /usr/lib/libpthread.so.0
#10 0x7fa6add8153f in clone () at /usr/lib/libc.so.6

Thread 1 (Thread 0x7fa6b0c19840 (LWP 2099)):
[KCrash Handler]
#6  0x7fa6ae4dbdbf in QHashData::nextNode(QHashData::Node*) () at
/usr/lib/libQt5Core.so.5
#7  0x7fa6b061330e in PowerDevil::Core::onResumingFromIdle() () at
/usr/lib/libpowerdevilcore.so.2
#8  0x7fa6b064d996 in  () at /usr/lib/libpowerdevilcore.so.2
#9  0x7fa6ae669a0c in QMetaObject::activate(QObject*, int, int, void**) ()
at /usr/lib/libQt5Core.so.5
#10 0x7fa6acb463bd in  () at /usr/lib/libKF5IdleTime.so.5
#11 0x7fa6ae669a0c in QMetaObject::activate(QObject*, int, int, void**) ()
at /usr/lib/libQt5Core.so.5
#12 0x7fa6ae669b60 in QMetaObject::activate(QObject*, int, int, void**) ()
at /usr/lib/libQt5Core.so.5
#13 0x7fa69e35a1c8 in ffi_call_unix64 () at /usr/lib/libffi.so.6
#14 0x7fa69e359c2a in ffi_call () at /usr/lib/libffi.so.6
#15 0x7fa69ebeff9f in  () at /usr/lib/libwayland-client.so.0
#16 0x7fa69ebec70a in  () at /usr/lib/libwayland-client.so.0
#17 0x7fa69ebedc5c in 

D13360: Touchpad KDED module: Convert to JSON metadata

2018-06-16 Thread David Edmundson
davidedmundson added a comment.


  I guess so.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13360

To: marten, #plasma, davidedmundson
Cc: romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D13360: Touchpad KDED module: Convert to JSON metadata

2018-06-16 Thread Roman Gilg
romangg added a comment.


  Should the patch be backported to 5.13 since it's a fix for the daemon 
according to the description?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13360

To: marten, #plasma, davidedmundson
Cc: romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D13573: Touchpad KCM QtQuickControls2 Conversion

2018-06-16 Thread David Edmundson
davidedmundson added inline comments.

INLINE COMMENTS

> main.qml:23
>  import QtQuick.Layouts 1.3 as Layouts
>  import QtQuick.Controls.Styles 1.4 as Styles
>  

this is either unused or wrong

> main.qml:37
> +
> +property size sizeHint: Qt.size(formLayout.width, formLayout.height)
> +property size minimumSizeHint: Qt.size(formLayout.width/2, 
> deviceSelector.height)

Saying the size hint is the size it currently is looks wrong

generally speaking:

width propagates from parent to child
 implicitWidth propagates from child to parent

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13573

To: furkantokac, romangg, ngraham, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D13573: Touchpad KCM QtQuickControls2 Conversion

2018-06-16 Thread Furkan Tokac
furkantokac created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
furkantokac requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13573

AFFECTED FILES
  kcms/touchpad/src/kcm/libinput/main.qml

To: furkantokac
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D13568: SinkModel: Ignore virtual sinks for preferredSink

2018-06-16 Thread David Rosca
drosca created this revision.
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
drosca requested review of this revision.

REVISION SUMMARY
  Preferred sink is used for volume control with media keys,
  so it should be controlling real hardware volume instead of
  virtual devices.
  
  BUG: 395466
  FIXED-IN: 5.13.1

TEST PLAN
  Builds

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  Plasma/5.13

REVISION DETAIL
  https://phabricator.kde.org/D13568

AFFECTED FILES
  src/device.cpp
  src/device.h
  src/pulseaudio.cpp

To: drosca, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart