D13772: Add AppStream metadata

[Pino Toscano]

pino requested changes to this revision.
pino added inline comments.

INLINE COMMENTS

> org.kde.ksysguard.appdata.xml:11
> +System Guard allows you to monitor information and statistics about 
> your system.
> +In addition to monitoring the local system, it can connect to remote 
> systems running the System Guard Daemon, which is in the 'ksysguardd' 
> package.
> +  

This is an implementation detail of (some) distributions, it makes no sense 
upstream, since it is all in this repository.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D13772

To: ngraham, #plasma, apol, mak, pino
Cc: pino, mak, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13772: Add AppStream metadata

[Matthias Klumpp]

mak requested changes to this revision.
mak added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> org.kde.ksysguard.appdata.xml:2
> +
> +
> +  KSysGuard

Nitpick: Use `desktop-application`

> org.kde.ksysguard.appdata.xml:7
> +  org.kde.ksysguard
> +  CC0-1.0
> +  GPL-2.0+

Maybe using `FSFAP` as license is better here, so the sources don't have to 
ship a copy of the CC0 license.

> org.kde.ksysguard.appdata.xml:18
> +
> +   type="source">https://www.kde.org/images/screenshots/ksysguard.png
> +   type="thumbnail">https://www.kde.org/images/screenshots/resized/ksysguard.png

Thumbnails are generally thrown away be the metadata extractor on the Linux 
distro side, so you can really drop the "type" property of the image tag here 
and just add the source image.

> org.kde.ksysguard.appdata.xml:28
> +  
> +

The component is missing a `launchable` tag: 
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-launchable
The categories and mimetypes lists can be dropped, as those will be 
automatically extracted from the desktop-file mentioned in the launchable tag 
(if they are not dropped, the metainfo file will *override* the desktop file 
contents, which is likely not the desired behavior here)

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D13772

To: ngraham, #plasma, apol, mak
Cc: mak, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13772: Add AppStream metadata

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, apol.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Add AppStream Metadata for KSysGuard, since it's currently lacking.

TEST PLAN
  Compile and install; the AppStream file is installed to 
`/usr/share/metainfo/`.

REPOSITORY
  R106 KSysguard

BRANCH
  appstream-metadata (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13772

AFFECTED FILES
  gui/CMakeLists.txt
  gui/org.kde.ksysguard.appdata.xml

To: ngraham, #plasma, apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13772: Add AppStream metadata

[Nathaniel Graham]

ngraham added a comment.


  Also, I'd appreciate it if someone could please check my choice of licenses; 
I'm not 100% sure that I chose the right ones.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D13772

To: ngraham, #plasma, apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13767: Touchpad KCM Pointer Speed Slider Improvement

[Furkan Tokac]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:86e674c6a2b9: Touchpad KCM Pointer Speed Slider 
Improvement (authored by furkantokac).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13767?vs=36801=36802

REVISION DETAIL
  https://phabricator.kde.org/D13767

AFFECTED FILES
  kcms/touchpad/src/kcm/libinput/main.qml

To: furkantokac, ngraham, romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13767: Touchpad KCM Pointer Speed Slider Improvement

[Furkan Tokac]

furkantokac updated this revision to Diff 36801.
furkantokac added a comment.


  Comment correction.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13767?vs=36783=36801

BRANCH
  arcpatch-D13767

REVISION DETAIL
  https://phabricator.kde.org/D13767

AFFECTED FILES
  kcms/touchpad/src/kcm/libinput/main.qml

To: furkantokac, ngraham, romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13694: Fix wrong availability of profiles and ports.

[Andreas Krutzler]

akrutzler added a comment.


  Good. :) I don't have commit rights yet so I think I can't do it there.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D13694

To: akrutzler, nicolasfella, broulik, drosca
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13767: Touchpad KCM Pointer Speed Slider Improvement

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> main.qml:248
>  if (touchpad != undefined && enabled && !root.loading) {
>  // transform slider range [1, 10] to libinput's pointer 
> acceleration range [-1, 1]
> +// by *10 and /10, we ignore the floating points after 1 
> digit. This prevents from

range [1, 11]

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13767

To: furkantokac, ngraham, romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13770: Only show available ports in port selection

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: drosca.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Unavailable ports are marked as unavailable, but can be selected 
nevertheless, which does not make
  sense. This removes them from the combobox. If the availability is unknown 
they are left in because they 
  might be useful.

TEST PLAN
  Works on my card where always excactly one port is available. (Un-)plugging 
the headphone shows the 
  appropriate port in the Combobox (if I remove the 'visible: portbox.count > 
1' line).
  I can't produce a setup where two ports are available at the same time, so 
switching ports via combobox is 
  untested.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  portbox

REVISION DETAIL
  https://phabricator.kde.org/D13770

AFFECTED FILES
  src/kcm/package/contents/ui/DeviceListItem.qml

To: nicolasfella, drosca
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13591: Set complete vectors instead of creting them at runtime

[Nathaniel Graham]

ngraham added a reviewer: Plasma.
ngraham added a comment.


  Sadly Breeze lost its maintainer recently, so reviewing this is going to have 
to be a community effort. Adding more people.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D13591

To: tcanabrava, #breeze, #plasma
Cc: ngraham, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7155: Implement sorting of the device tree items

[Christoph Feck]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:7c0f85162ee9: Implement sorting of the device tree items 
(authored by isaact, committed by cfeck).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7155?vs=26293=36786

REVISION DETAIL
  https://phabricator.kde.org/D7155

AFFECTED FILES
  Modules/devinfo/devicelisting.cpp
  Modules/devinfo/soldevice.cpp
  Modules/devinfo/soldevice.h

To: isaact, #plasma, cfeck, broulik, davidedmundson
Cc: davidedmundson, cfeck, broulik, anthonyfieroni, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D13694: Fix wrong availability of profiles and ports.

[Nicolas Fella]

nicolasfella added a comment.


  I found the issue and this patch solves it. +1 from me, but @drosca should 
also approve since he is the maintainer.
  While you're at it, can you please make the same change for 
https://cgit.kde.org/pulseaudio-qt.git ? It suffers from the same issue.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D13694

To: akrutzler, nicolasfella, broulik, drosca
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13767: Touchpad KCM Pointer Speed Slider Improvement

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  FWIW, you can mark those comments as done.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13767

To: furkantokac, ngraham, romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13694: Fix wrong availability of profiles and ports.

[Nicolas Fella]

nicolasfella added a comment.


  It does not regress any more. I did not observe any issue with the previous 
code so I can't confirm it fixes things, but the change looks sensible to me.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D13694

To: akrutzler, nicolasfella, broulik, drosca
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13767: Touchpad KCM Pointer Speed Slider Improvement

[Furkan Tokac]

furkantokac updated this revision to Diff 36783.
furkantokac added a comment.


  "value" part of last "Slider" patch is reverted since that kind of changes 
will be handled with another patch.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13767?vs=36782=36783

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13767

AFFECTED FILES
  kcms/touchpad/src/kcm/libinput/main.qml

To: furkantokac, ngraham, romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13767: Touchpad KCM Pointer Speed Slider Improvement

[Furkan Tokac]

furkantokac added inline comments.

INLINE COMMENTS

> ngraham wrote in main.qml:239
> Let's do this in a separate commit where we change it along with the same 
> value in the Mouse KCM.

Sure it will be better. Thanks!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13767

To: furkantokac, ngraham, romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13767: Touchpad KCM Pointer Speed Slider Improvement

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Almost perfect, just one issue below:

INLINE COMMENTS

> main.qml:239
>  if (!enabled) {
> -value = 0.1
> +value = 0.0
>  return

Let's do this in a separate commit where we change it along with the same value 
in the Mouse KCM.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13767

To: furkantokac, ngraham, romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13767: Touchpad KCM Pointer Speed Slider Improvement

[Furkan Tokac]

furkantokac created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
furkantokac requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13767

AFFECTED FILES
  kcms/touchpad/src/kcm/libinput/main.qml

To: furkantokac
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13745: Implement support for virtual desktops on Wayland

[Eike Hein]

hein added a comment.


  FWIW: I want to continue with this for now because under the current usage 
it's still better for performance and lower risk, but longer-term I might 
refactor VirtualDesktopInfo and ActivityInfo into 
{AbstractWorkspaceModel,VirtualDesktopModel,ActivityModel} and replace 
PagerModel directly. It would make for a more consistent lib API and simplify 
applet code.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13745

To: hein, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13752: Kill solidautoeject

[Anthony Fieroni]

anthonyfieroni added a comment.


  I have looking on https://bugs.kde.org/show_bug.cgi?id=394348 that's using 
same interface when ISO is mounting?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13752

To: broulik, #plasma, #frameworks, adridg, davidedmundson, dfaure, fvogt, ervin
Cc: anthonyfieroni, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D13760: [Media Frame] Fix history length property

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> davidedmundson wrote in mediaframe.cpp:336
> This could have just been an else of the branch above

And then one day someone adds a check for contains() before prepend(), for 
instance, and you would need to come back to this structure of the code. So 
this is more flexible.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D13760

To: broulik, #plasma, dfaure, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13760: [Media Frame] Fix history length property

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:c9908d08a281: [Media Frame] Fix history length property 
(authored by broulik).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13760?vs=36767=36768

REVISION DETAIL
  https://phabricator.kde.org/D13760

AFFECTED FILES
  applets/mediaframe/package/contents/ui/main.qml
  applets/mediaframe/plugin/mediaframe.cpp
  applets/mediaframe/plugin/mediaframe.h

To: broulik, #plasma, dfaure, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13760: [Media Frame] Fix history length property

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added inline comments.

INLINE COMMENTS

> mediaframe.cpp:336
> +
> +if (oldCount != m_history.count()) {
> +emit historyLengthChanged();

This could have just been an else of the branch above

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D13760

To: broulik, #plasma, dfaure, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13760: [Media Frame] Fix history length property

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Makes sense, binding needs to be updated when the value changes.
  
  Thanks for the fix!

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D13760

To: broulik, #plasma, dfaure
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13760: [Media Frame] Fix history length property

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, dfaure.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  An invokable cannot be notified.
  
  CCMAIL: dev.lar...@gmail.com

TEST PLAN
  Back button is enabled and disabled correctly again

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D13760

AFFECTED FILES
  applets/mediaframe/package/contents/ui/main.qml
  applets/mediaframe/plugin/mediaframe.cpp
  applets/mediaframe/plugin/mediaframe.h

To: broulik, #plasma, dfaure
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Plasma 5.12.6 LTS

[Jonathan Riddell]

Plasma 5.12.6 LTS sources are available for packaging with many fixes
to Discover and Plasma Desktop

https://www.kde.org/announcements/plasma-5.12.6.php

D5579: Introduce QQuickItem to nest kwin_wayland

[David Edmundson]

davidedmundson commandeered this revision.
davidedmundson added a reviewer: bdhruve.
davidedmundson added a comment.


  FWIW, this code now lives on in some code I'm writing (with EGL support as 
well as SHM).
  
  I don't think this is the right place. Kwin isn't going to be the one using 
it, and it's not kwin specific - so it would be weird to depend on kwin in an 
external project.
  
  So I'm going to close this. Hope that's ok.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5579

To: davidedmundson, #plasma_on_wayland, #kwin, bdhruve
Cc: davidedmundson, graesslin, plasma-devel, kwin, ragreen, jackyalcine, Pitel, 
schernikov, iodelay, bwowk, ZrenBot, alexeymin, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

KDE CI: Plasma powerdevil stable-kf5-qt5 SUSEQt5.10 - Build # 17 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma%20powerdevil%20stable-kf5-qt5%20SUSEQt5.10/17/
 Project:
Plasma powerdevil stable-kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 27 Jun 2018 11:22:25 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/8)0%
(0/65)0%
(0/65)0%
(0/3866)0%
(0/2636)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdaemon0%
(0/17)0%
(0/17)0%
(0/1345)0%
(0/1044)daemon.actions.bundled0%
(0/18)0%
(0/18)0%
(0/788)0%
(0/468)daemon.actions.dpms0%
(0/9)0%
(0/9)0%
(0/212)0%
(0/110)daemon.backends.upower0%
(0/13)0%
(0/13)0%
(0/983)0%
(0/739)kcmodule.activities0%
(0/2)0%
(0/2)0%
(0/195)0%
(0/123)kcmodule.common0%
(0/3)0%
(0/3)0%
(0/156)0%
(0/78)kcmodule.global0%
(0/1)0%
(0/1)0%
(0/79)0%
(0/28)kcmodule.profiles0%
(0/2)0%
(0/2)0%
(0/108)0%
(0/46)

KDE CI: Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10 - Build # 11 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20SUSEQt5.10/11/
 Project:
Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 27 Jun 2018 11:22:28 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.filetypestest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report20%
(2/10)16%
(4/25)16%
(4/25)19%
(493/2547)14%
(207/1433)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskbroadcastnotification0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/22)kcmshell0%
(0/2)0%
(0/2)0%
(0/158)0%
(0/82)kdesu0%
(0/2)0%
(0/2)0%
(0/276)0%
(0/190)keditfiletype23%
(3/13)23%
(3/13)23%
(285/1248)20%
(131/648)keditfiletype.tests100%
(1/1)100%
(1/1)81%
(208/257)41%
(76/186)kioclient0%
(0/1)0%
(0/1)0%
(0/221)0%
(0/98)kmimetypefinder0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/10)kstart0%
(0/2)0%
(0/2)0%
(0/220)0%
(0/162)ksvgtopng0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/4)ktraderclient0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/31)

KDE CI: Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.10 - Build # 9 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20FreeBSDQt5.10/9/
 Project:
Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.10
 Date of build:
Wed, 27 Jun 2018 11:22:24 +
 Build duration:
3 min 27 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.filetypestest

KDE CI: Plasma systemsettings stable-kf5-qt5 SUSEQt5.10 - Build # 21 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma%20systemsettings%20stable-kf5-qt5%20SUSEQt5.10/21/
 Project:
Plasma systemsettings stable-kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 27 Jun 2018 11:22:16 +
 Build duration:
2 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/7)0%
(0/23)0%
(0/23)0%
(0/1820)0%
(0/686)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapp0%
(0/3)0%
(0/3)0%
(0/271)0%
(0/124)app.ToolTips0%
(0/1)0%
(0/1)0%
(0/92)0%
(0/18)classic0%
(0/2)0%
(0/2)0%
(0/190)0%
(0/52)core0%
(0/9)0%
(0/9)0%
(0/503)0%
(0/232)icons0%
(0/3)0%
(0/3)0%
(0/271)0%
(0/52)sidebar0%
(0/4)0%
(0/4)0%
(0/400)0%
(0/186)sidebar.ToolTips0%
(0/1)0%
(0/1)0%
(0/93)0%
(0/22)

D13752: Kill solidautoeject

[Kai Uwe Broulik]

broulik added a comment.


  > It's not clear to me what this revision is trying to change (in terms of 
user-visible behavior) or how to test the change
  
  I think you could test it by disabling the "Drive Ejector" module in 
"Background Services" (kded settings) in System Settings. If pressing the 
button still ejects the CD as before, then this patch should be good on BSD / 
with HAL also.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13752

To: broulik, #plasma, #frameworks, adridg, davidedmundson, dfaure, fvogt, ervin
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D13752: Kill solidautoeject

[Adriaan de Groot]

adridg added a comment.


  It's not clear to me what this revision is trying to change (in terms of 
user-visible behavior) or how to test the change; what I've written above is 
current behavior on FreeBSD 11 with Plasma 5.12.5; HAL is running.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13752

To: broulik, #plasma, #frameworks, adridg, davidedmundson, dfaure, fvogt, ervin
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D13752: Kill solidautoeject

[Adriaan de Groot]

adridg added a comment.


  Since the ticket is rather unclear on what functionality is being tested, or 
how:
  
  - Put a CD with an ISO9660 filesystem in the drive (I used one with Debian 
from 1995 on it)
  - When device notifier pops up, pick "open with filemanager" (`*`)
  - Ensure the silesystem isn't actually busy (e.g. no shells cd'd into that 
filesystem)
  - Press the physical eject button on the drive
  
  On FreeBSD, the filesystem is unmounted and the CD is ejected. (And the 
directory  in /media where the drive was mounted is removed `**`).
  
  Notes:
  
  - `* `I get a "Error -- ... Client" popup with "Malformed URL" message, and 
an OK button.  No idea what is causing that or where it's from -- but I don't 
get a file manager either.
  - `**` This only works if the filesystem is mounted through the device 
notifier. Mounting it by hand (somewhere else) neither unmounts, nor ejects, 
nor removes the mount point (the last bit is good, since you must have  made 
that mount point by hand, too)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13752

To: broulik, #plasma, #frameworks, adridg, davidedmundson, dfaure, fvogt, ervin
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D13679: Fix recent toolbar layout regression

[Marco Martin]

mart added a comment.


  In D13679#283361 , @ngraham wrote:
  
  > Aleix implemented a better version of this with 
https://cgit.kde.org/discover.git/commit/?id=d5f7c102854c41e4ee9eb00cfb979993f2396233
  
  
  I'm still not sure about it.
  is it supposed to switch to breadcrumb when the window is narrow? (and 
buttons as fab on the bottom) in kirigami desktop apps are supposed to always 
have the top toolbar, even when they are narrow, that's why it gets navigation 
buttons, even when they are in tablet mode: bottom action buttons are purely 
for reachability in single hand mode on phones.
  
  Note that this has nothing to do with plasma mobile, there it would always be 
in breadcrumb+fab mode (you can test its behavior on desktop with export 
QT_QUICK_CONTROLS_MOBILE=1)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D13679

To: ngraham, #discover_software_store
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D13752: Kill solidautoeject

[Marco Martin]

mart added a comment.


  +1
  (maybe build conditionally on freebsd if it's *really* necessary there)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13752

To: broulik, #plasma, #frameworks, adridg, davidedmundson, dfaure, fvogt, ervin
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D13611: [Fonts KCM] disable "to" label when its companion controls are also disabled

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> main.qml:103
>  Layout.preferredWidth: formLayout.maxImplicitWidth
>  enabled: antiAliasingComboBox.currentIndex == 0
>  QtControls.SpinBox {

Also could have been done here, since `enabled` propagates recursively

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13611

To: ngraham, #vdg, davidedmundson
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13717: Implement Seek() and Seeked()

[Kai Uwe Broulik]

broulik added a comment.


  Thanks for your patch! There's a minor issue but other than that it's good.
  Can you also verify this doesn't cause a loop when using Plasma's media 
controller applet?

INLINE COMMENTS

> content-script.js:177
> +if (activePlayer) {
> +if (!activePlayer.seekable) {
> +console.warn("Got seek command, but player is not seekable");

The `seekable` property isn't an int but a `TimeRanges` object that tells you 
which portions of the player are seekable so this will never be `false`

[1] https://www.w3schools.com/tags/av_prop_seekable.asp

> mprisplugin.cpp:205
> +const qreal position = 
> data.value(QStringLiteral("currentTime")).toDouble() * 1000 * 1000;
> +Q_EMIT(((MPrisPlayer *) m_player)->Seeked((qlonglong) position));
> +setPosition(position);

Can't you just do `emit Seeked(position)`?

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D13717

To: mokhtari, broulik
Cc: nicolasfella, plasma-devel, #kde_connect, timothyc, jdvr, yannux, 
Danial0_0, johnq, ragreen, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, 
jeanv, ZrenBot, seebauer, bugzy, MayeulC, menasshock, lesliezhai, ali-mohamed, 
jensreuterberg, ach, abetts, sebas, apol, mart

D13752: Kill solidautoeject

[Fabian Vogt]

fvogt added a comment.


  Umount on eject press still works even without the kded module loaded.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13752

To: broulik, #plasma, #frameworks, adridg, davidedmundson, dfaure, fvogt, ervin
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13751: [Device Monitor] Create KFilePlacesModel on demand

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R97:688e04921094: [Device Monitor] Create KFilePlacesModel on 
demand (authored by broulik).

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13751?vs=36746=36748

REVISION DETAIL
  https://phabricator.kde.org/D13751

AFFECTED FILES
  src/kded/devicemonitor.cpp
  src/kded/devicemonitor.h

To: broulik, #plasma, drosca
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13752: Kill solidautoeject

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, Frameworks, adridg, davidedmundson, dfaure, 
fvogt, ervin.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Solid's UDisks backend never emits this signal. It is only present in HAL 
which is obsolete.

TEST PLAN
  FreeBSD supposedly still uses HAL, though?
  I don't have a CD drive..

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13752

AFFECTED FILES
  CMakeLists.txt
  solidautoeject/CMakeLists.txt
  solidautoeject/Messages.sh
  solidautoeject/solidautoeject.cpp
  solidautoeject/solidautoeject.desktop
  solidautoeject/solidautoeject.h

To: broulik, #plasma, #frameworks, adridg, davidedmundson, dfaure, fvogt, ervin
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13751: [Device Monitor] Create KFilePlacesModel on demand

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, drosca.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Doing so can be quite expensive as it queries devices and what not.
  This is particularly wasteful if the user doesn't have any Bluetooth devices 
or no browsable.

TEST PLAN
  No longer creates a model for me. Verified that pairing and unpairing 
browsable devices still properly updates places.

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D13751

AFFECTED FILES
  src/kded/devicemonitor.cpp
  src/kded/devicemonitor.h

To: broulik, #plasma, drosca
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart