D14268: Changed refresh time from 30 to 60 seconds

[Piotr Kąkol]

piotrkakol added a comment.


  Thanks, David.
  Yeah, even though I followed the instructions 

 you can see that the branch in this diff is "change-refresh-time (branched 
from master)" and it should be "change-refresh-time (branched from 
code-cleanup)".
  I'll remove this diff and try to make another one from the correct branch on 
Monday, with the line you requested.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D14268

To: piotrkakol
Cc: davidedmundson, plasma-devel, ngraham, gladhorn, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14268: Changed refresh time from 30 to 60 seconds

[David Edmundson]

davidedmundson added a comment.


  also try to commit just the change you're making not all of the other changes 
in the other commit

INLINE COMMENTS

> main.qml:51
>  engine: "time"
>  connectedSources: ["Local"]
> +interval: showSeconds ? 1000 : 6

please add

  intervalAlignment: plasmoid.configuration.showSeconds ? 
PlasmaCore.Types.NoAlignment : PlasmaCore.Types.AlignToMinute

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D14268

To: piotrkakol
Cc: davidedmundson, plasma-devel, ngraham, gladhorn, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14268: Changed refresh time from 30 to 60 seconds

[Piotr Kąkol]

piotrkakol created this revision.
Restricted Application added a project: Plasma.
piotrkakol requested review of this revision.

REPOSITORY
  R114 Plasma Addons

BRANCH
  change-refresh-time (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14268

AFFECTED FILES
  applets/binary-clock/package/contents/config/config.qml
  applets/binary-clock/package/contents/config/main.xml
  applets/binary-clock/package/contents/ui/BinaryClock.qml
  applets/binary-clock/package/contents/ui/Dot.qml
  applets/binary-clock/package/contents/ui/DotColumn.qml
  applets/binary-clock/package/contents/ui/configGeneral.qml
  applets/binary-clock/package/contents/ui/main.qml
  applets/binary-clock/package/metadata.desktop

To: piotrkakol
Cc: plasma-devel, ngraham, gladhorn, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14267: Cleaned code for binary clock applet and added comments

[Piotr Kąkol]

piotrkakol created this revision.
Restricted Application added a project: Plasma.
piotrkakol requested review of this revision.

REPOSITORY
  R114 Plasma Addons

BRANCH
  code-cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14267

AFFECTED FILES
  applets/binary-clock/package/contents/config/config.qml
  applets/binary-clock/package/contents/config/main.xml
  applets/binary-clock/package/contents/ui/BinaryClock.qml
  applets/binary-clock/package/contents/ui/Dot.qml
  applets/binary-clock/package/contents/ui/DotColumn.qml
  applets/binary-clock/package/contents/ui/configGeneral.qml
  applets/binary-clock/package/contents/ui/main.qml
  applets/binary-clock/package/metadata.desktop

To: piotrkakol
Cc: plasma-devel, ngraham, gladhorn, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14264: Disconnect decoration button requestHover tooltip on decoration destuction

[Martin Flöser]

graesslin added a comment.


  What's really strange is that requestShowTooltip comes from the event loop. 
But nothing in kdecoration or in KWin goes through a queued event to 
KWin::Decoration::DecoratedClientImpl::requestShowToolTip.
  
  Could it be a decoration plugin causing this?

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D14264

To: davidedmundson, #kwin
Cc: graesslin, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14264: Disconnect decoration button requestHover tooltip on decoration destuction

[Martin Flöser]

graesslin added a comment.


  The hovered state cannot change if there is no decoration. Hover is from an 
event handler from Decoration. I doubt that this change here can fix the crash. 
Also that's the explanation for the update slot not checking: no hover change 
if there's no decoration.
  
  The crash is weird: we did have a crash related to tooltips, but it's fixed.

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D14264

To: davidedmundson, #kwin
Cc: graesslin, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14264: Disconnect decoration button requestHover tooltip on decoration destuction

[David Edmundson]

davidedmundson planned changes to this revision.
davidedmundson added a comment.


  Not a stupid question. Will check

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D14264

To: davidedmundson, #kwin
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14050: Fwupd Backend For Review and Improvement

[Abhijeet sharma]

abhijeet2096 marked 7 inline comments as done.
abhijeet2096 added inline comments.

INLINE COMMENTS

> apol wrote in FwupdBackend.cpp:395
> Are you sure you need an event-loop there? Let's make this non-blocking.

Can you please guide me, on how can I make this non-blocking?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D14050

To: abhijeet2096, apol, davidedmundson
Cc: zzag, anthonyfieroni, plasma-devel, ragreen, ixoos, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14050: Fwupd Backend For Review and Improvement

[Abhijeet sharma]

abhijeet2096 updated this revision to Diff 38183.
abhijeet2096 added a comment.


  - Removed the derived FwupdUpdater
  - Using Standard Backend Updater
  - Now using the standard to name functions
  - Added Status on transactions [Not Tested]
  - Now Apps Cannot be executed/ Launched [Not tested]
  - Fixed Intendation and coding style at some places
  - Removed Ifdef in FwupdBackend.cpp
  - Removed FwupdNotifier
  
  I have still not changed the download function, need help how can I make it 
non-blocking.

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14050?vs=37778=38183

REVISION DETAIL
  https://phabricator.kde.org/D14050

AFFECTED FILES
  CMakeLists.txt
  cmake/FindGIO.cmake
  cmake/FindGLib.cmake
  cmake/FindGObject.cmake
  cmake/FindGObjectIntrospection.cmake
  cmake/FindLIBFWUPD.cmake
  cmake/FindSoup.cmake
  discover/qml/SourcesPage.qml
  libdiscover/backends/CMakeLists.txt
  libdiscover/backends/FwupdBackend/CMakeLists.txt
  libdiscover/backends/FwupdBackend/FwupdBackend.cpp
  libdiscover/backends/FwupdBackend/FwupdBackend.h
  libdiscover/backends/FwupdBackend/FwupdResource.cpp
  libdiscover/backends/FwupdBackend/FwupdResource.h
  libdiscover/backends/FwupdBackend/FwupdSourcesBackend.cpp
  libdiscover/backends/FwupdBackend/FwupdSourcesBackend.h
  libdiscover/backends/FwupdBackend/FwupdTransaction.cpp
  libdiscover/backends/FwupdBackend/FwupdTransaction.h
  libdiscover/backends/FwupdBackend/tests/CMakeLists.txt
  libdiscover/backends/FwupdBackend/tests/FwupdTest.cpp
  libdiscover/backends/FwupdBackend/tests/FwupdTest.h
  libdiscover/backends/FwupdBackend/tests/UpdateFwupdTest.cpp
  libdiscover/resources/AbstractSourcesBackend.h

To: abhijeet2096, apol, davidedmundson
Cc: zzag, anthonyfieroni, plasma-devel, ragreen, ixoos, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14264: Disconnect decoration button requestHover tooltip on decoration destuction

[Vlad Zagorodniy]

zzag added a comment.


  Probably stupid question, I'm just curious.. Why had only one receiver been 
changed to `decoration.data()`? Why that's not the case for
  
connect(this, ::hoveredChanged, this, updateSlot);
  
  ?
  
  Just for reference
  
void DecorationButton::update(const QRectF )
{
decoration()->update(rect.isNull() ? geometry().toRect() : 
rect.toRect());
}

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D14264

To: davidedmundson, #kwin
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14264: Disconnect decoration button requestHover tooltip on decoration destuction

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Decoration is destroyed at some point before DecorationButton, as seen
  by the existing use of QPointer for holding the Decoration.
  Use of a weak pointer without guarding seems wrong.
  
  Every other connect (DecorationButton::Private::init) that proxies to
  the decorationimplementation in kwin guards against this by setting the
  connect lifespan to match decoration. This one connect was out of sync.
  
  BUG: 396723
  CCBUG: 396729

TEST PLAN
  Ran kwin.
  Checked I still had tooltips
  Didn't try to reproduce the original crash

REPOSITORY
  R129 Window Decoration Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14264

AFFECTED FILES
  src/decorationbutton.cpp

To: davidedmundson, #kwin
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart