D14437: Fix QFileDialog not remembering the last visited directory.

[Anthony Fieroni]

anthonyfieroni added a comment.


  +1

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D14437

To: dfaure, anthonyfieroni, elvisangelaccio, plasma-devel, broulik, arichardson
Cc: apol, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D14437: Fix QFileDialog not remembering the last visited directory.

[David Faure]

dfaure added a comment.


  ping?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D14437

To: dfaure, anthonyfieroni, elvisangelaccio, plasma-devel, broulik, arichardson
Cc: apol, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D14440: File Dialog: fix testSelectUrl() again, i.e. selectUrl() should set the directory too

[David Faure]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R135:22da1e661afd: File Dialog: fix testSelectUrl() again, 
i.e. selectUrl() should set the… (authored by dfaure).
Herald added a project: Plasma.

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14440?vs=38681=40018

REVISION DETAIL
  https://phabricator.kde.org/D14440

AFFECTED FILES
  src/platformtheme/kdeplatformfiledialoghelper.cpp
  src/platformtheme/kdeplatformfiledialoghelper.h

To: dfaure, arichardson, anthonyfieroni, elvisangelaccio, plasma-devel, broulik
Cc: ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D14440: File Dialog: fix testSelectUrl() again, i.e. selectUrl() should set the directory too

[David Faure]

dfaure added a comment.


  I'll assume +1 and +1 = +2, and push...

REVISION DETAIL
  https://phabricator.kde.org/D14440

To: dfaure, arichardson, anthonyfieroni, elvisangelaccio, plasma-devel, broulik

D14869: [RFC] Increase default font sizes by 1 pt

[Filip Fila]

filipf added a comment.


  In D14869#311447 , @oysteins wrote:
  
  > In D14869#309949 , @rkflx wrote:
  >
  > > F6198464: kubuntu10-kubunbtu11-win10-macos.png 

  >
  >
  > I feel that Windows' font rendering produces significantly sharper fonts 
than anything else. FWIW I think it's both their choice of font (Segoe UI) and 
their ClearType technology that makes text in Windows easy to read even at 9pt. 
Increasing Noto Sans' size doesn't make it sharper in my eyes; perhaps AA and 
general font rendering is worth looking at.
  
  
  Possibly. But I bet what is more likely is that they set those values back 
when we didnt have FHD and touch screens and just stuck with it. That's 
Windows, they don't do as much revamping as much as they just add stuff on top 
of what already exists.
  
  But font rendering in Windows is also a mess. ClearType is an old technology 
from a different time and has been deprecated in favor of Greyscale (which is, 
funny enough, worse than ClearType because it's fuzzier). It was seen as an 
enhacement when it was implemented moreso because what they had before was 
awful and because screens were bad rather it being a great way to render fonts. 
Nowadays there may even be a 3rd type of rendering in Windows IIRC; they all 
co-exist in the same environment. But what's common to all of them is that they 
crudely alter fonts to artificially fit a pixel grid. In practice this usually 
means they thin them out and distort their proportions, making them either 
taller/shorter or wider/narrower than intended. Fonts also look jagged thanks 
to this. More real life consequences of distorting the typeface is that it 
ruins the vision the (non-Microsoft) font creator had for its font, that what 
is on the screen does not match printed material, that websites and PDFs may 
not look as you envisioned them etc. This is partly one of the reasons why 
design people prefer Macs and once you develop an eye for what fonts actually 
look like, you may also tend to see hinting as making fonts uglier. For 
instance, you can have a look at how Phabricator's Lato font looks like on your 
phone (provided the screen resolution isn't too shoddy) and then compare it 
with what hinting does to the font on the computer screen. On your phone it 
looks like it's supposed to.
  
  However, probably owing to most of Linux users being Windows users initially, 
from what I've seen the larger part of Linux community wants Freetype to be 
similar to Cleartype. This is not just unfortunate for the reasons mentioned 
above, but also because Freetype is already a great font renderer. I could 
provide plenty visual corroboration regarding this issue, but since this is not 
the topic here per se I just wanted to point out that there is a different 
approach than wanting "sharp" looking text. We could be going after fonts 
looking "crisp" instead, all the while remaining true to the typeface.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14869

To: ngraham, #plasma, #kde_applications, valorie, #vdg
Cc: oysteins, rooty, filipf, safaalfulaij, rikmills, harmathy, rkflx, abetts, 
davidedmundson, rizzitello, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D14933: Implemented Version checker for fwupd in FindLIBFWUPD.cmake

[Aleix Pol Gonzalez]

apol added a comment.


  You can extract the version from pkgconfig. CMake has macros to interact with 
it, or just the executable `pkg-config --modversion fwupd` meanwhile.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D14933

To: abhijeet2096, apol, davidedmundson
Cc: plasma-devel, masilva, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14933: Implemented Version checker for fwupd in FindLIBFWUPD.cmake

[Abhijeet sharma]

abhijeet2096 created this revision.
abhijeet2096 added reviewers: apol, davidedmundson.
abhijeet2096 added a project: Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
abhijeet2096 requested review of this revision.

REVISION SUMMARY
  Implemented Version checker for fwupd in FindLIBFWUPD.cmake
  

* Implemented Version Checker in FindLIBFWUPD.cmake
* Reduced the Minimum Required version of Fwupd to 1.06 [Not Tested, bug 
reports says it builds successfully on 1.06]
  
  
  Related Bugs:
  

* https://bugs.kde.org/show_bug.cgi?id=397377
* https://bugs.kde.org/show_bug.cgi?id=397378

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D14933

AFFECTED FILES
  CMakeLists.txt
  cmake/FindLIBFWUPD.cmake

To: abhijeet2096, apol, davidedmundson
Cc: plasma-devel, masilva, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14869: [RFC] Increase default font sizes by 1 pt

[Øystein S . -Alværvik]

oysteins added a comment.


  In D14869#309949 , @rkflx wrote:
  
  > F6198464: kubuntu10-kubunbtu11-win10-macos.png 

  
  
  I feel that Windows' font rendering produces significantly sharper fonts than 
anything else. FWIW I think it's both their choice of font (Segoe UI) and their 
ClearType technology that makes text in Windows easy to read even at 9pt. 
Increasing Noto Sans' size doesn't make it sharper in my eyes; perhaps AA and 
general font rendering is worth looking at.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14869

To: ngraham, #plasma, #kde_applications, valorie, #vdg
Cc: oysteins, rooty, filipf, safaalfulaij, rikmills, harmathy, rkflx, abetts, 
davidedmundson, rizzitello, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D14924: Prevent paste in screen locker (alternative approach)

[David Edmundson]

davidedmundson added a comment.


  But the bug is klipper specific behaviour.
  In hindsight the mimetype doesn't actually matter, there's no text/plain so 
klipper wouldn't save anyway.
  
  The important part is that we have something non-empty, non-useful. That 
should work in all clipboard managers.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D14924

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14923: Supress paste in screen locker

[Henrik Fehlauer]

rkflx added a comment.


  In D14923#311279 , @davidedmundson 
wrote:
  
  > Added bug no.
  
  
  I don't think that worked. Try with `arc diff --edit` ;)

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D14923

To: davidedmundson, #plasma
Cc: rkflx, graesslin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14924: Prevent paste in screen locker (alternative approach)

[Martin Flöser]

graesslin added a comment.


  I like the other solution better as it doesn't depend on Klipper specific 
behavior.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D14924

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14923: Supress paste in screen locker

[Martin Flöser]

graesslin added a comment.


  I like this solution. As a matter of fact the default options of Klipper are 
also fine. Only if the not default prevent empty clipboard option is used this 
breaks.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D14923

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart