D14984: Explicitly request Qt 5.7's QtQuick to make use of Connections.enabled

[Michael Pyne]

mpyne created this revision.
mpyne added reviewers: Frameworks, Plasma, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
mpyne requested review of this revision.

REVISION SUMMARY
  I recently rebuilt my Qt, KF5, and Plasma 5 environments from scratch. I 
noticed that System Settings no longer started.
  
  It took me a while to figure out the error message but the proximate issue 
ended up being:
  

file:///home/kde-svn/kde-5/lib64/qml/org/kde/kirigami.2/templates/private/ScrollView.qml:95:9:
 
"Connections.enabled" is not available in QtQuick 2.5. 
 enabled: !Settings.tabletMode 
 ^
  
  I imagine that Qt 5 has stricter checking on the use of QML properties. In 
this case we ask for QtQuick as of Qt 5.5, but Connections.enabled is only 
supported in Qt 5.7 on.
  
  I fixed this (and one other such usage) by changing the import statement to 
ask for QtQuick 5.7. We already require at least Qt 5.7 anyways so this isn't a 
new dependency for current KF5.

TEST PLAN
  Installed the updated Kirigami, successfully launched System Settings. 
Additionally the Plasma desktop wallpaper started working again too, though 
that wasn't why I'd made this fix.
  
  I verified by manual inspection of all uses of the 'Connection' QML item that 
there were no other uses of the "enabled" property from Qt 5.7.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D14984

AFFECTED FILES
  src/controls/private/RefreshableScrollView.qml
  src/controls/templates/private/ScrollView.qml

To: mpyne, #frameworks, #plasma, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D14807: [AppStream Runner] Also search when there were errors during Pool::load

[Stefan Brüns]

bruns updated this revision to Diff 40160.
bruns edited the test plan for this revision.
bruns added a comment.


  Remove from patch stack, apply first

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14807?vs=39637=40160

REVISION DETAIL
  https://phabricator.kde.org/D14807

AFFECTED FILES
  runners/appstream/appstreamrunner.cpp

To: bruns, #plasma, apol
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D14923: Supress paste in screen locker

[Martin Flöser]

graesslin added a comment.


  In D14923#311845 , @davidedmundson 
wrote:
  
  > > . As a matter of fact the default options of Klipper are also fine. Only 
if the not default prevent empty clipboard option is used this breaks.
  >
  > Code says otherwise.
  >
  > klipper.kcfg:
  >  klipper.kcfg-  Prevent empty clipboard
  >  klipper.kcfg-  true
  
  
  wow, sorry. I was sure it's the default. Must have been my two years on 
Wayland without klipper ;-)

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D14923

To: davidedmundson, #plasma
Cc: rkflx, graesslin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14855: Add applet with screen layouts and presentation mode

[Anthony Fieroni]

anthonyfieroni added a comment.


  @broulik, i'm pretty sure that it has a review that enable accessing OSD by 
mouse, can you investigate and ship it. I'm not against this but accessing OSD 
by mouse is pretty good feature after all.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D14855

To: broulik, #plasma, #vdg, fischbach, harmathy
Cc: anthonyfieroni, ngraham, mart, gladhorn, abetts, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D14855: Add applet with screen layouts and presentation mode

[Kai Uwe Broulik]

broulik added a comment.


  Then please make a final layout image that I can change my work to, 
preferably not being *completely* different from what I have now … also, the 
headings are smaller than e.g. System Tray's "Status and Notifications" heading

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D14855

To: broulik, #plasma, #vdg, fischbach, harmathy
Cc: ngraham, mart, gladhorn, abetts, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D14976: customIconColoring Theme api

[Marco Martin]

mart created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  get rid of hascustomiconcoloring

REPOSITORY
  R169 Kirigami

BRANCH
  mart/customIconColoring

REVISION DETAIL
  https://phabricator.kde.org/D14976

AFFECTED FILES
  src/controls/BasicListItem.qml
  src/desktopicon.cpp
  src/libkirigami/platformtheme.h

To: mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

Re: Upcoming reorganisation of the CI system

[Ben Cooksley]

On Wed, Aug 22, 2018 at 2:36 AM Morten Volden  wrote:
>
> Hi Ben

Hi Morten,

>
> I don't know if this is on you radar or not, but here goes.
>
> I have noticed that quite a few of the KDevelop unittests are failing on the 
> Windows CI.
>
> Running the tests locally they work fine.
>
> If I look at the output of the failing tests it is similar to that pasted 
> below.
>
> Searching brought me to this page:
>
> https://stackoverflow.com/questions/43897167/does-qt-build-with-opengl-angle-fix-support-for-windows-clients-not-having-openg/43932575#43932575
>
> Which seem to suggest that (re) install DirectX End-User Runtimes (June 
> 2010).should fix the issues.
>
> Since people will be giving the servers some TLC in the near future I thought 
> it might be worth looking at.

I suspect in this instance the problem may be caused by the KVM QXL
drivers that we're reliant on to serve as the system graphics.
Any ideas as to whether this might be the case or not?

As part of the system setup we have to install the DirectX SDK for
some components so I would have expected that it took care of
installing all the necessary runtime components as well.

>
> Kind Regards
>
> Morten

Cheers,
Ben

>
>
> qt.qpa.input.tablet: Tablet support:  "None"
> qt.qpa.windows: QWindowsContext::setProcessDpiAwareness 2
> SetProcessDpiAwareness(2) failed: COM error 0x80070005 E_ACCESSDENIED 
> (Unknown error 0x080070005), using 2
> qt.qpa.windows: QWindowsIntegrationPrivate::QWindowsIntegrationPrivate 
> DpiAwareness= 2 effective process DPI awareness= 2
> qt.qpa.windows: QWindowsContext::registerWindowClass "Qt5ClipboardView" 
> style=0x0 brush=0x0 icon=false atom=49400
> qt.qpa.mime: QWindowsClipboard::registerViewer m_clipboardViewer: 0xede04e8 
> format listener: true next: 0x0
> qt.qpa.windows: New Monitor:  Screen "WinDisc" 1024x768+0+0 avail: 
> 1024x768+0+0 physical: -1x-1 DPI: 96x96 Depth: 32 Format: 6 hMonitor: 0x10001 
> primary virtual desktop lock screen
> qt.qpa.fonts: QWindowsFontDatabase::systemDefaultFont QFont( "MS Shell Dlg 
> 2,8.25,-1,5,50,0,0,0,0,0" )
> qt.qpa.windows: QWindowsTheme::refreshIconPixmapSizes (QSize(16, 16), 
> QSize(32, 32), QSize(48, 48), QSize(256, 256))
> qt.qpa.gl: QWindowsIntegration::createPlatformOpenGLContext 
> QSurfaceFormat(version 2.0, options QFlags(), 
> depthBufferSize -1, redBufferSize -1, greenBufferSize -1, blueBufferSize -1, 
> alphaBufferSize -1, stencilBufferSize -1, samples -1, swapBehavior 
> QSurfaceFormat::SwapBehavior(DefaultSwapBehavior), swapInterval 1, colorSpace 
> QSurfaceFormat::ColorSpace(DefaultColorSpace), profile  
> QSurfaceFormat::OpenGLContextProfile(NoProfile))
> qt.qpa.gl: Basic wglCreateContext gives version 1.1
> qt.qpa.gl: OpenGL version too low
> qt.qpa.gl: OpenGL 2.0 entry points not found
> qt.qpa.gl: GPU features: QSet("disable_d3d11", "disable_desktopgl", 
> "disable_d3d9")
> qt.qpa.gl: Disabling Desktop GL:  GpuDescription(vendorId=0x0, deviceId=0x0, 
> subSysId=0x0, revision=0, driver: "", version=, "")
> qt.qpa.gl: Disabling D3D11:  GpuDescription(vendorId=0x0, deviceId=0x0, 
> subSysId=0x0, revision=0, driver: "", version=, "")
> qt.qpa.gl: Disabling D3D9:  GpuDescription(vendorId=0x0, deviceId=0x0, 
> subSysId=0x0, revision=0, driver: "", version=, "")
> qt.qpa.gl: QWindowsOpenGLTester::supportedRenderers 
> GpuDescription(vendorId=0x0, deviceId=0x0, subSysId=0x0, revision=0, driver: 
> "", version=, "") renderer:  QFlags(0x8|0x20)
> qt.qpa.gl: Qt: Using EGL from libEGLd
> qt.qpa.gl: Qt: Using OpenGL ES 2.0 from libGLESv2d
> qt.qpa.gl: QWindowsEGLStaticContext::create Created EGL display 0x1e5631fcd80 
> v 1 . 4
>
>
>
>
> Den tir. 21. aug. 2018 kl. 17.27 skrev Ben Cooksley :
>>
>> Hi all,
>>
>> Final call for objections or queries for this change - i'll be looking
>> to roll this out this weekend.
>>
>> Note: Plasma and KDevelop, i'm not subscribed to your lists so please
>> ensure i'm in CC for any responses.
>>
>> Cheers,
>> Ben
>
>
>
> --
> Regards / Med venlig hilsen
>
> Morten Danielsen Volden
> Software Developer
> M.Sc. EE

D14933: Implemented Version checker for fwupd in FindLIBFWUPD.cmake

[Abhijeet sharma]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:10b790f43052: Implemented Version checker for fwupd in 
FindLIBFWUPD.cmake (authored by abhijeet2096).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14933?vs=40030=40155

REVISION DETAIL
  https://phabricator.kde.org/D14933

AFFECTED FILES
  CMakeLists.txt
  cmake/FindLIBFWUPD.cmake

To: abhijeet2096, apol, davidedmundson
Cc: plasma-devel, masilva, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Upcoming reorganisation of the CI system

[Ben Cooksley]

Hi all,

Final call for objections or queries for this change - i'll be looking
to roll this out this weekend.

Note: Plasma and KDevelop, i'm not subscribed to your lists so please
ensure i'm in CC for any responses.

Cheers,
Ben

D14855: Add applet with screen layouts and presentation mode

[Nathaniel Graham]

ngraham added a comment.


  Maybe, but right now it's being oppressed to death by huge headers! :)

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D14855

To: broulik, #plasma, #vdg, fischbach, harmathy
Cc: ngraham, mart, gladhorn, abetts, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D14949: Add option for whether to show the volume change OSD

[Nathaniel Graham]

ngraham added a comment.


  I think the current UI is just fine as the default; no need to change it. 
Simply making it smaller wouldn't really help the submitter's use case very 
much anyway since it would still show up and cover up //something//. However 
I'd be open to making the default appearance configurable, as a small but vocal 
cohort of people don't seem to like it.
  
  That's material for another patch though.

REVISION DETAIL
  https://phabricator.kde.org/D14949

To: anonym, #vdg
Cc: ngraham, romangg, mart, broulik, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D14949: Add option for whether to show the volume change OSD

[Roman Gilg]

romangg added a comment.


  Could we have a small bar at the top edge of the screen in case of fullscreen 
app and otherwise the current one?

REVISION DETAIL
  https://phabricator.kde.org/D14949

To: anonym, #vdg
Cc: romangg, mart, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D14949: Add option for whether to show the volume change OSD

[Kai Uwe Broulik]

broulik added a comment.


  > this begs more the question whether the osd layer should stay on top of 
fullscreen windows
  
  It used to not do that but people also complained (me included, I want it 
ontop of my video). Maybe we need a new, more compact design (like the bar we 
had in 4.x), or one in the top left rather than center like Windows 10 has 
these days.

REVISION DETAIL
  https://phabricator.kde.org/D14949

To: anonym, #vdg
Cc: mart, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D14970: [MPris Dataengine] Avoid blocking calls in media shortcuts handling

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  All the information we need (player capabilities and playback status) is 
already present and managed by the `PlayerContainer`
  
  BUG: 397685
  FIXED-IN: 5.13.5

TEST PLAN
  Started VLC, ran `killall -SIGSTOP vlc`, pressed "Pause" on my keyboard, 
plasma would no longer freeze
  Back, forward, pause keys still work fine

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14970

AFFECTED FILES
  dataengines/mpris2/multiplexedservice.cpp
  dataengines/mpris2/playercontrol.h

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14949: Add option for whether to show the volume change OSD

[Marco Martin]

mart added a comment.


  this begs more the question whether the osd layer should stay on top of 
fullscreen windows, rater than adding yet another configuration option

REVISION DETAIL
  https://phabricator.kde.org/D14949

To: anonym, #vdg
Cc: mart, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D14855: Add applet with screen layouts and presentation mode

[Kai Uwe Broulik]

broulik added a comment.


  The presentation mode doesn't really relate to the layouts that's why I put 
the headings in there. Just placing a checkbox there will make it drown 
underneath the layout buttons

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D14855

To: broulik, #plasma, #vdg, fischbach, harmathy
Cc: ngraham, mart, gladhorn, abetts, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol