D15209: RFC: Port scripting to Qt WebEngine

2018-09-01 Thread Fabian Vogt 
fvogt created this revision.
fvogt added a reviewer: Plasma.
Herald added a project: Plasma.
fvogt requested review of this revision.

REVISION SUMMARY
  Unfortunately it relies on Qt WebKit features quite intensely, so a few
  godawful hacks were necessary to make it work. Most of those are needed
  to workaround restrictions of QWebChannel as bridge to the browser page.
  
  We gain:
  + Independence from WebKit
  + Support for newer JS and HTML features in scripts
  
  We lose:
  
  - Performance (especially memory use)
  - Independence from WebEngine
  - Sanity

TEST PLAN
  Tested the detailed memory info pages on a few processes, info is
  correct and the page seems to work fully.

REPOSITORY
  R111 KSysguard Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15209

AFFECTED FILES
  CMakeLists.txt
  config-ksysguard.h.cmake
  processui/CMakeLists.txt
  processui/scripting.cpp
  processui/scripting.h

To: fvogt, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15206: [Kickoff] Add a subtle separator line between the header and the content view

2018-09-01 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This is another idea that shook out of D15011 
. In conjunction with D15194 
, Kickoff will have subtle lines separating 
the main content area from both the tab bar and the header, giving it some 
much-needed structure while still not overwhelming the user with lines and 
frames.

TEST PLAN
  Tested with Kickoff on a panel on all four different sides of the screen, and 
with Breeze light and Breeze dark themes.
  
  [image goes here]

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff-header-separator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15206

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: ngraham, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15202: Move kcheckrunning into startkde

2018-09-01 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  kcheckrunning is only used by startkde, it shouldn't be in the ksmserver
  folder.
  
  No code or behavioural changes, just tidying.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  dave2

REVISION DETAIL
  https://phabricator.kde.org/D15202

AFFECTED FILES
  ksmserver/CMakeLists.txt
  ksmserver/kcheckrunning.cpp
  startkde/CMakeLists.txt
  startkde/kcheckrunning/kcheckrunning.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15201: Move logout-greeter into it's own subdir out of ksmserver

2018-09-01 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  No code or behavioural changes, just code tidying.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15201

AFFECTED FILES
  CMakeLists.txt
  ksmserver/CMakeLists.txt
  ksmserver/logout-greeter/CMakeLists.txt
  ksmserver/logout-greeter/main.cpp
  ksmserver/logout-greeter/shutdowndlg.cpp
  ksmserver/logout-greeter/shutdowndlg.h
  ksmserver/logout-greeter/tests/CMakeLists.txt
  ksmserver/logout-greeter/tests/main.cpp
  logout-greeter/CMakeLists.txt
  logout-greeter/main.cpp
  logout-greeter/shutdowndlg.cpp
  logout-greeter/shutdowndlg.h
  logout-greeter/tests/CMakeLists.txt
  logout-greeter/tests/main.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15185: Fix kscreenlocker_greet --switchuser

2018-09-01 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:747135631bfe: Fix kscreenlocker_greet --switchuser 
(authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15185?vs=40765=40805

REVISION DETAIL
  https://phabricator.kde.org/D15185

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml

To: davidedmundson, #plasma, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15197: Clarify docs in startkde about shtudown

2018-09-01 Thread David Edmundson 
davidedmundson created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

TEST PLAN
  N/A

REPOSITORY
  R120 Plasma Workspace

BRANCH
  dave

REVISION DETAIL
  https://phabricator.kde.org/D15197

AFFECTED FILES
  startkde/startkde.cmake
  startkde/startplasma.cmake

To: davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15187: Merge switch user dialog into lockscreen

2018-09-01 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:084b9a408cda: Merge switch user dialog into lockscreen 
(authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15187?vs=40768=40806#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15187?vs=40768=40806

REVISION DETAIL
  https://phabricator.kde.org/D15187

AFFECTED FILES
  ksmserver/CMakeLists.txt
  ksmserver/server.cpp
  ksmserver/switchuser-greeter/CMakeLists.txt
  ksmserver/switchuser-greeter/main.cpp
  lookandfeel/contents/userswitcher/UserSwitcher.qml

To: davidedmundson, #plasma, mart
Cc: ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D15186: Install our org.kde.screensaver interface definition

2018-09-01 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R133:a1960594cba7: Install our org.kde.screensaver interface 
definition (authored by davidedmundson).

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15186?vs=40767=40800

REVISION DETAIL
  https://phabricator.kde.org/D15186

AFFECTED FILES
  CMakeLists.txt

To: davidedmundson, #plasma, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15187: Merge switch user dialog into lockscreen

2018-09-01 Thread David Edmundson 
davidedmundson added inline comments.

INLINE COMMENTS

> mart wrote in server.cpp:1095
> should we need some confirmation from the screenlocker that the operation 
> actually went well?

good question.

The method is void, but we could still throw an error.

I checked all our code that calls this and they don't check the return.
If have to to change the calling code, I'll be changing it to call the method 
on the screensaver directly anyway. 
Proxying here is just for compatibility.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15187

To: davidedmundson, #plasma, mart
Cc: ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol