D15598: Sort icon and cursor themes case-insensitively

[Nathaniel Graham]

ngraham updated this revision to Diff 41956.
ngraham added a comment.


  Rebase on Plasma/5.14 branch

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15598?vs=41925=41956

BRANCH
  sort-icon-and-cursor-themes-case-insensitively (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15598

AFFECTED FILES
  src/gtkconfigkcmodule.cpp

To: ngraham, apol, #plasma
Cc: cfeck, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15206: [Kickoff] Add a subtle separator line between the header and the content view

[Nathaniel Graham]

ngraham added a comment.


  Ping.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15206

To: ngraham, #plasma, #vdg
Cc: abetts, mmustac, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D15598: Sort icon and cursor themes case-insensitively

[Christoph Feck]

cfeck added a comment.


  If you would need to process the data sorted, you would already sort the 
model. But here, it is only sorted for display, and that's exactly the use case 
for the proxy model.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D15598

To: ngraham, apol, #plasma
Cc: cfeck, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

[Nathaniel Graham]

ngraham added a comment.


  Looks like the dependencies have been committed and we've branched for 5.14. 
#plasma  folks/@davidedmundson, does 
this look good to land now?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12040

To: Zren, #plasma
Cc: ngraham, cfeck, mart, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D15598: Sort icon and cursor themes case-insensitively

[Nathaniel Graham]

ngraham added a comment.


  Data structures are not really my forte, but I had a look. It seems possible 
but rather complicated due to the way the models populate and update themselves 
and return data. I'd like to see what @apol has to say.
  
  Is there some big disadvantage with this approach in this patch? Negative 
memory/performance implications?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D15598

To: ngraham, apol, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » kactivitymanagerd » kf5-qt5 SUSEQt5.11 - Build # 5 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kactivitymanagerd/job/kf5-qt5%20SUSEQt5.11/5/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Wed, 19 Sep 2018 15:07:59 +
 Build duration:
1 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/13)0%
(0/36)0%
(0/36)0%
(0/1708)0%
(0/1015)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc.common.database0%
(0/2)0%
(0/2)0%
(0/125)0%
(0/94)src.common.database.schema0%
(0/1)0%
(0/1)0%
(0/49)0%
(0/14)src.common.dbus0%
(0/2)0%
(0/2)0%
(0/29)0%
(0/4)src.service0%
(0/11)0%
(0/11)0%
(0/640)0%
(0/368)src.service.ksmserver0%
(0/1)0%
(0/1)0%
(0/86)0%
(0/64)src.service.plugins.activitytemplates0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/10)src.service.plugins.eventspy0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/4)src.service.plugins.globalshortcuts0%
(0/1)0%
(0/1)0%
(0/50)0%
(0/20)src.service.plugins.runapplication0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/28)src.service.plugins.slc0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/10)src.service.plugins.sqlite0%
(0/7)0%
(0/7)0%
(0/505)0%
(0/387)src.service.plugins.virtualdesktopswitch0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/8)src.utils0%
(0/6)0%
(0/6)0%
(0/43)0%
(0/4)

KDE CI: Plasma » kactivitymanagerd » kf5-qt5 FreeBSDQt5.11 - Build # 5 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kactivitymanagerd/job/kf5-qt5%20FreeBSDQt5.11/5/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Wed, 19 Sep 2018 15:07:59 +
 Build duration:
39 sec and counting

D13745: Implement support for virtual desktops on Wayland

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> abstracttasksproxymodeliface.cpp:216
> +
> +const QModelIndex  = mapIfaceToSource(index);
> +const AbstractTasksModelIface *m = dynamic_cast AbstractTasksModelIface *>(sourceIndex.model());

mapIfaceToSource and mapToSource returns non-const index i've wonder way it's 
get as const ref then performed a const_cast?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13745

To: hein, mart, mvourlakos
Cc: anthonyfieroni, zzag, ngraham, abetts, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15599: Port the "Switch Desktop" containment action to libtaskmanager

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> desktop.cpp:46
> +
> +if (!s_virtualDesktopInfo) {
> +delete s_virtualDesktopInfo;

`!s_instanceCount`

> desktop.cpp:65
>  
> -//Is it either the first time or the desktop number changed?
>  if (m_actions.count() < numDesktops) {
>  for (int i = m_actions.count() + 1; i <= numDesktops; ++i) {

This codes doesn't take into account when the virtual desktop names change etc. 
I think it should re-create the actions every time, and not try to be "smart" 
by only changing the ones that are "superfluous" or "missing" as the names and 
order inbetween could have changed

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15599

To: hein, mart, davidedmundson
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: Fwd: KDE CI: Administration » Dependency Build Plasma kf5-qt5 SUSEQt5.11 - Build # 5 - Failure!

[Christophe Giboudeaux]

On jeudi 13 septembre 2018 21:47:36 CEST Ben Cooksley wrote:
> Hi all,
> 
> Please see below. If someone could please take a look and fix this failure
> that would be appreciated.
> 
> On another note, the Marble build recently broke with a similar error - has
> something been changed in Frameworks to remove a dependency on DBus by any
> chance?
> 
[...]
> CMake Error at lib/CMakeLists.txt:17 (add_library):
> Target "milou" links to target "Qt5::DBus" but the target was not found.
> Perhaps a find_package() call is missing for an IMPORTED target, or an
> ALIAS target is missing?

For the record, this issue was fixed yesterday. 
The problem was a change in kpackage which added Qt5::DBus to the PUBLIC 
interface link.

Milou depends on plasma-framework which depends on kpackage but nothing was 
looking for Qt5DBus.

There are different ways to avoid this kind of build issues:
- add a find_dependency() call to your FooConfig.cmake file when you add a new 
public dependency
- and before that, make sure it's not a 'PRIVATE' link target. This was the 
case here, the commit didn't change the API.

D15599: Port the "Switch Desktop" containment action to libtaskmanager

[Eike Hein]

hein updated this revision to Diff 41932.
hein added a comment.


  Kill more unused stuff.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15599?vs=41931=41932

BRANCH
  arcpatch-D13745

REVISION DETAIL
  https://phabricator.kde.org/D15599

AFFECTED FILES
  containmentactions/switchdesktop/CMakeLists.txt
  containmentactions/switchdesktop/desktop.cpp
  containmentactions/switchdesktop/desktop.h

To: hein, mart, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15599: Port the "Switch Desktop" containment action to libtaskmanager

[Eike Hein]

hein updated this revision to Diff 41931.
hein added a comment.


  Remove another unused include.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15599?vs=41930=41931

BRANCH
  arcpatch-D13745

REVISION DETAIL
  https://phabricator.kde.org/D15599

AFFECTED FILES
  containmentactions/switchdesktop/CMakeLists.txt
  containmentactions/switchdesktop/desktop.cpp
  containmentactions/switchdesktop/desktop.h

To: hein, mart, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15599: Port the "Switch Desktop" containment action to libtaskmanager

[Eike Hein]

hein created this revision.
hein added reviewers: mart, davidedmundson.
Herald added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  This:
  
  - Makes it work on Wayland. Depends on D13745 
.
  - Cleans up includes and linkage.
  - Fixes some pre-existing bugs like cached actions not updating to changed 
desktop names.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D13745

REVISION DETAIL
  https://phabricator.kde.org/D15599

AFFECTED FILES
  containmentactions/switchdesktop/CMakeLists.txt
  containmentactions/switchdesktop/desktop.cpp
  containmentactions/switchdesktop/desktop.h

To: hein, mart, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15598: Sort icon and cursor themes case-insensitively

[Kai Uwe Broulik]

broulik added a comment.


  Can't we fix the `CursorThemesModel` and `IconThemesModel` to already 
populate themselves correctly?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D15598

To: ngraham, apol, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15550: Move correct indices in the manual sort map when getting a move() call for group children

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3d3a4b6c0aa6: Move correct indices in the manual sort map 
when getting a move() call for… (authored by hein).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15550?vs=41739=41928

REVISION DETAIL
  https://phabricator.kde.org/D15550

AFFECTED FILES
  libtaskmanager/tasksmodel.cpp

To: hein, #plasma, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » kactivitymanagerd » kf5-qt5 FreeBSDQt5.11 - Build # 4 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kactivitymanagerd/job/kf5-qt5%20FreeBSDQt5.11/4/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Wed, 19 Sep 2018 07:04:32 +
 Build duration:
1 min 24 sec and counting
   CONSOLE OUTPUT
  [...truncated 466.08 KB...]#define assert(e)   ((e) ? (void)0 : __assert(__func__, __FILE__, \  ^In file included from /usr/home/jenkins/workspace/Plasma/kactivitymanagerd/kf5-qt5 FreeBSDQt5.11/build/src/service/plugins/sqlite/resourcelinkingadaptor.cpp:11:In file included from /usr/home/jenkins/workspace/Plasma/kactivitymanagerd/kf5-qt5 FreeBSDQt5.11/build/src/service/plugins/sqlite/resourcelinkingadaptor.h:17:In file included from /usr/home/jenkins/workspace/Plasma/kactivitymanagerd/kf5-qt5 FreeBSDQt5.11/src/service/plugins/sqlite/ResourceLinking.h:26:In file included from /usr/local/include/boost/container/flat_set.hpp:27:In file included from /usr/local/include/boost/container/new_allocator.hpp:24:/usr/local/include/boost/container/throw_exception.hpp:88:25: warning: address of array 'msg' will always evaluate to 'true' [-Wpointer-bool-conversion]  BOOST_ASSERT_MSG(!msg, str);   ~^~~/usr/local/include/boost/assert.hpp:61:46: note: expanded from macro 'BOOST_ASSERT_MSG'# define BOOST_ASSERT_MSG(expr, msg) assert((expr)&&(msg)) ^~~~/usr/include/assert.h:54:21: note: expanded from macro 'assert'#define assert(e)   ((e) ? (void)0 : __assert(__func__, __FILE__, \  ^In file included from /usr/home/jenkins/workspace/Plasma/kactivitymanagerd/kf5-qt5 FreeBSDQt5.11/build/src/service/plugins/sqlite/resourcescoringadaptor.cpp:11:In file included from /usr/home/jenkins/workspace/Plasma/kactivitymanagerd/kf5-qt5 FreeBSDQt5.11/build/src/service/plugins/sqlite/resourcescoringadaptor.h:17:In file included from /usr/home/jenkins/workspace/Plasma/kactivitymanagerd/kf5-qt5 FreeBSDQt5.11/src/service/plugins/sqlite/StatsPlugin.h:27:In file included from /usr/local/include/boost/container/flat_set.hpp:27:In file included from /usr/local/include/boost/container/new_allocator.hpp:24:/usr/local/include/boost/container/throw_exception.hpp:56:21: warning: address of array 'msg' will always evaluate to 'true' [-Wpointer-bool-conversion]  BOOST_ASSERT(!msg);   ~^~~/usr/local/include/boost/assert.hpp:60:36: note: expanded from macro 'BOOST_ASSERT'# define BOOST_ASSERT(expr) assert(expr)   ^~~~/usr/include/assert.h:54:21: note: expanded from macro 'assert'#define assert(e)   ((e) ? (void)0 : __assert(__func__, __FILE__, \  ^In file included from /usr/home/jenkins/workspace/Plasma/kactivitymanagerd/kf5-qt5 FreeBSDQt5.11/build/src/service/plugins/sqlite/resourcescoringadaptor.cpp:11:In file included from /usr/home/jenkins/workspace/Plasma/kactivitymanagerd/kf5-qt5 FreeBSDQt5.11/build/src/service/plugins/sqlite/resourcescoringadaptor.h:17:In file included from /usr/home/jenkins/workspace/Plasma/kactivitymanagerd/kf5-qt5 FreeBSDQt5.11/src/service/plugins/sqlite/StatsPlugin.h:27:In file included from /usr/local/include/boost/container/flat_set.hpp:27:In file included from /usr/local/include/boost/container/new_allocator.hpp:24:/usr/local/include/boost/container/throw_exception.hpp:64:25: warning: address of array 'msg' will always evaluate to 'true' [-Wpointer-bool-conversion]  BOOST_ASSERT_MSG(!msg, str);   ~^~~/usr/local/include/boost/assert.hpp:61:46: note: expanded from macro 'BOOST_ASSERT_MSG'# define BOOST_ASSERT_MSG(expr, msg) assert((expr)&&(msg)) ^~~~/usr/include/assert.h:54:21: note: expanded from macro 'assert'#define assert(e)   ((e) ? (void)0 : __assert(__func__, __FILE__, \  ^In file included from /usr/home/jenkins/workspace/Plasma/kactivitymanagerd/kf5-qt5 FreeBSDQt5.11/build/src/service/plugins/sqlite/resourcescoringadaptor.cpp:11:In file included from /usr/home/jenkins/workspace/Plasma/kactivitymanagerd/kf5-qt5 FreeBSDQt5.11/build/src/service/plugins/sqlite/resourcescoringadaptor.h:17:In file included from /usr/home/jenkins/workspace/Plasma/kactivitymanagerd/kf5-qt5 FreeBSDQt5.11/src/service/plugins/sqlite/StatsPlugin.h:27:In file included from /usr/local/include/boost/container/flat_set.hpp:27:In file included from /usr/local/include/boost/container/new_allocator.hpp:24:/usr/local/include/boost/container/throw_exception.hpp:72:25: warning: address of array 'msg' will always evaluate to 'true' [-Wpointer-bool-conversion]  BOOST_ASSERT_MSG(!msg, str);   ~^~~/usr/local/include/boost/assert.hpp:61:46: note: expanded from macro 'BOOST_ASSERT_MSG'# define BOOST_ASSERT_MSG(expr, msg) assert((expr)&&(msg)) ^~~~/usr/include/assert.h:54:21: note: expanded from macro 

KDE CI: Plasma » kactivitymanagerd » kf5-qt5 SUSEQt5.11 - Build # 4 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kactivitymanagerd/job/kf5-qt5%20SUSEQt5.11/4/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Wed, 19 Sep 2018 07:04:32 +
 Build duration:
46 sec and counting
   CONSOLE OUTPUT
  [...truncated 149.34 KB...][ 29%] Building CXX object src/service/plugins/runapplication/CMakeFiles/kactivitymanagerd_plugin_runapplication.dir/RunApplicationPlugin.cpp.o[ 30%] Generating templatesadaptor.moc[ 32%] Generating slcadaptor.moc[ 33%] Generating featuresadaptor.mocScanning dependencies of target kactivitymanagerd_plugin_virtualdesktopswitchScanning dependencies of target kactivitymanagerd_plugin_globalshortcuts[ 34%] Building CXX object src/service/plugins/virtualdesktopswitch/CMakeFiles/kactivitymanagerd_plugin_virtualdesktopswitch.dir/VirtualDesktopSwitchPlugin.cpp.o[ 35%] Generating activitiesadaptor.mocScanning dependencies of target kactivitymanagerd_plugin_activitytemplatesScanning dependencies of target kactivitymanagerd_plugin_slc[ 36%] Building CXX object src/service/plugins/globalshortcuts/CMakeFiles/kactivitymanagerd_plugin_globalshortcuts.dir/GlobalShortcutsPlugin.cpp.o[ 38%] Building CXX object src/service/plugins/activitytemplates/CMakeFiles/kactivitymanagerd_plugin_activitytemplates.dir/TemplatesPlugin.cpp.o[ 39%] Generating resourcesadaptor.moc[ 40%] Building CXX object src/service/plugins/slc/CMakeFiles/kactivitymanagerd_plugin_slc.dir/SlcPlugin.cpp.oScanning dependencies of target kactivitymanagerd[ 41%] Building CXX object src/service/CMakeFiles/kactivitymanagerd.dir/Application.cpp.oIn file included from /usr/include/qt5/QtCore/qstring.h:52, from /usr/include/qt5/QtCore/qobject.h:47, from /usr/include/qt5/QtCore/QObject:1, from /home/jenkins/workspace/Plasma/kactivitymanagerd/kf5-qt5 SUSEQt5.11/src/service/Plugin.h:27, from /home/jenkins/workspace/Plasma/kactivitymanagerd/kf5-qt5 SUSEQt5.11/src/service/plugins/runapplication/RunApplicationPlugin.h:21, from /home/jenkins/workspace/Plasma/kactivitymanagerd/kf5-qt5 SUSEQt5.11/src/service/plugins/runapplication/RunApplicationPlugin.cpp:18:/home/jenkins/workspace/Plasma/kactivitymanagerd/kf5-qt5 SUSEQt5.11/src/service/plugins/runapplication/RunApplicationPlugin.cpp: In lambda function:/home/jenkins/workspace/Plasma/kactivitymanagerd/kf5-qt5 SUSEQt5.11/src/service/plugins/runapplication/RunApplicationPlugin.cpp:46:13: error: expected primary-_expression_ before ���enum��� setName(QStringLiteral("org.kde.ActivityManager.RunApplication"=); ^~/home/jenkins/workspace/Plasma/kactivitymanagerd/kf5-qt5 SUSEQt5.11/src/service/plugins/runapplication/RunApplicationPlugin.cpp:46:13: error: expected primary-_expression_ before ���}��� token setName(QStringLiteral("org.kde.ActivityManager.RunApplication"=); ^~/home/jenkins/workspace/Plasma/kactivitymanagerd/kf5-qt5 SUSEQt5.11/src/service/plugins/runapplication/RunApplicationPlugin.cpp: In constructor ���RunApplicationPlugin::RunApplicationPlugin(QObject*, const QVariantList&)���:/home/jenkins/workspace/Plasma/kactivitymanagerd/kf5-qt5 SUSEQt5.11/src/service/plugins/runapplication/RunApplicationPlugin.cpp:46:70: error: expected ���)��� before ���;��� token setName(QStringLiteral("org.kde.ActivityManager.RunApplication"=);~ ^/home/jenkins/workspace/Plasma/kactivitymanagerd/kf5-qt5 SUSEQt5.11/src/service/plugins/runapplication/RunApplicationPlugin.cpp: In member function ���virtual bool RunApplicationPlugin::init(QHash&)���:/home/jenkins/workspace/Plasma/kactivitymanagerd/kf5-qt5 SUSEQt5.11/src/service/plugins/runapplication/RunApplicationPlugin.cpp:65:94: error: no matching function for call to ���RunApplicationPlugin::retrieve(QObject*&, QString, QString)��� m_activitiesService, QStringLiteral("CurrentActivity"), QStringLiteral("QString"));  ^In file included from /home/jenkins/workspace/Plasma/kactivitymanagerd/kf5-qt5 SUSEQt5.11/src/service/plugins/runapplication/RunApplicationPlugin.h:21, from /home/jenkins/workspace/Plasma/kactivitymanagerd/kf5-qt5 SUSEQt5.11/src/service/plugins/runapplication/RunApplicationPlugin.cpp:18:/home/jenkins/workspace/Plasma/kactivitymanagerd/kf5-qt5 SUSEQt5.11/src/service/Plugin.h:86:30: note: candidate: ���template static ReturnType Plugin::retrieve(QObject*, const char*, const char*, Args ...)��� inline static ReturnType retrieve(QObject *object, const char *method,  ^~~~/home/jenkins/workspace/Plasma/kactivitymanagerd/kf5-qt5 SUSEQt5.11/src/service/Plugin.h:86:30: note:   template argument deduction/substitution failed:In file included from /usr/include/qt5/QtCore/qstring.h:52, from