date:20181009

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-10-09 Thread Nathaniel Graham

ngraham updated this revision to Diff 43260.
ngraham added a comment.


  Rebase

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16031?vs=43257=43260

BRANCH
  tweaked-login-screen (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16031

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/UserDelegate.qml
  sddm-theme/Main.qml

To: ngraham, #vdg, #plasma
Cc: abetts, pstefan, broulik, rikmills, filipf, rooty, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-10-09 Thread Root

rooty added a comment.


  In D16031#340321 , @ngraham wrote:
  
  > Here are some screenshots from the latest version:
  >
  > F6316263: Spaceships.png 
  >
  > F6316264: Snow.png 
  >
  > F6316265: New Mexico.png 
  >
  > F6316266: Icebergs.png 
  >
  > F6316267: Stars.png 
  >
  > I think the button backgrounds could stand to be darkened a little bit 
more, but that's a discussion for D15999 .
  
  
  a definite improvement imo

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma
Cc: abetts, pstefan, broulik, rikmills, filipf, rooty, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16035: [SDDM theme] Use grammatically correct string "Log In"

2018-10-09 Thread Nathaniel Graham

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:817f51d88237: [SDDM theme] Use grammatically correct 
string Log In (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16035?vs=43258=43259

REVISION DETAIL
  https://phabricator.kde.org/D16035

AFFECTED FILES
  sddm-theme/Login.qml
  sddm-theme/Main.qml

To: ngraham, #vdg, #plasma, abetts
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D16035: [SDDM theme] Use grammatically correct string "Log In"

2018-10-09 Thread Nathaniel Graham

ngraham updated this revision to Diff 43258.
ngraham added a comment.


  Update one more occurrence

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16035?vs=43101=43258

BRANCH
  arcpatch-D16035

REVISION DETAIL
  https://phabricator.kde.org/D16035

AFFECTED FILES
  sddm-theme/Login.qml
  sddm-theme/Main.qml

To: ngraham, #vdg, #plasma, abetts
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-10-09 Thread Nathaniel Graham

ngraham added a comment.


  Here are some screenshots from the latest version:
  
  F6316263: Spaceships.png 
  
  F6316264: Snow.png 
  
  F6316265: New Mexico.png 
  
  F6316266: Icebergs.png 
  
  F6316267: Stars.png 
  
  I think the button backgrounds could stand to be darkened a little bit more, 
but that's a discussion for D15999 .

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma
Cc: abetts, pstefan, broulik, rikmills, filipf, rooty, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-10-09 Thread Nathaniel Graham

ngraham updated this revision to Diff 43257.
ngraham added a comment.


  - Tighten up outline around user avatar
  - Tweak shadows

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16031?vs=43092=43257

BRANCH
  tweaked-login-screen (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16031

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/UserDelegate.qml
  sddm-theme/Main.qml

To: ngraham, #vdg, #plasma
Cc: abetts, pstefan, broulik, rikmills, filipf, rooty, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-10-09 Thread Nathaniel Graham

ngraham marked an inline comment as done.
ngraham added a comment.

  In D16031#340299 , @filipf wrote:

  > One more thing I noticed about functionality and that is related to the 
opacity of the circles.
  >
  > Since we now have circles, we can add a different opacity for when an 
action button is hovered over and when it's not. Here's a too strong of an 
example of different opacities, this time from actual fiddling with SDDM 
theming:
  >
  > F6316007: image.png 
  >
  > It's fairly easy to implement. In **ActionButton.qml **you place something 
like
  >
  >   opacity: ( containsMouse || activeFocus ) ? 1 : 0.85
  >
  >
  > under the line
  >
  >   activeFocusOnTab: true
  >   

  There's already a fairly nice hover effect built in with these new icons so 
this actually isn't even needed.

  I tried using outlines instead of shadows, and it's not bad for the clock, 
but it doesn't work //at all// for the smaller username and button text. So I 
think that's a no-go. I'll have a new version up shortly.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma
Cc: abetts, pstefan, broulik, rikmills, filipf, rooty, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

2018-10-09 Thread Nathaniel Graham

ngraham added a comment.


  No problem at all, I just wanted it to get in so I could blog about it, since 
I think it will prove popular. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12040

To: Zren, #plasma, davidedmundson
Cc: ngraham, cfeck, mart, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

2018-10-09 Thread Chris Holland

Zren added a comment.


  Sorry, just merged both to master. Thanks davidedmundson for the patches that 
updated the ComboBox.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12040

To: Zren, #plasma, davidedmundson
Cc: ngraham, cfeck, mart, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

2018-10-09 Thread Chris Holland

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:347f43c42b70: Add Get Wallpaper Plugins... 
button to Config Desktop dialog (authored by Zren).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12041?vs=32246=43256

REVISION DETAIL
  https://phabricator.kde.org/D12041

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml

To: Zren, #plasma, davidedmundson
Cc: mart, abetts, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

2018-10-09 Thread Chris Holland

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5e1b650859fe: Add wallpaperplugin.knsrc + QML function to 
open GHNS dialog (authored by Zren).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12040?vs=42950=43255

REVISION DETAIL
  https://phabricator.kde.org/D12040

AFFECTED FILES
  components/shellprivate/CMakeLists.txt
  components/shellprivate/shellprivateplugin.cpp
  components/shellprivate/wallpaperplugin/wallpaperplugin.cpp
  components/shellprivate/wallpaperplugin/wallpaperplugin.h
  components/shellprivate/wallpaperplugin/wallpaperplugin.knsrc

To: Zren, #plasma, davidedmundson
Cc: ngraham, cfeck, mart, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D14697: X11: set GDK_SCALE (try 2)

2018-10-09 Thread David Edmundson

davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in startkde.cmake:98
> Where does `kdeglobals_kscreen_scalefactor` come from?

kstartupconfig5, which reads startupconfigkeys to see what to extract. They 
then get set as env vars.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14697

To: eszlari, davidedmundson, ngraham, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16035: [SDDM theme] Use grammatically correct string "Log In"

2018-10-09 Thread Andres Betts

abetts accepted this revision as: VDG, abetts.
abetts added a comment.
This revision is now accepted and ready to land.


  +1

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16035

To: ngraham, #vdg, #plasma, abetts
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-10-09 Thread Filip Fila

filipf added a comment.


  One more thing I noticed about functionality and that is related to the 
opacity of the circles.
  
  Since we now have circles, we can add a different opacity for when an action 
button is hovered over and when it's not. Here's a too strong of an example of 
different opacities, this time from actual fiddling with SDDM theming:
  
  F6316007: image.png 
  
  It's fairly easy to implement. In **ActionButton.qml **you place something 
like
  
opacity: ( containsMouse || activeFocus ) ? 1 : 0.85
  
  under the line
  
activeFocusOnTab: true

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma
Cc: abetts, pstefan, broulik, rikmills, filipf, rooty, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15885: Clean UI file for `details` portion of UI

2018-10-09 Thread Stefan Brüns

bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  Can you ammend this with the removals of appname/m_appname?
  If you need any assistance, please ask!

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D15885

To: sharvey, ngraham, bruns, davidedmundson
Cc: bruns, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-10-09 Thread Filip Fila

filipf added a comment.


  @ngraham well actually if we are turning off blur maybe it will somehow be 
possible to put a plain white background in SDDM again. Right now SDDM will 
darken it for you. If it won't do that anymore, this means that a drop shadow 
would probably not be enough; whoever implemented the current solution (for the 
lock screen as well) must have had this scenario on their mind. And truth be 
told light backgrounds do accentuate the shadows. But if you do agree that the 
clock shadows could be improved, it would be cool to see some other design 
variants yeah.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma
Cc: abetts, pstefan, broulik, rikmills, filipf, rooty, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16082: Notify headphone being plugged in on some hardware

2018-10-09 Thread Kai Uwe Broulik

broulik added inline comments.

INLINE COMMENTS

> main.qml:173
> +// For some hardware, headphones are a port of the build-in 
> audio sink
> +var text = 
> defaultSink.ports[defaultSink.activePortIndex].description;
> +var icon;

Please cache `defaultSink.ports[defaultSink.activePortIndex]` in a variable.

Also, can this be out of bounds or otherwise throw an error?

> main.qml:175
> +var icon;
> +if (defaultSink.ports[defaultSink.activePortIndex].name == 
> "analog-output-headphones") {
> +icon = Icon.formFactorIcon("headphone");

I would prefer if hardcoded values like these are put into a helper function or 
`formFactorIcon` augmented to take those into account also

> main.qml:181
> +
> +if (!icon || icon == "") {
> +icon = Icon.formFactorIcon(defaultSink.formFactor);

`if (!icon) {` is sufficient

> main.qml:187
>  if (!icon) {
> +text = defaultSink.description;
>  // Show "muted" icon for Dummy output

The `text =` assignments seem to serve no purpose, ie. the end result would be 
no different than having it down where it was

> pulseaudio.cpp:264
>  connect(sink, ::stateChanged, this, 
> ::updatePreferredSink);
> +connect(sink, ::activePortIndexChanged, this, [this]() {
> +Q_EMIT defaultSinkChanged();

You can connect a signal to a signal:

  connect(sink, ::activePortIndexChanged, this, ::defaultSinkChanged);

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D16082

To: thsurrel, #plasma, #vdg, drosca
Cc: broulik, nicolasfella, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16087: RFC: Store full URL as URI

2018-10-09 Thread Kai Uwe Broulik

broulik created this revision.
broulik added reviewers: Plasma, hein, ivan.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  A recently used file can also be a remote location

TEST PLAN
  It took me forever to figure out where this entry actually came from :/
  Task Manager uses the URI as `QUrl` for recent documents and tries to exclude 
Folders which didn't work as `QUrl("/foo/bar") is not `localFile` and as such 
the codepath was never hit.
  
  Not sure what the implications are for this change, it does fix Dolphin 
showing folders in its task manager context menu, often duplicating the ones 
from places. Right-click Dolphin, chose e.g. "Downloads", and you end up with a 
"Downloads" entry without icon in the menu.

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D16087

AFFECTED FILES
  src/service/plugins/eventspy/EventSpy.cpp

To: broulik, #plasma, hein, ivan
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16073: openconnect: add missing dependency Qt5Xml

2018-10-09 Thread Andreas Sturmlechner

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:6919a84c70d8: openconnect: add missing dependency Qt5Xml 
(authored by asturmlechner).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16073?vs=43221=43247

REVISION DETAIL
  https://phabricator.kde.org/D16073

AFFECTED FILES
  vpn/openconnect/CMakeLists.txt

To: asturmlechner, #plasma, alexeymin
Cc: alexeymin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16073: openconnect: add missing dependency Qt5Xml

2018-10-09 Thread Andreas Sturmlechner

asturmlechner added a comment.


  In D16073#340107 , @alexeymin 
wrote:
  
  > If it fixes build error `.../vpn/openconnect/openconnectauth.cpp:38:10: 
fatal error: QDomDocument: No such file or directory` then fine...
  
  
  Yes, it was exactly that: https://bugs.gentoo.org/668166

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  Plasma/5.14

REVISION DETAIL
  https://phabricator.kde.org/D16073

To: asturmlechner, #plasma, alexeymin
Cc: alexeymin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14697: X11: set GDK_SCALE (try 2)

2018-10-09 Thread Peter Eszlari

eszlari added inline comments.

INLINE COMMENTS

> broulik wrote in startkde.cmake:98
> Where does `kdeglobals_kscreen_scalefactor` come from?

Line 52.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14697

To: eszlari, davidedmundson, ngraham, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14697: X11: set GDK_SCALE (try 2)

2018-10-09 Thread Kai Uwe Broulik

broulik added inline comments.

INLINE COMMENTS

> startkde.cmake:98
>  export QT_SCREEN_SCALE_FACTORS="$kdeglobals_kscreen_screenscalefactors"
> +if [ "$kdeglobals_kscreen_scalefactor" -eq "2" ] || [ 
> "$kdeglobals_kscreen_scalefactor" -eq "3" ]; then
> +export GDK_SCALE=$kdeglobals_kscreen_scalefactor

Where does `kdeglobals_kscreen_scalefactor` come from?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14697

To: eszlari, davidedmundson, ngraham, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14697: X11: set GDK_SCALE (try 2)

2018-10-09 Thread Nathaniel Graham

ngraham added a comment.


  @davidedmundson 5.14 was just released; should we give this a shot for 5.15?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14697

To: eszlari, davidedmundson, ngraham, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16082: Notify headphone being plugged in on some hardware

2018-10-09 Thread Thomas Surrel

thsurrel created this revision.
thsurrel added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
thsurrel requested review of this revision.

REVISION SUMMARY
  On my computer, plugging the headphones in and out does not create
  a sink change but only a port change within the audio 'build-in' sink.
  
  I don't know if many users are in the same case, but this patch brings
  back the OSD notifier.
  
  I don't know if what I did is the right approach, comments are welcomed.

TEST PLAN
  Buy a Lenovo T470s :)
  Plug headphones in and enjoy the nice icon on the OSD.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  arc_ports (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16082

AFFECTED FILES
  applet/contents/ui/main.qml
  src/device.h
  src/pulseaudio.cpp

To: thsurrel, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16073: openconnect: add missing dependency Qt5Xml

2018-10-09 Thread Alexey Min

alexeymin accepted this revision.
alexeymin added a comment.
This revision is now accepted and ready to land.


  
https://cgit.kde.org/plasma-nm.git/diff/vpn/openconnect/CMakeLists.txt?id=a44b7f38c548d756b6cb822c047ef71cf67645f5
  Probably this commit could remove dependency on QtXml (I'm not sure, QtDbus 
probably depends on QtXml and QtDbus was removed)
  If it fixes build error `.../vpn/openconnect/openconnectauth.cpp:38:10: fatal 
error: QDomDocument: No such file or directory` then fine...

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  Plasma/5.14

REVISION DETAIL
  https://phabricator.kde.org/D16073

To: asturmlechner, #plasma, alexeymin
Cc: alexeymin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16081: Fix build with gpsd 3.18

2018-10-09 Thread Antonio Rojas

arojas created this revision.
arojas added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  The signature of gps_read has changed in 3.18 to add an optional buffer 
parameter.
  Passing NULL, 0 should keep the previous behavior, see 
https://git.savannah.gnu.org/cgit/gpsd.git/commit?id=6bba8b329fc7687b15863d30471d5af402467802

TEST PLAN
  Builds with gpsd 3.17 and 3.18. Can't test if it works since I don't have a 
gps device.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16081

AFFECTED FILES
  dataengines/geolocation/location_gps.cpp

To: arojas, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16076: load icons from proper icon themes

2018-10-09 Thread Marco Martin

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:6a45d5592acf: load icons from proper icon themes 
(authored by mart).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16076?vs=43227=43229

REVISION DETAIL
  https://phabricator.kde.org/D16076

AFFECTED FILES
  KF5Kirigami2Macros.cmake
  src/desktopicon.cpp
  src/desktopicon.h
  src/kirigamiplugin.cpp

To: mart, #kirigami
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D16076: load icons from proper icon themes

2018-10-09 Thread Marco Martin

mart created this revision.
mart added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  this renders Kirigami.Icon and internal QQC2 icon loading mechanism
  compatible, as creating a valid theme, QIconLoader will work.
  
  always install index.theme
  
  Revert "always install index.theme"
  
  This reverts commit ec559a907fe15fea9d52bd051ca82ef8c62ca000.

TEST PLAN
  on android the gallery loads both icons in Kirigami.Icon and in
  QQC2 ToolButtons

REPOSITORY
  R169 Kirigami

BRANCH
  phab/iconthemes

REVISION DETAIL
  https://phabricator.kde.org/D16076

AFFECTED FILES
  KF5Kirigami2Macros.cmake
  src/desktopicon.cpp
  src/desktopicon.h
  src/kirigamiplugin.cpp

To: mart, #kirigami
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-10-09 Thread Nathaniel Graham

ngraham added a comment.


  I really like the darker background for the icons, and have suggested that 
for D15999: Add icons with added background to system.svgz 
. If we do that, we won't need either blur 
or shadows behind them, and the shadows can just be for text.
  
  I have no opinion regarding smaller icons within the background circle, but 
that would be a suggestion for D15999 , not 
this patch.
  
  Regarding the clock shadow, the one in your mockup @filipf is so tight that I 
wonder if simply outlining the text might look better. I can reduce the size of 
sha current shadow and see what it looks like, and try out an outline too.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma
Cc: abetts, pstefan, broulik, rikmills, filipf, rooty, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-10-09 Thread Filip Fila

filipf added a comment.


  The new shadows around the action button text look better and the border 
around the avatar seems perfectly fine actually.
  
  I do, however, think that the shadows are too strong all together. The clock 
is actually a bigger concern. Have a look at the inside of the number "4" where 
the shadows overlap. Or inside the number "8"... it's very bad aesthetically.
  
  Why are we using the outer shadow effect on the clock and not the drop shadow 
effect? The text is big and thick enough to allow the use of a drop shadow, 
which looks much more classy:
  
  F6315226: With_border_2.png 
  
  Unfortunately the other text has to use outer shadow because the drop shadow 
effect is not enough (I tried).
  
  In the mock-up I've also: 1) removed the circle's border; 2) scaled down the 
icons within the circle; 3) added blur behind the circle (can't really see it 
here unfortunately)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma
Cc: abetts, pstefan, broulik, rikmills, filipf, rooty, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-10-09 Thread Nathaniel Graham

ngraham added a comment.


  In D16031#339882 , @broulik wrote:
  
  > Again: Can we just use shadows behind the logout buttons and avatar like we 
have for the clock?
  
  
  We can't do only a shadow for the avatar since it gives a shadow to the 
outline of the icon and not the shader effect, which looks bad. If we add a 
shadow behind the avatar (which I would be open to), the circle background I've 
added is mandatory.
  
  For the buttons, it's a bit better, but I don't think //just// shadows behind 
the current icons will be enough:
  F6315209: Drop shadows behind original icons, default background.png 

  F6315210: Drop shadows behind original icons, challenging background.png 

  
  Shadows behind the new circle-background icons do work pretty well though, 
and improve the contrast to good levels.:
  F6315212: Drop shadows behind round icons, default background.png 

  F6315214: Drop shadows behind round icons, challenging background.png 

  
  Maybe that reveals that the icons' translucent background should be less 
translucent, or even opaque, and then we wouldn't need a shadow for them.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma
Cc: abetts, pstefan, broulik, rikmills, filipf, rooty, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16073: openconnect: add missing dependency Qt5Xml

2018-10-09 Thread Andreas Sturmlechner

asturmlechner updated this revision to Diff 43221.
asturmlechner added a comment.


  Only pull in Qt5Xml if OpenConnect is requested.

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16073?vs=43220=43221

BRANCH
  Plasma/5.14

REVISION DETAIL
  https://phabricator.kde.org/D16073

AFFECTED FILES
  vpn/openconnect/CMakeLists.txt

To: asturmlechner, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16073: openconnect: add missing dependency Qt5Xml

2018-10-09 Thread Andreas Sturmlechner

asturmlechner created this revision.
asturmlechner added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
asturmlechner requested review of this revision.

REVISION SUMMARY
  QDomDocument is imported from vpn/openconnect/openconnectauth.cpp

TEST PLAN
  Build succeeds now.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  Plasma/5.14

REVISION DETAIL
  https://phabricator.kde.org/D16073

AFFECTED FILES
  CMakeLists.txt
  vpn/openconnect/CMakeLists.txt

To: asturmlechner, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-10-09 Thread Root

rooty added a comment.


  In D16031#339180 , @pstefan wrote:
  
  > As other have pointed out the shadows for the buttons and username look out 
of place. Do they use the same radius/spread as those of the clock?
  >
  > I think blur is still needed. If you look at the picture of the snow-y 
landscape the contrast suffers quite a bit because of the noisy background. In 
my mock-up test the smoothing of the blur helped quite in such cases.
  
  
  
  
  In D16031#339559 , @ngraham wrote:
  
  > I see what folks mean about the background circle for the avatar being too 
big. I'll reduce it, but IMHO it the "border" needs to be there, even if it's 
small. Compare the following images on a background that really highlights the 
need:
  >
  > No border: F6313303: Without border.png 

  >
  > 2px border: F6313305: With border.png 
  >
  > To my eyes there is no question, the second one looks better.
  >
  > I can also tweak the shadows Here's how it would look with the above change 
plus the button and username shadows tweaked to better match the clock's 
shadows: F6313297: Screenshot_20181008_193916.png 

  
  
  circle border around avatar = it looks great in the last image, flush with 
the avatar
  shadows = can you make them more diffuse please and post it again? thanks

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma
Cc: abetts, pstefan, broulik, rikmills, filipf, rooty, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

Plasma 5.14.0

2018-10-09 Thread Jonathan Riddell

Plasma 5.14.0 is now released
https://www.kde.org/announcements/plasma-5.14.0.php

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-10-09 Thread Kai Uwe Broulik

broulik added a comment.


  Again: Can we just use shadows behind the logout buttons and avatar like we 
have for the clock?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma
Cc: abetts, pstefan, broulik, rikmills, filipf, rooty, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

Google CodeIn

2018-10-09 Thread Valorie Zimmerman

Hello folks, we (KDE Student Programs) are still trying to recruit mentors
for the upcoming Google CodeIn contest for 14 to 18 year-olds. We've
written to KDE-Community ML and KDE-devel, but don't want to nag. Still, we
have too few mentors and not enough tasks to begin the contest.

What works best is *lots* of mentors with a few tasks each. Is there
something you would love done that would take you an hour or two? Amazing
but true, motivated youngsters can do these tasks if given good
instructions. Please read up on the contest if you've not participated
before, join the KDE-Soc-Mentor ML and as for an invite to the webapp.
Please mention what team you're working with and with what google-connected
email account you want to be invited.

https://community.kde.org/GCi for more information. Please write directly
to kde-soc-managem...@kde.org if there are any difficulties, not to me
personally.

Thanks,

Valorie, for KDE Student Programs

-- 
http://about.me/valoriez

D15209: Port scripting to Qt WebEngine

2018-10-09 Thread Fabian Vogt

This revision was automatically updated to reflect the committed changes.
Closed by commit R111:c9747e37c531: Port scripting to Qt WebEngine (authored by 
fvogt).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15209?vs=40829=43206

REVISION DETAIL
  https://phabricator.kde.org/D15209

AFFECTED FILES
  CMakeLists.txt
  config-ksysguard.h.cmake
  processui/CMakeLists.txt
  processui/scripting.cpp
  processui/scripting.h

To: fvogt, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15209: Port scripting to Qt WebEngine

2018-10-09 Thread David Edmundson

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  I don't like the use of any web browser in something so minor...but this is 
definitely better than the current state.
  I say we go for it.

REPOSITORY
  R111 KSysguard Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15209

To: fvogt, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16066: [ksmserver] Launch logout greeter with DBus methods

2018-10-09 Thread David Edmundson

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Removing this is part of preparations for ksmserver to become just an X
  session manager. See T9779 .
  
  Instead of ksmserver opening the greeter with a tonne of args and then
  having a socket to watch for changes, the new mechanism is that we fire
  and forget the prompt. Then the logout prompt calls back into ksmserver
  with the request. Simplifies code greatly allows for moving.
  
  KSMserver's shutdown DBus method remain on ksmserver for compatibility,
  but ultimately spawning the prompt will move to libkworkspace and called
  from the session directly.
  
  QML API in the logout greeter remains mostly untouched.
  
  Behavioural changes are minor:
  There was a QML property "choose" exposed to the greeter if the default
  shutdown option is set to None. Though we don't allow this in the KCM
  and our default prompt doesn't use it.
  
  We no longer block a user from saving a session whilst a logout prompt
  is active.

TEST PLAN
  Logged out
  Shutdown
  
  Also ran with old ksmserver, still got a prompt

REPOSITORY
  R120 Plasma Workspace

BRANCH
  ksmserver_split

REVISION DETAIL
  https://phabricator.kde.org/D16066

AFFECTED FILES
  ksmserver/CMakeLists.txt
  ksmserver/org.kde.LogoutPrompt.xml
  ksmserver/server.cpp
  ksmserver/server.h
  ksmserver/shutdown.cpp
  logout-greeter/CMakeLists.txt
  logout-greeter/greeter.cpp
  logout-greeter/greeter.h
  logout-greeter/main.cpp
  logout-greeter/shutdowndlg.cpp
  logout-greeter/shutdowndlg.h

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15209: Port scripting to Qt WebEngine

2018-10-09 Thread Fabian Vogt

fvogt added a comment.


  I removed the RFC - I'm using this patch since I uploaded and haven't had any 
issues so far.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D15209

To: fvogt, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16065: [logoutprompt] Split greeter class into separate .h .cpp files

2018-10-09 Thread David Edmundson

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  No code changes

TEST PLAN
  Compiles

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16065

AFFECTED FILES
  logout-greeter/CMakeLists.txt
  logout-greeter/greeter.cpp
  logout-greeter/greeter.h
  logout-greeter/main.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15840: [Folder View] Remember selected item when navigating in subfolders

2018-10-09 Thread Thomas Surrel

thsurrel updated this revision to Diff 43190.
thsurrel added a comment.


  Use gridView.visibleArea

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15840?vs=43158=43190

BRANCH
  arc_folderview3 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15840

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml

To: thsurrel, #plasma, broulik, hein
Cc: anthonyfieroni, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

43 matches

Mail list logo