D16241: [Folder View] Improve layout and formatting of Icons page

[Nathaniel Graham]

ngraham added a comment.


  Note: I know the `width: 500` is a horrible hack that is certainly the wrong 
way to do this, but I couldn't figure out how else to get the Labels' width to 
be long enough so that `Layout.alignment: Qt.AlignRight` worked. 
`Layout.fillWidth: true` had no effect. I look forward to learning the correct 
way to handle this situation. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16241

To: ngraham, #plasma, #vdg, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16241: [Folder View] Improve layout and formatting of Icons page

[Nathaniel Graham]

ngraham updated this revision to Diff 43712.
ngraham added a comment.


  Improve another string

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16241?vs=43710=43712

BRANCH
  icons-page-tweaks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16241

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigIcons.qml

To: ngraham, #plasma, #vdg, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16241: [Folder View] Improve layout and formatting of Icons page

[Nathaniel Graham]

ngraham added a comment.


  Note: I know the `width: 500` is a horrible hack that is certainly the wrong 
way to do this, but I couldn't figure out how else to get the Labels' width to 
be long enough so that `Layout.alignment: Qt.AlignRight` worked. 
`Layout.fillWidth: true` had no effect. I look forward to learning the correct 
way to handle this situation. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16241

To: ngraham, #plasma, #vdg, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16241: [Folder View] Improve layout and formatting of Icons page

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, VDG, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Improve the layout and formatting of the Icons page to follow 
https://hig.kde.org/patterns/content/form.html

TEST PLAN
  Desktop, before:
  
  After:
  
  Panel widget, before:
  
  After:

REPOSITORY
  R119 Plasma Desktop

BRANCH
  icons-page-tweaks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16241

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigIcons.qml

To: ngraham, #plasma, #vdg, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16231: [ksmserver] Rewrite Startup

[David Edmundson]

davidedmundson marked an inline comment as done.
davidedmundson added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in startup.cpp:194
> Can we delay it to finishStartup?

Probably, but for now I'm trying to be as close to 1:1 with the old code.

Long term plan ideally I want these just in a .desktop file that kglobalaccel 
can use directly.

> anthonyfieroni wrote in startup.cpp:210
> It's unused, can we remove it?

it's called from main

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16231

To: davidedmundson, #plasma
Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16231: [ksmserver] Rewrite Startup

[David Edmundson]

davidedmundson updated this revision to Diff 43695.
davidedmundson added a comment.


  Update

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16231?vs=43681=43695

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16231

AFFECTED FILES
  ksmserver/server.h
  ksmserver/startup.cpp
  ksmserver/startup.h

To: davidedmundson, #plasma
Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16231: [ksmserver] Rewrite Startup

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> startup.cpp:194
> +connect(phase1, ::finished, this, [=]() {
> +ksmserver->setupShortcuts(); // done only here, because it needs 
> kglobalaccel :-/
> +});

Can we delay it to finishStartup?

> startup.cpp:210
>  
> -void Startup::autoStart0()
> +void Startup::upAndRunning( const QString& msg )
>  {

It's unused, can we remove it?

> startup.h:39
> +void start() override;
> +private:
>  };

Remove ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16231

To: davidedmundson, #plasma
Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16231: [ksmserver] Rewrite Startup

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  The code is effectively 3 startup phases each of which has some parallel
  methods that need to be complete before moving onto the next phase.
  
  The old code had a tonne of methods all of which tracking what state
  we're in and trying to start the next method in the chain handling
  things out of order.
  
  This simplifies everything into 3 composite kjobs. A lot more classes,
  but each one tiny with the flow more readable.
  
  Code should be effectively the same. The startup sound is moved ever so
  slightly earlier to be when phase 2 starts rather than just after
  kcminit2 finishes (midway through the old phase 2), but no significant
  behavioural changes here.

TEST PLAN
  Logged in with session restore and without

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16231

AFFECTED FILES
  ksmserver/server.h
  ksmserver/startup.cpp
  ksmserver/startup.h

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16081: Fix build with gpsd 3.18

[Antonio Rojas]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:81a0fe6db9ac: Fix build with gpsd 3.18 (authored by 
arojas).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16081?vs=43233=43676

REVISION DETAIL
  https://phabricator.kde.org/D16081

AFFECTED FILES
  dataengines/geolocation/location_gps.cpp

To: arojas, #plasma, davidedmundson
Cc: rdieter, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16225: [ksmserver] Split startup into separate class

[David Edmundson]

davidedmundson updated this revision to Diff 43663.
davidedmundson added a comment.


  Remove unused enum value in startup

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16225?vs=43658=43663

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16225

AFFECTED FILES
  ksmserver/main.cpp
  ksmserver/server.cpp
  ksmserver/server.h
  ksmserver/startup.cpp
  ksmserver/startup.h

To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16219: [Lock Screen] Do not try to unlock when unvisible

[Andres Betts]

abetts added a comment.


  In D16219#343511 , @thsurrel wrote:
  
  > The bug is https://bugs.kde.org/show_bug.cgi?id=395671
  
  
  Thank you guys

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16219

To: thsurrel, #plasma, #vdg
Cc: davidedmundson, abetts, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16219: [Lock Screen] Do not try to unlock when unvisible

[Thomas Surrel]

thsurrel added a comment.


  The bug is https://bugs.kde.org/show_bug.cgi?id=395671

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16219

To: thsurrel, #plasma, #vdg
Cc: davidedmundson, abetts, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16219: [Lock Screen] Do not try to unlock when unvisible

[Andres Betts]

abetts added a comment.


  In D16219#343507 , @davidedmundson 
wrote:
  
  > There's one in the bug report.
  
  
  If this is the bug referenced
  
  https://bugs.kde.org/show_bug.cgi?id=399835
  
  There is no video there

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16219

To: thsurrel, #plasma, #vdg
Cc: davidedmundson, abetts, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16219: [Lock Screen] Do not try to unlock when unvisible

[David Edmundson]

davidedmundson added a comment.


  There's one in the bug report.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16219

To: thsurrel, #plasma, #vdg
Cc: davidedmundson, abetts, filipf, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16219: [Lock Screen] Do not try to unlock when unvisible

[Andres Betts]

abetts added a comment.


  Could you please add a short video or gif showing this problem?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16219

To: thsurrel, #plasma, #vdg
Cc: abetts, filipf, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D16225: [ksmserver] Split startup into separate class

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Everything related to Plasma startup goes in Startup everything relating
  to X session management stays in KSMServer.  Restoring the window
  manager currently stays inside ksmserver as it passes the session ID as
  an argument and at various points checks if something the client is the
  WM.
  Relevant methods move to server.cpp to keep one class per cpp file.
  
  KSMServer gains some signals as it can no longer call the startup methods
  directly to continue the process.
  
  This is part of a cleanup series in ksmserver. (The friend class will 
disappear
  in the next commit)
  
  Behaviour should remain identical.

TEST PLAN
  Logged in on X

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16225

AFFECTED FILES
  ksmserver/main.cpp
  ksmserver/server.cpp
  ksmserver/server.h
  ksmserver/startup.cpp
  ksmserver/startup.h

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16224: move globaltooolbars inside the page

[Marco Martin]

mart created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  hack the Page layouting in order to have 2 levels of headers
  this makes pagerow and layers work ways better
  
  header resizing while page scrolling is starting to work again
  
  hacky fix
  
  needs a way to disable contentY updating for the external invisible
  header
  
  Revert "hacky fix"
  
  This reverts commit ca99e2b3bf55aa4d1f86941ed9a8722432ab61ed 
.
  
  fully fix header resizing
  
  apidocs
  
  fix sizing of toolbars in collapsed pages
  
  adjust anims easiing curves
  
  Merge branch 'master' into mart/innerPageToolBar

REPOSITORY
  R169 Kirigami

BRANCH
  mart/innerPageToolBar

REVISION DETAIL
  https://phabricator.kde.org/D16224

AFFECTED FILES
  src/controls/Page.qml
  src/controls/PageRow.qml
  src/controls/ScrollablePage.qml
  src/controls/private/globaltoolbar/AbstractPageHeader.qml
  src/controls/private/globaltoolbar/PageRowGlobalToolBarStyleGroup.qml
  src/controls/templates/AbstractApplicationHeader.qml

To: mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D15702: User can define margins for the desktop

[Michail Vourlakos]

mvourlakos added inline comments.

INLINE COMMENTS

> davidedmundson wrote in FolderView.qml:1127
> I don't understand this change?

when I tested the patch there was an issue when the user was dragging an applet 
at the edges of the desktop and in areas that now the margins are used. This 
qBound() is trying to only accept x,y values that are valid ones

A case I remember was that a user was dragging an applet at the far right of 
the desktop and the applet was moving at the far left on the opposite side.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15702

To: mvourlakos, #plasma, davidedmundson, mart
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15702: User can define margins for the desktop

[Michail Vourlakos]

mvourlakos added a comment.


  In D15702#343328 , @davidedmundson 
wrote:
  
  > Code wise we already have something to make sure Containments don't overlap 
with hidden panels  (Corona::availableScreenRect) which we override in 
shellcorona, I don't think we need a second one at a different layer.
  
  
  there is also availableScreenRegion that plasma is using when dragging 
applets but how can Latte access them ?
  Only way I thought it would be a dbus protocol and that would make things 
complex.
  
  > UI wise, it seems non-optimial; latte dock users have to take a manual step 
and we get an additionally more complex UI.
  >  Does Latte know the size a user would want?
  
  Latte knows exactly how much space the user wants but I dont know how to 
inform plasma for this.
  
  > Is there a use-case outside latte?
  
  I suppose that all dock implementations fall into the case... such as Plank, 
Cairo dock etc...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15702

To: mvourlakos, #plasma, davidedmundson, mart
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16219: [Lock Screen] Do not try to unlock when unvisible

[Thomas Surrel]

thsurrel added a comment.


  In D16219#343399 , @filipf wrote:
  
  > The new lock screen runs the risk of adding extra steps for the user. This 
is one change that can help the issue because IIRC in Windows you also have a 
double lock screen and pressing Enter will get you to the password prompt; I 
assume the users who have had experience with Windows would expect Plasma to do 
the same, hence the bug reports. I would also suggest to add something like a 
"Type to unlock..." text to the unblurred screen because it's not intuitive 
that the user can just start typing their password, and they should be saved 
from having to move their mouse etc.
  
  
  Could you create a feature request in https://bugs.kde.org/ about the "Type 
to unlock..." label ? That should be done in a separate patch, I believe.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16219

To: thsurrel, #plasma, #vdg
Cc: filipf, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16219: [Lock Screen] Do not try to unlock when unvisible

[Filip Fila]

filipf added a comment.


  The new lock screen runs the risk of adding extra steps for the user. This is 
one change that can help the issue because IIRC in Windows you also have a 
double lock screen and pressing Enter will get you to the password prompt; I 
assume the users who have had experience with Windows would expect Plasma to do 
the same, hence the bug reports. I would also suggest to add something like a 
"Type to unlock..." text to the unblurred screen because it's not intuitive 
that the user can just start typing their password, and they should be saved 
from having to move their mouse etc.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16219

To: thsurrel, #plasma, #vdg
Cc: filipf, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16220: Add feature to save sensor displays as images

[Patrick Flynn]

pflynn created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
pflynn requested review of this revision.

REVISION SUMMARY
  This adds an item to the context menu in the sensor displays with an option 
to save them as a PNG image.  Below are a few example images generated by this 
feature:
  
  F6331143: cpu_history.png 
  
  F6331142: network.png 

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D16220

AFFECTED FILES
  gui/SensorDisplayLib/SensorDisplay.cpp
  gui/SensorDisplayLib/SensorDisplay.h

To: pflynn
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: MOday meeting notes for 15/10/2018

[Marco Martin]

Sorry, missed Johnathan, with the very important announce of the
kickoff meeting:
5.14 is out!
* 5.14.1 tomorrow
* I've been pinging people with ToDo items to get them up to date but
could do with catching up with notmart and maybe others
 ** 5.15 kickoff Wed 17 12:00UTC, 13:00BST, 14:00CEST
https://notes.kde.org/p/plasma-5.15-kickoff
On Mon, Oct 15, 2018 at 12:21 PM Marco Martin  wrote:
>
> David:
> * I spent another day on stupid FF + wayland. I now have the buffer
> issue reproducible in a super simple non-kwin test. Which is progress,
> but not good progress.
> * There's some news on the bug that plasmashell apparently locks up
> and freezes on notifications. It seems it happens with oxygen and the
> SuSE theme, but not breeze. I want to investigate that (probably
> Dialog resize loop, probably dialog resize from contents should all be
> based on implicitsize, not size of contents)
> * At some point I think we need a dialog2; we can do that one right
>
> Vlad:
>  Done:
> * Fixed flickering caused by the Dialog (Windows of type Dialog, not
> Plasma Dialog discussed before) Parent effect;
> * Fixed crashing of the Dim Inactive effect when some application
> creates a window, then closes it, then creates it again;
> * The Fade Desktop effect is no longer fades windows that have been
> moved between virtual desktops, also it now implicitly supports the
> new virtual desktop protocol.
> Under review/Waiting for review:
> * Optimize shadow generation in the Breeze decoration theme; D15514
> Diff 15514 "[libbreezecommon] Use box blur instead of FFT blur"
> [Accepted] https://phabricator.kde.org/D15514
> * Overhaul the Snap Helper effect; D15695
> Diff 15695 "[effects/snaphelper] Do massive overhaul" [Needs
> Review] https://phabricator.kde.org/D15695
> * Simplify code that builds the constrained stacking order. D15893
> Diff 15893 "Generalize constrainedStackingOrder for group
> transients and ordinary transients" [Needs Review]
> https://phabricator.kde.org/D15893
> Currently working on:
> * Still working on the transient stuff. https://bugs.kde.org/397448
>
> Marco:
> 8/10/2018
> Kirigami:
> * new Breadcrumb and TabBar global toolbar implementation that
> deprecate completely old crufty ApplicationHeader
> * Fixed loading of icons on Android for QQC2 controls such as
> Button,ToolButton,MenuItem etc
> * further layout fixes to overlay sheets
> * fixed display of layers headers
> * rework layers animation, looks way smoother now
> * started a rework of pages globalToolBar, still to finish for this
> week, right now on branch mart/innerPageToolBar
> Plasma:
> * multilevel kcm finally completely merged
> * fixed in the virtual desktop branches based on feedback

D16219: [Lock Screen] Do not try to unlock when unvisible

[Thomas Surrel]

thsurrel created this revision.
thsurrel added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
thsurrel requested review of this revision.

REVISION SUMMARY
  In the lock screen, pressing the enter key while the UI is not yet
  visible ends up trying to unlock (and would usually fail because the
  password field is empty).
  Ensure that the UI is visible before unlocking.
  
  BUG: 395671

TEST PLAN
  Lock the session, press enter. The UI should appear without any
  "Unlocking failed" message.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arc_enterpressed (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16219

AFFECTED FILES
  lookandfeel/contents/lockscreen/MainBlock.qml

To: thsurrel, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

MOday meeting notes for 15/10/2018

[Marco Martin]

David:
* I spent another day on stupid FF + wayland. I now have the buffer
issue reproducible in a super simple non-kwin test. Which is progress,
but not good progress.
* There's some news on the bug that plasmashell apparently locks up
and freezes on notifications. It seems it happens with oxygen and the
SuSE theme, but not breeze. I want to investigate that (probably
Dialog resize loop, probably dialog resize from contents should all be
based on implicitsize, not size of contents)
* At some point I think we need a dialog2; we can do that one right

Vlad:
 Done:
* Fixed flickering caused by the Dialog (Windows of type Dialog, not
Plasma Dialog discussed before) Parent effect;
* Fixed crashing of the Dim Inactive effect when some application
creates a window, then closes it, then creates it again;
* The Fade Desktop effect is no longer fades windows that have been
moved between virtual desktops, also it now implicitly supports the
new virtual desktop protocol.
Under review/Waiting for review:
* Optimize shadow generation in the Breeze decoration theme; D15514
Diff 15514 "[libbreezecommon] Use box blur instead of FFT blur"
[Accepted] https://phabricator.kde.org/D15514
* Overhaul the Snap Helper effect; D15695
Diff 15695 "[effects/snaphelper] Do massive overhaul" [Needs
Review] https://phabricator.kde.org/D15695
* Simplify code that builds the constrained stacking order. D15893
Diff 15893 "Generalize constrainedStackingOrder for group
transients and ordinary transients" [Needs Review]
https://phabricator.kde.org/D15893
Currently working on:
* Still working on the transient stuff. https://bugs.kde.org/397448

Marco:
8/10/2018
Kirigami:
* new Breadcrumb and TabBar global toolbar implementation that
deprecate completely old crufty ApplicationHeader
* Fixed loading of icons on Android for QQC2 controls such as
Button,ToolButton,MenuItem etc
* further layout fixes to overlay sheets
* fixed display of layers headers
* rework layers animation, looks way smoother now
* started a rework of pages globalToolBar, still to finish for this
week, right now on branch mart/innerPageToolBar
Plasma:
* multilevel kcm finally completely merged
* fixed in the virtual desktop branches based on feedback

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.11 - Build # 19 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.11/19/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Mon, 15 Oct 2018 09:21:54 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/7)0%
(0/23)0%
(0/23)0%
(0/1827)0%
(0/692)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapp0%
(0/3)0%
(0/3)0%
(0/270)0%
(0/124)app.ToolTips0%
(0/1)0%
(0/1)0%
(0/92)0%
(0/18)classic0%
(0/2)0%
(0/2)0%
(0/190)0%
(0/52)core0%
(0/9)0%
(0/9)0%
(0/505)0%
(0/234)icons0%
(0/3)0%
(0/3)0%
(0/271)0%
(0/52)sidebar0%
(0/4)0%
(0/4)0%
(0/406)0%
(0/190)sidebar.ToolTips0%
(0/1)0%
(0/1)0%
(0/93)0%
(0/22)

D15702: User can define margins for the desktop

[David Edmundson]

davidedmundson added a comment.


  I fully understand we want something. I'm not convinced by this as-is.
  
  Code wise we already have something to make sure Containments don't overlap 
with hidden panels  (Corona::availableScreenRect) which we override in 
shellcorona, I don't think we need a second one at a different layer.
  
  UI wise, it seems non-optimial; latte dock users have to take a manual step 
and we get an additionally more complex UI.
  Does Latte know the size a user would want? Is there a use-case outside latte?

INLINE COMMENTS

> FolderView.qml:1127
> +//! x,y values in acceptable values
> +var boundedX = isContainment ? Math.min(Math.max(cellWidth / 
> 2, x - main.anchors.leftMargin), scrollArea.width - cellWidth / 2) : x;
> +var boundedY = isContainment ? Math.min(Math.max(cellHeight 
> / 2, y - main.anchors.topMargin), scrollArea.height - cellHeight / 2) : y;

I don't understand this change?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15702

To: mvourlakos, #plasma, davidedmundson, mart
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15093: Add WireGuard capability.

[Bruce Anderson]

andersonbruce added a comment.


  Well for the first time since July there has been activity on 
network-manager-wireguard including the addition of an additional parameter 
supported so I am going to get going on adding it to this. Also, it looks like 
the pre- and post- options now do something so against my better judgment I am 
going to add them back in as well.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D15093

To: andersonbruce, #plasma, jgrulich, pino
Cc: acrouthamel, K900, pino, lbeltrame, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16152: [Discover Notifier] Open Updates page in notification

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:f237e7c0ccc8: [Discover Notifier] Open Updates page in 
notification (authored by broulik).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16152?vs=43450=43636

REVISION DETAIL
  https://phabricator.kde.org/D16152

AFFECTED FILES
  notifier/DiscoverNotifier.cpp

To: broulik, #plasma, apol, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16149: [Global Menu Applet] Fix menu layout option being always disabled

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:824279fce904: [Global Menu Applet] Fix menu layout option 
being always disabled (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16149?vs=43439=43635

REVISION DETAIL
  https://phabricator.kde.org/D16149

AFFECTED FILES
  applets/appmenu/package/contents/ui/configGeneral.qml

To: broulik, #plasma, davidedmundson, chinmoyr
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15247: Show tooltips in krunner

[Oleg Solovyov]

McPain added a comment.


  Any ideas how to fix the bugs I mentioned above?

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D15247

To: McPain, #plasma, broulik, ngraham
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart