D16536: [fontinst KCM] Slightly modernize layout
ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The Font Install KCM has a very dated layout. Thisd patch addresses some (but not all) of the aesthetic and usability deficiencies by doing the following: - Eliminate the tools menu and relocate its two items elsewhere - Move the GHNS button to the bottom-right corner, like every other KCM - Put the Scan for Duplicate Fonts... action on the toolbar - Change Add... into Install from File... to match the style of other KCMs TEST PLAN [image goes here] REPOSITORY R119 Plasma Desktop BRANCH kcm-fontint-minor-modernization (branched from master) REVISION DETAIL https://phabricator.kde.org/D16536 AFFECTED FILES kcms/kfontinst/kcmfontinst/KCmFontInst.cpp kcms/kfontinst/kcmfontinst/KCmFontInst.h To: ngraham, #plasma, #vdg Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D16527: Move GHNS button to the normal location
This revision was automatically updated to reflect the committed changes. Closed by commit R123:16328d3aab91: Move GHNS button to the normal location (authored by ngraham). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16527?vs=44492&id=44520 REVISION DETAIL https://phabricator.kde.org/D16527 AFFECTED FILES src/ui/themeconfig.ui To: ngraham, #plasma, #vdg, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D16528: Move GHNS buttons to the normal location for Colors and Emoticons KCMs
This revision was automatically updated to reflect the committed changes. Closed by commit R119:7e4a07d25cc7: Move GHNS buttons to the normal location for Colors and Emoticons KCMs (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16528?vs=44493&id=44521 REVISION DETAIL https://phabricator.kde.org/D16528 AFFECTED FILES kcms/colors/colorsettings.ui kcms/emoticons/emoticonslist.ui To: ngraham, #plasma, #vdg, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D16521: [cuttlefish] Bind StandardKey.Quit (Ctrl+Q) to exit the app
This revision was automatically updated to reflect the committed changes. Closed by commit R118:47e4fa8e5366: [cuttlefish] Bind StandardKey.Quit (Ctrl+Q) to exit the app (authored by Zren). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16521?vs=44472&id=44504 REVISION DETAIL https://phabricator.kde.org/D16521 AFFECTED FILES cuttlefish/package/contents/ui/cuttlefish.qml cuttlefish/src/main.cpp To: Zren, ngraham Cc: ngraham, apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D16066: [ksmserver] Launch logout greeter with DBus methods
This revision was automatically updated to reflect the committed changes. Closed by commit R120:68538b6d451f: [ksmserver] Launch logout greeter with DBus methods (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16066?vs=43205&id=44500#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16066?vs=43205&id=44500 REVISION DETAIL https://phabricator.kde.org/D16066 AFFECTED FILES ksmserver/CMakeLists.txt ksmserver/org.kde.LogoutPrompt.xml ksmserver/server.cpp ksmserver/server.h ksmserver/shutdown.cpp logout-greeter/CMakeLists.txt logout-greeter/greeter.cpp logout-greeter/greeter.h logout-greeter/main.cpp logout-greeter/shutdowndlg.cpp logout-greeter/shutdowndlg.h To: davidedmundson, #plasma, apol Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D16225: [ksmserver] Split startup into separate class
This revision was automatically updated to reflect the committed changes. Closed by commit R120:248dadf49597: [ksmserver] Split startup into separate class (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16225?vs=43663&id=44501#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16225?vs=43663&id=44501 REVISION DETAIL https://phabricator.kde.org/D16225 AFFECTED FILES ksmserver/main.cpp ksmserver/server.cpp ksmserver/server.h ksmserver/startup.cpp ksmserver/startup.h To: davidedmundson, #plasma, graesslin Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D16231: [ksmserver] Rewrite Startup
This revision was automatically updated to reflect the committed changes. Closed by commit R120:96a595f1b860: [ksmserver] Rewrite Startup (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16231?vs=43695&id=44502#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16231?vs=43695&id=44502 REVISION DETAIL https://phabricator.kde.org/D16231 AFFECTED FILES ksmserver/server.h ksmserver/startup.cpp ksmserver/startup.h To: davidedmundson, #plasma, apol Cc: apol, broulik, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D16530: Drop X11 core fonts code from startkde/startplasma
bruns created this revision. bruns added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY Qt and GTK based applications have switched to using fontconfig for fonts exclusively, so this code is mostly unused. As for the remaining legacy X11 applications: - mkfontdir only supports bitmap (e.g. PCF, BDF) fonts. For e.g. truetype fonts, a mkfontscale call would be required. Lack of complaints hints this is not used at all. - the system dirs (sys_odir, sys_fdir) use KDEDIR(S), which is deprecated. The dirs do not exist, thus the fontpath is unchanged. - system dirs are typically allready included in the XServer font path TLDR: (scalable) fonts in user dirs are not picked up due to missing mkfontscale calls, and system dirs are already included. This removes the dependency on xset and mkfontdir. The latter is important, as e.g. on openSUSE the availability of mkfontdir triggers costly, extra setup steps for X Core fonts on package installation. REPOSITORY R120 Plasma Workspace BRANCH drop_x_core_font_support REVISION DETAIL https://phabricator.kde.org/D16530 AFFECTED FILES startkde/startkde.cmake startkde/startplasma.cmake To: bruns, #plasma, fvogt Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D16277: [ksmserver] Split xsession logout and shutdown into separate classes
apol requested changes to this revision.
apol added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> shutdown.cpp:31
> {
> -if ( state != Idle )
> -return;
> -sessionGroup = QStringLiteral( "Session: " ) + session;
> -saveCurrentSession();
> +m_shutdownType = KWorkSpace::ShutdownTypeNone;
> +startLogout();
If you have to set it before calling startLogout(), maybe it would work better
as an argument.
> shutdown.cpp:68
> +QDir dir(shutDownFolder);
> +if (!dir.exists()) {
> continue;
Is it really possible for ::locateAll to return directories that don't exist?
> shutdown.h:1
> +#pragma once
> +
It's missing the license.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D16277
To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, mart
D16231: [ksmserver] Rewrite Startup
davidedmundson added inline comments. INLINE COMMENTS > apol wrote in startup.cpp:275 > can't this be `&KJob::emitResult`? It's stupid: I can do connect(watch, SIGNAL(finished()), this, SLOT(emitResult())); but not with function pointers because: error: 'emitResult' is a protected member of 'KJob' connect(watcher, &QDBusPendingCallWatcher::finished, this, &KJob::emitResult); REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D16231 To: davidedmundson, #plasma, apol Cc: apol, broulik, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D14542: KCM using new virtual desktops DBus interface
hein added a comment. Should be OK now REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D14542 To: hein, mart, davidedmundson, ltoscano, zzag Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D14542: KCM using new virtual desktops DBus interface
hein updated this revision to Diff 44498. hein added a comment. Try to remove Marco's revision REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14542?vs=44095&id=44498 BRANCH arcpatch-D14542_1 REVISION DETAIL https://phabricator.kde.org/D14542 AFFECTED FILES kcmkwin/kwindesktop/CMakeLists.txt kcmkwin/kwindesktop/Messages.sh kcmkwin/kwindesktop/desktop.desktop kcmkwin/kwindesktop/desktopnameswidget.cpp kcmkwin/kwindesktop/desktopnameswidget.h kcmkwin/kwindesktop/desktopsmodel.cpp kcmkwin/kwindesktop/desktopsmodel.h kcmkwin/kwindesktop/kcm_kwin_virtualdesktops.desktop kcmkwin/kwindesktop/main.cpp kcmkwin/kwindesktop/main.h kcmkwin/kwindesktop/main.ui kcmkwin/kwindesktop/package/contents/ui/main.qml kcmkwin/kwindesktop/package/metadata.desktop kcmkwin/kwindesktop/virtualdesktops.cpp kcmkwin/kwindesktop/virtualdesktops.h To: hein, mart, davidedmundson, ltoscano, zzag Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D16231: [ksmserver] Rewrite Startup
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
+1 LGTM
INLINE COMMENTS
> startup.cpp:275
> QDBusPendingCallWatcher *watcher = new QDBusPendingCallWatcher(pending,
> this);
> -QObject::connect(watcher, &QDBusPendingCallWatcher::finished, this,
> &Startup::secondKDEDPhaseLoaded);
> +QObject::connect(watcher, &QDBusPendingCallWatcher::finished, this,
> [this]() {emitResult();});
> QObject::connect(watcher, &QDBusPendingCallWatcher::finished, watcher,
> &QObject::deleteLater);
can't this be `&KJob::emitResult`?
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16231
To: davidedmundson, #plasma, apol
Cc: apol, broulik, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D16375: fix warnings
This revision was automatically updated to reflect the committed changes. Closed by commit R169:96aa15d1: fix warnings (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16375?vs=44077&id=44497 REVISION DETAIL https://phabricator.kde.org/D16375 AFFECTED FILES src/controls/GlobalDrawer.qml src/controls/private/BannerImage.qml To: apol, #kirigami, mart Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein
D16066: [ksmserver] Launch logout greeter with DBus methods
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. This looks really good! REPOSITORY R120 Plasma Workspace BRANCH ksmserver_split REVISION DETAIL https://phabricator.kde.org/D16066 To: davidedmundson, #plasma, apol Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D16528: Move GHNS buttons to the normal location for Icons and Emoticons KCMs
ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch moves the GHNS button to the bottom-right corner for the Icons and Emoticons KCMs, to match nearly all other KCMs. TEST PLAN [images go here] REPOSITORY R119 Plasma Desktop BRANCH ghns-button-in-a-consistent-location (branched from master) REVISION DETAIL https://phabricator.kde.org/D16528 AFFECTED FILES kcms/colors/colorsettings.ui kcms/emoticons/emoticonslist.ui To: ngraham, #plasma, #vdg Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D16527: Move GHNS button to the normal location
ngraham updated this revision to Diff 44492. ngraham added a comment. Tweaks REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16527?vs=44491&id=44492 BRANCH ghns-button-in-a-consistent-location (branched from master) REVISION DETAIL https://phabricator.kde.org/D16527 AFFECTED FILES src/ui/themeconfig.ui To: ngraham, #plasma, #vdg Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D16527: Move GHNS button to the normal location
ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch moves the GHNS button to the bottom-right corner, where it is for nearly all other KCMs. TEST PLAN [image goes here] REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH ghns-button-in-a-consistent-location (branched from master) REVISION DETAIL https://phabricator.kde.org/D16527 AFFECTED FILES src/ui/themeconfig.ui To: ngraham, #plasma, #vdg Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D16504: [KCMs] Use consistent text for GHNS buttons
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:ae36781b332a: [KCMs] Use consistent text for GHNS buttons (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16504?vs=44401&id=44489 REVISION DETAIL https://phabricator.kde.org/D16504 AFFECTED FILES doc/kcontrol/colors/index.docbook doc/kcontrol/desktopthemedetails/index.docbook doc/kcontrol/emoticons/index.docbook doc/kcontrol/fontinst/index.docbook doc/kcontrol/icons/index.docbook doc/kcontrol/splashscreen/index.docbook kcms/colors/colorsettings.ui kcms/cursortheme/package/contents/ui/main.qml kcms/desktoptheme/package/contents/ui/main.qml kcms/emoticons/emoticonslist.ui kcms/icons/package/contents/ui/main.qml kcms/ksplash/package/contents/ui/main.qml kcms/lookandfeel/package/contents/ui/main.qml To: ngraham, #plasma, #vdg Cc: broulik, Codezela, abetts, plasma-devel, kde-doc-english, ragreen, Pitel, ZrenBot, skadinna, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
D16503: Use consistent text for the GHNS button
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R123:474b5d16b566: Use consistent text for the GHNS button (authored by ngraham). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16503?vs=44400&id=44488 REVISION DETAIL https://phabricator.kde.org/D16503 AFFECTED FILES src/ui/themeconfig.ui To: ngraham, #plasma, #vdg Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
