[kio-extras] [Bug 329687] previewing an HTML file from a local file system causes network retrievals while generating the thumbnail

[Stefan Brüns]

https://bugs.kde.org/show_bug.cgi?id=329687

Stefan Brüns  changed:

   What|Removed |Added

 CC||stefan.bruens@rwth-aachen.d
   ||e
 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Stefan Brüns  ---
The HTML thumbnailer has been removed completely:
https://phabricator.kde.org/D15095

-- 
You are receiving this mail because:
You are the assignee for the bug.

D17233: Only cancel job when an "error" is set and ignore "interrupted"

[Fabian Vogt]

fvogt added a comment.


  LGTM otherwise.

INLINE COMMENTS

> downloadjob.cpp:152
> +const QString error = it->toString();
> +if (!error.isEmpty()) {
>  if (error == QLatin1String("USER_CANCELED")

You could change this into

  QString error = payload.value(QStringLiteral("error")).toString();
  if(!error.isEmpty())

> downloadjob.cpp:207
> +
> +it = payload.constFind(QStringLiteral("state"));
> +if (it != end) {

Same here as for error above.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D17233

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

[Nathaniel Graham]

ngraham added a comment.


  In D16031#368953 , @raddison wrote:
  
  > I've also looked at the test plan and it's not exactly a stroke of genius 
if it looks like 
https://phabricator.kde.org/file/data/w3iyc7eov3ys6kmhrwi7/PHID-FILE-nya3nyqpjbmnijijvlwm/Screenshot_20181129_233236.png
  
  
  You have two options:
  
  - Stop insulting people and their work
  - Go away
  
  Coming up with realistic solutions to difficult and controversial issues is 
hard. We have gone over a bunch of different designs and all of them have 
strengths and weaknesses. You are welcome to propose alternatives in T9658 
, but please do it with respect. Thanks.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma, rizzitello, davidedmundson
Cc: raddison, romangg, davidedmundson, rizzitello, abetts, pstefan, broulik, 
rikmills, filipf, rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17268: Fix warning

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  .../kirigami.2/templates/AbstractApplicationHeader.qml:113: TypeError: Cannot 
read property 'globalToolBarItem' of null
  .../kirigami.2/templates/AbstractApplicationHeader.qml:114: TypeError: Cannot 
read property 'globalToolBarItem' of null

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17268

AFFECTED FILES
  src/controls/templates/AbstractApplicationHeader.qml

To: apol, #kirigami
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

[Richard Addison]

raddison added a comment.


  In D16031#368865 , @ngraham wrote:
  
  > In D16031#368861 , @raddison 
wrote:
  >
  > > @ngraham Is it going to look something like that? 
https://phabricator.kde.org/file/data/zaerjwktbynwubnvu3ja/PHID-FILE-y52h6nwujyugxuqkc73z/maxresdefault.jpg
  >
  >
  > No, screenshots for the current proposal are in the Test Plan section of 
this patch. The image you're referring to was the old Plasma 5 design that was 
replaced in Plasma 5.8. I would support going back to that style of design 
because it solves virtually all of the problems here. But so far there doesn't 
seem to be a lot of enthusiasm for that. The
  
  
  Truth to tell neither am I enthused about the old Plasma 5 design. 
  I've also looked at the test plan and it's not exactly a stroke of genius if 
it looks like 
https://phabricator.kde.org/file/data/w3iyc7eov3ys6kmhrwi7/PHID-FILE-nya3nyqpjbmnijijvlwm/Screenshot_20181129_233236.png

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma, rizzitello, davidedmundson
Cc: raddison, romangg, davidedmundson, rizzitello, abetts, pstefan, broulik, 
rikmills, filipf, rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17263: DelegateRecycler: Don't create a new propertiesTracker for every delegate

[Aleix Pol Gonzalez]

apol closed this revision.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D17263

To: apol, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17263: DelegateRecycler: Don't create a new propertiesTracker for every delegate

[Aleix Pol Gonzalez]

apol updated this revision to Diff 46572.
apol added a comment.


  Clean after destruction

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17263?vs=46571=46572

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17263

AFFECTED FILES
  src/delegaterecycler.cpp

To: apol, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17263: DelegateRecycler: Don't create a new propertiesTracker for every delegate

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  It should make setSourceComponent a bit lighter

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17263

AFFECTED FILES
  src/delegaterecycler.cpp

To: apol, #kirigami
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

[Nathaniel Graham]

ngraham added a comment.


  In D16031#368861 , @raddison wrote:
  
  > @ngraham Is it going to look something like that? 
https://phabricator.kde.org/file/data/zaerjwktbynwubnvu3ja/PHID-FILE-y52h6nwujyugxuqkc73z/maxresdefault.jpg
  
  
  No, screenshots for the current proposal are in the Test Plan section of this 
patch. The image you're referring to was the old Plasma 5 design that was 
replaced in Plasma 5.8. I would support going back to that style of design 
because it solves virtually all of the problems here. But so far there doesn't 
seem to be a lot of enthusiasm for that. The

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma, rizzitello, davidedmundson
Cc: raddison, romangg, davidedmundson, rizzitello, abetts, pstefan, broulik, 
rikmills, filipf, rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

[Richard Addison]

raddison added a comment.


  In D16031#368787 , @ngraham wrote:
  
  > In D16031#368739 , @raddison 
wrote:
  >
  > > > Still I find the original version with full blur and darkened 
background way better to read for many background pictures. I don't think it's 
wort it to sacrifice this usability factor to allow a better view of the 
background.
  > >
  > > I think the same. Sacrificing the blur would result in dullness without 
any significant benefit.
  > >
  > > > Instead would it be possible to have a similar timeout for hiding the 
controls and unblurring as for the lockscreen (with visible controls and blur 
in the beginning)?
  > >
  > > Yep, that would be great because it would result in a cohesive visual 
experience.
  > >
  > > @romangg +1
  >
  >
  > I addressed all of that already: https://phabricator.kde.org/D16031#354282
  
  
  @ngraham Is it going to look something like that? 
https://phabricator.kde.org/file/data/zaerjwktbynwubnvu3ja/PHID-FILE-y52h6nwujyugxuqkc73z/maxresdefault.jpg

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma, rizzitello, davidedmundson
Cc: raddison, romangg, davidedmundson, rizzitello, abetts, pstefan, broulik, 
rikmills, filipf, rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

[Nathaniel Graham]

ngraham added a comment.


  In D16031#368739 , @raddison wrote:
  
  > > Still I find the original version with full blur and darkened background 
way better to read for many background pictures. I don't think it's wort it to 
sacrifice this usability factor to allow a better view of the background.
  >
  > I think the same. Sacrificing the blur would result in dullness without any 
significant benefit.
  >
  > > Instead would it be possible to have a similar timeout for hiding the 
controls and unblurring as for the lockscreen (with visible controls and blur 
in the beginning)?
  >
  > Yep, that would be great because it would result in a cohesive visual 
experience.
  >
  > @romangg +1
  
  
  I addressed all of that already: https://phabricator.kde.org/D16031#354282

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma, rizzitello, davidedmundson
Cc: raddison, romangg, davidedmundson, rizzitello, abetts, pstefan, broulik, 
rikmills, filipf, rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

[Richard Addison]

raddison added a comment.


  > Still I find the original version with full blur and darkened background 
way better to read for many background pictures. I don't think it's wort it to 
sacrifice this usability factor to allow a better view of the background.
  
  I think the same. Sacrificing the blur would result in dullness without any 
significant benefit.
  
  > Instead would it be possible to have a similar timeout for hiding the 
controls and unblurring as for the lockscreen (with visible controls and blur 
in the beginning)?
  
  Yep, that that would be great because it would result in a cohesive visual 
experience.
  
  @romangg +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma, rizzitello, davidedmundson
Cc: raddison, romangg, davidedmundson, rizzitello, abetts, pstefan, broulik, 
rikmills, filipf, rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

[Eike Hein]

hein updated this revision to Diff 46554.
hein added a comment.


  Handle KWin restarts

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14542?vs=46551=46554

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14542

AFFECTED FILES
  kcmkwin/kwindesktop/CMakeLists.txt
  kcmkwin/kwindesktop/Messages.sh
  kcmkwin/kwindesktop/desktop.desktop
  kcmkwin/kwindesktop/desktopnameswidget.cpp
  kcmkwin/kwindesktop/desktopnameswidget.h
  kcmkwin/kwindesktop/desktopsmodel.cpp
  kcmkwin/kwindesktop/desktopsmodel.h
  kcmkwin/kwindesktop/kcm_kwin_virtualdesktops.desktop
  kcmkwin/kwindesktop/main.cpp
  kcmkwin/kwindesktop/main.h
  kcmkwin/kwindesktop/main.ui
  kcmkwin/kwindesktop/package/contents/ui/main.qml
  kcmkwin/kwindesktop/package/metadata.desktop
  kcmkwin/kwindesktop/virtualdesktops.cpp
  kcmkwin/kwindesktop/virtualdesktops.h

To: hein, mart, davidedmundson, ltoscano, zzag
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D16873: [comic] Request current identifier on date changed

[Anthony Fieroni]

anthonyfieroni added a comment.


  Ping

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16873

To: anthonyfieroni, #plasma, davidedmundson, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16856: [comic] Sync configuration on write

[Anthony Fieroni]

anthonyfieroni added a comment.


  Ping

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16856

To: anthonyfieroni, #plasma, davidedmundson
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

[Eike Hein]

hein updated this revision to Diff 46551.
hein added a comment.


  Rebase on master for good measure

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14542?vs=46545=46551

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14542

AFFECTED FILES
  kcmkwin/kwindesktop/CMakeLists.txt
  kcmkwin/kwindesktop/Messages.sh
  kcmkwin/kwindesktop/desktop.desktop
  kcmkwin/kwindesktop/desktopnameswidget.cpp
  kcmkwin/kwindesktop/desktopnameswidget.h
  kcmkwin/kwindesktop/desktopsmodel.cpp
  kcmkwin/kwindesktop/desktopsmodel.h
  kcmkwin/kwindesktop/kcm_kwin_virtualdesktops.desktop
  kcmkwin/kwindesktop/main.cpp
  kcmkwin/kwindesktop/main.h
  kcmkwin/kwindesktop/main.ui
  kcmkwin/kwindesktop/package/contents/ui/main.qml
  kcmkwin/kwindesktop/package/metadata.desktop
  kcmkwin/kwindesktop/virtualdesktops.cpp
  kcmkwin/kwindesktop/virtualdesktops.h

To: hein, mart, davidedmundson, ltoscano, zzag
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

[Eike Hein]

hein updated this revision to Diff 46545.
hein added a comment.


  Fix syncing to server.
  
  Fixes take various shapes:
  
  - Fix bug on our side.
  - Handle weird KWin behavior, such as emiting desktopRowsChanged with an 
unchanged value.
  - s/onAccepted/onEditingFinished on the rename TextField, otherwise focus 
loss keeps the changed text but doesn't light up Apply.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14542?vs=44673=46545

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14542

AFFECTED FILES
  kcmkwin/kwindesktop/CMakeLists.txt
  kcmkwin/kwindesktop/Messages.sh
  kcmkwin/kwindesktop/desktop.desktop
  kcmkwin/kwindesktop/desktopnameswidget.cpp
  kcmkwin/kwindesktop/desktopnameswidget.h
  kcmkwin/kwindesktop/desktopsmodel.cpp
  kcmkwin/kwindesktop/desktopsmodel.h
  kcmkwin/kwindesktop/kcm_kwin_virtualdesktops.desktop
  kcmkwin/kwindesktop/main.cpp
  kcmkwin/kwindesktop/main.h
  kcmkwin/kwindesktop/main.ui
  kcmkwin/kwindesktop/package/contents/ui/main.qml
  kcmkwin/kwindesktop/package/metadata.desktop
  kcmkwin/kwindesktop/virtualdesktops.cpp
  kcmkwin/kwindesktop/virtualdesktops.h

To: hein, mart, davidedmundson, ltoscano, zzag
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D17233: Only cancel job when an "error" is set and ignore "interrupted"

[Kai Uwe Broulik]

broulik updated this revision to Diff 46536.
broulik retitled this revision from "Delay finishing download when state 
changes to "interrupted"" to "Only cancel job when an "error" is set and ignore 
"interrupted"".
broulik edited the summary of this revision.
broulik edited the test plan for this revision.

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17233?vs=46474=46536

REVISION DETAIL
  https://phabricator.kde.org/D17233

AFFECTED FILES
  host/downloadjob.cpp

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart