D17360: Added "Transparent with light text" theme for Desktop Notes

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:0230b5f5e332: Added Transparent with light 
text theme for Desktop Notes (authored by IamMaxim, committed by ngraham).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17360?vs=46870=46929

REVISION DETAIL
  https://phabricator.kde.org/D17360

AFFECTED FILES
  applets/notes/package/contents/ui/configAppearance.qml
  applets/notes/package/contents/ui/main.qml

To: IamMaxim, #plasma, davidedmundson
Cc: shubham, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17375: Don't automatically refresh if the user already asked apt to do so

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Kubuntu, sitter, rikmills.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Just expect apt to do the right thing.
  
  BUG: 401810

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17375

AFFECTED FILES
  libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp

To: apol, #kubuntu, sitter, rikmills
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[David Edmundson]

davidedmundson added a comment.


  > Local workarounds for toolkit bugs are ..
  
  I fully 100% agree on that principle, but in this specific case from my tech 
POV, option 1 is fine too.
  
  Sizing items is typically in the jurisdiction of the app using the component 
rather than the component itself - as long as you stay above the minimum size 
hints from the component. 
  This patch would, it's akin to doing QWidget::setHorizontalSizePolicy(Minimum)
  
  I don't have an opinion on which is better UI.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, 
#plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, mbohlender, mart

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Björn Feber]

GB_2 added a comment.


  Ok, number two then.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, 
IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Nathaniel Graham]

ngraham added a comment.


  In D17323#371825 , @GB_2 wrote:
  
  > 2. Align "Height/Width" button contents on the left side F6458265: Panel 
Edit Mode Buttons (2).png 
  
  
  This is the choice that basically just uses the button's default appearance 
rather than locally overriding anything, right? If so, I would prefer this 
approach. Local workarounds for toolkit bugs are almost never worth it when you 
own and control the toolkit IMHO.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, 
IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Björn Feber]

GB_2 added a comment.


  Because https://phabricator.kde.org/D17355 is currently not working properly, 
we have two options:
  
  1. Small "Height/Width" button
  
  F6458263: Panel Edit Mode Buttons (1).png 

  
  2. Align "Height/Width" button contents on the left side
  
  F6458265: Panel Edit Mode Buttons (2).png 

  
  And yes, I will still add the tooltip.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, 
IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

[Eike Hein]

hein added a comment.


  I'm no longer aware of bugs in this, please re-review it.
  
  Please have the latest version of @mart's D17265 
 applied or you may encounter weirdness 
from KWin's side.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson, ltoscano, zzag
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

[Eike Hein]

hein updated this revision to Diff 46916.
hein added a comment.


  Further fixes to sync & co
  
  - Adding a desktop could emit wrong model transactions (wrong container count 
was used to calculate append index).
  - `updateModifiedState` (previously `checkModifiedState`) now handles cases 
where desktop counts and names remained the same despite the user triggering 
with remove/add actions. This can happen when removing a desktop retaining the 
default name and adding a desktop back, for example. In this case the method 
will replace dummy with server ids so that the data structures match again, 
then avoid doing a sync to the server and disable the Apply button.
  - During sync, when syncing ids replace any dummy ids with server ids in the 
data structures. For cases similar to above - a desktop was replaced with an 
identically-named one, and is not handled by a remove/create -, otherwise the 
following block will emit setDesktopName D-Bus calls with invalid ids.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14542?vs=46895=46916

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14542

AFFECTED FILES
  kcmkwin/kwindesktop/CMakeLists.txt
  kcmkwin/kwindesktop/Messages.sh
  kcmkwin/kwindesktop/desktop.desktop
  kcmkwin/kwindesktop/desktopnameswidget.cpp
  kcmkwin/kwindesktop/desktopnameswidget.h
  kcmkwin/kwindesktop/desktopsmodel.cpp
  kcmkwin/kwindesktop/desktopsmodel.h
  kcmkwin/kwindesktop/kcm_kwin_virtualdesktops.desktop
  kcmkwin/kwindesktop/main.cpp
  kcmkwin/kwindesktop/main.h
  kcmkwin/kwindesktop/main.ui
  kcmkwin/kwindesktop/package/contents/ui/main.qml
  kcmkwin/kwindesktop/package/metadata.desktop
  kcmkwin/kwindesktop/virtualdesktops.cpp
  kcmkwin/kwindesktop/virtualdesktops.h

To: hein, mart, davidedmundson, ltoscano, zzag
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Right now the componentchooser KCM's browser module has a really confusing 
setting ("In an application based on the contents of the url") that's the 
default. There are ancient Buzailla tickets about this being confusing, and 
some users report that it actually does the wrong thing for certain URLs.
  
  This patch removes the UI for this feature and makes it a hidden 
fallback-only behavior for the rare case that there aren't any web browsers 
installed.
  
  BUG: 100016
  FIXED-IN: 5.15.0

TEST PLAN
  Here's what it looks like now:
  
  Verifications performed:
  
  - There are no actual settings changes for any users, since browsers ask to 
set themselves as the default, and distros ship config files already specifying 
their preferred browser.
  - Changing the browser in the combobox correctly updates both 
`~/.config/kdeglobals` and `~/.configmimeapps.list`
  - The combobox's default setting is now correctly identical to what 
`~/.config/mimeapps.list` specifies, if anything
  - KRun still does unnecessary URL introspection when there is in fact a 
default browser set in `~/.config/mimeapps.list` but ~/.config/kdeglobals` 
doesn't have a default browser set, which is fixed separately in KIO with 
D17371 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  browser-chooser-service-and-exec-only (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17372

AFFECTED FILES
  kcms/componentchooser/browserconfig_ui.ui
  kcms/componentchooser/componentchooserbrowser.cpp

To: ngraham, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17365: Round label width

[Fabian Vogt]

fvogt added a comment.


  > Hmm, the "After" pictured depicts terrible kerning. Take a look at 
"Discover" in particular. Is this really the trade-off we're faced with? It 
feels like there are upstream Qt bugs here.
  
  Yup, definitely. Font rendering in QML has some issues.
  
  FreeType hinting configuration and especially the used font can make a huge 
difference though. With "Roboto" for example it looks perfectly fine.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17365

To: fvogt, #plasma, broulik
Cc: ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17365: Round label width

[Nathaniel Graham]

ngraham added a comment.


  Hmm, the "After" pictured depicts terrible kerning. Take a look at "Discover" 
in particular. Is this really the trade-off we're faced with? It feels like 
there are upstream Qt bugs here.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17365

To: fvogt, #plasma, broulik
Cc: ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

[Vlad Zagorodniy]

zzag added a comment.


  Some issues that I saw while testing this patch:
  
  - with 2 rows and 6 virtual desktop, I get the following desktop layout (is 
it a bug in KWin core?)
  
+---+---+---+---+---+
|   |   |   |   |   |
+---+---+---+---+---+
|   |
+---+
  
  - if any virtual desktop is removed, then System Settings window will be sent 
to the last virtual desktop.

INLINE COMMENTS

> desktopsmodel.h:51
> + *
> + * After synchronization, the model tracks Kwin-side changes again,
> + * until the user makes further changes.

*KWin-side

> desktopsmodel.h:119-124
> +QStringList m_serverSideDesktops;
> +QHash m_serverSideNames;
> +int m_serverSideRows;
> +QStringList m_desktops;
> +QHash m_names;
> +int m_rows;

For better readability, you could create a struct to represent the state on 
both sides, e.g.:

  struct State
  {
  QStringList desktops;
  QHash names;
  int rows;
  };
  
  State m_clientState;
  State m_serverState;

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson, ltoscano, zzag
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

[Alex Debus]

alexde added a comment.


  I would like to introduce another suggestion, which has not yet came up: If 
you don't want to blur everything, how about to only blur an rectangle 
underneath the login controls. That means a combination of early Plasma 5
  
  > The early Plasma 5 login screen put a dark translucent rectangle underneath 
the foreground elements, which worked just fine
  
  and the current one + the enhanced contrast:
  
  F6457437: Screenshot_20181129_233135.png 

  I am sorry that this a pretty bad mockup, but Gimp works completely 
counterintuitive to me. Otherwise it'd look better and there were round 
corners. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma, rizzitello, davidedmundson
Cc: alexde, raddison, romangg, davidedmundson, rizzitello, abetts, pstefan, 
broulik, rikmills, filipf, rooty, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

[Eike Hein]

hein updated this revision to Diff 46895.
hein added a comment.


  Revamp KWin restart handling
  
  The way a KWin restart is handled is now the same as the general
  "stay in sync with server if the user didn't make changes, other-
  wise stick to the user state and notify about the server-side
  change" approach:
  
  - User changes are now kept and not thrown away
  - When KWin restarts the old and the new server state are compared, and if 
the user had made any changes, the model notifies about any difference

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14542?vs=46554=46895

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14542

AFFECTED FILES
  kcmkwin/kwindesktop/CMakeLists.txt
  kcmkwin/kwindesktop/Messages.sh
  kcmkwin/kwindesktop/desktop.desktop
  kcmkwin/kwindesktop/desktopnameswidget.cpp
  kcmkwin/kwindesktop/desktopnameswidget.h
  kcmkwin/kwindesktop/desktopsmodel.cpp
  kcmkwin/kwindesktop/desktopsmodel.h
  kcmkwin/kwindesktop/kcm_kwin_virtualdesktops.desktop
  kcmkwin/kwindesktop/main.cpp
  kcmkwin/kwindesktop/main.h
  kcmkwin/kwindesktop/main.ui
  kcmkwin/kwindesktop/package/contents/ui/main.qml
  kcmkwin/kwindesktop/package/metadata.desktop
  kcmkwin/kwindesktop/virtualdesktops.cpp
  kcmkwin/kwindesktop/virtualdesktops.h

To: hein, mart, davidedmundson, ltoscano, zzag
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D17367: Update Void Linux URL in README.md

[John Zimmermann]

johnz created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
johnz requested review of this revision.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D17367

AFFECTED FILES
  README.md

To: johnz
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

[Richard Addison]

raddison added a comment.


  > This patch adjusts the Breeze SDDM theme to remove the 
semi-permanently-blurred background, which has not been especially popular.
  
  Please produce methodological evidence of its unpopularity.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma, rizzitello, davidedmundson
Cc: raddison, romangg, davidedmundson, rizzitello, abetts, pstefan, broulik, 
rikmills, filipf, rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17217: Implement free memory notifier

[Oleg Solovyov]

McPain updated this revision to Diff 46892.
McPain added a comment.


  Default limit: 25% -> 10%
  Fix typos
  Auto detect swap, removed "includeSwap" setting
  KSysGuard: show kill button (implemented in D17366 
)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17217?vs=46407=46892

REVISION DETAIL
  https://phabricator.kde.org/D17217

AFFECTED FILES
  plasma-workspace/CMakeLists.txt
  plasma-workspace/freememorynotifier/CMakeLists.txt
  plasma-workspace/freememorynotifier/COPYING
  plasma-workspace/freememorynotifier/Messages.sh
  plasma-workspace/freememorynotifier/README
  plasma-workspace/freememorynotifier/freememorynotifier.cpp
  plasma-workspace/freememorynotifier/freememorynotifier.desktop
  plasma-workspace/freememorynotifier/freememorynotifier.h
  plasma-workspace/freememorynotifier/freememorynotifier.kcfg
  plasma-workspace/freememorynotifier/freememorynotifier.notifyrc
  plasma-workspace/freememorynotifier/freememorynotifier_prefs_base.ui
  plasma-workspace/freememorynotifier/kcm_freememorynotifier.cpp
  plasma-workspace/freememorynotifier/kcm_freememorynotifier.desktop
  plasma-workspace/freememorynotifier/kcm_freememorynotifier.h
  plasma-workspace/freememorynotifier/module.cpp
  plasma-workspace/freememorynotifier/module.h
  plasma-workspace/freememorynotifier/org.kde.FreeMemoryNotifier.xml
  plasma-workspace/freememorynotifier/settings.kcfgc
  plasma-workspace/systemmonitor/ksystemactivitydialog.cpp
  plasma-workspace/systemmonitor/ksystemactivitydialog.h
  plasma-workspace/systemmonitor/main.cpp

To: McPain, broulik, #vdg, ngraham
Cc: davidedmundson, graesslin, abetts, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17366: Implement "Kill" button when sysguard was invoked from freememorynotifier

[Oleg Solovyov]

McPain created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.

REVISION SUMMARY
  If ksysguard was invoked from freememorynotifier directly, every process is 
displayed with its own kill button.
  In most "OOM-risky" cases it is required to kill one and only one process.
  
  Clicking on his own "Kill" button is cheaper than selecting it from list and 
clicking the main "Kill" button (2 clicks > 1 click)
  Also, you cannot hide this column by accident or show it when invoked by 
hotkey (Ctrl+Esc by default).
  
  Since it's invoked with --ignore-config option I implemented earlier (D17217 
) any layout changes won't be stored in 
config.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D17366

AFFECTED FILES
  libksysguard/processui/ProcessModel.cpp
  libksysguard/processui/ProcessModel.h
  libksysguard/processui/ksysguardprocesslist.cpp
  libksysguard/processui/ksysguardprocesslist.h

To: McPain
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17217: Implement free memory notifier

[Oleg Solovyov]

McPain added a comment.


  In D17217#367842 , @davidedmundson 
wrote:
  
  > There's also an alternative that I'd like to suggest:
  >  According to https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt 
there's a system called "memory pressure" you can watch for events on a 
specific FD with various levels of out-of-memory-ness. A lot cheaper than 
polling, far more reliable, and following the system's OOM configuration. 
Getting that in at a frameworks level so it can be hooked up to notifications 
in this case, but also garbage collections in UI code could be pretty cool.
  
  
  Thanks. Any examples in KDE? I can't implement this from scratch right now.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17217

To: McPain, broulik, #vdg, ngraham
Cc: davidedmundson, graesslin, abetts, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17360: Added "Transparent with light text" theme for Desktop Notes

[Shubham]

shubham added a comment.


  Congrats on your first patch.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D17360

To: IamMaxim, #plasma, davidedmundson
Cc: shubham, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.11 - Build # 109 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.11/109/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Wed, 05 Dec 2018 09:55:40 +
 Build duration:
4 min 8 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeStarted by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] nodeStill waiting to schedule taskWaiting for next available executor on ‘FreeBSDQt5.11’Running on FreeBSD Builder 3 in /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.11[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] checkoutCloning the remote Git repositoryCloning repository git://anongit.kde.org/plasma-desktop > git init /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.11 # timeout=10Fetching upstream changes from git://anongit.kde.org/plasma-desktop > git --version # timeout=10 > git fetch --tags --progress git://anongit.kde.org/plasma-desktop +refs/heads/*:refs/remotes/origin/* # timeout=120ERROR: Error cloning remote repo 'origin'hudson.plugins.git.GitException: Command "git fetch --tags --progress git://anongit.kde.org/plasma-desktop +refs/heads/*:refs/remotes/origin/*" returned status code 128:stdout: stderr: fatal: read error: Connection reset by peer	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2016)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1735)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:72)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:420)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:629)	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153)	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146)	at hudson.remoting.UserRequest.perform(UserRequest.java:212)	at hudson.remoting.UserRequest.perform(UserRequest.java:54)	at hudson.remoting.Request$2.run(Request.java:369)	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)	at java.util.concurrent.FutureTask.run(FutureTask.java:266)	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)	at java.lang.Thread.run(Thread.java:748)	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to FreeBSD Builder 3		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357)		at hudson.remoting.Channel.call(Channel.java:955)		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)		at sun.reflect.GeneratedMethodAccessor300.invoke(Unknown Source)		at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)		at java.lang.reflect.Method.invoke(Method.java:498)		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)		at com.sun.proxy.$Proxy79.execute(Unknown Source)		at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1146)		at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186)		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:120)		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:90)		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:77)		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1$1.call(SynchronousNonBlockingStepExecution.java:50)		at hudson.security.ACL.impersonate(ACL.java:290)		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1.run(SynchronousNonBlockingStepExecution.java:47)		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)		... 4 more[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: Error cloning remote repo 'origin'[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

D17365: Round label width

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:3526334e8234: Round label width (authored by fvogt).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17365?vs=46884=46886

REVISION DETAIL
  https://phabricator.kde.org/D17365

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: fvogt, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17365: Round label width

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Cool! Stable branch pls

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17365

To: fvogt, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17365: Round folder view delegate and label positions

[Fabian Vogt]

fvogt updated this revision to Diff 46884.
fvogt added a comment.


  Turns out the label width rounding is enough

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17365?vs=46882=46884

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17365

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: fvogt, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17365: Round folder view delegate and label positions

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> broulik wrote in FolderItemDelegate.qml:66
> That's what this hideous code is actually supposed to do

It doesn't work though - I'll check some more.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17365

To: fvogt, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17365: Round folder view delegate and label positions

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> FolderItemDelegate.qml:66
>  // leading to blurry rendering. The Loader is offset to account for 
> this.
>  x: -main.x % 1
>  y: -main.y % 1

That's what this hideous code is actually supposed to do

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17365

To: fvogt, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17365: Round folder view delegate and label positions

[Fabian Vogt]

fvogt created this revision.
fvogt added a reviewer: Plasma.
Herald added a project: Plasma.
fvogt requested review of this revision.

REVISION SUMMARY
  Currently the delegates and especially the labels can be at non-integer
  positions. This results in ugly font rendering.

TEST PLAN
  Before/after: https://phabricator.kde.org/F6456830

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17365

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml
  containments/desktop/package/contents/ui/FolderView.qml

To: fvogt, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart