D17829: Make sure we don't override QIcon::themeName when we should not
apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY KirigamiPlugin is lives in a separate thread than QApplication and themeName initialization is a race condition. This way at least we limit the initialisation to non-linux desktop systems. TEST PLAN Now kalgebramobile and kirigamigallery show the icons on my system REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D17829 AFFECTED FILES src/kirigamiplugin.cpp To: apol, #kirigami, mart Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein
[Breeze] [Bug 367696] konsole icon is almost invisible when I use breeze dark theme
https://bugs.kde.org/show_bug.cgi?id=367696
--- Comment #4 from Kurt Hindenburg ---
Git commit e1fde67a69c748b76f8210ac22f58e76b53d9717 by Kurt Hindenburg, on
behalf of Nate Graham.
Committed on 28/12/2018 at 03:27.
Pushed by hindenburg into branch 'master'.
Only show tab icon if the user has specifically chosen one
Summary:
This patch introduces a UI change: tabs only show an icon if it's not
the default one; that is to say, only if the user has actually customized
the icon. There are several reasons for this:
1. **Conceptual:** When only non-default profile icons show up in the tab,
it does a better job of highlighting the fact that a non-default profile
is being used.
2. **Aesthetic:** you no longer have the same icon in every tab by default,
which looks bad and causes the eye to ignore it over time.
3. **Icon-specific:** the `utilities-terminal` icon doesn't look good
against a dark background (https://bugs.kde.org/show_bug.cgi?id=367696)
4. **Code hygiene:** reduces a bit of redundancy in the session controller
code.
Related: bug 401864
FIXED-IN: 19.04.0
Test Plan:
Open multiple tabs and make one of them use a profile with a
non-default icon:
{F6502534, size=full}
Verify that bell signals still cause tabs to get icons.
Reviewers: #konsole, #vdg, ndavis, hindenburg
Reviewed By: #konsole, #vdg, ndavis, hindenburg
Subscribers: fabianr, abetts, hindenburg, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D17747
M +9-7src/SessionController.cpp
https://commits.kde.org/konsole/e1fde67a69c748b76f8210ac22f58e76b53d9717
--
You are receiving this mail because:
You are the assignee for the bug.
D17815: [Wallpaper] Allow adding multiple images at once from the file picker dialog
This revision was automatically updated to reflect the committed changes. Closed by commit R120:b9549351c2c7: [Wallpaper] Allow adding multiple images at once from the file picker dialog (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17815?vs=48235=48266 REVISION DETAIL https://phabricator.kde.org/D17815 AFFECTED FILES wallpapers/image/image.cpp To: ngraham, #konsole, broulik, davidedmundson Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D17809: Check icon positions after move
McPain added inline comments.
INLINE COMMENTS
> positioner.cpp:418
> + */
> +while ((!isBlank(to) && from != to) || toIndices.contains(to)) {
> to++;
AFAIK, the first part of condition is "check if `to` is blank and if it's not,
check whether we're not moving icon to itself, and if we do, it's alright"
The second part is "check if we're already moving another icon to `to` and if
we do so, try `to+1`"
REVISION DETAIL
https://phabricator.kde.org/D17809
To: McPain, #plasma, hein
Cc: davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D17809: Check icon positions after move
McPain updated this revision to Diff 48238. McPain added a comment. Fixed condition mistake CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17809?vs=48220=48238 REVISION DETAIL https://phabricator.kde.org/D17809 AFFECTED FILES containments/desktop/plugins/folder/positioner.cpp To: McPain, #plasma, hein Cc: davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
