D17834: Allow the use of One-Time Password

[Enrique Melendez]

enriquem added a comment.


  You are, of course, correct. How can I have missed that?

REVISION DETAIL
  https://phabricator.kde.org/D17834

To: enriquem, jgrulich
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17834: Allow the use of One-Time Password

[Enrique Melendez]

enriquem updated this revision to Diff 48328.
enriquem edited the summary of this revision.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17834?vs=48289=48328

REVISION DETAIL
  https://phabricator.kde.org/D17834

AFFECTED FILES
  vpn/fortisslvpn/fortisslvpnadvanced.ui
  vpn/fortisslvpn/fortisslvpnauth.cpp
  vpn/fortisslvpn/fortisslvpnauth.ui
  vpn/fortisslvpn/fortisslvpnwidget.cpp
  vpn/fortisslvpn/nm-fortisslvpn-service.h

To: enriquem, jgrulich
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

[Nathaniel Graham]

ngraham added a comment.


  It's on my to-do list, but please have some patience. :) Most people are 
probably still out for their winter holiday vacations.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: bcooksley, #sysadmin, ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

[Alexander Kernozhitsky]

gepardo added a comment.


  Hello, is there any progress on the review?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: bcooksley, #sysadmin, ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17842: Move some messages to LOG_DEBUG level

[Nathaniel Graham]

ngraham added a comment.


  Thanks for your contribution!

REPOSITORY
  R107 KWallet PAM Integration

REVISION DETAIL
  https://phabricator.kde.org/D17842

To: opoplawski
Cc: ngraham, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17842: Move some messages to LOG_DEBUG level

[Nathaniel Graham]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R107:8164bf3a9b57: Move some messages to LOG_DEBUG level 
(authored by opoplawski, committed by ngraham).

REPOSITORY
  R107 KWallet PAM Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17842?vs=48312=48317

REVISION DETAIL
  https://phabricator.kde.org/D17842

AFFECTED FILES
  pam_kwallet.c

To: opoplawski
Cc: ngraham, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17842: Move some messages to LOG_DEBUG level. Resolves bug #392199

[Nathaniel Graham]

ngraham added a comment.


  Makes sense to me.
  
  Please remove ". Resolves bug #392199" from the title; it's unnecessary.

REPOSITORY
  R107 KWallet PAM Integration

REVISION DETAIL
  https://phabricator.kde.org/D17842

To: opoplawski
Cc: ngraham, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17598: Improve "No internet connection!" error message

[Nathaniel Graham]

ngraham added a comment.


  How come?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17598

To: ngraham, #discover_software_store, #vdg, apol
Cc: shubham, pino, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17361: [RFC] [FormLayout] fix item label alignment

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Seems to be already fixed; there must have been something wrong at the time 
with my source checkout or something.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D17361

To: ngraham, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17598: Improve "No internet connection!" error message

[Shubham]

shubham added a comment.


  Shouldn't the second part of the sentence be in its own line?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17598

To: ngraham, #discover_software_store, #vdg, apol
Cc: shubham, pino, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17844: [RFC] Show installed and available versions of updates right there on the page

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: apol, Discover Software Store, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Show the installed anv available versions on the delegate rather than hidden 
away.
  
  RFC because showing the currently-installed version does not actually work 
for packages (it does work for apps). I tried my best to fix this, but what I 
thought would fix it didn't. Suggestions are welcome.

TEST PLAN
  [image goes here]
  
  This will look nicer on distros that aren't Neon dev, where update strings 
are shorter and more user-readable. :)

REPOSITORY
  R134 Discover Software Store

BRANCH
  show-versions-more-clearly-on-updates-page (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17844

AFFECTED FILES
  discover/qml/UpdatesPage.qml
  libdiscover/UpdateModel/UpdateItem.cpp
  libdiscover/UpdateModel/UpdateItem.h
  libdiscover/UpdateModel/UpdateModel.cpp
  libdiscover/UpdateModel/UpdateModel.h
  libdiscover/backends/PackageKitBackend/PackageKitResource.cpp

To: ngraham, apol, #discover_software_store, #vdg
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17842: Move some messages to LOG_DEBUG level. Resolves bug #392199

[Orion Poplawski]

opoplawski created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
opoplawski requested review of this revision.

REVISION SUMMARY
  Move some messages to LOG_DEBUG level.  Resolves bug #392199

REPOSITORY
  R107 KWallet PAM Integration

REVISION DETAIL
  https://phabricator.kde.org/D17842

AFFECTED FILES
  pam_kwallet.c

To: opoplawski
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17796: Plasma Workspace. Fixed general settings of the widgets.

[David Edmundson]

davidedmundson added a comment.


  The call on line 141 looks superfluous - if there's any change to checked we 
modify cfg_sources which should trigger the reload.
  
  Can you confirm?

REVISION DETAIL
  https://phabricator.kde.org/D17796

To: pavelmos, jriddell, #plasma, ngraham
Cc: davidedmundson, ngraham, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17834: Allow the use of One-Time Password

[Jan Grulich]

jgrulich added a comment.


  I don't think this is a complete support for this. You need to add support 
into the auth-dialog as well, without it the connection would expect an otp 
password, but there will be no way how to provide it.
  
  See 
https://github.com/GNOME/network-manager-fortisslvpn/blob/master/auth-dialog/main.c
 for how it's done in Gnome.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D17834

To: enriquem, jgrulich
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17598: Improve "No internet connection!" error message

[Nathaniel Graham]

ngraham added a comment.


  Ping!

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17598

To: ngraham, #discover_software_store, #vdg, apol
Cc: pino, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17834: Allow the use of One-Time Password

[Enrique Melendez]

enriquem created this revision.
enriquem added a reviewer: jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
enriquem requested review of this revision.

REVISION SUMMARY
  NetworkManager-fortisslvpn allows the user to use a One-Time Password 
challenge, but this option has not been included in the plasma applet. This 
change makes allowance for that setting, changing the "Advanced" config dialog 
to include a checkBox to that effect.
  
  The layout has been taken from the NetworkManager "Advanced" config dialog.
  
  The change has been tested for writing to and reading from the config file, 
but should still be fully tested

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D17834

AFFECTED FILES
  vpn/fortisslvpn/fortisslvpnadvanced.ui
  vpn/fortisslvpn/fortisslvpnwidget.cpp
  vpn/fortisslvpn/nm-fortisslvpn-service.h

To: enriquem, jgrulich
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17796: Plasma Workspace. Fixed general settings of the widgets.

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  There we go, it works now! Code change looks sane to me.
  
  Please change the title to something more descriptive, such as "Show accurate 
checked state for system monitor configuration pages". And then we'll wait for 
a review from a #plasma  developer.

REVISION DETAIL
  https://phabricator.kde.org/D17796

To: pavelmos, jriddell, #plasma, ngraham
Cc: ngraham, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17796: Plasma Workspace. Fixed general settings of the widgets.

[Pavel Mos]

pavelmos updated this revision to Diff 48278.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17796?vs=48186=48278

REVISION DETAIL
  https://phabricator.kde.org/D17796

AFFECTED FILES
  applets/systemmonitor/common/contents/ui/ConfigGeneral.qml

To: pavelmos, jriddell, #plasma, ngraham
Cc: ngraham, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart