D17154: Go back to SCSS

2018-12-31 Thread Bhushan Shah 
bshah edited subscribers, added: bshah; removed: Sysadmin.
bshah added a comment.


  (removing sysadmin from subscribers)

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd
Cc: bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, #sysadmin

D17154: Go back to SCSS

2018-12-31 Thread Nathaniel Graham 
ngraham added a comment.


  No worries! CMake can be a bit challenging. :)

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd
Cc: cgiboudeaux, davidedmundson, bcooksley, #sysadmin, ngraham, jackg, 
plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2018-12-31 Thread Alexander Kernozhitsky 
gepardo added a comment.


  In D17154#384519 , @ngraham wrote:
  
  > The `install` target is installing to `./Breeze` and `./Breeze-Dark` in 
addition to the `CMAKE_INSTALL_PREFIX` location, which messes up the 
permissions in your source checkout if you do an in-source build and run `sudo 
make install`.
  
  
  Got it. The issue is more compilcated, though. `Breeze` and `Breeze-Dark` 
directories are created during the build. They are not real targets currently, 
so are build each time (even during the install). So, when installed as root, 
they are modified. I will think of how to fix this issue.
  
  Sorry for these issues with the building process, I'm not familar with it 
much. But at least I hope there're no such issues with the theme itself.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd
Cc: cgiboudeaux, davidedmundson, bcooksley, #sysadmin, ngraham, jackg, 
plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2018-12-31 Thread Nathaniel Graham 
ngraham added a comment.


  The `install` target is installing to `./Breeze` and `./Breeze-Dark` in 
addition to the `CMAKE_INSTALL_PREFIX` location, which messes up the 
permissions in your source checkout if you do an in-source build and run `sudo 
make install`.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd
Cc: cgiboudeaux, davidedmundson, bcooksley, #sysadmin, ngraham, jackg, 
plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

2018-12-31 Thread Nathaniel Graham 
ngraham added a comment.


  If folks really want, I can have a look at removing the feature entirely. 
However are we sure we don't want to keep it around as a fallback? It doesn't 
necessarily seem like a bad backup, it's just maybe not appropriate as a 
user-visible setting anymore in 2018.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17372

To: ngraham, #plasma, #vdg
Cc: dfaure, abetts, davidedmundson, plasma-devel, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17154: Go back to SCSS

2018-12-31 Thread Alexander Kernozhitsky 
gepardo updated this revision to Diff 48462.
gepardo added a comment.


  CMake fixes:
  
  - Compatibility with older versions
  - Add docs and copyright into FindSass.cmake

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17154?vs=48224=48462

BRANCH
  breeze-gtk-sass (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17154

AFFECTED FILES
  Breeze-dark-gtk/CMakeLists.txt
  Breeze-dark-gtk/assets/arrow-down-active.png
  Breeze-dark-gtk/assets/arrow-down-hover.png
  Breeze-dark-gtk/assets/arrow-down-insensitive.png
  Breeze-dark-gtk/assets/arrow-down.png
  Breeze-dark-gtk/assets/arrow-left-active.png
  Breeze-dark-gtk/assets/arrow-left-hover.png
  Breeze-dark-gtk/assets/arrow-left-insensitive.png
  Breeze-dark-gtk/assets/arrow-left.png
  Breeze-dark-gtk/assets/arrow-right-active.png
  Breeze-dark-gtk/assets/arrow-right-hover.png
  Breeze-dark-gtk/assets/arrow-right-insensitive.png
  Breeze-dark-gtk/assets/arrow-right.png
  Breeze-dark-gtk/assets/arrow-small-down-active.png
  Breeze-dark-gtk/assets/arrow-small-down-hover.png
  Breeze-dark-gtk/assets/arrow-small-down-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-down.png
  Breeze-dark-gtk/assets/arrow-small-left-active.png
  Breeze-dark-gtk/assets/arrow-small-left-hover.png
  Breeze-dark-gtk/assets/arrow-small-left-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-left.png
  Breeze-dark-gtk/assets/arrow-small-right-active.png
  Breeze-dark-gtk/assets/arrow-small-right-hover.png
  Breeze-dark-gtk/assets/arrow-small-right-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-right.png
  Breeze-dark-gtk/assets/arrow-small-up-active.png
  Breeze-dark-gtk/assets/arrow-small-up-hover.png
  Breeze-dark-gtk/assets/arrow-small-up-insensitive.png
  Breeze-dark-gtk/assets/arrow-small-up.png
  Breeze-dark-gtk/assets/arrow-up-active.png
  Breeze-dark-gtk/assets/arrow-up-hover.png
  Breeze-dark-gtk/assets/arrow-up-insensitive.png
  Breeze-dark-gtk/assets/arrow-up.png
  Breeze-dark-gtk/assets/button-active.png
  Breeze-dark-gtk/assets/button-hover.png
  Breeze-dark-gtk/assets/button-insensitive.png
  Breeze-dark-gtk/assets/button.png
  Breeze-dark-gtk/assets/check-checked-active.png
  Breeze-dark-gtk/assets/check-checked-act...@2.png
  Breeze-dark-gtk/assets/check-checked-backdrop-insensitive.png
  Breeze-dark-gtk/assets/check-checked-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-checked-backdrop.png
  Breeze-dark-gtk/assets/check-checked-backd...@2.png
  Breeze-dark-gtk/assets/check-checked-hover.png
  Breeze-dark-gtk/assets/check-checked-ho...@2.png
  Breeze-dark-gtk/assets/check-checked-insensitive.png
  Breeze-dark-gtk/assets/check-checked-insensit...@2.png
  Breeze-dark-gtk/assets/check-mixed-active.png
  Breeze-dark-gtk/assets/check-mixed-act...@2.png
  Breeze-dark-gtk/assets/check-mixed-backdrop-insensitive.png
  Breeze-dark-gtk/assets/check-mixed-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-mixed-backdrop.png
  Breeze-dark-gtk/assets/check-mixed-backd...@2.png
  Breeze-dark-gtk/assets/check-mixed-hover.png
  Breeze-dark-gtk/assets/check-mixed-ho...@2.png
  Breeze-dark-gtk/assets/check-mixed-insensitive.png
  Breeze-dark-gtk/assets/check-mixed-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-active.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-act...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backdrop-insensitive.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backdrop.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-backd...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-hover.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-ho...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-insensitive.png
  Breeze-dark-gtk/assets/check-selectionmode-checked-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-active.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-act...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-backdrop-insensitive.png
  
Breeze-dark-gtk/assets/check-selectionmode-unchecked-backdrop-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-backdrop.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-backd...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-hover.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-ho...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-insensitive.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked-insensit...@2.png
  Breeze-dark-gtk/assets/check-selectionmode-unchecked.png
  Breeze-dark-gtk/assets/check-selectionmode-unchec...@2.png
  Breeze-dark-gtk/assets/check-unchecked-active.png
  Breeze-dark-gtk/assets/check-unchecked-act...@2.png
  Breeze-dark-gtk/assets/check-unchecked-backdrop-insensitive.png

D17154: Go back to SCSS

2018-12-31 Thread Alexander Kernozhitsky 
gepardo added inline comments.

INLINE COMMENTS

> cgiboudeaux wrote in FindSass.cmake:1
> Missing doc & license

Which one should I choose? Is BSD 3-clause, that is used by //Extra CMake 
modules//, OK?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd
Cc: cgiboudeaux, davidedmundson, bcooksley, #sysadmin, ngraham, jackg, 
plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

2018-12-31 Thread Nathaniel Graham 
ngraham updated this revision to Diff 48457.
ngraham added a comment.


  Revert unintentional and unnecessary whitespace change

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17372?vs=48456=48457

BRANCH
  arcpatch-D17372

REVISION DETAIL
  https://phabricator.kde.org/D17372

AFFECTED FILES
  kcms/componentchooser/browserconfig_ui.ui
  kcms/componentchooser/componentchooserbrowser.cpp

To: ngraham, #plasma, #vdg
Cc: dfaure, abetts, davidedmundson, plasma-devel, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

2018-12-31 Thread Nathaniel Graham 
ngraham updated this revision to Diff 48456.
ngraham added a comment.


  Initialize m_browserCombo before accessing it

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17372?vs=46914=48456

BRANCH
  arcpatch-D17372

REVISION DETAIL
  https://phabricator.kde.org/D17372

AFFECTED FILES
  kcms/componentchooser/browserconfig_ui.ui
  kcms/componentchooser/componentchooserbrowser.cpp

To: ngraham, #plasma, #vdg
Cc: dfaure, abetts, davidedmundson, plasma-devel, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D13849: WIP: Add fractional scaling to wayland scaling GUI

2018-12-31 Thread David Edmundson 
davidedmundson added a comment.


  Was uploaded so someone else could test the rest of the underlying stuff 
that's merged.
  
  It runtime requires Qt 5.12 for xdg-output which the shell needs for 
fullscreen, which means we can merge for Plasma 5.16

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D13849

To: davidedmundson, #plasma
Cc: fcucchetto, gvarsanyi, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13849: WIP: Add fractional scaling to wayland scaling GUI

2018-12-31 Thread Filippo Cucchetto 
fcucchetto added a comment.


  Is there a reason why this has been abandoned

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D13849

To: davidedmundson, #plasma
Cc: fcucchetto, gvarsanyi, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

2018-12-31 Thread Christophe Giboudeaux 
cgiboudeaux added inline comments.

INLINE COMMENTS

> CMakeLists.txt:14
>  
> -include(KDEInstallDirs)
> +if(${CMAKE_VERSION} GREATER_EQUAL 3.12.0)
> +find_package(Python3 COMPONENTS Interpreter REQUIRED)

This doesn't exist in CMake 2.8.12. Use

  if(NOT CMAKE_VERSION VERSION_LESS 3.12.0)

or invert the if/else to avoid the 'NOT'

> FindSass.cmake:1
> +set_package_properties(Sass PROPERTIES
> +  DESCRIPTION "SASS compiler"

Missing doc & license

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd
Cc: cgiboudeaux, davidedmundson, bcooksley, #sysadmin, ngraham, jackg, 
plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17598: Improve "No internet connection!" error message

2018-12-31 Thread Nathaniel Graham 
ngraham added a comment.


  Not really. The text is not long, while the window size is user-adjustible so 
the empty space area can potentially be very large.

REPOSITORY
  R134 Discover Software Store

BRANCH
  better-no-connectivity-error-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17598

To: ngraham, #discover_software_store, #vdg, apol, shubham
Cc: rooty, shubham, pino, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17598: Improve "No internet connection!" error message

2018-12-31 Thread Shubham 
shubham added a comment.


  @rooty yeah, it depends on the available space. The main motive should be 
full up the empty space.
  @ngraham Is there any possible representation where we can just eliminate or 
use up that empty space.

REPOSITORY
  R134 Discover Software Store

BRANCH
  better-no-connectivity-error-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17598

To: ngraham, #discover_software_store, #vdg, apol, shubham
Cc: rooty, shubham, pino, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17598: Improve "No internet connection!" error message

2018-12-31 Thread Root 
rooty added a comment.


  it might work on the left, but i think this is better because it takes up the 
entire pane, and is important enough to warrant doing so
  
  for example,
  F6517329: image.png 
  F6517334: image.png 
  
  versus firefox's 
  F6517331: image.png 
  (takes up more room)
  
  in contrast to less 'important' prompts such as
  
  F6517338: image.png 
  F6517341: image.png 
  F6517343: image.png 

REPOSITORY
  R134 Discover Software Store

BRANCH
  better-no-connectivity-error-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17598

To: ngraham, #discover_software_store, #vdg, apol, shubham
Cc: rooty, shubham, pino, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17598: Improve "No internet connection!" error message

2018-12-31 Thread Shubham 
shubham added a comment.


  In D17598#384293 , @ngraham wrote:
  
  > In D17598#384289 , @shubham 
wrote:
  >
  > > Looking nice. Not being nitpicky, what's the default behaviour, the icon 
should be on top or to the free space on the left?
  >
  >
  > There is no real rule here. It's more of "what looks good" in a designey 
sense. :)
  
  
  Well then it's good, conveying the message without actually the need to read 
it.

REPOSITORY
  R134 Discover Software Store

BRANCH
  better-no-connectivity-error-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17598

To: ngraham, #discover_software_store, #vdg, apol, shubham
Cc: rooty, shubham, pino, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17598: Improve "No internet connection!" error message

2018-12-31 Thread Nathaniel Graham 
ngraham added a comment.


  In D17598#384289 , @shubham wrote:
  
  > Looking nice. Not being nitpicky, what's the default behaviour, the icon 
should be on top or to the free space on the left?
  
  
  There is no real rule here. It's more of "what looks good" in a designey 
sense. :)

REPOSITORY
  R134 Discover Software Store

BRANCH
  better-no-connectivity-error-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17598

To: ngraham, #discover_software_store, #vdg, apol, shubham
Cc: rooty, shubham, pino, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17598: Improve "No internet connection!" error message

2018-12-31 Thread Shubham 
shubham added a comment.


  Looking nice. Not being nitpicky, what's the default behaviour, the icon 
should be on top or to the free space on the left?

REPOSITORY
  R134 Discover Software Store

BRANCH
  better-no-connectivity-error-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17598

To: ngraham, #discover_software_store, #vdg, apol, shubham
Cc: rooty, shubham, pino, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17598: Improve "No internet connection!" error message

2018-12-31 Thread Nathaniel Graham 
ngraham updated this revision to Diff 48441.
ngraham added a comment.


  Rebase on master

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17598?vs=48440=48441

BRANCH
  better-no-connectivity-error-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17598

AFFECTED FILES
  discover/qml/BrowsingPage.qml

To: ngraham, #discover_software_store, #vdg, apol, shubham
Cc: rooty, shubham, pino, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17598: Improve "No internet connection!" error message

2018-12-31 Thread Nathaniel Graham 
ngraham updated this revision to Diff 48440.
ngraham added a comment.


  Tighten up the wording a tiny bit

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17598?vs=48439=48440

BRANCH
  better-no-connectivity-error-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17598

AFFECTED FILES
  discover/qml/BrowsingPage.qml

To: ngraham, #discover_software_store, #vdg, apol, shubham
Cc: shubham, pino, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17598: Improve "No internet connection!" error message

2018-12-31 Thread Root 
rooty added a comment.


  loving the icon, it really stresses the importance of checking whether your 
internet connection's working without being (too) imposing

REPOSITORY
  R134 Discover Software Store

BRANCH
  better-no-connectivity-error-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17598

To: ngraham, #discover_software_store, #vdg, apol, shubham
Cc: rooty, shubham, pino, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17598: Improve "No internet connection!" error message

2018-12-31 Thread Nathaniel Graham 
ngraham updated this revision to Diff 48439.
ngraham added a comment.


  Add an icon per #VDG  suggestion

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17598?vs=48408=48439

BRANCH
  better-no-connectivity-error-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17598

AFFECTED FILES
  discover/qml/BrowsingPage.qml

To: ngraham, #discover_software_store, #vdg, apol, shubham
Cc: shubham, pino, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart