D13868: [KdePlasma-Addons/POTD/NOAA] Fixed the web address and fetched the picture from new address

[Tagore Chandan Reddy]

tagorechandanreddy added a comment.


  @ngraham My email address: tagore.chan...@gmail.com

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D13868

To: tagorechandanreddy, #plasma, davidedmundson
Cc: ngraham, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18206: Improve the Look and Feel KCM

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  +1
  
  I think the use of an article is okay here since it's basically a tooltip 
that just happens to be inappropriately displayed as a title for other reasons.
  
  All those +1s add up to a formal acceptance, methinks.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-lookandfeel-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18206

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, rooty, rizzitello, abetts, filipf, #vdg, plasma-devel, #plasma, 
kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D18206: Improve the Look and Feel KCM

[Root]

rooty added a comment.


  +1 from me
  if you want you could drop the article by the way and make it "Choose Look 
and Feel theme"
  it's like "Configure Network Settings" vs "Configure the Network Settings"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18206

To: GB_2, #plasma, #vdg
Cc: rooty, rizzitello, abetts, filipf, #vdg, plasma-devel, #plasma, kvanton, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D18206: Improve the Look and Feel KCM

[Chris Rizzitello]

rizzitello added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18206

To: GB_2, #plasma, #vdg
Cc: rizzitello, abetts, filipf, #vdg, plasma-devel, #plasma, kvanton, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, 
apol, mart

D18206: Improve the Look and Feel KCM

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18206

To: GB_2, #plasma, #vdg
Cc: abetts, filipf, #vdg, plasma-devel, #plasma, kvanton, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D18206: Improve the Look and Feel KCM

[Filip Fila]

filipf added a comment.


  I like this because the essence of what the user is doing in this kcm is 
choosing, rather than configuring.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18206

To: GB_2, #plasma, #vdg
Cc: filipf, #vdg, plasma-devel, #plasma, kvanton, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18019: [Digital Clock] Add ability to set a custom date format string

[Chris Holland]

Zren added a comment.


  > D18155 
  
  Looking at the alternative patch, I've renamed the config key variable to 
`customDateFormat`. Most of the differences stem from not using a "variant" 
data type for `DigitalClock.qml`'s `dateFormat` variable. The `string 
formatDate(datetime date, variant format)` (qt doc link 
) accepts a variant 
type.
  
  In D18019#390579 , @davidedmundson 
wrote:
  
  > So for those reasons, I'm inclined to say +1.
  
  
  Assuming there's no objection to this, I'll merge this Sunday night. The beta 
is Thurs, so I assume that's the cutoff date?
  
  > I don't think the answers to the same question apply to the "First Day of 
the Week" patch.
  
  Fair enough. With that setting, the user sort of expects every date selection 
calendar popup (Qt/Gtk) to follow that setting. Where as with this setting, the 
user's expectation is that it should only change the panel's clock widget.
  
  > I don't think we need the colour formatting link. It's a niche within a 
niche. Removing it "solves" the escaping issue as it means the user is doing 
something undocumented in the first place.
  
  Sounds good. Until there's an embedded list of examples (D18168 
) it could just overwhelm the user with 2 
different syntaxes.
  
  -
  
  Final note. We're using `Qt.formatDate()`, which means the "time formats" 
`hh`, `mm`, `ss`, `t` (time zone), and `zzz` (millis) are not replaced with 
their value. Implementing that would require duplicating the "sizehelper 
timeMetrics" code for the date format though, which I can't guarantee a bugless 
patch this soon before the 5.15 Beta. If I finish D18168 
, then it might help suggest to the user 
that only the "date variables" are accepted.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18019

To: Zren, #plasma, #vdg
Cc: karpenyamichael, davidedmundson, abetts, cfeck, ngraham, mart, ndavis, 
rooty, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D18019: [Digital Clock] Add ability to set a custom date format string

[Chris Holland]

Zren updated this revision to Diff 49332.
Zren edited the summary of this revision.
Zren edited the test plan for this revision.
Zren added a comment.


  - Rename config key from `dateFormatStr` and config TextField 
`dateFormatTextField` to `customDateFormat`.
  - Remove the "Color Format Documentation" link.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18019?vs=49137=49332

REVISION DETAIL
  https://phabricator.kde.org/D18019

AFFECTED FILES
  applets/digital-clock/package/contents/config/main.xml
  applets/digital-clock/package/contents/ui/DigitalClock.qml
  applets/digital-clock/package/contents/ui/configAppearance.qml

To: Zren, #plasma, #vdg
Cc: karpenyamichael, davidedmundson, abetts, cfeck, ngraham, mart, ndavis, 
rooty, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D16945: Fix fallback to built-in ui

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R133:dfd02160746b: Fix fallback to built-in ui (authored by 
graesslin).

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16945?vs=45744=49330

REVISION DETAIL
  https://phabricator.kde.org/D16945

AFFECTED FILES
  greeter/greeterapp.cpp

To: graesslin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16943: Disable kcrash in greeter in same way as in KWin

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R133:552932c8baab: Disable kcrash in greeter in same way as in 
KWin (authored by graesslin).

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16943?vs=45629=49329

REVISION DETAIL
  https://phabricator.kde.org/D16943

AFFECTED FILES
  greeter/greeterapp.cpp

To: graesslin, #plasma, #kwin, bshah, davidedmundson
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18206: Improve the Look and Feel KCM

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  The LnF KCM has some inconsistencies and doesn't always apply the KDE HIG, so 
this fixes that and makes some other improvements.
  F6546516: LnF KCM.png 

TEST PLAN
  Open the LnF KCM

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-lookandfeel-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18206

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm_lookandfeel.desktop
  kcms/lookandfeel/package/contents/ui/main.qml
  kcms/lookandfeel/package/metadata.desktop

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, kvanton, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18194: Fix autohide behaviour after dragging a panel

[Steffen Coenen]

scoenen added a comment.


  You can use this email address: stef...@steffen-coenen.de
  
  As for the potentially redundant code on X11, I am not sure if there is any 
benefit in changing it any further as it works as it is. It just checks if a 
mouseGrabberItem() is present which should never be the case on X11 now and 
then does nothing.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18194

To: scoenen, mvourlakos
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, lavender, ZrenBot, 
mvourlakos, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

[Alexander Kernozhitsky]

gepardo added a comment.


  > I would also scrap all the stuff about ~/.local
  
  Are there any strong reasons?
  
  Reasons for not removing `~/.local` are the following. KDE still doesn't have 
custom color schemes support for Breeze-GTK. But `build-theme.sh` allows to 
rebuild the theme with custom color scheme and by default install it into 
`~/.local/share/themes`. As you can see, it can read the colors from kdeglobals 
and color schemes (local and system-wide). (BTW that's how I'm using the theme: 
I just run `build_theme.sh` when changing color scheme)
  
  I do agree that's a temporary hack there should be a user-friendly way to 
change the colors. But I think there no reason to remove this stuff now.
  
  Maybe this way to rebuild the theme can be mentioned in README also.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson
Cc: lbeltrame, bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> build_theme.sh:89-98
> +COLOR_SCHEME="/usr/share/color-schemes/Breeze.colors"
> +  fi
> +else
> +  THEME_NAME="${COLOR_SCHEME}"
> +  if [ -f "/usr/share/color-schemes/${COLOR_SCHEME}.colors" ]; then
> +COLOR_SCHEME="/usr/share/color-schemes/${COLOR_SCHEME}.colors"
> +  elif [ -f "${HOME}/.local/share/color-schemes/${COLOR_SCHEME}.colors" ]; 
> then

We can't assume '/usr/share'/
Nor can we use the install prefix for where this is installed as that breaks 
distro packaging.

Breeze needs to export this location in it's installed .cmake file, then we 
should reference that.

I would also scrap all the stuff about ~/.local.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson
Cc: lbeltrame, bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart