D18258: Wait forever until the lock file can be locked

[trmdi]

trmdi created this revision.
trmdi added a reviewer: mvourlakos.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  - `timeout = 3000` is a bit short on some computer. Use `timeout = -1` will 
work for any case.
  
  BUG: 401041

TEST PLAN
  BUG: 401041 is fixed on my computer.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18258

AFFECTED FILES
  app/main.cpp

To: trmdi, mvourlakos
Cc: plasma-devel, sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.11 - Build # 283 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.11/283/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Tue, 08 Jan 2019 13:53:22 +
 Build duration:
35 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 20 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 106 test(s), Skipped: 0 test(s), Total: 106 test(s)Name: projectroot.autotests.integration Failed: 0 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 12 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report65%
(54/83)54%
(289/532)54%
(289/532)40%
(28018/70060)30%
(13089/43758)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault86%
(130/151)86%
(130/151)63%
(18180/28771)48%
(9603/20109)colorcorrection100%
(5/5)100%
(5/5)82%
(440/535)59%
(195/328)data0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/8)decorations100%
(10/10)100%
(10/10)76%
(399/523)61%
(124/204)effects100%
(2/2)100%
(2/2)98%
(155/158)82%
(23/28)effects.backgroundcontrast25%
(1/4)25%
(1/4)1%
(5/351)2%
(4/250)effects.blur20%
(1/5)20%
(1/5)1%
(5/660)1%
(4/379)effects.colorpicker100%
(2/2)100%
(2/2)13%
(8/62)0%
(0/24)effects.coverswitch33%
(1/3)33%
(1/3)0%
(2/657)1%
(4/530)effects.cube25%
(1/4)25%
(1/4)0%
(3/1285)0%
(0/1017)effects.cubeslide33%
(1/3)33%
(1/3)5%
(24/465)1%
(5/370)effects.desktopgrid67%
(2/3)67%
(2/3)7%
(73/1023)3%
(27/962)effects.diminactive33%
(1/3)33%
(1/3)13%
(30/232)2%
(3/160)effects.fallapart50%
(1/2)50%
(1/2)12%
(13/106)5%
(3/58)effects.flipswitch33%
(1/3)33%
(1/3)7%
(45/655)1%
(5/554)effects.glide67%
(2/3)67%
(2/3)68%
(140/206)53%
(48/91)effects.highlightwindow100%
(2/2)100%
 

22.-26. March 2019, Leipzig - KDE Privacy Sprint

[Sandro Knauß]

Hi,

The Privacy sprint is coming  we're happy to announce the preliminary
date as 22.-26. March 2019 in Leipzig, Germany and we're looking forward to 
seeing you there. So please give us feedback, if you want to come. You can 
also get reimbursement via https://reimbursements.kde.org

We're working hard on making this sprint amazing and look forward to all
the constructive fun we're going to have.

Best, the privacy goal sprint team 
Florian, Louise and Sandro

--

On Mittwoch, 28. November 2018 13:56:54 CET Sandro Knauß wrote:
> Hey,
> 
> We volunteered to organize a KDE Privacy Sprint. We wanted to make it happen
> in March. We think at a sprint of five days. The main goal for the sprint
> is to locate privacy issues and after locating them hopefully fix them.
> Let's take the advantage to speak in person with multiple people of
> different part in KDE to find solutions. Currently the date is not fixed,
> so we doodle for one:
> 
> https://bitpoll.mafiasi.de/poll/8BYKJA5B/
> 
> Please add yourself to the doodle fast, so that we can have a fixed date
> within the next weeks.
> 
> Explicitly we would like to invite people from following teams:
> Plasma
> Plasma mobile
> Vault
> Falkon
> Choqok
> KDE Pim
> Frameworks
> 
> Please feel also invited, if you are not in such a team an be simply
> interested in that topic!
> 
> The sprint will either be located in Leipzig(Germany) or Les Magnas (France)
> http://auxsaisons.free.fr/. At the moment both options are still open, but
> soon we need to decide. What is your preference of place?
> 
> Some issues that came into my mind:
> 
> *  currently when clicking on a link in an email the url is accessed within
> Plasma and than forward this to Firefox. If the user wants to use TorBrowser
> as default browser it is a Privacy Breach.
>  *  having an interface to torify/vpn applications
> 
> Wifi:
> 
> * detect wiki login pages - do not access internet before, e.g. you are
> using inet of a hotel
> *  have a way to allow/dissallow applications interact with inet for
> specific wifis, e.g. you are using inet of a hotel
> 
> TLS:
> 
> * detecting bad SSL standards aka only TLS 1.0...
> * more helpful SSL problem dialog (properly if you have a wifi login page)
> 
> Mails:
> 
> * Encrypting headers of mails to give less metadata to surveillance T742.
> * Make it possible to search in encrypted mails, as until now, the encrypted
> data are a binary blob for the search. The search important to find mails
> again T8447.
> * Add GnuPG TOFU (Trust On First Use) trust model support for KMail. With
> TOFU you will get more security without exchanging the gpg fingerprints. To
> make it clear, exchanging fingerprints gives better security, but is
> exhausting.
> * Make Akregator webviewer protect against ad trackers T7528.
> 
> For more information look at https://phabricator.kde.org/T8622.
> 
> Share your thoughts and see you!
> 
> louise and hefee

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.11 - Build # 288 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.11/288/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Wed, 09 Jan 2019 09:17:01 +
 Build duration:
1 hr 7 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.autotests.kwin_testScreenEdgesName: projectroot.autotests Failed: 0 test(s), Passed: 106 test(s), Skipped: 0 test(s), Total: 106 test(s)Name: projectroot.autotests.integration Failed: 0 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 12 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report65%
(54/83)54%
(289/532)54%
(289/532)40%
(28012/70080)30%
(13053/43772)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault86%
(130/151)86%
(130/151)63%
(18171/28786)48%
(9560/20117)colorcorrection100%
(5/5)100%
(5/5)82%
(440/535)59%
(195/328)data0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/8)decorations100%
(10/10)100%
(10/10)76%
(399/523)61%
(124/204)effects100%
(2/2)100%
(2/2)98%
(155/158)82%
(23/28)effects.backgroundcontrast25%
(1/4)25%
(1/4)1%
(5/351)2%
(4/250)effects.blur20%
(1/5)20%
(1/5)1%
(5/660)1%
(4/379)effects.colorpicker100%
(2/2)100%
(2/2)13%
(8/62)0%
(0/24)effects.coverswitch33%
(1/3)33%
(1/3)0%
(2/657)1%
(4/530)effects.cube25%
(1/4)25%
(1/4)0%
(3/1285)0%
(0/1017)effects.cubeslide33%
(1/3)33%
(1/3)5%
(24/465)1%
(5/370)effects.desktopgrid67%
(2/3)67%
(2/3)7%
(73/1023)3%
(27/962)effects.diminactive33%
(1/3)33%
(1/3)13%
(30/232)2%
(3/160)effects.fallapart50%
(1/2)50%
(1/2)12%
(13/106)5%
(3/58)effects.flipswitch33%
(1/3)33%
(1/3)7%
(45/655)1%
(5/554)effects.glide67%
(2/3)67%
(2/3)68%
(140/206)53%
(48/91)effects.highlightwindow100%

Re: Plasma 5.14.4

[Luna Jernberg]

Updating

On Thu, Jan 10, 2019 at 3:51 AM Jonathan Riddell  wrote:

> Plasma 5.14.5 is now released
> https://www.kde.org/announcements/plasma-5.14.5.php
>

D18032: Fix USB view

[Alexandre Ferreira]

alexandref updated this revision to Diff 49494.
alexandref added a comment.


  Added usb.ids from the distribution (Gentoo)

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18032?vs=49207=49494

REVISION DETAIL
  https://phabricator.kde.org/D18032

AFFECTED FILES
  Modules/usbview/usbdb.cpp
  Modules/usbview/usbdevices.cpp

To: alexandref, #plasma, cfeck, davidedmundson
Cc: asturmlechner, davidedmundson, plasma-devel, sukalyanbanga, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18255: Improve up/down display for Monitor widgets

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> davidedmundson wrote in DoublePlotter.qml:105
> Can we assume a font has ⬆ characters?

I grabbed this code from `plasma-nm`, which does the same thing. I haven't 
heard any complaints about that so I'm going to assume yes?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18255

To: ngraham, #plasma, #vdg
Cc: davidedmundson, plasma-devel, sukalyanbanga, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18255: Improve up/down display for Monitor widgets

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> DoublePlotter.qml:105
>  nameLabel.text = plotter.sensorName
> -speedLabel.text = formatData(data1) + " | " + 
> formatData(data2)
> +speedLabel.text = i18n("⬇ %2 |  color='%3'>⬆ %4",
> +downloadColor,

Can we assume a font has ⬆ characters?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18255

To: ngraham, #plasma, #vdg
Cc: davidedmundson, plasma-devel, sukalyanbanga, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18255: Improve up/down display for Monitor widgets

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch improves the up/down display for the Monitor widgets, and most 
nodablt the Network Monitor widget.

TEST PLAN
  Before, no activity:
  
  After, no activity:
  
  Before, some activity:
  
  After, some activity:
  
  All the other ones still look good or are improved:

REPOSITORY
  R120 Plasma Workspace

BRANCH
  improve-network-monitor-display (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18255

AFFECTED FILES
  applets/systemmonitor/common/contents/ui/DoublePlotter.qml
  applets/systemmonitor/net/contents/ui/net.qml

To: ngraham, #plasma, #vdg
Cc: plasma-devel, sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18019: [Digital Clock] Add ability to set a custom date format string

[Chris Holland]

Zren added a comment.


  There was a few +1s, but I wasn't exactly sure who specifically "approves" 
this for a merge to `plasma-workspace` or `digital-clock` specifically. My bad, 
I shouldn't of left this feature to the last minute and felt rushed to get it 
in. I'll try to avoid the time before the betas when submitting in the future.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18019

To: Zren, #plasma, #vdg
Cc: broulik, karpenyamichael, davidedmundson, abetts, cfeck, ngraham, mart, 
ndavis, rooty, plasma-devel, sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D14147: Port from GConf to GSettings

[Andreas Sturmlechner]

asturmlechner added inline comments.

INLINE COMMENTS

> drosca wrote in CMakeLists.txt:46
> This should probably use cache variables:
> 
>   set(USE_GCONF FALSE CACHE STRING "Build with GConf")
>   set(USE_GSETTINGS TRUE CACHE STRING "Build with GSettings")

this still needs to be addressed, anything else though?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D14147

To: nicolasfella, drosca, davidedmundson
Cc: lbeltrame, evpokp, rikmills, broulik, asturmlechner, plasma-devel, 
sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17874: [dimdisplay] Effectively waits display to wake-up

[Anthony Fieroni]

This revision was automatically updated to reflect the committed changes.
Closed by commit R122:c40b8ba3b66d: [dimdisplay] Waits a bit display to wake-up 
(authored by anthonyfieroni).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17874?vs=48407=49468

REVISION DETAIL
  https://phabricator.kde.org/D17874

AFFECTED FILES
  daemon/actions/bundled/dimdisplay.cpp
  daemon/powerdevilcore.cpp

To: anthonyfieroni, mart, broulik, thsurrel, #plasma
Cc: abetts, plasma-devel, sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16890: [systemtray] Keep config entries after modifying

[Anthony Fieroni]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0885170daf56: [systemtray] Workaround component creation 
(authored by anthonyfieroni).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D16890?vs=45502=49467#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16890?vs=45502=49467

REVISION DETAIL
  https://phabricator.kde.org/D16890

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: anthonyfieroni, #plasma, broulik, davidedmundson, ngraham
Cc: trmdi, mart, ngraham, broulik, plasma-devel, sukalyanbanga, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D16890: [systemtray] Keep config entries after modifying

[Nathaniel Graham]

ngraham added a comment.


  @anthonyfieroni can you add a comment in the code that indicates the Qt 
issues this is working around?
  
  We've got three days until 5.15 tagging. Let's try to get this in!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16890

To: anthonyfieroni, #plasma, broulik, davidedmundson, ngraham
Cc: trmdi, mart, ngraham, broulik, plasma-devel, sukalyanbanga, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D16890: [systemtray] Keep config entries after modifying

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.


  The bug has been reported before!
  
  https://bugreports.qt.io/browse/QTBUG-71238 / 
https://bugreports.qt.io/browse/QTBUG-72004
  
  Ignore the title and context, read the comment from Kai about the component 
without a parent getting cleaned up.
  
  That moves this from working round an "unknown", to working round a "known" 
issue.  
  Seems a tiny difference, but means a lot to whether I accept it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16890

To: anthonyfieroni, #plasma, broulik, davidedmundson, ngraham
Cc: trmdi, mart, ngraham, broulik, plasma-devel, sukalyanbanga, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D18247: Improve Desktop/Plasma Theme KCM

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:2015bad98e64: Improve Desktop/Plasma Theme KCM (authored 
by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18247?vs=49453=49461

REVISION DETAIL
  https://phabricator.kde.org/D18247

AFFECTED FILES
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm_desktoptheme.desktop
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/package/metadata.desktop

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, davidedmundson, #vdg, plasma-devel, #plasma, sukalyanbanga, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D18246: Fix premature firing of allInitialized signal

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Nice catch. Looks like this might this fix 401334?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18246

To: leinir, apol, ngraham, #discover_software_store, davidedmundson
Cc: plasma-devel, sukalyanbanga, jraleigh, bam, GB_2, masilva, ragreen, ixoos, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18194: Fix autohide behaviour after dragging a panel

[Michail Vourlakos]

This revision was automatically updated to reflect the committed changes.
Closed by commit R878:56cfb427348a: Fix autohide behaviour after dragging a 
panel (authored by scoenen, committed by mvourlakos).

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18194?vs=49286=49460

REVISION DETAIL
  https://phabricator.kde.org/D18194

AFFECTED FILES
  app/view/visibilitymanager.cpp
  app/wm/abstractwindowinterface.h
  app/wm/waylandinterface.cpp
  app/wm/waylandinterface.h
  app/wm/xwindowinterface.cpp
  app/wm/xwindowinterface.h

To: scoenen, mvourlakos
Cc: plasma-devel, sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, lavender, 
ZrenBot, mvourlakos, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D18244: Check for python-cairo

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> FindPythonCairo.cmake:8
> +# Check for python cairo
> +execute_process(COMMAND ${PYTHON_EXECUTABLE} -c "import cairo"
> +RESULT_VARIABLE PYTHON_CAIRO_RESULT)

FindPython3.cmake doesn't define PYTHON_EXECUTABLE but Python3_EXECUTABLE, you 
need e.g set(PYTHON_EXECUTABLE "${Python3_EXECUTABLE}") after line 4.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18244

To: davidedmundson, #plasma, ngraham, cgiboudeaux
Cc: ngraham, zzag, plasma-devel, sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11235: [DrKonqi] Request change of ptrace scope from KCrash

[Oswald Buddenhagen]

ossi requested changes to this revision.
ossi added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> debuggerlaunchers.cpp:57
>  if ( pid > 0 ) {
> +queryPtrace(pid);
>  m_monitor->startMonitoring(pid);

according to my reading of the documentation 
(https://www.kernel.org/doc/Documentation/security/Yama.txt) and the kernel 
source, this is unnecessary in this branch, as descendants of the assigned 
ptracer have the right as well (that's why the "normal" backtrace creation 
works without your patch), and not even detaching breaks the chain.

> queryptrace.cpp:67
> +
> +if (select(sfd + 1, , NULL, NULL, ) > 0 &&
> +read(sfd, msg, 3) > 0 && strcmp(msg, "OK") == 0) {

use poll() here, too.

> queryptrace.cpp:68
> +if (select(sfd + 1, , NULL, NULL, ) > 0 &&
> +read(sfd, msg, 3) > 0 && strcmp(msg, "OK") == 0) {
> +qCInfo(DRKONQI_LOG) << "ptrace granted by debugged process";

the current version of the complementary patch just echoes back the pid, so 
this cannot possibly work.

> croick wrote in queryptrace.cpp:26
> QTemporaryDir will not work, since the location is set in KCrash.

the location is still bogus, though. see comment on the other diff.

> queryptrace.h:22
> +
> +/** In Linux try to make the process attach to the debugger */
> +void queryPtrace(qint64 pid);

no. "on linux, tell the process to allow the debugger to attach to it".

> queryptrace.h:23
> +/** In Linux try to make the process attach to the debugger */
> +void queryPtrace(qint64 pid);
> +

that's a rather misleading function name. setPtracer() would reflect the 
purpose and upstream naming.

> croick wrote in crashtest.cpp:138
> That reasoning does not seem to be true. The output can still be read when 
> started "normally".

only if kdeinit was started from the same console, which you cannot assume.

also, this change wouldn't belong into this patch anyway.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11235

To: croick, #plasma_workspaces, #frameworks, ossi
Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, 
sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18247: Improve Desktop/Plasma Theme KCM

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  +1. The only change here that I think might be  remotely controversial is 
changing "Desktop theme" to Plasma theme". But I thin that's a very good change 
since it improves the ability to understand what this actually is, and also 
uses our branding. You're using Plasma, so this thing chooses the Plasma theme. 
Makes sense to me.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-desktoptheme-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18247

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, davidedmundson, #vdg, plasma-devel, #plasma, sukalyanbanga, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D18247: Improve Desktop/Plasma Theme KCM

[Björn Feber]

GB_2 added a comment.


  In D18247#393021 , @davidedmundson 
wrote:
  
  > > The Desktop/Plasma Theme KCM has some inconsistencies and doesn't always 
apply the KDE HIG, so this fixes it, makes some other improvements and
  >
  > Where?
  >
  > > renames the KCM to "Plasma Theme".
  >
  > I can only see this.
  
  
  Wrong description, icon and text capitalization.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18247

To: GB_2, #plasma, #vdg
Cc: davidedmundson, #vdg, plasma-devel, #plasma, sukalyanbanga, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18247: Improve Desktop/Plasma Theme KCM

[David Edmundson]

davidedmundson added a comment.


  > The Desktop/Plasma Theme KCM has some inconsistencies and doesn't always 
apply the KDE HIG, so this fixes it, makes some other improvements and
  
  Where?
  
  > renames the KCM to "Plasma Theme".
  
  I can only see this.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18247

To: GB_2, #plasma, #vdg
Cc: davidedmundson, #vdg, plasma-devel, #plasma, sukalyanbanga, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18247: Improve Desktop/Plasma Theme KCM

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Similar to D18206 .
  The Desktop/Plasma Theme KCM has some inconsistencies and doesn't always 
apply the KDE HIG, so this fixes it, makes some other improvements and renames 
the KCM to "Plasma Theme".

TEST PLAN
  Open the Desktop/Plasma Theme KCM

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-desktoptheme-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18247

AFFECTED FILES
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm_desktoptheme.desktop
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/package/metadata.desktop

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18244: Check for python-cairo

[David Edmundson]

davidedmundson added a comment.


  Which change of that is relevant?

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18244

To: davidedmundson, #plasma, ngraham
Cc: ngraham, zzag, plasma-devel, sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18245: [DrKonqi] Create QApplication in a scope to fix possible deadlock

[Harald Sitter]

sitter added a comment.


  please provide some backtraces. This looks like a hack, the qa decidedly 
shouldn't get stuck on destruction just because cleanup already ran.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18245

To: croick, sitter, #kdevelop
Cc: plasma-devel, sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18019: [Digital Clock] Add ability to set a custom date format string

[Nathaniel Graham]

ngraham added a comment.


  To pad out the 5.15 feature list, maybe? 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18019

To: Zren, #plasma, #vdg
Cc: broulik, karpenyamichael, davidedmundson, abetts, cfeck, ngraham, mart, 
ndavis, rooty, plasma-devel, sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D18244: Check for python-cairo

[Vlad Zagorodniy]

zzag added a comment.


  Well, something like this works fine, though this is a quick and dirty 
solution.
  
if (CMAKE_VERSION VERSION_LESS 3.12.0)
find_package (PythonInterp 3 REQUIRED)
set (_py_exe ${PYTHON_EXECUTABLE})
else ()
find_package (Python 3.0 REQUIRED COMPONENTS Interpreter)
set (_py_exe ${Python_EXECUTABLE})
endif ()

execute_process (COMMAND "${_py_exe}" "-c"
"import re, cairo; 
print(re.compile('/__init__.py.*').sub('',cairo.__file__))"
RESULT_VARIABLE _PY_cairo_status
OUTPUT_VARIABLE _PY_cairo_location
ERROR_QUIET
OUTPUT_STRIP_TRAILING_WHITESPACE
)

if (_PY_cairo_status EQUAL 0)
set (PY_CAIRO ${_PY_cairo_location} CACHE STRING "Location of pycairo")
endif ()

find_package_handle_standard_args (PythonCairo DEFAULT_MSG PY_CAIRO)

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18244

To: davidedmundson, #plasma, ngraham
Cc: ngraham, zzag, plasma-devel, sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18244: Check for python-cairo

[Nathaniel Graham]

ngraham added a comment.


$  (arcpatch-D18244) cmake -DCMAKE_INSTALL_PREFIX=/usr  
-DPYTHON_EXECUTABLE=/usr/bin/python3 .
-- The following RUNTIME packages have been found:

 * GTKEngine, Pixmap/Pixbuf theme engine for GTK 2, 
   Required for GTK 2 theme

-- The following REQUIRED packages have been found:

 * ECM (required version >= 0.0.9)
 * Sass, SASS compiler, 
   Required for building GTK themes
 * PythonInterp (required version >= 3)
 * PythonCairo
   Required to render assets
 * Breeze
   Required to build the Breeze GTK+ styles
 * Qt5
 * Qt5Core

-- Configuring done
-- Generating done
-- Build files have been written to: /home/dev/repos/breeze-gtk
  
  Trying Python 2:
  
dev@dev-pc:~/repos/breeze-gtk$  (arcpatch-D18244) cmake 
-DCMAKE_INSTALL_PREFIX=/usr  -DPYTHON_EXECUTABLE=/usr/bin/python2 .
CMake Error at 
/usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
  Could NOT find PythonInterp: Found unsuitable version "2.7.15", but
  required is at least "3" (found /usr/bin/python2)
Call Stack (most recent call first):
  /usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:376 
(_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake-3.10/Modules/FindPythonInterp.cmake:152 
(FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  cmake/FindPythonCairo.cmake:2 (find_package)
  CMakeLists.txt:13 (find_package)


-- Configuring incomplete, errors occurred!
See also "/home/dev/repos/breeze-gtk/CMakeFiles/CMakeOutput.log".

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18244

To: davidedmundson, #plasma, ngraham
Cc: ngraham, zzag, plasma-devel, sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18246: Fix premature firing of allInitialized signal

[Dan Leinir Turthra Jensen]

leinir created this revision.
leinir added reviewers: apol, ngraham, Discover Software Store.
leinir added a project: Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  In case this is in fact the first backend to be added, and also happens to be 
pre-filled, we still need for the rest of the backends to be added before 
trying to send out the initialized signal. To ensure this happens, this patch 
schedules it for the start of the next run of the event loop, and ensures that 
it only happens if there are no more backends to initialise.
  
  Specifically, this happens if e.g. the fwupd backend is the first to be 
initialised, and results in (amongst other things) that the application loads 
up and insists that there are no application backends.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18246

AFFECTED FILES
  libdiscover/resources/ResourcesModel.cpp

To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, sukalyanbanga, jraleigh, bam, GB_2, masilva, ragreen, ixoos, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18244: Check for python-cairo

[David Edmundson]

davidedmundson added a comment.


  and/or change python_executable to Python3_EXECUTABLE

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18244

To: davidedmundson, #plasma, ngraham
Cc: ngraham, zzag, plasma-devel, sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18244: Check for python-cairo

[David Edmundson]

davidedmundson added a comment.


  @zzag could you run with
  
  cmake -DPYTHON_EXECUTABLE=/usr/bin/python3

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18244

To: davidedmundson, #plasma, ngraham
Cc: ngraham, zzag, plasma-devel, sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18244: Check for python-cairo

[Nathaniel Graham]

ngraham added a comment.


  In D18244#392953 , @zzag wrote:
  
  > For me it fails even though I have python-cairo installed, e.g.
  >
  >$ python
  >Python 3.7.2 (default, Jan 10 2019, 23:51:51) 
  >[GCC 8.2.1 20181127] on linux
  >Type "help", "copyright", "credits" or "license" for more information.
  >   >>> import cairo
  >   >>> cairo.__file__
  >'/usr/lib/python3.7/site-packages/cairo/__init__.py'
  >   >>> 
  >   
  
  
  That's strange. Here's my output:
  
$  (arcpatch-D18244) cmake -DCMAKE_INSTALL_PREFIX=/usr .
-- The following RUNTIME packages have been found:

 * GTKEngine, Pixmap/Pixbuf theme engine for GTK 2, 
   Required for GTK 2 theme

-- The following REQUIRED packages have been found:

 * ECM (required version >= 0.0.9)
 * Sass, SASS compiler, 
   Required for building GTK themes
 * PythonInterp (required version >= 3)
 * PythonCairo
   Required to render assets
 * Breeze
   Required to build the Breeze GTK+ styles
 * Qt5
 * Qt5Core

-- Configuring done
-- Generating done
-- Build files have been written to: /home/dev/repos/breeze-gtk

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18244

To: davidedmundson, #plasma, ngraham
Cc: ngraham, zzag, plasma-devel, sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18245: [DrKonqi] Create QApplication in a scope to fix possible deadlock

[Christoph Roick]

croick created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
croick requested review of this revision.

REVISION SUMMARY
  Observed with a crashing KDevelop:
  If the QApplication is destructed after cleanup of the DrKonqi
  backend, somehow a DrKonqi-thread of the QDBusConnection may be
  blocked by the debuggee (poll() being stuck according to strace).
  Since DrKonqi then cannot quit, KCrash continues waiting, leading
  to a deadlock. The situation may be disentangled by externally
  sending SIGSTOP to the debuggee.
  
  Cleaning up the QApplication first and afterwards the backend
  omits the deadlock.

TEST PLAN
  - let kdevelop crash to fire up DrKonqi
  - close DrKonqi again
  - watch state of crashed kdevelop process

REPOSITORY
  R871 DrKonqi

BRANCH
  scopedqapp

REVISION DETAIL
  https://phabricator.kde.org/D18245

AFFECTED FILES
  src/main.cpp

To: croick
Cc: plasma-devel, sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18244: Check for python-cairo

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Works for me and CMake code looks good. For now we should probably ship this 
here for the 5.15 release, but maybe this should also go into ECM and then we 
can use it from there in subsequent releases?

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18244

To: davidedmundson, #plasma, ngraham
Cc: ngraham, zzag, plasma-devel, sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18244: Check for python-cairo

[Vlad Zagorodniy]

zzag added a comment.


  For me it fails even though I have python-cairo installed, e.g.
  
$ python
Python 3.7.2 (default, Jan 10 2019, 23:51:51) 
[GCC 8.2.1 20181127] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import cairo
>>> cairo.__file__
'/usr/lib/python3.7/site-packages/cairo/__init__.py'
>>>

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D18244

To: davidedmundson, #plasma
Cc: zzag, plasma-devel, sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18239: login screen with same behavior as lockscreen

[Andres Betts]

abetts added a comment.


  I agree with @ngraham here. I feel that it is not always wise to apply the 
same UX everywhere. It might feel right but there are user experiences that are 
common place for other systems and it could become distracting for the user to 
expect one thing and such thing behaves too much outside of that expectation.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18239

To: mart, #plasma, #vdg, ngraham
Cc: abetts, ngraham, davidedmundson, plasma-devel, sukalyanbanga, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, 
apol, mart

D18244: Check for python-cairo

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

TEST PLAN
  Works correctly when installed
  
  Changed cmake locally to "import asdfasdf"
  Got the correct error message and an aborted build

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18244

AFFECTED FILES
  CMakeLists.txt
  cmake/FindPythonCairo.cmake

To: davidedmundson, #plasma
Cc: plasma-devel, sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18239: login screen with same behavior as lockscreen

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  I'm not sold on this for multiple reasons:
  
  1. It's very close to 5.15; I don't thing we should be making consequential 
UI changes to a controversial component three days before tagging.
  2. Due to limitations of the current design, this will just exchange one 
problem (people can't see the pretty login screen wallpaper) for others (people 
get confused by the lack of a visible UI; people get frustrated by the UI 
disappearing before they've made a choice, etc.)
  3. I'm not sure the "no controls are visible before user interaction" UI 
makes sense for a login screen. I tolerated it for the lock screen because 
there's only ever one user there, so immediately typing the password is a 
learnable habit, but the login screen incorporates a user switcher and there 
are more interactive possibilities. Furthermore, having there be basically no 
UI visible after you start up your computer just doesn't seem user-friendly to 
me. Sure, over time, people would get used to it, but is is really an 
improvement? I don't think so. GNOME has this type of design for their login 
screen and I find it really unfriendly and annoying there.
  
  #VDG 's opinions these days are that 
the basic design needs to be looked at in the 5.16 timeframe, because with the 
current design we have no room to maneuver: every time we change one thing it 
regresses something else. That's a sign that the design isn't accommodating our 
needs anymore. See T10325: 5.16 Login screen redesign 


INLINE COMMENTS

> config.qml:4
>  {
> -property string type: "color"
> +property string type: "image"
>  property color color: "#1d99f3" // Plasma blue

Seems unrelated?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18239

To: mart, #plasma, #vdg, ngraham
Cc: ngraham, davidedmundson, plasma-devel, sukalyanbanga, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D17706: Fix lock screen focus

[Andrey Bychkov]

andreyby updated this revision to Diff 49444.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17706?vs=47933=49444

REVISION DETAIL
  https://phabricator.kde.org/D17706

AFFECTED FILES
  greeter/greeterapp.cpp

To: andreyby, davidedmundson
Cc: graesslin, abetts, davidedmundson, plasma-devel, sukalyanbanga, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, 
apol, mart

D14147: Port from GConf to GSettings

[Luca Beltrame]

lbeltrame added a comment.


  Ping! Is this still being looked at? As distributions may phase out 
pulseaudio-gconf, this is important.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D14147

To: nicolasfella, drosca, davidedmundson
Cc: lbeltrame, evpokp, rikmills, broulik, asturmlechner, plasma-devel, 
sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18189: Fix ComboBox

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:4f00b0cabc12: Fix ComboBox (authored by apol).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18189?vs=49258=49439

REVISION DETAIL
  https://phabricator.kde.org/D18189

AFFECTED FILES
  org.kde.desktop/ComboBox.qml
  tests/testComboBox.qml

To: apol, #kirigami, mart
Cc: plasma-devel, sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18239: login screen with same behavior as lockscreen

[David Edmundson]

davidedmundson added a comment.


  Code is fine and I don't have any objections to doing this.
  
  Will let VDG approve or not.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18239

To: mart, #plasma, #vdg
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D17154#392806 , @davidedmundson 
wrote:
  
  > > Are there any strong reasons?
  >
  > It's not installed, so a user can't use it.
  >
  > That means it's only a build tool. As it's a build tool it's very important 
to not get stuff from the host system as it makes things less reproducible.
  
  
  at the very least, it should use XDG_DATA_HOME by default and 
${HOME}/.local/share as a fallback 
(https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html)

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson
Cc: lbeltrame, bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Meeting week 3

[Jonathan Riddell]

 Plasma 5.15 beta is due out on Thursday
 that means I should be writing the announcement today
 but there's not much to announce https://notes.kde.org/p/plasma_5_15

 In other big news, I did a massive merge on breeze-gtk with the
monster patch
 the whole backstory is complex, there was a fork of some really
old github branch
 and the whole git merging was equally shitty
 that still needs some work ASAP to be release ready
 I regret doing it

 - Only returned from vacation Wednesday
 - Mostly E-Mail, Bugzilla, and Phabricator backlog
 - Plasma Dialog no longer messes with Item's visibility
 -- Should fix (work around) flaky containsMouse handling in
e.g. notification popups

 this week
 Kirigami
 * continue with the expandable action groups
 KWin
 * merged kwin review D17265
 Diff 17265 "Fix changing the number of rows via the dbus
protocol" [Closed] https://phabricator.kde.org/D17265
 Plasma
 * fixed the panel controller which sometimes popped up in the
task manager

D17154: Go back to SCSS

[David Edmundson]

davidedmundson added a comment.


  > Are there any strong reasons?
  
  It's not installed, so a user can't use it.
  
  That means it's only a build tool. As it's a build tool it's very important 
to not get stuff from the host system as it makes things less reproducible.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson
Cc: lbeltrame, bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17154: Go back to SCSS

[Luca Beltrame]

lbeltrame added a comment.


  In D17154#391812 , @gepardo wrote:
  
  > Are there any strong reasons?
  
  
  Not everyone has their XDG paths set in ~/.local, even more so when doing 
development.
  
  In addition, I had a look at the script. While I do stuff in Python for a 
living (and for many years) I could not figure out what was the purpose of the 
classes, the functions, and the last part of the generation of the theme is a 
bunch of calls without much context. In short, this needs to be documented, and 
clearly, otherwise it'll be treated as a magic black box and the moment 
something breaks, no one will know how to fix it.
  
  Yes, I'm to blame because I didn't look at it sooner.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson
Cc: lbeltrame, bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, 
plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D18240: [appmenu] set KDED phase

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3fa868a73f87: [appmenu] set KDED phase (authored by 
davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18240?vs=49426=49427

REVISION DETAIL
  https://phabricator.kde.org/D18240

AFFECTED FILES
  appmenu/appmenu.desktop

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18240: [appmenu] set KDED phase

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Without specifying it the default is phase 2.
  Phase 2 is run in parallel with session restore.
  
  BUG: 384392

TEST PLAN
  None.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18240

AFFECTED FILES
  appmenu/appmenu.desktop

To: davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18019: [Digital Clock] Add ability to set a custom date format string

[Kai Uwe Broulik]

broulik added a comment.


  Why was this committed?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18019

To: Zren, #plasma, #vdg
Cc: broulik, karpenyamichael, davidedmundson, abetts, cfeck, ngraham, mart, 
ndavis, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D18239: login screen with same behavior as lockscreen

[Marco Martin]

mart created this revision.
mart added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  start with wallpaper only mode by default, blur background at first
  input

TEST PLAN
  works as before, just starts in wallaper mode which before was triggered 
after waiting for 60 
  seconds

REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/invertlogin

REVISION DETAIL
  https://phabricator.kde.org/D18239

AFFECTED FILES
  sddm-theme/Main.qml
  sddm-theme/dummydata/config.qml

To: mart, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18182: Fix new file creation leading to dupe items on a fresh view

[Oleg Solovyov]

McPain accepted this revision.
McPain added a comment.
This revision is now accepted and ready to land.


  It works, thanks.
  Removed D17689  and D17707 
 patches so I close then

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D18182

To: hein, #plasma, McPain
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17689: [RFC] Positioner: call initMaps even if m_enabled == false

[Oleg Solovyov]

McPain added a comment.


  In D17689#391265 , @hein wrote:
  
  > Here's my take: https://phabricator.kde.org/D18182
  
  
  is this intentional you mentioned *this* review, not 
https://phabricator.kde.org/D17707?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17689

To: McPain, #plasma, hein, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart