D18341: Support icons from local files in buttons

2019-01-17 Thread Kai Uwe Broulik
broulik added a comment.


  `/foo/bar` is not a local URL? `file:///foo/bar` would be. I think you now 
broke the `QString` case?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D18341

To: nicolasfella, #plasma, mart
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D17784: Don't ignore default virtual devices

2019-01-17 Thread Filip Fila
filipf added a comment.


  For context, I filed the bug report 
(https://bugs.kde.org/show_bug.cgi?id=395466) and then David fixed it in D13568 
.
  
  Since I don't think PulseEffects becomes the default device, this should be 
fine.

REVISION DETAIL
  https://phabricator.kde.org/D17784

To: sharhalakis, broulik, drosca
Cc: filipf, ngraham, cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18343: [Imagepackage] Port wallpaper plugins to QQC2

2019-01-17 Thread Nathaniel Graham
ngraham added a comment.


  Good call David!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18343

To: ngraham, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18343: [Imagepackage] Port wallpaper plugins to QQC2

2019-01-17 Thread Nathaniel Graham
ngraham updated this revision to Diff 49779.
ngraham marked an inline comment as done.
ngraham added a comment.


  Keep the QQC1 version of the ComboBox until we've fixed 
tps://bugs.kde.org/show_bug.cgi?id=403153

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18343?vs=49772=49779

BRANCH
  port-imagepackage-plugins-to-qqc2 (branched from Plasma/5.15)

REVISION DETAIL
  https://phabricator.kde.org/D18343

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

To: ngraham, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18347: [wallpapers/image] Don't use PlasmaCore in desktop themed UI

2019-01-17 Thread David Edmundson
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

TEST PLAN
  Runs as before

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18347

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

To: davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D17784: Don't ignore default virtual devices

2019-01-17 Thread Nathaniel Graham
ngraham added a comment.


  Don't worry, reviewers automatically get notified. :)

REVISION DETAIL
  https://phabricator.kde.org/D17784

To: sharhalakis, broulik, drosca
Cc: ngraham, cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D17784: Don't ignore default virtual devices

2019-01-17 Thread Stefanos Harhalakis
sharhalakis added a comment.


  Fixed. I'm not sure if I need to press a button or something to request 
another review though.

REVISION DETAIL
  https://phabricator.kde.org/D17784

To: sharhalakis, broulik, drosca
Cc: cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


KDE CI: Plasma » kwin » stable-kf5-qt5 SUSEQt5.11 - Build # 54 - Failure!

2019-01-17 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/stable-kf5-qt5%20SUSEQt5.11/54/
 Project:
stable-kf5-qt5 SUSEQt5.11
 Date of build:
Fri, 18 Jan 2019 00:14:02 +
 Build duration:
57 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] nodeStill waiting to schedule taskWaiting for next available executor on ‘SUSEQt5.11’Running on Docker Swarm-cd666456a28f in /home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 SUSEQt5.11[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] checkoutCloning the remote Git repositoryCloning repository git://anongit.kde.org/kwin > git init /home/jenkins/workspace/Plasma/kwin/stable-kf5-qt5 SUSEQt5.11 # timeout=10Fetching upstream changes from git://anongit.kde.org/kwin > git --version # timeout=10 > git fetch --tags --progress git://anongit.kde.org/kwin +refs/heads/*:refs/remotes/origin/* # timeout=120ERROR: Error fetching remote repo 'origin'hudson.plugins.git.GitException: Failed to fetch from git://anongit.kde.org/kwin	at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:888)	at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155)	at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186)	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:120)	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:90)	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:77)	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1$1.call(SynchronousNonBlockingStepExecution.java:51)	at hudson.security.ACL.impersonate(ACL.java:290)	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1.run(SynchronousNonBlockingStepExecution.java:48)	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)	at java.util.concurrent.FutureTask.run(FutureTask.java:266)	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)	at java.lang.Thread.run(Thread.java:748)Caused by: hudson.plugins.git.GitException: Command "git fetch --tags --progress git://anongit.kde.org/kwin +refs/heads/*:refs/remotes/origin/*" returned status code 128:stdout: stderr: fatal: read error: Connection reset by peer	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2038)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1757)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:72)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:438)	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153)	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146)	at hudson.remoting.UserRequest.perform(UserRequest.java:212)	at hudson.remoting.UserRequest.perform(UserRequest.java:54)	at hudson.remoting.Request$2.run(Request.java:369)	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)	... 4 more	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to Docker Swarm-cd666456a28f		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1743)		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357)		at hudson.remoting.Channel.call(Channel.java:957)		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)		at sun.reflect.GeneratedMethodAccessor325.invoke(Unknown Source)		at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)		at java.lang.reflect.Method.invoke(Method.java:498)		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)		at com.sun.proxy.$Proxy89.execute(Unknown Source)		at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:886)		at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155)		at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186)		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:120)		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:90)		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:77)		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1$1.call(SynchronousNonBlockingStepExecution.java:51)		at hudson.security.ACL.impersonate(ACL.java:290)		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1.run(SynchronousNonBlockingStepExecution.java:48)		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)		... 4 more > git config remote.origin.url 

D18343: [Imagepackage] Port wallpaper plugins to QQC2

2019-01-17 Thread David Edmundson
davidedmundson added a comment.


  If you want to push everything except the combobox go for it.
  QQC allows us to mix, we should make use of that to do regression-free ports.

INLINE COMMENTS

> config.qml:90
>  }
> -QtControls.ComboBox {
> +ComboBox {
>  id: resizeComboBox

And now we've replaced this bug report with a new one about resizing the menu 
to contents.

I think that'll affect a lot more users.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18343

To: ngraham, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D17784: Don't ignore default virtual devices

2019-01-17 Thread Stefanos Harhalakis
sharhalakis updated this revision to Diff 49776.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17784?vs=48152=49776

REVISION DETAIL
  https://phabricator.kde.org/D17784

AFFECTED FILES
  src/pulseaudio.cpp

To: sharhalakis, broulik, drosca
Cc: cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18343: [Imagepackage] Port wallpaper plugins to QQC2

2019-01-17 Thread Nathaniel Graham
ngraham created this revision.
ngraham added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  BUG: 400549
  FIXED-IN: 5.15.0

TEST PLAN
  On the lock screen KCM at 1.2x scale, before:
  
  After:
  
  All functionality continues to work on the lock screen and SDDM KCMs.
  
  Cannot change plugins to test on the desktop containment window due to a 
pre-existing bug: https://bugs.kde.org/show_bug.cgi?id=403330

REPOSITORY
  R120 Plasma Workspace

BRANCH
  port-imagepackage-plugins-to-qqc2 (branched from Plasma/5.15)

REVISION DETAIL
  https://phabricator.kde.org/D18343

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

To: ngraham, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D17784: Don't ignore default virtual devices

2019-01-17 Thread Christoph Feck
cfeck added inline comments.

INLINE COMMENTS

> pulseaudio.cpp:300
>  it.next();
> -if (it.value()->isVirtualDevice() || it.value()->state() != 
> state) {
> +if ((it.value()->isVirtualDevice()&& !it.value()->isDefault())
> +|| it.value()->state() != state) {

Missing Space: `) &&`

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D17784

To: sharhalakis, broulik, drosca
Cc: cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D13418: Add build dependencies to INSTALL file

2019-01-17 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes.
Closed by commit R884:509a0ca40c36: Add build dependencies to INSTALL file 
(authored by majohnson, committed by aacid).

REPOSITORY
  R884 Active Window Control Applet for Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13418?vs=35795=49767

REVISION DETAIL
  https://phabricator.kde.org/D13418

AFFECTED FILES
  INSTALL

To: majohnson, martinkostolny, mart
Cc: ngraham, aacid, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
skadinna, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18341: Support icons from local files in buttons

2019-01-17 Thread Nicolas Fella
nicolasfella created this revision.
nicolasfella added reviewers: Plasma, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Trying to assign an icon from a file to a button like in
  
import QtQuick 2.2
import QtQuick.Controls 2.4

Button {
icon.source: "/usr/share/icons/breath/emotes/22/face-smirk.svg"
}
  
  results in no icon being shown. The current code interprets the filename as 
QString and tries to load an icon with that name from the theme, which 
obviously doesn't exist. This patch checks whether the icon points to a local 
file 
  and if it is loads it. If not it falls back to loading it from the theme.

TEST PLAN
  Above code now correctly displays a face.
  Ran systemsettings, checked QML KCMs' buttons for icons

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  icons

REVISION DETAIL
  https://phabricator.kde.org/D18341

AFFECTED FILES
  plugin/kquickstyleitem.cpp

To: nicolasfella, #plasma, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18340: [Date & Time KCM] Fix clock display with fractional scale factor

2019-01-17 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:985acbb74657: [Date  Time KCM] Fix clock display 
with fractional scale factor (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18340?vs=49761=49762

REVISION DETAIL
  https://phabricator.kde.org/D18340

AFFECTED FILES
  kcms/dateandtime/dtime.cpp

To: ngraham, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18340: [Date & Time KCM] Fix clock display with fractional scale factor

2019-01-17 Thread Nathaniel Graham
ngraham created this revision.
ngraham added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  BUG: 396936
  FIXED-IN: 5.12.8

TEST PLAN
  1.2 scale factor, before:
  
  1.2 scale factor: after:
  
  No change at 1x.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-clock-with-fractional-scale-factor (branched from Plasma/5.12)

REVISION DETAIL
  https://phabricator.kde.org/D18340

AFFECTED FILES
  kcms/dateandtime/dtime.cpp

To: ngraham, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D17751: Add shadow to Hour's hand

2019-01-17 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Land on master only please, as this requires a change in Frameworks 5.55.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  hand

REVISION DETAIL
  https://phabricator.kde.org/D17751

To: shubham, mart, hein, #vdg, ngraham, davidedmundson
Cc: ndavis, abetts, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart


D18314: Cosmetic fixes for build_theme.sh

2019-01-17 Thread Nathaniel Graham
ngraham added a comment.


  lol too fast for me

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D18314

To: gepardo, davidedmundson
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18314: Cosmetic fixes for build_theme.sh

2019-01-17 Thread Nathaniel Graham
ngraham added a comment.


  @davidedmundson should we land this to the 5.15 branch, or just master?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D18314

To: gepardo, davidedmundson
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18314: Cosmetic fixes for build_theme.sh

2019-01-17 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R98:6a6a432546bb: Cosmetic fixes for build_theme.sh (authored 
by gepardo, committed by davidedmundson).

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18314?vs=49704=49759

REVISION DETAIL
  https://phabricator.kde.org/D18314

AFFECTED FILES
  src/build_theme.sh

To: gepardo, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18321: support for the concept of expandible items

2019-01-17 Thread Alessandro Longo
alex-l added a comment.


  Very cool!

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18321

To: mart, #kirigami
Cc: alex-l, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein


D18320: Search-enable the application page

2019-01-17 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks for the copious code comments. Definitely makes things easier to 
understand in the future.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18320

To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


KDE CI: Plasma » breeze-gtk » stable-kf5-qt5 FreeBSDQt5.12 - Build # 4 - Fixed!

2019-01-17 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/breeze-gtk/job/stable-kf5-qt5%20FreeBSDQt5.12/4/
 Project:
stable-kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 17 Jan 2019 16:40:07 +
 Build duration:
1 min 23 sec and counting

D17751: Add shadow to Hour's hand

2019-01-17 Thread Shubham
shubham updated this revision to Diff 49728.
shubham added a comment.


  Updating D17751 : Add shadow to Hour's 
hand
  Use harcoded pixel values

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17751?vs=49656=49728

BRANCH
  hand

REVISION DETAIL
  https://phabricator.kde.org/D17751

AFFECTED FILES
  applets/analog-clock/contents/ui/analogclock.qml

To: shubham, mart, hein, #vdg, ngraham, davidedmundson
Cc: ndavis, abetts, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart


freedesktop.notifications daemon - crossplatform alternatives?

2019-01-17 Thread René J . V . Bertin
Hi,

Sorry for a somewhat off-topic question.

As far as I can tell the KF5/Plasma5 freedesktop notifications implementation 
is really not easily isolated even if it probably would be cross-platform. (I 
can run the systray widget in plasma-windowed, but that isn't really 
satisfactory.)

Why the cross-platform interest? Much KF5 software uses freedestop 
notifications that run over DBus, also when running on Mac or MS Windows, and 
evidently it would make sense to show them there too. Esp. if that could 
somehow be done via the native notification interface, with or without a 
control widget in the "systray" (menuextras on Mac).

Qt does allow that (possibly with a little extra code) so the question here is 
whether a (simple), pure-Qt implementation of a notification daemon already 
exists. Does anyone know?
The closest thing I have found to date is the lxqt notifyd, but that depends on 
liblxqt which requires X11.

Thanks,
R


D18318: Prettify and search enable the error page

2019-01-17 Thread Nathaniel Graham
ngraham added a comment.


  When submitting a patch that involves UI changes, it's always appreciated to 
include a screenshot. Bonus points for both before-and-after screenshots. :)
  
  https://community.kde.org/Infrastructure/Phabricator#Include_some_screenshots

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18318

To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


KDE CI: Plasma » breeze-gtk » stable-kf5-qt5 FreeBSDQt5.12 - Build # 3 - Failure!

2019-01-17 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/breeze-gtk/job/stable-kf5-qt5%20FreeBSDQt5.12/3/
 Project:
stable-kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 17 Jan 2019 14:51:10 +
 Build duration:
3 min 48 sec and counting
   CONSOLE OUTPUT
  [...truncated 164 lines...]Retrieving: Plasma-bluez-qt-stable-kf5-qt5Retrieving: Plasma-baloo-stable-kf5-qt5[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Configuring Build)[Pipeline] sh+ python3 -u ci-tooling/helpers/configure-build.py --product Plasma --project breeze-gtk --branchGroup stable-kf5-qt5 --platform FreeBSDQt5.12 --installTo /home/jenkins/install-prefix/== Using the following environment to perform the build:JOB_NAME  = 'Plasma/breeze-gtk/stable-kf5-qt5 FreeBSDQt5.12'BUILD_NUMBER  = '3'LOGNAME   = 'jenkins'LANG  = 'en_US.UTF-8'JAVA_HOME = '/usr/local/openjdk8-jre'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/breeze-gtk/job/stable-kf5-qt5%20FreeBSDQt5.12/display/redirect'MAIL  = '/var/mail/jenkins'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/breeze-gtk/job/stable-kf5-qt5%20FreeBSDQt5.12/3/display/redirect?page=changes'JENKINS_URL   = 'https://build.kde.org/'PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'JOB_BASE_NAME = 'stable-kf5-qt5 FreeBSDQt5.12'HUDSON_HOME   = '/home/production/data'BUILD_ID  = '3'OLDPWD= '/usr/home/jenkins'PWD   = '/usr/home/jenkins/workspace/Plasma/breeze-gtk/stable-kf5-qt5 FreeBSDQt5.12'_ = '/usr/local/bin/java'TERM  = 'su'NODE_LABELS   = 'FreeBSD Builder 2 FreeBSDQt5.12'BUILD_TAG = 'jenkins-Plasma-breeze-gtk-stable-kf5-qt5 FreeBSDQt5.12-3'BUILD_DISPLAY_NAME= '#3'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/breeze-gtk/job/stable-kf5-qt5%20FreeBSDQt5.12/3/display/redirect'USER  = 'jenkins'HOME  = '/home/jenkins'BUILD_URL = 'https://build.kde.org/job/Plasma/job/breeze-gtk/job/stable-kf5-qt5%20FreeBSDQt5.12/3/'JOB_URL   = 'https://build.kde.org/job/Plasma/job/breeze-gtk/job/stable-kf5-qt5%20FreeBSDQt5.12/'HUDSON_URL= 'https://build.kde.org/'SHELL = '/usr/local/bin/bash'WORKSPACE = '/usr/home/jenkins/workspace/Plasma/breeze-gtk/stable-kf5-qt5 FreeBSDQt5.12'MM_CHARSET= 'UTF-8'STAGE_NAME= 'Configuring Build'NODE_NAME = 'FreeBSD Builder 2'BLOCKSIZE = 'K'EXECUTOR_NUMBER   = '0'SHLVL = '1'CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:symbolize=1'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/breeze-gtk/stable-kf5-qt5 FreeBSDQt5.12"-- The C compiler identification is Clang 6.0.1-- The CXX compiler identification is Clang 6.0.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Found Sass: /usr/local/bin/sassc  -- Found Python3: /usr/local/bin/python3.6 (found version "3.6.8") found components:  Interpreter CMake Error at CMakeLists.txt:15 (find_package):  By not providing "FindBreeze.cmake" in CMAKE_MODULE_PATH this project has  asked CMake to find a package configuration file provided by "Breeze", but  CMake did not find one.  Could not find a package configuration file 

D18314: Cosmetic fixes for build_theme.sh

2019-01-17 Thread Alexander Kernozhitsky
gepardo added a comment.


  @davidedmundson, can you please merge it into master? I don't have a 
developer account, so I can't do this by myself.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  build-script-minor-fixes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18314

To: gepardo, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18322: [Look and Feel and KSplash KCM] Set sourceSize for thumbnail

2019-01-17 Thread David Edmundson
davidedmundson added a comment.


  Setting sourceSize +++
  
  Only thing:
  
  211: void QQuickImageBase::load() {
  258:d->pix.load(qmlEngine(this), loadUrl, d->sourcesize * 
d->devicePixelRatio, options, d->providerOptions);
  
  If you need to change this here we're working around something.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18322

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18322: [Look and Feel and KSplash KCM] Set sourceSize for thumbnail

2019-01-17 Thread Kai Uwe Broulik
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Avoids loading huge screenshots just to show them in a tiny thumbnail.
  It's using `GridView.cellWidth` instead of `width` to avoid reloading the 
image as the layouting is done. Everytime `sourceSize` changes, the image is 
reloaded.

TEST PLAN
  Saves like 10 MB in both KCMS for me
  Verified that the Images are only loaded once upon opening the KCM
  Still looks ok, albeit slightly blurrier, as before `smooth` wasn't set on 
resizing and now it's done in image reader or so.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18322

AFFECTED FILES
  kcms/ksplash/package/contents/ui/main.qml
  kcms/lookandfeel/package/contents/ui/main.qml

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18321: support for the concept of expandible items

2019-01-17 Thread Marco Martin
mart added a comment.


  the Global Drawer Mode section is expanded
  F6553308: Screenshot_20190117_150513.png 


REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18321

To: mart, #kirigami
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein


D18321: support for the concept of expandible items

2019-01-17 Thread Marco Martin
mart created this revision.
mart added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  if an Action has the property expandible, its subactions are shown under it 
in globalDrawer 
  and ContextDrawer
  those actions will disappear when the globaldrawer is collapsed.
  useful to have a more hyerarchical looking sidebars

TEST PLAN
  using it in the gallery and in Koko

REPOSITORY
  R169 Kirigami

BRANCH
  mart/expandibleItems

REVISION DETAIL
  https://phabricator.kde.org/D18321

AFFECTED FILES
  kirigami.qrc
  kirigami.qrc.in
  src/controls/Action.qml
  src/controls/BasicListItem.qml
  src/controls/ContextDrawer.qml
  src/controls/GlobalDrawer.qml
  src/controls/private/ContextDrawerActionItem.qml
  src/controls/private/GlobalDrawerActionItem.qml
  src/controls/templates/OverlayDrawer.qml

To: mart, #kirigami
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein


D18320: Search-enable the application page

2019-01-17 Thread Dan Leinir Turthra Jensen
leinir created this revision.
leinir added reviewers: apol, ngraham, Discover Software Store.
leinir added a project: Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  Usually the application page is not the top level page (you'll usually 
navigate through it using one of the app lists), but when it is, this patch 
ensures that the search field is displayed, and further ensures that the search 
is performed on the full list of resources. This will happen when Discover is 
launched e.g. from krunner or otherwise requested to show a specific 
application on launch.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18320

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18318: Prettify and search enable the error page

2019-01-17 Thread Dan Leinir Turthra Jensen
leinir created this revision.
leinir added reviewers: apol, ngraham, Discover Software Store.
leinir added a project: Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  The prettification is based somewhat on the way the Updates page looks while 
fetching (it was previously just a header and just sort of... boring looking)
  
  The functional difference in this patch is that the search field is enabled, 
should this page be shown as the first thing when Discover opens (and as such 
is the root item in the pagerow). This might for example happen if you attempt 
to pass an application on the commandline which does not exist.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18318

AFFECTED FILES
  discover/qml/DiscoverWindow.qml

To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18189: Fix ComboBox

2019-01-17 Thread Kai Uwe Broulik
broulik added inline comments.

INLINE COMMENTS

> apol wrote in ComboBox.qml:207
> delegateModel property doesn't exist in QQC2.ComboBox. I was never getting a 
> popup.
> 
> http://doc.qt.io/qt-5/qml-qtquick-controls-combobox-members.html
> 
> Also we didn't use to specify a delegate to the ListView

The docs you were looking at are QQC1.

  Q_PROPERTY(QQmlInstanceModel *delegateModel READ delegateModel NOTIFY 
delegateModelChanged FINAL)``` is in `QtQuick.Templates` `ComboBox`, which this 
thing is.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D18189

To: apol, #kirigami, mart
Cc: broulik, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18189: Fix ComboBox

2019-01-17 Thread Kai Uwe Broulik
broulik reopened this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  This breaks mouse wheel interaction

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D18189

To: apol, #kirigami, mart
Cc: broulik, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D11235: [DrKonqi] Request change of ptrace scope from KCrash

2019-01-17 Thread Christoph Roick
croick updated this revision to Diff 49717.
croick added a comment.


  - swap variable declaration

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11235?vs=49710=49717

BRANCH
  ptracer

REVISION DETAIL
  https://phabricator.kde.org/D11235

AFFECTED FILES
  src/CMakeLists.txt
  src/debuggerlaunchers.cpp
  src/debuggerlaunchers.h
  src/ptracer.cpp
  src/ptracer.h
  src/tests/crashtest/crashtest.cpp

To: croick, #plasma_workspaces, #frameworks, ossi
Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


Plasma 5.15 beta

2019-01-17 Thread Jonathan Riddell
Plasma 5.15 beta is now released
https://www.kde.org/announcements/plasma-5.14.90.php


D11235: [DrKonqi] Request change of ptrace scope from KCrash

2019-01-17 Thread Oswald Buddenhagen
ossi added a comment.


  In D11235#395021 , @croick wrote:
  
  > What do you mean? The (internal) debugger is a child of the debuggee.
  
  
  yes, that's why you need setPtracer() - if crashtest was *under* gdb, that 
would be unnecessary. ;)
  (i'm still referring to the enumeration of cases, if that wasn't clear.)

INLINE COMMENTS

> ptracer.cpp:63
> +
> +int bytes = 0, r;
> +while (bytes < msize) {

i meant this line ...
(but your change was good, too).

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11235

To: croick, #plasma_workspaces, #frameworks, ossi
Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.11 - Build # 26 - Fixed!

2019-01-17 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.11/26/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 17 Jan 2019 12:48:03 +
 Build duration:
26 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/8)0%
(0/65)0%
(0/65)0%
(0/3999)0%
(0/2740)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdaemon0%
(0/17)0%
(0/17)0%
(0/1407)0%
(0/1116)daemon.actions.bundled0%
(0/18)0%
(0/18)0%
(0/806)0%
(0/470)daemon.actions.dpms0%
(0/9)0%
(0/9)0%
(0/221)0%
(0/114)daemon.backends.upower0%
(0/13)0%
(0/13)0%
(0/1018)0%
(0/759)kcmodule.activities0%
(0/2)0%
(0/2)0%
(0/195)0%
(0/123)kcmodule.common0%
(0/3)0%
(0/3)0%
(0/156)0%
(0/78)kcmodule.global0%
(0/1)0%
(0/1)0%
(0/79)0%
(0/28)kcmodule.profiles0%
(0/2)0%
(0/2)0%
(0/117)0%
(0/52)

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Failure!

2019-01-17 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/5/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 17 Jan 2019 12:44:39 +
 Build duration:
9 min 42 sec and counting
   CONSOLE OUTPUT
  [...truncated 184 lines...]LANG  = 'en_US.UTF-8'JAVA_HOME = '/usr/local/openjdk8-jre'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/display/redirect'MAIL  = '/var/mail/jenkins'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/5/display/redirect?page=changes'JENKINS_URL   = 'https://build.kde.org/'PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'JOB_BASE_NAME = 'kf5-qt5 FreeBSDQt5.12'HUDSON_HOME   = '/home/production/data'BUILD_ID  = '5'OLDPWD= '/usr/home/jenkins'PWD   = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 FreeBSDQt5.12'_ = '/usr/local/bin/java'TERM  = 'su'NODE_LABELS   = 'FreeBSD Builder 1 FreeBSDQt5.12'BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-kf5-qt5 FreeBSDQt5.12-5'BUILD_DISPLAY_NAME= '#5'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/5/display/redirect'USER  = 'jenkins'HOME  = '/home/jenkins'BUILD_URL = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/5/'JOB_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/'HUDSON_URL= 'https://build.kde.org/'SHELL = '/usr/local/bin/bash'WORKSPACE = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 FreeBSDQt5.12'MM_CHARSET= 'UTF-8'STAGE_NAME= 'Configuring Build'NODE_NAME = 'FreeBSD Builder 1'BLOCKSIZE = 'K'EXECUTOR_NUMBER   = '0'SHLVL = '1'CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:symbolize=1'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 FreeBSDQt5.12"-- The C compiler identification is Clang 6.0.1-- The CXX compiler identification is Clang 6.0.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.54.0") -- Found KF5DocTools: /usr/home/jenkins/install-prefix/lib/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.54.0") -- Found KF5IconThemes: /usr/home/jenkins/install-prefix/lib/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.54.0") -- Found KF5Init: /usr/home/jenkins/install-prefix/lib/cmake/KF5Init/KF5InitConfig.cmake (found version "5.54.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.54.0") -- Found KF5KCMUtils: 

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.11 - Build # 19 - Still Failing!

2019-01-17 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.11/19/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 17 Jan 2019 12:44:39 +
 Build duration:
5 min 49 sec and counting
   CONSOLE OUTPUT
  [...truncated 246 lines...]MORE  = '-sl'WORKSPACE = '/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 SUSEQt5.11'PWD   = '/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 SUSEQt5.11'HUDSON_URL= 'https://build.kde.org/'HOME  = '/home/jenkins/'NODE_NAME = 'Docker Swarm-d8688de1423c'HOST  = 'd8688de1423c'XNLSPATH  = '/usr/X11R6/lib/X11/nls'JOB_NAME  = 'Plasma/kde-cli-tools/kf5-qt5 SUSEQt5.11'XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.11/display/redirect'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.11/19/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.11/'BUILD_DISPLAY_NAME= '#19'XCURSOR_THEME = 'DMZ-Black'SHLVL = '3'BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-kf5-qt5 SUSEQt5.11-19'NODE_LABELS   = 'Docker Swarm-d8688de1423c SUSEQt5.11'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre-1.8.0-openjdk/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'LANG  = 'en_US.UTF-8'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 SUSEQt5.11"-- The C compiler identification is GNU 8.2.1-- The CXX compiler identification is GNU 8.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.54.0") -- Found KF5DocTools: /home/jenkins/install-prefix/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.54.0") -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.54.0") -- Found KF5Init: /home/jenkins/install-prefix/lib64/cmake/KF5Init/KF5InitConfig.cmake (found version "5.54.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.54.0") -- Found KF5KCMUtils: /home/jenkins/install-prefix/lib64/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake (found version "5.54.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.54.0") -- Found KF5Service: 

D18310: Require breeze >= 5.14.90

2019-01-17 Thread David Edmundson
davidedmundson added a comment.


  Oh, I'm really sorry! I hadn't seen this.
  
  Yeah, I was waiting for the .90 too.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D18310

To: heikobecker, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18310: Require breeze >= 5.14.90

2019-01-17 Thread Heiko Becker
heikobecker abandoned this revision.
heikobecker added a comment.


  Superseded by 843bc1cc087451d6debd86fb9f21004c4ad1fbc7 


REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D18310

To: heikobecker, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D11235: [DrKonqi] Request change of ptrace scope from KCrash

2019-01-17 Thread Christoph Roick
croick added a comment.


  > you got the parent-child ordering wrong in the commit message. ^^
  
  What do you mean? The (internal) debugger is a child of the debuggee.
  
$ pstree -pn $(pidof crashtest)
crashtest(17220)─┬─{crashtest}(17221)
 ├─{crashtest}(17222)
 └─drkonqi(17223)─┬─{drkonqi}(17224)
  ├─{drkonqi}(17225)
  ├─{drkonqi}(17231)
  └─gdb(17293)─┬─{gdb}(17294)
   ├─{gdb}(17295)
   └─{gdb}(17296)

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11235

To: croick, #plasma_workspaces, #frameworks, ossi
Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D11235: [DrKonqi] Request change of ptrace scope from KCrash

2019-01-17 Thread Christoph Roick
croick updated this revision to Diff 49710.
croick added a comment.


  - swap lines, declare array for response message where needed

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11235?vs=49705=49710

BRANCH
  ptracer

REVISION DETAIL
  https://phabricator.kde.org/D11235

AFFECTED FILES
  src/CMakeLists.txt
  src/debuggerlaunchers.cpp
  src/debuggerlaunchers.h
  src/ptracer.cpp
  src/ptracer.h
  src/tests/crashtest/crashtest.cpp

To: croick, #plasma_workspaces, #frameworks, ossi
Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16212: [Device Notifier] Add a button to unmount all devices

2019-01-17 Thread Thomas Surrel
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:81db74434cd5: [Device Notifier] Add a button to unmount 
all devices (authored by thsurrel).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16212?vs=49644=49709

REVISION DETAIL
  https://phabricator.kde.org/D16212

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/DeviceItem.qml
  applets/devicenotifier/package/contents/ui/FullRepresentation.qml
  applets/devicenotifier/package/contents/ui/devicenotifier.qml

To: thsurrel, #plasma, #vdg, ngraham, broulik
Cc: abetts, broulik, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart


D11235: [DrKonqi] Request change of ptrace scope from KCrash

2019-01-17 Thread Oswald Buddenhagen
ossi added a comment.


  you got the parent-child ordering wrong in the commit message. ^^

INLINE COMMENTS

> ptracer.cpp:61
> +char msg[msize], rmsg[msize];
> +int bytes = 0, r;
> +sprintf(msg, "%lld", debuggerpid);

this looks stupid, i'd swap the order.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11235

To: croick, #plasma_workspaces, #frameworks, ossi
Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D11235: [DrKonqi] Request change of ptrace scope from KCrash

2019-01-17 Thread Christoph Roick
croick updated this revision to Diff 49705.
croick edited the summary of this revision.
croick added a comment.


  - adjust warning and check for EINTR when polling

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11235?vs=49651=49705

BRANCH
  ptracer

REVISION DETAIL
  https://phabricator.kde.org/D11235

AFFECTED FILES
  src/CMakeLists.txt
  src/debuggerlaunchers.cpp
  src/debuggerlaunchers.h
  src/ptracer.cpp
  src/ptracer.h
  src/tests/crashtest/crashtest.cpp

To: croick, #plasma_workspaces, #frameworks, ossi
Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D18300: [Mouse KCM] Port away from KDELibs4Support

2019-01-17 Thread Alexander Volkov
volkov closed this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18300

To: volkov, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.11 - Build # 35 - Fixed!

2019-01-17 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.11/35/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 17 Jan 2019 11:02:07 +
 Build duration:
23 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/7)0%
(0/23)0%
(0/23)0%
(0/1820)0%
(0/706)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapp0%
(0/3)0%
(0/3)0%
(0/273)0%
(0/126)app.ToolTips0%
(0/1)0%
(0/1)0%
(0/92)0%
(0/18)classic0%
(0/2)0%
(0/2)0%
(0/189)0%
(0/52)core0%
(0/9)0%
(0/9)0%
(0/505)0%
(0/238)icons0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/48)sidebar0%
(0/4)0%
(0/4)0%
(0/426)0%
(0/202)sidebar.ToolTips0%
(0/1)0%
(0/1)0%
(0/93)0%
(0/22)

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.11 - Build # 25 - Still Failing!

2019-01-17 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.11/25/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 17 Jan 2019 10:57:57 +
 Build duration:
23 min and counting
   CONSOLE OUTPUT
  [...truncated 250 lines...]HOME  = '/home/jenkins/'NODE_NAME = 'Docker Swarm-4bcc92d67cdc'HOST  = '4bcc92d67cdc'XNLSPATH  = '/usr/X11R6/lib/X11/nls'JOB_NAME  = 'Plasma/powerdevil/kf5-qt5 SUSEQt5.11'XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.11/display/redirect'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.11/25/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.11/'BUILD_DISPLAY_NAME= '#25'XCURSOR_THEME = 'DMZ-Black'SHLVL = '3'BUILD_TAG = 'jenkins-Plasma-powerdevil-kf5-qt5 SUSEQt5.11-25'NODE_LABELS   = 'Docker Swarm-4bcc92d67cdc SUSEQt5.11'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre-1.8.0-openjdk/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'LANG  = 'en_US.UTF-8'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/powerdevil/kf5-qt5 SUSEQt5.11"-- The C compiler identification is GNU 8.2.1-- The CXX compiler identification is GNU 8.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /home/jenkins/install-prefix/lib64/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.54.0") -- Found KF5Auth: /home/jenkins/install-prefix/lib64/cmake/KF5Auth/KF5AuthConfig.cmake (found version "5.54.0") -- Found KF5IdleTime: /home/jenkins/install-prefix/lib64/cmake/KF5IdleTime/KF5IdleTimeConfig.cmake (found version "5.54.0") -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.54.0") -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.54.0") -- Found KF5Solid: /home/jenkins/install-prefix/lib64/cmake/KF5Solid/KF5SolidConfig.cmake (found version "5.54.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.54.0") -- Found KF5GlobalAccel: /home/jenkins/install-prefix/lib64/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.54.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.54.0") -- Found KF5NotifyConfig: 

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.11 - Build # 18 - Failure!

2019-01-17 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.11/18/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 17 Jan 2019 10:54:53 +
 Build duration:
24 min and counting
   CONSOLE OUTPUT
  [...truncated 246 lines...]MORE  = '-sl'WORKSPACE = '/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 SUSEQt5.11'PWD   = '/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 SUSEQt5.11'HUDSON_URL= 'https://build.kde.org/'HOME  = '/home/jenkins/'NODE_NAME = 'Docker Swarm-1ca094180acc'HOST  = '1ca094180acc'XNLSPATH  = '/usr/X11R6/lib/X11/nls'JOB_NAME  = 'Plasma/kde-cli-tools/kf5-qt5 SUSEQt5.11'XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.11/display/redirect'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.11/18/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.11/'BUILD_DISPLAY_NAME= '#18'XCURSOR_THEME = 'DMZ-Black'SHLVL = '3'BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-kf5-qt5 SUSEQt5.11-18'NODE_LABELS   = 'Docker Swarm-1ca094180acc SUSEQt5.11'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre-1.8.0-openjdk/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'LANG  = 'en_US.UTF-8'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/kde-cli-tools/kf5-qt5 SUSEQt5.11"-- The C compiler identification is GNU 8.2.1-- The CXX compiler identification is GNU 8.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.54.0") -- Found KF5DocTools: /home/jenkins/install-prefix/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.54.0") -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.54.0") -- Found KF5Init: /home/jenkins/install-prefix/lib64/cmake/KF5Init/KF5InitConfig.cmake (found version "5.54.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.54.0") -- Found KF5KCMUtils: /home/jenkins/install-prefix/lib64/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake (found version "5.54.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.54.0") -- Found KF5Service: 

D18314: Cosmetic fixes for build_theme.sh

2019-01-17 Thread Alexander Kernozhitsky
gepardo created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gepardo requested review of this revision.

REVISION SUMMARY
  I saw the changes introduced by https://phabricator.kde.org/D18287. It's a 
really good idea :)
  
  The commit contains some minor fixes into the build script (like quoting "$4" 
parameter)

TEST PLAN
  Builds on my machine. The changes are minor and should not affect anything.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  build-script-minor-fixes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18314

AFFECTED FILES
  src/build_theme.sh

To: gepardo
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


KDE CI: Plasma » breeze-gtk » kf5-qt5 SUSEQt5.11 - Build # 16 - Fixed!

2019-01-17 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20SUSEQt5.11/16/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 17 Jan 2019 10:50:02 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.11 - Build # 34 - Failure!

2019-01-17 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.11/34/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 17 Jan 2019 10:45:12 +
 Build duration:
16 min and counting
   CONSOLE OUTPUT
  [...truncated 255 lines...]XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.11/display/redirect'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.11/34/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.11/'BUILD_DISPLAY_NAME= '#34'XCURSOR_THEME = 'DMZ-Black'SHLVL = '3'BUILD_TAG = 'jenkins-Plasma-systemsettings-kf5-qt5 SUSEQt5.11-34'NODE_LABELS   = 'Docker Swarm-a23e4abf9075 SUSEQt5.11'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre-1.8.0-openjdk/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'LANG  = 'en_US.UTF-8'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/systemsettings/kf5-qt5 SUSEQt5.11"-- The C compiler identification is GNU 8.2.1-- The CXX compiler identification is GNU 8.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Crash: /home/jenkins/install-prefix/lib64/cmake/KF5Crash/KF5CrashConfig.cmake (found version "5.54.0") -- Found KF5ItemViews: /home/jenkins/install-prefix/lib64/cmake/KF5ItemViews/KF5ItemViewsConfig.cmake (found version "5.54.0") -- Found KF5KCMUtils: /home/jenkins/install-prefix/lib64/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake (found version "5.54.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.54.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.54.0") -- Found KF5Service: /home/jenkins/install-prefix/lib64/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.54.0") -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.54.0") -- Found KF5WidgetsAddons: /home/jenkins/install-prefix/lib64/cmake/KF5WidgetsAddons/KF5WidgetsAddonsConfig.cmake (found version "5.54.0") -- Found KF5WindowSystem: /home/jenkins/install-prefix/lib64/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.54.0") -- Found KF5XmlGui: /home/jenkins/install-prefix/lib64/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake (found version "5.54.0") -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.54.0") -- Found KF5Config: 

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.11 - Build # 24 - Failure!

2019-01-17 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.11/24/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 17 Jan 2019 10:45:04 +
 Build duration:
12 min and counting
   CONSOLE OUTPUT
  [...truncated 250 lines...]HOME  = '/home/jenkins/'NODE_NAME = 'Docker Swarm-7be5af07ec25'HOST  = '7be5af07ec25'XNLSPATH  = '/usr/X11R6/lib/X11/nls'JOB_NAME  = 'Plasma/powerdevil/kf5-qt5 SUSEQt5.11'XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.11/display/redirect'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.11/24/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.11/'BUILD_DISPLAY_NAME= '#24'XCURSOR_THEME = 'DMZ-Black'SHLVL = '3'BUILD_TAG = 'jenkins-Plasma-powerdevil-kf5-qt5 SUSEQt5.11-24'NODE_LABELS   = 'Docker Swarm-7be5af07ec25 SUSEQt5.11'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre-1.8.0-openjdk/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'LANG  = 'en_US.UTF-8'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/powerdevil/kf5-qt5 SUSEQt5.11"-- The C compiler identification is GNU 8.2.1-- The CXX compiler identification is GNU 8.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /home/jenkins/install-prefix/lib64/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.54.0") -- Found KF5Auth: /home/jenkins/install-prefix/lib64/cmake/KF5Auth/KF5AuthConfig.cmake (found version "5.54.0") -- Found KF5IdleTime: /home/jenkins/install-prefix/lib64/cmake/KF5IdleTime/KF5IdleTimeConfig.cmake (found version "5.54.0") -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.54.0") -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.54.0") -- Found KF5Solid: /home/jenkins/install-prefix/lib64/cmake/KF5Solid/KF5SolidConfig.cmake (found version "5.54.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.54.0") -- Found KF5GlobalAccel: /home/jenkins/install-prefix/lib64/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.54.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.54.0") -- Found KF5NotifyConfig: 

KDE CI: Plasma » breeze-gtk » kf5-qt5 SUSEQt5.11 - Build # 15 - Still Failing!

2019-01-17 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20SUSEQt5.11/15/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 17 Jan 2019 10:20:52 +
 Build duration:
3 min 14 sec and counting
   CONSOLE OUTPUT
  [...truncated 241 lines...]NODE_NAME = 'Docker Swarm-e7d79552b4cf'HOST  = 'e7d79552b4cf'XNLSPATH  = '/usr/X11R6/lib/X11/nls'JOB_NAME  = 'Plasma/breeze-gtk/kf5-qt5 SUSEQt5.11'XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20SUSEQt5.11/display/redirect'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20SUSEQt5.11/15/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20SUSEQt5.11/'BUILD_DISPLAY_NAME= '#15'XCURSOR_THEME = 'DMZ'SHLVL = '3'BUILD_TAG = 'jenkins-Plasma-breeze-gtk-kf5-qt5 SUSEQt5.11-15'NODE_LABELS   = 'Docker Swarm-e7d79552b4cf SUSEQt5.11'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre-1.8.0-openjdk/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'LANG  = 'en_US.UTF-8'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/breeze-gtk/kf5-qt5 SUSEQt5.11"-- The C compiler identification is GNU 8.2.1-- The CXX compiler identification is GNU 8.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Found Sass: /usr/bin/sassc  -- Found Python3: /usr/bin/python3.6 (found version "3.6.5") found components:  Interpreter Traceback (most recent call last):  File "", line 1, in ModuleNotFoundError: No module named 'cairo'-- The following REQUIRED packages have been found: * ECM (required version >= 0.0.9) * Sass, SASS compiler,Required for building GTK themes * Python3 * Breeze   Required to build the Breeze GTK+ styles * Qt5 * Qt5Core-- The following RUNTIME packages have not been found: * GTKEngine, Pixmap/Pixbuf theme engine for GTK 2,Required for GTK 2 theme-- The following REQUIRED packages have not been found: * PythonCairo   Required to render assetsCMake Error at /usr/share/cmake/Modules/FeatureSummary.cmake:459 (message):  feature_summary() Error: REQUIRED package(s) are missing, aborting CMake  run.Call Stack (most recent call first):  CMakeLists.txt:24 (feature_summary)-- Configuring incomplete, errors occurred!See also "/home/jenkins/workspace/Plasma/breeze-gtk/kf5-qt5 SUSEQt5.11/build/CMakeFiles/CMakeOutput.log".[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

D18309: don't set python exe to undefined

2019-01-17 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes.
Closed by commit R98:51e27ecf4057: dont set python exe to undefined 
(authored by sitter).

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18309?vs=49691=49700

REVISION DETAIL
  https://phabricator.kde.org/D18309

AFFECTED FILES
  cmake/FindPythonCairo.cmake

To: sitter, davidedmundson, fvogt
Cc: fvogt, heikobecker, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D13870: Correct Folder View sizing and representation switch behavior

2019-01-17 Thread Friedrich W. H. Kossebau
kossebau added inline comments.

INLINE COMMENTS

> main.qml:58
> +
> +return undefined;
> +}

This and the same below sadly results in error log output e.g. when testing 
applets with plasmoidviewer:

  
file:///usr/share/plasma/plasmoids/org.kde.desktopcontainment/contents/ui/main.qml:61:5:
 Unable to assign [undefined] to int
  
file:///usr/share/plasma/plasmoids/org.kde.desktopcontainment/contents/ui/main.qml:52:5:
 Unable to assign [undefined] to int

Seems to be able to assign `null` or `undefined` to a property the respective 
property needs to have a `RESET` method defined.

Unsure myself what undefined even should mean here, and whether a RESET method 
is better than just assigning some dummy value here.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13870

To: hein, mart, broulik, mvourlakos
Cc: kossebau, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.11 - Build # 16 - Still unstable!

2019-01-17 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.11/16/
 Project:
stable-kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 17 Jan 2019 09:52:04 +
 Build duration:
1 min 42 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report20%
(2/10)16%
(4/25)16%
(4/25)19%
(493/2542)14%
(214/1483)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskbroadcastnotification0%
(0/1)0%
(0/1)0%
(0/49)0%
(0/22)kcmshell0%
(0/2)0%
(0/2)0%
(0/163)0%
(0/86)kdesu0%
(0/2)0%
(0/2)0%
(0/275)0%
(0/192)keditfiletype23%
(3/13)23%
(3/13)23%
(285/1247)21%
(138/666)keditfiletype.tests100%
(1/1)100%
(1/1)81%
(208/257)41%
(76/186)kioclient0%
(0/1)0%
(0/1)0%
(0/221)0%
(0/116)kmimetypefinder0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/10)kstart0%
(0/2)0%
(0/2)0%
(0/218)0%
(0/166)ksvgtopng0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/4)ktraderclient0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/35)

KDE CI: Plasma » breeze-gtk » kf5-qt5 SUSEQt5.11 - Build # 14 - Still Failing!

2019-01-17 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20SUSEQt5.11/14/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 17 Jan 2019 09:52:05 +
 Build duration:
1 min 11 sec and counting
   CONSOLE OUTPUT
  [...truncated 241 lines...]NODE_NAME = 'Docker Swarm-fc87c795b7d6'HOST  = 'fc87c795b7d6'XNLSPATH  = '/usr/X11R6/lib/X11/nls'JOB_NAME  = 'Plasma/breeze-gtk/kf5-qt5 SUSEQt5.11'XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'LIBGL_DEBUG   = 'quiet'HUDSON_HOME   = '/home/production/data'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20SUSEQt5.11/display/redirect'PROFILEREAD   = 'true'MAIL  = '/var/mail/jenkins'LESSKEY   = '/etc/lesskey.bin'BUILD_URL = 'https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20SUSEQt5.11/14/'SHELL = '/bin/bash'STAGE_NAME= 'Configuring Build'JOB_URL   = 'https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20SUSEQt5.11/'BUILD_DISPLAY_NAME= '#14'XCURSOR_THEME = 'DMZ'SHLVL = '3'BUILD_TAG = 'jenkins-Plasma-breeze-gtk-kf5-qt5 SUSEQt5.11-14'NODE_LABELS   = 'Docker Swarm-fc87c795b7d6 SUSEQt5.11'LOGNAME   = 'jenkins'JRE_HOME  = '/usr/lib64/jvm/jre'XDG_CONFIG_DIRS   = '/home/jenkins/install-prefix/etc/xdg:/etc/xdg'PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'JAVA_BINDIR   = '/usr/lib64/jvm/jre-1.8.0-openjdk/bin'G_BROKEN_FILENAMES= '1'HISTSIZE  = '1000'CPU   = 'x86_64'CVS_RSH   = 'ssh'LESSOPEN  = 'lessopen.sh %s'CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'LANG  = 'en_US.UTF-8'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/breeze-gtk/kf5-qt5 SUSEQt5.11"-- The C compiler identification is GNU 8.2.1-- The CXX compiler identification is GNU 8.2.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Found Sass: /usr/bin/sassc  -- Found Python3: /usr/bin/python3.6 (found version "3.6.5") found components:  Interpreter Traceback (most recent call last):  File "", line 1, in ModuleNotFoundError: No module named 'cairo'-- The following REQUIRED packages have been found: * ECM (required version >= 0.0.9) * Sass, SASS compiler,Required for building GTK themes * Python3 * Breeze   Required to build the Breeze GTK+ styles * Qt5 * Qt5Core-- The following RUNTIME packages have not been found: * GTKEngine, Pixmap/Pixbuf theme engine for GTK 2,Required for GTK 2 theme-- The following REQUIRED packages have not been found: * PythonCairo   Required to render assetsCMake Error at /usr/share/cmake/Modules/FeatureSummary.cmake:459 (message):  feature_summary() Error: REQUIRED package(s) are missing, aborting CMake  run.Call Stack (most recent call first):  CMakeLists.txt:24 (feature_summary)-- Configuring incomplete, errors occurred!See also "/home/jenkins/workspace/Plasma/breeze-gtk/kf5-qt5 SUSEQt5.11/build/CMakeFiles/CMakeOutput.log".[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

D18244: Check for python-cairo

2019-01-17 Thread Christophe Giboudeaux
cgiboudeaux added a comment.


  In D18244#394859 , @rikmills wrote:
  
  > This breaks NeonKubuntu builds, whereas previously the builds were working 
as I explicitly had added python3-cairo to the build depends. It is there 
still, but cmake thinks not.
  >
  > EDIT: seems specific to cmake < 3.12 in Bionic. Kubuntu Cosmic/Disco build 
with cmake 3.12 finds python3-cairo, but fails on another issue probably 
related a different recent commit.
  >
  > 
https://build.neon.kde.org/job/bionic_unstable_kde_breeze-gtk_bin_amd64/51/consoleFull
  >
  > > 02:43:04 -- The following REQUIRED packages have not been found:
  > >  02:43:04 
  > >  02:43:04  * PythonCairo
  > >  02:43:04Required to render assets
  
  
  From the build log:
  
  > 03:42:04 The following NEW packages will be installed:
  > 
  >   [...] libcairo-script-interpreter2{a} libcairo2-dev{a}
  >
  
  python3-cairo isn't installed.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D18244

To: davidedmundson, #plasma, ngraham, cgiboudeaux, zzag
Cc: rikmills, ngraham, zzag, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D18309: don't set python exe to undefined

2019-01-17 Thread Fabian Vogt
fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  Tested with cmake 3.10.2, works.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18309

To: sitter, davidedmundson, fvogt
Cc: fvogt, heikobecker, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart