D18299: ComboBox: fix default delegate

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> broulik wrote in ComboBox.qml:58
> Are you sure this is needed? Qt docs say for that using `ItemDelegate` for a 
> `ComboBox` is recommended as:
> "This ensures that the interaction works as expected, and the popup will 
> automatically close when appropriate. "
> The `currentIndex` change makes sense, though

otherwise it didn't work. I may have overlooked something though.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D18299

To: apol, #frameworks, davidedmundson
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18378: Fix bug 402077 for 5.14.x

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> filechooser.cpp:298
> +if(currentUrl.scheme().isEmpty())
> +currentUrl=QUrl::fromLocalFile(currentFolder);
> +fileDialog->setDirectoryUrl(currentUrl);

KDE coding style:

  if (thing) {
  do stuff;
  }

Spaces around the equals sign please

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18378

To: bero, jgrulich
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18378: Fix bug 402077 for 5.14.x

[Nathaniel Graham]

ngraham added a comment.


  Unfortunately there aren't any more 5.14.x released scheduled. But you could 
target this for the 5.12 LTS branch maybe?

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18378

To: bero
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18378: Fix bug 402077 for 5.14.x

[Bernhard Rosenkraenzer]

bero created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bero requested review of this revision.

REVISION SUMMARY
  This fixes preselecting a filename and directory in xdg-desktop-portal-kde on 
the 5.14.x branch. This bug is already fixed on master by the move to 
KFileWidget instead of QFileDialog -- this fix is less intrusive and probably 
more suitable for another 5.14.x release.
  
  BUG: 402077

TEST PLAN
  Add patch, kill xdg-desktop-portal-kde, go to a website with firefox, select 
"Save Page As", make sure the filename and save directory are correct.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18378

AFFECTED FILES
  src/filechooser.cpp

To: bero
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15304: [WIP] [KCM] Port to QQC2

[Nathaniel Graham]

ngraham updated this revision to Diff 49859.

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15304?vs=49855=49859

REVISION DETAIL
  https://phabricator.kde.org/D15304

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/CardListItem.qml
  src/kcm/package/contents/ui/DeviceComboBox.qml
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/Header.qml
  src/kcm/package/contents/ui/StreamListItem.qml
  src/kcm/package/contents/ui/VolumeSlider.qml
  src/kcm/package/contents/ui/main.qml

To: ngraham, #plasma, drosca
Cc: huftis, nicolasfella, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D15304: [KCM] Port (almost) entirely to QQC2

[Nathaniel Graham]

ngraham updated this revision to Diff 49855.
ngraham added a comment.


  Port entirely away from QQC1 by adopting the QQC2 TabBar

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15304?vs=42512=49855

BRANCH
  arcpatch-D15304

REVISION DETAIL
  https://phabricator.kde.org/D15304

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/main.qml

To: ngraham, #plasma, drosca
Cc: huftis, nicolasfella, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18375: Adjust Latte Dock to libtaskmanager API changes for Wayland

[Michail Vourlakos]

mvourlakos added a comment.


  looks ok, do you think that VirtualDesktop changes should go to another 
commit?
  
  based on 
https://github.com/KDE/plasma-desktop/commit/b0d6eab4a698809ff9f5b7244a975ac467222508
 ?

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18375

To: scoenen, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, lavender, ZrenBot, 
mvourlakos, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18375: Adjust Latte Dock to libtaskmanager API changes for Wayland

[Steffen Coenen]

scoenen created this revision.
scoenen added a reviewer: mvourlakos.
scoenen added a project: Latte Dock.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
scoenen requested review of this revision.

REVISION SUMMARY
  Changes in libtaskmanager in Plasma 5.15 currently break several Latte Dock 
features. This patch ensures that Latte Dock will continue to work when Plasma 
5.15 is released.
  
  BUG: 403358

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18375

AFFECTED FILES
  plasmoid/package/contents/ui/ContextMenu.qml
  plasmoid/package/contents/ui/main.qml
  plasmoid/package/contents/ui/task/TaskDelegate.qml
  plasmoid/package/contents/ui/task/TaskWindows.qml

To: scoenen, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, lavender, ZrenBot, 
mvourlakos, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.11 - Build # 20 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.11/20/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Fri, 18 Jan 2019 21:40:29 +
 Build duration:
2 min 49 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report20%
(2/10)16%
(4/25)16%
(4/25)19%
(493/2552)14%
(212/1483)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskbroadcastnotification0%
(0/1)0%
(0/1)0%
(0/49)0%
(0/22)kcmshell0%
(0/2)0%
(0/2)0%
(0/163)0%
(0/86)kdesu0%
(0/2)0%
(0/2)0%
(0/275)0%
(0/192)keditfiletype23%
(3/13)23%
(3/13)23%
(285/1247)20%
(136/664)keditfiletype.tests100%
(1/1)100%
(1/1)81%
(208/257)41%
(76/186)kioclient0%
(0/1)0%
(0/1)0%
(0/231)0%
(0/118)kmimetypefinder0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/10)kstart0%
(0/2)0%
(0/2)0%
(0/218)0%
(0/166)ksvgtopng0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/4)ktraderclient0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/35)

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.12 - Build # 6 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/6/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 18 Jan 2019 21:40:22 +
 Build duration:
1 min 48 sec and counting
   JUnit Tests
  Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest

D18370: Set libkworkspace minimum version

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Would this string get automatically updated by the release scripts in the 
future?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18370

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18370: Set libkworkspace minimum version

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  CCBUG: 403367

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18370

AFFECTED FILES
  CMakeLists.txt

To: davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17773: Copy to Clipboard in English

[Nathaniel Graham]

ngraham added a comment.


  Oops, wrong bug. Too many tabs open... Correcting the original comment now.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D17773

To: guoyunhe, #plasma, ngraham
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17773: Copy to Clipboard in English

[David Edmundson]

davidedmundson added a comment.


  How can this affect discover?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D17773

To: guoyunhe, #plasma, ngraham
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16093: Consistent arrow key handling in the Informative Alt+Tab skin

[Nathaniel Graham]

ngraham added a comment.


  Yay! Now onto https://bugs.kde.org/show_bug.cgi?id=308331! I tried with 
D16897  but ran into some trouble. It 
works, but the keys are hardcoded rather than reading the key from the global 
shortcuts. What's tricky is that only the key itself should do it, not the key 
plus the modifier (since the user is already holding down a modifier to keep 
the alt-tab switcher open).

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16093

To: Zren, davidedmundson, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18357: [applets/mediaframe] Resize combobox to contents

[Nathaniel Graham]

ngraham added a comment.


  Works, but feels like a workaround. Shouldn't we add a comment indicating 
what bug we're working around?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D18357

To: davidedmundson, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16093: Consistent arrow key handling in the Informative Alt+Tab skin

[Chris Holland]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:80bd32b12a01: Consistent arrow key handling in the 
Informative Alt+Tab skin (authored by Zren).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16093?vs=43263=49829

REVISION DETAIL
  https://phabricator.kde.org/D16093

AFFECTED FILES
  windowswitchers/informative/contents/ui/main.qml

To: Zren, davidedmundson, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16093: Consistent arrow key handling in the Informative Alt+Tab skin

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Yeah, I was probably doing something dumb. Confirmed that this works with 
your test plan.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16093

To: Zren, davidedmundson, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16093: Consistent arrow key handling in the Informative Alt+Tab skin

[Chris Holland]

Zren added a comment.


  I forgot to merge this after david's patch was merged. I just tested this in 
the Neon Beta ISO to confirm the fix still works.
  
  In D16093#359639 , @ngraham wrote:
  
  > Hmm, this does not actually work for me. Seems like it logically should, 
but it doesn't.
  
  
  I'm guessing you didn't restart the `kwin_x11 --replace` process after 
manually patching the qml file, as I believe the old version is still kwin's 
cache/memory. Changing to another skin and back won't reload the skin, you need 
to restart kwin. That or you tested without D16693 
 that forwards keyboard events to the qml 
skin.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16093

To: Zren, davidedmundson
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17773: Copy to Clipboard in English

[Nathaniel Graham]

ngraham added a comment.


  BTW I just discovered that this caused a regression: 
https://bugs.kde.org/show_bug.cgi?id=402104
  
  It's currently publicly visible at 
https://blog.neon.kde.org/index.php/2019/01/17/test-kde-plasma-5-15-beta-with-neon/
 :p

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D17773

To: guoyunhe, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18318: Prettify and search enable the error page

[Nathaniel Graham]

ngraham added a comment.


  +1 for always showing the search field. But that icon looks a bit big. I 
might make it smaller and lose the opacity.
  
  Also, while we're prettifying the error page, how about vertically centering 
everything too?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18318

To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18320: Search-enable the application page

[Nathaniel Graham]

ngraham added a comment.


  Cherry-picked onto the `Plasma/5.15` branch since it's a bugfix that doesn't 
introduce any string changes.
  
  Let's try to land future patches that meet those criteria on the 
`Plasma/5.15` branch during the 5.15 beta period. We need to polish Discover to 
a mirror sheen as much as possible! :)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18320

To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18343: [wallpapers/image] Port wallpaper plugins (mostly) to QQC2

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7e6d0c0b0eeb: [wallpapers/image] Port wallpaper plugins 
(mostly) to QQC2 (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18343?vs=49779=49823

REVISION DETAIL
  https://phabricator.kde.org/D18343

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

To: ngraham, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: KDE file dialog column resize no longer possible?

[Nate Graham]

Yes, this was an intentional change: 
https://cgit.kde.org/kio.git/commit/?id=e504bc1fd56412ee7e9748a0dfafa537977ec1b5

Check out the listed bugs that it fixed! However I understand that it did cause 
some fallout: https://bugs.kde.org/show_bug.cgi?id=401506

I tried to fix that in 
https://cgit.kde.org/kio.git/commit/?id=f28e343063783c6a0a6b925a390a1a1a5e10d91c

But it had to be reverted in 
https://cgit.kde.org/kio.git/commit/?id=9f1b7e879fd2a8e315e564a47e147d90760b0786
 because it caused an unacceptable performance regression.

Essentially what we want to do is auto-size the columns when there's enough 
horizontal space to show everything (i.e. provide a good default view without 
the need for manual adjustment), but when horizontal space is limited, we want 
to ensure that the Name column retains its automatically-determined width and 
give the whole view a scrollbar. I tried a few ways to accomplish this but 
eventually ran into a Qt bug: https://bugreports.qt.io/browse/QTBUG-1248

Assistance would be appreciated. :-)

Nate 


  On Fri, 18 Jan 2019 03:20:26 -0700 René J.V. Bertin  
wrote  
 > Hi, 
 >  
 > Sorry for cross-posting (initially), I'm not certain which list is the most 
 > appropriate. 
 >  
 > It's often been tricky to trigger column resize mode in the KDE file dialog 
 > (when in one of the detailed view modes) but I realise I haven't been able 
 > to do this at all for a little while now. I just checked a Qt example, this 
 > is not a regression in the Qt version I'm using. 
 >  
 > Has resizing support been turned off in KF5 maybe, and if so, where and why? 
 >  
 > Thanks, 
 > René 
 > 

Re: KDE file dialog column resize no longer possible?

[Nate Graham]

Yes, this was an intentional change: 
https://cgit.kde.org/kio.git/commit/?id=e504bc1fd56412ee7e9748a0dfafa537977ec1b5

Check out the listed bugs that it fixed! However I understand that it did cause 
some fallout: https://bugs.kde.org/show_bug.cgi?id=401506

I tried to fix that in 
https://cgit.kde.org/kio.git/commit/?id=f28e343063783c6a0a6b925a390a1a1a5e10d91c

But it had to be reverted in 
https://cgit.kde.org/kio.git/commit/?id=9f1b7e879fd2a8e315e564a47e147d90760b0786
 because it caused an unacceptable performance regression.

Essentially what we want to do is auto-size the columns when there's enough 
horizontal space to show everything (i.e. provide a good default view without 
the need for manual adjustment), but when horizontal space is limited, we want 
to ensure that the Name column retains its automatically-determined width and 
give the whole view a scrollbar. I tried a few ways to accomplish this but 
eventually ran into a Qt bug: https://bugreports.qt.io/browse/QTBUG-1248

Assistance would be appreciated.  :-)

Nate


  On Fri, 18 Jan 2019 03:20:26 -0700 René J.V. Bertin  
wrote  
 > Hi, 
 >  
 > Sorry for cross-posting (initially), I'm not certain which list is the most 
 > appropriate. 
 >  
 > It's often been tricky to trigger column resize mode in the KDE file dialog 
 > (when in one of the detailed view modes) but I realise I haven't been able 
 > to do this at all for a little while now. I just checked a Qt example, this 
 > is not a regression in the Qt version I'm using. 
 >  
 > Has resizing support been turned off in KF5 maybe, and if so, where and why? 
 >  
 > Thanks, 
 > René 
 > 

D18363: [build] Search for kirigami as a runtime dependency

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:89992d14d696: [build] Search for kirigami as a runtime 
dependency (authored by heikobecker).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18363?vs=49814=49822

REVISION DETAIL
  https://phabricator.kde.org/D18363

AFFECTED FILES
  CMakeLists.txt

To: heikobecker, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18362: [build] Search for kirigami as a runtime dependency

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:129dfcfd69d6: [build] Search for kirigami as a runtime 
dependency (authored by heikobecker).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18362?vs=49813=49821

REVISION DETAIL
  https://phabricator.kde.org/D18362

AFFECTED FILES
  CMakeLists.txt

To: heikobecker, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18360: [build] Search for kirigami as a runtime dependency

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:779854fa6431: [build] Search for kirigami as a runtime 
dependency (authored by heikobecker).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18360?vs=49810=49820

REVISION DETAIL
  https://phabricator.kde.org/D18360

AFFECTED FILES
  CMakeLists.txt

To: heikobecker, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18361: libkworkspace: Allow standalone build

[Andreas Sturmlechner]

asturmlechner added a comment.


  For the record, I would have been in support of this. ;)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18361

To: heikobecker
Cc: asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18364: [build] Search for kirigami as a runtime dependency

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:7793c31e0132: [build] Search for kirigami as a runtime 
dependency (authored by heikobecker).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18364?vs=49815=49818

REVISION DETAIL
  https://phabricator.kde.org/D18364

AFFECTED FILES
  CMakeLists.txt

To: heikobecker, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18364: [build] Search for kirigami as a runtime dependency

[Heiko Becker]

heikobecker created this revision.
heikobecker added a reviewer: jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
heikobecker requested review of this revision.

TEST PLAN
  cmake lists kirigami as a found dependency

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  Plasma/5.15

REVISION DETAIL
  https://phabricator.kde.org/D18364

AFFECTED FILES
  CMakeLists.txt

To: heikobecker, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18363: [build] Search for kirigami as a runtime dependency

[Heiko Becker]

heikobecker created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
heikobecker requested review of this revision.

TEST PLAN
  cmake lists kirigami as a found dependency

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  Plasma/5.15

REVISION DETAIL
  https://phabricator.kde.org/D18363

AFFECTED FILES
  CMakeLists.txt

To: heikobecker
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18362: [build] Search for kirigami as a runtime dependency

[Heiko Becker]

heikobecker created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
heikobecker requested review of this revision.

TEST PLAN
  cmake lists kirigami as a found dependency

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.15

REVISION DETAIL
  https://phabricator.kde.org/D18362

AFFECTED FILES
  CMakeLists.txt

To: heikobecker
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18361: libkworkspace: Allow standalone build

[Heiko Becker]

heikobecker abandoned this revision.
heikobecker added a comment.


  Sorry, accidentally uploaded.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18361

To: heikobecker
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18361: libkworkspace: Allow standalone build

[Heiko Becker]

heikobecker created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
heikobecker requested review of this revision.

REVISION SUMMARY
  [build] Search for kirigami as a runtime dependency

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.15

REVISION DETAIL
  https://phabricator.kde.org/D18361

AFFECTED FILES
  CMakeLists.txt

To: heikobecker
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18360: [build] Search for kirigami as a runtime dependency

[Heiko Becker]

heikobecker created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
heikobecker requested review of this revision.

TEST PLAN
  cmake lists kirigami as a found dependency

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.15

REVISION DETAIL
  https://phabricator.kde.org/D18360

AFFECTED FILES
  CMakeLists.txt

To: heikobecker
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18357: [applets/mediaframe] Resize combobox to contents

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Copies the bodge currently present in plasma-workspace wallpaper config.
  
  BUG: 390571

TEST PLAN
  Looked at it

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18357

AFFECTED FILES
  applets/mediaframe/package/contents/ui/ConfigGeneral.qml

To: davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18322: [Look and Feel and KSplash KCM] Set sourceSize for thumbnail

[David Edmundson]

davidedmundson added a comment.


  I put debug in Qt, in qmlscene it works as you'd expect.
  
  In the system settings  case QQuickImage thinks the DPR is always 1.
  
  The relevant window is 
   QQuickWindow(0x55f9aee446d0, visibility=QWindow::Windowed, 
flags=QFlags(Window), title="Offscreen", geometry=336,21 
426x592)
  with window()->effectiveDevicePixelRatio() == 1
  
  It's a bug in the window embedding.
  
  
  
  I have a consistent rule about working round Qt bugs.
  I'll allow it if and only if we understand the root cause and have filed a 
bug or patch upstream and then reference it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18322

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE file dialog column resize no longer possible?

[René J . V . Bertin]

Hi,

Sorry for cross-posting (initially), I'm not certain which list is the most 
appropriate.

It's often been tricky to trigger column resize mode in the KDE file dialog 
(when in one of the detailed view modes) but I realise I haven't been able to 
do this at all for a little while now. I just checked a Qt example, this is not 
a regression in the Qt version I'm using.

Has resizing support been turned off in KF5 maybe, and if so, where and why?

Thanks,
René

D17751: Add shadow to Hour's hand

[Shubham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:975df8f8930c: Add shadow to Hours hand (authored by 
shubham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17751?vs=49728=49796

REVISION DETAIL
  https://phabricator.kde.org/D17751

AFFECTED FILES
  applets/analog-clock/contents/ui/analogclock.qml

To: shubham, mart, hein, #vdg, ngraham, davidedmundson
Cc: ndavis, abetts, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D18320: Search-enable the application page

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:9aa0a7df1395: Search-enable the application page 
(authored by leinir).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18320?vs=49719=49791

REVISION DETAIL
  https://phabricator.kde.org/D18320

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18320: Search-enable the application page

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D18320#395251 , @ngraham wrote:
  
  > Thanks for the copious code comments. Definitely makes things easier to 
understand in the future.
  
  
  i do prefer to overcomment rather than undercomment... i've come back to 
things too many times and gone "huh, must be a reason" and then gone searching 
for ages to discover the reason which, of course, is never just straightforward 
- i want future-me to not squint disappointingly at past-me ;)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18320

To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18318: Prettify and search enable the error page

[Dan Leinir Turthra Jensen]

leinir added a comment.


  Yes, quite, of course :D Was going to post one and got sidetracked ;)
  
  The shot is identical to the previous state, except for two largeish and 
contained bits (hence only the one shot): There is a search field shown here 
where one was missing previously, and there is an icon. No changes to the text 
and its location:
  F6554480: image.png 

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18318

To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18276: Fix KDE Connect volume control

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R994:91b3f5114a81: Fix KDE Connect volume control (authored by 
nicolasfella).

REPOSITORY
  R994 Pulseaudio Qt Bindings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18276?vs=49563=49789

REVISION DETAIL
  https://phabricator.kde.org/D18276

AFFECTED FILES
  src/context.cpp

To: nicolasfella, drosca
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18341: Support icons from local files in buttons

[Nicolas Fella]

nicolasfella added a comment.


  In D18341#395692 , @broulik wrote:
  
  > `/foo/bar` is not a local URL? `file:///foo/bar` would be. I think you now 
broke the `QString` case?
  
  
  qDebug() << icon.value();
  gives QUrl("file:///foo/bar"), even when the original URL was specified 
without scheme
  
  The QString case still works

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D18341

To: nicolasfella, #plasma, mart
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart