D17983: StatusItemNotifier: fix overlays by name with icons by name

[Pino Toscano]

pino added a comment.


  In D17983#388160 , @pino wrote:
  
  > Thanks -- which branch should I push this to? `Plasma/5.12`, `Plasma/5.14`, 
or only `master` for now?
  
  
  ping?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  sni-overlays (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17983

To: pino, apol
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Looks good to me, I woud personally keep the header in the popup menu, at 
least I know I clicked on correct connection.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  vpilo/contextMenu

REVISION DETAIL
  https://phabricator.kde.org/D18504

To: vpilo, #vdg, jgrulich
Cc: broulik, jgrulich, ngraham, abetts, GB_2, plasma-devel, jraleigh, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18571: Add "apply on double-click" feature to most other recent ported KCMs

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  +1 to this. It's nice when you already know what you're doing and want to 
change a setting quickly.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  new-kcms-apply-on-double-click (branched from Plasma/5.15)

REVISION DETAIL
  https://phabricator.kde.org/D18571

To: ngraham, #vdg, #plasma, broulik, ndavis
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18572: [Image wallpaper] Use units from Kirigami rather than PlasmaCore

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

TEST PLAN
  Used it; it still worked and everything looked the same

REPOSITORY
  R120 Plasma Workspace

BRANCH
  units-from-kirigami (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18572

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

To: ngraham, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18571: Add "apply on double-click" feature to most other recent ported KCMs

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The new Colors KCM includes the "apply on double-click" feature requested in 
https://bugs.kde.org/show_bug.cgi?id=398303.
  
  This patch adds that feature to other recently ported KCMs, except for the 
Look And Feel KCM, where there is still an unanswered question regarding how to 
handle the destructive checkbox.

TEST PLAN
  Double-click on the items in the Icons, Plasma Theme, Cursors, and Splash 
Screen KCMs. The new setting is instantly applied.
  
  CCBUG: 398303

REPOSITORY
  R119 Plasma Desktop

BRANCH
  new-kcms-apply-on-double-click (branched from Plasma/5.15)

REVISION DETAIL
  https://phabricator.kde.org/D18571

AFFECTED FILES
  kcms/cursortheme/package/contents/ui/Delegate.qml
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/icons/package/contents/ui/main.qml
  kcms/ksplash/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18519: [KColorSchemeEditor] Turn Save button into Save As

[Andres Betts]

abetts added a comment.


  I guess the way that the new theme is created through the ui is also 
something to consider. Maybe, let's think of a cleaner theme editing process 
and then the save button will be easier to understand?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18519

To: broulik, #plasma, #vdg
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18519: [KColorSchemeEditor] Turn Save button into Save As

[Nathaniel Graham]

ngraham added a comment.


  There's a somewhat awkward-feeling workflow here:
  
  1. Edit a system color scheme
  2. Click Save as... and save it as something else
  
  The config dialog remains open, but suddenly is showing the copy, not the 
original. However it does not show the Apply button.
  
  I think either the window should close after the Save As... Operation, or it 
should update its buttons accordingly.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18519

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18561: Use same intro page system settings icon as in the desktop file

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Stable branch, please. 
https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22

REPOSITORY
  R124 System Settings

BRANCH
  use-same-intropage-systemsettings-icon-as-in-desktop-file (branched from 
master)

REVISION DETAIL
  https://phabricator.kde.org/D18561

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15304: [KCM] Port to QQC2

[Nathaniel Graham]

ngraham added a comment.


  This is working and ready to land, but there's still an option question 
regarding whether we want to commit it now with the hacky workarounds for 
https://bugs.kde.org/show_bug.cgi?id=394296, or fix those first and remove the 
workarounds before committing.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  arcpatch-D15304

REVISION DETAIL
  https://phabricator.kde.org/D15304

To: ngraham, #plasma, drosca
Cc: apol, huftis, nicolasfella, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D15304: [KCM] Port to QQC2

[Nathaniel Graham]

ngraham updated this revision to Diff 50385.
ngraham added a comment.


  Correct comment again

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15304?vs=50328=50385

BRANCH
  arcpatch-D15304

REVISION DETAIL
  https://phabricator.kde.org/D15304

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/CardListItem.qml
  src/kcm/package/contents/ui/DeviceComboBox.qml
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/Header.qml
  src/kcm/package/contents/ui/StreamListItem.qml
  src/kcm/package/contents/ui/VolumeSlider.qml
  src/kcm/package/contents/ui/main.qml

To: ngraham, #plasma, drosca
Cc: apol, huftis, nicolasfella, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D18559: Use correct sidebar back button press color

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Makes sense. Please re-base on the stable branch (`Plasma/5.15`) and land 
there, then merge to master.  Instructions are here: 
https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22

REPOSITORY
  R124 System Settings

BRANCH
  use-correct-sidebar-back-button-press-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18559

To: GB_2, #plasma, #vdg, davidedmundson, ngraham
Cc: ngraham, plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18564: Remove support for KWin's QPA plugin for KWindowSystem

[Martin Flöser]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
graesslin requested review of this revision.

REVISION SUMMARY
  KWin added a plugin for itself, thus it's no longer needed.
  
  See: 02a0561016c22be906350bca68973f2818b727d7 
 in 
kwin.git

REPOSITORY
  R130 Frameworks integration plugin using KWayland

BRANCH
  no-kwin

REVISION DETAIL
  https://phabricator.kde.org/D18564

AFFECTED FILES
  src/windowsystem/wayland.json

To: graesslin, #kwin, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18561: Use same intro page system settings icon as in the desktop file

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Use the same system settings icon in the intro page that is used in the 
desktop file for consistency and compatibilty with other icon themes.

TEST PLAN
  Open the system settings (maybe also with a different icon theme).

REPOSITORY
  R124 System Settings

BRANCH
  use-same-intropage-systemsettings-icon-as-in-desktop-file (branched from 
master)

REVISION DETAIL
  https://phabricator.kde.org/D18561

AFFECTED FILES
  sidebar/package/contents/ui/introPage.qml

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart