D19019: Verify that model.AppPid is defined

[Kai Uwe Broulik]

broulik added a comment.


  Only actual windows have PIDs, the role isn't implemented for startup tasks 
or launchers iirc

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19019

To: serhiyz, #plasma, davidedmundson
Cc: broulik, hein, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19024: Exclude powerdevil from session management

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  I have seen reports of powerdevil sometimes not properly starting, but that's 
probably unrelated to this? It's started by an autostart file I think and isn't 
dbus-activated

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19024

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19028: [ksmserver] Restore legacy sessions

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  5.15 branch please

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19028

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 111 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/111/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 15 Feb 2019 04:42:33 +
 Build duration:
9 min 12 sec and counting
   CONSOLE OUTPUT
  [...truncated 2646 lines...][2019-02-15T04:51:29.727Z] /usr/home/jenkins/install-prefix/include/KF5/KWayland/Server/plasmawindowmanagement_interface.h:116:10: note: 'setVirtualDesktop' has been explicitly marked deprecated here[2019-02-15T04:51:29.727Z] void KWAYLANDSERVER_DEPRECATED setVirtualDesktop(quint32 desktop);[2019-02-15T04:51:29.727Z]  ^[2019-02-15T04:51:29.727Z] /usr/home/jenkins/install-prefix/include/KF5/KWayland/Server/kwaylandserver_export.h:25:53: note: expanded from macro 'KWAYLANDSERVER_DEPRECATED'[2019-02-15T04:51:29.727Z] #  define KWAYLANDSERVER_DEPRECATED __attribute__ ((__deprecated__))[2019-02-15T04:51:29.727Z] ^[2019-02-15T04:51:30.000Z] [ 58%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/__/scripting/scripting_logging.cpp.o[2019-02-15T04:51:31.472Z] [ 58%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/effectModelTest.dir/effectconfig.cpp.o[2019-02-15T04:51:31.472Z] [ 58%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/effectModelTest.dir/compositing.cpp.o[2019-02-15T04:51:31.767Z] Scanning dependencies of target kcm_kwin_virtualdesktops[2019-02-15T04:51:31.767Z] [ 58%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwin_virtualdesktops.dir/virtualdesktops.cpp.o[2019-02-15T04:51:31.767Z] 3 warnings generated.[2019-02-15T04:51:31.767Z] [ 58%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/effectModelTest.dir/test/effectmodeltest.cpp.o[2019-02-15T04:51:32.051Z] [ 58%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/__/screens.cpp.o[2019-02-15T04:51:32.051Z] [ 58%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/effectModelTest.dir/test/modeltest.cpp.o[2019-02-15T04:51:32.051Z] [ 58%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/kwincompositing.dir/compositing.cpp.o[2019-02-15T04:51:32.317Z] [ 58%] Building CXX object CMakeFiles/kwin.dir/client.cpp.o[2019-02-15T04:51:32.317Z] [ 58%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/kwincompositing.dir/effectconfig.cpp.o[2019-02-15T04:51:33.298Z] [ 58%] Building CXX object CMakeFiles/kwin.dir/client_machine.cpp.o[2019-02-15T04:51:34.254Z] [ 58%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/__/orientation_sensor.cpp.o[2019-02-15T04:51:34.254Z] [ 58%] Building CXX object CMakeFiles/kwin.dir/cursor.cpp.o[2019-02-15T04:51:34.513Z] [ 58%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/kwincompositing.dir/kwin_compositing_interface.cpp.o[2019-02-15T04:51:35.100Z] [ 58%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/effectModelTest.dir/kwin_compositing_interface.cpp.o[2019-02-15T04:51:35.100Z] [ 58%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwin_virtualdesktops.dir/animationsmodel.cpp.o[2019-02-15T04:51:35.367Z] [ 58%] Building CXX object CMakeFiles/kwin.dir/debug_console.cpp.o[2019-02-15T04:51:35.367Z] [ 58%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwin_virtualdesktops.dir/desktopsmodel.cpp.o[2019-02-15T04:51:35.945Z] [ 58%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/effectModelTest.dir/kwin_effects_interface.cpp.o[2019-02-15T04:51:36.229Z] [ 58%] Building CXX object CMakeFiles/kwin.dir/tabgroup.cpp.o[2019-02-15T04:51:36.817Z] [ 58%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/effectModelTest.dir/effectModelTest_autogen/mocs_compilation.cpp.o[2019-02-15T04:51:36.817Z] [ 58%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/settings.cpp.o[2019-02-15T04:51:37.087Z] [ 59%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/kwincompositing.dir/kwin_effects_interface.cpp.o[2019-02-15T04:51:37.087Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/focuschain.cpp.o[2019-02-15T04:51:37.360Z] [ 59%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/orientationsensoradaptor.cpp.o[2019-02-15T04:51:37.961Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.12/debug_console.cpp:647:10: warning: comparison of two values with different enumeration types in switch statement ('QVariant::Type' and 'QMetaType::Type') [-Wenum-compare-switch][2019-02-15T04:51:37.961Z] case QMetaType::QRect: {[2019-02-15T04:51:37.961Z]  ^~~~[2019-02-15T04:51:37.961Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.12/debug_console.cpp:643:10: warning: comparison of two values with different enumeration types in switch statement ('QVariant::Type' and 'QMetaType::Type') [-Wenum-compare-switch][2019-02-15T04:51:37.961Z] case QMetaType::QSizeF: {[2019-02-15T04:51:37.961Z]  ^[2019-02-15T04:51:37.961Z] 

D19029: Guard virtualDesktopManagement being accessed before fetched

[David Edmundson]

davidedmundson added a comment.


  The other option is:
  
  connection->roundTrip();
  
  at the end of init, which effectively is a (slightly safer) nested event loop 
until we've send a ping to kwin and back, which indicates that kwin must have 
also finished sending the registry

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19029

To: davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19029: Guard virtualDesktopManagement being accessed before fetched

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  The WaylandPrivate::virtualDesktopManagement object is loaded
  asyncronously.
  
  It's null until we finish fetching the registry.
  
  A code path could call the desktopNames in that time.

TEST PLAN
  Had a crash
  Couldn't reproduce reliably

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19029

AFFECTED FILES
  libtaskmanager/virtualdesktopinfo.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19028: [ksmserver] Restore legacy sessions

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  KSMServer has two modes, the slightly ancient mode (XSMP), and the
  really ancient legacy mode (XSM).
  
  When startup was rewritten in 96a595f1b8602838f065f312bd5b6ae24f8d6ac1 

  we accidentally dropped the call that invokes restore of the legacy
  session as well as the normal mode.
  
  BUG: 404318

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19028

AFFECTED FILES
  ksmserver/startup.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19026: Exclude kuiserver from session management

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Service is DBus activated, we don't want to manually restore it.

TEST PLAN
  Code is copied directly from plasmashell

REPOSITORY
  R120 Plasma Workspace

BRANCH
  davidedmundson/kworkspace2

REVISION DETAIL
  https://phabricator.kde.org/D19026

AFFECTED FILES
  kuiserver/main.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19025: Exclude kscreen backend launcher from session management

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Found in my ksmserverrc being restarted every session.

TEST PLAN
  Code is copied from plasmashell

REPOSITORY
  R110 KScreen Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19025

AFFECTED FILES
  src/backendlauncher/main.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19024: Exclude powerdevil from session management

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  I found this process in my ksmserverrc
  
  This is autostarted through other ways, and there's no useful data that
  should persist across sessions.

TEST PLAN
  Code is copy pasted

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19024

AFFECTED FILES
  daemon/powerdevilapp.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17217: Implement free memory notifier

[Krešimir Čohar]

rooty added a comment.


  My two cents - I really like this idea and  this would be a **very** useful 
feature for those of us that really dislike swap space and have OOM problems 
(one too many browser tabs). But I'd set the intervals at 5-10 or even 20 
minutes (not seconds).
  
  Also, I suggest renaming it to "Memory Limit" or something else (a better 
description).
  
  Otherwise, nice work!

REVISION DETAIL
  https://phabricator.kde.org/D17217

To: McPain, broulik, #vdg, ngraham
Cc: rooty, davidedmundson, graesslin, abetts, ngraham, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, 
apol, mart

D18999: Remove ignored style properties from CSS

[Andrzej Broński]

andrzej1_1 added a comment.


  @ngraham done; I updated revison. My full name is //Andrzej Broński// and my 
email: //andrzej...@o2.pl//.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D18999

To: andrzej1_1, #breeze, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, trickyricky26, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18999: Remove ignored style properties from CSS

[Andrzej Broński]

andrzej1_1 updated this revision to Diff 51720.
andrzej1_1 edited the summary of this revision.
andrzej1_1 added a comment.


  Include fixes for //-GtkExpander-expander-size// and 
//-GtkCheckButton-indicator-size//

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18999?vs=51652=51720

REVISION DETAIL
  https://phabricator.kde.org/D18999

AFFECTED FILES
  src/gtk320/widgets/_base.scss
  src/gtk320/widgets/_treeview.scss

To: andrzej1_1, #breeze, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, trickyricky26, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19011: Thunderbolt KCM and KDED module

[Carl Schwan]

ognarb added inline comments.

INLINE COMMENTS

> fakeserver.h:1
> +#ifndef FAKESERVER_H
> +#define FAKESERVER_H

You forgot to add a GPL license header for this file. Same for:

- autotests/bolt/fakeserver/fakeserver.cpp
- autotests/bolt/kded/kdedtest.cpp
- autotests/bolt/lib/managertest.cpp
- autotests/bolt/lib/devicetest.cpp
- kcms/bolt/package/contents/ui/DeviceList.qml
- kcms/bolt/package/contents/ui/utils.js

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19011

To: dvratil
Cc: ognarb, yurchor, asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18716: Add a TextField component

[Carl Schwan]

ognarb added a comment.


  @mart thanks for the review, I don't have enough time this weekend, but I 
will start working on it next Tuesday :)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18716

To: ognarb, apol, #kirigami, ngraham, mart
Cc: broulik, mart, apol, ngraham, plasma-devel, dkardarakos, davidedmundson, 
hein

D18999: Remove ignored style properties from CSS

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Oh ok. If you want to do that in separate patch, let me know and I'll land 
this one for you.
  
  ...on that subject, can you give me your full name and email address so I can 
land the patch with the correct authorship information?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D18999

To: andrzej1_1, #breeze, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, trickyricky26, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19019: Verify that model.AppPid is defined

[Eike Hein]

hein added a comment.


  Remote clients have no pid, but might be nicer to fix the model to return 0.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19019

To: serhiyz, #plasma, davidedmundson
Cc: hein, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18999: Remove ignored style properties from CSS

[Andrzej Broński]

andrzej1_1 added a comment.


  @ngraham This fix was prepared for totally ignored style properties **only**. 
For example GtkCheckButton:indicator-size 

 cannot be just removed:
  
  > GtkCheckButton:indicator-size has been deprecated since version 3.20 and 
should not be used in newly-written code.
  > 
  > Use CSS min-width and min-height on the indicator node.
  
  This will require adding //CSS// and I am not familiar with //GTK//. But I 
think I will be able to work it out as well, so give me some time and I will 
let you know.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D18999

To: andrzej1_1, #breeze
Cc: ngraham, plasma-devel, jraleigh, GB_2, trickyricky26, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19019: Verify that model.AppPid is defined

[David Edmundson]

davidedmundson added a comment.


  In what situation is it undefined?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19019

To: serhiyz, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19023: [Kickoff] Don't respond to window resizing/tiling shortcuts

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch does for Kickoff what Kicker already does, and sets the maximum 
height
  equal to the minimum height. This makes it no longer respond to window tiling 
and
  maximize keyboard shortcuts.
  
  BUG: 402614
  FIXED-IN: 5.15.1

TEST PLAN
  Apply patch, restart plasmashell, open Kickoff, hit [Meta] + [PgUp]. Kickoff 
closes
  and the shortcut is passed down to the active app instead.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  dont-respond-to-window-management-shortcuts (branched from Plasma/5.15)

REVISION DETAIL
  https://phabricator.kde.org/D19023

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: ngraham, #plasma, hein
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19021: [Digital Clock] Fix 24h tri-state button broken in port to QQC2

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  +1 for fixing the bug, but this should really have a better UI. Using a 
checkbox for more something that has more than just binary on/off states is a 
poor practice because it's never apparent what the third "half checked" state 
actually means. We should more towards turning this into a combobox or radio 
buttons with the options  "System locale default", "Force 12 hour", and "Force 
24 hour" (or something like that).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19021

To: Zren, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19021: [Digital Clock] Fix 24h tri-state button broken in port to QQC2

[Chris Holland]

Zren created this revision.
Zren added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  In 12h system locales (eg: en_US), checked=1 is cast as
  Qt::PartiallyChecked=1 which defaults to the system locale (12h).
  Since it's no longer a tri-state button, the user can't select
  Qt::Checked=2 which forces the 24h state.
  
  BUG: 404292
  
  FIXED-IN: 5.15.1

TEST PLAN
  - Run `LC_TIME="en_US.UTF-8" plasmoidviewer -a org.kde.plasma.digitalclock` 
and confirm it's a 2 state button that doesn't enable 24h clock.
  - Patch 
`/usr/share/plasma/plasmoids/org.kde.plasma.digitalclock/contents/ui/configAppearance.qml`
  - Run `LC_TIME="en_US.UTF-8" plasmoidviewer -a org.kde.plasma.digitalclock` 
and confirm it's a 3 state button that does force the 24h clock.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19021

AFFECTED FILES
  applets/digital-clock/package/contents/ui/configAppearance.qml

To: Zren, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

[Andres Betts]

abetts added a comment.


  In D18893#412372 , @rooty wrote:
  
  > Hey guys so I opened up another diff to deal with the icons specifically: 
D19020 
  >
  > > For this image with the dots and type, shouldn't that be centered and not 
touch the edge of the circle?
  >
  > That works too, but the idea here was to make it seem like it has more 
depth. Not sure though. Still open to any and all suggestions
  
  
  I would suggest to keep elements centered just to follow the general logic of 
the rest of the icons.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18893

To: rooty, #vdg, #plasma, filipf, davidedmundson, ngraham
Cc: abetts, davidedmundson, ngraham, filipf, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

[Krešimir Čohar]

rooty added a comment.


  Hey guys so I opened up another diff to deal with the icons specifically: 
D19020 
  
  > For this image with the dots and type, shouldn't that be centered and not 
touch the edge of the circle?
  
  That works too, but the idea here was to make it seem like it has more depth. 
Not sure though. Still open to any and all suggestions

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18893

To: rooty, #vdg, #plasma, filipf, davidedmundson, ngraham
Cc: abetts, davidedmundson, ngraham, filipf, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

[Krešimir Čohar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ccefa20ae859: [sddm-theme] Add buttons to username prompt 
to make it a full-fledged login… (authored by rooty).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18893?vs=51667=51711

REVISION DETAIL
  https://phabricator.kde.org/D18893

AFFECTED FILES
  sddm-theme/Main.qml

To: rooty, #vdg, #plasma, filipf, davidedmundson, ngraham
Cc: abetts, davidedmundson, ngraham, filipf, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19011: Thunderbolt KCM and KDED module

[Yuri Chornoivan]

yurchor added a comment.


  Thanks in advance for fixing these minor typos.

INLINE COMMENTS

> DeviceView.qml:122
> +function() {
> +console.log("Device " + device.uid + " enrolled 
> successfuly");
> +},

Typo: successfuly -> successfully

> DeviceView.qml:141
> +enabled = true;
> +console.log("Device " + device.uid + " enrolled 
> successfuly");
> +},

Typo: successfuly -> successfully

> utils.js:17
> +if (device.authFlags & Bolt.Bolt.Auth.NoPCIE) {
> +str = i18n("Reduced Funcionality");
> +} else {

Typo: Funcionality -> Functionality

> kded_bolt.notifyrc:23
> +Name=Error during device authorization
> +Comment=An error occured while authorizing or blocking a Thunderbolt device
> +Contexts=errornot

Typo: occured -> occurred

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19011

To: dvratil
Cc: yurchor, asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19019: Verify that model.AppPid is defined

[Serhiy Zahoriya]

serhiyz created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
serhiyz requested review of this revision.

REVISION SUMMARY
  Verify that model.AppPid is defined to avoid error messages on every hover of 
an item in Task Manager.
  
  BUG: 396316

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19019

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml

To: serhiyz
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18991: [containment] Show an inline message when the Desktop Toolbox is hidden

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1a10e201e919: [containment] Show an inline message when 
the Desktop Toolbox is hidden (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18991?vs=51628=51706

REVISION DETAIL
  https://phabricator.kde.org/D18991

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigTweaks.qml

To: ngraham, #vdg, #plasma, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18990: [containment] Modernize tweaks page layout and port to QQC2

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:191a901d09c4: [containment] Modernize tweaks page layout 
and port to QQC2 (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18990?vs=51625=51705

REVISION DETAIL
  https://phabricator.kde.org/D18990

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigTweaks.qml

To: ngraham, #vdg, #plasma, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 110 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/110/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 14 Feb 2019 17:46:41 +
 Build duration:
2 min 30 sec and counting
   CONSOLE OUTPUT
  [...truncated 2643 lines...][2019-02-14T17:49:05.516Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.12/abstract_client.cpp:850:8: warning: 'setVirtualDesktop' is deprecated [-Wdeprecated-declarations][2019-02-14T17:49:05.516Z] w->setVirtualDesktop(isOnAllDesktops() ? 0 : desktop() - 1);[2019-02-14T17:49:05.516Z]^[2019-02-14T17:49:05.516Z] /usr/home/jenkins/install-prefix/include/KF5/KWayland/Server/plasmawindowmanagement_interface.h:116:10: note: 'setVirtualDesktop' has been explicitly marked deprecated here[2019-02-14T17:49:05.516Z] void KWAYLANDSERVER_DEPRECATED setVirtualDesktop(quint32 desktop);[2019-02-14T17:49:05.516Z]  ^[2019-02-14T17:49:05.516Z] /usr/home/jenkins/install-prefix/include/KF5/KWayland/Server/kwaylandserver_export.h:25:53: note: expanded from macro 'KWAYLANDSERVER_DEPRECATED'[2019-02-14T17:49:05.516Z] #  define KWAYLANDSERVER_DEPRECATED __attribute__ ((__deprecated__))[2019-02-14T17:49:05.516Z] ^[2019-02-14T17:49:05.516Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.12/abstract_client.cpp:933:40: warning: 'virtualDesktopRequested' is deprecated [-Wdeprecated-declarations][2019-02-14T17:49:05.516Z] connect(w, ::virtualDesktopRequested, this,[2019-02-14T17:49:05.516Z]^[2019-02-14T17:49:05.516Z] /usr/home/jenkins/install-prefix/include/KF5/KWayland/Server/plasmawindowmanagement_interface.h:244:10: note: 'virtualDesktopRequested' has been explicitly marked deprecated here[2019-02-14T17:49:05.516Z] void KWAYLANDSERVER_DEPRECATED virtualDesktopRequested(quint32 desktop);[2019-02-14T17:49:05.516Z]  ^[2019-02-14T17:49:05.516Z] /usr/home/jenkins/install-prefix/include/KF5/KWayland/Server/kwaylandserver_export.h:25:53: note: expanded from macro 'KWAYLANDSERVER_DEPRECATED'[2019-02-14T17:49:05.516Z] #  define KWAYLANDSERVER_DEPRECATED __attribute__ ((__deprecated__))[2019-02-14T17:49:05.516Z] ^[2019-02-14T17:49:05.516Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.12/abstract_client.cpp:996:16: warning: 'setVirtualDesktop' is deprecated [-Wdeprecated-declarations][2019-02-14T17:49:05.516Z] w->setVirtualDesktop(desktop() - 1);[2019-02-14T17:49:05.516Z]^[2019-02-14T17:49:05.516Z] /usr/home/jenkins/install-prefix/include/KF5/KWayland/Server/plasmawindowmanagement_interface.h:116:10: note: 'setVirtualDesktop' has been explicitly marked deprecated here[2019-02-14T17:49:05.516Z] void KWAYLANDSERVER_DEPRECATED setVirtualDesktop(quint32 desktop);[2019-02-14T17:49:05.516Z]  ^[2019-02-14T17:49:05.516Z] /usr/home/jenkins/install-prefix/include/KF5/KWayland/Server/kwaylandserver_export.h:25:53: note: expanded from macro 'KWAYLANDSERVER_DEPRECATED'[2019-02-14T17:49:05.516Z] #  define KWAYLANDSERVER_DEPRECATED __attribute__ ((__deprecated__))[2019-02-14T17:49:05.516Z] ^[2019-02-14T17:49:05.516Z] [ 59%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/__/screens.cpp.o[2019-02-14T17:49:05.516Z] [ 59%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/effectModelTest.dir/kwin_compositing_interface.cpp.o[2019-02-14T17:49:05.516Z] [ 59%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/__/orientation_sensor.cpp.o[2019-02-14T17:49:06.106Z] [ 59%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/effectModelTest.dir/kwin_effects_interface.cpp.o[2019-02-14T17:49:06.106Z] [ 59%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/effectModelTest.dir/effectModelTest_autogen/mocs_compilation.cpp.o[2019-02-14T17:49:06.711Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/cursor.cpp.o[2019-02-14T17:49:06.711Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/debug_console.cpp.o[2019-02-14T17:49:06.990Z] 3 warnings generated.[2019-02-14T17:49:06.990Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/tabgroup.cpp.o[2019-02-14T17:49:06.990Z] [ 59%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/settings.cpp.o[2019-02-14T17:49:06.990Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/focuschain.cpp.o[2019-02-14T17:49:07.249Z] [ 59%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/orientationsensoradaptor.cpp.o[2019-02-14T17:49:07.525Z] [ 59%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/testScriptedEffectLoader_autogen/mocs_compilation.cpp.o[2019-02-14T17:49:07.785Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/globalshortcuts.cpp.o[2019-02-14T17:49:08.044Z] [ 59%] Linking CXX executable 

D19014: [plasma-pa] Add command to switch all applications to the selected device

[Valerio Pilo]

vpilo created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
vpilo requested review of this revision.

REVISION SUMMARY
  If you have many applications running (e.g. browser tabs) it's very annoying 
to manually switch them all to another device. With this context menu option, 
it's now very easy.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  vpilo/switchStreamsToDevice (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19014

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  src/device.h
  src/sink.cpp
  src/sink.h
  src/source.cpp
  src/source.h

To: vpilo
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19013: [plasma-pa] Increase minimum size of expanded plasmoid

[Valerio Pilo]

vpilo created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
vpilo requested review of this revision.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  vpilo/minimumSize

REVISION DETAIL
  https://phabricator.kde.org/D19013

AFFECTED FILES
  applet/contents/ui/main.qml

To: vpilo
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19009: Use better KDE GTK Config KCM desktop file comment

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R99:bceb50cb8ec3: Use better KDE GTK Config KCM desktop file 
comment (authored by GB_2).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19009?vs=51691=51696

REVISION DETAIL
  https://phabricator.kde.org/D19009

AFFECTED FILES
  kde-gtk-config.desktop

To: GB_2, #plasma, #vdg, ngraham
Cc: #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19006: Use KCM name in KCM header

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:b6ad57fc5fa2: Use KCM name in KCM header (authored by 
GB_2).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19006?vs=51688=51695

REVISION DETAIL
  https://phabricator.kde.org/D19006

AFFECTED FILES
  core/ModuleView.cpp

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19011: Thunderbolt KCM and KDED module

[Daniel Vrátil]

dvratil created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
dvratil requested review of this revision.

REVISION SUMMARY
  The KCM allows user to authorize and store (or forget) the authorization
  of Thunderbolt 3 devices. This is done by communicating with the Bolt
  daemon via DBus (throug libkbolt).
  
  The KDED module listens for new unauthorized devices and shows a
  notification with a button to authorize when such device is connected.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  boltkcm

REVISION DETAIL
  https://phabricator.kde.org/D19011

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/bolt/CMakeLists.txt
  autotests/bolt/data/default.json
  autotests/bolt/fakeserver/CMakeLists.txt
  autotests/bolt/fakeserver/fakedevice.cpp
  autotests/bolt/fakeserver/fakedevice.h
  autotests/bolt/fakeserver/fakemanager.cpp
  autotests/bolt/fakeserver/fakemanager.h
  autotests/bolt/fakeserver/fakeserver.cpp
  autotests/bolt/fakeserver/fakeserver.h
  autotests/bolt/fakeserver/main.cpp
  autotests/bolt/kded/CMakeLists.txt
  autotests/bolt/kded/kdedtest.cpp
  autotests/bolt/lib/CMakeLists.txt
  autotests/bolt/lib/devicetest.cpp
  autotests/bolt/lib/managertest.cpp
  cmake/modules/FindBolt.cmake
  kcms/CMakeLists.txt
  kcms/bolt/CMakeLists.txt
  kcms/bolt/Messages.sh
  kcms/bolt/kcm_bolt.cpp
  kcms/bolt/kcm_bolt.desktop
  kcms/bolt/kcm_bolt.h
  kcms/bolt/package/contents/ui/DeviceList.qml
  kcms/bolt/package/contents/ui/DeviceView.qml
  kcms/bolt/package/contents/ui/main.qml
  kcms/bolt/package/contents/ui/utils.js
  kcms/bolt/package/metadata.desktop
  kded/CMakeLists.txt
  kded/bolt/CMakeLists.txt
  kded/bolt/kded_bolt.cpp
  kded/bolt/kded_bolt.desktop
  kded/bolt/kded_bolt.h
  kded/bolt/kded_bolt.notifyrc
  kded/bolt/main.cpp
  libs/CMakeLists.txt
  libs/bolt/CMakeLists.txt
  libs/bolt/dbushelper.cpp
  libs/bolt/dbushelper.h
  libs/bolt/device.cpp
  libs/bolt/device.h
  libs/bolt/devicemodel.cpp
  libs/bolt/devicemodel.h
  libs/bolt/enum.cpp
  libs/bolt/enum.h
  libs/bolt/interfaces/org.freedesktop.bolt1.device.xml
  libs/bolt/interfaces/org.freedesktop.bolt1.manager.xml
  libs/bolt/manager.cpp
  libs/bolt/manager.h

To: dvratil
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19009: Use better KDE GTK Config KCM desktop file comment

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Use a better KDE GTK Config KCM desktop file comment that is correct and 
consistent with others.
  F6614949: Better KDE GTK Config KCM Desktop File Comment.png 


TEST PLAN
  Open the KDE GTK Config KCM.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  use-better-kde-gtk-config-kcm-desktop-file-comment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19009

AFFECTED FILES
  kde-gtk-config.desktop

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19006: Use KCM name in KCM header

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  A clear bug. I always wondered why the QTWidgets KCMs got their header text 
from the comment field in the desktop file while the QML KCMs got it from the 
KAboutData string. +1 for always consistently using the KAboutData string.
  
  Looks like this results in the Boot Splash KCM having an empty header. Once 
this lands, we need to make sure we fix that before 5.16.

REPOSITORY
  R124 System Settings

BRANCH
  use-kcm-name-in-kcm-header (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19006

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19006: Use KCM name in KCM header

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Use the KCM name in Qt Widgets KCM headers, to make them consistent with 
others.
  F6614892: KCM Name in KCM Header.png 

TEST PLAN
  Open a Qt Widgets KCM like "Widget Style".

REPOSITORY
  R124 System Settings

BRANCH
  use-kcm-name-in-kcm-header (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19006

AFFECTED FILES
  core/ModuleView.cpp

To: GB_2, #plasma, #vdg
Cc: plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18999: Remove ignore style properties from CSS

[Nathaniel Graham]

ngraham added a comment.


  Nice catch. Upon testing, I noticed two remaining warnings from Pavucontrol:
  
$  (arcpatch-D18999) pavucontrol 

(pavucontrol:7385): Gtk-WARNING **: 09:18:56.255: Theme parsing error: 
gtk.css:68:34: The style property GtkCheckButton:indicator-size is deprecated 
and shouldn't be used anymore. It will be removed in a future version

(pavucontrol:7385): Gtk-WARNING **: 09:18:56.256: Theme parsing error: 
gtk.css:72:30: The style property GtkExpander:expander-size is deprecated and 
shouldn't be used anymore. It will be removed in a future version
  
  Can you fix those too?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D18999

To: andrzej1_1, #breeze
Cc: ngraham, plasma-devel, jraleigh, GB_2, trickyricky26, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18896: [plasma-nm] Refresh wifi networks as fast as possible

[Valerio Pilo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:1b49255d81f0: [plasma-nm] Refresh wifi networks as fast 
as possible (authored by vpilo).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18896?vs=51677=51687

REVISION DETAIL
  https://phabricator.kde.org/D18896

AFFECTED FILES
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/main.qml
  kcm/kcm.cpp
  libs/handler.cpp
  libs/handler.h
  mobile/wifi/package/contents/ui/main.qml

To: vpilo, jgrulich, ngraham, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

[Andres Betts]

abetts added a comment.


  In D18893#412025 , @rooty wrote:
  
  > Thanks for accepting the patch!
  >  Should I land this and deal with the icons in another diff? Because this 
is in "plasma-workspace" and the icons are in "plasma-framework"?
  >
  > Then again, I might have to change the code here (the new icons have 
different labels).
  >  This is what I've got so far:
  >  F6614662: image.png 
  
  
  For this image with the dots and type, shouldn't that be centered and not 
touch the edge of the circle?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D18893

REVISION DETAIL
  https://phabricator.kde.org/D18893

To: rooty, #vdg, #plasma, filipf, davidedmundson, ngraham
Cc: abetts, davidedmundson, ngraham, filipf, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D18575: Remove warning before hidding the MenuBar

[Nathaniel Graham]

ngraham added a comment.


  In D18575#411906 , @tcanabrava 
wrote:
  
  > The hidding / displaying the menus should not be the *app* responsability, 
but KXmlGuiWindow. If this code is moved there, all apps that are currently 
doing this manually can benefit the feature and have a tiny bit less code.
  
  
  Yep, strongly agree.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D18575

To: tcanabrava, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Land this now, then let's do the icons in another patch.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D18893

REVISION DETAIL
  https://phabricator.kde.org/D18893

To: rooty, #vdg, #plasma, filipf, davidedmundson, ngraham
Cc: abetts, davidedmundson, ngraham, filipf, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19004: Remove extra nested dbus session

[Bhushan Shah]

bshah added a comment.


  git log says it is needed for systems where dbus-user-session is not installed

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19004

To: davidedmundson, #plasma
Cc: bshah, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19004: Remove extra nested dbus session

[Bhushan Shah]

bshah added a comment.


  Hmm, does git blame tell anything useful?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19004

To: davidedmundson, #plasma
Cc: bshah, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18896: [plasma-nm] Refresh wifi networks as fast as possible

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Looks good. Thank you.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  vpilo/wifiRefresh (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18896

To: vpilo, jgrulich, ngraham, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19004: Remove extra nested dbus session

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  It's not needed if the systemd pam session is loaded. (or presumably CK2
  equivalent)
  
  We rely on this for kwin's logind integration anyway. Therefore the
  extra nested session is pointless.
  More importantly it will break should dbus-broker get used instead of
  the classic dbus daemon.
  
  BUG: 404335

TEST PLAN
  Logged out and in
  Still had DBus
  
  Would be good if bshash can remember the reason he added it

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19004

AFFECTED FILES
  plasmawayland.desktop.cmake

To: davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18896: [plasma-nm] Refresh wifi networks as fast as possible

[Valerio Pilo]

vpilo updated this revision to Diff 51677.
vpilo added a comment.


  - Review comments

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18896?vs=51525=51677

BRANCH
  vpilo/wifiRefresh (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18896

AFFECTED FILES
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/main.qml
  kcm/kcm.cpp
  libs/handler.cpp
  libs/handler.h
  mobile/wifi/package/contents/ui/main.qml

To: vpilo, jgrulich, ngraham, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 109 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/109/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 14 Feb 2019 13:15:45 +
 Build duration:
2 min 25 sec and counting
   CONSOLE OUTPUT
  [...truncated 2642 lines...][2019-02-14T13:18:00.056Z] [ 58%] Building CXX object CMakeFiles/kwin.dir/debug_console.cpp.o[2019-02-14T13:18:00.056Z] [ 58%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/__/screens.cpp.o[2019-02-14T13:18:00.639Z] [ 58%] Building CXX object CMakeFiles/kwin.dir/tabgroup.cpp.o[2019-02-14T13:18:00.639Z] [ 58%] Building CXX object CMakeFiles/kwin.dir/focuschain.cpp.o[2019-02-14T13:18:00.899Z] [ 58%] Linking CXX shared module ../../bin/kcm_kwintabbox.so[2019-02-14T13:18:01.158Z] [ 58%] Built target kcm_kwintabbox[2019-02-14T13:18:01.158Z] [ 58%] Generating ui_compositing.h[2019-02-14T13:18:01.158Z] [ 58%] Generating kwin_compositing_interface.cpp, kwin_compositing_interface.h[2019-02-14T13:18:01.158Z] [ 58%] Generating kwin_effects_interface.cpp, kwin_effects_interface.h[2019-02-14T13:18:01.158Z] [ 58%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/__/orientation_sensor.cpp.o[2019-02-14T13:18:01.158Z] [ 58%] Generating kwin_compositing_interface.moc[2019-02-14T13:18:01.158Z] [ 58%] Generating kwin_effects_interface.moc[2019-02-14T13:18:01.158Z] 3 warnings generated.[2019-02-14T13:18:01.158Z] [ 58%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/settings.cpp.o[2019-02-14T13:18:01.415Z] Scanning dependencies of target kwincompositing[2019-02-14T13:18:01.415Z] [ 58%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/kwincompositing.dir/model.cpp.o[2019-02-14T13:18:01.415Z] [ 58%] Building CXX object CMakeFiles/kwin.dir/globalshortcuts.cpp.o[2019-02-14T13:18:01.675Z] [ 58%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/orientationsensoradaptor.cpp.o[2019-02-14T13:18:01.675Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.12/debug_console.cpp:647:10: warning: comparison of two values with different enumeration types in switch statement ('QVariant::Type' and 'QMetaType::Type') [-Wenum-compare-switch][2019-02-14T13:18:01.675Z] case QMetaType::QRect: {[2019-02-14T13:18:01.675Z]  ^~~~[2019-02-14T13:18:01.675Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.12/debug_console.cpp:643:10: warning: comparison of two values with different enumeration types in switch statement ('QVariant::Type' and 'QMetaType::Type') [-Wenum-compare-switch][2019-02-14T13:18:01.675Z] case QMetaType::QSizeF: {[2019-02-14T13:18:01.675Z]  ^[2019-02-14T13:18:01.675Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.12/debug_console.cpp:639:10: warning: comparison of two values with different enumeration types in switch statement ('QVariant::Type' and 'QMetaType::Type') [-Wenum-compare-switch][2019-02-14T13:18:01.675Z] case QMetaType::QSize: {[2019-02-14T13:18:01.675Z]  ^~~~[2019-02-14T13:18:01.675Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.12/debug_console.cpp:635:10: warning: comparison of two values with different enumeration types in switch statement ('QVariant::Type' and 'QMetaType::Type') [-Wenum-compare-switch][2019-02-14T13:18:01.675Z] case QMetaType::QPointF: {[2019-02-14T13:18:01.675Z]  ^~[2019-02-14T13:18:01.675Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.12/debug_console.cpp:631:10: warning: comparison of two values with different enumeration types in switch statement ('QVariant::Type' and 'QMetaType::Type') [-Wenum-compare-switch][2019-02-14T13:18:01.675Z] case QMetaType::QPoint: {[2019-02-14T13:18:01.675Z]  ^[2019-02-14T13:18:01.951Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/input.cpp.o[2019-02-14T13:18:02.212Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/input_event.cpp.o[2019-02-14T13:18:02.787Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/input_event_spy.cpp.o[2019-02-14T13:18:02.787Z] [ 59%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/testScriptedEffectLoader_autogen/mocs_compilation.cpp.o[2019-02-14T13:18:03.046Z] [ 59%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/kwincompositing.dir/main.cpp.o[2019-02-14T13:18:03.046Z] [ 59%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/kwincompositing.dir/compositing.cpp.o[2019-02-14T13:18:03.613Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/keyboard_input.cpp.o[2019-02-14T13:18:03.613Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.12/input.cpp:1511:23: warning: comparison of integers of different signs: 'qint32' (aka 'int') and 'quint32' (aka 'unsigned int') [-Wsign-compare][2019-02-14T13:18:03.613Z] if (m_touchId != id) {[2019-02-14T13:18:03.613Z] ~ ^  ~~[2019-02-14T13:18:03.613Z] 

D19002: Fix window thumbnails not working since frameworks 5.55

[Mathias Tillman]

mathiastillman closed this revision.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D19002

To: mathiastillman, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

[Krešimir Čohar]

rooty added a comment.


  Thanks for accepting the patch!
  Should I land this and deal with the icons in another diff? Because this is 
in "plasma-workspace" and the icons are in "plasma-framework"?
  
  Then again, I might have to change the code here (the new icons have 
different labels).
  This is what I've got so far:
  F6614556: image.png 
  F6614558: image.png 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D18893

REVISION DETAIL
  https://phabricator.kde.org/D18893

To: rooty, #vdg, #plasma, filipf, davidedmundson
Cc: abetts, davidedmundson, ngraham, filipf, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

KDE CI: Plasma » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 22 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/22/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 14 Feb 2019 12:45:00 +
 Build duration:
11 min and counting
   CONSOLE OUTPUT
  [...truncated 128 lines...][2019-02-14T12:56:15.431Z] SHELL = '/usr/local/bin/bash'[2019-02-14T12:56:15.431Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/kwayland/kf5-qt5 FreeBSDQt5.12'[2019-02-14T12:56:15.431Z] MM_CHARSET= 'UTF-8'[2019-02-14T12:56:15.431Z] STAGE_NAME= 'Configuring Build'[2019-02-14T12:56:15.431Z] NODE_NAME = 'FreeBSD Builder 1'[2019-02-14T12:56:15.431Z] BLOCKSIZE = 'K'[2019-02-14T12:56:15.431Z] EXECUTOR_NUMBER   = '0'[2019-02-14T12:56:15.431Z] SHLVL = '1'[2019-02-14T12:56:15.431Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-02-14T12:56:15.431Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2019-02-14T12:56:15.431Z] PKG_CONFIG_PATH   = '/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2019-02-14T12:56:15.431Z] QT_PLUGIN_PATH= '/usr/local/lib/qca-qt5'[2019-02-14T12:56:15.431Z] XDG_CONFIG_DIRS   = '/usr/local/etc/xdg'[2019-02-14T12:56:15.431Z] QT_SELECT = 'qt5'[2019-02-14T12:56:15.431Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-02-14T12:56:15.431Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:symbolize=1'[2019-02-14T12:56:15.431Z] [2019-02-14T12:56:15.431Z] [2019-02-14T12:56:15.431Z] == Commencing Configuration:[2019-02-14T12:56:15.431Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/kwayland/kf5-qt5 FreeBSDQt5.12"[2019-02-14T12:56:16.239Z] -- The C compiler identification is Clang 6.0.1[2019-02-14T12:56:16.239Z] -- The CXX compiler identification is Clang 6.0.1[2019-02-14T12:56:16.239Z] -- Check for working C compiler: /usr/bin/cc[2019-02-14T12:56:16.534Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-02-14T12:56:16.534Z] -- Detecting C compiler ABI info[2019-02-14T12:56:16.534Z] -- Detecting C compiler ABI info - done[2019-02-14T12:56:16.534Z] -- Detecting C compile features[2019-02-14T12:56:16.793Z] -- Detecting C compile features - done[2019-02-14T12:56:16.793Z] -- Check for working CXX compiler: /usr/bin/c++[2019-02-14T12:56:17.050Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-02-14T12:56:17.050Z] -- Detecting CXX compiler ABI info[2019-02-14T12:56:17.050Z] -- Detecting CXX compiler ABI info - done[2019-02-14T12:56:17.050Z] -- Detecting CXX compile features[2019-02-14T12:56:17.308Z] -- Detecting CXX compile features - done[2019-02-14T12:56:17.308Z] -- [2019-02-14T12:56:17.308Z] [2019-02-14T12:56:17.566Z] -- Found PkgConfig: /usr/local/bin/pkg-config (found version "1.6.0") [2019-02-14T12:56:17.566Z] -- Found Wayland_Client: /usr/local/lib/libwayland-client.so (found version "1.16.0") [2019-02-14T12:56:17.566Z] -- Found Wayland_Server: /usr/local/lib/libwayland-server.so (found version "1.16.0") [2019-02-14T12:56:17.566Z] -- Found Wayland: /usr/local/lib/libwayland-client.so;/usr/local/lib/libwayland-server.so (found suitable version "1.16.0", minimum required is "1.13") found components:  Client Server [2019-02-14T12:56:17.566Z] -- Found WaylandScanner: /usr/local/bin/wayland-scanner  [2019-02-14T12:56:17.566Z] -- Performing Test HAVE_EGL[2019-02-14T12:56:17.566Z] -- Performing Test HAVE_EGL - Failed[2019-02-14T12:56:17.566Z] -- Could NOT find EGL (missing: HAVE_EGL) (found version "1.5")[2019-02-14T12:56:17.566Z] -- Looking for __GLIBC__[2019-02-14T12:56:17.566Z] -- Looking for __GLIBC__ - not found[2019-02-14T12:56:17.566Z] -- Performing Test _OFFT_IS_64BIT[2019-02-14T12:56:17.823Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-02-14T12:56:17.823Z] -- Performing Test HAVE_DATE_TIME[2019-02-14T12:56:17.823Z] -- Performing Test HAVE_DATE_TIME - Success[2019-02-14T12:56:17.823Z] -- Could not set up the appstream test. appstreamcli is missing.[2019-02-14T12:56:17.823Z] -- Looking for linux/input.h[2019-02-14T12:56:17.823Z] -- Looking for linux/input.h - not found[2019-02-14T12:56:17.823Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY[2019-02-14T12:56:17.823Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2019-02-14T12:56:17.823Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2019-02-14T12:56:18.087Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2019-02-14T12:56:18.087Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2019-02-14T12:56:18.087Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2019-02-14T12:56:18.087Z] -- The weston 

D19003: Update visibility of mainItem of the window thumbnail since this is no longer done automatically in KDE Frameworks 5.55.

[Mathias Tillman]

mathiastillman created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mathiastillman requested review of this revision.

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19003

AFFECTED FILES
  plasmoid/package/contents/ui/main.qml

To: mathiastillman
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

[Krešimir Čohar]

rooty updated this revision to Diff 51667.
rooty added a comment.


  Add visible: !inputPanel.keyboardActive

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18893?vs=51303=51667

BRANCH
  arcpatch-D18893

REVISION DETAIL
  https://phabricator.kde.org/D18893

AFFECTED FILES
  sddm-theme/Main.qml

To: rooty, #vdg, #plasma, filipf
Cc: abetts, davidedmundson, ngraham, filipf, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19002: Fix window thumbnails not working since frameworks 5.55

[Michail Vourlakos]

mvourlakos accepted this revision.
mvourlakos added a comment.
This revision is now accepted and ready to land.


  nice, can you commit it?

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D19002

To: mathiastillman, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19002: Fix window thumbnails not working since frameworks 5.55

[Mathias Tillman]

mathiastillman created this revision.
mathiastillman added a reviewer: mvourlakos.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mathiastillman requested review of this revision.

REVISION SUMMARY
  This fixes a problem where window thumbnails are no longer visible since KDE 
Frameworks 5.55. This is caused by 
https://cgit.kde.org/plasma-framework.git/commit/?id=b257029afc3bfcd6366d2c2b910b8d91403ab8a
 which no longer automatically updates the visibility of mainItem of 
PlasmaCore.Dialog.

TEST PLAN
  Ensure window thumbnails are working correctly now

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D19002

AFFECTED FILES
  plasmoid/package/contents/ui/main.qml

To: mathiastillman, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

[Krešimir Čohar]

rooty added a comment.


  In D18893#409907 , @davidedmundson 
wrote:
  
  > From my POV, +1 too.
  
  
  Good point! I'll just add it

REPOSITORY
  R120 Plasma Workspace

BRANCH
  login-prompt-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18893

To: rooty, #vdg, #plasma, filipf
Cc: abetts, davidedmundson, ngraham, filipf, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D18896: [plasma-nm] Refresh wifi networks as fast as possible

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> vpilo wrote in main.qml:78
> I did it for consistency, so in both files there's only one action. It's also 
> useful for debugging.

It would still be one action even if you call "handler.requestScan()" instead 
of adding additional unnecessary layer.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18896

To: vpilo, jgrulich, ngraham, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Remote desktop on Plasma Wayland session

[Jan Grulich]

Hi,

I've spent quite a bit time on remote desktop support for Plasma Wayland 
sessions. I have full mouse support in xdg-desktop-portal-kde and also in Krfb 
so it can be easily tested and used. Problem is that I'm currently blocked by 
my additions to the FakeInput protocol on KWayland and KWin side and I'm 
unable to get this reviewed. The addition is basically just about allowing to 
move with mouse cursor using absolute coordinates, because current API allows 
only relative coordinates. Therefore I would like to kindly ask if someone 
from Plasma/KWin maintainers can look into this so I can get this off my 
plate.

The reviews are here:
KWayland: https://phabricator.kde.org/D18114
KWin: https://phabricator.kde.org/D18115

Also, while mouse support might be enough for someone, we still need keyboard 
support, which I tried to add into the FakeInput protocol as well, but it was 
rejected by Martin as he would like to have a different and more secure way.  
I currently don't have that much time to investigate this further and 
implement myself, but it might be a good idea for a GSoC task, it would just 
need someone from KWin maintainers to help on this front, while I can help on 
the portal side of thing. Are there any volunteers for this? Any idea how all 
of this can be done?

If you want to see a demo of the remote desktop, see the link below, on one 
laptop I used Krfb (server) running on Wayland session and on the other one I 
used Krdc (client).

Link: https://jgrulich.fedorapeople.org/wayland_remote_desktop.mkv

Thanks.

Regards,
Jan

D18896: [plasma-nm] Refresh wifi networks as fast as possible

[Valerio Pilo]

vpilo added inline comments.

INLINE COMMENTS

> jgrulich wrote in main.qml:78
> Since this is just one line function, you can use handler.requestScan() 
> directly as before.

I did it for consistency, so in both files there's only one action. It's also 
useful for debugging.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18896

To: vpilo, jgrulich, ngraham, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18716: Add a TextField component

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> mart wrote in TextField.qml:106
> text will go under both buttons, in order to avoid that, probably anchors 
> should be added to the TextField's contentItem to make space for the buttons.

err, TextField is not a Control, right.

so, it should set leftPadding and rightPadding to the space of the buttons

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18716

To: ognarb, apol, #kirigami, ngraham, mart
Cc: broulik, mart, apol, ngraham, plasma-devel, dkardarakos, davidedmundson, 
hein

D18716: Add a TextField component

[Marco Martin]

mart added a comment.


  also, the name should possibily not conflict with QQC2 TextField, like 
ActionTextField or something like that.

INLINE COMMENTS

> TextField.qml:21
> +import QtQuick 2.5
> +import QtQuick.Controls 2.1
> +import org.kde.kirigami 2.4 as Kirigami

always namespace the controls import as
import QtQuick.Controls 2.1 as Controls

> TextField.qml:89
> +ToolTip {
> +delay: Kirigami.Units.longDuration
> +visible: root.focusSequence != null && root.focusSequence.hovered

the style already sets the correct values for duration and timeout, this line 
should be removed

> TextField.qml:106
> +
> +ToolButton {
> +anchors {

text will go under both buttons, in order to avoid that, probably anchors 
should be added to the TextField's contentItem to make space for the buttons.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18716

To: ognarb, apol, #kirigami, ngraham, mart
Cc: broulik, mart, apol, ngraham, plasma-devel, dkardarakos, davidedmundson, 
hein

D18645: BasicListItem: use specified tint color when transparency is 0

[Marco Martin]

mart added a comment.


  I think i'll introduce an heuristic to analyze the image and decide if it's  
monochrome and drop all this transparent nonsense (would make it a bit 
inefficient as it wuld need to read pixels colors in software but may be 
justified).
  locally i was trying with Shannon entropy of the distribution of either 
colors or gray values, which seems to yeld satisfying results

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18645

To: pwegner, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Redondo]

davidre added a comment.


  I can't think of a reason why it doesn't work for you :/.
  Maybe we can debug this on your side. Or the problem is on my side and it 
only works for me. Maybe someone other can comment if it works for them or not?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: alexde, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18579: Rework Sensor Browser

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 51655.
tcanabrava added a comment.


  - Fix code style
  - re-add assert
  - Fix code style

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18579?vs=50423=51655

BRANCH
  CleanSensorBrowser

REVISION DETAIL
  https://phabricator.kde.org/D18579

AFFECTED FILES
  gui/SensorBrowser.cpp
  gui/SensorBrowser.h

To: tcanabrava
Cc: argonel, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18576: Simpe C updates to ksysguardd code

[Tomaz Canabrava]

This revision was automatically updated to reflect the committed changes.
Closed by commit R106:b4bde28dc7af: Simpe C updates to ksysguardd code 
(authored by tcanabrava).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18576?vs=50419=51654

REVISION DETAIL
  https://phabricator.kde.org/D18576

AFFECTED FILES
  ksysguardd/CMakeLists.txt
  ksysguardd/Command.c
  ksysguardd/PWUIDCache.c
  ksysguardd/conf.c
  ksysguardd/ksysguardd.c

To: tcanabrava, apol
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D18999: Remove ignore style properties from CSS

[Andrzej Broński]

andrzej1_1 created this revision.
andrzej1_1 added a project: Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
andrzej1_1 requested review of this revision.

REVISION SUMMARY
  When I was running //GTK3// application //pavucontrol//, I was getting 
warnings:
  
(pavucontrol:10863): Gtk-WARNING **: 10:09:55.669: Theme parsing error: 
gtk.css:127:35: The style property GtkButton:child-displacement-x is deprecated 
and shouldn't be used anymore. It will be removed in a future version   
   

(pavucontrol:10863): Gtk-WARNING **: 10:09:55.669: Theme parsing error: 
gtk.css:128:35: The style property GtkButton:child-displacement-y is deprecated 
and shouldn't be used anymore. It will be removed in a future version   
   

(pavucontrol:10863): Gtk-WARNING **: 10:09:55.669: Theme parsing error: 
gtk.css:129:34: The style property GtkCheckButton:indicator-size is deprecated 
and shouldn't be used anymore. It will be removed in a future version   


(pavucontrol:10863): Gtk-WARNING **: 10:09:55.669: Theme parsing error: 
gtk.css:130:36: The style property GtkCheckMenuItem:indicator-size is 
deprecated and shouldn't be used anymore. It will be removed in a future 
version 

(pavucontrol:10863): Gtk-WARNING **: 10:09:55.669: Theme parsing error: 
gtk.css:132:46: The style property GtkScrolledWindow:scrollbars-within-bevel is 
deprecated and shouldn't be used anymore. It will be removed in a future 
version   

(pavucontrol:10863): Gtk-WARNING **: 10:09:55.669: Theme parsing error: 
gtk.css:135:30: The style property GtkExpander:expander-size is
deprecated and shouldn't be used anymore. It will be removed in a future 
version   

(pavucontrol:10863): Gtk-WARNING **: 10:09:55.669: Theme parsing error: 
gtk.css:142:29: The style property GtkStatusbar:shadow-type is deprecated and 
shouldn't be used anymore. It will be removed in a future version
  
  This was annoying, so I decided to fix it. Firstly I thought it is a 
application problem, but then I discovered it is //breeze-gtk// issue. For 
example //GTK3// documentation states that:
  
  > GtkStatusbar:shadow-type has been deprecated since version 3.20 and should 
not be used in newly-written code.
  > 
  > Use CSS properties to determine the appearance, the value of this style 
property is ignored.
  
  So if some styles are ignored, I can remove them and get rid of part of 
warnings:
  
  1. I wrote python script for finding all deprecation messages in docs: 
F6614333: find-deprecated-styles.py 
  2. I ran script and saved results to file
  3. I used it to find all ignored properties in CSS:
  
$ find-deprecated-styles.py > /tmp/gtk-deprecated.txt
$ cd breeze-gtk/src/gtk320/
$ cat /tmp/gtk-deprecated.txt | sed -n 's/^ \* \([^ ]*\).*the value of this 
style property is ignored.*$/\1/p' | tr : -  | while read style; do grep -Rn 
$style; done
widgets/_base.scss:40:  -GtkStatusbar-shadow-type: none;
widgets/_base.scss:12:  -GtkButton-child-displacement-x: 0;
widgets/_base.scss:13:  -GtkButton-child-displacement-y: 0;
widgets/_base.scss:16:  -GtkCheckMenuItem-indicator-size: 18;
widgets/_base.scss:24:  -GtkScrolledWindow-scrollbars-within-bevel: 0;
  
  Then I just removed them.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D18999

AFFECTED FILES
  src/gtk320/widgets/_base.scss

To: andrzej1_1
Cc: plasma-devel, jraleigh, GB_2, trickyricky26, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18578: Reduce string objects

[Tomaz Canabrava]

This revision was automatically updated to reflect the committed changes.
Closed by commit R106:91b1f7115bf3: Reduce string objects (authored by 
tcanabrava).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18578?vs=50421=51653

REVISION DETAIL
  https://phabricator.kde.org/D18578

AFFECTED FILES
  gui/ksysguard.cpp

To: tcanabrava, apol
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D18575: Remove warning before hidding the MenuBar

[Tomaz Canabrava]

tcanabrava added a comment.


  In D18575#401418 , @ngraham wrote:
  
  > > No other KDE app does this
  >
  > That's not true. Kate and Gwenview do this too, and for good reason: 
without this warning, there's no way to know how to get the menu bar back again 
if you remove it by accident and/or don't know about the [ctrl] + [m] shortcut.
  >
  > Konsole doesn't show a warning because it's a power user app; presumably 
the user knows what he/she is doing. Dolphin doesn't have this warning because 
it automatically creates a menu-like toolbar button when the menubar is hidden, 
which is an acceptable alternative. But for apps that don't do this or 
something else (e.g. putting the menubar in the titlebar instead) we need to 
show an ugly warning like this.
  
  
  I can argue that the ksysguard is also a power user app, but I'll now argue 
something else:
  The hidding / displaying the menus should not be the *app* responsability, 
but KXmlGuiWindow. If this code is moved there, all apps that are currently 
doing this manually can benefit the feature and have a tiny bit less code.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D18575

To: tcanabrava, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart