D19467: [colors-kcm] Fix blurry previews

[Kai Uwe Broulik]

broulik added a comment.


  Looks like KCM GridView should round the cell sizes to avoid non-integer 
pixel alignment

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19467

To: filipf, broulik, #vdg, rooty, davidedmundson
Cc: davidedmundson, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19419: [KdePlasma-Addons/POTD/NOAA] Fixed RegEx string to suit latest changes on the webpage

[Tagore Chandan Reddy]

tagorechandanreddy added a comment.


  The HTML of the webpage is updated with random whitespace characters and 
newline characters. Henceforth, this patch handles any such changes.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19419

To: tagorechandanreddy, ngraham, davidedmundson
Cc: plasma-devel, ngraham, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19185: [KRunner, SDDM theme, Logout screen, Login widget] Use the word "Sleep" instead of "Suspend"

[Nathaniel Graham]

ngraham added a comment.


  Good call, thanks!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19185

To: ngraham, #vdg, #plasma, filipf, mart
Cc: rooty, abetts, filipf, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19119: ApplicationPage: include the available version when selecting the source

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Ah, that makes sense. Looks good now!

REPOSITORY
  R134 Discover Software Store

BRANCH
  arcpatch-D19119

REVISION DETAIL
  https://phabricator.kde.org/D19119

To: apol, #discover_software_store, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19502: Add a SearchField and PasswordField component

[Nathaniel Graham]

ngraham added a reviewer: mart.
ngraham added a comment.


  Wow, that was fast. I'm impressed.

INLINE COMMENTS

> PasswordField.qml:25
> +/**
> + * This is a standart password text field.
> + *

`Standart` -> `Standard`

> SearchField.qml:25
> +/**
> + * This is a standart textfield following KDE HIG. Using Ctrl+F as focus
> + * sequence and "Search..." as placeholder text.

`Standart` -> `Standard`

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19502

To: ognarb, #kirigami, ngraham, mart
Cc: apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein

D19419: [KdePlasma-Addons/POTD/NOAA] Fixed RegEx string to suit latest changes on the webpage

[Nathaniel Graham]

ngraham added a comment.


  Can you clarify what problem we're solving here? The NOAA picture of the day 
wallpaper currently works just fine for me.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19419

To: tagorechandanreddy, ngraham, davidedmundson
Cc: plasma-devel, ngraham, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19119: ApplicationPage: include the available version when selecting the source

[Aleix Pol Gonzalez]

apol updated this revision to Diff 53094.
apol added a comment.


  swap order

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19119?vs=51969=53094

BRANCH
  arcpatch-D19119

REVISION DETAIL
  https://phabricator.kde.org/D19119

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: apol, #discover_software_store, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19502: Add a SearchField and PasswordField component

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> PasswordField.qml:51
> +},
> +Kirigami.Action {
> +iconName: "edit-clear"

Looks off that the clear buttons are not aligned. Invert?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19502

To: ognarb, #kirigami, ngraham
Cc: apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein

D19454: Fix errors in kirigami example files

[Aleix Pol Gonzalez]

apol added a comment.


  Others look good to me.

INLINE COMMENTS

> AbstractApplicationWindow.qml:105
>  pageStack: Controls.StackView {
> +function goBack() {
> +console.log("goBack");

Why's that?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19454

To: ognarb, #kirigami
Cc: apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein

D19119: ApplicationPage: include the available version when selecting the source

[Aleix Pol Gonzalez]

apol added a comment.


  Can't add () because both sides add them.
  I forgot to click submit on the screenshot last time (poor phab, was still 
offering it!), will add it now.
  
  F6655279: Screenshot_20190304_023003.png 


REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19119

To: apol, #discover_software_store, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

[Krešimir Čohar]

rooty added a comment.


  The animator causes a little bit of a problem (keep your eye on the Sleep 
button):
  
  F6655268: consequences-of-advanced-spellcasting.mp4 


REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19502: Add a SearchField and PasswordField component

[Carl Schwan]

ognarb created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ognarb requested review of this revision.

REVISION SUMMARY
  Provide a small abstraction over ActionTextField to implement consistent 
standard special text field
  
  **Warning:** I include a placeholder text in this two example, not sure if 
this is correct, because kirigami probably shouldn't include translatable 
content.

TEST PLAN
  Compile, example work

REPOSITORY
  R169 Kirigami

BRANCH
  dev

REVISION DETAIL
  https://phabricator.kde.org/D19502

AFFECTED FILES
  examples/simpleexamples/MultipleColumnsGallery.qml
  kirigami.qrc
  kirigami.qrc.in
  src/controls/ActionTextField.qml
  src/controls/PasswordField.qml
  src/controls/SearchField.qml
  src/kirigamiplugin.cpp
  src/qmldir

To: ognarb
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D19185: [KRunner, SDDM theme, Logout screen, Login widget] Use the word "Sleep" instead of "Suspend"

[Krešimir Čohar]

rooty added a comment.


  P.S. I took the liberty of replacing Suspend with the word Sleep to the user 
prompt screen too e588bebe78d27a92da2db0ba4260c26f76e28743 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19185

To: ngraham, #vdg, #plasma, filipf, mart
Cc: rooty, abetts, filipf, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19214: [sddm-theme] Replace login button label with icon

[Krešimir Čohar]

rooty added a comment.


  In D19214#424106 , @ngraham wrote:
  
  > Hmm, the Kirigami text field doesn't look like that in an app. Must be some 
weird SDDM environment thing?
  >
  > Either way, let's fix the height issue *somehow*. :)
  
  
  It's sorta ugly but what's tripping me up is... why doesn't it get smaller if 
i set pointSize to 1 (and gets bigger if I set it to, say, 32)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19214

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: ngraham, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19214: [sddm-theme] Replace login button label with icon

[Nathaniel Graham]

ngraham added a comment.


  Hmm, the Kirigami text field doesn't look like that in an app. Must be some 
weird SDDM environment thing?
  
  Either way, let's fix the height issue *somehow*. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19214

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: ngraham, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19214: [sddm-theme] Replace login button label with icon

[Krešimir Čohar]

rooty added a comment.


  In D19214#424074 , @ngraham wrote:
  
  > Looks like https://bugs.kde.org/show_bug.cgi?id=399155 has revealed that 
the text field itself just isn't tall enough. Fixing that should fix both the 
bug mentioned above, as well as the hackaround to make the button shorter so 
they're the same height.
  >
  > Let's either fix the issue in the PlasmaComponents text field before we 
land this, or else see if we can port this to use the Kirigami 
`ActionTextField` instead, which should be the correct height.
  
  
  I don't know. The Kirigami field uses a different glow, so I'm not sure which 
one of these is the better solution.
  
  While I understand that this height bug should be fixed, using Kirigami 
actually reveals how tall the field gets 
  F6655104: image.png 
  And it comes out looking big and boxy
  Should we switch to a smaller font size maybe?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19214

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: ngraham, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

[Filip Fila]

filipf added a subscriber: davidedmundson.
filipf added a comment.


  @davidedmundson we have some considerable issues with text opacity failing 
when the logout screen is superimposed over a light background:
  
  F6655046: image.png 
  
  You mentioned something about sending in a Qt patch for this in the bug 
report . Could we use QtRendering 
to work around the issue until the patch lands?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

[Filip Fila]

filipf added a comment.


  In D19478#424055 , @ngraham wrote:
  
  > ...And now that that's landed, I think this can too.
  
  
  I would now wait until after D19479  so 
that we don't necessarily have dark and light circles. I would adjust this 
patch so both circles would look harmonious.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19478

To: filipf, ngraham, #vdg, #plasma, rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [SDDM theme] Add visual feedback when hovering over action buttons

[Filip Fila]

filipf updated this revision to Diff 53089.
filipf added a comment.


  itemOpacity override is not needed after all

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19479?vs=53088=53089

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/logout/LogoutButton.qml

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [SDDM theme] Add visual feedback when hovering over action buttons

[Filip Fila]

filipf updated this revision to Diff 53088.
filipf edited the summary of this revision.
filipf added a comment.


  split SDDM & LockScreen circle opacity settings, override ActionButton.qml 
root 
  opacity, change label top margin in logout screen

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19479?vs=53027=53088

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/logout/LogoutButton.qml

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19214: [sddm-theme] Replace login button label with icon

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Looks like https://bugs.kde.org/show_bug.cgi?id=399155 has revealed that the 
text field itself just isn't tall enough. Fixing that should fix both the bug 
mentioned above, as well as the hackaround to make the button shorter so 
they're the same height.
  
  Let's either fix the issue in the PlasmaComponents text field before we land 
this, or else see if we can port this to use the Kirigami `ActionTextField` 
instead, which should be the correct height.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19214

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: ngraham, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11352: [RFC] Auto ordered systray

[Nathaniel Graham]

ngraham added a comment.


  #plasma  folks? Are we landing this?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  stableSystray2

REVISION DETAIL
  https://phabricator.kde.org/D11352

To: Pitel, #vdg, #plasma, mart
Cc: ngraham, wsdfhjxc, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D19479: [SDDM theme] Add visual feedback when hovering over action buttons

[Krešimir Čohar]

rooty added a comment.


  In D19479#424043 , @ngraham wrote:
  
  > In D19479#424008 , @rooty wrote:
  >
  > > This isn't bad (especially with a top margin) but I actually like the 
subtlety of not having the circles and having them pop up on hovering over them.
  > >
  > > How about using this style for the logout screen and the opacity 0 then 
0.15 for the sddm and lock screens?
  >
  >
  > I think there's some value to having the same UI in all three places. 
However that may just be the side of me talking that looves background 
circles! :-p Mm, such nice background circles...
  
  
  LOL. The circles are fine but I'd rather not include them in the SDDM theme - 
the circle appearing on hover is a very fancy effect. If they're there from the 
getgo the SDDM theme loses the element of surprise ("Wow I didn't know it could 
do that!").
  
  As for the logout screen, I'd place the circles there because of poor 
visibility, not because I think they necessarily look better than circles 
appearing on hover. If we could avoid them and maintain visibility, I'd just as 
soon do that.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19500: [KDirModel] Fix job urls change signal connection

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, dfaure, jtamate.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The private slot declaration for `_k_slotJobUrlsChanged` got removed as part 
of D12095  but the slot never actually 
ported breaking the transfers visible feature.

TEST PLAN
  Signal is emitted properly again when enabled

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19500

AFFECTED FILES
  src/widgets/kdirmodel.cpp

To: broulik, #frameworks, dfaure, jtamate
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

[Nathaniel Graham]

ngraham added a comment.


  ...And now that that's landed, I think this can too.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19478

To: filipf, ngraham, #vdg, #plasma, rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19315: Use ActionTextField to implement the searchField in system settings

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice!
  
  If you're upset about losing the animation, we could add that to the action 
buttons of the `ActionTextField` component itself.

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19315

To: ognarb, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [SDDM theme] Add visual feedback when hovering over action buttons

[Nathaniel Graham]

ngraham added a comment.


  In D19479#424008 , @rooty wrote:
  
  > This isn't bad (especially with a top margin) but I actually like the 
subtlety of not having the circles and having them pop up on hovering over them.
  >
  > How about using this style for the logout screen and the opacity 0 then 
0.15 for the sddm and lock screens?
  
  
  I think there's some value to having the same UI in all three places. However 
that may just be the side of me talking that looves background circles! :-p 
Mm, such nice background circles...

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [SDDM theme] Add visual feedback when hovering over action buttons

[Krešimir Čohar]

rooty added a comment.


  This isn't bad (especially with a top margin) but I actually like the 
subtlety of not having the circles and having them pop up on hovering over them

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19496: [kcm/componentchooser] Remove unused ktimerdialog.{h,cpp}

[Alexander Volkov]

volkov created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
volkov requested review of this revision.

REVISION SUMMARY
  Amend 2f83a4434a888cd17b03af1f9925cbb054256ade 
.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19496

AFFECTED FILES
  kcms/componentchooser/CMakeLists.txt
  kcms/componentchooser/ktimerdialog.cpp
  kcms/componentchooser/ktimerdialog.h

To: volkov
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19214: [sddm-theme] Replace login button label with icon

[Krešimir Čohar]

rooty updated this revision to Diff 53078.
rooty added a comment.


  Rebase

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19214?vs=52355=53078

REVISION DETAIL
  https://phabricator.kde.org/D19214

AFFECTED FILES
  lookandfeel/contents/lockscreen/MainBlock.qml
  sddm-theme/Login.qml

To: rooty, #vdg, #plasma
Cc: ngraham, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

[Krešimir Čohar]

rooty added a comment.


  Considering that there's an outline around the clock and the username now as 
a fallback option, should we add one to the action buttons too?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19468

To: rooty, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[Krešimir Čohar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:458576b2b5db: [sddm-theme] Enlarge user avatar in focus 
(authored by rooty).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19372?vs=53030=53077

REVISION DETAIL
  https://phabricator.kde.org/D19372

AFFECTED FILES
  lookandfeel/contents/components/UserDelegate.qml

To: rooty, #vdg, ngraham
Cc: davidedmundson, abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19460: [powerdevil] Correct labels

[Krešimir Čohar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R122:85ae655bacbb: [powerdevil] Correct labels (authored by 
rooty).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19460?vs=52958=53076

REVISION DETAIL
  https://phabricator.kde.org/D19460

AFFECTED FILES
  kcmodule/activities/activityWidget.ui

To: rooty, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [SDDM theme] Add visual feedback when hovering over action buttons

[Nathaniel Graham]

ngraham added a comment.


  That's beautiful! I love it.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19044: [InlineMessage] Do not draw shadows around the message

[Nathaniel Graham]

ngraham added a comment.


  In D19044#423965 , @Codezela wrote:
  
  > how can I try this in home
  
  
  
https://community.kde.org/Infrastructure/Phabricator#How_to_review_someone_else.27s_patch
  
  If you need further assistance, please ask in the `#kde-devel` channel on IRC 
or Matrix.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19044

To: filipf, #vdg, #kirigami, ngraham, mart
Cc: Codezela, rooty, ndavis, mart, abetts, plasma-devel, domson, dkardarakos, 
apol, davidedmundson, hein

D19044: [InlineMessage] Do not draw shadows around the message

[Hazem Salem]

Codezela added a comment.


  can we make this massages full width borderless total flat
  how can I try this in home
  sorry I am new in this things

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19044

To: filipf, #vdg, #kirigami, ngraham, mart
Cc: Codezela, rooty, ndavis, mart, abetts, plasma-devel, domson, dkardarakos, 
apol, davidedmundson, hein

D19479: [SDDM theme] Add visual feedback when hovering over action buttons

[Filip Fila]

filipf added a comment.


  Changing this component would affect all 3 screens. The logout screen is 
trickier though due to key presses.
  
  What if we did this?
  
  **Login screen
  **F6654023: sddmButtons-2019-03-03_18.20.49 

  
  **Lock screen
  **F6654024: sddmButtons-2019-03-03_18.21.26 

  
  **Logout screen
  **F6654025: sddmButtons-2019-03-03_18.22.07 


REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Perfect. Shipit!
  
  FWIW I think being explicit is better than implicit when there's any possible 
chance of confusion or misunderstanding.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D19372

REVISION DETAIL
  https://phabricator.kde.org/D19372

To: rooty, #vdg, ngraham
Cc: davidedmundson, abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19479: [SDDM theme] Add visual feedback when hovering over action buttons

[Nathaniel Graham]

ngraham added a comment.


  On the logout screen, navigating using the arrow keys should move the 
background circle too.
  
  But in general I think his is actually really great. It solves the problem 
perfectly and it looks good. On the downside, it doesn't particularly look like 
the other hover effect used for any other button, including the ones on the 
lock and login screens.
  
  Thoughts?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

[Nathaniel Graham]

ngraham added a comment.


  In D19186#423597 , @aspotashev 
wrote:
  
  > Hi Nate,
  >
  > You missed this one at daemon/actions/bundled/suspendsessionconfig.cpp:88:
  >
  >   m_comboBox->addItem(QIcon::fromTheme("system-suspend-hybrid"), 
i18n("Hybrid suspend"), (uint)SuspendSession::SuspendHybridMode);
  >   
  >   
  
  
  Good call. Fixed in 8ad3c3c8ba3d5b2c81bbc884f9a272a25da163c3 


REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19186

To: ngraham, #vdg, #plasma, broulik, filipf, mart
Cc: aspotashev, filipf, mart, ltoscano, abetts, aacid, plasma-devel, 
kde-doc-english, jraleigh, gennad, GB_2, ragreen, Pitel, ZrenBot, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19301: Use Kirigami.ActionTextField for the SearchField

[Nathaniel Graham]

ngraham added a comment.


  Oops, so it does!

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19301

To: ognarb, #discover_software_store, ngraham
Cc: ngraham, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D19434: Change entry of Endpoint UI

[Nathaniel Graham]

ngraham added a comment.


  In D19434#423613 , @andersonbruce 
wrote:
  
  > My preference is to only use a spinbox for entries with less than 100 
possible values.  I believe that the up/down arrows give the impression that 
clicking on them is the "proper" method of selecting a value and while some 
people know that you can type in a value into a spinbox, I believe that there 
are others who do not and I really don't want users to be metaphorically 
cursing my name when they are trying to click their way up to a port number of 
say, 23517.
  
  
  I would tend to agree.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D19434

To: andersonbruce, jgrulich
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19460: [powerdevil] Correct labels

[Krešimir Čohar]

rooty marked 2 inline comments as done.
rooty added inline comments.

INLINE COMMENTS

> ngraham wrote in activityWidget.ui:72
> Eh, let's make the English teachers happy. :)

Now let's only hope they'll switch to Plasma :D

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19460

To: rooty, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart